Skip to contentSkip to conversation

ARM: dts: at91: sama7g5ek: enable pull-up for serial debug line

PATCH New Eugen Hristev 1 participant 2 messages Jan 28, 2021 – Feb 11, 2021 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: at91: sama7g5ek: enable pull-up for serial debug line

If the serial tx/rx are floating, it can happen that bogus characters are detected on the line at boot time. This leads to U-boot accidentally thinking someone pressed a key to stop autoboot, thus stopping booting process. This can happen if the serial cable is not connected. There are hardware pull-ups on the board connected to serial cable VBUS.
To solve this when the cable is not plugged, enable internal pull-ups as well for the tx/rx lines.

---
 arch/arm/dts/sama7g5ek.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/dts/sama7g5ek.dts +1 -1
index ff9c9eb45c..3a4fdd38a5 100644
@@ -122,7 +122,7 @@
 	pinctrl_flx3_default: flx3_default {
 		pinmux = <PIN_PD16__FLEXCOM3_IO0>,
 			 <PIN_PD17__FLEXCOM3_IO1>;
-		bias-disable;
+		bias-pull-up;
 	};
 
 	pinctrl_sdmmc0_cmd_data_default: sdmmc0_cmd_data_default {
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/1 ARM: dts: at91: sama7g5ek: enable pull-up for serial debug line

Quoted 19 lines · Eugen Hristev

If the serial tx/rx are floating, it can happen that bogus characters are detected on the line at boot time. This leads to U-boot accidentally thinking someone pressed a key to stop autoboot, thus stopping booting process. This can happen if the serial cable is not connected. There are hardware pull-ups on the board connected to serial cable VBUS.
To solve this when the cable is not plugged, enable internal pull-ups as well for the tx/rx lines.

---
  arch/arm/dts/sama7g5ek.dts | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/dts/sama7g5ek.dts +0 -0
index ff9c9eb45c..3a4fdd38a5 100644

arch/arm/dts/sama7g5ek.dts line 128

Quoted 8 lines
arch/arm/dts/sama7g5ek.dts +1 -1
@@ -122,7 +122,7 @@
  	pinctrl_flx3_default: flx3_default {
  		pinmux = <PIN_PD16__FLEXCOM3_IO0>,
  			 <PIN_PD17__FLEXCOM3_IO1>;
-		bias-disable;
+		bias-pull-up;
  	};
 
  	pinctrl_sdmmc0_cmd_data_default: sdmmc0_cmd_data_default {

Applied to u-boot-atmel/master