Skip to contentSkip to conversation

arago.conf: disable buildpaths QA errors in meta-qt5

PATCH In review Denys Dmytriyenko 2 participants 9 messages Jul 16, 2024 – Jul 17, 2024 2 messages not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arago.conf: disable buildpaths QA errors in meta-qt5

From: Denys Dmytriyenko <[email protected]>

As meta-qt5 is not going to fix the issues causing the errors:

https://github.com/meta-qt5/meta-qt5/issues/575

---
 meta-arago-distro/conf/distro/arago.conf | 4 ++++
 1 file changed, 4 insertions(+)
meta-arago-distro/conf/distro/arago.conf +4 -0
index deaa8c02..716068ba 100644
@@ -188,3 +188,7 @@ LICENSE_FLAGS_ACCEPTED = "commercial_gst-ffmpeg commercial_gstreamer1.0-libav co
 
 # Do not package own copy of perl into devkit, rely on host one
 ASSUME_PROVIDED += "nativesdk-perl"
+
+# https://github.com/meta-qt5/meta-qt5/issues/575
+ERROR_QA:remove:layer-qt5-layer = "buildpaths"
+WARN_QA:append:layer-qt5-layer = " buildpaths"
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/1 ti-llvm: adopt an LLVM fix for buildpaths errors

From: Denys Dmytriyenko <[email protected]>

Make sure llvm-configs doesn't have absolute build paths.

---
 meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb | 5 +++++
 1 file changed, 5 insertions(+)
meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb +5 -0
index 4b990b7f..810c603b 100644
@@ -62,6 +62,11 @@ EXTRA_OECONF += " --enable-targets="host,arm,c6000,msp430" \
 
 EXTRA_OEMAKE += "LIBXML2_INC="${LIBXML2_INC}" LIBXML2_LIBS="${LIBXML2_LIBS}""
 
+# patch out build host paths for reproducibility
+do_compile:prepend() {
+        sed -i -e "s,${WORKDIR},,g" ${LLVM_BUILD_DIR}/tools/llvm-config/Release/BuildVariables.inc
+}
+
 do_compile:class-native() {
   cd ${LLVM_BUILD_DIR}
 
Signature · 1 line
2.25.1
#2 lore raw

Re: [meta-arago] [master][PATCH] ti-llvm: adopt an LLVM fix for buildpaths errors

Quoted 15 lines · Denys Dmytriyenko

From: Denys Dmytriyenko <[email protected]>

Make sure llvm-configs doesn't have absolute build paths.

---
  meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb | 5 +++++
  1 file changed, 5 insertions(+)
meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb +0 -0
index 4b990b7f..810c603b 100644
@@ -62,6 +62,11 @@ EXTRA_OECONF += " --enable-targets="host,arm,c6000,msp430" \
 

meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb EXTRA_OECONF += " --enable-targets="host,arm,c6000,msp430" \ · line 72

Quoted 10 lines
meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb +5 -0
  EXTRA_OEMAKE += "LIBXML2_INC="${LIBXML2_INC}" LIBXML2_LIBS="${LIBXML2_LIBS}""
 
+# patch out build host paths for reproducibility
+do_compile:prepend() {
+        sed -i -e "s,${WORKDIR},,g" ${LLVM_BUILD_DIR}/tools/llvm-config/Release/BuildVariables.inc
+}
+
  do_compile:class-native() {
    cd ${LLVM_BUILD_DIR}
 

I'm getting build errors with this.

native:

sed: can't read /scratch/jenkins_builds/arago-master-wip/build/build/arago-tmp-default-glibc/work/x86_64-linux/ti-llvm3.6-native/3.6/llvm-3.6.build/tools/llvm-config/Release/BuildVariables.inc: No such file or directory

nativesdk:

sed: can't read /scratch/jenkins_builds/arago-master-wip/build/build/arago-tmp-default-glibc/work/x86_64-nativesdk-arago-linux/nativesdk-ti-llvm3.6/3.6/llvm-3.6.build/tools/llvm-config/Release/BuildVariables.inc: No such file or directory

Signature · 3 lines
Ryan Eatmon                [email protected]
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS

A message that is not in the archive (sent off-list or not yet received): [email protected]

#4 lore raw

Re: [meta-arago] [master][PATCH] ti-llvm: adopt an LLVM fix for buildpaths errors

Quoted 30 lines · Ryan Eatmon via lists.yoctoproject.org
Quoted 22 lines · Denys Dmytriyenko

From: Denys Dmytriyenko <[email protected]>

Make sure llvm-configs doesn't have absolute build paths.

---
  meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb | 5 +++++

  1 file changed, 5 insertions(+)
meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb +0 -1
index 4b990b7f..810c603b 100644
@@ -62,6 +62,11 @@ EXTRA_OECONF += " 
--enable-targets="host,arm,c6000,msp430" \

  EXTRA_OEMAKE += "LIBXML2_INC="${LIBXML2_INC}" LIBXML2_LIBS="${LIBXML2_LIBS}""

meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb +3 -0
+# patch out build host paths for reproducibility
+do_compile:prepend() {
+        sed -i -e "s,${WORKDIR},,g" 

${LLVM_BUILD_DIR}/tools/llvm-config/Release/BuildVariables.inc

meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb +2 -0
+}
+
Quoted 2 lines

  do_compile:class-native() {
    cd ${LLVM_BUILD_DIR}

I'm getting build errors with this.

Quoted 8 lines

native:

sed: can't read /scratch/jenkins_builds/arago-master-wip/build/build/arago-tmp-default-glibc/work/x86_64-linux/ti-llvm3.6-native/3.6/llvm-3.6.build/tools/llvm-config/Release/BuildVariables.inc: No such file or directory

nativesdk:

sed: can't read /scratch/jenkins_builds/arago-master-wip/build/build/arago-tmp-default-glibc/work/x86_64-nativesdk-arago-linux/nativesdk-ti-llvm3.6/3.6/llvm-3.6.build/tools/llvm-config/Release/BuildVariables.inc: No such file or directory

I think that during the build it creates this file, but before the builds the files does not exist yet. Maybe you tested this against a built directory where the file existed but from a clean dir it fails?

Signature · 3 lines
Ryan Eatmon                [email protected]
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS

A message that is not in the archive (sent off-list or not yet received): [email protected]

#6 lore raw

Re: [meta-arago] [master][PATCH] ti-llvm: adopt an LLVM fix for buildpaths errors

Quoted 35 lines · Ryan Eatmon via lists.yoctoproject.org
Quoted 32 lines · Ryan Eatmon via lists.yoctoproject.org
Quoted 22 lines · Denys Dmytriyenko

From: Denys Dmytriyenko <[email protected]>

Make sure llvm-configs doesn't have absolute build paths.

---
  meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb | 5 +++++

  1 file changed, 5 insertions(+)
meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb +0 -1
index 4b990b7f..810c603b 100644
@@ -62,6 +62,11 @@ EXTRA_OECONF += " 
--enable-targets="host,arm,c6000,msp430" \

  EXTRA_OEMAKE += "LIBXML2_INC="${LIBXML2_INC}" LIBXML2_LIBS="${LIBXML2_LIBS}""

meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb +3 -0
+# patch out build host paths for reproducibility
+do_compile:prepend() {
+        sed -i -e "s,${WORKDIR},,g" 

${LLVM_BUILD_DIR}/tools/llvm-config/Release/BuildVariables.inc

meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb +2 -0
+}
+
Quoted 2 lines

  do_compile:class-native() {
    cd ${LLVM_BUILD_DIR}

I'm getting build errors with this.

native:

Quoted 9 lines
Quoted 6 lines

sed: can't read /scratch/jenkins_builds/arago-master-wip/build/build/arago-tmp-default-glibc/work/x86_64-linux/ti-llvm3.6-native/3.6/llvm-3.6.build/tools/llvm-config/Release/BuildVariables.inc: No such file or directory

nativesdk:

sed: can't read /scratch/jenkins_builds/arago-master-wip/build/build/arago-tmp-default-glibc/work/x86_64-nativesdk-arago-linux/nativesdk-ti-llvm3.6/3.6/llvm-3.6.build/tools/llvm-config/Release/BuildVariables.inc: No such file or directory

I think that during the build it creates this file, but before the builds the files does not exist yet.  Maybe you tested this against a built directory where the file existed but from a clean dir it fails?

Also, it looks the contents of the BuildVariables.inc might be in a "bad" state with this change. But I could be wrong as I don't know how all of this package works.

#define LLVM_SRC_ROOT "/git"
#define LLVM_OBJ_ROOT "/llvm-3.6.build"

By just replacing the WORKDIR with "" we are pointing this file to the root directory where I doubt these things will be living. Again, without knowing how this package works and uses those two variables I can't speak as to the correctness of this. I agree it fixes the buildpaths issue, but does it break the software package at that point?

Signature · 3 lines
Ryan Eatmon                [email protected]
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS
#7 lore raw

Re: [meta-arago] [master][PATCH] ti-llvm: adopt an LLVM fix for buildpaths errors

Quoted 63 lines · Ryan Eatmon
Quoted 43 lines · Ryan Eatmon via lists.yoctoproject.org
Quoted 40 lines · Ryan Eatmon via lists.yoctoproject.org
Quoted 25 lines · Denys Dmytriyenko

From: Denys Dmytriyenko <[email protected]>

Make sure llvm-configs doesn't have absolute build paths.

---
  meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb | 5 +++++

  1 file changed, 5 insertions(+)

diff --git a/meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb b/meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb index 4b990b7f..810c603b 100644

meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb +0 -1
@@ -62,6 +62,11 @@ EXTRA_OECONF += "
--enable-targets="host,arm,c6000,msp430" \

  EXTRA_OEMAKE += "LIBXML2_INC="${LIBXML2_INC}"
LIBXML2_LIBS="${LIBXML2_LIBS}""

meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb +3 -0
+# patch out build host paths for reproducibility
+do_compile:prepend() {
+        sed -i -e "s,${WORKDIR},,g"

${LLVM_BUILD_DIR}/tools/llvm-config/Release/BuildVariables.inc

meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb +2 -0
+}
+
Quoted 2 lines

  do_compile:class-native() {
    cd ${LLVM_BUILD_DIR}

I'm getting build errors with this.

native:

sed: can't read /scratch/jenkins_builds/arago-master-wip/build/build/arago-tmp-default-glibc/work/x86_64-linux/ti-llvm3.6-native/3.6/llvm-3.6.build/tools/llvm-config/Release/BuildVariables.inc:
No such file or directory

nativesdk:

Quoted 9 lines
Quoted 3 lines

sed: can't read /scratch/jenkins_builds/arago-master-wip/build/build/arago-tmp-default-glibc/work/x86_64-nativesdk-arago-linux/nativesdk-ti-llvm3.6/3.6/llvm-3.6.build/tools/llvm-config/Release/BuildVariables.inc:
No such file or directory

I think that during the build it creates this file, but before the builds the files does not exist yet.  Maybe you tested this against a built directory where the file existed but from a clean dir it fails?

Also, it looks the contents of the BuildVariables.inc might be in a "bad" state with this change. But I could be wrong as I don't know how all of this package works.

#define LLVM_SRC_ROOT "/git"
#define LLVM_OBJ_ROOT "/llvm-3.6.build"

Quoted 6 lines

By just replacing the WORKDIR with "" we are pointing this file to the root directory where I doubt these things will be living. Again, without knowing how this package works and uses those two variables I can't speak as to the correctness of this. I agree it fixes the buildpaths issue, but does it break the software package at that point?

This is exactly what OE-Core does with upstream LLVM.

Signature · 1 line
Denys
#8 lore raw

Re: [meta-arago] [master][PATCH] ti-llvm: adopt an LLVM fix for buildpaths errors

Quoted 64 lines · Denys Dmytriyenko
Quoted 63 lines · Ryan Eatmon
Quoted 43 lines · Ryan Eatmon via lists.yoctoproject.org
Quoted 40 lines · Ryan Eatmon via lists.yoctoproject.org
Quoted 23 lines · Denys Dmytriyenko

From: Denys Dmytriyenko <[email protected]>

Make sure llvm-configs doesn't have absolute build paths.

---
   meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb | 5 +++++
   1 file changed, 5 insertions(+)

diff --git a/meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb b/meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb index 4b990b7f..810c603b 100644

meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb +0 -1
@@ -62,6 +62,11 @@ EXTRA_OECONF += "
--enable-targets="host,arm,c6000,msp430" \
   EXTRA_OEMAKE += "LIBXML2_INC="${LIBXML2_INC}"

LIBXML2_LIBS="${LIBXML2_LIBS}""

meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb +3 -0
+# patch out build host paths for reproducibility
+do_compile:prepend() {
+        sed -i -e "s,${WORKDIR},,g"

${LLVM_BUILD_DIR}/tools/llvm-config/Release/BuildVariables.inc

meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb EXTRA_OECONF += " --enable-targets="host,arm,c6000,msp430" \ · line 71

Quoted 4 lines
meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb +2 -0
+}
+
   do_compile:class-native() {
     cd ${LLVM_BUILD_DIR}

I'm getting build errors with this.

native:

sed: can't read /scratch/jenkins_builds/arago-master-wip/build/build/arago-tmp-default-glibc/work/x86_64-linux/ti-llvm3.6-native/3.6/llvm-3.6.build/tools/llvm-config/Release/BuildVariables.inc:
No such file or directory

nativesdk:

Quoted 9 lines
Quoted 3 lines

sed: can't read /scratch/jenkins_builds/arago-master-wip/build/build/arago-tmp-default-glibc/work/x86_64-nativesdk-arago-linux/nativesdk-ti-llvm3.6/3.6/llvm-3.6.build/tools/llvm-config/Release/BuildVariables.inc:
No such file or directory

I think that during the build it creates this file, but before the builds the files does not exist yet.  Maybe you tested this against a built directory where the file existed but from a clean dir it fails?

Also, it looks the contents of the BuildVariables.inc might be in a "bad" state with this change. But I could be wrong as I don't know how all of this package works.

#define LLVM_SRC_ROOT "/git"
#define LLVM_OBJ_ROOT "/llvm-3.6.build"

Quoted 9 lines
Quoted 6 lines

By just replacing the WORKDIR with "" we are pointing this file to the root directory where I doubt these things will be living. Again, without knowing how this package works and uses those two variables I can't speak as to the correctness of this. I agree it fixes the buildpaths issue, but does it break the software package at that point?

This is exactly what OE-Core does with upstream LLVM.

Good enough for me then. =)

Signature · 3 lines
Ryan Eatmon                [email protected]
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS
#9 lore raw

Re: [meta-arago] [master][PATCH] ti-llvm: adopt an LLVM fix for buildpaths errors

Quoted 74 lines · Ryan Eatmon
Quoted 71 lines · Denys Dmytriyenko
Quoted 69 lines · Ryan Eatmon
Quoted 43 lines · Ryan Eatmon via lists.yoctoproject.org
Quoted 40 lines · Ryan Eatmon via lists.yoctoproject.org
Quoted 25 lines · Denys Dmytriyenko

From: Denys Dmytriyenko <[email protected]>

Make sure llvm-configs doesn't have absolute build paths.

---
  meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb | 5 +++++

  1 file changed, 5 insertions(+)

diff --git a/meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb b/meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb index 4b990b7f..810c603b 100644

meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb +0 -1
@@ -62,6 +62,11 @@ EXTRA_OECONF += "
--enable-targets="host,arm,c6000,msp430" \

  EXTRA_OEMAKE += "LIBXML2_INC="${LIBXML2_INC}"
LIBXML2_LIBS="${LIBXML2_LIBS}""

meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb +3 -0
+# patch out build host paths for reproducibility
+do_compile:prepend() {
+        sed -i -e "s,${WORKDIR},,g"

${LLVM_BUILD_DIR}/tools/llvm-config/Release/BuildVariables.inc

meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb +2 -0
+}
+
Quoted 2 lines

  do_compile:class-native() {
    cd ${LLVM_BUILD_DIR}

I'm getting build errors with this.

native:

sed: can't read /scratch/jenkins_builds/arago-master-wip/build/build/arago-tmp-default-glibc/work/x86_64-linux/ti-llvm3.6-native/3.6/llvm-3.6.build/tools/llvm-config/Release/BuildVariables.inc:
No such file or directory

nativesdk:

Quoted 9 lines
Quoted 3 lines

sed: can't read /scratch/jenkins_builds/arago-master-wip/build/build/arago-tmp-default-glibc/work/x86_64-nativesdk-arago-linux/nativesdk-ti-llvm3.6/3.6/llvm-3.6.build/tools/llvm-config/Release/BuildVariables.inc:
No such file or directory

I think that during the build it creates this file, but before the builds the files does not exist yet.  Maybe you tested this against a built directory where the file existed but from a clean dir it fails?

Also, it looks the contents of the BuildVariables.inc might be in a "bad" state with this change. But I could be wrong as I don't know how all of this package works.

#define LLVM_SRC_ROOT "/git"
#define LLVM_OBJ_ROOT "/llvm-3.6.build"

By just replacing the WORKDIR with "" we are pointing this file to the root directory where I doubt these things will be living. Again, without knowing how this package works and uses those two variables I can't speak as to the correctness of this. I agree it fixes the buildpaths issue, but does it break the software package at that point?

Quoted 4 lines
Quoted 2 lines

This is exactly what OE-Core does with upstream LLVM.

Good enough for me then. =)

https://git.openembedded.org/openembedded-core/commit/?h=master-next&id=55c1cccff5afc1230d3c2287bc0fdaa579bf2743

The only difference is that much newer LLVM 18.1.8 (vs. 3.6 here) apparently generates BuildVariables.inc file in do_configure() and not in do_compile() so it already exists for the sed command...

Signature · 1 line
Denys
#10 lore raw
In reply to Denys Dmytriyenko
Quoted 16 lines · Denys Dmytriyenko

From: Denys Dmytriyenko <[email protected]>

As meta-qt5 is not going to fix the issues causing the errors:

https://github.com/meta-qt5/meta-qt5/issues/575

---
  meta-arago-distro/conf/distro/arago.conf | 4 ++++
  1 file changed, 4 insertions(+)
meta-arago-distro/conf/distro/arago.conf +0 -0
index deaa8c02..716068ba 100644

meta-arago-distro/conf/distro/arago.conf LICENSE_FLAGS_ACCEPTED = "commercial_gst-ffmpeg commercial_gstreamer1.0-libav co · line 194

Quoted 7 lines
meta-arago-distro/conf/distro/arago.conf +4 -0
@@ -188,3 +188,7 @@ LICENSE_FLAGS_ACCEPTED = "commercial_gst-ffmpeg commercial_gstreamer1.0-libav co
 
  # Do not package own copy of perl into devkit, rely on host one
  ASSUME_PROVIDED += "nativesdk-perl"
+
+# https://github.com/meta-qt5/meta-qt5/issues/575
+ERROR_QA:remove:layer-qt5-layer = "buildpaths"
+WARN_QA:append:layer-qt5-layer = " buildpaths"

Yeah, I saw that and thought this should be the answer. Since meta-arago is not seeking compatible status this should be acceptable.

Signature · 3 lines
Ryan Eatmon                [email protected]
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS