Skip to contentSkip to conversation

dt-bindings: hwmon: Add max6639

PATCH Superseded Naresh Solanki 3 participants 14 messages Apr 20, 2023 – Jul 20, 2023

Subsystems (2)

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 dt-bindings: hwmon: Add max6639

From: Marcello Sylvester Bauer <[email protected]>

Add Devicetree binding documentation for Maxim MAX6639 temperature monitor with PWM fan-speed controller.

...
Changes in V2:
- Update subject
- Drop blank lines

---
 .../bindings/hwmon/maxim,max6639.yaml         | 52 +++++++++++++++++++
 1 file changed, 52 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml
Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +52 -0
new file mode 100644
index 000000000000..1aaedfd7cee0
@@ -0,0 +1,52 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/hwmon/maxim,max6639.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Maxim max6639
+
+maintainers:
+  - Naresh Solanki <[email protected]>
+
+description: |
+  The MAX6639 is a 2-channel temperature monitor with dual, automatic, PWM
+  fan-speed controller.  It monitors its own temperature and one external
+  diode-connected transistor or the temperatures of two external diode-connected
+  transistors, typically available in CPUs, FPGAs, or GPUs.
+
+  Datasheets:
+    https://datasheets.maximintegrated.com/en/ds/MAX6639-MAX6639F.pdf
+
+properties:
+  compatible:
+    enum:
+      - maxim,max6639
+
+  reg:
+    maxItems: 1
+
+  '#address-cells':
+    const: 1
+
+  '#size-cells':
+    const: 0
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+      #address-cells = <1>;
+      #size-cells = <0>;
+
+      fan-controller@10 {
+        compatible = "maxim,max6639";
+        reg = <0x10>;
+      };
+    };
+...

base-commit: b8610e0fe08f1476895f141be60f8dd842f0adac

Signature · 1 line
2.39.1
#1 lore raw

PATCH v2 2/2 hwmon: (max6639) Add compatible string

Use maxim,max6639 as compatible string for the driver.

...
Changes in V2:
- None, Updated DT patch

---
 drivers/hwmon/max6639.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/hwmon/max6639.c +6 -0
index 9b895402c80d..ada410bfb7b6 100644
@@ -618,11 +618,17 @@ MODULE_DEVICE_TABLE(i2c, max6639_id);
 
 static DEFINE_SIMPLE_DEV_PM_OPS(max6639_pm_ops, max6639_suspend, max6639_resume);
 
+static const struct of_device_id max6639_of_match[] = {
+	{ .compatible = "maxim,max6639", },
+	{ },
+};
+
 static struct i2c_driver max6639_driver = {
 	.class = I2C_CLASS_HWMON,
 	.driver = {
 		   .name = "max6639",
 		   .pm = pm_sleep_ptr(&max6639_pm_ops),
+		   .of_match_table = max6639_of_match,
 		   },
 	.probe_new = max6639_probe,
 	.id_table = max6639_id,
Signature · 1 line
2.39.1
#2 lore raw
In reply to Naresh Solanki
Quoted 8 lines · Naresh Solanki

From: Marcello Sylvester Bauer <[email protected]>

Add Devicetree binding documentation for Maxim MAX6639 temperature monitor with PWM fan-speed controller.

...

Wrong syntax. '...' do not mean anything, it's ---

Quoted 14 lines

Changes in V2:
- Update subject
- Drop blank lines

---
 .../bindings/hwmon/maxim,max6639.yaml         | 52 +++++++++++++++++++
 1 file changed, 52 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml
Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +0 -0
new file mode 100644
index 000000000000..1aaedfd7cee0

Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml line 7

Quoted 7 lines
Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +7 -0
@@ -0,0 +1,52 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/hwmon/maxim,max6639.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Maxim max6639

What is this device? fan controller?

Quoted 16 lines
Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +16 -0
+
+maintainers:
+  - Naresh Solanki <[email protected]>
+
+description: |
+  The MAX6639 is a 2-channel temperature monitor with dual, automatic, PWM
+  fan-speed controller.  It monitors its own temperature and one external
+  diode-connected transistor or the temperatures of two external diode-connected
+  transistors, typically available in CPUs, FPGAs, or GPUs.
+
+  Datasheets:
+    https://datasheets.maximintegrated.com/en/ds/MAX6639-MAX6639F.pdf
+
+properties:
+  compatible:
+    enum:

Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml line 33

Quoted 10 lines
Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +10 -0
+      - maxim,max6639
+
+  reg:
+    maxItems: 1
+
+  '#address-cells':
+    const: 1
+
+  '#size-cells':
+    const: 0

Why do you need these two properties?

Anyway, the binding looks incomplete. Where are the supplies? Interrupts?

Quoted 20 lines
Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +19 -0
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+      #address-cells = <1>;
+      #size-cells = <0>;
+
+      fan-controller@10 {
+        compatible = "maxim,max6639";
+        reg = <0x10>;
+      };
+    };
+...
Quoted 1 line

base-commit: b8610e0fe08f1476895f141be60f8dd842f0adac

Best regards,
Krzysztof

#3 lore raw

Hi Krzysztof,

Quoted 11 lines · Krzysztof Kozlowski
Quoted 8 lines · Naresh Solanki

From: Marcello Sylvester Bauer <[email protected]>

Add Devicetree binding documentation for Maxim MAX6639 temperature monitor with PWM fan-speed controller.

...

Wrong syntax. '...' do not mean anything, it's ---

Ack

Quoted 9 lines
Quoted 9 lines

Changes in V2:
- Update subject
- Drop blank lines

---
  .../bindings/hwmon/maxim,max6639.yaml         | 52 +++++++++++++++++++
  1 file changed, 52 insertions(+)

create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml

Quoted 15 lines

Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml line 7

Quoted 13 lines
Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +7 -0
new file mode 100644
index 000000000000..1aaedfd7cee0
@@ -0,0 +1,52 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/hwmon/maxim,max6639.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Maxim max6639

What is this device? fan controller?

Yes Fan controller.
Do you want me to update the title here as:
"Maxim MAC6639 2 channel fan controller & temperature monitor" ?

Quoted 21 lines
Quoted 21 lines
Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +20 -0
+
+maintainers:
+  - Naresh Solanki <[email protected]>
+
+description: |
+  The MAX6639 is a 2-channel temperature monitor with dual, automatic, PWM
+  fan-speed controller.  It monitors its own temperature and one external
+  diode-connected transistor or the temperatures of two external diode-connected
+  transistors, typically available in CPUs, FPGAs, or GPUs.
+
+  Datasheets:
+    https://datasheets.maximintegrated.com/en/ds/MAX6639-MAX6639F.pdf
+
+properties:
+  compatible:
+    enum:
+      - maxim,max6639
+
+  reg:
+    maxItems: 1
Quoted 8 lines

Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml line 33

Quoted 6 lines
Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +6 -0
+
+  '#address-cells':
+    const: 1
+
+  '#size-cells':
+    const: 0

Why do you need these two properties?

Ack. Will remove them.

Quoted 2 lines

Anyway, the binding looks incomplete. Where are the supplies? Interrupts?

This patch just adds basic support to the existing platform driver.
Intention is to be able to call the driver from DT with basic initialization from driver the existing driver.

Quoted 21 lines
Quoted 21 lines
Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +19 -0
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+      #address-cells = <1>;
+      #size-cells = <0>;
+
+      fan-controller@10 {
+        compatible = "maxim,max6639";
+        reg = <0x10>;
+      };
+    };
+...
Quoted 5 lines
Quoted 1 line

base-commit: b8610e0fe08f1476895f141be60f8dd842f0adac

Best regards,
Krzysztof

Regards,
Naresh

#4 lore raw
Quoted 23 lines · Naresh Solanki
Quoted 8 lines
Quoted 8 lines

Changes in V2:
- Update subject
- Drop blank lines

---
  .../bindings/hwmon/maxim,max6639.yaml         | 52 +++++++++++++++++++
  1 file changed, 52 insertions(+)

create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml

Quoted 15 lines

Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml line 7

Quoted 13 lines
Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +7 -0
new file mode 100644
index 000000000000..1aaedfd7cee0
@@ -0,0 +1,52 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/hwmon/maxim,max6639.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Maxim max6639

What is this device? fan controller?

Quoted 3 lines

Yes Fan controller.
Do you want me to update the title here as:
"Maxim MAC6639 2 channel fan controller & temperature monitor" ?

Enough would be:
Maxim MAX6639 Fan Controller

Quoted 30 lines
Quoted 22 lines
Quoted 22 lines
Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +20 -0
+
+maintainers:
+  - Naresh Solanki <[email protected]>
+
+description: |
+  The MAX6639 is a 2-channel temperature monitor with dual, automatic, PWM
+  fan-speed controller.  It monitors its own temperature and one external
+  diode-connected transistor or the temperatures of two external diode-connected
+  transistors, typically available in CPUs, FPGAs, or GPUs.
+
+  Datasheets:
+    https://datasheets.maximintegrated.com/en/ds/MAX6639-MAX6639F.pdf
+
+properties:
+  compatible:
+    enum:
+      - maxim,max6639
+
+  reg:
+    maxItems: 1
Quoted 8 lines

Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml line 33

Quoted 6 lines
Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +6 -0
+
+  '#address-cells':
+    const: 1
+
+  '#size-cells':
+    const: 0

Why do you need these two properties?

Quoted 6 lines

Ack. Will remove them.

Quoted 2 lines

Anyway, the binding looks incomplete. Where are the supplies? Interrupts?

This patch just adds basic support to the existing platform driver. Intention is to be able to call the driver from DT with basic initialization from driver the existing driver.

Bindings should be rather complete. Here the datasheet is accessible and few properties quite obvious, so I don't see a reason to skip them.

Best regards,
Krzysztof

#5 lore raw

Hi Krzysztof,

Quoted 25 lines · Krzysztof Kozlowski
Quoted 23 lines · Naresh Solanki
Quoted 23 lines
Quoted 14 lines

Changes in V2:
- Update subject
- Drop blank lines

---
   .../bindings/hwmon/maxim,max6639.yaml         | 52 +++++++++++++++++++
   1 file changed, 52 insertions(+)

create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml

Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +0 -0
new file mode 100644
index 000000000000..1aaedfd7cee0

Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml line 7

Quoted 7 lines
Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +7 -0
@@ -0,0 +1,52 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/hwmon/maxim,max6639.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Maxim max6639

What is this device? fan controller?

Quoted 6 lines
Quoted 3 lines

Yes Fan controller.
Do you want me to update the title here as:
"Maxim MAC6639 2 channel fan controller & temperature monitor" ?

Enough would be:
Maxim MAX6639 Fan Controller

Ack

Quoted 34 lines
Quoted 34 lines
Quoted 24 lines
Quoted 24 lines
Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +20 -0
+
+maintainers:
+  - Naresh Solanki <[email protected]>
+
+description: |
+  The MAX6639 is a 2-channel temperature monitor with dual, automatic, PWM
+  fan-speed controller.  It monitors its own temperature and one external
+  diode-connected transistor or the temperatures of two external diode-connected
+  transistors, typically available in CPUs, FPGAs, or GPUs.
+
+  Datasheets:
+    https://datasheets.maximintegrated.com/en/ds/MAX6639-MAX6639F.pdf
+
+properties:
+  compatible:
+    enum:
+      - maxim,max6639
+
+  reg:
+    maxItems: 1
Quoted 8 lines

Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml line 33

Quoted 6 lines
Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +6 -0
+
+  '#address-cells':
+    const: 1
+
+  '#size-cells':
+    const: 0

Why do you need these two properties?

Ack. Will remove them.

Quoted 1 line
Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Anyway, the binding looks incomplete. Where are the supplies? Interrupts?

This patch just adds basic support to the existing platform driver. Intention is to be able to call the driver from DT with basic initialization from driver the existing driver.

Bindings should be rather complete. Here the datasheet is accessible and few properties quite obvious, so I don't see a reason to skip them.

I agree with you. But currently the driver which is already merged doesn't has it implemented. And will be working on separate patch to include this later.

Quoted 5 lines

Best regards,
Krzysztof

Regards,
Naresh.

#6 lore raw

Hi Krzysztof,

Quoted 74 lines · Naresh Solanki

Hi Krzysztof,

Quoted 26 lines · Krzysztof Kozlowski
Quoted 24 lines · Naresh Solanki
Quoted 24 lines
Quoted 15 lines

Changes in V2:
- Update subject
- Drop blank lines
---
   .../bindings/hwmon/maxim,max6639.yaml         | 52
+++++++++++++++++++

   1 file changed, 52 insertions(+)

   create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml

Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +0 -0
new file mode 100644
index 000000000000..1aaedfd7cee0

Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml line 7

Quoted 7 lines
Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +7 -0
@@ -0,0 +1,52 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/hwmon/maxim,max6639.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Maxim max6639

What is this device? fan controller?

Quoted 6 lines
Quoted 3 lines

Yes Fan controller.
Do you want me to update the title here as:
"Maxim MAC6639 2 channel fan controller & temperature monitor" ?

Enough would be:
Maxim MAX6639 Fan Controller

Ack

Quoted 38 lines
Quoted 38 lines
Quoted 27 lines
Quoted 27 lines
Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +6 -0
+
+maintainers:
+  - Naresh Solanki <[email protected]>
+
+description: |
+  The MAX6639 is a 2-channel temperature monitor with dual, 

automatic, PWM
+  fan-speed controller.  It monitors its own temperature and one external
+  diode-connected transistor or the temperatures of two external diode-connected
+  transistors, typically available in CPUs, FPGAs, or GPUs.

Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +11 -0
+
+  Datasheets:
+    https://datasheets.maximintegrated.com/en/ds/MAX6639-MAX6639F.pdf
+
+properties:
+  compatible:
+    enum:
+      - maxim,max6639
+
+  reg:
+    maxItems: 1
Quoted 8 lines

Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml line 33

Quoted 6 lines
Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +6 -0
+
+  '#address-cells':
+    const: 1
+
+  '#size-cells':
+    const: 0

Why do you need these two properties?

Ack. Will remove them.

Quoted 2 lines

Anyway, the binding looks incomplete. Where are the supplies? Interrupts?

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

This patch just adds basic support to the existing platform driver. Intention is to be able to call the driver from DT with basic initialization from driver the existing driver.

Bindings should be rather complete. Here the datasheet is accessible and few properties quite obvious, so I don't see a reason to skip them.

I agree with you. But currently the driver which is already merged doesn't has it implemented. And will be working on separate patch to include this later.

Please let me know if this approach is acceptable, or if there are any other suggestions or concerns that you have. Thanks,
Naresh

Quoted 8 lines
Quoted 5 lines

Best regards,
Krzysztof

Regards,
Naresh.

#7 lore raw
Quoted 85 lines · Naresh Solanki

Hi Krzysztof,

Quoted 82 lines · Naresh Solanki

Hi Krzysztof,

Quoted 29 lines · Krzysztof Kozlowski
Quoted 27 lines · Naresh Solanki
Quoted 27 lines
Quoted 18 lines

Changes in V2:
- Update subject
- Drop blank lines
---
   .../bindings/hwmon/maxim,max6639.yaml         | 52
+++++++++++++++++++

   1 file changed, 52 insertions(+)

   create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml

(quoted diff) +0 -0

a/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml b/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file mode 100644
index 000000000000..1aaedfd7cee0

Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml line 7

Quoted 7 lines
Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +7 -0
@@ -0,0 +1,52 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/hwmon/maxim,max6639.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Maxim max6639

What is this device? fan controller?

Quoted 6 lines
Quoted 3 lines

Yes Fan controller.
Do you want me to update the title here as:
"Maxim MAC6639 2 channel fan controller & temperature monitor" ?

Enough would be:
Maxim MAX6639 Fan Controller

Ack

Quoted 43 lines
Quoted 42 lines
Quoted 27 lines
Quoted 27 lines
Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +6 -0
+
+maintainers:
+  - Naresh Solanki <[email protected]>
+
+description: |
+  The MAX6639 is a 2-channel temperature monitor with dual, 

automatic, PWM
+  fan-speed controller.  It monitors its own temperature and one external
+  diode-connected transistor or the temperatures of two external diode-connected
+  transistors, typically available in CPUs, FPGAs, or GPUs.

Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +11 -0
+
+  Datasheets:
+    https://datasheets.maximintegrated.com/en/ds/MAX6639-MAX6639F.pdf
+
+properties:
+  compatible:
+    enum:
+      - maxim,max6639
+
+  reg:
+    maxItems: 1
Quoted 8 lines

Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml line 33

Quoted 6 lines
Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +6 -0
+
+  '#address-cells':
+    const: 1
+
+  '#size-cells':
+    const: 0

Why do you need these two properties?

Ack. Will remove them.

Quoted 3 lines

Anyway, the binding looks incomplete. Where are the supplies? Interrupts?

This patch just adds basic support to the existing platform driver. Intention is to be able to call the driver from DT with basic initialization from driver the existing driver.

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

Bindings should be rather complete. Here the datasheet is accessible and few properties quite obvious, so I don't see a reason to skip them.

I agree with you. But currently the driver which is already merged doesn't has it implemented.
And will be working on separate patch to include this later.

Please let me know if this approach is acceptable, or if there are any other suggestions or concerns that you have.

You are adding new bindings, so what does the driver has to do with it?

Best regards,
Krzysztof

#8 lore raw

Hi Krzysztof,

Quoted 88 lines · Krzysztof Kozlowski
Quoted 87 lines · Naresh Solanki

Hi Krzysztof,

Quoted 84 lines · Naresh Solanki

Hi Krzysztof,

Quoted 29 lines · Krzysztof Kozlowski
Quoted 27 lines · Naresh Solanki
Quoted 27 lines
Quoted 18 lines

Changes in V2:
- Update subject
- Drop blank lines

---
    .../bindings/hwmon/maxim,max6639.yaml         | 52
+++++++++++++++++++
    1 file changed, 52 insertions(+)

   create mode 100644
Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml

diff --git a/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml b/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file mode 100644
index 000000000000..1aaedfd7cee0

Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml line 7

Quoted 7 lines
Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +7 -0
@@ -0,0 +1,52 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/hwmon/maxim,max6639.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Maxim max6639

What is this device? fan controller?

Quoted 6 lines
Quoted 3 lines

Yes Fan controller.
Do you want me to update the title here as:
"Maxim MAC6639 2 channel fan controller & temperature monitor" ?

Enough would be:
Maxim MAX6639 Fan Controller

Ack

Quoted 45 lines
Quoted 35 lines
Quoted 27 lines
Quoted 27 lines
Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +6 -0
+
+maintainers:
+  - Naresh Solanki <[email protected]>
+
+description: |
+  The MAX6639 is a 2-channel temperature monitor with dual,

automatic, PWM
+  fan-speed controller.  It monitors its own temperature and one external
+  diode-connected transistor or the temperatures of two external diode-connected
+  transistors, typically available in CPUs, FPGAs, or GPUs.

Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +11 -0
+
+  Datasheets:
+    https://datasheets.maximintegrated.com/en/ds/MAX6639-MAX6639F.pdf
+
+properties:
+  compatible:
+    enum:
+      - maxim,max6639
+
+  reg:
+    maxItems: 1
Quoted 8 lines

Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml

Quoted 6 lines
Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +6 -0
+
+  '#address-cells':
+    const: 1
+
+  '#size-cells':
+    const: 0

Why do you need these two properties?

Quoted 7 lines

Ack. Will remove them.

Quoted 3 lines

Anyway, the binding looks incomplete. Where are the supplies? Interrupts?

This patch just adds basic support to the existing platform driver. Intention is to be able to call the driver from DT with basic initialization from driver the existing driver.

Bindings should be rather complete. Here the datasheet is accessible and few properties quite obvious, so I don't see a reason to skip them.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

I agree with you. But currently the driver which is already merged doesn't has it implemented.
And will be working on separate patch to include this later.

Please let me know if this approach is acceptable, or if there are any other suggestions or concerns that you have.

You are adding new bindings, so what does the driver has to do with it?

The reason for adding these new bindings is to enable the use of the driver on my machine. Without the compatible string, it would not be possible to use the driver.

Currently, the driver initializes the device with defaults, which is good enough for my application. Also, as you previously pointed out, it uses the optional 'fan-supply' which will be included in the next patch revision.

I hope this clarifies my reasoning. Could you kindly confirm if we can proceed with this approach?

Best Regards,
~Naresh

Quoted 4 lines

Best regards,
Krzysztof

#9 lore raw
Quoted 102 lines · Naresh Solanki

Hi Krzysztof,

Quoted 88 lines · Krzysztof Kozlowski
Quoted 87 lines · Naresh Solanki

Hi Krzysztof,

Quoted 84 lines · Naresh Solanki

Hi Krzysztof,

Quoted 29 lines · Krzysztof Kozlowski
Quoted 27 lines · Naresh Solanki
Quoted 27 lines
Quoted 18 lines

Changes in V2:
- Update subject
- Drop blank lines

---
    .../bindings/hwmon/maxim,max6639.yaml         | 52
+++++++++++++++++++
    1 file changed, 52 insertions(+)

   create mode 100644
Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml

diff --git a/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml b/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file mode 100644
index 000000000000..1aaedfd7cee0

Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml line 7

Quoted 7 lines
Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +7 -0
@@ -0,0 +1,52 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/hwmon/maxim,max6639.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Maxim max6639

What is this device? fan controller?

Quoted 6 lines
Quoted 3 lines

Yes Fan controller.
Do you want me to update the title here as:
"Maxim MAC6639 2 channel fan controller & temperature monitor" ?

Enough would be:
Maxim MAX6639 Fan Controller

Ack

Quoted 45 lines
Quoted 35 lines
Quoted 27 lines
Quoted 27 lines
Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +6 -0
+
+maintainers:
+  - Naresh Solanki <[email protected]>
+
+description: |
+  The MAX6639 is a 2-channel temperature monitor with dual,

automatic, PWM
+  fan-speed controller.  It monitors its own temperature and one external
+  diode-connected transistor or the temperatures of two external diode-connected
+  transistors, typically available in CPUs, FPGAs, or GPUs.

Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +11 -0
+
+  Datasheets:
+    https://datasheets.maximintegrated.com/en/ds/MAX6639-MAX6639F.pdf
+
+properties:
+  compatible:
+    enum:
+      - maxim,max6639
+
+  reg:
+    maxItems: 1
Quoted 8 lines

Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml

Quoted 6 lines
Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +6 -0
+
+  '#address-cells':
+    const: 1
+
+  '#size-cells':
+    const: 0

Why do you need these two properties?

Quoted 7 lines

Ack. Will remove them.

Quoted 3 lines

Anyway, the binding looks incomplete. Where are the supplies? Interrupts?

This patch just adds basic support to the existing platform driver. Intention is to be able to call the driver from DT with basic initialization from driver the existing driver.

Bindings should be rather complete. Here the datasheet is accessible and few properties quite obvious, so I don't see a reason to skip them.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

I agree with you. But currently the driver which is already merged doesn't has it implemented.
And will be working on separate patch to include this later.

Please let me know if this approach is acceptable, or if there are any other suggestions or concerns that you have.

You are adding new bindings, so what does the driver has to do with it?

The reason for adding these new bindings is to enable the use of the driver on my machine. Without the compatible string, it would not be possible to use the driver.

Quoted 7 lines

Currently, the driver initializes the device with defaults, which is good enough for my application. Also, as you previously pointed out, it uses the optional 'fan-supply' which will be included in the next patch revision.

I hope this clarifies my reasoning. Could you kindly confirm if we can proceed with this approach?

No, we cannot, because we asked you to fix things there. Your entire explanation about compatible and driver is not related to the comment you received: bindings should be complete. You argue that bindings do not have to be complete, because of something with driver. This is not related. Bindings are not for driver.

Best regards,
Krzysztof

#10 lore raw

Hi Krzysztof,

Quoted 108 lines · Krzysztof Kozlowski
Quoted 107 lines · Naresh Solanki

Hi Krzysztof,

Quoted 88 lines · Krzysztof Kozlowski
Quoted 87 lines · Naresh Solanki

Hi Krzysztof,

Quoted 84 lines · Naresh Solanki

Hi Krzysztof,

Quoted 29 lines · Krzysztof Kozlowski
Quoted 27 lines · Naresh Solanki
Quoted 27 lines
Quoted 18 lines

Changes in V2:
- Update subject
- Drop blank lines

---
     .../bindings/hwmon/maxim,max6639.yaml         | 52
+++++++++++++++++++
     1 file changed, 52 insertions(+)

   create mode 100644
Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml

diff --git a/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml b/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file mode 100644
index 000000000000..1aaedfd7cee0

Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml line 7

Quoted 7 lines
Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +7 -0
@@ -0,0 +1,52 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/hwmon/maxim,max6639.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Maxim max6639

What is this device? fan controller?

Quoted 6 lines
Quoted 3 lines

Yes Fan controller.
Do you want me to update the title here as:
"Maxim MAC6639 2 channel fan controller & temperature monitor" ?

Enough would be:
Maxim MAX6639 Fan Controller

Ack

Quoted 45 lines
Quoted 35 lines
Quoted 27 lines
Quoted 27 lines
Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +6 -0
+
+maintainers:
+  - Naresh Solanki <[email protected]>
+
+description: |
+  The MAX6639 is a 2-channel temperature monitor with dual,

automatic, PWM
+  fan-speed controller.  It monitors its own temperature and one external
+  diode-connected transistor or the temperatures of two external diode-connected
+  transistors, typically available in CPUs, FPGAs, or GPUs.

Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +11 -0
+
+  Datasheets:
+    https://datasheets.maximintegrated.com/en/ds/MAX6639-MAX6639F.pdf
+
+properties:
+  compatible:
+    enum:
+      - maxim,max6639
+
+  reg:
+    maxItems: 1
Quoted 8 lines

Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml

Quoted 6 lines
Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +6 -0
+
+  '#address-cells':
+    const: 1
+
+  '#size-cells':
+    const: 0

Why do you need these two properties?

Quoted 7 lines

Ack. Will remove them.

Quoted 3 lines

Anyway, the binding looks incomplete. Where are the supplies? Interrupts?

This patch just adds basic support to the existing platform driver. Intention is to be able to call the driver from DT with basic initialization from driver the existing driver.

Bindings should be rather complete. Here the datasheet is accessible and few properties quite obvious, so I don't see a reason to skip them.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

I agree with you. But currently the driver which is already merged doesn't has it implemented.
And will be working on separate patch to include this later.

Please let me know if this approach is acceptable, or if there are any other suggestions or concerns that you have.

You are adding new bindings, so what does the driver has to do with it?

The reason for adding these new bindings is to enable the use of the driver on my machine. Without the compatible string, it would not be possible to use the driver.

Currently, the driver initializes the device with defaults, which is good enough for my application. Also, as you previously pointed out, it uses the optional 'fan-supply' which will be included in the next patch revision.

Quoted 8 lines
Quoted 2 lines

I hope this clarifies my reasoning. Could you kindly confirm if we can proceed with this approach?

No, we cannot, because we asked you to fix things there. Your entire explanation about compatible and driver is not related to the comment you received: bindings should be complete. You argue that bindings do not have to be complete, because of something with driver. This is not related. Bindings are not for driver.

I understand that complete bindings are important, but as the driver is already merged and functional, my immediate goal is to enable its use on my machine. I will work on a separate patch to include the interrupts in both binding & driver.

Quoted 4 lines

Best regards,
Krzysztof

#11 lore raw
Quoted 120 lines · Naresh Solanki

Hi Krzysztof,

Quoted 108 lines · Krzysztof Kozlowski
Quoted 107 lines · Naresh Solanki

Hi Krzysztof,

Quoted 88 lines · Krzysztof Kozlowski
Quoted 87 lines · Naresh Solanki

Hi Krzysztof,

Quoted 84 lines · Naresh Solanki

Hi Krzysztof,

Quoted 29 lines · Krzysztof Kozlowski
Quoted 27 lines · Naresh Solanki
Quoted 27 lines
Quoted 18 lines

Changes in V2:
- Update subject
- Drop blank lines

---
     .../bindings/hwmon/maxim,max6639.yaml         | 52
+++++++++++++++++++
     1 file changed, 52 insertions(+)

   create mode 100644
Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml

diff --git a/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml b/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file mode 100644
index 000000000000..1aaedfd7cee0

Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml line 7

Quoted 7 lines
Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +7 -0
@@ -0,0 +1,52 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/hwmon/maxim,max6639.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Maxim max6639

What is this device? fan controller?

Quoted 6 lines
Quoted 3 lines

Yes Fan controller.
Do you want me to update the title here as:
"Maxim MAC6639 2 channel fan controller & temperature monitor" ?

Enough would be:
Maxim MAX6639 Fan Controller

Ack

Quoted 45 lines
Quoted 35 lines
Quoted 27 lines
Quoted 27 lines
Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +6 -0
+
+maintainers:
+  - Naresh Solanki <[email protected]>
+
+description: |
+  The MAX6639 is a 2-channel temperature monitor with dual,

automatic, PWM
+  fan-speed controller.  It monitors its own temperature and one external
+  diode-connected transistor or the temperatures of two external diode-connected
+  transistors, typically available in CPUs, FPGAs, or GPUs.

Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +11 -0
+
+  Datasheets:
+    https://datasheets.maximintegrated.com/en/ds/MAX6639-MAX6639F.pdf
+
+properties:
+  compatible:
+    enum:
+      - maxim,max6639
+
+  reg:
+    maxItems: 1
Quoted 8 lines

Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml

Quoted 6 lines
Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml new file +6 -0
+
+  '#address-cells':
+    const: 1
+
+  '#size-cells':
+    const: 0

Why do you need these two properties?

Quoted 7 lines

Ack. Will remove them.

Quoted 3 lines

Anyway, the binding looks incomplete. Where are the supplies? Interrupts?

This patch just adds basic support to the existing platform driver. Intention is to be able to call the driver from DT with basic initialization from driver the existing driver.

Bindings should be rather complete. Here the datasheet is accessible and few properties quite obvious, so I don't see a reason to skip them.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

I agree with you. But currently the driver which is already merged doesn't has it implemented.
And will be working on separate patch to include this later.

Please let me know if this approach is acceptable, or if there are any other suggestions or concerns that you have.

You are adding new bindings, so what does the driver has to do with it?

The reason for adding these new bindings is to enable the use of the driver on my machine. Without the compatible string, it would not be possible to use the driver.

Currently, the driver initializes the device with defaults, which is good enough for my application. Also, as you previously pointed out, it uses the optional 'fan-supply' which will be included in the next patch revision.

Quoted 8 lines
Quoted 2 lines

I hope this clarifies my reasoning. Could you kindly confirm if we can proceed with this approach?

No, we cannot, because we asked you to fix things there. Your entire explanation about compatible and driver is not related to the comment you received: bindings should be complete. You argue that bindings do not have to be complete, because of something with driver. This is not related. Bindings are not for driver.

Quoted 4 lines

I understand that complete bindings are important, but as the driver is already merged and functional, my immediate goal is to enable its use on my machine. I will work on a separate patch to include the interrupts in both binding & driver.

I don't care about driver and did not comment about it. I don't understand why do you bring it here all'n over.

Best regards,
Krzysztof

maintainer
#12 lore raw
In reply to Naresh Solanki
Quoted 2 lines · Naresh Solanki

Hi Krzysztof,

[ ... ]

Quoted 9 lines
Quoted 6 lines

No, we cannot, because we asked you to fix things there. Your entire explanation about compatible and driver is not related to the comment you received: bindings should be complete. You argue that bindings do not have to be complete, because of something with driver. This is not related. Bindings are not for driver.

I understand that complete bindings are important, but as the driver is already merged and functional, my immediate goal is to enable its use on my machine. I will work on a separate patch to include the interrupts in both binding & driver.

As a follow-up, since it came up in a separate context:

Bindings and driver are independent of each other. _Bindings_ are supposed to be complete. However, the existence of a property in the bindings description does not have to be reflected in the driver.

FWIW, you _could_ have added the device to the list of trivial devices. The only really mandatory property is vdd, and every chip has that. All other properties are really about configuration and/or fan properties, and I don't even know how to describe fan properties (such as pulses per revolution, pwm parameters, fan speed limits, the relationship between pwm outputs and fan inputs, the relationship between fan speed input and pwm output, or fan spin-up requirements) in devicetree.

Guenter

#13 lore raw

Hi Guenter,

Quoted 22 lines · Guenter Roeck
Quoted 2 lines · Naresh Solanki

Hi Krzysztof,

[ ... ]

Quoted 9 lines
Quoted 6 lines

No, we cannot, because we asked you to fix things there. Your entire explanation about compatible and driver is not related to the comment you received: bindings should be complete. You argue that bindings do not have to be complete, because of something with driver. This is not related. Bindings are not for driver.

I understand that complete bindings are important, but as the driver is already merged and functional, my immediate goal is to enable its use on my machine. I will work on a separate patch to include the interrupts in both binding & driver.

As a follow-up, since it came up in a separate context:

Bindings and driver are independent of each other. _Bindings_ are supposed to be complete. However, the existence of a property in the bindings description does not have to be reflected in the driver.

Quoted 8 lines

FWIW, you _could_ have added the device to the list of trivial devices. The only really mandatory property is vdd, and every chip has that. All other properties are really about configuration and/or fan properties, and I don't even know how to describe fan properties (such as pulses per revolution, pwm parameters, fan speed limits, the relationship between pwm outputs and fan inputs, the relationship between fan speed input and pwm output, or fan spin-up requirements) in devicetree.

Thanks for the inputs,
Will work on it & keep you posted.

Regards,
Naresh

Quoted 3 lines

Guenter