Support UDC on Tegra 20/30/114/124

This quirk is required to make USB Ethernet gadget working with HW that can't cope with unaligned DMA. For some reason only f_ncm handles that quirk, let's handle it in the rest of the network models. All models have been tested with a ChipIdea UDC driver on NVIDIA Tegra20 SoC that require DMA to be aligned.

Signed-off-by Dmitry Osipenko <[email protected]>

---
 drivers/usb/gadget/function/f_ecm.c   | 2 ++
 drivers/usb/gadget/function/f_eem.c   | 2 ++
 drivers/usb/gadget/function/f_rndis.c | 4 ++++
 3 files changed, 8 insertions(+)

drivers/usb/gadget/function/f_ecm.c +2 -0

index 4c488d15b6f6..01150f7864c7 100644
@@ -584,6 +584,8 @@ static int ecm_set_alt(struct usb_function *f, unsigned intf, unsigned alt)
 			 */
 			ecm->port.is_zlp_ok =
 				gadget_is_zlp_supported(cdev->gadget);
+			ecm->port.no_skb_reserve =
+				gadget_avoids_skb_reserve(cdev->gadget);
 			ecm->port.cdc_filter = DEFAULT_FILTER;
 			DBG(cdev, "activate ecm\n");
 			net = gether_connect(&ecm->port);

drivers/usb/gadget/function/f_eem.c +2 -0

index 007ec6e4a5d4..3b70b9ccfd2d 100644
@@ -215,6 +215,8 @@ static int eem_set_alt(struct usb_function *f, unsigned intf, unsigned alt)
 		 */
 		eem->port.is_zlp_ok = 1;
 		eem->port.cdc_filter = DEFAULT_FILTER;
+		eem->port.no_skb_reserve =
+				gadget_avoids_skb_reserve(cdev->gadget);
 		DBG(cdev, "activate eem\n");
 		net = gether_connect(&eem->port);
 		if (IS_ERR(net))

drivers/usb/gadget/function/f_rndis.c +0 -0

index 16562e461121..1b379c051a84 100644

drivers/usb/gadget/function/f_rndis.c +0 -0

 		DBG(cdev, "RNDIS RX/TX early activation ... \n");
 		net = gether_connect(&rndis->port);
 		if (IS_ERR(net))

Signature · 6 lines

2.13.2

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Quoted 47 lines · Dmitry Osipenko

This quirk is required to make USB Ethernet gadget working with HW that can't cope with unaligned DMA. For some reason only f_ncm handles that quirk, let's handle it in the rest of the network models. All models have been tested with a ChipIdea UDC driver on NVIDIA Tegra20 SoC that require DMA to be aligned.

Signed-off-by Dmitry Osipenko <[email protected]>

---
 drivers/usb/gadget/function/f_ecm.c   | 2 ++
 drivers/usb/gadget/function/f_eem.c   | 2 ++
 drivers/usb/gadget/function/f_rndis.c | 4 ++++
 3 files changed, 8 insertions(+)

drivers/usb/gadget/function/f_ecm.c +2 -0

index 4c488d15b6f6..01150f7864c7 100644
@@ -584,6 +584,8 @@ static int ecm_set_alt(struct usb_function *f, unsigned intf, unsigned alt)
 			 */
 			ecm->port.is_zlp_ok =
 				gadget_is_zlp_supported(cdev->gadget);
+			ecm->port.no_skb_reserve =
+				gadget_avoids_skb_reserve(cdev->gadget);
 			ecm->port.cdc_filter = DEFAULT_FILTER;
 			DBG(cdev, "activate ecm\n");
 			net = gether_connect(&ecm->port);

drivers/usb/gadget/function/f_eem.c +2 -0

index 007ec6e4a5d4..3b70b9ccfd2d 100644
@@ -215,6 +215,8 @@ static int eem_set_alt(struct usb_function *f, unsigned intf, unsigned alt)
 		 */
 		eem->port.is_zlp_ok = 1;
 		eem->port.cdc_filter = DEFAULT_FILTER;
+		eem->port.no_skb_reserve =
+				gadget_avoids_skb_reserve(cdev->gadget);
 		DBG(cdev, "activate eem\n");
 		net = gether_connect(&eem->port);
 		if (IS_ERR(net))

drivers/usb/gadget/function/f_rndis.c +0 -0

index 16562e461121..1b379c051a84 100644
@@ -593,6 +593,10 @@ static int rndis_set_alt(struct usb_function *f, unsigned intf, unsigned alt)
 		 */
 		rndis->port.cdc_filter = 0;
 

drivers/usb/gadget/function/f_rndis.c static int rndis_set_alt(struct usb_function *f, unsigned intf, unsigned alt) · line 599

Quoted 4 lines

drivers/usb/gadget/function/f_rndis.c +4 -0

+		/* Setup DMA alignment workaround for UDC's that need it */
+		rndis->port.no_skb_reserve =
+				gadget_avoids_skb_reserve(cdev->gadget);
+

You may add above comments for other two changes.

NVIDIA Tegra20 UDC can't cope with unaligned DMA and require a USB gadget quirk that avoids SKB buffer alignment to be set in order to make Ethernet Gadget working. Later Tegra generations do not require that quirk. Let's add a new platform data flag that allows to enable USB gadget quirk for platforms that require it.

Signed-off-by Dmitry Osipenko <[email protected]>

---
 drivers/usb/chipidea/udc.c   | 3 +++
 include/linux/usb/chipidea.h | 1 +
 2 files changed, 4 insertions(+)

drivers/usb/chipidea/udc.c +3 -0

index d68b125796f9..404f10513339 100644
@@ -1899,6 +1899,9 @@ static int udc_start(struct ci_hdrc *ci)
 	ci->gadget.name         = ci->platdata->name;
 	ci->gadget.otg_caps	= otg_caps;
 
+	if (ci->platdata->flags & CI_HDRC_REQUIRES_ALIGNED_DMA)
+		ci->gadget.quirk_avoids_skb_reserve = 1;
+
 	if (ci->is_otg && (otg_caps->hnp_support || otg_caps->srp_support ||
 						otg_caps->adp_support))
 		ci->gadget.is_otg = 1;

include/linux/usb/chipidea.h +0 -0

index c5fdfcf99828..d725cff7268d 100644

drivers/usb/chipidea/ci_hdrc_tegra.c new file +4 -0

+	/* setup and register ChipIdea HDRC device */
+	udc->data.name = "tegra-udc";
+	udc->data.capoffset = DEF_CAPOFFSET;
+	udc->data.flags = 0;

drivers/usb/chipidea/ci_hdrc_tegra.c new file +15 -0

+
+	udc->dev = ci_hdrc_add_device(&pdev->dev, pdev->resource,
+				      pdev->num_resources, &udc->data);
+	if (IS_ERR(udc->dev)) {
+		err = PTR_ERR(udc->dev);
+		dev_err(&pdev->dev, "failed to add HDRC device: %d\n", err);
+		goto power_off;
+	}
+
+	platform_set_drvdata(pdev, udc);
+
+	return 0;
+
+power_off:
+	usb_phy_set_suspend(udc->phy, 1);

drivers/usb/chipidea/ci_hdrc_tegra.c new file +5 -0

+static int tegra_udc_remove(struct platform_device *pdev)
+{
+	struct tegra_udc *udc = platform_get_drvdata(pdev);
+
+	usb_phy_set_suspend(udc->phy, 1);

Quoted 9 lines · Dmitry Osipenko

drivers/usb/chipidea/ci_hdrc_tegra.c new file +9 -0

+	/* setup and register ChipIdea HDRC device */
+	udc->data.name = "tegra-udc";
+	udc->data.capoffset = DEF_CAPOFFSET;
+	udc->data.flags = 0;
+	udc->data.usb_phy = udc->phy;
+
+	/* setup device specific quirks */
+	soc = id->data;
+

drivers/usb/chipidea/ci_hdrc_tegra.c line 113

Quoted 5 lines

drivers/usb/chipidea/ci_hdrc_tegra.c new file +5 -0

+	if (!soc->supports_unaligned_dma)
+		udc->data.flags |= CI_HDRC_REQUIRES_ALIGNED_DMA;
+
+	/* power on UDC controller */
+	usb_phy_set_suspend(udc->phy, 0);

Why above is needed? The chipidea core will do usb_phy_init for power on.

Quoted 10 lines · Peter Chen

Quoted 9 lines · Dmitry Osipenko

drivers/usb/chipidea/ci_hdrc_tegra.c new file +9 -0

+	/* setup and register ChipIdea HDRC device */
+	udc->data.name = "tegra-udc";
+	udc->data.capoffset = DEF_CAPOFFSET;
+	udc->data.flags = 0;
+	udc->data.usb_phy = udc->phy;
+
+	/* setup device specific quirks */
+	soc = id->data;
+

Quoted 9 lines

drivers/usb/chipidea/ci_hdrc_tegra.c line 113

Quoted 5 lines

drivers/usb/chipidea/ci_hdrc_tegra.c new file +5 -0

+	if (!soc->supports_unaligned_dma)
+		udc->data.flags |= CI_HDRC_REQUIRES_ALIGNED_DMA;
+
+	/* power on UDC controller */
+	usb_phy_set_suspend(udc->phy, 0);

Why above is needed? The chipidea core will do usb_phy_init for power on.

It is needed because Tegra's USB PHY driver doesn't hook up .init() of the struct usb_phy and the power management is handled by set_suspend().

Quoted 21 lines · Dmitry Osipenko

Quoted 19 lines · Peter Chen

Quoted 4 lines · Dmitry Osipenko

drivers/usb/chipidea/ci_hdrc_tegra.c new file +4 -0

+	/* setup and register ChipIdea HDRC device */
+	udc->data.name = "tegra-udc";
+	udc->data.capoffset = DEF_CAPOFFSET;
+	udc->data.flags = 0;

drivers/usb/chipidea/ci_hdrc_tegra.c line 113

Quoted 10 lines

drivers/usb/chipidea/ci_hdrc_tegra.c new file +10 -0

+	udc->data.usb_phy = udc->phy;
+
+	/* setup device specific quirks */
+	soc = id->data;
+
+	if (!soc->supports_unaligned_dma)
+		udc->data.flags |= CI_HDRC_REQUIRES_ALIGNED_DMA;
+
+	/* power on UDC controller */
+	usb_phy_set_suspend(udc->phy, 0);

Why above is needed? The chipidea core will do usb_phy_init for power on.

Quoted 3 lines

It is needed because Tegra's USB PHY driver doesn't hook up .init() of the struct usb_phy and the power management is handled by set_suspend().

Ok, please comment it since it is strange that initialize phy at .set_suspend API, after that, you can add my Ack for this patch.

From: Thierry Reding <[email protected]>

Override the compatible string of the first USB controller to enable device mode.

Signed-off-by Thierry Reding <[email protected]>

---
 arch/arm/boot/dts/tegra20-trimslice.dts | 2 ++
 1 file changed, 2 insertions(+)

arch/arm/boot/dts/tegra20-trimslice.dts +0 -0

index b902ab594afa..96b4f3f9827b 100644

Quoted 17 lines · Dmitry Osipenko

From: Thierry Reding <[email protected]>

Override the compatible string of the first USB controller to enable device mode.

Signed-off-by Thierry Reding <[email protected]>

---
 arch/arm/boot/dts/tegra20-trimslice.dts | 2 ++
 1 file changed, 2 insertions(+)

arch/arm/boot/dts/tegra20-trimslice.dts +0 -0

index b902ab594afa..96b4f3f9827b 100644
@@ -336,7 +336,9 @@
 	};
 

arch/arm/boot/dts/tegra20-trimslice.dts line 341

Quoted 4 lines

arch/arm/boot/dts/tegra20-trimslice.dts +2 -0

 	usb@c5000000 {
+		compatible = "nvidia,tegra20-udc";
 		status = "okay";
+		dr_mode = "otg";

If this board supports peripheral-only, you need to set dr_mode as "peripheral".

Quoted 18 lines · Peter Chen

Quoted 17 lines · Dmitry Osipenko

From: Thierry Reding <[email protected]>

Override the compatible string of the first USB controller to enable device mode.

Signed-off-by Thierry Reding <[email protected]>

---
 arch/arm/boot/dts/tegra20-trimslice.dts | 2 ++
 1 file changed, 2 insertions(+)

arch/arm/boot/dts/tegra20-trimslice.dts +0 -0

index b902ab594afa..96b4f3f9827b 100644
@@ -336,7 +336,9 @@
 	};
 

Quoted 8 lines

arch/arm/boot/dts/tegra20-trimslice.dts line 341

Quoted 4 lines

arch/arm/boot/dts/tegra20-trimslice.dts +2 -0

 	usb@c5000000 {
+		compatible = "nvidia,tegra20-udc";
 		status = "okay";
+		dr_mode = "otg";

If this board supports peripheral-only, you need to set dr_mode as "peripheral".

It should support OTG, but we aren't going to implement the host mode switch for now. Stephen claims that the host mode is working with the tegra-ehci driver, it would be nice if anyone could confirm this.

Quoted 14 lines · Peter Chen

Quoted 13 lines · Dmitry Osipenko

From: Thierry Reding <[email protected] .org>

Override the compatible string of the first USB controller to enable
device mode.

Signed-off-by Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@pub

lic.gmane.org>
---
 arch/arm/boot/dts/tegra20-trimslice.dts | 2 ++

 1 file changed, 2 insertions(+)

Quoted 16 lines

arch/arm/boot/dts/tegra20-trimslice.dts line 341

Quoted 12 lines

arch/arm/boot/dts/tegra20-trimslice.dts +0 -0

index b902ab594afa..96b4f3f9827b 100644
@@ -336,7 +336,9 @@
  	};

  usb@c5000000 {

arch/arm/boot/dts/tegra20-trimslice.dts +1 -0

+		compatible = "nvidia,tegra20-udc";

  status = "okay";

arch/arm/boot/dts/tegra20-trimslice.dts +1 -0

+		dr_mode = "otg";

If this board supports peripheral-only, you need to set dr_mode as "peripheral".

It should support OTG, but we aren't going to implement the host mode switch for
now. Stephen claims that the host mode is working with the tegra-ehci driver, it
would be nice if anyone could confirm this.

Quoted 32 lines · Dmitry Osipenko

Quoted 30 lines · Peter Chen

Quoted 19 lines · Dmitry Osipenko

From: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA-XMD5yJDbdMToUJ55TTLPZA@public.gmane.org .org>

Override the compatible string of the first USB controller to enable
device mode.

Signed-off-by Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@pub

lic.gmane.org>

---
 arch/arm/boot/dts/tegra20-trimslice.dts | 2 ++
 1 file changed, 2 insertions(+)

arch/arm/boot/dts/tegra20-trimslice.dts +0 -0

index b902ab594afa..96b4f3f9827b 100644

arch/arm/boot/dts/tegra20-trimslice.dts line 341

Quoted 6 lines

arch/arm/boot/dts/tegra20-trimslice.dts +2 -0

@@ -336,7 +336,9 @@
 	};
 
 	usb@c5000000 {
+		compatible = "nvidia,tegra20-udc";
 		status = "okay";
+		dr_mode = "otg";

If this board supports peripheral-only, you need to set dr_mode as "peripheral".

Quoted 5 lines

It should support OTG, but we aren't going to implement the host mode switch for
now. Stephen claims that the host mode is working with the tegra-ehci driver, it
would be nice if anyone could confirm this.

I can confirm that on Colibri T20, Apalis/Colibri T30 and Apalis TK1 host mode works just fine with the regular tegra-ehci driver.

I'm about to give your patch set a try on those boards as well and will give further feedback.

Quoted 17 lines · Dmitry Osipenko

From: Thierry Reding <[email protected]>

Override the compatible string of the first USB controller to enable device mode.

Signed-off-by Thierry Reding <[email protected]>

---
  arch/arm/boot/dts/tegra20-trimslice.dts | 2 ++
  1 file changed, 2 insertions(+)

arch/arm/boot/dts/tegra20-trimslice.dts +0 -0

index b902ab594afa..96b4f3f9827b 100644
@@ -336,7 +336,9 @@
  	};
 

arch/arm/boot/dts/tegra20-trimslice.dts line 341

Quoted 4 lines

arch/arm/boot/dts/tegra20-trimslice.dts +2 -0

  	usb@c5000000 {
+		compatible = "nvidia,tegra20-udc";
  		status = "okay";
+		dr_mode = "otg";

If this board supports peripheral-only, you need to set dr_mode as "peripheral".

Quoted 11 lines · Peter Chen

Quoted 10 lines · Dmitry Osipenko

From: Thierry Reding <[email protected]>

Override the compatible string of the first USB controller to enable device mode.

Signed-off-by Thierry Reding <[email protected]>

---
  arch/arm/boot/dts/tegra20-trimslice.dts | 2 ++
  1 file changed, 2 insertions(+)

Quoted 14 lines

arch/arm/boot/dts/tegra20-trimslice.dts line 340

Quoted 11 lines

arch/arm/boot/dts/tegra20-trimslice.dts +2 -0

index b902ab594afa..96b4f3f9827b 100644
@@ -336,7 +336,9 @@
      };
        usb@c5000000 {
+        compatible = "nvidia,tegra20-udc";
          status = "okay";
+        dr_mode = "otg";

If this board supports peripheral-only, you need to set dr_mode as "peripheral".

I agree here. Even if the ports can theoretically do otg, and DT is supposed to represent HW not SW, given we have no SW support for actual OTG, it'd be best not to change the DT to OTG until it's actually useful to do so. This comment applies to the patches I ack'd already too.

Quoted 27 lines · Stephen Warren

Quoted 11 lines · Peter Chen

Quoted 10 lines · Dmitry Osipenko

From: Thierry Reding <[email protected]>

Override the compatible string of the first USB controller to enable device mode.

Signed-off-by Thierry Reding <[email protected]>

---
   arch/arm/boot/dts/tegra20-trimslice.dts | 2 ++
   1 file changed, 2 insertions(+)

Quoted 14 lines

arch/arm/boot/dts/tegra20-trimslice.dts line 340

Quoted 11 lines

arch/arm/boot/dts/tegra20-trimslice.dts +2 -0

index b902ab594afa..96b4f3f9827b 100644
@@ -336,7 +336,9 @@
       };
         usb@c5000000 {
+        compatible = "nvidia,tegra20-udc";
           status = "okay";
+        dr_mode = "otg";

If this board supports peripheral-only, you need to set dr_mode as "peripheral".

Quoted 4 lines

I agree here. Even if the ports can theoretically do otg, and DT is supposed to represent HW not SW, given we have no SW support for actual OTG, it'd be best not to change the DT to OTG until it's actually useful to do so. This comment applies to the patches I ack'd already too.

In case of absence of the "dr_mode" option or without a support of host mode switching, UDC driver fallbacks to the peripheral mode. Given that DT is supposed to be stable, I'm not sure what to do... should I specify the peripheral mode for now (which doesn't represent the HW) or completely remove the "dr_mode"?

Quoted 33 lines · Dmitry Osipenko

Quoted 27 lines · Stephen Warren

Quoted 11 lines · Peter Chen

Quoted 10 lines · Dmitry Osipenko

From: Thierry Reding <[email protected]>

Override the compatible string of the first USB controller to enable device mode.

Signed-off-by Thierry Reding <[email protected]>

---
   arch/arm/boot/dts/tegra20-trimslice.dts | 2 ++
   1 file changed, 2 insertions(+)

Quoted 14 lines

arch/arm/boot/dts/tegra20-trimslice.dts line 340

Quoted 11 lines

arch/arm/boot/dts/tegra20-trimslice.dts +2 -0

index b902ab594afa..96b4f3f9827b 100644
@@ -336,7 +336,9 @@
       };
         usb@c5000000 {
+        compatible = "nvidia,tegra20-udc";
           status = "okay";
+        dr_mode = "otg";

If this board supports peripheral-only, you need to set dr_mode as "peripheral".

Quoted 4 lines

I agree here. Even if the ports can theoretically do otg, and DT is supposed to represent HW not SW, given we have no SW support for actual OTG, it'd be best not to change the DT to OTG until it's actually useful to do so. This comment applies to the patches I ack'd already too.

Quoted 5 lines

In case of absence of the "dr_mode" option or without a support of host mode switching, UDC driver fallbacks to the peripheral mode. Given that DT is supposed to be stable, I'm not sure what to do... should I specify the peripheral mode for now (which doesn't represent the HW) or completely remove the "dr_mode"?

I think specifying dr_mode="peripheral" now is fine; we can change it later.

DT ABI compatibility isn't about never changing the DT content, it's about making sure that any schema changes occur in a backwards-compatible fashion.

Also in the case of a USB port that does support OTG, the dr_mode property represents both (a) the HW's capabilities, and (b) the user's desired (initial, if e.g. sysfs modification is possible) mode of operation if the HW has multiple capabilities. Given (b), I think it's fine to specify peripheral mode for now, and allow the user to change it back to host or OTG mode if they want (although OTG mode isn't useful/valid until SW support exists).

From: Thierry Reding <[email protected]>

Override the compatible string of the first USB controller to enable device mode.

Quoted 4 lines · Dmitry Osipenko

From: Thierry Reding <[email protected]>

Override the compatible string of the first USB controller to enable device mode.

Conceptually I'm fine with this change since the port isn't enabled at all yet and so this doesn't change any existing behaviour. I hope someone tested this on real HW?

Acked-by Stephen Warren <[email protected]>

From: Thierry Reding <[email protected]>

Override the compatible string of the first USB controller to enable device mode.

From: Thierry Reding <[email protected]>

Override the compatible string of the first USB controller to enable device mode.

Quoted 5 lines · Dmitry Osipenko

Override the compatible string of the first USB controller to enable device mode.

arch/arm/boot/dts/tegra20-paz00.dts +0 -0

arch/arm/boot/dts/tegra20-paz00.dts line 458

Quoted 5 lines

      usb@c5000000 {

arch/arm/boot/dts/tegra20-paz00.dts +2 -0

+        compatible = "nvidia,tegra20-udc";
          status = "okay";
+        dr_mode = "otg";
      };

This port is the only external USB port on the AC100.

idea to reconfigure it so it can only work in device mode, although given that display, keyboard, and mouse are built-in to this device, perhaps this change is merely unexpected rather than catastrophic to a user, since they can recover via the keyboard/display. Let's drop this patch until OTG mode is actually implemented.

Quoted 13 lines · Stephen Warren

Quoted 11 lines · Dmitry Osipenko

Override the compatible string of the first USB controller to enable device mode.

arch/arm/boot/dts/tegra20-paz00.dts +2 -0

 
       usb@c5000000 {
+        compatible = "nvidia,tegra20-udc";
           status = "okay";
+        dr_mode = "otg";
       };

Quoted 1 line

This port is the only external USB port on the AC100.

Seems that's not true. http://elinux.org/Tegra/Boards/Toshiba_AC100 claims that there are host and micro USB ports.

Quoted 20 lines · Stephen Warren

Quoted 18 lines · Dmitry Osipenko

Quoted 5 lines

Override the compatible string of the first USB controller to enable device mode.

arch/arm/boot/dts/tegra20-paz00.dts

Quoted 10 lines

arch/arm/boot/dts/tegra20-paz00.dts +2 -0

 
       usb@c5000000 {
 
+        compatible = "nvidia,tegra20-udc";
 
           status = "okay";
 
+        dr_mode = "otg";
 
       };

This port is the only external USB port on the AC100.

Quoted 2 lines

Seems that's not true. http://elinux.org/Tegra/Boards/Toshiba_AC100 claims that there are host and micro USB ports.

You're right; I was getting this board confused with the Springbank variety of Seaboard, and when I looked at the mini USB port on the AC100 I thought it was something else.

Given the physical connector on this USB port on the AC100, it's probably fine to convert it to device-mode only since I don't expect anyone has a USB OTG cable that has a mini size connector on the host end.

It looks like this port is only enabled because the very first version of tegra-paz00.dts didn't explicitly disable the port, and when tegra20.dtsi was updated to disable all USB ports by default, tegra-paz00.dtsi was updated to enable the port so that the DT change didn't affect behaviour, which then left the port enabled explicitly albeit without much reason.

So, once the dr_mode is fixed in this change, it's:

Acked-by Stephen Warren <[email protected]>

Am Donnerstag, 6. Juli 2017, 20:00:02 CEST schrieb Stephen Warren:

Quoted 21 lines · Dmitry Osipenko

Quoted 20 lines · Stephen Warren

Quoted 18 lines · Dmitry Osipenko

Quoted 5 lines

Override the compatible string of the first USB controller to enable device mode.

arch/arm/boot/dts/tegra20-paz00.dts

Quoted 10 lines

arch/arm/boot/dts/tegra20-paz00.dts +2 -0

 
       usb@c5000000 {
 
+        compatible = "nvidia,tegra20-udc";
 
           status = "okay";
 
+        dr_mode = "otg";
 
       };

This port is the only external USB port on the AC100.

Quoted 6 lines

Quoted 2 lines

Seems that's not true. http://elinux.org/Tegra/Boards/Toshiba_AC100 claims that there are host and micro USB ports.

You're right; I was getting this board confused with the Springbank variety of Seaboard, and when I looked at the mini USB port on the AC100 I thought it was something else.

Sorry, for the late reply, I'm on vacation.

Quoted 10 lines

Given the physical connector on this USB port on the AC100, it's probably fine to convert it to device-mode only since I don't expect anyone has a USB OTG cable that has a mini size connector on the host end.

It looks like this port is only enabled because the very first version of tegra-paz00.dts didn't explicitly disable the port, and when tegra20.dtsi was updated to disable all USB ports by default, tegra-paz00.dtsi was updated to enable the port so that the DT change didn't affect behaviour, which then left the port enabled explicitly albeit without much reason.

I think someone used it in the past in host mode and it was working, but I think everyone will be happy to have it operating as client only (as original intended), especially because we already have an external (and also an internal) usb port.

Quoted 2 lines

So, once the dr_mode is fixed in this change, it's:

Acked-by Stephen Warren <[email protected]>

Tested-by Marc Dietrich <[email protected]>

Since NVIDIA Tegra 20/30/40/TK1 are supported now by the ChipIdea driver, let's enable this driver in tegra_defconfig.

Quoted 2 lines · Dmitry Osipenko

Since NVIDIA Tegra 20/30/40/TK1 are supported now by the ChipIdea driver, let's enable this driver in tegra_defconfig.

Shouldn't this patch be earlier in the series so that we don't completely break USB support between the patch which switches a port to the UDC driver and the UDC driver actually being built?

Some time ago Thierry Reding sent out patches that enabled UDC on NVIDIA Tegra, unfortunately they haven't got enough traction to get into the kernel. I've rebased those patches and added a fix for the Ethernet USB Gadget on Tegra20, Marc Dietrich tested UDC driver on AC100 and Nicolas Chauvet on TK1. Like an original patchset, this series adds support for the peripheral mode only.

Quoted 6 lines · Dmitry Osipenko

Some time ago Thierry Reding sent out patches that enabled UDC on NVIDIA Tegra, unfortunately they haven't got enough traction to get into the kernel. I've rebased those patches and added a fix for the Ethernet USB Gadget on Tegra20, Marc Dietrich tested UDC driver on AC100 and Nicolas Chauvet on TK1. Like an original patchset, this series adds support for the peripheral mode only.

Does this mean that the relevant ports no longer support host mode? That's going to be a user-visible regression, which doesn't sound like a good idea. Isn't OTG possible instead?

Quoted 8 lines · Stephen Warren

Quoted 6 lines · Dmitry Osipenko

Some time ago Thierry Reding sent out patches that enabled UDC on NVIDIA Tegra, unfortunately they haven't got enough traction to get into the kernel. I've rebased those patches and added a fix for the Ethernet USB Gadget on Tegra20, Marc Dietrich tested UDC driver on AC100 and Nicolas Chauvet on TK1. Like an original patchset, this series adds support for the peripheral mode only.

Quoted 3 lines

Does this mean that the relevant ports no longer support host mode? That's going to be a user-visible regression, which doesn't sound like a good idea. Isn't OTG possible instead?

We are going to switch only AC100 and TrimSlice to use the UDC driver.

Do you
know whether that port is working in a host mode with the tegra-ehci driver on these devices?

That should be a micro USB port. Since that port is working in a device mode by default, I presume that switching it into a host mode would require some extra 'dance', otherwise I may drop the AC100 / TrimSlice patches.

The full-featured OTG should be possible, it could be done later if desired. I'm leaving it to somebody else to implement.

Quoted 9 lines · Dmitry Osipenko

Quoted 8 lines · Stephen Warren

Quoted 6 lines · Dmitry Osipenko

Some time ago Thierry Reding sent out patches that enabled UDC on NVIDIA Tegra, unfortunately they haven't got enough traction to get into the kernel. I've rebased those patches and added a fix for the Ethernet USB Gadget on Tegra20, Marc Dietrich tested UDC driver on AC100 and Nicolas Chauvet on TK1. Like an original patchset, this series adds support for the peripheral mode only.

Quoted 5 lines

Quoted 3 lines

Does this mean that the relevant ports no longer support host mode? That's going to be a user-visible regression, which doesn't sound like a good idea. Isn't OTG possible instead?

We are going to switch only AC100 and TrimSlice to use the UDC driver.

Really? I saw patches in the series for Beaver, Dalmore, and Jetson TK1 too.

Quoted 3 lines

Do you
know whether that port is working in a host mode with the tegra-ehci driver on these devices?

If any USB port is enabled in the DT, it was certainly validated at some point. IIRC, we only have host mode enabled at present. So, yes, I'd expect this port to work in host mode currently without any issue.

Quoted 6 lines

That should be a micro USB port. Since that port is working in a device mode by default, I presume that switching it into a host mode would require some extra 'dance', otherwise I may drop the AC100 / TrimSlice patches.

The full-featured OTG should be possible, it could be done later if desired. I'm leaving it to somebody else to implement.

Quoted 10 lines · Stephen Warren

Quoted 9 lines · Dmitry Osipenko

Quoted 8 lines · Stephen Warren

Quoted 6 lines · Dmitry Osipenko

Some time ago Thierry Reding sent out patches that enabled UDC on NVIDIA Tegra, unfortunately they haven't got enough traction to get into the kernel. I've rebased those patches and added a fix for the Ethernet USB Gadget on Tegra20, Marc Dietrich tested UDC driver on AC100 and Nicolas Chauvet on TK1. Like an original patchset, this series adds support for the peripheral mode only.

Quoted 8 lines

Quoted 5 lines

Quoted 3 lines

Does this mean that the relevant ports no longer support host mode? That's going to be a user-visible regression, which doesn't sound like a good idea. Isn't OTG possible instead?

We are going to switch only AC100 and TrimSlice to use the UDC driver.

Really? I saw patches in the series for Beaver, Dalmore, and Jetson TK1 too.

Yes, the "PHY" and "EHCI" nodes are disabled on those boards in DT.

Quoted 8 lines

Quoted 3 lines

Do you
know whether that port is working in a host mode with the tegra-ehci driver on these devices?

If any USB port is enabled in the DT, it was certainly validated at some point. IIRC, we only have host mode enabled at present. So, yes, I'd expect this port to work in host mode currently without any issue.

Okay, so we have to decide whether it's reasonable to switch AC100 and TrimSlice to the peripheral mode. I think realistically chances that someone uses that port in a host mode are quite low, while it works fine and probably more useful in a device mode.

Quoted 43 lines · Dmitry Osipenko

Quoted 21 lines · Stephen Warren

Quoted 20 lines · Dmitry Osipenko

Quoted 18 lines · Stephen Warren

Quoted 11 lines · Dmitry Osipenko

Some time ago Thierry Reding sent out patches that enabled UDC on NVIDIA
Tegra, unfortunately they haven't got enough traction to get into the
kernel. I've rebased those patches and added a fix for the Ethernet USB
Gadget on Tegra20, Marc Dietrich tested UDC driver on AC100 and Nicolas
Chauvet on TK1. Like an original patchset, this series adds support for
the peripheral mode only.

Does this mean that the relevant ports no longer support host mode? That's going
to be a user-visible regression, which doesn't sound like a good idea. Isn't OTG
possible instead?

Quoted 6 lines

Quoted 2 lines

We are going to switch only AC100 and TrimSlice to use the UDC driver.

Really? I saw patches in the series for Beaver, Dalmore, and Jetson TK1 too.

Yes, the "PHY" and "EHCI" nodes are disabled on those boards in DT.

Quoted 11 lines

Quoted 4 lines

Do you
know whether that port is working in a host mode with the tegra-ehci driver on
these devices?

If any USB port is enabled in the DT, it was certainly validated at some point.
IIRC, we only have host mode enabled at present. So, yes, I'd expect this port
to work in host mode currently without any issue.

Quoted 7 lines

Okay, so we have to decide whether it's reasonable to switch AC100 and TrimSlice
to the peripheral mode. I think realistically chances that someone uses that
port in a host mode are quite low, while it works fine and probably more useful
in a device mode.

Judging by this:

http://trimslice.com/download/documentation/trim-slice-man.pdf

at least TrimSlice doesn't seem to implement OTG, so we'd have to make a
choice to support either host or peripheral mode. I guess technically it
would need to be peripheral mode because pin 4 is not connected.

Does a similar document exist for AC100?

Thierry

Quoted 56 lines · Thierry Reding

Quoted 43 lines · Dmitry Osipenko

Quoted 21 lines · Stephen Warren

Quoted 20 lines · Dmitry Osipenko

Quoted 18 lines · Stephen Warren

Quoted 11 lines · Dmitry Osipenko

Some time ago Thierry Reding sent out patches that enabled UDC on NVIDIA
Tegra, unfortunately they haven't got enough traction to get into the
kernel. I've rebased those patches and added a fix for the Ethernet USB
Gadget on Tegra20, Marc Dietrich tested UDC driver on AC100 and Nicolas
Chauvet on TK1. Like an original patchset, this series adds support for
the peripheral mode only.

Does this mean that the relevant ports no longer support host mode? That's going
to be a user-visible regression, which doesn't sound like a good idea. Isn't OTG
possible instead?

Quoted 6 lines

Quoted 2 lines

We are going to switch only AC100 and TrimSlice to use the UDC driver.

Really? I saw patches in the series for Beaver, Dalmore, and Jetson TK1 too.

Yes, the "PHY" and "EHCI" nodes are disabled on those boards in DT.

Quoted 11 lines

Quoted 4 lines

Do you
know whether that port is working in a host mode with the tegra-ehci driver on
these devices?

If any USB port is enabled in the DT, it was certainly validated at some point.
IIRC, we only have host mode enabled at present. So, yes, I'd expect this port
to work in host mode currently without any issue.

Quoted 7 lines

Okay, so we have to decide whether it's reasonable to switch AC100 and TrimSlice
to the peripheral mode. I think realistically chances that someone uses that
port in a host mode are quite low, while it works fine and probably more useful
in a device mode.

Judging by this:

http://trimslice.com/download/documentation/trim-slice-man.pdf

Quoted 7 lines

at least TrimSlice doesn't seem to implement OTG, so we'd have to make a
choice to support either host or peripheral mode. I guess technically it
would need to be peripheral mode because pin 4 is not connected.

Does a similar document exist for AC100?

Judging by the Compal PAZ00 schematics it does indeed have an ID pin which is connected to the mini USB socket.

USB1_ID1: From Connector

USB1_ID2: From EC

So an alternative possibility to switch device/host mode would be from the EC (;-p).

Quoted 68 lines · Marcel Ziswiler

Quoted 56 lines · Thierry Reding

Quoted 43 lines · Dmitry Osipenko

Quoted 21 lines · Stephen Warren

Quoted 20 lines · Dmitry Osipenko

Quoted 18 lines · Stephen Warren

Quoted 11 lines · Dmitry Osipenko

Some time ago Thierry Reding sent out patches that enabled UDC on NVIDIA
Tegra, unfortunately they haven't got enough traction to get into the
kernel. I've rebased those patches and added a fix for the Ethernet USB
Gadget on Tegra20, Marc Dietrich tested UDC driver on AC100 and Nicolas
Chauvet on TK1. Like an original patchset, this series adds support for
the peripheral mode only.

Does this mean that the relevant ports no longer support host mode? That's going
to be a user-visible regression, which doesn't sound like a good idea. Isn't OTG
possible instead?

Quoted 6 lines

Quoted 2 lines

We are going to switch only AC100 and TrimSlice to use the UDC driver.

Really? I saw patches in the series for Beaver, Dalmore, and Jetson TK1 too.

Yes, the "PHY" and "EHCI" nodes are disabled on those boards in DT.

Quoted 11 lines

Quoted 4 lines

Do you
know whether that port is working in a host mode with the tegra-ehci driver on
these devices?

If any USB port is enabled in the DT, it was certainly validated at some point.
IIRC, we only have host mode enabled at present. So, yes, I'd expect this port
to work in host mode currently without any issue.

Quoted 7 lines

Okay, so we have to decide whether it's reasonable to switch AC100 and TrimSlice
to the peripheral mode. I think realistically chances that someone uses that
port in a host mode are quite low, while it works fine and probably more useful
in a device mode.

Judging by this:

http://trimslice.com/download/documentation/trim-slice-man.pdf

Quoted 7 lines

at least TrimSlice doesn't seem to implement OTG, so we'd have to make a
choice to support either host or peripheral mode. I guess technically it
would need to be peripheral mode because pin 4 is not connected.

Does a similar document exist for AC100?

Judging by the Compal PAZ00 schematics it does indeed have an ID pin which is connected to the mini USB socket.

Quoted 6 lines

USB1_ID1: From Connector

USB1_ID2: From EC

So an alternative possibility to switch device/host mode would be from the EC (;-p).

According to the TRM, there's a USB PHY register that can be used to query the ID/VBUS pins. They can optionally also be connected to a pair of GPIO lines. Apparently it's even possible to hook them up to the PMU and use a PMU specific mechanism. Most of that information can be found in downstream kernel code.

Using U-Boot I can monitor the USB1_IF_USB_PHY_VBUS_WAKEUP_ID_0 register (address 0x7d000408) and I see that bit ID_STS changes, and can presumably trigger an interrupt when ID_INT_EN is set.

According to the downstream kernel this isn't supposed to work on the Jetson TK1 up to and including the D revision, but it seems to work in U-Boot at least on the C revision that I have. For earlier revisions there is a sysfs attribute that can be used to force the port into the desired mode.

Can anyone check whether or not the above register (on Tegra20, the physical address of the register should be 0xc5000408) changes when switching between micro A and micro B cables on TrimSlice and/or PAZ00? Note that I wasn't able to see a difference after unplugging a micro B cable. It only toggles after plugging in the micro A or after unplugging the micro B, which I think really only means that by default the port will be in peripheral mode. This can probably also be influenced by setting or clearing the ID_PU field (pull-up on ID pin).

If this works reliably, we may be able to implement a very simple form of detecting host/peripheral mode.

Quoted 11 lines · Stephen Warren

Quoted 6 lines · Dmitry Osipenko

Some time ago Thierry Reding sent out patches that enabled UDC on NVIDIA Tegra, unfortunately they haven't got enough traction to get into the kernel. I've rebased those patches and added a fix for the Ethernet USB Gadget on Tegra20, Marc Dietrich tested UDC driver on AC100 and Nicolas Chauvet on TK1. Like an original patchset, this series adds support for the peripheral mode only.

Does this mean that the relevant ports no longer support host mode? That's going to be a user-visible regression, which doesn't sound like a good idea. Isn't OTG possible instead?

We are going to switch only AC100 and TrimSlice to use the UDC driver. Do you know whether that port is working in a host mode with the tegra-ehci driver on these devices? That should be a micro USB port. Since that port is working in a device mode by default, I presume that switching it into a host mode would require some extra 'dance', otherwise I may drop the AC100 / TrimSlice patches.

The full-featured OTG should be possible, it could be done later if desired. I'm leaving it to somebody else to implement.

Quoted 19 lines · Dmitry Osipenko

Quoted 11 lines · Stephen Warren

Quoted 6 lines · Dmitry Osipenko

Some time ago Thierry Reding sent out patches that enabled UDC on NVIDIA Tegra, unfortunately they haven't got enough traction to get into the kernel. I've rebased those patches and added a fix for the Ethernet USB Gadget on Tegra20, Marc Dietrich tested UDC driver on AC100 and Nicolas Chauvet on TK1. Like an original patchset, this series adds support for the peripheral mode only.

Does this mean that the relevant ports no longer support host mode? That's going to be a user-visible regression, which doesn't sound like a good idea. Isn't OTG possible instead?

We are going to switch only AC100 and TrimSlice to use the UDC driver. Do you know whether that port is working in a host mode with the tegra-ehci driver on these devices? That should be a micro USB port. Since that port is working in a device mode by default, I presume that switching it into a host mode would require some extra 'dance', otherwise I may drop the AC100 / TrimSlice patches.

Quoted 3 lines

The full-featured OTG should be possible, it could be done later if desired. I'm leaving it to somebody else to implement.

Full-featured OTG? Do you mean it is compliances OTG spec, or just support dual-role switch through ID pin or external connector?