Skip to contentSkip to conversation

Fix checkpatch.pl issues

PATCH Superseded Madhumitha Prabakaran 3 participants 7 messages Mar 2, 2019 – Mar 3, 2019 Staging

v4 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

v4 cover Fix checkpatch.pl issues

This patchset fixes the comment styles of SPDX-License Identifier based on License Identifier syntax.

Madhumitha Prabakaran (2):
Staging: vt6655: channel.h: Fix comment style of SPDX License Identifier
Staging: vt6655: desc.h: Fix comment style of SPDX License Identifier
---
Changes in v4-
-Fixed matches in subject lines of the patches

Changes in v3-
- Fixed commit log and version number

Changes in v2-
-Included cover letter in patch set

 drivers/staging/vt6655/channel.h | 2 +-
 drivers/staging/vt6655/desc.h    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Signature · 1 line
2.17.1
#1 lore raw

PATCH v4 1/2 Staging: vt6655: Fix comment style of SPDX License Identifier

Fix comment style of SPDX License Identifier for header file type based on License Identifier syntax.

---
 drivers/staging/vt6655/channel.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6655/channel.h +1 -1
index 53f623a4af65..0d2709607456 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
Signature · 1 line
2.17.1
#2 lore raw

PATCH v4 2/2 Staging: vt6655: Fix comment style of SPDX License Identifier

In reply to Madhumitha Prabakaran

Fix comment style of SPDX License Identifier for header file type based on License Identifier syntax.

---
 drivers/staging/vt6655/desc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6655/desc.h +1 -1
index b4a0037b40c1..d4572847b08a 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
Signature · 1 line
2.17.1
maintainer
#3 lore raw
In reply to Madhumitha Prabakaran
Quoted 6 lines · Madhumitha Prabakaran

This patchset fixes the comment styles of SPDX-License Identifier based on License Identifier syntax.

Madhumitha Prabakaran (2):
Staging: vt6655: channel.h: Fix comment style of SPDX License Identifier
Staging: vt6655: desc.h: Fix comment style of SPDX License Identifier

Again, these look fine.

Now go look at the subject lines of the patches you sent out. It does not match these.

Something is really wrong with either how you are generating this message, or the patches, it does not make sense at all. They should always match up identically as git should do it all for you.

Please try sending the series to only yourself next, to verify you got it right, before sending it to everyone.

thanks,

greg k-h

#4 lore raw
Quoted 17 lines · Greg KH
Quoted 6 lines · Madhumitha Prabakaran

This patchset fixes the comment styles of SPDX-License Identifier based on License Identifier syntax.

Madhumitha Prabakaran (2):
Staging: vt6655: channel.h: Fix comment style of SPDX License Identifier
Staging: vt6655: desc.h: Fix comment style of SPDX License Identifier

Again, these look fine.

Now go look at the subject lines of the patches you sent out. It does not match these.

Something is really wrong with either how you are generating this message, or the patches, it does not make sense at all. They should always match up identically as git should do it all for you.

Quoted 6 lines

Please try sending the series to only yourself next, to verify you got it right, before sending it to everyone.

thanks,

greg k-h

Re: [PATCH v4 0/2] Fix checkpatch.pl issues

Will fix it and resend it.

thanks,

madhumitha

#5 lore raw
In reply to Greg KH
Quoted 17 lines · Greg KH
Quoted 6 lines · Madhumitha Prabakaran

This patchset fixes the comment styles of SPDX-License Identifier based on License Identifier syntax.

Madhumitha Prabakaran (2):
Staging: vt6655: channel.h: Fix comment style of SPDX License Identifier
Staging: vt6655: desc.h: Fix comment style of SPDX License Identifier

Again, these look fine.

Now go look at the subject lines of the patches you sent out. It does not match these.

Something is really wrong with either how you are generating this message, or the patches, it does not make sense at all. They should always match up identically as git should do it all for you.

Quoted 6 lines

Please try sending the series to only yourself next, to verify you got it right, before sending it to everyone.

thanks,

greg k-h

I fixed this using the below link. https://wiki.umbc.edu/pages/viewpage.action?pageId=1867916.

please correct me if I'm wrong

Thanks

Madhumitha

#6 lore raw
Quoted 18 lines · Madhumthia Prabakaran
Quoted 17 lines · Greg KH
Quoted 6 lines · Madhumitha Prabakaran

This patchset fixes the comment styles of SPDX-License Identifier based on License Identifier syntax.

Madhumitha Prabakaran (2):
Staging: vt6655: channel.h: Fix comment style of SPDX License Identifier
Staging: vt6655: desc.h: Fix comment style of SPDX License Identifier

Again, these look fine.

Now go look at the subject lines of the patches you sent out. It does not match these.

Something is really wrong with either how you are generating this message, or the patches, it does not make sense at all. They should always match up identically as git should do it all for you.

Quoted 8 lines
Quoted 6 lines

Please try sending the series to only yourself next, to verify you got it right, before sending it to everyone.

thanks,

greg k-h

I fixed this using the below link. https://wiki.umbc.edu/pages/viewpage.action?pageId=1867916.

Not sure to see any connection.

julia

Quoted 14 lines

please correct me if I'm wrong

Thanks

Madhumitha

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190303052106.GA31969%40madhuleo.
For more options, visit https://groups.google.com/d/optout.