Skip to contentSkip to conversation

Fix checkpatch.pl issues

PATCH Superseded Madhumitha Prabakaran 2 participants 4 messages Mar 3, 2019 Staging

v5 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

v5 cover Fix checkpatch.pl issues

These patches fix comment style of SPDX License Identifier.

---

Madhumitha Prabakaran (2):
Staging: vt6655: Fix comment style of SPDX License Identifier
Staging: vt6655: Fix comment style of SPDX License Identifier

 drivers/staging/vt6655/channel.h | 2 +-
 drivers/staging/vt6655/desc.h    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Signature · 1 line
2.17.1
#1 lore raw

PATCH v5 1/2 Staging: vt6655: Fix comment style of SPDX License Identifier

Fix comment style of SPDX License Identifier for header file type based on License Identifier syntax.

---
 drivers/staging/vt6655/channel.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6655/channel.h +1 -1
index 53f623a4af65..0d2709607456 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
Signature · 1 line
2.17.1
#2 lore raw

PATCH v5 2/2 Staging: vt6655: Fix comment style of SPDX License Identifier

In reply to Madhumitha Prabakaran

Fix comment style of SPDX License Identifier for header file type based on License Identifier syntax.

---
 drivers/staging/vt6655/desc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6655/desc.h +1 -1
index b4a0037b40c1..d4572847b08a 100644
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0+
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc.
  * All rights reserved.
Signature · 1 line
2.17.1
#3 lore raw
In reply to Madhumitha Prabakaran
Quoted 7 lines · Madhumitha Prabakaran

These patches fix comment style of SPDX License Identifier.

---

Madhumitha Prabakaran (2):
Staging: vt6655: Fix comment style of SPDX License Identifier
Staging: vt6655: Fix comment style of SPDX License Identifier

This has been changed in the wrong way. You now have two commits with the same subject line.

Perhaps all of the iteraions on this mean that it should really be one patch. The files are for the same driver, the changes are the same, and the changes are very small and easy to review.

julia

Quoted 16 lines
 drivers/staging/vt6655/channel.h | 2 +-
 drivers/staging/vt6655/desc.h    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

--
2.17.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/cover.1551588900.git.madhumithabiw%40gmail.com.
For more options, visit https://groups.google.com/d/optout.