Add initial support for slimport anx7625
Subsystems (4)
v2 cover Add initial support for slimport anx7625
Hi all,
The following series add initial support for the Slimport ANX7625 transmitter, a ultra-low power Full-HD 4K MIPI to DP transmitter designed for portable device.
This is the initial version, any mistakes, please let me know, I will fix it in the next series.
Thanks,
Xin
Xin Ji (2):
dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP bridge driver
.../bindings/display/bridge/anx7625.yaml | 96 + drivers/gpu/drm/bridge/Makefile | 2 +- drivers/gpu/drm/bridge/analogix/Kconfig | 6 + drivers/gpu/drm/bridge/analogix/Makefile | 1 + drivers/gpu/drm/bridge/analogix/anx7625.c | 2153 ++++++++++++++++++++ drivers/gpu/drm/bridge/analogix/anx7625.h | 406 ++++ 6 files changed, 2663 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/display/bridge/anx7625.yaml create mode 100644 drivers/gpu/drm/bridge/analogix/anx7625.c create mode 100644 drivers/gpu/drm/bridge/analogix/anx7625.h
Signature · 1 line
2.7.4
PATCH v2 1/2 dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding
The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed for portable device. It converts MIPI to DisplayPort 1.3 4K.
You can add support to your board with binding.
Example:
anx7625_bridge: encoder@58 {
compatible = "analogix,anx7625";
reg = <0x58>;
status = "okay";
panel-flags = <1>;
enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>;
reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>;
#address-cells = <1>;
#size-cells = <0>;
port@0 {
reg = <0>;
anx_1_in: endpoint {
remote-endpoint = <&mipi_dsi>;
};
};
port@3 {
reg = <3>;
anx_1_out: endpoint {
remote-endpoint = <&panel_in>;
};
};
};--- .../bindings/display/bridge/anx7625.yaml | 96 ++++++++++++++++++++++ 1 file changed, 96 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/bridge/anx7625.yaml
Documentation/devicetree/bindings/display/bridge/anx7625.yaml new file +96 -0
@@ -0,0 +1,96 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +# Copyright 2019 Analogix Semiconductor, Inc. +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/display/bridge/anx7625.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Analogix ANX7625 SlimPort (4K Mobile HD Transmitter) + +maintainers: + - Xin Ji <[email protected]> + +description: | + The ANX7625 is an ultra-low power 4K Mobile HD Transmitter + designed for portable devices. + +properties: + "#address-cells": true + "#size-cells": true + + compatible: + items: + - const: analogix,anx7625 + + reg: + maxItems: 1 + + panel-flags: + description: indicate the panel is internal or external + maxItems: 1 + + interrupts: + maxItems: 1 + + enable-gpios: + description: used for power on chip control, POWER_EN pin D2. + maxItems: 1 + + reset-gpios: + description: used for reset chip control, RESET_N pin B7. + maxItems: 1 + + port@0: + type: object + description: + A port node pointing to MIPI DSI host port node. + + port@1: + type: object + description: + A port node pointing to MIPI DPI host port node. + + port@2: + type: object + description: + A port node pointing to external connector port node. + + port@3: + type: object + description: + A port node pointing to eDP port node. + +required: + - "#address-cells" + - "#size-cells" + - compatible + - reg + - port@0 + - port@3 + +example: + - | + anx7625_bridge: encoder@58 { + compatible = "analogix,anx7625"; + reg = <0x58>; + status = "okay"; + panel-flags = <1>; + enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>; + reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>; + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + anx_1_in: endpoint { + remote-endpoint = <&mipi_dsi>; + }; + }; + + port@3 { + reg = <3>; + anx_1_out: endpoint { + remote-endpoint = <&panel_in>; + }; + }; + };
Signature · 1 line
2.7.4
Re: [PATCH v2 1/2] dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding
Quoted 94 lines · Xin Ji
The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed for portable device. It converts MIPI to DisplayPort 1.3 4K.
You can add support to your board with binding.
Example:
anx7625_bridge: encoder@58 { compatible = "analogix,anx7625"; reg = <0x58>; status = "okay"; panel-flags = <1>; enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>; reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>; #address-cells = <1>; #size-cells = <0>; port@0 { reg = <0>; anx_1_in: endpoint { remote-endpoint = <&mipi_dsi>; }; }; port@3 { reg = <3>; anx_1_out: endpoint { remote-endpoint = <&panel_in>; }; }; };Signed-off-by Xin Ji <[email protected]>--- .../bindings/display/bridge/anx7625.yaml | 96 ++++++++++++++++++++++ 1 file changed, 96 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/bridge/anx7625.yamlDocumentation/devicetree/bindings/display/bridge/anx7625.yaml new file +51
-0@@ -0,0 +1,96 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +# Copyright 2019 Analogix Semiconductor, Inc. +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/display/bridge/anx7625.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Analogix ANX7625 SlimPort (4K Mobile HD Transmitter) + +maintainers: + - Xin Ji <[email protected]> + +description: | + The ANX7625 is an ultra-low power 4K Mobile HD Transmitter + designed for portable devices. + +properties: + "#address-cells": true + "#size-cells": true + + compatible: + items: + - const: analogix,anx7625 + + reg: + maxItems: 1 + + panel-flags: + description: indicate the panel is internal or external + maxItems: 1 + + interrupts: + maxItems: 1 + + enable-gpios: + description: used for power on chip control, POWER_EN pin D2. + maxItems: 1 + + reset-gpios: + description: used for reset chip control, RESET_N pin B7. + maxItems: 1 + + port@0: + type: object + description: + A port node pointing to MIPI DSI host port node. + + port@1: + type: object + description: + A port node pointing to MIPI DPI host port node.
Documentation/devicetree/bindings/display/bridge/anx7625.yaml line 61
Quoted 10 lines
Documentation/devicetree/bindings/display/bridge/anx7625.yaml new file +10
-0+ + port@2: + type: object + description: + A port node pointing to external connector port node. + + port@3: + type: object + description: + A port node pointing to eDP port node.
Decrypting available product brief[1], there are following physical lines:
Input:
- MIPI DSI/DPI - video data, are DSI and DPI lines shared?
- I2S - audio data,
- I2C - control line,
- ALERT/INTP - interrupt,
- USB 3.1 SSRc/Tx - for USB forwarding,
Output:
- SS1, SS2,
- SBU/AUX,
- CC1/2.
Having this information I try to understand ports defined by you:
- port@2 you have defined as pointing to external port, but here the port should be rather subnode of ANX7625 - the chip has CC lines, see beginning of [2].
- port@3 describes SS1, SS2 and SBU/AUX lines together, am I right? In USB-C binding SBU and SS lines are represented by different ports, different approach, but maybe better in this case.
Maybe it would be good to add 2nd example with USB-C port.
[1]:
https://www.analogix.com/system/files/AA-002291-PB-6-ANX7625_ProductBrief.pdf
[2]: Documentation/devicetree/bindings/connector/usb-connector.txt
Regards
Andrzej
Quoted 35 lines
Documentation/devicetree/bindings/display/bridge/anx7625.yaml new file +35
-0+ +required: + - "#address-cells" + - "#size-cells" + - compatible + - reg + - port@0 + - port@3 + +example: + - | + anx7625_bridge: encoder@58 { + compatible = "analogix,anx7625"; + reg = <0x58>; + status = "okay"; + panel-flags = <1>; + enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>; + reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>; + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + anx_1_in: endpoint { + remote-endpoint = <&mipi_dsi>; + }; + }; + + port@3 { + reg = <3>; + anx_1_out: endpoint { + remote-endpoint = <&panel_in>; + }; + }; + };
Laurent Pinchart
reviewerRe: [PATCH v2 1/2] dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding
Hi Andrzej,
Quoted 109 lines · Andrzej Hajda
Quoted 94 lines · Xin Ji
The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed for portable device. It converts MIPI to DisplayPort 1.3 4K.
You can add support to your board with binding.
Example:
anx7625_bridge: encoder@58 { compatible = "analogix,anx7625"; reg = <0x58>; status = "okay"; panel-flags = <1>; enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>; reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>; #address-cells = <1>; #size-cells = <0>; port@0 { reg = <0>; anx_1_in: endpoint { remote-endpoint = <&mipi_dsi>; }; }; port@3 { reg = <3>; anx_1_out: endpoint { remote-endpoint = <&panel_in>; }; }; };Signed-off-by Xin Ji <[email protected]>--- .../bindings/display/bridge/anx7625.yaml | 96 ++++++++++++++++++++++ 1 file changed, 96 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/bridge/anx7625.yamlDocumentation/devicetree/bindings/display/bridge/anx7625.yaml new file +51
-0@@ -0,0 +1,96 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +# Copyright 2019 Analogix Semiconductor, Inc. +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/display/bridge/anx7625.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Analogix ANX7625 SlimPort (4K Mobile HD Transmitter) + +maintainers: + - Xin Ji <[email protected]> + +description: | + The ANX7625 is an ultra-low power 4K Mobile HD Transmitter + designed for portable devices. + +properties: + "#address-cells": true + "#size-cells": true + + compatible: + items: + - const: analogix,anx7625 + + reg: + maxItems: 1 + + panel-flags: + description: indicate the panel is internal or external + maxItems: 1 + + interrupts: + maxItems: 1 + + enable-gpios: + description: used for power on chip control, POWER_EN pin D2. + maxItems: 1 + + reset-gpios: + description: used for reset chip control, RESET_N pin B7. + maxItems: 1 + + port@0: + type: object + description: + A port node pointing to MIPI DSI host port node. + + port@1: + type: object + description: + A port node pointing to MIPI DPI host port node.Documentation/devicetree/bindings/display/bridge/anx7625.yaml line 61
Quoted 10 lines
Documentation/devicetree/bindings/display/bridge/anx7625.yaml new file +10
-0+ + port@2: + type: object + description: + A port node pointing to external connector port node. + + port@3: + type: object + description: + A port node pointing to eDP port node.Decrypting available product brief[1], there are following physical lines:
Quoted 3 lines
Input:
- MIPI DSI/DPI - video data, are DSI and DPI lines shared?
It would be much easier if we could have access to more complete information. I believe the DSI and DPI pins could be muxed, but there should be more DPI pins than DSI pins.
Quoted 20 lines
- I2S - audio data,
- I2C - control line,
- ALERT/INTP - interrupt,
- USB 3.1 SSRc/Tx - for USB forwarding,
Output:
- SS1, SS2,
- SBU/AUX,
- CC1/2.
Having this information I try to understand ports defined by you:
Quoted 7 lines
- port@2 you have defined as pointing to external port, but here the port should be rather subnode of ANX7625 - the chip has CC lines, see beginning of [2].
- port@3 describes SS1, SS2 and SBU/AUX lines together, am I right? In USB-C binding SBU and SS lines are represented by different ports, different approach, but maybe better in this case.
I believe that, when connected to a DP display (either DP or eDP), the DisplayPort signals are output on SS1 and/or SS2. I this really wonder if we need two separate ports for this, it seems that port@2 and port@3 should be merged.
Quoted 1 line
Maybe it would be good to add 2nd example with USB-C port.
That would help with the discussion, yes.
Quoted 40 lines
[1]:
https://www.analogix.com/system/files/AA-002291-PB-6-ANX7625_ProductBrief.pdf[2]:
Documentation/devicetree/bindings/connector/usb-connector.txtQuoted 35 lines
Documentation/devicetree/bindings/display/bridge/anx7625.yaml new file +35
-0+ +required: + - "#address-cells" + - "#size-cells" + - compatible + - reg + - port@0 + - port@3 + +example: + - | + anx7625_bridge: encoder@58 { + compatible = "analogix,anx7625"; + reg = <0x58>; + status = "okay"; + panel-flags = <1>; + enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>; + reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>; + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + anx_1_in: endpoint { + remote-endpoint = <&mipi_dsi>; + }; + }; + + port@3 { + reg = <3>; + anx_1_out: endpoint { + remote-endpoint = <&panel_in>; + }; + }; + };
Signature · 3 lines
Regards, Laurent Pinchart
Re: [PATCH v2 1/2] dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding
Hi Laurent Pinchart, please check my comment below.
Thanks,
Xin
Quoted 112 lines · Laurent Pinchart
Hi Andrzej,
Quoted 109 lines · Andrzej Hajda
Quoted 94 lines · Xin Ji
The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed for portable device. It converts MIPI to DisplayPort 1.3 4K.
You can add support to your board with binding.
Example:
anx7625_bridge: encoder@58 { compatible = "analogix,anx7625"; reg = <0x58>; status = "okay"; panel-flags = <1>; enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>; reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>; #address-cells = <1>; #size-cells = <0>; port@0 { reg = <0>; anx_1_in: endpoint { remote-endpoint = <&mipi_dsi>; }; }; port@3 { reg = <3>; anx_1_out: endpoint { remote-endpoint = <&panel_in>; }; }; };Signed-off-by Xin Ji <[email protected]>--- .../bindings/display/bridge/anx7625.yaml | 96 ++++++++++++++++++++++ 1 file changed, 96 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/bridge/anx7625.yamlDocumentation/devicetree/bindings/display/bridge/anx7625.yaml new file +51
-0@@ -0,0 +1,96 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +# Copyright 2019 Analogix Semiconductor, Inc. +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/display/bridge/anx7625.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Analogix ANX7625 SlimPort (4K Mobile HD Transmitter) + +maintainers: + - Xin Ji <[email protected]> + +description: | + The ANX7625 is an ultra-low power 4K Mobile HD Transmitter + designed for portable devices. + +properties: + "#address-cells": true + "#size-cells": true + + compatible: + items: + - const: analogix,anx7625 + + reg: + maxItems: 1 + + panel-flags: + description: indicate the panel is internal or external + maxItems: 1 + + interrupts: + maxItems: 1 + + enable-gpios: + description: used for power on chip control, POWER_EN pin D2. + maxItems: 1 + + reset-gpios: + description: used for reset chip control, RESET_N pin B7. + maxItems: 1 + + port@0: + type: object + description: + A port node pointing to MIPI DSI host port node. + + port@1: + type: object + description: + A port node pointing to MIPI DPI host port node.Documentation/devicetree/bindings/display/bridge/anx7625.yaml line 61
Quoted 10 lines
Documentation/devicetree/bindings/display/bridge/anx7625.yaml new file +10
-0+ + port@2: + type: object + description: + A port node pointing to external connector port node. + + port@3: + type: object + description: + A port node pointing to eDP port node.Decrypting available product brief[1], there are following physical lines:
Quoted 7 lines
Quoted 3 lines
Input:
- MIPI DSI/DPI - video data, are DSI and DPI lines shared?
It would be much easier if we could have access to more complete information. I believe the DSI and DPI pins could be muxed, but there should be more DPI pins than DSI pins.
Yes DPI pins more than DSI pins.
Quoted 25 lines
Quoted 25 lines
- I2S - audio data,
- I2C - control line,
- ALERT/INTP - interrupt,
- USB 3.1 SSRc/Tx - for USB forwarding,
Output:
- SS1, SS2,
- SBU/AUX,
- CC1/2.
Having this information I try to understand ports defined by you:
- port@2 you have defined as pointing to external port, but here the port should be rather subnode of ANX7625 - the chip has CC lines, see beginning of [2].
Quoted 8 lines
Quoted 3 lines
- port@3 describes SS1, SS2 and SBU/AUX lines together, am I right? In USB-C binding SBU and SS lines are represented by different ports, different approach, but maybe better in this case.
I believe that, when connected to a DP display (either DP or eDP), the DisplayPort signals are output on SS1 and/or SS2. I this really wonder if we need two separate ports for this, it seems that port@2 and port@3 should be merged.
OK, I will merge the port@2 and port@3, and use a flag to indicate whether the control is external connector control or not.
Quoted 4 lines
Quoted 2 lines
Maybe it would be good to add 2nd example with USB-C port.
That would help with the discussion, yes.
As we disabled USB-C feature in anx7625, we cannot define a USB-C port.
Quoted 46 lines
Quoted 41 lines
[1]:
https://www.analogix.com/system/files/AA-002291-PB-6-ANX7625_ProductBrief.pdf[2]:
Documentation/devicetree/bindings/connector/usb-connector.txtQuoted 35 lines
Documentation/devicetree/bindings/display/bridge/anx7625.yaml new file +35
-0+ +required: + - "#address-cells" + - "#size-cells" + - compatible + - reg + - port@0 + - port@3 + +example: + - | + anx7625_bridge: encoder@58 { + compatible = "analogix,anx7625"; + reg = <0x58>; + status = "okay"; + panel-flags = <1>; + enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>; + reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>; + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + anx_1_in: endpoint { + remote-endpoint = <&mipi_dsi>; + }; + }; + + port@3 { + reg = <3>; + anx_1_out: endpoint { + remote-endpoint = <&panel_in>; + }; + }; + };Signature · 3 lines
Regards, Laurent Pinchart
Laurent Pinchart
reviewerRe: [PATCH v2 1/2] dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding
Hi Xin Ji,
Quoted 149 lines · Xin Ji
Quoted 110 lines · Laurent Pinchart
Quoted 109 lines · Andrzej Hajda
Quoted 94 lines · Xin Ji
The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed for portable device. It converts MIPI to DisplayPort 1.3 4K.
You can add support to your board with binding.
Example:
anx7625_bridge: encoder@58 { compatible = "analogix,anx7625"; reg = <0x58>; status = "okay"; panel-flags = <1>; enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>; reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>; #address-cells = <1>; #size-cells = <0>; port@0 { reg = <0>; anx_1_in: endpoint { remote-endpoint = <&mipi_dsi>; }; }; port@3 { reg = <3>; anx_1_out: endpoint { remote-endpoint = <&panel_in>; }; }; };Signed-off-by Xin Ji <[email protected]>--- .../bindings/display/bridge/anx7625.yaml | 96 ++++++++++++++++++++++ 1 file changed, 96 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/bridge/anx7625.yamlDocumentation/devicetree/bindings/display/bridge/anx7625.yaml new file +51
-0@@ -0,0 +1,96 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +# Copyright 2019 Analogix Semiconductor, Inc. +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/display/bridge/anx7625.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Analogix ANX7625 SlimPort (4K Mobile HD Transmitter) + +maintainers: + - Xin Ji <[email protected]> + +description: | + The ANX7625 is an ultra-low power 4K Mobile HD Transmitter + designed for portable devices. + +properties: + "#address-cells": true + "#size-cells": true + + compatible: + items: + - const: analogix,anx7625 + + reg: + maxItems: 1 + + panel-flags: + description: indicate the panel is internal or external + maxItems: 1 + + interrupts: + maxItems: 1 + + enable-gpios: + description: used for power on chip control, POWER_EN pin D2. + maxItems: 1 + + reset-gpios: + description: used for reset chip control, RESET_N pin B7. + maxItems: 1 + + port@0: + type: object + description: + A port node pointing to MIPI DSI host port node. + + port@1: + type: object + description: + A port node pointing to MIPI DPI host port node.Documentation/devicetree/bindings/display/bridge/anx7625.yaml line 61
Quoted 10 lines
Documentation/devicetree/bindings/display/bridge/anx7625.yaml new file +10
-0+ + port@2: + type: object + description: + A port node pointing to external connector port node. + + port@3: + type: object + description: + A port node pointing to eDP port node.Decrypting available product brief[1], there are following physical lines:
Quoted 7 lines
Quoted 3 lines
Input:
- MIPI DSI/DPI - video data, are DSI and DPI lines shared?
It would be much easier if we could have access to more complete information. I believe the DSI and DPI pins could be muxed, but there should be more DPI pins than DSI pins.
Yes DPI pins more than DSI pins.
Quoted 28 lines
Quoted 27 lines
- I2S - audio data,
- I2C - control line,
- ALERT/INTP - interrupt,
- USB 3.1 SSRc/Tx - for USB forwarding,
Output:
- SS1, SS2,
- SBU/AUX,
- CC1/2.
Having this information I try to understand ports defined by you:
- port@2 you have defined as pointing to external port, but here the port should be rather subnode of ANX7625 - the chip has CC lines, see beginning of [2].
- port@3 describes SS1, SS2 and SBU/AUX lines together, am I right? In USB-C binding SBU and SS lines are represented by different ports, different approach, but maybe better in this case.
Quoted 7 lines
Quoted 4 lines
I believe that, when connected to a DP display (either DP or eDP), the DisplayPort signals are output on SS1 and/or SS2. I this really wonder if we need two separate ports for this, it seems that port@2 and port@3 should be merged.
OK, I will merge the port@2 and port@3, and use a flag to indicate whether the control is external connector control or not.
Could this be inferred from the connected DT node ? If the node connected to the endpoint is a display connector node, then we have an external connector. Otherwise we have an eDP panel. Ideally this should even be done at runtime, by communicating with the drm_bridge or drm_panel corresponding to the connected node.
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
Maybe it would be good to add 2nd example with USB-C port.
That would help with the discussion, yes.
As we disabled USB-C feature in anx7625, we cannot define a USB-C port.
It's fine if the feature isn't implemented in the driver, but we should still take it into account to design the DT bindings. Otherwise, when someone will want to add support for USB-C to the ANX7625 bindings, they may find it impossible to do so in a nice backward-compatible way. That's why an example would already be useful.
Quoted 40 lines
Quoted 40 lines
Quoted 40 lines
[1]:
https://www.analogix.com/system/files/AA-002291-PB-6-ANX7625_ProductBrief.pdf[2]:
Documentation/devicetree/bindings/connector/usb-connector.txtQuoted 35 lines
Documentation/devicetree/bindings/display/bridge/anx7625.yaml new file +35
-0+ +required: + - "#address-cells" + - "#size-cells" + - compatible + - reg + - port@0 + - port@3 + +example: + - | + anx7625_bridge: encoder@58 { + compatible = "analogix,anx7625"; + reg = <0x58>; + status = "okay"; + panel-flags = <1>; + enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>; + reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>; + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + anx_1_in: endpoint { + remote-endpoint = <&mipi_dsi>; + }; + }; + + port@3 { + reg = <3>; + anx_1_out: endpoint { + remote-endpoint = <&panel_in>; + }; + }; + };
Signature · 3 lines
Regards, Laurent Pinchart
Re: [PATCH v2 1/2] dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding
Hi Laurent Pinchart,
Quoted 157 lines · Laurent Pinchart
Hi Xin Ji,
Quoted 154 lines · Xin Ji
Quoted 110 lines · Laurent Pinchart
Quoted 109 lines · Andrzej Hajda
Quoted 94 lines · Xin Ji
The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed for portable device. It converts MIPI to DisplayPort 1.3 4K.
You can add support to your board with binding.
Example:
anx7625_bridge: encoder@58 { compatible = "analogix,anx7625"; reg = <0x58>; status = "okay"; panel-flags = <1>; enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>; reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>; #address-cells = <1>; #size-cells = <0>; port@0 { reg = <0>; anx_1_in: endpoint { remote-endpoint = <&mipi_dsi>; }; }; port@3 { reg = <3>; anx_1_out: endpoint { remote-endpoint = <&panel_in>; }; }; };Signed-off-by Xin Ji <[email protected]>--- .../bindings/display/bridge/anx7625.yaml | 96 ++++++++++++++++++++++ 1 file changed, 96 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/bridge/anx7625.yamlDocumentation/devicetree/bindings/display/bridge/anx7625.yaml new file +51
-0@@ -0,0 +1,96 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +# Copyright 2019 Analogix Semiconductor, Inc. +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/display/bridge/anx7625.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Analogix ANX7625 SlimPort (4K Mobile HD Transmitter) + +maintainers: + - Xin Ji <[email protected]> + +description: | + The ANX7625 is an ultra-low power 4K Mobile HD Transmitter + designed for portable devices. + +properties: + "#address-cells": true + "#size-cells": true + + compatible: + items: + - const: analogix,anx7625 + + reg: + maxItems: 1 + + panel-flags: + description: indicate the panel is internal or external + maxItems: 1 + + interrupts: + maxItems: 1 + + enable-gpios: + description: used for power on chip control, POWER_EN pin D2. + maxItems: 1 + + reset-gpios: + description: used for reset chip control, RESET_N pin B7. + maxItems: 1 + + port@0: + type: object + description: + A port node pointing to MIPI DSI host port node. + + port@1: + type: object + description: + A port node pointing to MIPI DPI host port node.Documentation/devicetree/bindings/display/bridge/anx7625.yaml line 61
Quoted 10 lines
Documentation/devicetree/bindings/display/bridge/anx7625.yaml new file +10
-0+ + port@2: + type: object + description: + A port node pointing to external connector port node. + + port@3: + type: object + description: + A port node pointing to eDP port node.Decrypting available product brief[1], there are following physical lines:
Quoted 7 lines
Quoted 3 lines
Input:
- MIPI DSI/DPI - video data, are DSI and DPI lines shared?
It would be much easier if we could have access to more complete information. I believe the DSI and DPI pins could be muxed, but there should be more DPI pins than DSI pins.
Yes DPI pins more than DSI pins.
Quoted 32 lines
Quoted 20 lines
- I2S - audio data,
- I2C - control line,
- ALERT/INTP - interrupt,
- USB 3.1 SSRc/Tx - for USB forwarding,
Output:
- SS1, SS2,
- SBU/AUX,
- CC1/2.
Having this information I try to understand ports defined by you:
Quoted 7 lines
- port@2 you have defined as pointing to external port, but here the port should be rather subnode of ANX7625 - the chip has CC lines, see beginning of [2].
- port@3 describes SS1, SS2 and SBU/AUX lines together, am I right? In USB-C binding SBU and SS lines are represented by different ports, different approach, but maybe better in this case.
I believe that, when connected to a DP display (either DP or eDP), the DisplayPort signals are output on SS1 and/or SS2. I this really wonder if we need two separate ports for this, it seems that port@2 and port@3 should be merged.
Quoted 8 lines
Quoted 2 lines
OK, I will merge the port@2 and port@3, and use a flag to indicate whether the control is external connector control or not.
Could this be inferred from the connected DT node ? If the node connected to the endpoint is a display connector node, then we have an external connector. Otherwise we have an eDP panel. Ideally this should even be done at runtime, by communicating with the
drm_bridgeordrm_panelcorresponding to the connected node.
I think the port@2 should be removed, it could not be inferred from the connected DT node.
Quoted 5 lines
Quoted 5 lines
Quoted 4 lines
Quoted 2 lines
Maybe it would be good to add 2nd example with USB-C port.
That would help with the discussion, yes.
Quoted 7 lines
Quoted 1 line
As we disabled USB-C feature in anx7625, we cannot define a USB-C port.
It's fine if the feature isn't implemented in the driver, but we should still take it into account to design the DT bindings. Otherwise, when someone will want to add support for USB-C to the ANX7625 bindings, they may find it impossible to do so in a nice backward-compatible way. That's why an example would already be useful.
OK.
Quoted 46 lines
Quoted 41 lines
Quoted 41 lines
Quoted 41 lines
[1]:
https://www.analogix.com/system/files/AA-002291-PB-6-ANX7625_ProductBrief.pdf[2]:
Documentation/devicetree/bindings/connector/usb-connector.txtQuoted 35 lines
Documentation/devicetree/bindings/display/bridge/anx7625.yaml new file +35
-0+ +required: + - "#address-cells" + - "#size-cells" + - compatible + - reg + - port@0 + - port@3 + +example: + - | + anx7625_bridge: encoder@58 { + compatible = "analogix,anx7625"; + reg = <0x58>; + status = "okay"; + panel-flags = <1>; + enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>; + reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>; + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + anx_1_in: endpoint { + remote-endpoint = <&mipi_dsi>; + }; + }; + + port@3 { + reg = <3>; + anx_1_out: endpoint { + remote-endpoint = <&panel_in>; + }; + }; + };Signature · 3 lines
Regards, Laurent Pinchart
Re: [PATCH v2 1/2] dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding
In reply to Andrzej HajdaHi Andrzej Hajda, please check my comment below.
Thanks,
Xin
Quoted 121 lines · Andrzej Hajda
Quoted 94 lines · Xin Ji
The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed for portable device. It converts MIPI to DisplayPort 1.3 4K.
You can add support to your board with binding.
Example:
anx7625_bridge: encoder@58 { compatible = "analogix,anx7625"; reg = <0x58>; status = "okay"; panel-flags = <1>; enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>; reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>; #address-cells = <1>; #size-cells = <0>; port@0 { reg = <0>; anx_1_in: endpoint { remote-endpoint = <&mipi_dsi>; }; }; port@3 { reg = <3>; anx_1_out: endpoint { remote-endpoint = <&panel_in>; }; }; };Signed-off-by Xin Ji <[email protected]>--- .../bindings/display/bridge/anx7625.yaml | 96 ++++++++++++++++++++++ 1 file changed, 96 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/bridge/anx7625.yamlDocumentation/devicetree/bindings/display/bridge/anx7625.yaml new file +51
-0@@ -0,0 +1,96 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +# Copyright 2019 Analogix Semiconductor, Inc. +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/display/bridge/anx7625.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Analogix ANX7625 SlimPort (4K Mobile HD Transmitter) + +maintainers: + - Xin Ji <[email protected]> + +description: | + The ANX7625 is an ultra-low power 4K Mobile HD Transmitter + designed for portable devices. + +properties: + "#address-cells": true + "#size-cells": true + + compatible: + items: + - const: analogix,anx7625 + + reg: + maxItems: 1 + + panel-flags: + description: indicate the panel is internal or external + maxItems: 1 + + interrupts: + maxItems: 1 + + enable-gpios: + description: used for power on chip control, POWER_EN pin D2. + maxItems: 1 + + reset-gpios: + description: used for reset chip control, RESET_N pin B7. + maxItems: 1 + + port@0: + type: object + description: + A port node pointing to MIPI DSI host port node. + + port@1: + type: object + description: + A port node pointing to MIPI DPI host port node.Documentation/devicetree/bindings/display/bridge/anx7625.yaml line 61
Quoted 10 lines
Documentation/devicetree/bindings/display/bridge/anx7625.yaml new file +10
-0+ + port@2: + type: object + description: + A port node pointing to external connector port node. + + port@3: + type: object + description: + A port node pointing to eDP port node.Decrypting available product brief[1], there are following physical lines:
Input:
- MIPI DSI/DPI - video data, are DSI and DPI lines shared?
- I2S - audio data,
- I2C - control line,
- ALERT/INTP - interrupt,
- USB 3.1 SSRc/Tx - for USB forwarding,
Quoted 7 lines
Output:
- SS1, SS2,
- SBU/AUX,
- CC1/2.
At this application, we didn't use CC1/2 line, we only use the video format convert(MIPI to DP) feature on anx7625.
Quoted 7 lines
Having this information I try to understand ports defined by you:
- port@2 you have defined as pointing to external port, but here the port should be rather subnode of ANX7625 - the chip has CC lines, see beginning of [2].
The port@2 is for Chromium book external port low power mode control, the driver according this port to register external connector notify interface to receive "connect/disconnect" event to do low power control.
Quoted 7 lines
- port@3 describes SS1, SS2 and SBU/AUX lines together, am I right? In USB-C binding SBU and SS lines are represented by different ports, different approach, but maybe better in this case.
Maybe it would be good to add 2nd example with USB-C port.
No need to add 2nd example with USB-C port, as I said, we didn't use the USB Type-C PD feature at anx7625.
Quoted 49 lines
[1]:
https://www.analogix.com/system/files/AA-002291-PB-6-ANX7625_ProductBrief.pdf[2]:
Documentation/devicetree/bindings/connector/usb-connector.txtRegards
Andrzej
Quoted 35 lines
Documentation/devicetree/bindings/display/bridge/anx7625.yaml new file +35
-0+ +required: + - "#address-cells" + - "#size-cells" + - compatible + - reg + - port@0 + - port@3 + +example: + - | + anx7625_bridge: encoder@58 { + compatible = "analogix,anx7625"; + reg = <0x58>; + status = "okay"; + panel-flags = <1>; + enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>; + reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>; + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + anx_1_in: endpoint { + remote-endpoint = <&mipi_dsi>; + }; + }; + + port@3 { + reg = <3>; + anx_1_out: endpoint { + remote-endpoint = <&panel_in>; + }; + }; + };
PATCH v2 2/2 drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP bridge driver
In reply to Xin JiThe ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed for portable device. It converts MIPI DSI/DPI to DisplayPort 1.3 4K.
The ANX7625 can support both USB Type-C PD feature and MIPI DSI/DPI to DP feature. This driver only enabled MIPI DSI/DPI to DP feature.
--- drivers/gpu/drm/bridge/Makefile | 2 +- drivers/gpu/drm/bridge/analogix/Kconfig | 6 + drivers/gpu/drm/bridge/analogix/Makefile | 1 + drivers/gpu/drm/bridge/analogix/anx7625.c | 2153 +++++++++++++++++++++++++++++ drivers/gpu/drm/bridge/analogix/anx7625.h | 406 ++++++ 5 files changed, 2567 insertions(+), 1 deletion(-) create mode 100644 drivers/gpu/drm/bridge/analogix/anx7625.c create mode 100644 drivers/gpu/drm/bridge/analogix/anx7625.h
drivers/gpu/drm/bridge/Makefile +1 -1
@@ -12,8 +12,8 @@ obj-$(CONFIG_DRM_SII9234) += sii9234.o obj-$(CONFIG_DRM_THINE_THC63LVD1024) += thc63lvd1024.o obj-$(CONFIG_DRM_TOSHIBA_TC358764) += tc358764.o obj-$(CONFIG_DRM_TOSHIBA_TC358767) += tc358767.o -obj-$(CONFIG_DRM_ANALOGIX_DP) += analogix/ obj-$(CONFIG_DRM_I2C_ADV7511) += adv7511/ obj-$(CONFIG_DRM_TI_SN65DSI86) += ti-sn65dsi86.o obj-$(CONFIG_DRM_TI_TFP410) += ti-tfp410.o +obj-y += analogix/ obj-y += synopsys/
drivers/gpu/drm/bridge/analogix/Kconfig +6 -0
@@ -2,3 +2,9 @@ config DRM_ANALOGIX_DP tristate depends on DRM + +config ANALOGIX_ANX7625 + tristate "Analogix MIPI to DP interface support" + help + ANX7625 is an ultra-low power 4K mobile HD transmitter designed + for portable devices. It converts MIPI/DPI to DisplayPort1.3 4K.
drivers/gpu/drm/bridge/analogix/Makefile +1 -0
@@ -1,3 +1,4 @@ # SPDX-License-Identifier: GPL-2.0-only +obj-$(CONFIG_ANALOGIX_ANX7625) += anx7625.o analogix_dp-objs := analogix_dp_core.o analogix_dp_reg.o obj-$(CONFIG_DRM_ANALOGIX_DP) += analogix_dp.o
drivers/gpu/drm/bridge/analogix/anx7625.c new file +2153 -0
2,153 lines not on this page · raw message
drivers/gpu/drm/bridge/analogix/anx7625.h new file +406 -0
406 lines not on this page · raw message
Signature · 1 line
2.7.4
kbuild test robot
build botRe: [PATCH v2 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP bridge driver
Thank you for the patch! Perhaps something to improve:
Hi Xin,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[cannot apply to v5.4-rc3 next-20191011]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Xin-Ji/dt-bindings-drm-bridge-anx7625-MIPI-to-DP-transmitter-binding/20191014-043019
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-rc1-43-g0ccb3b4-dirty
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'If you fix the issue, kindly add following tag
sparse warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/bridge/analogix/anx7625.c:731:10: sparse: sparse: symbol 'ANX_OUI' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
kbuild test robot
build bot[RFC PATCH] drm/bridge: anx7625: ANX_OUI[] can be static
In reply to Xin JiFixes: 152a82b6747f ("drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP bridge driver")
--- anx7625.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/bridge/analogix/anx7625.c +1 -1
@@ -728,7 +728,7 @@ static int anx7625_dpi_config(struct anx7625_data *ctx)return ret; } -const u8 ANX_OUI [3 ] = {0x00 ,0x22 ,0xB9 }; +static const u8 ANX_OUI [3 ] = {0x00 ,0x22 ,0xB9 };static int is_anx_dongle (struct anx7625_data *ctx) {u8 buf[3 ];
Re: [PATCH v2 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP bridge driver
In reply to Xin Ji[ These are automated text from the 0-day bot -dan ]
Hi Xin,
Thank you for the patch! Perhaps something to improve:
If you fix the issue, kindly add following tag
New smatch warnings:drivers/gpu/drm/bridge/analogix/anx7625.c:1274 anx7625_start_dp_work() error: uninitialized symbol 'sp_tx_lane_count'.
# https://github.com/0day-ci/linux/commit/152a82b6747f10d6c13c7a422173947c2f2e1aa2
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 152a82b6747f10d6c13c7a422173947c2f2e1aa2
vim +/sp_tx_lane_count +1274 drivers/gpu/drm/bridge/analogix/anx7625.c
152a82b6747f10 Xin Ji 2019-10-11 1253 static void anx7625_start_dp_work(struct anx7625_data *ctx)
152a82b6747f10 Xin Ji 2019-10-11 1254 {
152a82b6747f10 Xin Ji 2019-10-11 1255 int ret;
152a82b6747f10 Xin Ji 2019-10-11 1256 u8 buf[MAX_DPCD_BUFFER_SIZE];
152a82b6747f10 Xin Ji 2019-10-11 1257 u8 hdcp_cap;
152a82b6747f10 Xin Ji 2019-10-11 1258 struct device *dev = &ctx->client->dev;
152a82b6747f10 Xin Ji 2019-10-11 1259 u8 sp_tx_bw; /* linktraining banwidth */
152a82b6747f10 Xin Ji 2019-10-11 1260 u8 sp_tx_lane_count; /* link training lane count */
152a82b6747f10 Xin Ji 2019-10-11 1261
152a82b6747f10 Xin Ji 2019-10-11 1262 if (ctx->hpd_high_cnt >= 2) {
152a82b6747f10 Xin Ji 2019-10-11 1263 DRM_DEV_DEBUG_DRIVER(dev, "anx7625 filter useless HPD\n");
152a82b6747f10 Xin Ji 2019-10-11 1264 return;
152a82b6747f10 Xin Ji 2019-10-11 1265 }
152a82b6747f10 Xin Ji 2019-10-11 1266
152a82b6747f10 Xin Ji 2019-10-11 1267 ctx->hpd_high_cnt++;
152a82b6747f10 Xin Ji 2019-10-11 1268
152a82b6747f10 Xin Ji 2019-10-11 1269 sp_tx_get_rx_bw(ctx, &sp_tx_bw);
152a82b6747f10 Xin Ji 2019-10-11 1270
152a82b6747f10 Xin Ji 2019-10-11 1271 sp_tx_aux_dpcdread_bytes(ctx, 0x00, 0x00, DPCD_MAX_LANE_COUNT,
152a82b6747f10 Xin Ji 2019-10-11 1272 1, &sp_tx_lane_count);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^Smatch thinks sp_tx_aux_dpcdread_bytes() can fail and we don't check for errors.
152a82b6747f10 Xin Ji 2019-10-11 1273152a82b6747f10 Xin Ji 2019-10-11 @1274 sp_tx_lane_count = sp_tx_lane_count & 0x1f;
152a82b6747f10 Xin Ji 2019-10-11 1275 sp_tx_aux_dpcdread_bytes(ctx, 0x06, 0x80, 0x28, 1, buf);/* read Bcap */ 152a82b6747f10 Xin Ji 2019-10-11 1276 152a82b6747f10 Xin Ji 2019-10-11 1277 hdcp_cap = buf[0] & 0x01; 152a82b6747f10 Xin Ji 2019-10-11 1278
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Quoted 10 lines · Xin Ji
Hi all,
The following series add initial support for the Slimport ANX7625 transmitter, a ultra-low power Full-HD 4K MIPI to DP transmitter designed for portable device.
This is the initial version, any mistakes, please let me know, I will fix it in the next series.
Thanks,
Xin
Next time please increment patchset version number - this is third iteration of v2.
Regards
Andrzej
Quoted 6 lines
Xin Ji (2):
dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP bridge driver
Quoted 11 lines
.../bindings/display/bridge/anx7625.yaml | 96 + drivers/gpu/drm/bridge/Makefile | 2 +- drivers/gpu/drm/bridge/analogix/Kconfig | 6 + drivers/gpu/drm/bridge/analogix/Makefile | 1 + drivers/gpu/drm/bridge/analogix/anx7625.c | 2153 ++++++++++++++++++++ drivers/gpu/drm/bridge/analogix/anx7625.h | 406 ++++ 6 files changed, 2663 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/display/bridge/anx7625.yaml create mode 100644 drivers/gpu/drm/bridge/analogix/anx7625.c create mode 100644 drivers/gpu/drm/bridge/analogix/anx7625.h
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Andrzej, OK, I'll increment patchset version number next time.
Thanks,
Xin
Quoted 39 lines · Andrzej Hajda
Quoted 10 lines · Xin Ji
Hi all,
The following series add initial support for the Slimport ANX7625 transmitter, a ultra-low power Full-HD 4K MIPI to DP transmitter designed for portable device.
This is the initial version, any mistakes, please let me know, I will fix it in the next series.
Thanks,
XinNext time please increment patchset version number - this is third iteration of v2.
Regards
Andrzej
Quoted 17 lines
Xin Ji (2):
dt-bindings: drm/bridge: anx7625: MIPI to DP transmitter binding drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP bridge driver.../bindings/display/bridge/anx7625.yaml | 96 + drivers/gpu/drm/bridge/Makefile | 2 +- drivers/gpu/drm/bridge/analogix/Kconfig | 6 + drivers/gpu/drm/bridge/analogix/Makefile | 1 + drivers/gpu/drm/bridge/analogix/anx7625.c | 2153 ++++++++++++++++++++ drivers/gpu/drm/bridge/analogix/anx7625.h | 406 ++++ 6 files changed, 2663 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/display/bridge/anx7625.yaml create mode 100644 drivers/gpu/drm/bridge/analogix/anx7625.c create mode 100644 drivers/gpu/drm/bridge/analogix/anx7625.h
Quoted 11 lines · Xin Ji
Hi all,
The following series add initial support for the Slimport ANX7625 transmitter, a ultra-low power Full-HD 4K MIPI to DP transmitter designed for portable device.
This is the initial version, any mistakes, please let me know, I will fix it in the next series.
Thanks,
Xin
I'm not a domain expert but I like these patches now.
regards,
dan carpenter
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel