Fix bochs memory leak
v2 cover Fix bochs memory leak
Fix a small memory leak in the Bochs display driver.
Each frame would leak about 304 bytes.
v2: Add missing signed-off-by line.
Cameron Esfahani (1):
display/bochs-display: fix memory leak
hw/display/bochs-display.c | 2 ++ 1 file changed, 2 insertions(+)
Signature · 1 line
2.24.0
PATCH v2 1/1 display/bochs-display: fix memory leak
Fix memory leak in bochs_display_update(). Leaks 304 bytes per frame.
--- hw/display/bochs-display.c | 2 ++ 1 file changed, 2 insertions(+)
hw/display/bochs-display.c +2 -0
@@ -252,6 +252,8 @@ static void bochs_display_update(void *opaque)dpy_gfx_update (s->con,0 , ys, mode.width, y - ys); } + +g_free (snap); } }
Signature · 1 line
2.24.0
Re: [PATCH v2 1/1] display/bochs-display: fix memory leak
Quoted 3 lines · Cameron Esfahani via
Fix memory leak in
bochs_display_update(). Leaks 304 bytes per frame.Signed-off-by Cameron Esfahani <[email protected]>
Funny to have a dirty@ email fixing a DirtyBitmapSnapshot leak =)
Quoted 18 lines
--- hw/display/bochs-display.c | 2 ++ 1 file changed, 2 insertions(+)hw/display/bochs-display.c +2
-0@@ -252,6 +252,8 @@ static void bochs_display_update(void *opaque)dpy_gfx_update (s->con,0 , ys, mode.width, y - ys); } + +g_free (snap); } }
Re: [PATCH v2 1/1] display/bochs-display: fix memory leak
Quoted 10 lines · Philippe Mathieu-Daudé
Quoted 4 lines · Cameron Esfahani via
Fix memory leak in
bochs_display_update(). Leaks 304 bytes per frame.Signed-off-by Cameron Esfahani <[email protected]>Funny to have a dirty@ email fixing a DirtyBitmapSnapshot leak =)
Fixes 33ebad54056
Dirty fixing bad in a snap. What a fix. :-o
Quoted 23 lines
Reviewed-by Philippe Mathieu-Daudé <[email protected]>---
Quoted 17 lines
hw/display/bochs-display.c | 2 ++ 1 file changed, 2 insertions(+)hw/display/bochs-display.c +2
-0@@ -252,6 +252,8 @@ static void bochs_display_update(void *opaque)dpy_gfx_update (s->con,0 , ys, mode.width, y - ys); } + +g_free (snap); } }
Re: [PATCH v2 1/1] display/bochs-display: fix memory leak
Quoted 12 lines · Aleksandar Markovic
On Wednesday, December 11, 2019, Philippe Mathieu-Daudé <[email protected] <mailto:[email protected]>> wrote:
On 12/10/19 10:27 PM, Cameron Esfahani via wrote:
Fix memory leak in bochs_display_update(). Leaks 304 bytes per frame.
Signed-off-by Cameron Esfahani <[email protected]<mailto:[email protected]>>
Quoted 6 lines
Funny to have a dirty@ email fixing a DirtyBitmapSnapshot leak =)
Fixes 33ebad54056Dirty fixing bad in a snap. What a fix. :-o
Nice one! =)