Skip to contentSkip to conversation

Fix bochs memory leak

PATCH Superseded Cameron Esfahani via 2 participants 3 messages Dec 10, 2019

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

cover Fix bochs memory leak

Fix a small memory leak in the Bochs display driver.

Each frame would leak about 304 bytes.

Cameron Esfahani (1):
display/bochs-display: fix memory leak

 hw/display/bochs-display.c | 2 ++
 1 file changed, 2 insertions(+)
Signature · 1 line
2.24.0
#1 lore raw

PATCH 1/1 display/bochs-display: fix memory leak

Fix memory leak in bochs_display_update(). Leaks 304 bytes per frame.

---
 hw/display/bochs-display.c | 2 ++
 1 file changed, 2 insertions(+)
hw/display/bochs-display.c +2 -0
index dc1bd1641d..215db9a231 100644
@@ -252,6 +252,8 @@ static void bochs_display_update(void *opaque)
             dpy_gfx_update(s->con, 0, ys,
                            mode.width, y - ys);
         }
+
+        g_free(snap);
     }
 }
 
Signature · 1 line
2.24.0
#2 lore raw
In reply to Cameron Esfahani via
Patchew URL: https://patchew.org/QEMU/[email protected]/

Patchew URL: https://patchew.org/QEMU/[email protected]/

Hi,

This series seems to have some coding style problems. See output below for more information:

Subject: [PATCH v1 0/1] Fix bochs memory leak
Type: series
Message-id: [email protected]

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
a3c9e5d display/bochs-display: fix memory leak

=== OUTPUT BEGIN ===
ERROR: Missing Signed-off-by: line(s)

total: 1 errors, 0 warnings, 8 lines checked

Commit a3c9e5dc8c32 (display/bochs-display: fix memory leak) has style problems, please review. If any of these errors are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1

The full log is available at
http://patchew.org/logs/[email protected]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [email protected]