test/kms_cursor_crc: tie some loose ends in prepare_crtc

PATCH Superseded Melissa Wen 3 participants 9 messages Jun 22, 2020 – Jul 16, 2020

Share & tools

Melissa Wen

author

2020-06-22 16:37 UTC #0 lore raw

cover test/kms_cursor_crc: tie some loose ends in prepare_crtc

Using vkms, when running a sequence of subtests from kms_cursor_crc, several strange timeout failures occurred. For example, running the alpha-opaque cursor twice, the first run is successful and the second fails. In addition, if we run the entire test in a call (i.e.: sudo IGT_FORCE_DRIVER=vkms build/tests/kms_cursor_crc), the first subtest passes and the rest of the subtests fail - even those that succeed when run in isolation.

igt_debugfs-DEBUG: Opening debugfs directory '/sys/kernel/debug/dri/0'
igt_core-INFO: Timed out: Opening crc fd, and poll for first CRC.

During my debugging process, I found two issues that were blocking execution and the solution is in this patchset:

1 - When a subtest fails, it exits and skips the cleaning step, leaving the pipe_crc allocated and blocked for the next subtest. The first patch fixes it by releasing any old pipe_crc before creating a new one.

2 - When the CRC capture process starts, it enters an endless wait; this seems to be related to the fact that the VKMS simulates vblank events, generating a time mismatch between vblank and CRC capture. Waiting for vblank before starting the capture process sets the pace, as shown in the second patch.

Melissa Wen (2):
test/kms_cursor_crc: release old pipe_crc before create a new one test/kms_cursor_crc: align the start of the CRC capture to a vblank

 tests/kms_cursor_crc.c | 3 +++
 1 file changed, 3 insertions(+)

Signature · 6 lines

2.27.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Melissa Wen

author

2020-06-22 16:38 UTC #1 lore raw

PATCH 1/2 test/kms_cursor_crc: release old pipe_crc before create a new one

When a subtest fails, it skips the cleanup, and its pipe_crc remains allocated. As a consequence, the following subtest also fails (timeout) when trying to create a new one. This patch releases any remaining pipe_crc to enable the creation of a new one for the next subtest.

Signed-off-by Melissa Wen <[email protected]>

---
 tests/kms_cursor_crc.c | 2 ++
 1 file changed, 2 insertions(+)

tests/kms_cursor_crc.c +2 -0

index f105e295..5976df5f 100644
@@ -423,6 +423,8 @@ static void prepare_crtc(data_t *data, igt_output_t *output,
 	igt_display_commit(display);
 
 	/* create the pipe_crc object for this pipe */
+	if (data->pipe_crc)
+		igt_pipe_crc_free(data->pipe_crc);
 	data->pipe_crc = igt_pipe_crc_new(data->drm_fd, data->pipe,
 					  INTEL_PIPE_CRC_SOURCE_AUTO);

Signature · 6 lines

2.27.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Arkadiusz Hiler

Reviewed-by on v1 1/2

2020-07-15 12:47 UTC #2 lore raw

Re: [Intel-gfx] [PATCH i-g-t 1/2] test/kms_cursor_crc: release old pipe_crc before create a new one

Quoted 15 lines · Melissa Wen

When a subtest fails, it skips the cleanup, and its pipe_crc remains allocated. As a consequence, the following subtest also fails (timeout) when trying to create a new one. This patch releases any remaining pipe_crc to enable the creation of a new one for the next subtest.
Signed-off-by Melissa Wen <[email protected]>
---
 tests/kms_cursor_crc.c | 2 ++
 1 file changed, 2 insertions(+)
tests/kms_cursor_crc.c +0 -0
index f105e295..5976df5f 100644

tests/kms_cursor_crc.c static void prepare_crtc(data_t *data, igt_output_t *output, · line 427

Quoted 5 lines

tests/kms_cursor_crc.c +2 -0

@@ -423,6 +423,8 @@ static void prepare_crtc(data_t *data, igt_output_t *output,
 	igt_display_commit(display);
 
 	/* create the pipe_crc object for this pipe */
+	if (data->pipe_crc)
+		igt_pipe_crc_free(data->pipe_crc);

That's a welcome improvement, but you may want to also look at 06333955bf3d ("tests/kms_cursor_crc: start crc only once per test") for some extra inspiration for future work on this.

It should be possible to initiate pipe crc to be initalized only once per each tested pipe in run_tests_on_pipe() - igt_pipe_crc_new() can be costly on some real panels.

Anyway,

Reviewed-by Arkadiusz Hiler <[email protected]>

Quoted 10 lines

tests/kms_cursor_crc.c +0 -0

 	data->pipe_crc = igt_pipe_crc_new(data->drm_fd, data->pipe,
 					  INTEL_PIPE_CRC_SOURCE_AUTO);

Signature · 6 lines

2.27.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Melissa Wen

author

2020-07-16 11:40 UTC #3 lore raw

Re: [igt-dev] [Intel-gfx] [PATCH i-g-t 1/2] test/kms_cursor_crc: release old pipe_crc before create a new one

Quoted 26 lines · Arkadiusz Hiler

Quoted 15 lines · Melissa Wen
When a subtest fails, it skips the cleanup, and its pipe_crc remains allocated. As a consequence, the following subtest also fails (timeout) when trying to create a new one. This patch releases any remaining pipe_crc to enable the creation of a new one for the next subtest.
Signed-off-by Melissa Wen <[email protected]>
---
 tests/kms_cursor_crc.c | 2 ++
 1 file changed, 2 insertions(+)
tests/kms_cursor_crc.c +0 -0
index f105e295..5976df5f 100644
tests/kms_cursor_crc.c static void prepare_crtc(data_t *data, igt_output_t *output, · line 427
Quoted 5 lines
tests/kms_cursor_crc.c +2 -0
@@ -423,6 +423,8 @@ static void prepare_crtc(data_t *data, igt_output_t *output,
 	igt_display_commit(display);
 
 	/* create the pipe_crc object for this pipe */
+	if (data->pipe_crc)
+		igt_pipe_crc_free(data->pipe_crc);
That's a welcome improvement, but you may want to also look at 06333955bf3d ("tests/kms_cursor_crc: start crc only once per test") for some extra inspiration for future work on this.

Quoted 3 lines

It should be possible to initiate pipe crc to be initalized only once per each tested pipe in run_tests_on_pipe() - igt_pipe_crc_new() can be costly on some real panels.

Hi,

Thanks for the advice!
As I have one more refactoring in mind for this test, I will add this in the works and send a patchset with everything together.

For now, I just submitted a v2 of this patch because I dropped the other one that was in the same patchset.

Melissa

Quoted 15 lines

Anyway,

Reviewed-by Arkadiusz Hiler <[email protected]>

Quoted 10 lines

tests/kms_cursor_crc.c +0 -0

 	data->pipe_crc = igt_pipe_crc_new(data->drm_fd, data->pipe,
 					  INTEL_PIPE_CRC_SOURCE_AUTO);

Signature · 6 lines

2.27.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Melissa Wen

author

2020-06-22 16:38 UTC #4 lore raw

PATCH 2/2 test/kms_cursor_crc: align the start of the CRC capture to a vblank

In reply to Melissa Wen

When running subtests in sequence using vkms, the beginning of CRC capture process does not match the simulated vblank timing. This mismatch leads to an endless busy wait and, consequently, timeout failures for the remaining subtests in the test sequence. This patch sets the pace by waiting for vblank before starting the CRC capture.

Signed-off-by Melissa Wen <[email protected]>

---
 tests/kms_cursor_crc.c | 1 +
 1 file changed, 1 insertion(+)

tests/kms_cursor_crc.c +1 -0

index 5976df5f..755c34ed 100644
@@ -474,6 +474,7 @@ static void prepare_crtc(data_t *data, igt_output_t *output,
 		igt_assert(data->batch);
 	}
 
+	igt_wait_for_vblank(data->drm_fd, data->pipe);
 	igt_pipe_crc_start(data->pipe_crc);
 }

Signature · 6 lines

2.27.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Arkadiusz Hiler

2020-07-15 13:02 UTC #5 lore raw

Re: [Intel-gfx] [PATCH i-g-t 2/2] test/kms_cursor_crc: align the start of the CRC capture to a vblank

Quoted 7 lines · Melissa Wen

When running subtests in sequence using vkms, the beginning of CRC capture process does not match the simulated vblank timing. This mismatch leads to an endless busy wait and, consequently, timeout failures for the remaining subtests in the test sequence. This patch sets the pace by waiting for vblank before starting the CRC capture.
Signed-off-by Melissa Wen <[email protected]>

This one is quite interetesing. The test seems to be working just fine on the real hardware and causes the endless busy wait on VKMS only...

DRM is bad at describing usage sequences and what's defined and what's undefined when it comes to behavior. We just try not to break any of the existing users. On top of that CRC capture is a testing/debug feature that doesn't have have to be stable - it's not really obvious what's the correct course of action here.

The vblank wait won't harm anyone, especially in the context presented above. You have to keep in mind that other implementations of CRC caputring doesn't have that requirement and you will likely find more similar instances of this usage pattern. There may be even more of them introduced over time - there's no CI on VKMS (fingers crossed that this is going to change).

Have you thought about what's easier here - making the current code work on the VKMS side or fixing the test? I would like to know your thoughts on this.

Signature · 2 lines

Cheers,
Arek

Quoted 23 lines

---
 tests/kms_cursor_crc.c | 1 +
 1 file changed, 1 insertion(+)

tests/kms_cursor_crc.c +1 -0

index 5976df5f..755c34ed 100644
@@ -474,6 +474,7 @@ static void prepare_crtc(data_t *data, igt_output_t *output,
 		igt_assert(data->batch);
 	}
 
+	igt_wait_for_vblank(data->drm_fd, data->pipe);
 	igt_pipe_crc_start(data->pipe_crc);
 }

Signature · 6 lines

2.27.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Melissa Wen

author

2020-07-15 16:22 UTC #6 lore raw

Re: [Intel-gfx] [PATCH i-g-t 2/2] test/kms_cursor_crc: align the start of the CRC capture to a vblank

Quoted 25 lines · Arkadiusz Hiler

Quoted 7 lines · Melissa Wen
When running subtests in sequence using vkms, the beginning of CRC capture process does not match the simulated vblank timing. This mismatch leads to an endless busy wait and, consequently, timeout failures for the remaining subtests in the test sequence. This patch sets the pace by waiting for vblank before starting the CRC capture.
Signed-off-by Melissa Wen <[email protected]>
This one is quite interetesing. The test seems to be working just fine on the real hardware and causes the endless busy wait on VKMS only...
DRM is bad at describing usage sequences and what's defined and what's undefined when it comes to behavior. We just try not to break any of the existing users. On top of that CRC capture is a testing/debug feature that doesn't have have to be stable - it's not really obvious what's the correct course of action here.
The vblank wait won't harm anyone, especially in the context presented above. You have to keep in mind that other implementations of CRC caputring doesn't have that requirement and you will likely find more similar instances of this usage pattern. There may be even more of them introduced over time - there's no CI on VKMS (fingers crossed that this is going to change).

Quoted 3 lines

Have you thought about what's easier here - making the current code work on the VKMS side or fixing the test? I would like to know your thoughts on this.

Hi,

Thank you very much for the review!

I've been investigating more about this with the community help and, in fact, the problem seems to be more linked to vkms. I mean, this problem of waiting for a vblank before starting to capture the CRC seems to affect vkms in other igt tests too. So the most accurate thing is to treat it over there.

I will send a v2 only with the other patch that releases the pipe_crc before creating a new one.

Thanks again,

Melissa

Quoted 31 lines

Signature · 3 lines

-- 
Cheers,
Arek

Quoted 23 lines

---
 tests/kms_cursor_crc.c | 1 +
 1 file changed, 1 insertion(+)

tests/kms_cursor_crc.c +1 -0

index 5976df5f..755c34ed 100644
@@ -474,6 +474,7 @@ static void prepare_crtc(data_t *data, igt_output_t *output,
 		igt_assert(data->batch);
 	}
 
+	igt_wait_for_vblank(data->drm_fd, data->pipe);
 	igt_pipe_crc_start(data->pipe_crc);
 }

Signature · 6 lines

2.27.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Patchwork

2020-06-25 15:14 UTC #7 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for test/kms_cursor_crc: tie some loose ends in prepare_crtc

In reply to Melissa Wen

== Series Details ==

Series: test/kms_cursor_crc: tie some loose ends in prepare_crtc
URL : https://patchwork.freedesktop.org/series/78813/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_8664 -> IGTPW_4704
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/index.html

Known issues
------------

Here are the changes found in IGTPW_4704 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_suspend@basic-s0:
- fi-tgl-u2: [PASS][1] -> [FAIL][2] ([i915#1888])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/fi-tgl-u2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/fi-tgl-u2/igt@[email protected]

* igt@i915_module_load@reload:
- fi-byt-j1900: [PASS][3] -> [DMESG-WARN][4] ([i915#1982])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/fi-byt-j1900/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/fi-byt-j1900/igt@[email protected]

* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-whl-u: [PASS][5] -> [DMESG-WARN][6] ([i915#95])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/fi-whl-u/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/fi-whl-u/igt@[email protected]

* igt@i915_pm_rpm@module-reload:
- fi-kbl-soraka: [PASS][7] -> [DMESG-WARN][8] ([i915#1982])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/fi-kbl-soraka/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/fi-kbl-soraka/igt@[email protected]

* igt@i915_selftest@live@gt_contexts:
- fi-snb-2600: [PASS][9] -> [DMESG-FAIL][10] ([i915#541] / [i915#666])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/fi-snb-2600/igt@i915_selftest@live@gt_contexts.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/fi-snb-2600/igt@i915_selftest@live@gt_contexts.html

* igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1:
- fi-icl-u2: [PASS][11] -> [DMESG-WARN][12] ([i915#1982])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/fi-icl-u2/igt@kms_flip@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/fi-icl-u2/igt@kms_flip@[email protected]

#### Possible fixes ####

* igt@gem_exec_suspend@basic-s0:
- fi-apl-guc: [INCOMPLETE][13] ([i915#1242]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/fi-apl-guc/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/fi-apl-guc/igt@[email protected]

* igt@gem_exec_suspend@basic-s3:
- fi-tgl-u2: [FAIL][15] ([i915#1888]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/fi-tgl-u2/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/fi-tgl-u2/igt@[email protected]

* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-bsw-kefka: [DMESG-WARN][17] ([i915#1982]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/fi-bsw-kefka/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/fi-bsw-kefka/igt@[email protected]

* igt@kms_busy@basic@flip:
- fi-kbl-x1275: [DMESG-WARN][19] ([i915#62] / [i915#92] / [i915#95]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/fi-kbl-x1275/igt@kms_busy@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/fi-kbl-x1275/igt@kms_busy@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- {fi-kbl-7560u}: [DMESG-WARN][21] ([i915#1982]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/fi-kbl-7560u/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/fi-kbl-7560u/igt@[email protected]

#### Warnings ####

* igt@gem_exec_suspend@basic-s0:
- fi-kbl-x1275: [DMESG-WARN][23] ([i915#1982] / [i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][24] ([i915#62] / [i915#92] / [i915#95])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/fi-kbl-x1275/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/fi-kbl-x1275/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-kbl-x1275: [DMESG-WARN][25] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][26] ([i915#62] / [i915#92]) +8 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/fi-kbl-x1275/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/fi-kbl-x1275/igt@[email protected]

* igt@kms_force_connector_basic@force-edid:
- fi-kbl-x1275: [DMESG-WARN][27] ([i915#62] / [i915#92]) -> [DMESG-WARN][28] ([i915#62] / [i915#92] / [i915#95]) +2 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/fi-kbl-x1275/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/fi-kbl-x1275/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

Participating hosts (44 -> 38)
------------------------------

Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5717 -> IGTPW_4704

CI-20190529: 20190529
CI_DRM_8664: a15b3619fc33a841f92f3939c6bfaffefba28fbf @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_4704: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/index.html
IGT_5717: 725bf2dae51f0087eaa64f1931a2ef9d22f070dd @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Patchwork

2020-06-25 16:11 UTC #8 lore raw

[igt-dev] ✗ Fi.CI.IGT: failure for test/kms_cursor_crc: tie some loose ends in prepare_crtc

In reply to Melissa Wen

== Series Details ==

Series: test/kms_cursor_crc: tie some loose ends in prepare_crtc
URL : https://patchwork.freedesktop.org/series/78813/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_8664_full -> IGTPW_4704_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_4704_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_4704_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_4704_full:

### IGT changes ###

#### Possible regressions ####

* igt@gem_mmap_gtt@fault-concurrent:
- shard-glk: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-glk7/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-glk7/igt@[email protected]

* igt@i915_pm_rpm@system-suspend-modeset:
- shard-apl: [PASS][3] -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-apl8/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-apl4/igt@[email protected]

* igt@kms_cursor_legacy@all-pipes-forked-move:
- shard-hsw: [PASS][5] -> [INCOMPLETE][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-hsw2/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-hsw2/igt@[email protected]

Known issues
------------

Here are the changes found in IGTPW_4704_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_balancer@bonded-early:
- shard-tglb: [PASS][7] -> [FAIL][8] ([i915#2079])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-tglb5/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-tglb2/igt@[email protected]

* igt@gem_exec_suspend@basic-s3:
- shard-iclb: [PASS][9] -> [INCOMPLETE][10] ([i915#1185])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-iclb2/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-iclb3/igt@[email protected]
- shard-kbl: [PASS][11] -> [DMESG-WARN][12] ([i915#180]) +2 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-kbl7/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-kbl6/igt@[email protected]

* igt@gem_exec_whisper@basic-fds-forked-all:
- shard-glk: [PASS][13] -> [DMESG-WARN][14] ([i915#118] / [i915#95]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-glk7/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-glk5/igt@[email protected]

* igt@gem_mmap_wc@copy:
- shard-kbl: [PASS][15] -> [DMESG-WARN][16] ([i915#93] / [i915#95]) +40 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-kbl2/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-kbl6/igt@[email protected]

* igt@gen9_exec_parse@allowed-all:
- shard-glk: [PASS][17] -> [INCOMPLETE][18] ([i915#1436] / [i915#58] / [k.org#198133])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-glk6/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-glk4/igt@[email protected]

* igt@i915_module_load@reload:
- shard-tglb: [PASS][19] -> [DMESG-WARN][20] ([i915#402]) +2 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-tglb7/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-tglb6/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-128x42-random:
- shard-kbl: [PASS][21] -> [DMESG-FAIL][22] ([i915#54] / [i915#95])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-kbl7/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-kbl4/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-64x21-onscreen:
- shard-apl: [PASS][23] -> [DMESG-WARN][24] ([i915#1635] / [i915#95]) +37 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-apl7/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-apl1/igt@[email protected]

* igt@kms_flip@2x-dpms-vs-vblank-race-interruptible@ab-vga1-hdmi-a1:
- shard-hsw: [PASS][25] -> [DMESG-WARN][26] ([i915#1982])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-hsw5/igt@kms_flip@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-hsw6/igt@kms_flip@[email protected]

* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][27] -> [FAIL][28] ([i915#79])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-glk7/igt@kms_flip@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-glk8/igt@kms_flip@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-blt:
- shard-tglb: [PASS][29] -> [DMESG-WARN][30] ([i915#1982] / [i915#402])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-blt.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-tglb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-blt.html

* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-blt:
- shard-tglb: [PASS][31] -> [DMESG-WARN][32] ([i915#1982])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-tglb3/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-tglb3/igt@[email protected]

* igt@kms_mmap_write_crc@main:
- shard-kbl: [PASS][33] -> [DMESG-FAIL][34] ([i915#95])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-kbl3/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-kbl4/igt@[email protected]

* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][35] -> [SKIP][36] ([fdo#109441]) +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-iclb6/igt@kms_psr@psr2_sprite_plane_move.html

* igt@perf@blocking-parameterized:
- shard-iclb: [PASS][37] -> [FAIL][38] ([i915#1542])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-iclb5/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-iclb7/igt@[email protected]

* igt@perf_pmu@all-busy-idle-check-all:
- shard-hsw: [PASS][39] -> [TIMEOUT][40] ([i915#1958]) +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-hsw6/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-hsw7/igt@[email protected]
- shard-snb: [PASS][41] -> [TIMEOUT][42] ([i915#1958])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-snb5/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-snb2/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_reloc@basic-concurrent0:
- shard-glk: [FAIL][43] ([i915#1930]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-glk4/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-glk2/igt@[email protected]

* igt@gem_exec_whisper@basic-queues-all:
- shard-glk: [DMESG-WARN][45] ([i915#118] / [i915#95]) -> [PASS][46] +2 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-glk5/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-glk6/igt@[email protected]

* igt@gem_shrink@reclaim:
- shard-hsw: [SKIP][47] ([fdo#109271]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-hsw2/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-hsw8/igt@[email protected]

* igt@gem_userptr_blits@create-destroy-sync:
- shard-hsw: [TIMEOUT][49] ([i915#1958]) -> [PASS][50] +2 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-hsw8/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-hsw1/igt@[email protected]

* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-tglb: [SKIP][51] ([i915#1904]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-tglb3/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-tglb2/igt@[email protected]

* igt@i915_pm_rpm@system-suspend-execbuf:
- shard-kbl: [INCOMPLETE][53] ([i915#151] / [i915#155]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-kbl3/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-kbl4/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-64x64-onscreen:
- shard-kbl: [DMESG-FAIL][55] ([i915#54] / [i915#95]) -> [PASS][56] +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-kbl3/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-kbl2/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [DMESG-WARN][57] ([i915#180]) -> [PASS][58] +3 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-kbl2/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-kbl4/igt@[email protected]

* igt@kms_flip@busy-flip@a-hdmi-a2:
- shard-glk: [FAIL][59] ([i915#275]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-glk7/igt@kms_flip@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-glk9/igt@kms_flip@[email protected]

* igt@kms_flip_tiling@flip-changes-tiling-yf:
- shard-kbl: [DMESG-FAIL][61] ([i915#95]) -> [PASS][62] +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-kbl6/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-kbl1/igt@[email protected]
- shard-apl: [DMESG-FAIL][63] ([i915#1635] / [i915#95]) -> [PASS][64] +2 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-apl3/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-apl4/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-gtt:
- shard-iclb: [DMESG-WARN][65] ([i915#1982]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-gtt.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-gtt.html

* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-wc:
- shard-tglb: [DMESG-WARN][67] ([i915#1982]) -> [PASS][68] +2 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-tglb5/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-tglb1/igt@[email protected]

* igt@kms_invalid_dotclock:
- shard-snb: [TIMEOUT][69] ([i915#1958]) -> [PASS][70] +3 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-snb6/igt@kms_invalid_dotclock.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-snb1/igt@kms_invalid_dotclock.html

* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-mid:
- shard-kbl: [DMESG-FAIL][71] ([fdo#108145] / [i915#95]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-kbl3/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-kbl2/igt@[email protected]
- shard-apl: [DMESG-FAIL][73] ([fdo#108145] / [i915#1635] / [i915#95]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-apl3/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-apl8/igt@[email protected]

* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [SKIP][75] ([fdo#109642] / [fdo#111068]) -> [PASS][76] +1 similar issue
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-iclb7/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-iclb2/igt@[email protected]

* igt@kms_psr@psr2_suspend:
- shard-iclb: [SKIP][77] ([fdo#109441]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-iclb6/igt@kms_psr@psr2_suspend.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-iclb2/igt@kms_psr@psr2_suspend.html

* igt@kms_vblank@pipe-b-ts-continuation-dpms-rpm:
- shard-apl: [DMESG-WARN][79] ([i915#1635] / [i915#95]) -> [PASS][80] +27 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-apl7/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-apl3/igt@[email protected]

* igt@perf_pmu@semaphore-busy@rcs0:
- shard-kbl: [FAIL][81] ([i915#1820]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-kbl3/igt@perf_pmu@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-kbl6/igt@perf_pmu@[email protected]

* igt@prime_vgem@basic-blt:
- shard-tglb: [DMESG-WARN][83] ([i915#402]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-tglb8/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-tglb7/igt@[email protected]

* igt@syncobj_wait@multi-wait-submitted-signaled:
- shard-kbl: [DMESG-WARN][85] ([i915#93] / [i915#95]) -> [PASS][86] +38 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-kbl2/igt@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-kbl1/igt@[email protected]

#### Warnings ####

* igt@i915_pm_rpm@modeset-pc8-residency-stress:
- shard-apl: [SKIP][87] ([fdo#109271]) -> [SKIP][88] ([fdo#109271] / [i915#1635]) +19 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-apl8/igt@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-apl4/igt@[email protected]

* igt@kms_big_fb@linear-32bpp-rotate-90:
- shard-snb: [SKIP][89] ([fdo#109271]) -> [TIMEOUT][90] ([i915#1958]) +3 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-snb1/igt@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-snb2/igt@[email protected]

* igt@kms_big_fb@y-tiled-32bpp-rotate-90:
- shard-hsw: [TIMEOUT][91] ([i915#1958]) -> [SKIP][92] ([fdo#109271]) +1 similar issue
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-hsw8/igt@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-hsw8/igt@[email protected]

* igt@kms_color_chamelium@pipe-a-ctm-limited-range:
- shard-apl: [SKIP][93] ([fdo#109271] / [fdo#111827] / [i915#1635]) -> [SKIP][94] ([fdo#109271] / [fdo#111827]) +1 similar issue
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-apl1/igt@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-apl7/igt@[email protected]

* igt@kms_color_chamelium@pipe-b-ctm-limited-range:
- shard-apl: [SKIP][95] ([fdo#109271] / [fdo#111827]) -> [SKIP][96] ([fdo#109271] / [fdo#111827] / [i915#1635])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-apl3/igt@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-apl6/igt@[email protected]

* igt@kms_draw_crc@draw-method-rgb565-render-ytiled:
- shard-snb: [TIMEOUT][97] ([i915#1958]) -> [SKIP][98] ([fdo#109271]) +1 similar issue
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-snb6/igt@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-snb4/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-pwrite:
- shard-hsw: [SKIP][99] ([fdo#109271]) -> [TIMEOUT][100] ([i915#1958]) +2 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-hsw6/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-pwrite.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-hsw7/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-pwrite.html

* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-blt:
- shard-apl: [SKIP][101] ([fdo#109271] / [i915#1635]) -> [SKIP][102] ([fdo#109271]) +12 similar issues
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-apl6/igt@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-apl7/igt@[email protected]

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-kbl: [DMESG-WARN][103] ([i915#180]) -> [DMESG-WARN][104] ([i915#93] / [i915#95])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8664/shard-kbl6/igt@[email protected]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4704/shard-kbl2/igt@[email protected]

Participating hosts (11 -> 8)
------------------------------

Missing (3): pig-skl-6260u pig-glk-j5005 pig-icl-1065g7

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5717 -> IGTPW_4704
* Piglit: piglit_4509 -> None

== Logs ==