Revert device tree changes for EUD
Subsystems (5)
cover Revert device tree changes for EUD
Revert the device tree changes for Embedded USB Debugger(EUD) from the usb tree to avoid conflicts as device tree changes for EUD are supposed to go from qcom Tree.
Changes in this patch
*Fixed the issue with revert statement.
*Added the signed-off tag.
Souradeep Chowdhury (2):
Revert "arm64: dts: qcom: sc7280: Set the default dr_mode for usb2" Revert "arm64: dts: qcom: sc7280: Add EUD dt node and dwc3 connector"
arch/arm64/boot/dts/qcom/sc7280-idp.dts | 4 ---- arch/arm64/boot/dts/qcom/sc7280.dtsi | 36 --------------------------------- 2 files changed, 40 deletions(-)
--
2.7.4
PATCH RESEND 1/2 Revert "arm64: dts: qcom: sc7280: Set the default dr_mode for usb2"
This reverts commit c18553956f34819e224a79c9890eba2ba0604e15.
Revert the change to set dr_mode for usb2 in case of Embedded USB Debugger(EUD).
--- arch/arm64/boot/dts/qcom/sc7280-idp.dts | 4 ---- 1 file changed, 4 deletions(-)
arch/arm64/boot/dts/qcom/sc7280-idp.dts +0 -4
@@ -61,10 +61,6 @@ modem-init; }; -&usb_2_dwc3 { - dr_mode = "otg"; -}; - &pmk8350_rtc { status = "okay"; };
Signature · 1 line
2.7.4
Re: [Resend PATCH V1 1/2] Revert "arm64: dts: qcom: sc7280: Set the default dr_mode for usb2"
Quoted 4 lines · Souradeep Chowdhury
This reverts commit
c18553956f34819e224a79c9890eba2ba0604e15.Revert the change to set
dr_modefor usb2 in case of Embedded USB Debugger(EUD).
Why are you doing this? Changelog text needs to say why the change is needed, not just what it is doing.
thanks,
greg k-h
PATCH RESEND 2/2 Revert "arm64: dts: qcom: sc7280: Add EUD dt node and dwc3 connector"
In reply to Souradeep ChowdhuryThis reverts commit a0c68e493007a8c72b6b00f6ac95590a86edc937.
Revert all the changes to add the Embedded USB Debugger(EUD) Node in the device tree, the connector node and also changes to usb2 Node associated with this.
--- arch/arm64/boot/dts/qcom/sc7280.dtsi | 36 ------------------------------------ 1 file changed, 36 deletions(-)
arch/arm64/boot/dts/qcom/sc7280.dtsi +0 -36
@@ -2583,12 +2583,6 @@ phys = <&usb_2_hsphy>; phy-names = "usb2-phy"; maximum-speed = "high-speed"; - usb-role-switch; - port { - usb2_role_switch: endpoint { - remote-endpoint = <&eud_ep>; - }; - }; }; };
@@ -2630,36 +2624,6 @@ interrupts = <GIC_SPI 582 IRQ_TYPE_LEVEL_HIGH>; }; - eud: eud@88e0000 { - compatible = "qcom,sc7280-eud","qcom,eud"; - reg = <0 0x88e0000 0 0x2000>, - <0 0x88e2000 0 0x1000>; - interrupts-extended = <&pdc 11 IRQ_TYPE_LEVEL_HIGH>; - ports { - port@0 { - eud_ep: endpoint { - remote-endpoint = <&usb2_role_switch>; - }; - }; - port@1 { - eud_con: endpoint { - remote-endpoint = <&con_eud>; - }; - }; - }; - }; - - eud_typec: connector { - compatible = "usb-c-connector"; - ports { - port@0 { - con_eud: endpoint { - remote-endpoint = <&eud_con>; - }; - }; - }; - }; - nsp_noc: interconnect@a0c0000 { reg = <0 0x0a0c0000 0 0x10000>; compatible = "qcom,sc7280-nsp-noc";
Signature · 1 line
2.7.4
Re: [Resend PATCH V1 2/2] Revert "arm64: dts: qcom: sc7280: Add EUD dt node and dwc3 connector"
Quoted 5 lines · Souradeep Chowdhury
This reverts commit
a0c68e493007a8c72b6b00f6ac95590a86edc937.Revert all the changes to add the Embedded USB Debugger(EUD) Node in the device tree, the connector node and also changes to usb2 Node associated with this.
Again, why?
thanks,
greg k-h