Skip to contentSkip to conversation

Revert device tree changes for EUD

PATCH Superseded Souradeep Chowdhury 2 participants 6 messages Feb 18, 2022

Subsystems (5)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover Revert device tree changes for EUD

Revert the device tree changes for Embedded USB Debugger(EUD) from the usb tree to avoid conflicts as device tree changes for EUD are supposed to go from qcom Tree.

Souradeep Chowdhury (2):
Revert "arm64: dts: qcom: sc7280: Set the default dr_mode for usb2" Revert "arm64: dts: qcom: sc7280: Add EUD dt node and dwc3 connector"

 arch/arm64/boot/dts/qcom/sc7280-idp.dts |  4 ----
 arch/arm64/boot/dts/qcom/sc7280.dtsi    | 36 ---------------------------------
 2 files changed, 40 deletions(-)

--
2.7.4

#1 lore raw

PATCH 1/2 Revert "arm64: dts: qcom: sc7280: Set the default dr_mode for usb2"

Revert the change to set the dr_mode for usb2 in case of Embedded USB Debugger(EUD).

---
 arch/arm64/boot/dts/qcom/sc7280-idp.dts | 4 ----
 1 file changed, 4 deletions(-)
arch/arm64/boot/dts/qcom/sc7280-idp.dts +0 -4
index f40eaa5..9b991ba 100644
@@ -61,10 +61,6 @@
 	modem-init;
 };
 
-&usb_2_dwc3 {
-	dr_mode = "otg";
-};
-
 &pmk8350_rtc {
 	status = "okay";
 };

--
2.7.4

#2 lore raw

Re: [PATCH V1 1/2] Revert "arm64: dts: qcom: sc7280: Set the default dr_mode for usb2"

Quoted 22 lines · Souradeep Chowdhury

Revert the change to set the dr_mode for usb2 in case of Embedded USB Debugger(EUD).

---
 arch/arm64/boot/dts/qcom/sc7280-idp.dts | 4 ----
 1 file changed, 4 deletions(-)
arch/arm64/boot/dts/qcom/sc7280-idp.dts +0 -5
index f40eaa5..9b991ba 100644
@@ -61,10 +61,6 @@
 	modem-init;
 };
 
-&usb_2_dwc3 {
-	dr_mode = "otg";
-};
-
 &pmk8350_rtc {
 	status = "okay";
 };
--
Quoted 2 lines

2.7.4

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.

You are receiving this message because of the following common error(s) as indicated below:

- Your patch does not have a Signed-off-by: line. Please read the kernel file, Documentation/SubmittingPatches and resend it after adding that line. Note, the line needs to be in the body of the email, before the patch, not at the bottom of the patch or in the email signature.

If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.

thanks,

greg k-h's patch email bot

#3 lore raw

Re: [PATCH V1 1/2] Revert "arm64: dts: qcom: sc7280: Set the default dr_mode for usb2"

In reply to Souradeep Chowdhury
Quoted 5 lines · Souradeep Chowdhury

Revert the change to set the dr_mode for usb2 in case of Embedded USB Debugger(EUD).

---
 arch/arm64/boot/dts/qcom/sc7280-idp.dts | 4 ----
 1 file changed, 4 deletions(-)

Also, please use the normal format for reverting a change with the git id and the like. This is an odd style :(

greg k-h

#4 lore raw

PATCH 2/2 Revert "arm64: dts: qcom: sc7280: Add EUD dt node and dwc3 connector"

In reply to Souradeep Chowdhury

Revert all the changes to add the Embedded USB Debugger(EUD) Node in the device tree, the connector node and also changes to usb2 Node associated with this.

---
 arch/arm64/boot/dts/qcom/sc7280.dtsi | 36 ------------------------------------
 1 file changed, 36 deletions(-)
arch/arm64/boot/dts/qcom/sc7280.dtsi +0 -36
index 96917fe..937c2e0 100644
@@ -2583,12 +2583,6 @@
 				phys = <&usb_2_hsphy>;
 				phy-names = "usb2-phy";
 				maximum-speed = "high-speed";
-				usb-role-switch;
-				port {
-					usb2_role_switch: endpoint {
-						remote-endpoint = <&eud_ep>;
-					};
-				};
 			};
 		};
 
@@ -2630,36 +2624,6 @@
 			interrupts = <GIC_SPI 582 IRQ_TYPE_LEVEL_HIGH>;
 		};
 
-		eud: eud@88e0000 {
-			compatible = "qcom,sc7280-eud","qcom,eud";
-			reg = <0 0x88e0000 0 0x2000>,
-			      <0 0x88e2000 0 0x1000>;
-			interrupts-extended = <&pdc 11 IRQ_TYPE_LEVEL_HIGH>;
-			ports {
-				port@0 {
-					eud_ep: endpoint {
-						remote-endpoint = <&usb2_role_switch>;
-					};
-				};
-				port@1 {
-					eud_con: endpoint {
-						remote-endpoint = <&con_eud>;
-					};
-				};
-			};
-		};
-
-		eud_typec: connector {
-			compatible = "usb-c-connector";
-			ports {
-				port@0 {
-					con_eud: endpoint {
-						remote-endpoint = <&eud_con>;
-					};
-				};
-			};
-		};
-
 		nsp_noc: interconnect@a0c0000 {
 			reg = <0 0x0a0c0000 0 0x10000>;
 			compatible = "qcom,sc7280-nsp-noc";
Signature · 1 line
2.7.4
#5 lore raw

Re: [PATCH V1 2/2] Revert "arm64: dts: qcom: sc7280: Add EUD dt node and dwc3 connector"

Quoted 64 lines · Souradeep Chowdhury

Revert all the changes to add the Embedded USB Debugger(EUD) Node in the device tree, the connector node and also changes to usb2 Node associated with this.

---
 arch/arm64/boot/dts/qcom/sc7280.dtsi | 36 ------------------------------------
 1 file changed, 36 deletions(-)
arch/arm64/boot/dts/qcom/sc7280.dtsi +0 -36
index 96917fe..937c2e0 100644
@@ -2583,12 +2583,6 @@
 				phys = <&usb_2_hsphy>;
 				phy-names = "usb2-phy";
 				maximum-speed = "high-speed";
-				usb-role-switch;
-				port {
-					usb2_role_switch: endpoint {
-						remote-endpoint = <&eud_ep>;
-					};
-				};
 			};
 		};
 
@@ -2630,36 +2624,6 @@
 			interrupts = <GIC_SPI 582 IRQ_TYPE_LEVEL_HIGH>;
 		};
 
-		eud: eud@88e0000 {
-			compatible = "qcom,sc7280-eud","qcom,eud";
-			reg = <0 0x88e0000 0 0x2000>,
-			      <0 0x88e2000 0 0x1000>;
-			interrupts-extended = <&pdc 11 IRQ_TYPE_LEVEL_HIGH>;
-			ports {
-				port@0 {
-					eud_ep: endpoint {
-						remote-endpoint = <&usb2_role_switch>;
-					};
-				};
-				port@1 {
-					eud_con: endpoint {
-						remote-endpoint = <&con_eud>;
-					};
-				};
-			};
-		};
-
-		eud_typec: connector {
-			compatible = "usb-c-connector";
-			ports {
-				port@0 {
-					con_eud: endpoint {
-						remote-endpoint = <&eud_con>;
-					};
-				};
-			};
-		};
-
 		nsp_noc: interconnect@a0c0000 {
 			reg = <0 0x0a0c0000 0 0x10000>;
 			compatible = "qcom,sc7280-nsp-noc";
Signature · 1 line
2.7.4

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.

You are receiving this message because of the following common error(s) as indicated below:

- Your patch does not have a Signed-off-by: line. Please read the kernel file, Documentation/SubmittingPatches and resend it after adding that line. Note, the line needs to be in the body of the email, before the patch, not at the bottom of the patch or in the email signature.

If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.

thanks,

greg k-h's patch email bot