Add support for QMC HDLC, framer infrastruture and PEF2256 framer (v4)
Subsystems (16)
v4 cover Add support for QMC HDLC, framer infrastruture and PEF2256 framer (v4)
From: Herve Codina <[email protected]>
Hi,
TLDR: This is a resend of v3 with a build failure fix in patch 21. No other changes.
I have a system where I need to handle an HDLC interface and some audio data.
The HDLC data are transferred using a TDM bus on which a PEF2256 (E1/T1 framer) is present. The PEF2256 transfers data from/to the TDM bus to/from the E1 line. This PEF2256 is connected to a PowerQUICC SoC for the control path and the TDM is connected to the SoC (QMC component) for the data path.
From the QMC HDLC driver, I need to handle HDLC data using the QMC, carrier detection using the PEF2256 (E1 line carrier) and set/get some PEF2256 configuration.
The QMC HDLC driver considers the PEF2256 as a generic framer. It performs operations that involve the PEF2256 through the generic framer API.
The audio data are exchanged with the PEF2256 using a CPU DAI connected to the TDM bus through the QMC and the PEF2256 needs to be seen as a codec in order to be linked to the CPU DAI.
The codec handles the carrier detection using the PEF2256 and reports the carrier state to the ALSA subsystem using the ASoC jack detection.
The codec, even if instantiated by the PEF2256 driver, considers the PEF2256 as a generic framer.
The generic framer has:
- 2 consumers (QMC HDLC drv and codec)
- 1 provider (PEF2256)
So, the design is the following:
+------------------+ +---------+
| QMC | <- TDM -> | PEF2256 | <-> E1
+---------+ | +-------------+ | | |
| CPU DAI | <-data--> | QMC channel | | | |
+---------+ | +-------------+ | | |
+--------------+ | +-------------+ | | |
| QMC HDLC drv | <-data--> | QMC channel | | | |
+--------------+ | +-------------+ | | |
^ +------------------+ | |
| +--------+ +-------------+ | |
+-> | framer | <-> | PEF2256 drv | <- local bus ->| |
| | | | +---------+
+-> | | | |
| +--------+ | +-------+ |
+-------------------> | codec | |
| +-------+ |
+-------------+Further more, the TDM timeslots used by the QMC HDLC driver need to be configured at runtime (QMC dynamic timeslots).
Several weeks ago, I sent two series related to this topic:
- Add the Lantiq PEF2256 audio support [1]
- RFC Add support for QMC HDLC and PHY [2]
This current series is a rework of these two series taking into account feedbacks previously received.
In order to implement all of this, I do the following:
1) Perform some fixes (patches 1, 2, 3, 4)
2) Introduce the QMC HDLC driver (patches 5, 6, 7)
3) Add QMC dynamic timeslot support (patches 8 - 18)
4) Add timeslots change support in QMC HDLC (patch 19)
5) Introduce framer infrastructure (patch 20)
6) Add PEF2256 framer provider (patches 11, 22, 23, 24, 25)
7) Add framer codec as a framer consumer (patch 26)
8) Add framer support as a framer consumer in QMC HDLC (patch 27, 28)
The series contains the full story and detailed modifications. If needed, the series can be split and/or commmits can be squashed. Let me know.
Compare to the previous iteration
https://lore.kernel.org/linux-kernel/[email protected]/
This v3 series mainly:
- Fixes some implementation details.
- Adds a new patch (patch 5) to remove existing inline keyword in the QMC driver.
- Squashes patches related to the QMC HDLC binding together.
Best regards,
Hervé
[1]: https://lore.kernel.org/all/[email protected]/
[2]: https://lore.kernel.org/all/[email protected]/
Changes v3 -> v4
- Fixes build failure with CONFIG_MODULES in patch 21 (net: wan: Add framer framework support)
Changes v2 -> v3
- Patches 1, 2, 3, 4
Add 'Reviewed-by: Christophe Leroy <[email protected]>'
- New patch
Remove inline keyword from the existing registers accessors helpers
- Patch 6 (patches 5, 27 in v2)
Update the binding title
Squash patch 27
- Patch 7 (patch 6 in v2)
Remove the cast in netdev_to_qmc_hdlc()
Add 'Reviewed-by: Christophe Leroy <[email protected]>'
- Patch 8 (patch 7 in v2): No change
- Patches 9, 10 (patches 8, 9 in v2)
Add 'Reviewed-by: Christophe Leroy <[email protected]>'
- Patch 11 (patch 10 in v2)
Remove inline keyword from the introduced qmc_clrsetbits16() helper Add 'Reviewed-by: Christophe Leroy <[email protected]>'
- Patches 12, 13, 14, 15, 16, 17, 18, 19, 20
Add 'Reviewed-by: Christophe Leroy <[email protected]>'
- Patch 21 (patch 20 in v2)
Remove unneeded framer NULL pointer check
Add 'Reviewed-by: Christophe Leroy <[email protected]>'
- Patch 22 (patch 21 in v2)
Change sclkr and sclkx clocks description
Remove the framer phandle property from the framer subnodes (ie. from framer-codec nodes)
- Patch 23 (patch 22 in v2)
Initialize 'disabled' variable at declaration
Fix commit log
Add 'Reviewed-by: Christophe Leroy <[email protected]>'
- Patch 24 (patch 23 in v2)
Remove inline keyword from the existing registers accessors helpers Use dev_warn_ratelimited() in default interrupt handler Add 'Reviewed-by: Christophe Leroy <[email protected]>'
- Patch 25 (patch 24 in v2)
Replace #include "linux/bitfield.h" by #include <linux/bitfield.h> Fold the pinctrl anonymous struct into the struct pef2256_pinctrl Update commit log
Add 'Reviewed-by: Christophe Leroy <[email protected]>'
- Patch 26 (patch 25 in v2)
Add 'Reviewed-by: Christophe Leroy <[email protected]>'
- Patch 27 (patch 26 in v2)
Fix error message
Changed the ch.max computation in framer_dai_hw_rule_channels_by_format() Add 'Reviewed-by: Christophe Leroy <[email protected]>'
- Patch 28
Add 'Reviewed-by: Christophe Leroy <[email protected]>'
Changes v1 -> v2
- Patches 1, 2 (New in v2)
Fix __iomem addresses declaration
- Patch 19 (17 in v1)
Fix a compilation warning
- Patch 26 (24 in v1)
Fix a typo in Kconfig file
Fix issues raised by sparse (make C=1)
Herve Codina (28):
soc: fsl: cpm1: tsa: Fix __iomem addresses declaration
soc: fsl: cpm1: qmc: Fix __iomem addresses declaration
soc: fsl: cpm1: qmc: Fix rx channel reset
soc: fsl: cpm1: qmc: Extend the API to provide Rx status
soc: fsl: cpm1: qmc: Remove inline function specifiers
dt-bindings: net: Add support for QMC HDLC
net: wan: Add support for QMC HDLC
MAINTAINERS: Add the Freescale QMC HDLC driver entry
soc: fsl: cpm1: qmc: Introduce available timeslots masks
soc: fsl: cpm1: qmc: Rename qmc_setup_tsa* to qmc_init_tsa*
soc: fsl: cpm1: qmc: Introduce qmc_chan_setup_tsa*
soc: fsl: cpm1: qmc: Remove no more needed checks from
qmc_check_chans()
soc: fsl: cpm1: qmc: Check available timeslots in qmc_check_chans()
soc: fsl: cpm1: qmc: Add support for disabling channel TSA entries
soc: fsl: cpm1: qmc: Split Tx and Rx TSA entries setup
soc: fsl: cpm1: qmc: Introduce is_tsa_64rxtx flag
soc: fsl: cpm1: qmc: Handle timeslot entries at channel start() and
stop()
soc: fsl: cpm1: qmc: Remove timeslots handling from setup_chan()
soc: fsl: cpm1: qmc: Introduce functions to change timeslots at
runtime
wan: qmc_hdlc: Add runtime timeslots changes support
net: wan: Add framer framework support
dt-bindings: net: Add the Lantiq PEF2256 E1/T1/J1 framer
mfd: core: Ensure disabled devices are skiped without aborting
net: wan: framer: Add support for the Lantiq PEF2256 framer
pinctrl: Add support for the Lantic PEF2256 pinmux
MAINTAINERS: Add the Lantiq PEF2256 driver entry
ASoC: codecs: Add support for the framer codec
net: wan: fsl_qmc_hdlc: Add framer support
.../devicetree/bindings/net/fsl,qmc-hdlc.yaml | 46 + .../bindings/net/lantiq,pef2256.yaml | 219 +++++ MAINTAINERS | 17 + drivers/mfd/mfd-core.c | 17 +- drivers/net/wan/Kconfig | 14 + drivers/net/wan/Makefile | 3 + drivers/net/wan/framer/Kconfig | 35 + drivers/net/wan/framer/Makefile | 7 + drivers/net/wan/framer/framer-core.c | 886 ++++++++++++++++++ drivers/net/wan/framer/pef2256/Makefile | 8 + drivers/net/wan/framer/pef2256/pef2256-regs.h | 250 +++++ drivers/net/wan/framer/pef2256/pef2256.c | 880 +++++++++++++++++ drivers/net/wan/fsl_qmc_hdlc.c | 820 ++++++++++++++++ drivers/pinctrl/Kconfig | 14 + drivers/pinctrl/Makefile | 1 + drivers/pinctrl/pinctrl-pef2256-regs.h | 65 ++ drivers/pinctrl/pinctrl-pef2256.c | 308 ++++++ drivers/soc/fsl/qe/qmc.c | 501 ++++++++-- drivers/soc/fsl/qe/tsa.c | 22 +- include/linux/framer/framer-provider.h | 194 ++++ include/linux/framer/framer.h | 199 ++++ include/linux/framer/pef2256.h | 31 + include/soc/fsl/qe/qmc.h | 25 +- sound/soc/codecs/Kconfig | 15 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/framer-codec.c | 413 ++++++++ sound/soc/fsl/fsl_qmc_audio.c | 2 +- 27 files changed, 4872 insertions(+), 122 deletions(-) create mode 100644 Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml create mode 100644 Documentation/devicetree/bindings/net/lantiq,pef2256.yaml create mode 100644 drivers/net/wan/framer/Kconfig create mode 100644 drivers/net/wan/framer/Makefile create mode 100644 drivers/net/wan/framer/framer-core.c create mode 100644 drivers/net/wan/framer/pef2256/Makefile create mode 100644 drivers/net/wan/framer/pef2256/pef2256-regs.h create mode 100644 drivers/net/wan/framer/pef2256/pef2256.c create mode 100644 drivers/net/wan/fsl_qmc_hdlc.c create mode 100644 drivers/pinctrl/pinctrl-pef2256-regs.h create mode 100644 drivers/pinctrl/pinctrl-pef2256.c create mode 100644 include/linux/framer/framer-provider.h create mode 100644 include/linux/framer/framer.h create mode 100644 include/linux/framer/pef2256.h create mode 100644 sound/soc/codecs/framer-codec.c
Signature · 7 lines
2.41.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH v4 1/28 soc: fsl: cpm1: tsa: Fix __iomem addresses declaration
From: Herve Codina <[email protected]>
Running sparse (make C=1) on tsa.c raises a lot of warning such as:
--- 8< ---
warning: incorrect type in assignment (different address spaces)
expected void *[noderef] si_regs
got void [noderef] __iomem *
--- 8< ---
Indeed, some variable were declared 'type *__iomem var' instead of 'type __iomem *var'.
Use the correct declaration to remove these warnings.
--- drivers/soc/fsl/qe/tsa.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-)
drivers/soc/fsl/qe/tsa.c +11 -11
@@ -98,9 +98,9 @@#define TSA_SIRP 0x10struct tsa_entries_area { -void *__iomem entries_start; -void *__iomem entries_next; -void *__iomem last_entry; +void __iomem *entries_start; +void __iomem *entries_next; +void __iomem *last_entry; };struct tsa_tdm {
@@ -117,8 +117,8 @@ struct tsa_tdm {struct tsa {struct device *dev; -void *__iomem si_regs; -void *__iomem si_ram; +void __iomem *si_regs; +void __iomem *si_ram;resource_size_t si_ram_sz;spinlock_t lock;int tdms;/* TSA_TDMx ORed */
@@ -135,27 +135,27 @@ static inline struct tsa *tsa_serial_get_tsa(struct tsa_serial *tsa_serial) return container_of(tsa_serial, struct tsa, serials[tsa_serial->id]); } -static inline void tsa_write32 (void *__iomem addr,u32 val) +static inline void tsa_write32 (void __iomem *addr,u32 val) {iowrite32be (val, addr); } -static inline void tsa_write8 (void *__iomem addr,u32 val) +static inline void tsa_write8 (void __iomem *addr,u32 val) {iowrite8 (val, addr); } -static inline u32 tsa_read32 (void *__iomem addr) +static inline u32 tsa_read32 (void __iomem *addr) {return ioread32be (addr); } -static inline void tsa_clrbits32 (void *__iomem addr,u32 clr) +static inline void tsa_clrbits32 (void __iomem *addr,u32 clr) {tsa_write32 (addr,tsa_read32 (addr) & ~clr); } -static inline void tsa_clrsetbits32 (void *__iomem addr,u32 clr,u32 set) +static inline void tsa_clrsetbits32 (void __iomem *addr,u32 clr,u32 set) {tsa_write32 (addr, (tsa_read32 (addr) & ~clr) | set); }
@@ -313,7 +313,7 @@ static u32 tsa_serial_id2csel(struct tsa *tsa, u32 serial_id)static int tsa_add_entry (struct tsa *tsa,struct tsa_entries_area *area,u32 count,u32 serial_id) { -void *__iomem addr; +void __iomem *addr;u32 left;u32 val;u32 cnt;
Signature · 1 line
2.41.0
PATCH v4 2/28 soc: fsl: cpm1: qmc: Fix __iomem addresses declaration
In reply to Christophe LeroyFrom: Herve Codina <[email protected]>
Running sparse (make C=1) on qmc.c raises a lot of warning such as:
...
warning: incorrect type in assignment (different address spaces)
expected struct cpm_buf_desc [usertype] *[noderef] __iomem bd got struct cpm_buf_desc [noderef] [usertype] __iomem *txbd_free
...
Indeed, some variable were declared 'type *__iomem var' instead of 'type __iomem *var'.
Use the correct declaration to remove these warnings.
--- drivers/soc/fsl/qe/qmc.c | 34 +++++++++++++++++----------------- 1 file changed, 17 insertions(+), 17 deletions(-)
drivers/soc/fsl/qe/qmc.c +17 -17
@@ -175,7 +175,7 @@ struct qmc_chan {struct list_head list;unsigned int id;struct qmc *qmc; -void *__iomem s_param; +void __iomem *s_param;enum qmc_mode mode;u64 tx_ts_mask;u64 rx_ts_mask;
@@ -203,9 +203,9 @@ struct qmc_chan {struct qmc {struct device *dev;struct tsa_serial *tsa_serial; -void *__iomem scc_regs; -void *__iomem scc_pram; -void *__iomem dpram; +void __iomem *scc_regs; +void __iomem *scc_pram; +void __iomem *dpram;u16 scc_pram_offset;cbd_t __iomem *bd_table;dma_addr_t bd_dma_addr;
@@ -218,37 +218,37 @@ struct qmc {struct qmc_chan *chans[64 ]; }; -static inline void qmc_write16 (void *__iomem addr,u16 val) +static inline void qmc_write16 (void __iomem *addr,u16 val) {iowrite16be (val, addr); } -static inline u16 qmc_read16 (void *__iomem addr) +static inline u16 qmc_read16 (void __iomem *addr) {return ioread16be (addr); } -static inline void qmc_setbits16 (void *__iomem addr,u16 set) +static inline void qmc_setbits16 (void __iomem *addr,u16 set) {qmc_write16 (addr,qmc_read16 (addr) | set); } -static inline void qmc_clrbits16 (void *__iomem addr,u16 clr) +static inline void qmc_clrbits16 (void __iomem *addr,u16 clr) {qmc_write16 (addr,qmc_read16 (addr) & ~clr); } -static inline void qmc_write32 (void *__iomem addr,u32 val) +static inline void qmc_write32 (void __iomem *addr,u32 val) {iowrite32be (val, addr); } -static inline u32 qmc_read32 (void *__iomem addr) +static inline u32 qmc_read32 (void __iomem *addr) {return ioread32be (addr); } -static inline void qmc_setbits32 (void *__iomem addr,u32 set) +static inline void qmc_setbits32 (void __iomem *addr,u32 set) {qmc_write32 (addr,qmc_read32 (addr) | set); }
@@ -318,7 +318,7 @@ int qmc_chan_write_submit(struct qmc_chan *chan, dma_addr_t addr, size_t length, {struct qmc_xfer_desc *xfer_desc;unsigned long flags; -cbd_t *__iomem bd; +cbd_t __iomem *bd;u16 ctrl;int ret;
@@ -374,7 +374,7 @@ static void qmc_chan_write_done(struct qmc_chan *chan)void (*complete)(void *context);unsigned long flags;void *context; -cbd_t *__iomem bd; +cbd_t __iomem *bd;u16 ctrl;/*
@@ -425,7 +425,7 @@ int qmc_chan_read_submit(struct qmc_chan *chan, dma_addr_t addr, size_t length, {struct qmc_xfer_desc *xfer_desc;unsigned long flags; -cbd_t *__iomem bd; +cbd_t __iomem *bd;u16 ctrl;int ret;
@@ -488,7 +488,7 @@ static void qmc_chan_read_done(struct qmc_chan *chan)void (*complete)(void *context,size_t size);struct qmc_xfer_desc *xfer_desc;unsigned long flags; -cbd_t *__iomem bd; +cbd_t __iomem *bd;void *context;u16 datalen;u16 ctrl;
@@ -663,7 +663,7 @@ static void qmc_chan_reset_rx(struct qmc_chan *chan) {struct qmc_xfer_desc *xfer_desc;unsigned long flags; -cbd_t *__iomem bd; +cbd_t __iomem *bd;u16 ctrl;spin_lock_irqsave (&chan->rx_lock, flags);
@@ -694,7 +694,7 @@ static void qmc_chan_reset_tx(struct qmc_chan *chan) {struct qmc_xfer_desc *xfer_desc;unsigned long flags; -cbd_t *__iomem bd; +cbd_t __iomem *bd;u16 ctrl;spin_lock_irqsave (&chan->tx_lock, flags);
Signature · 7 lines
2.41.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH v4 3/28 soc: fsl: cpm1: qmc: Fix rx channel reset
In reply to Christophe LeroyFrom: Herve Codina <[email protected]>
The qmc_chan_reset_rx() set the is_rx_stopped flag. This leads to an inconsistent state in the following sequence.
qmc_chan_stop()
qmc_chan_reset()Indeed, after the qmc_chan_reset() call, the channel must still be stopped. Only a qmc_chan_start() call can move the channel from stopped state to started state.
Fix the issue removing the is_rx_stopped flag setting from qmc_chan_reset()
--- drivers/soc/fsl/qe/qmc.c | 1 - 1 file changed, 1 deletion(-)
drivers/soc/fsl/qe/qmc.c +0 -1
@@ -685,7 +685,6 @@ static void qmc_chan_reset_rx(struct qmc_chan *chan) qmc_read16(chan->s_param + QMC_SPE_RBASE)); chan->rx_pending =0 ; - chan->is_rx_stopped = false;spin_unlock_irqrestore (&chan->rx_lock, flags); }
Signature · 7 lines
2.41.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH v4 4/28 soc: fsl: cpm1: qmc: Extend the API to provide Rx status
In reply to Christophe LeroyFrom: Herve Codina <[email protected]>
In HDLC mode, some status flags related to the data read transfer can be set by the hardware and need to be known by a QMC consumer for further analysis.
Extend the API in order to provide these transfer status flags at the read complete() call.
In TRANSPARENT mode, these flags have no meaning. Keep only one read complete() API and update the consumers working in transparent mode. In this case, the newly introduced flags parameter is simply unused.
--- drivers/soc/fsl/qe/qmc.c | 29 +++++++++++++++++++++++++---- include/soc/fsl/qe/qmc.h | 15 ++++++++++++++- sound/soc/fsl/fsl_qmc_audio.c | 2 +- 3 files changed, 40 insertions(+), 6 deletions(-)
drivers/soc/fsl/qe/qmc.c +25 -4
@@ -166,7 +166,7 @@struct qmc_xfer_desc {union {void (*tx_complete)(void *context); -void (*rx_complete)(void *context,size_t length); +void (*rx_complete)(void *context,size_t length,unsigned int flags); };void *context; };
@@ -421,7 +421,8 @@ static void qmc_chan_write_done(struct qmc_chan *chan) }int qmc_chan_read_submit (struct qmc_chan *chan,dma_addr_t addr,size_t length, -void (*complete)(void *context,size_t length),void *context) +void (*complete)(void *context,size_t length,unsigned int flags), +void *context) {struct qmc_xfer_desc *xfer_desc;unsigned long flags;
@@ -454,6 +455,10 @@ int qmc_chan_read_submit(struct qmc_chan *chan, dma_addr_t addr, size_t length, xfer_desc->rx_complete = complete; xfer_desc->context = context; +/* Clear previous status flags */ + ctrl &= ~(QMC_BD_RX_L |QMC_BD_RX_F |QMC_BD_RX_LG |QMC_BD_RX_NO | +QMC_BD_RX_AB |QMC_BD_RX_CR ); +/* Activate the descriptor */ ctrl |= (QMC_BD_RX_E |QMC_BD_RX_UB );wmb ();/* Be sure to flush data before descriptor activation */
@@ -485,7 +490,7 @@ EXPORT_SYMBOL(qmc_chan_read_submit);static void qmc_chan_read_done (struct qmc_chan *chan) { -void (*complete)(void *context,size_t size); +void (*complete)(void *context,size_t size,unsigned int flags);struct qmc_xfer_desc *xfer_desc;unsigned long flags;cbd_t __iomem *bd;
@@ -527,7 +532,23 @@ static void qmc_chan_read_done(struct qmc_chan *chan)if (complete) {spin_unlock_irqrestore (&chan->rx_lock, flags); -complete (context, datalen); + +/* +* Avoid conversion between internal hardware flags and +* the software API flags. +* -> Be sure that the software API flags are consistent +* with the hardware flags +*/ +BUILD_BUG_ON (QMC_RX_FLAG_HDLC_LAST !=QMC_BD_RX_L ); +BUILD_BUG_ON (QMC_RX_FLAG_HDLC_FIRST !=QMC_BD_RX_F ); +BUILD_BUG_ON (QMC_RX_FLAG_HDLC_OVF !=QMC_BD_RX_LG ); +BUILD_BUG_ON (QMC_RX_FLAG_HDLC_UNA !=QMC_BD_RX_NO ); +BUILD_BUG_ON (QMC_RX_FLAG_HDLC_ABORT !=QMC_BD_RX_AB ); +BUILD_BUG_ON (QMC_RX_FLAG_HDLC_CRC !=QMC_BD_RX_CR ); + +complete (context, datalen, + ctrl & (QMC_BD_RX_L |QMC_BD_RX_F |QMC_BD_RX_LG | +QMC_BD_RX_NO |QMC_BD_RX_AB |QMC_BD_RX_CR ));spin_lock_irqsave (&chan->rx_lock, flags); }
include/soc/fsl/qe/qmc.h +14 -1
@@ -9,6 +9,7 @@#ifndef __SOC_FSL_QMC_H__#define __SOC_FSL_QMC_H__ +#include <linux/bits.h> #include <linux/types.h> struct device_node ;
@@ -56,8 +57,20 @@ int qmc_chan_set_param(struct qmc_chan *chan, const struct qmc_chan_param *paramint qmc_chan_write_submit (struct qmc_chan *chan,dma_addr_t addr,size_t length,void (*complete)(void *context),void *context); +/* Flags available (ORed) for read complete() flags parameter in HDLC mode. +* No flags are available in transparent mode and the read complete() flags +* parameter has no meaning in transparent mode. +*/ +#define QMC_RX_FLAG_HDLC_LAST BIT(11)/* Last in frame */ +#define QMC_RX_FLAG_HDLC_FIRST BIT(10)/* First in frame */ +#define QMC_RX_FLAG_HDLC_OVF BIT(5)/* Data overflow */ +#define QMC_RX_FLAG_HDLC_UNA BIT(4)/* Unaligned (ie. bits received not multiple of 8) */ +#define QMC_RX_FLAG_HDLC_ABORT BIT(3)/* Received an abort sequence (seven consecutive ones) */ +#define QMC_RX_FLAG_HDLC_CRC BIT(2)/* CRC error */ +int qmc_chan_read_submit (struct qmc_chan *chan,dma_addr_t addr,size_t length, -void (*complete)(void *context,size_t length), +void (*complete)(void *context,size_t length, +unsigned int flags),void *context);#define QMC_CHAN_READ (1<<0)
sound/soc/fsl/fsl_qmc_audio.c +1 -1
@@ -99,7 +99,7 @@ static void qmc_audio_pcm_write_complete(void *context)snd_pcm_period_elapsed (prtd->substream); } -static void qmc_audio_pcm_read_complete (void *context,size_t length) +static void qmc_audio_pcm_read_complete (void *context,size_t length,unsigned int flags) {struct qmc_dai_prtd *prtd = context;int ret;
Signature · 1 line
2.41.0
PATCH v4 5/28 soc: fsl: cpm1: qmc: Remove inline function specifiers
In reply to Christophe LeroyFrom: Herve Codina <[email protected]>
The inline function specifier is present on some functions but it is better to let the compiler decide inlining or not these functions.
Remove inline specifiers.
--- drivers/soc/fsl/qe/qmc.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/soc/fsl/qe/qmc.c +7 -7
@@ -218,37 +218,37 @@ struct qmc {struct qmc_chan *chans[64 ]; }; -static inline void qmc_write16 (void __iomem *addr,u16 val) +static void qmc_write16 (void __iomem *addr,u16 val) {iowrite16be (val, addr); } -static inline u16 qmc_read16 (void __iomem *addr) +static u16 qmc_read16 (void __iomem *addr) {return ioread16be (addr); } -static inline void qmc_setbits16 (void __iomem *addr,u16 set) +static void qmc_setbits16 (void __iomem *addr,u16 set) {qmc_write16 (addr,qmc_read16 (addr) | set); } -static inline void qmc_clrbits16 (void __iomem *addr,u16 clr) +static void qmc_clrbits16 (void __iomem *addr,u16 clr) {qmc_write16 (addr,qmc_read16 (addr) & ~clr); } -static inline void qmc_write32 (void __iomem *addr,u32 val) +static void qmc_write32 (void __iomem *addr,u32 val) {iowrite32be (val, addr); } -static inline u32 qmc_read32 (void __iomem *addr) +static u32 qmc_read32 (void __iomem *addr) {return ioread32be (addr); } -static inline void qmc_setbits32 (void __iomem *addr,u32 set) +static void qmc_setbits32 (void __iomem *addr,u32 set) {qmc_write32 (addr,qmc_read32 (addr) | set); }
Signature · 7 lines
2.41.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH v4 6/28 dt-bindings: net: Add support for QMC HDLC
In reply to Christophe LeroyFrom: Herve Codina <[email protected]>
The QMC (QUICC mutichannel controller) is a controller present in some PowerQUICC SoC such as MPC885.
The QMC HDLC uses the QMC controller to transfer HDLC data.
Additionally, a framer can be connected to the QMC HDLC.
If present, this framer is the interface between the TDM bus used by the QMC HDLC and the E1/T1 line.
The QMC HDLC can use this framer to get information about the E1/T1 line and configure the E1/T1 line.
--- .../devicetree/bindings/net/fsl,qmc-hdlc.yaml | 46 +++++++++++++++++++ 1 file changed, 46 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml
Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml new file +46 -0
@@ -0,0 +1,46 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/fsl,qmc-hdlc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Freescale/NXP QUICC Multichannel Controller (QMC) HDLC + +maintainers: + - Herve Codina <[email protected]> + +description: | + The QMC HDLC uses a QMC (QUICC Multichannel Controller) channel to transfer + HDLC data. + +properties: + compatible: + const: fsl,qmc-hdlc + + fsl,qmc-chan: + $ref: /schemas/types.yaml#/definitions/phandle-array + items: + - items: + - description: phandle to QMC node + - description: Channel number + description: + Should be a phandle/number pair. The phandle to QMC node and the QMC + channel to use. + + framer: + $ref: /schemas/types.yaml#/definitions/phandle + description: + phandle to the framer node + +required: + - compatible + - fsl,qmc-chan + +additionalProperties: false + +examples: + - | + hdlc { + compatible = "fsl,qmc-hdlc"; + fsl,qmc-chan = <&qmc 16>; + };
Signature · 7 lines
2.41.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Rob Herring
maintainerRe: [PATCH v4 06/28] dt-bindings: net: Add support for QMC HDLC
Quoted 27 lines · Christophe Leroy
From: Herve Codina <[email protected]>
The QMC (QUICC mutichannel controller) is a controller present in some PowerQUICC SoC such as MPC885.
The QMC HDLC uses the QMC controller to transfer HDLC data.Additionally, a framer can be connected to the QMC HDLC.
If present, this framer is the interface between the TDM bus used by the QMC HDLC and the E1/T1 line.
The QMC HDLC can use this framer to get information about the E1/T1 line and configure the E1/T1 line.Signed-off-by Herve Codina <[email protected]>Signed-off-by Christophe Leroy <[email protected]>--- .../devicetree/bindings/net/fsl,qmc-hdlc.yaml | 46 +++++++++++++++++++ 1 file changed, 46 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yamlDocumentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml new file +2
-0@@ -0,0 +1,46 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2
Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml line 12
Quoted 10 lines
Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml new file +10
-0+--- +$id: http://devicetree.org/schemas/net/fsl,qmc-hdlc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Freescale/NXP QUICC Multichannel Controller (QMC) HDLC + +maintainers: + - Herve Codina <[email protected]> + +description: |
Don't need '|'
Quoted 11 lines
Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml new file +11
-0+ The QMC HDLC uses a QMC (QUICC Multichannel Controller) channel to transfer + HDLC data. + +properties: + compatible: + const: fsl,qmc-hdlc + + fsl,qmc-chan: + $ref: /schemas/types.yaml#/definitions/phandle-array + items: + - items:
Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml line 33
Quoted 10 lines
Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml new file +10
-0+ - description: phandle to QMC node + - description: Channel number + description: + Should be a phandle/number pair. The phandle to QMC node and the QMC + channel to use. + + framer: + $ref: /schemas/types.yaml#/definitions/phandle + description: + phandle to the framer node
What's the framer?
Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml line 45
Quoted 12 lines
Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml new file +12
-0+ +required: + - compatible + - fsl,qmc-chan + +additionalProperties: false + +examples: + - | + hdlc { + compatible = "fsl,qmc-hdlc"; + fsl,qmc-chan = <&qmc 16>;
Where does this node live?
QMC is this[1]? Why don't you just add the compatible to channel@10 in the QMC node?
Rob
[1] Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,cpm1-scc-qmc.yaml
Herve Codina
maintainerRe: [PATCH v4 06/28] dt-bindings: net: Add support for QMC HDLC
Quoted 32 lines · On Mon, 21 Aug 2023 15:42:58 -0500 Rob Herring <[email protected]> wrote:
Quoted 31 lines · Christophe Leroy
From: Herve Codina <[email protected]>
The QMC (QUICC mutichannel controller) is a controller present in some PowerQUICC SoC such as MPC885.
The QMC HDLC uses the QMC controller to transfer HDLC data.Additionally, a framer can be connected to the QMC HDLC.
If present, this framer is the interface between the TDM bus used by the QMC HDLC and the E1/T1 line.
The QMC HDLC can use this framer to get information about the E1/T1 line and configure the E1/T1 line.Signed-off-by Herve Codina <[email protected]>Signed-off-by Christophe Leroy <[email protected]>--- .../devicetree/bindings/net/fsl,qmc-hdlc.yaml | 46 +++++++++++++++++++ 1 file changed, 46 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yamlDocumentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml new file +6
-0@@ -0,0 +1,46 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/fsl,qmc-hdlc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# +
Quoted 8 lines
Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml line 12
Quoted 6 lines
Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml new file +6
-0+title: Freescale/NXP QUICC Multichannel Controller (QMC) HDLC + +maintainers: + - Herve Codina <[email protected]> + +description: |Don't need '|'
Will be fixed in the next iteration.
Quoted 16 lines
Quoted 16 lines
Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml new file +15
-0+ The QMC HDLC uses a QMC (QUICC Multichannel Controller) channel to transfer + HDLC data. + +properties: + compatible: + const: fsl,qmc-hdlc + + fsl,qmc-chan: + $ref: /schemas/types.yaml#/definitions/phandle-array + items: + - items: + - description: phandle to QMC node + - description: Channel number + description: + Should be a phandle/number pair. The phandle to QMC node and the QMC
Quoted 8 lines
Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml line 33
Quoted 6 lines
Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml new file +6
-0+ channel to use. + + framer: + $ref: /schemas/types.yaml#/definitions/phandle + description: + phandle to the framer nodeWhat's the framer?
A framer is a component in charge of an E1/T1 line interface.
Is is connected to the TDM bus and it converts TDM frames to/from E1/T1 frames.
The HDLC data are sent/received to/from the TDM bus and the framer is used to get information about the E1/T1 line such as link up/down.
I can update the description to:
--- 8< ---
phandle to the framer node. The framer is in charge of an E1/T1 line interface connected to the TDM bus. It can be used to get the E1/T1 line status such as link up/down.
--- 8< ---
Is that better ?
Quoted 16 lines
Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml line 45
Quoted 13 lines
Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml new file +12
-0+ +required: + - compatible + - fsl,qmc-chan + +additionalProperties: false + +examples: + - | + hdlc { + compatible = "fsl,qmc-hdlc"; + fsl,qmc-chan = <&qmc 16>;Where does this node live?
Quoted 2 lines
QMC is this[1]? Why don't you just add the compatible to channel@10 in the QMC node?
Indeed, I will move the properties (compatible and framer phandle) to the QMC channel node.
Quoted 4 lines
Rob
[1]
Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,cpm1-scc-qmc.yaml
Best regards,
Hervé
Signature · 3 lines
Hervé Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH v4 7/28 net: wan: Add support for QMC HDLC
In reply to Christophe LeroyFrom: Herve Codina <[email protected]>
The QMC HDLC driver provides support for HDLC using the QMC (QUICC Multichannel Controller) to transfer the HDLC data.
--- drivers/net/wan/Kconfig | 12 + drivers/net/wan/Makefile | 1 + drivers/net/wan/fsl_qmc_hdlc.c | 422 +++++++++++++++++++++++++++++++++ 3 files changed, 435 insertions(+) create mode 100644 drivers/net/wan/fsl_qmc_hdlc.c
drivers/net/wan/Kconfig +12 -0
@@ -195,6 +195,18 @@ config FARSYNC To compile this driver as a module, choose M here: the module will be called farsync. +config FSL_QMC_HDLC + tristate "Freescale QMC HDLC support" + depends on HDLC + depends on CPM_QMC + help + HDLC support using the Freescale QUICC Multichannel Controller (QMC). + + To compile this driver as a module, choose M here: the + module will be called fsl_qmc_hdlc. + + If unsure, say N. + config FSL_UCC_HDLC tristate "Freescale QUICC Engine HDLC support" depends on HDLC
drivers/net/wan/Makefile +1 -0
@@ -23,6 +23,7 @@ obj-$(CONFIG_WANXL) += wanxl.o obj-$(CONFIG_PCI200SYN) += pci200syn.o obj-$(CONFIG_PC300TOO) += pc300too.o obj-$(CONFIG_IXP4XX_HSS) += ixp4xx_hss.o +obj-$(CONFIG_FSL_QMC_HDLC) += fsl_qmc_hdlc.o obj-$(CONFIG_FSL_UCC_HDLC) += fsl_ucc_hdlc.o obj-$(CONFIG_SLIC_DS26522) += slic_ds26522.o
drivers/net/wan/fsl_qmc_hdlc.c new file +422 -0
422 lines not on this page · raw message
Signature · 1 line
2.41.0
PATCH v4 8/28 MAINTAINERS: Add the Freescale QMC HDLC driver entry
In reply to Christophe LeroyFrom: Herve Codina <[email protected]>
After contributing the driver, add myself as the maintainer for the Freescale QMC HDLC driver.
--- MAINTAINERS | 8 ++++++++ 1 file changed, 8 insertions(+)
MAINTAINERS +8 -0
@@ -8305,6 +8305,14 @@ F: Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,cpm1-scc-qmc.yaml F: drivers/soc/fsl/qe/qmc.c F: include/soc/fsl/qe/qmc.h +FREESCALE QUICC ENGINE QMC HDLC DRIVER +M: Herve Codina <[email protected]> +L: [email protected] +L: [email protected] +S: Maintained +F: Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml +F: drivers/net/wan/fsl_qmc_hdlc.c + FREESCALE QUICC ENGINE TSA DRIVER M: Herve Codina <[email protected]> L: [email protected]
Signature · 7 lines
2.41.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH v4 9/28 soc: fsl: cpm1: qmc: Introduce available timeslots masks
In reply to Christophe LeroyFrom: Herve Codina <[email protected]>
Available timeslots masks define timeslots available for the related channel. These timeslots are defined by the QMC binding.
Timeslots used are initialized to available timeslots but can be a subset of available timeslots.
This prepares the dynamic timeslots management (ie. changing timeslots at runtime).
--- drivers/soc/fsl/qe/qmc.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/soc/fsl/qe/qmc.c +6 -2
@@ -177,7 +177,9 @@ struct qmc_chan {struct qmc *qmc;void __iomem *s_param;enum qmc_mode mode; +u64 tx_ts_mask_avail;u64 tx_ts_mask; +u64 rx_ts_mask_avail;u64 rx_ts_mask;bool is_reverse_data;
@@ -875,7 +877,8 @@ static int qmc_of_parse_chans(struct qmc *qmc, struct device_node *np)of_node_put (chan_np);return ret; } - chan->tx_ts_mask = ts_mask; + chan->tx_ts_mask_avail = ts_mask; + chan->tx_ts_mask = chan->tx_ts_mask_avail; ret =of_property_read_u64 (chan_np,"fsl,rx-ts-mask" , &ts_mask);if (ret) {
@@ -884,7 +887,8 @@ static int qmc_of_parse_chans(struct qmc *qmc, struct device_node *np)of_node_put (chan_np);return ret; } - chan->rx_ts_mask = ts_mask; + chan->rx_ts_mask_avail = ts_mask; + chan->rx_ts_mask = chan->rx_ts_mask_avail; mode ="transparent" ; ret =of_property_read_string (chan_np,"fsl,operational-mode" , &mode);
Signature · 7 lines
2.41.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH v4 10/28 soc: fsl: cpm1: qmc: Rename qmc_setup_tsa* to qmc_init_tsa*
In reply to Christophe LeroyFrom: Herve Codina <[email protected]>
qmc_setup_tsa* are called once at initialisation.
They initialize the QMC TSA table.
In order to introduce setup function later on for dynamic timeslots management, rename the function to avoid later confusion.
--- drivers/soc/fsl/qe/qmc.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
drivers/soc/fsl/qe/qmc.c +8 -8
@@ -919,7 +919,7 @@ static int qmc_of_parse_chans(struct qmc *qmc, struct device_node *np)return qmc_check_chans (qmc); } -static int qmc_setup_tsa_64rxtx (struct qmc *qmc,const struct tsa_serial_info *info) +static int qmc_init_tsa_64rxtx (struct qmc *qmc,const struct tsa_serial_info *info) {struct qmc_chan *chan;unsigned int i;
@@ -961,7 +961,7 @@ static int qmc_setup_tsa_64rxtx(struct qmc *qmc, const struct tsa_serial_info *ireturn 0 ; } -static int qmc_setup_tsa_32rx_32tx (struct qmc *qmc,const struct tsa_serial_info *info) +static int qmc_init_tsa_32rx_32tx (struct qmc *qmc,const struct tsa_serial_info *info) {struct qmc_chan *chan;unsigned int i;
@@ -1019,7 +1019,7 @@ static int qmc_setup_tsa_32rx_32tx(struct qmc *qmc, const struct tsa_serial_inforeturn 0 ; } -static int qmc_setup_tsa (struct qmc *qmc) +static int qmc_init_tsa (struct qmc *qmc) {struct tsa_serial_info info;int ret;
@@ -1030,12 +1030,12 @@ static int qmc_setup_tsa(struct qmc *qmc)return ret;/* -* Setup one common 64 entries table or two 32 entries (one for Tx and -* one for Tx) according to assigned TS numbers. +* Initialize one common 64 entries table or two 32 entries (one for Tx +* and one for Tx) according to assigned TS numbers. */ return ((info.nb_tx_ts >32 ) || (info.nb_rx_ts >32 )) ? -qmc_setup_tsa_64rxtx (qmc, &info) : -qmc_setup_tsa_32rx_32tx (qmc, &info); +qmc_init_tsa_64rxtx (qmc, &info) : +qmc_init_tsa_32rx_32tx (qmc, &info); }static int qmc_setup_chan_trnsync (struct qmc *qmc,struct qmc_chan *chan)
@@ -1391,7 +1391,7 @@ static int qmc_probe(struct platform_device *pdev)qmc_write32 (qmc->scc_pram +QMC_GBL_C_MASK32 ,0xDEBB20E3 );qmc_write16 (qmc->scc_pram +QMC_GBL_C_MASK16 ,0xF0B8 ); - ret =qmc_setup_tsa (qmc); + ret =qmc_init_tsa (qmc);if (ret) goto err_tsa_serial_disconnect;
Signature · 1 line
2.41.0
PATCH v4 11/28 soc: fsl: cpm1: qmc: Introduce qmc_chan_setup_tsa*
In reply to Christophe LeroyFrom: Herve Codina <[email protected]>
Introduce the qmc_chan_setup_tsa* functions to setup entries related to the given channel.
Use them during QMC channels setup.
--- drivers/soc/fsl/qe/qmc.c | 161 ++++++++++++++++++++++++++++++--------- 1 file changed, 125 insertions(+), 36 deletions(-)
drivers/soc/fsl/qe/qmc.c +125 -36
@@ -240,6 +240,11 @@ static void qmc_clrbits16(void __iomem *addr, u16 clr)qmc_write16 (addr,qmc_read16 (addr) & ~clr); } +static void qmc_clrsetbits16 (void __iomem *addr,u16 clr,u16 set) +{ +qmc_write16 (addr, (qmc_read16 (addr) & ~clr) | set); +} +static void qmc_write32 (void __iomem *addr,u32 val) {iowrite32be (val, addr);
@@ -562,6 +567,122 @@ static void qmc_chan_read_done(struct qmc_chan *chan)spin_unlock_irqrestore (&chan->rx_lock, flags); } +static int qmc_chan_setup_tsa_64rxtx (struct qmc_chan *chan,const struct tsa_serial_info *info) +{ +unsigned int i; +u16 curr; +u16 val; + +/* +* Use a common Tx/Rx 64 entries table. +* Tx and Rx related stuffs must be identical +*/ +if (chan->tx_ts_mask != chan->rx_ts_mask) { +dev_err (chan->qmc->dev,"chan %u uses different Rx and Tx TS\n" , chan->id); +return -EINVAL ; + } + + val =QMC_TSA_VALID |QMC_TSA_MASK |QMC_TSA_CHANNEL (chan->id); + +/* Check entries based on Rx stuff*/ +for (i =0 ; i < info->nb_rx_ts; i++) { +if (!(chan->rx_ts_mask & (((u64 )1 ) << i))) +continue ; + + curr =qmc_read16 (chan->qmc->scc_pram +QMC_GBL_TSATRX + (i *2 )); +if (curr &QMC_TSA_VALID && (curr & ~QMC_TSA_WRAP ) != val) { +dev_err (chan->qmc->dev,"chan %u TxRx entry %d already used\n" , + chan->id, i); +return -EBUSY ; + } + } + +/* Set entries based on Rx stuff*/ +for (i =0 ; i < info->nb_rx_ts; i++) { +if (!(chan->rx_ts_mask & (((u64 )1 ) << i))) +continue ; + +qmc_clrsetbits16 (chan->qmc->scc_pram +QMC_GBL_TSATRX + (i *2 ), + ~QMC_TSA_WRAP , val); + } + +return 0 ; +} + +static int qmc_chan_setup_tsa_32rx_32tx (struct qmc_chan *chan,const struct tsa_serial_info *info) +{ +unsigned int i; +u16 curr; +u16 val; + +/* Use a Tx 32 entries table and a Rx 32 entries table */ + + val =QMC_TSA_VALID |QMC_TSA_MASK |QMC_TSA_CHANNEL (chan->id); + +/* Check entries based on Rx stuff */ +for (i =0 ; i < info->nb_rx_ts; i++) { +if (!(chan->rx_ts_mask & (((u64 )1 ) << i))) +continue ; + + curr =qmc_read16 (chan->qmc->scc_pram +QMC_GBL_TSATRX + (i *2 )); +if (curr &QMC_TSA_VALID && (curr & ~QMC_TSA_WRAP ) != val) { +dev_err (chan->qmc->dev,"chan %u Rx entry %d already used\n" , + chan->id, i); +return -EBUSY ; + } + } +/* Check entries based on Tx stuff */ +for (i =0 ; i < info->nb_tx_ts; i++) { +if (!(chan->tx_ts_mask & (((u64 )1 ) << i))) +continue ; + + curr =qmc_read16 (chan->qmc->scc_pram +QMC_GBL_TSATTX + (i *2 )); +if (curr &QMC_TSA_VALID && (curr & ~QMC_TSA_WRAP ) != val) { +dev_err (chan->qmc->dev,"chan %u Tx entry %d already used\n" , + chan->id, i); +return -EBUSY ; + } + } + +/* Set entries based on Rx stuff */ +for (i =0 ; i < info->nb_rx_ts; i++) { +if (!(chan->rx_ts_mask & (((u64 )1 ) << i))) +continue ; + +qmc_clrsetbits16 (chan->qmc->scc_pram +QMC_GBL_TSATRX + (i *2 ), + ~QMC_TSA_WRAP , val); + } +/* Set entries based on Tx stuff */ +for (i =0 ; i < info->nb_tx_ts; i++) { +if (!(chan->tx_ts_mask & (((u64 )1 ) << i))) +continue ; + +qmc_clrsetbits16 (chan->qmc->scc_pram +QMC_GBL_TSATTX + (i *2 ), + ~QMC_TSA_WRAP , val); + } + +return 0 ; +} + +static int qmc_chan_setup_tsa (struct qmc_chan *chan) +{ +struct tsa_serial_info info; +int ret; + +/* Retrieve info from the TSA related serial */ + ret =tsa_serial_get_info (chan->qmc->tsa_serial, &info); +if (ret) +return ret; + +/* +* Setup one common 64 entries table or two 32 entries (one for Tx +* and one for Tx) according to assigned TS numbers. +*/ +return ((info.nb_tx_ts >32 ) || (info.nb_rx_ts >32 )) ? +qmc_chan_setup_tsa_64rxtx (chan, &info) : +qmc_chan_setup_tsa_32rx_32tx (chan, &info); +} +static int qmc_chan_command (struct qmc_chan *chan,u8 qmc_opcode) {return cpm_command (chan->id <<2 , (qmc_opcode <<4 ) |0x0E );
@@ -921,7 +1042,6 @@ static int qmc_of_parse_chans(struct qmc *qmc, struct device_node *np)static int qmc_init_tsa_64rxtx (struct qmc *qmc,const struct tsa_serial_info *info) { -struct qmc_chan *chan;unsigned int i;u16 val;
@@ -935,18 +1055,6 @@ static int qmc_init_tsa_64rxtx(struct qmc *qmc, const struct tsa_serial_info *infor (i =0 ; i <64 ; i++)qmc_write16 (qmc->scc_pram +QMC_GBL_TSATRX + (i *2 ),0x0000 ); -/* Set entries based on Rx stuff*/ -list_for_each_entry (chan, &qmc->chan_head, list) { -for (i =0 ; i < info->nb_rx_ts; i++) { -if (!(chan->rx_ts_mask & (((u64 )1 ) << i))) -continue ; - - val =QMC_TSA_VALID |QMC_TSA_MASK | -QMC_TSA_CHANNEL (chan->id); -qmc_write16 (qmc->scc_pram +QMC_GBL_TSATRX + (i *2 ), val); - } - } -/* Set Wrap bit on last entry */ qmc_setbits16 (qmc->scc_pram +QMC_GBL_TSATRX + ((info->nb_rx_ts -1 ) *2 ),QMC_TSA_WRAP );
@@ -963,7 +1071,6 @@ static int qmc_init_tsa_64rxtx(struct qmc *qmc, const struct tsa_serial_info *instatic int qmc_init_tsa_32rx_32tx (struct qmc *qmc,const struct tsa_serial_info *info) { -struct qmc_chan *chan;unsigned int i;u16 val;
@@ -978,28 +1085,6 @@ static int qmc_init_tsa_32rx_32tx(struct qmc *qmc, const struct tsa_serial_infoqmc_write16 (qmc->scc_pram +QMC_GBL_TSATTX + (i *2 ),0x0000 ); } -/* Set entries based on Rx and Tx stuff*/ -list_for_each_entry (chan, &qmc->chan_head, list) { -/* Rx part */ -for (i =0 ; i < info->nb_rx_ts; i++) { -if (!(chan->rx_ts_mask & (((u64 )1 ) << i))) -continue ; - - val =QMC_TSA_VALID |QMC_TSA_MASK | -QMC_TSA_CHANNEL (chan->id); -qmc_write16 (qmc->scc_pram +QMC_GBL_TSATRX + (i *2 ), val); - } -/* Tx part */ -for (i =0 ; i < info->nb_tx_ts; i++) { -if (!(chan->tx_ts_mask & (((u64 )1 ) << i))) -continue ; - - val =QMC_TSA_VALID |QMC_TSA_MASK | -QMC_TSA_CHANNEL (chan->id); -qmc_write16 (qmc->scc_pram +QMC_GBL_TSATTX + (i *2 ), val); - } - } -/* Set Wrap bit on last entries */ qmc_setbits16 (qmc->scc_pram +QMC_GBL_TSATRX + ((info->nb_rx_ts -1 ) *2 ),QMC_TSA_WRAP );
@@ -1081,6 +1166,10 @@ static int qmc_setup_chan(struct qmc *qmc, struct qmc_chan *chan) chan->qmc = qmc; + ret =qmc_chan_setup_tsa (chan); +if (ret) +return ret; +/* Set channel specific parameter base address */ chan->s_param = qmc->dpram + (chan->id *64 );/* 16 bd per channel (8 rx and 8 tx) */
Signature · 7 lines
2.41.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH v4 12/28 soc: fsl: cpm1: qmc: Remove no more needed checks from qmc_check_chans()
In reply to Christophe LeroyFrom: Herve Codina <[email protected]>
The newly introduced qmc_chan_setup_tsa* functions check that the channel entries are not already used.
These checks are also performed by qmc_check_chans() and are no more needed.
Remove them from qmc_check_chans().
--- drivers/soc/fsl/qe/qmc.c | 20 -------------------- 1 file changed, 20 deletions(-)
drivers/soc/fsl/qe/qmc.c +0 -20
@@ -884,10 +884,7 @@ EXPORT_SYMBOL(qmc_chan_reset);static int qmc_check_chans (struct qmc *qmc) {struct tsa_serial_info info; -bool is_one_table = false;struct qmc_chan *chan; -u64 tx_ts_mask =0 ; -u64 rx_ts_mask =0 ;u64 tx_ts_assigned_mask;u64 rx_ts_assigned_mask;int ret;
@@ -911,7 +908,6 @@ static int qmc_check_chans(struct qmc *qmc)dev_err (qmc->dev,"Number of TSA Tx/Rx TS assigned are not equal\n" );return -EINVAL ; } - is_one_table = true; } tx_ts_assigned_mask = info.nb_tx_ts ==64 ?U64_MAX : (((u64 )1 ) << info.nb_tx_ts) -1 ;
@@ -922,27 +918,11 @@ static int qmc_check_chans(struct qmc *qmc)dev_err (qmc->dev,"chan %u uses TSA unassigned Tx TS\n" , chan->id);return -EINVAL ; } -if (tx_ts_mask & chan->tx_ts_mask) { -dev_err (qmc->dev,"chan %u uses an already used Tx TS\n" , chan->id); -return -EINVAL ; - }if (chan->rx_ts_mask > rx_ts_assigned_mask) {dev_err (qmc->dev,"chan %u uses TSA unassigned Rx TS\n" , chan->id);return -EINVAL ; } -if (rx_ts_mask & chan->rx_ts_mask) { -dev_err (qmc->dev,"chan %u uses an already used Rx TS\n" , chan->id); -return -EINVAL ; - } - -if (is_one_table && (chan->tx_ts_mask != chan->rx_ts_mask)) { -dev_err (qmc->dev,"chan %u uses different Rx and Tx TS\n" , chan->id); -return -EINVAL ; - } - - tx_ts_mask |= chan->tx_ts_mask; - rx_ts_mask |= chan->rx_ts_mask; }return 0 ;
Signature · 7 lines
2.41.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH v4 13/28 soc: fsl: cpm1: qmc: Check available timeslots in qmc_check_chans()
In reply to Christophe LeroyFrom: Herve Codina <[email protected]>
The timeslots checked in qmc_check_chans() are the timeslots used. With the introduction of the available timeslots, the used timeslots are a subset of the available timeslots. The timeslots checked during the qmc_check_chans() call should be the available ones.
Simply update and check the available timeslots instead of the used timeslots in qmc_check_chans().
--- drivers/soc/fsl/qe/qmc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/soc/fsl/qe/qmc.c +4 -4
@@ -914,13 +914,13 @@ static int qmc_check_chans(struct qmc *qmc) rx_ts_assigned_mask = info.nb_rx_ts ==64 ?U64_MAX : (((u64 )1 ) << info.nb_rx_ts) -1 ;list_for_each_entry (chan, &qmc->chan_head, list) { -if (chan->tx_ts_mask > tx_ts_assigned_mask) { -dev_err (qmc->dev,"chan %u uses TSA unassigned Tx TS\n" , chan->id); +if (chan->tx_ts_mask_avail > tx_ts_assigned_mask) { +dev_err (qmc->dev,"chan %u can use TSA unassigned Tx TS\n" , chan->id);return -EINVAL ; } -if (chan->rx_ts_mask > rx_ts_assigned_mask) { -dev_err (qmc->dev,"chan %u uses TSA unassigned Rx TS\n" , chan->id); +if (chan->rx_ts_mask_avail > rx_ts_assigned_mask) { +dev_err (qmc->dev,"chan %u can use TSA unassigned Rx TS\n" , chan->id);return -EINVAL ; } }
Signature · 1 line
2.41.0
PATCH v4 14/28 soc: fsl: cpm1: qmc: Add support for disabling channel TSA entries
In reply to Christophe LeroyFrom: Herve Codina <[email protected]>
In order to allow runtime timeslot route changes, disabling channel TSA entries needs to be supported.
Add support for this new feature.
--- drivers/soc/fsl/qe/qmc.c | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-)
drivers/soc/fsl/qe/qmc.c +11 -9
@@ -567,7 +567,8 @@ static void qmc_chan_read_done(struct qmc_chan *chan)spin_unlock_irqrestore (&chan->rx_lock, flags); } -static int qmc_chan_setup_tsa_64rxtx (struct qmc_chan *chan,const struct tsa_serial_info *info) +static int qmc_chan_setup_tsa_64rxtx (struct qmc_chan *chan,const struct tsa_serial_info *info, +bool enable) {unsigned int i;u16 curr;
@@ -603,13 +604,14 @@ static int qmc_chan_setup_tsa_64rxtx(struct qmc_chan *chan, const struct tsa_sercontinue ;qmc_clrsetbits16 (chan->qmc->scc_pram +QMC_GBL_TSATRX + (i *2 ), - ~QMC_TSA_WRAP , val); + ~QMC_TSA_WRAP , enable ? val :0x0000 ); }return 0 ; } -static int qmc_chan_setup_tsa_32rx_32tx (struct qmc_chan *chan,const struct tsa_serial_info *info) +static int qmc_chan_setup_tsa_32rx_32tx (struct qmc_chan *chan,const struct tsa_serial_info *info, +bool enable) {unsigned int i;u16 curr;
@@ -650,7 +652,7 @@ static int qmc_chan_setup_tsa_32rx_32tx(struct qmc_chan *chan, const struct tsa_continue ;qmc_clrsetbits16 (chan->qmc->scc_pram +QMC_GBL_TSATRX + (i *2 ), - ~QMC_TSA_WRAP , val); + ~QMC_TSA_WRAP , enable ? val :0x0000 ); }/* Set entries based on Tx stuff */ for (i =0 ; i < info->nb_tx_ts; i++) {
@@ -658,13 +660,13 @@ static int qmc_chan_setup_tsa_32rx_32tx(struct qmc_chan *chan, const struct tsa_continue ;qmc_clrsetbits16 (chan->qmc->scc_pram +QMC_GBL_TSATTX + (i *2 ), - ~QMC_TSA_WRAP , val); + ~QMC_TSA_WRAP , enable ? val :0x0000 ); }return 0 ; } -static int qmc_chan_setup_tsa (struct qmc_chan *chan) +static int qmc_chan_setup_tsa (struct qmc_chan *chan,bool enable) {struct tsa_serial_info info;int ret;
@@ -679,8 +681,8 @@ static int qmc_chan_setup_tsa(struct qmc_chan *chan)* and one for Tx) according to assigned TS numbers. */ return ((info.nb_tx_ts >32 ) || (info.nb_rx_ts >32 )) ? -qmc_chan_setup_tsa_64rxtx (chan, &info) : -qmc_chan_setup_tsa_32rx_32tx (chan, &info); +qmc_chan_setup_tsa_64rxtx (chan, &info, enable) : +qmc_chan_setup_tsa_32rx_32tx (chan, &info, enable); }static int qmc_chan_command (struct qmc_chan *chan,u8 qmc_opcode)
@@ -1146,7 +1148,7 @@ static int qmc_setup_chan(struct qmc *qmc, struct qmc_chan *chan) chan->qmc = qmc; - ret =qmc_chan_setup_tsa (chan); + ret =qmc_chan_setup_tsa (chan, true);if (ret)return ret;
Signature · 1 line
2.41.0
PATCH v4 15/28 soc: fsl: cpm1: qmc: Split Tx and Rx TSA entries setup
In reply to Christophe LeroyFrom: Herve Codina <[email protected]>
The Tx and Rx entries for a given channel are set in one function.
In order to modify Rx entries and Tx entries independently of one other, split this function in one for the Rx part and one for the Tx part.
--- drivers/soc/fsl/qe/qmc.c | 49 ++++++++++++++++++++++++++++------------ 1 file changed, 35 insertions(+), 14 deletions(-)
drivers/soc/fsl/qe/qmc.c +35 -14
@@ -610,14 +610,14 @@ static int qmc_chan_setup_tsa_64rxtx(struct qmc_chan *chan, const struct tsa_serreturn 0 ; } -static int qmc_chan_setup_tsa_32rx_32tx (struct qmc_chan *chan,const struct tsa_serial_info *info, -bool enable) +static int qmc_chan_setup_tsa_32rx (struct qmc_chan *chan,const struct tsa_serial_info *info, +bool enable) {unsigned int i;u16 curr;u16 val; -/* Use a Tx 32 entries table and a Rx 32 entries table */ +/* Use a Rx 32 entries table */ val =QMC_TSA_VALID |QMC_TSA_MASK |QMC_TSA_CHANNEL (chan->id);
@@ -633,6 +633,30 @@ static int qmc_chan_setup_tsa_32rx_32tx(struct qmc_chan *chan, const struct tsa_return -EBUSY ; } } + +/* Set entries based on Rx stuff */ +for (i =0 ; i < info->nb_rx_ts; i++) { +if (!(chan->rx_ts_mask & (((u64 )1 ) << i))) +continue ; + +qmc_clrsetbits16 (chan->qmc->scc_pram +QMC_GBL_TSATRX + (i *2 ), + ~QMC_TSA_WRAP , enable ? val :0x0000 ); + } + +return 0 ; +} + +static int qmc_chan_setup_tsa_32tx (struct qmc_chan *chan,const struct tsa_serial_info *info, +bool enable) +{ +unsigned int i; +u16 curr; +u16 val; + +/* Use a Tx 32 entries table */ + + val =QMC_TSA_VALID |QMC_TSA_MASK |QMC_TSA_CHANNEL (chan->id); +/* Check entries based on Tx stuff */ for (i =0 ; i < info->nb_tx_ts; i++) {if (!(chan->tx_ts_mask & (((u64 )1 ) << i)))
@@ -646,14 +670,6 @@ static int qmc_chan_setup_tsa_32rx_32tx(struct qmc_chan *chan, const struct tsa_ } } -/* Set entries based on Rx stuff */ -for (i =0 ; i < info->nb_rx_ts; i++) { -if (!(chan->rx_ts_mask & (((u64 )1 ) << i))) -continue ; - -qmc_clrsetbits16 (chan->qmc->scc_pram +QMC_GBL_TSATRX + (i *2 ), - ~QMC_TSA_WRAP , enable ? val :0x0000 ); - }/* Set entries based on Tx stuff */ for (i =0 ; i < info->nb_tx_ts; i++) {if (!(chan->tx_ts_mask & (((u64 )1 ) << i)))
@@ -680,9 +696,14 @@ static int qmc_chan_setup_tsa(struct qmc_chan *chan, bool enable)* Setup one common 64 entries table or two 32 entries (one for Tx * and one for Tx) according to assigned TS numbers. */ -return ((info.nb_tx_ts >32 ) || (info.nb_rx_ts >32 )) ? -qmc_chan_setup_tsa_64rxtx (chan, &info, enable) : -qmc_chan_setup_tsa_32rx_32tx (chan, &info, enable); +if (info.nb_tx_ts >32 || info.nb_rx_ts >32 ) +return qmc_chan_setup_tsa_64rxtx (chan, &info, enable); + + ret =qmc_chan_setup_tsa_32rx (chan, &info, enable); +if (ret) +return ret; + +return qmc_chan_setup_tsa_32tx (chan, &info, enable); }static int qmc_chan_command (struct qmc_chan *chan,u8 qmc_opcode)
Signature · 1 line
2.41.0
PATCH v4 16/28 soc: fsl: cpm1: qmc: Introduce is_tsa_64rxtx flag
In reply to Christophe LeroyFrom: Herve Codina <[email protected]>
In order to support runtime timeslot route changes, some operations will be different according the routing table used (common Rx and Tx table or one table for Rx and one for Tx).
The is_tsa_64rxtx flag is introduced to avoid extra computation to determine the table format each time we need it.
It is set once at initialization.
--- drivers/soc/fsl/qe/qmc.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/soc/fsl/qe/qmc.c +4 -1
@@ -216,6 +216,7 @@ struct qmc {u16 __iomem *int_curr;dma_addr_t int_dma_addr;size_t int_size; +bool is_tsa_64rxtx;struct list_head chan_head;struct qmc_chan *chans[64 ]; };
@@ -696,7 +697,7 @@ static int qmc_chan_setup_tsa(struct qmc_chan *chan, bool enable)* Setup one common 64 entries table or two 32 entries (one for Tx * and one for Tx) according to assigned TS numbers. */ -if (info.nb_tx_ts >32 || info.nb_rx_ts >32 ) +if (chan->qmc->is_tsa_64rxtx)return qmc_chan_setup_tsa_64rxtx (chan, &info, enable); ret =qmc_chan_setup_tsa_32rx (chan, &info, enable);
@@ -1053,6 +1054,7 @@ static int qmc_init_tsa_64rxtx(struct qmc *qmc, const struct tsa_serial_info *in* Everything was previously checked, Tx and Rx related stuffs are * identical -> Used Rx related stuff to build the table */ + qmc->is_tsa_64rxtx = true;/* Invalidate all entries */ for (i =0 ; i <64 ; i++)
@@ -1081,6 +1083,7 @@ static int qmc_init_tsa_32rx_32tx(struct qmc *qmc, const struct tsa_serial_info* Use a Tx 32 entries table and a Rx 32 entries table. * Everything was previously checked. */ + qmc->is_tsa_64rxtx = false;/* Invalidate all entries */ for (i =0 ; i <32 ; i++) {
Signature · 7 lines
2.41.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH v4 17/28 soc: fsl: cpm1: qmc: Handle timeslot entries at channel start() and stop()
In reply to Christophe LeroyFrom: Herve Codina <[email protected]>
In order to support runtime timeslot route changes, enable the channel timeslot entries at channel start() and disable them at channel stop().
--- drivers/soc/fsl/qe/qmc.c | 175 ++++++++++++++++++++++++++++++++++++--- 1 file changed, 163 insertions(+), 12 deletions(-)
drivers/soc/fsl/qe/qmc.c +163 -12
@@ -177,6 +177,7 @@ struct qmc_chan {struct qmc *qmc;void __iomem *s_param;enum qmc_mode mode; +spinlock_t ts_lock;/* Protect timeslots */ u64 tx_ts_mask_avail;u64 tx_ts_mask;u64 rx_ts_mask_avail;
@@ -265,6 +266,7 @@ static void qmc_setbits32(void __iomem *addr, u32 set)int qmc_chan_get_info (struct qmc_chan *chan,struct qmc_chan_info *info) {struct tsa_serial_info tsa_info; +unsigned long flags;int ret;/* Retrieve info from the TSA related serial */
@@ -272,6 +274,8 @@ int qmc_chan_get_info(struct qmc_chan *chan, struct qmc_chan_info *info)if (ret)return ret; +spin_lock_irqsave (&chan->ts_lock, flags); + info->mode = chan->mode; info->rx_fs_rate = tsa_info.rx_fs_rate; info->rx_bit_rate = tsa_info.rx_bit_rate;
@@ -280,6 +284,8 @@ int qmc_chan_get_info(struct qmc_chan *chan, struct qmc_chan_info *info) info->tx_bit_rate = tsa_info.tx_bit_rate; info->nb_rx_ts =hweight64 (chan->rx_ts_mask); +spin_unlock_irqrestore (&chan->ts_lock, flags); +return 0 ; }EXPORT_SYMBOL (qmc_chan_get_info);
@@ -683,6 +689,40 @@ static int qmc_chan_setup_tsa_32tx(struct qmc_chan *chan, const struct tsa_seriareturn 0 ; } +static int qmc_chan_setup_tsa_tx (struct qmc_chan *chan,bool enable) +{ +struct tsa_serial_info info; +int ret; + +/* Retrieve info from the TSA related serial */ + ret =tsa_serial_get_info (chan->qmc->tsa_serial, &info); +if (ret) +return ret; + +/* Setup entries */ +if (chan->qmc->is_tsa_64rxtx) +return qmc_chan_setup_tsa_64rxtx (chan, &info, enable); + +return qmc_chan_setup_tsa_32tx (chan, &info, enable); +} + +static int qmc_chan_setup_tsa_rx (struct qmc_chan *chan,bool enable) +{ +struct tsa_serial_info info; +int ret; + +/* Retrieve info from the TSA related serial */ + ret =tsa_serial_get_info (chan->qmc->tsa_serial, &info); +if (ret) +return ret; + +/* Setup entries */ +if (chan->qmc->is_tsa_64rxtx) +return qmc_chan_setup_tsa_64rxtx (chan, &info, enable); + +return qmc_chan_setup_tsa_32rx (chan, &info, enable); +} +static int qmc_chan_setup_tsa (struct qmc_chan *chan,bool enable) {struct tsa_serial_info info;
@@ -719,6 +759,12 @@ static int qmc_chan_stop_rx(struct qmc_chan *chan)spin_lock_irqsave (&chan->rx_lock, flags); +if (chan->is_rx_stopped) { +/* The channel is already stopped -> simply return ok */ + ret =0 ; + goto end; + } +/* Send STOP RECEIVE command */ ret =qmc_chan_command (chan,0x0 );if (ret) {
@@ -729,6 +775,15 @@ static int qmc_chan_stop_rx(struct qmc_chan *chan) chan->is_rx_stopped = true; +if (!chan->qmc->is_tsa_64rxtx || chan->is_tx_stopped) { + ret =qmc_chan_setup_tsa_rx (chan, false); +if (ret) { +dev_err (chan->qmc->dev,"chan %u: Disable tsa entries failed (%d)\n" , + chan->id, ret); + goto end; + } + } + end:spin_unlock_irqrestore (&chan->rx_lock, flags);return ret;
@@ -741,6 +796,12 @@ static int qmc_chan_stop_tx(struct qmc_chan *chan)spin_lock_irqsave (&chan->tx_lock, flags); +if (chan->is_tx_stopped) { +/* The channel is already stopped -> simply return ok */ + ret =0 ; + goto end; + } +/* Send STOP TRANSMIT command */ ret =qmc_chan_command (chan,0x1 );if (ret) {
@@ -751,37 +812,82 @@ static int qmc_chan_stop_tx(struct qmc_chan *chan) chan->is_tx_stopped = true; +if (!chan->qmc->is_tsa_64rxtx || chan->is_rx_stopped) { + ret =qmc_chan_setup_tsa_tx (chan, false); +if (ret) { +dev_err (chan->qmc->dev,"chan %u: Disable tsa entries failed (%d)\n" , + chan->id, ret); + goto end; + } + } + end:spin_unlock_irqrestore (&chan->tx_lock, flags);return ret; } +static int qmc_chan_start_rx (struct qmc_chan *chan); +int qmc_chan_stop (struct qmc_chan *chan,int direction) { -int ret; +bool is_rx_rollback_needed = false; +unsigned long flags; +int ret =0 ; + +spin_lock_irqsave (&chan->ts_lock, flags);if (direction &QMC_CHAN_READ ) { + is_rx_rollback_needed = !chan->is_rx_stopped; ret =qmc_chan_stop_rx (chan);if (ret) -return ret; + goto end; }if (direction &QMC_CHAN_WRITE ) { ret =qmc_chan_stop_tx (chan); -if (ret) -return ret; +if (ret) { +/* Restart rx if needed */ +if (is_rx_rollback_needed) +qmc_chan_start_rx (chan); + goto end; + } } -return 0 ; +end: +spin_unlock_irqrestore (&chan->ts_lock, flags); +return ret; }EXPORT_SYMBOL (qmc_chan_stop); -static void qmc_chan_start_rx (struct qmc_chan *chan) +static int qmc_setup_chan_trnsync (struct qmc *qmc,struct qmc_chan *chan); + +static int qmc_chan_start_rx (struct qmc_chan *chan) {unsigned long flags; +int ret;spin_lock_irqsave (&chan->rx_lock, flags); +if (!chan->is_rx_stopped) { +/* The channel is already started -> simply return ok */ + ret =0 ; + goto end; + } + + ret =qmc_chan_setup_tsa_rx (chan, true); +if (ret) { +dev_err (chan->qmc->dev,"chan %u: Enable tsa entries failed (%d)\n" , + chan->id, ret); + goto end; + } + + ret =qmc_setup_chan_trnsync (chan->qmc, chan); +if (ret) { +dev_err (chan->qmc->dev,"chan %u: setup TRNSYNC failed (%d)\n" , + chan->id, ret); + goto end; + } +/* Restart the receiver */ if (chan->mode ==QMC_TRANSPARENT )qmc_write32 (chan->s_param +QMC_SPE_ZDSTATE ,0x18000080 );
@@ -792,15 +898,38 @@ static void qmc_chan_start_rx(struct qmc_chan *chan) chan->is_rx_stopped = false; +end:spin_unlock_irqrestore (&chan->rx_lock, flags); +return ret; } -static void qmc_chan_start_tx (struct qmc_chan *chan) +static int qmc_chan_start_tx (struct qmc_chan *chan) {unsigned long flags; +int ret;spin_lock_irqsave (&chan->tx_lock, flags); +if (!chan->is_tx_stopped) { +/* The channel is already started -> simply return ok */ + ret =0 ; + goto end; + } + + ret =qmc_chan_setup_tsa_tx (chan, true); +if (ret) { +dev_err (chan->qmc->dev,"chan %u: Enable tsa entries failed (%d)\n" , + chan->id, ret); + goto end; + } + + ret =qmc_setup_chan_trnsync (chan->qmc, chan); +if (ret) { +dev_err (chan->qmc->dev,"chan %u: setup TRNSYNC failed (%d)\n" , + chan->id, ret); + goto end; + } +/* * Enable channel transmitter as it could be disabled if * qmc_chan_reset() was called.
@@ -812,18 +941,39 @@ static void qmc_chan_start_tx(struct qmc_chan *chan) chan->is_tx_stopped = false; +end:spin_unlock_irqrestore (&chan->tx_lock, flags); +return ret; }int qmc_chan_start (struct qmc_chan *chan,int direction) { -if (direction &QMC_CHAN_READ ) -qmc_chan_start_rx (chan); +bool is_rx_rollback_needed = false; +unsigned long flags; +int ret =0 ; -if (direction &QMC_CHAN_WRITE ) -qmc_chan_start_tx (chan); +spin_lock_irqsave (&chan->ts_lock, flags); -return 0 ; +if (direction &QMC_CHAN_READ ) { + is_rx_rollback_needed = chan->is_rx_stopped; + ret =qmc_chan_start_rx (chan); +if (ret) + goto end; + } + +if (direction &QMC_CHAN_WRITE ) { + ret =qmc_chan_start_tx (chan); +if (ret) { +/* Restop rx if needed */ +if (is_rx_rollback_needed) +qmc_chan_stop_rx (chan); + goto end; + } + } + +end: +spin_unlock_irqrestore (&chan->ts_lock, flags); +return ret; }EXPORT_SYMBOL (qmc_chan_start);
@@ -992,6 +1142,7 @@ static int qmc_of_parse_chans(struct qmc *qmc, struct device_node *np) } chan->id = chan_id; +spin_lock_init (&chan->ts_lock);spin_lock_init (&chan->rx_lock);spin_lock_init (&chan->tx_lock);
Signature · 7 lines
2.41.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH v4 18/28 soc: fsl: cpm1: qmc: Remove timeslots handling from setup_chan()
In reply to Christophe LeroyFrom: Herve Codina <[email protected]>
Timeslots setting is done at channel start() and stop(). There is no more need to do that during setup_chan().
Simply remove timeslot setting from setup_chan().
--- drivers/soc/fsl/qe/qmc.c | 28 ---------------------------- 1 file changed, 28 deletions(-)
drivers/soc/fsl/qe/qmc.c +0 -28
@@ -723,30 +723,6 @@ static int qmc_chan_setup_tsa_rx(struct qmc_chan *chan, bool enable)return qmc_chan_setup_tsa_32rx (chan, &info, enable); } -static int qmc_chan_setup_tsa (struct qmc_chan *chan,bool enable) -{ -struct tsa_serial_info info; -int ret; - -/* Retrieve info from the TSA related serial */ - ret =tsa_serial_get_info (chan->qmc->tsa_serial, &info); -if (ret) -return ret; - -/* -* Setup one common 64 entries table or two 32 entries (one for Tx -* and one for Tx) according to assigned TS numbers. -*/ -if (chan->qmc->is_tsa_64rxtx) -return qmc_chan_setup_tsa_64rxtx (chan, &info, enable); - - ret =qmc_chan_setup_tsa_32rx (chan, &info, enable); -if (ret) -return ret; - -return qmc_chan_setup_tsa_32tx (chan, &info, enable); -} -static int qmc_chan_command (struct qmc_chan *chan,u8 qmc_opcode) {return cpm_command (chan->id <<2 , (qmc_opcode <<4 ) |0x0E );
@@ -1323,10 +1299,6 @@ static int qmc_setup_chan(struct qmc *qmc, struct qmc_chan *chan) chan->qmc = qmc; - ret =qmc_chan_setup_tsa (chan, true); -if (ret) -return ret; -/* Set channel specific parameter base address */ chan->s_param = qmc->dpram + (chan->id *64 );/* 16 bd per channel (8 rx and 8 tx) */
Signature · 1 line
2.41.0
PATCH v4 19/28 soc: fsl: cpm1: qmc: Introduce functions to change timeslots at runtime
In reply to Christophe LeroyFrom: Herve Codina <[email protected]>
Introduce qmc_chan_{get,set}_ts_info() function to allow timeslots modification at runtime.
The modification is provided using qmc_chan_set_ts_info() and will be applied on next qmc_chan_start().qmc_chan_set_ts_info() must be called with the channel rx and/or tx stopped.
--- drivers/soc/fsl/qe/qmc.c | 51 ++++++++++++++++++++++++++++++++++++++++ include/soc/fsl/qe/qmc.h | 10 ++++++++ 2 files changed, 61 insertions(+)
drivers/soc/fsl/qe/qmc.c +51 -0
@@ -290,6 +290,57 @@ int qmc_chan_get_info(struct qmc_chan *chan, struct qmc_chan_info *info) }EXPORT_SYMBOL (qmc_chan_get_info); +int qmc_chan_get_ts_info (struct qmc_chan *chan,struct qmc_chan_ts_info *ts_info) +{ +unsigned long flags; + +spin_lock_irqsave (&chan->ts_lock, flags); + + ts_info->rx_ts_mask_avail = chan->rx_ts_mask_avail; + ts_info->tx_ts_mask_avail = chan->tx_ts_mask_avail; + ts_info->rx_ts_mask = chan->rx_ts_mask; + ts_info->tx_ts_mask = chan->tx_ts_mask; + +spin_unlock_irqrestore (&chan->ts_lock, flags); + +return 0 ; +} +EXPORT_SYMBOL (qmc_chan_get_ts_info); + +int qmc_chan_set_ts_info (struct qmc_chan *chan,const struct qmc_chan_ts_info *ts_info) +{ +unsigned long flags; +int ret; + +/* Only a subset of available timeslots is allowed */ +if ((ts_info->rx_ts_mask & chan->rx_ts_mask_avail) != ts_info->rx_ts_mask) +return -EINVAL ; +if ((ts_info->tx_ts_mask & chan->tx_ts_mask_avail) != ts_info->tx_ts_mask) +return -EINVAL ; + +/* In case of common rx/tx table, rx/tx masks must be identical */ +if (chan->qmc->is_tsa_64rxtx) { +if (ts_info->rx_ts_mask != ts_info->tx_ts_mask) +return -EINVAL ; + } + +spin_lock_irqsave (&chan->ts_lock, flags); + +if ((chan->tx_ts_mask != ts_info->tx_ts_mask && !chan->is_tx_stopped) || + (chan->rx_ts_mask != ts_info->rx_ts_mask && !chan->is_rx_stopped)) { +dev_err (chan->qmc->dev,"Channel rx and/or tx not stopped\n" ); + ret = -EBUSY ; + }else { + chan->tx_ts_mask = ts_info->tx_ts_mask; + chan->rx_ts_mask = ts_info->rx_ts_mask; + ret =0 ; + } +spin_unlock_irqrestore (&chan->ts_lock, flags); + +return ret; +} +EXPORT_SYMBOL (qmc_chan_set_ts_info); +int qmc_chan_set_param (struct qmc_chan *chan,const struct qmc_chan_param *param) {if (param->mode != chan->mode)
include/soc/fsl/qe/qmc.h +10 -0
@@ -38,6 +38,16 @@ struct qmc_chan_info {int qmc_chan_get_info (struct qmc_chan *chan,struct qmc_chan_info *info); +struct qmc_chan_ts_info { +u64 rx_ts_mask_avail; +u64 tx_ts_mask_avail; +u64 rx_ts_mask; +u64 tx_ts_mask; +}; + +int qmc_chan_get_ts_info (struct qmc_chan *chan,struct qmc_chan_ts_info *ts_info); +int qmc_chan_set_ts_info (struct qmc_chan *chan,const struct qmc_chan_ts_info *ts_info); +struct qmc_chan_param {enum qmc_mode mode;union {
Signature · 7 lines
2.41.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH v4 20/28 wan: qmc_hdlc: Add runtime timeslots changes support
In reply to Christophe LeroyFrom: Herve Codina <[email protected]>
QMC channels support runtime timeslots changes but nothing is done at the QMC HDLC driver to handle these changes.
Use existing IFACE ioctl in order to configure the timeslots to use.
--- drivers/net/wan/fsl_qmc_hdlc.c | 169 ++++++++++++++++++++++++++++++++- 1 file changed, 168 insertions(+), 1 deletion(-)
drivers/net/wan/fsl_qmc_hdlc.c +168 -1
@@ -32,6 +32,7 @@ struct qmc_hdlc {struct qmc_hdlc_desc tx_descs[8 ];unsigned int tx_out;struct qmc_hdlc_desc rx_descs[4 ]; +u32 slot_map; };static inline struct qmc_hdlc *netdev_to_qmc_hdlc (struct net_device *netdev)
@@ -202,6 +203,162 @@ static netdev_tx_t qmc_hdlc_xmit(struct sk_buff *skb, struct net_device *netdev)return NETDEV_TX_OK ; } +static int qmc_hdlc_xlate_slot_map (struct qmc_hdlc *qmc_hdlc, +u32 slot_map,struct qmc_chan_ts_info *ts_info) +{ +u64 ts_mask_avail; +unsigned int bit; +unsigned int i; +u64 ts_mask; +u64 map =0 ; + +/* Tx and Rx masks must be identical */ +if (ts_info->rx_ts_mask_avail != ts_info->tx_ts_mask_avail) { +dev_err (qmc_hdlc->dev,"tx and rx available timeslots mismatch (0x%llx, 0x%llx)\n" , + ts_info->rx_ts_mask_avail, ts_info->tx_ts_mask_avail); +return -EINVAL ; + } + + ts_mask_avail = ts_info->rx_ts_mask_avail; + ts_mask =0 ; + map = slot_map; + bit =0 ; +for (i =0 ; i <64 ; i++) { +if (ts_mask_avail &BIT_ULL (i)) { +if (map &BIT_ULL (bit)) + ts_mask |=BIT_ULL (i); + bit++; + } + } + +if (hweight64 (ts_mask) !=hweight64 (map)) { +dev_err (qmc_hdlc->dev,"Cannot translate timeslots 0x%llx -> (0x%llx,0x%llx)\n" , + map, ts_mask_avail, ts_mask); +return -EINVAL ; + } + + ts_info->tx_ts_mask = ts_mask; + ts_info->rx_ts_mask = ts_mask; +return 0 ; +} + +static int qmc_hdlc_xlate_ts_info (struct qmc_hdlc *qmc_hdlc, +const struct qmc_chan_ts_info *ts_info,u32 *slot_map) +{ +u64 ts_mask_avail; +unsigned int bit; +unsigned int i; +u64 ts_mask; +u64 map =0 ; + +/* Tx and Rx masks must be identical */ +if (ts_info->rx_ts_mask_avail != ts_info->tx_ts_mask_avail) { +dev_err (qmc_hdlc->dev,"tx and rx available timeslots mismatch (0x%llx, 0x%llx)\n" , + ts_info->rx_ts_mask_avail, ts_info->tx_ts_mask_avail); +return -EINVAL ; + } +if (ts_info->rx_ts_mask != ts_info->tx_ts_mask) { +dev_err (qmc_hdlc->dev,"tx and rx timeslots mismatch (0x%llx, 0x%llx)\n" , + ts_info->rx_ts_mask, ts_info->tx_ts_mask); +return -EINVAL ; + } + + ts_mask_avail = ts_info->rx_ts_mask_avail; + ts_mask = ts_info->rx_ts_mask; + map =0 ; + bit =0 ; +for (i =0 ; i <64 ; i++) { +if (ts_mask_avail &BIT_ULL (i)) { +if (ts_mask &BIT_ULL (i)) + map |=BIT_ULL (bit); + bit++; + } + } + +if (hweight64 (ts_mask) !=hweight64 (map)) { +dev_err (qmc_hdlc->dev,"Cannot translate timeslots (0x%llx,0x%llx) -> 0x%llx\n" , + ts_mask_avail, ts_mask, map); +return -EINVAL ; + } + +if (map >=BIT_ULL (32 )) { +dev_err (qmc_hdlc->dev,"Slot map out of 32bit (0x%llx,0x%llx) -> 0x%llx\n" , + ts_mask_avail, ts_mask, map); +return -EINVAL ; + } + + *slot_map = map; +return 0 ; +} + +static int qmc_hdlc_set_iface (struct qmc_hdlc *qmc_hdlc,int if_iface,const te1_settings *te1) +{ +struct qmc_chan_ts_info ts_info; +int ret; + + ret =qmc_chan_get_ts_info (qmc_hdlc->qmc_chan, &ts_info); +if (ret) { +dev_err (qmc_hdlc->dev,"get QMC channel ts info failed %d\n" , ret); +return ret; + } + ret =qmc_hdlc_xlate_slot_map (qmc_hdlc, te1->slot_map, &ts_info); +if (ret) +return ret; + + ret =qmc_chan_set_ts_info (qmc_hdlc->qmc_chan, &ts_info); +if (ret) { +dev_err (qmc_hdlc->dev,"set QMC channel ts info failed %d\n" , ret); +return ret; + } + + qmc_hdlc->slot_map = te1->slot_map; + +return 0 ; +} + +static int qmc_hdlc_ioctl (struct net_device *netdev,struct if_settings *ifs) +{ +struct qmc_hdlc *qmc_hdlc =netdev_to_qmc_hdlc (netdev); +te1_settings te1; + +switch (ifs->type) { +case IF_GET_IFACE : + ifs->type =IF_IFACE_E1 ; +if (ifs->size <sizeof (te1)) { +if (!ifs->size) +return 0 ;/* only type requested */ + + ifs->size =sizeof (te1);/* data size wanted */ +return -ENOBUFS ; + } + +memset (&te1,0 ,sizeof (te1)); + +/* Update slot_map */ + te1.slot_map = qmc_hdlc->slot_map; + +if (copy_to_user (ifs->ifs_ifsu.te1, &te1,sizeof (te1))) +return -EFAULT ; +return 0 ; + +case IF_IFACE_E1 : +case IF_IFACE_T1 : +if (!capable (CAP_NET_ADMIN )) +return -EPERM ; + +if (netdev->flags &IFF_UP ) +return -EBUSY ; + +if (copy_from_user (&te1, ifs->ifs_ifsu.te1,sizeof (te1))) +return -EFAULT ; + +return qmc_hdlc_set_iface (qmc_hdlc, ifs->type, &te1); + +default : +return hdlc_ioctl (netdev, ifs); + } +} +static int qmc_hdlc_open (struct net_device *netdev) {struct qmc_hdlc *qmc_hdlc =netdev_to_qmc_hdlc (netdev);
@@ -328,13 +485,14 @@ static const struct net_device_ops qmc_hdlc_netdev_ops = { .ndo_open = qmc_hdlc_open, .ndo_stop = qmc_hdlc_close, .ndo_start_xmit = hdlc_start_xmit, - .ndo_siocwandev = hdlc_ioctl, + .ndo_siocwandev = qmc_hdlc_ioctl, };static int qmc_hdlc_probe (struct platform_device *pdev) {struct device_node *np = pdev->dev.of_node;struct qmc_hdlc *qmc_hdlc; +struct qmc_chan_ts_info ts_info;struct qmc_chan_info info;hdlc_device *hdlc;int ret;
@@ -364,6 +522,15 @@ static int qmc_hdlc_probe(struct platform_device *pdev)return -EINVAL ; } + ret =qmc_chan_get_ts_info (qmc_hdlc->qmc_chan, &ts_info); +if (ret) { +dev_err (qmc_hdlc->dev,"get QMC channel ts info failed %d\n" , ret); +return ret; + } + ret =qmc_hdlc_xlate_ts_info (qmc_hdlc, &ts_info, &qmc_hdlc->slot_map); +if (ret) +return ret; + qmc_hdlc->netdev =alloc_hdlcdev (qmc_hdlc);if (!qmc_hdlc->netdev) {dev_err (qmc_hdlc->dev,"failed to alloc hdlc dev\n" );
Signature · 7 lines
2.41.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH v4 20/28] wan: qmc_hdlc: Add runtime timeslots changes support
Le 18/08/2023 à 18:39, Christophe Leroy a écrit :
Quoted 11 lines
From: Herve Codina <[email protected]>
QMC channels support runtime timeslots changes but nothing is done at the QMC HDLC driver to handle these changes.
Use existing IFACE ioctl in order to configure the timeslots to use.
Signed-off-by Herve Codina <[email protected]>Reviewed-by Christophe Leroy <[email protected]>Signed-off-by Christophe Leroy <[email protected]>---
Hi,
a few nits below, should there be a v5.
Quoted 17 lines
drivers/net/wan/fsl_qmc_hdlc.c | 169 ++++++++++++++++++++++++++++++++- 1 file changed, 168 insertions(+), 1 deletion(-)drivers/net/wan/fsl_qmc_hdlc.c +1
-0@@ -32,6 +32,7 @@ struct qmc_hdlc {struct qmc_hdlc_desc tx_descs[8 ];unsigned int tx_out;struct qmc_hdlc_desc rx_descs[4 ]; +u32 slot_map; };static inline struct qmc_hdlc *netdev_to_qmc_hdlc (struct net_device *netdev)@@ -202,6 +203,162 @@ static netdev_tx_t qmc_hdlc_xmit(struct sk_buff *skb, struct net_device *netdev)return NETDEV_TX_OK ;
drivers/net/wan/fsl_qmc_hdlc.c static netdev_tx_t qmc_hdlc_xmit(struct sk_buff *skb, struct net_device *netdev) · line 213
Quoted 10 lines
drivers/net/wan/fsl_qmc_hdlc.c +8
-0} +static int qmc_hdlc_xlate_slot_map (struct qmc_hdlc *qmc_hdlc, +u32 slot_map,struct qmc_chan_ts_info *ts_info) +{ +u64 ts_mask_avail; +unsigned int bit; +unsigned int i; +u64 ts_mask; +u64 map =0 ;
This init looks useless.
Quoted 29 lines
drivers/net/wan/fsl_qmc_hdlc.c +29
-0+ +/* Tx and Rx masks must be identical */ +if (ts_info->rx_ts_mask_avail != ts_info->tx_ts_mask_avail) { +dev_err (qmc_hdlc->dev,"tx and rx available timeslots mismatch (0x%llx, 0x%llx)\n" , + ts_info->rx_ts_mask_avail, ts_info->tx_ts_mask_avail); +return -EINVAL ; + } + + ts_mask_avail = ts_info->rx_ts_mask_avail; + ts_mask =0 ; + map = slot_map; + bit =0 ; +for (i =0 ; i <64 ; i++) { +if (ts_mask_avail &BIT_ULL (i)) { +if (map &BIT_ULL (bit)) + ts_mask |=BIT_ULL (i); + bit++; + } + } + +if (hweight64 (ts_mask) !=hweight64 (map)) { +dev_err (qmc_hdlc->dev,"Cannot translate timeslots 0x%llx -> (0x%llx,0x%llx)\n" , + map, ts_mask_avail, ts_mask); +return -EINVAL ; + } + + ts_info->tx_ts_mask = ts_mask; + ts_info->rx_ts_mask = ts_mask; +return 0 ;
drivers/net/wan/fsl_qmc_hdlc.c static netdev_tx_t qmc_hdlc_xmit(struct sk_buff *skb, struct net_device *netdev) · line 252
Quoted 10 lines
drivers/net/wan/fsl_qmc_hdlc.c +10
-0+} + +static int qmc_hdlc_xlate_ts_info (struct qmc_hdlc *qmc_hdlc, +const struct qmc_chan_ts_info *ts_info,u32 *slot_map) +{ +u64 ts_mask_avail; +unsigned int bit; +unsigned int i; +u64 ts_mask; +u64 map =0 ;
This init looks useless.
Quoted 40 lines
drivers/net/wan/fsl_qmc_hdlc.c +40
-0+ +/* Tx and Rx masks must be identical */ +if (ts_info->rx_ts_mask_avail != ts_info->tx_ts_mask_avail) { +dev_err (qmc_hdlc->dev,"tx and rx available timeslots mismatch (0x%llx, 0x%llx)\n" , + ts_info->rx_ts_mask_avail, ts_info->tx_ts_mask_avail); +return -EINVAL ; + } +if (ts_info->rx_ts_mask != ts_info->tx_ts_mask) { +dev_err (qmc_hdlc->dev,"tx and rx timeslots mismatch (0x%llx, 0x%llx)\n" , + ts_info->rx_ts_mask, ts_info->tx_ts_mask); +return -EINVAL ; + } + + ts_mask_avail = ts_info->rx_ts_mask_avail; + ts_mask = ts_info->rx_ts_mask; + map =0 ; + bit =0 ; +for (i =0 ; i <64 ; i++) { +if (ts_mask_avail &BIT_ULL (i)) { +if (ts_mask &BIT_ULL (i)) + map |=BIT_ULL (bit); + bit++; + } + } + +if (hweight64 (ts_mask) !=hweight64 (map)) { +dev_err (qmc_hdlc->dev,"Cannot translate timeslots (0x%llx,0x%llx) -> 0x%llx\n" , + ts_mask_avail, ts_mask, map); +return -EINVAL ; + } + +if (map >=BIT_ULL (32 )) { +dev_err (qmc_hdlc->dev,"Slot map out of 32bit (0x%llx,0x%llx) -> 0x%llx\n" , + ts_mask_avail, ts_mask, map); +return -EINVAL ; + } + + *slot_map = map; +return 0 ; +}
...
Quoted 12 lines
drivers/net/wan/fsl_qmc_hdlc.c +12
-0+static int qmc_hdlc_ioctl (struct net_device *netdev,struct if_settings *ifs) +{ +struct qmc_hdlc *qmc_hdlc =netdev_to_qmc_hdlc (netdev); +te1_settings te1; + +switch (ifs->type) { +case IF_GET_IFACE : + ifs->type =IF_IFACE_E1 ; +if (ifs->size <sizeof (te1)) { +if (!ifs->size) +return 0 ;/* only type requested */ +
drivers/net/wan/fsl_qmc_hdlc.c static netdev_tx_t qmc_hdlc_xmit(struct sk_buff *skb, struct net_device *netdev) · line 340
Quoted 10 lines
drivers/net/wan/fsl_qmc_hdlc.c +10
-0+ ifs->size =sizeof (te1);/* data size wanted */ +return -ENOBUFS ; + } + +memset (&te1,0 ,sizeof (te1)); + +/* Update slot_map */ + te1.slot_map = qmc_hdlc->slot_map; + +if (copy_to_user (ifs->ifs_ifsu.te1, &te1,sizeof (te1)))
~~
Extra space.
Quoted 20 lines
drivers/net/wan/fsl_qmc_hdlc.c +20
-0+return -EFAULT ; +return 0 ; + +case IF_IFACE_E1 : +case IF_IFACE_T1 : +if (!capable (CAP_NET_ADMIN )) +return -EPERM ; + +if (netdev->flags &IFF_UP ) +return -EBUSY ; + +if (copy_from_user (&te1, ifs->ifs_ifsu.te1,sizeof (te1))) +return -EFAULT ; + +return qmc_hdlc_set_iface (qmc_hdlc, ifs->type, &te1); + +default : +return hdlc_ioctl (netdev, ifs); + } +}
...
Herve Codina
maintainerRe: [PATCH v4 20/28] wan: qmc_hdlc: Add runtime timeslots changes support
Hi Christophe,
Quoted 36 lines · On Mon, 21 Aug 2023 07:40:26 +0200 Christophe JAILLET…
Le 18/08/2023 à 18:39, Christophe Leroy a écrit :
Quoted 11 lines
From: Herve Codina <[email protected]>
QMC channels support runtime timeslots changes but nothing is done at the QMC HDLC driver to handle these changes.
Use existing IFACE ioctl in order to configure the timeslots to use.
Signed-off-by Herve Codina <[email protected]>Reviewed-by Christophe Leroy <[email protected]>Signed-off-by Christophe Leroy <[email protected]>---
Hi,
a few nits below, should there be a v5.
Quoted 19 lines
drivers/net/wan/fsl_qmc_hdlc.c | 169 ++++++++++++++++++++++++++++++++- 1 file changed, 168 insertions(+), 1 deletion(-)drivers/net/wan/fsl_qmc_hdlc.c +1
-0@@ -32,6 +32,7 @@ struct qmc_hdlc {struct qmc_hdlc_desc tx_descs[8 ];unsigned int tx_out;struct qmc_hdlc_desc rx_descs[4 ]; +u32 slot_map; };static inline struct qmc_hdlc *netdev_to_qmc_hdlc (struct net_device *netdev)@@ -202,6 +203,162 @@ static netdev_tx_t qmc_hdlc_xmit(struct sk_buff *skb, struct net_device *netdev)return NETDEV_TX_OK ; }
Quoted 10 lines
drivers/net/wan/fsl_qmc_hdlc.c static netdev_tx_t qmc_hdlc_xmit(struct sk_buff *skb, struct net_device *netdev) · line 213
Quoted 8 lines
drivers/net/wan/fsl_qmc_hdlc.c +8
-0+static int qmc_hdlc_xlate_slot_map (struct qmc_hdlc *qmc_hdlc, +u32 slot_map,struct qmc_chan_ts_info *ts_info) +{ +u64 ts_mask_avail; +unsigned int bit; +unsigned int i; +u64 ts_mask; +u64 map =0 ;This init looks useless.
Will be removed in the next iteration.
Quoted 34 lines
Quoted 34 lines
drivers/net/wan/fsl_qmc_hdlc.c +33
-0+ +/* Tx and Rx masks must be identical */ +if (ts_info->rx_ts_mask_avail != ts_info->tx_ts_mask_avail) { +dev_err (qmc_hdlc->dev,"tx and rx available timeslots mismatch (0x%llx, 0x%llx)\n" , + ts_info->rx_ts_mask_avail, ts_info->tx_ts_mask_avail); +return -EINVAL ; + } + + ts_mask_avail = ts_info->rx_ts_mask_avail; + ts_mask =0 ; + map = slot_map; + bit =0 ; +for (i =0 ; i <64 ; i++) { +if (ts_mask_avail &BIT_ULL (i)) { +if (map &BIT_ULL (bit)) + ts_mask |=BIT_ULL (i); + bit++; + } + } + +if (hweight64 (ts_mask) !=hweight64 (map)) { +dev_err (qmc_hdlc->dev,"Cannot translate timeslots 0x%llx -> (0x%llx,0x%llx)\n" , + map, ts_mask_avail, ts_mask); +return -EINVAL ; + } + + ts_info->tx_ts_mask = ts_mask; + ts_info->rx_ts_mask = ts_mask; +return 0 ; +} + +static int qmc_hdlc_xlate_ts_info (struct qmc_hdlc *qmc_hdlc, +const struct qmc_chan_ts_info *ts_info,u32 *slot_map)
Quoted 8 lines
drivers/net/wan/fsl_qmc_hdlc.c static netdev_tx_t qmc_hdlc_xmit(struct sk_buff *skb, struct net_device *netdev) · line 213
Quoted 6 lines
drivers/net/wan/fsl_qmc_hdlc.c +6
-0+{ +u64 ts_mask_avail; +unsigned int bit; +unsigned int i; +u64 ts_mask; +u64 map =0 ;This init looks useless.
Will be remove in the next iteration.
Quoted 68 lines
Quoted 41 lines
drivers/net/wan/fsl_qmc_hdlc.c +40
-0+ +/* Tx and Rx masks must be identical */ +if (ts_info->rx_ts_mask_avail != ts_info->tx_ts_mask_avail) { +dev_err (qmc_hdlc->dev,"tx and rx available timeslots mismatch (0x%llx, 0x%llx)\n" , + ts_info->rx_ts_mask_avail, ts_info->tx_ts_mask_avail); +return -EINVAL ; + } +if (ts_info->rx_ts_mask != ts_info->tx_ts_mask) { +dev_err (qmc_hdlc->dev,"tx and rx timeslots mismatch (0x%llx, 0x%llx)\n" , + ts_info->rx_ts_mask, ts_info->tx_ts_mask); +return -EINVAL ; + } + + ts_mask_avail = ts_info->rx_ts_mask_avail; + ts_mask = ts_info->rx_ts_mask; + map =0 ; + bit =0 ; +for (i =0 ; i <64 ; i++) { +if (ts_mask_avail &BIT_ULL (i)) { +if (ts_mask &BIT_ULL (i)) + map |=BIT_ULL (bit); + bit++; + } + } + +if (hweight64 (ts_mask) !=hweight64 (map)) { +dev_err (qmc_hdlc->dev,"Cannot translate timeslots (0x%llx,0x%llx) -> 0x%llx\n" , + ts_mask_avail, ts_mask, map); +return -EINVAL ; + } + +if (map >=BIT_ULL (32 )) { +dev_err (qmc_hdlc->dev,"Slot map out of 32bit (0x%llx,0x%llx) -> 0x%llx\n" , + ts_mask_avail, ts_mask, map); +return -EINVAL ; + } + + *slot_map = map; +return 0 ; +}...
Quoted 12 lines
drivers/net/wan/fsl_qmc_hdlc.c +12
-0+static int qmc_hdlc_ioctl (struct net_device *netdev,struct if_settings *ifs) +{ +struct qmc_hdlc *qmc_hdlc =netdev_to_qmc_hdlc (netdev); +te1_settings te1; + +switch (ifs->type) { +case IF_GET_IFACE : + ifs->type =IF_IFACE_E1 ; +if (ifs->size <sizeof (te1)) { +if (!ifs->size) +return 0 ;/* only type requested */ +drivers/net/wan/fsl_qmc_hdlc.c static netdev_tx_t qmc_hdlc_xmit(struct sk_buff *skb, struct net_device *netdev) · line 340
Quoted 10 lines
drivers/net/wan/fsl_qmc_hdlc.c +10
-0+ ifs->size =sizeof (te1);/* data size wanted */ +return -ENOBUFS ; + } + +memset (&te1,0 ,sizeof (te1)); + +/* Update slot_map */ + te1.slot_map = qmc_hdlc->slot_map; + +if (copy_to_user (ifs->ifs_ifsu.te1, &te1,sizeof (te1)))~~
Quoted 1 line
Extra space.
Will be fixed in the next iteration.
Quoted 15 lines
Quoted 15 lines
drivers/net/wan/fsl_qmc_hdlc.c +14
-0+return -EFAULT ; +return 0 ; + +case IF_IFACE_E1 : +case IF_IFACE_T1 : +if (!capable (CAP_NET_ADMIN )) +return -EPERM ; + +if (netdev->flags &IFF_UP ) +return -EBUSY ; + +if (copy_from_user (&te1, ifs->ifs_ifsu.te1,sizeof (te1))) +return -EFAULT ; +
Quoted 9 lines
Quoted 6 lines
drivers/net/wan/fsl_qmc_hdlc.c +6
-0+return qmc_hdlc_set_iface (qmc_hdlc, ifs->type, &te1); + +default : +return hdlc_ioctl (netdev, ifs); + } +}...
Thanks for the review,
Best regards,
Hervé
Signature · 3 lines
Hervé Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH v4 21/28 net: wan: Add framer framework support
In reply to Christophe LeroyFrom: Herve Codina <[email protected]>
A framer is a component in charge of an E1/T1 line interface. Connected usually to a TDM bus, it converts TDM frames to/from E1/T1 frames. It also provides information related to the E1/T1 line.
The framer framework provides a set of APIs for the framer drivers (framer provider) to create/destroy a framer and APIs for the framer users (framer consumer) to obtain a reference to the framer, and use the framer.
This basic implementation provides a framer abstraction for:
- power on/off the framer
- get the framer status (line state)
- be notified on framer status changes
- get/set the framer configuration
---
v4: Fixed wrong names in three EXPORT_SYMBOL()
--- drivers/net/wan/Kconfig | 2 + drivers/net/wan/Makefile | 2 + drivers/net/wan/framer/Kconfig | 19 + drivers/net/wan/framer/Makefile | 6 + drivers/net/wan/framer/framer-core.c | 886 +++++++++++++++++++++++++ include/linux/framer/framer-provider.h | 194 ++++++ include/linux/framer/framer.h | 199 ++++++ 7 files changed, 1308 insertions(+) create mode 100644 drivers/net/wan/framer/Kconfig create mode 100644 drivers/net/wan/framer/Makefile create mode 100644 drivers/net/wan/framer/framer-core.c create mode 100644 include/linux/framer/framer-provider.h create mode 100644 include/linux/framer/framer.h
drivers/net/wan/Kconfig +2 -0
@@ -95,6 +95,8 @@ config HDLC_X25 comment "X.25/LAPB support is disabled" depends on HDLC && (LAPB!=m || HDLC!=m) && LAPB!=y +source "drivers/net/wan/framer/Kconfig" + config PCI200SYN tristate "Goramo PCI200SYN support" depends on HDLC && PCI
drivers/net/wan/Makefile +2 -0
@@ -14,6 +14,8 @@ obj-$(CONFIG_HDLC_FR) += hdlc_fr.o obj-$(CONFIG_HDLC_PPP) += hdlc_ppp.o obj-$(CONFIG_HDLC_X25) += hdlc_x25.o +obj-y += framer/ + obj-$(CONFIG_FARSYNC) += farsync.o obj-$(CONFIG_LAPBETHER) += lapbether.o
drivers/net/wan/framer/Kconfig new file +19 -0
@@ -0,0 +1,19 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# FRAMER +# + +menu "Framer Subsystem" + +config GENERIC_FRAMER + bool "Framer Core" + help + Generic Framer support. + + This framework is designed to provide a generic interface for framer + devices present in the kernel. This layer will have the generic + API by which framer drivers can create framer using the framer + framework and framer users can obtain reference to the framer. + All the users of this framework should select this config. + +endmenu
drivers/net/wan/framer/Makefile new file +6 -0
@@ -0,0 +1,6 @@ +# SPDX-License-Identifier: GPL-2.0 +# +# Makefile for the framer drivers. +# + +obj-$(CONFIG_GENERIC_FRAMER) += framer-core.o
drivers/net/wan/framer/framer-core.c new file +886 -0
886 lines not on this page · raw message
include/linux/framer/framer-provider.h new file +194 -0
194 lines not on this page · raw message
include/linux/framer/framer.h new file +199 -0
199 lines not on this page · raw message
Signature · 9 lines
2.41.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Jakub Kicinski
maintainerRe: [PATCH v4 21/28] net: wan: Add framer framework support
Quoted 5 lines · On Fri, 18 Aug 2023 18:39:15 +0200 Christophe Leroy wrote:
From: Herve Codina <[email protected]>
A framer is a component in charge of an E1/T1 line interface. Connected usually to a TDM bus, it converts TDM frames to/from E1/T1 frames. It also provides information related to the E1/T1 line.
Okay, progress is being made, now it builds patch by patch. Still some kdoc warnings remain (W=1 build only catches kdoc warnings in sources, you gotta run ./scripts/kernel-doc -none explicitly on the headers):
include/linux/framer/framer.h:27: warning: Enum value 'FRAMER_IFACE_E1' not described in enum 'framer_iface' include/linux/framer/framer.h:27: warning: Enum value 'FRAMER_IFACE_T1' not described in enum 'framer_iface' include/linux/framer/framer.h:35: warning: expecting prototype for enum framer_clock_mode. Prototype was for enum framer_clock_type instead include/linux/framer/framer.h:47: warning: expecting prototype for struct framer_configuration. Prototype was for struct framer_config instead include/linux/framer/framer.h:60: warning: cannot understand function prototype: 'enum framer_event ' include/linux/framer/framer.h:89: warning: Function parameter or member 'notify_status_work' not described in 'framer' include/linux/framer/framer.h:89: warning: Function parameter or member 'notifier_list' not described in 'framer' include/linux/framer/framer.h:89: warning: Function parameter or member 'polling_work' not described in 'framer'
Signature · 1 line
pw-bot: cr
Simon Horman
reviewerRe: [PATCH v4 21/28] net: wan: Add framer framework support
In reply to Christophe LeroyQuoted 17 lines · Christophe Leroy
From: Herve Codina <[email protected]>
A framer is a component in charge of an E1/T1 line interface. Connected usually to a TDM bus, it converts TDM frames to/from E1/T1 frames. It also provides information related to the E1/T1 line.
The framer framework provides a set of APIs for the framer drivers (framer provider) to create/destroy a framer and APIs for the framer users (framer consumer) to obtain a reference to the framer, and use the framer.
This basic implementation provides a framer abstraction for:
- power on/off the framer
- get the framer status (line state)
- be notified on framer status changes
- get/set the framer configuration
Quoted 3 lines
Signed-off-by Herve Codina <[email protected]>Reviewed-by Christophe Leroy <[email protected]>Signed-off-by Christophe Leroy <[email protected]>
Hi Christophe and Herve,
some minor feedback from my side.
...
Quoted 1 line
drivers/net/wan/framer/framer-core.c +0
-0
...
Quoted 4 lines
drivers/net/wan/framer/framer-core.c +4
-0+/** +* framer_create() - create a new framer +* @dev: device that is creating the new framer +* @node: device node of the framer. default to dev->of_node.
drivers/net/wan/framer/framer-core.c line 609
Quoted 10 lines
drivers/net/wan/framer/framer-core.c +10
-0+* @ops: function pointers for performing framer operations +* +* Called to create a framer using framer framework. +*/ +struct framer *framer_create (struct device *dev,struct device_node *node, +const struct framer_ops *ops) +{ +int ret; +int id; +struct framer *framer;
Please arrange local variable declarations for Networking code using reverse xmas tree order - longest line to shortest.
https://github.com/ecree-solarflare/xmastree is helpful here.
...
Quoted 1 line
include/linux/framer/framer-provider.h +0
-0
...
Quoted 9 lines
+/**
+ * structframer_ops- set of function pointers for performing framer operations
+ * @init: operation to be performed for initializing the framer
+ * @exit: operation to be performed while exiting
+ * @power_on: powering on the framer
+ * @power_off: powering off the framer
+ * @flags: OR-ed flags (FRAMER_FLAG_*) to ask for core functionality
+ * - @FRAMER_FLAG_POLL_STATUS:
+ * Ask the core to perfom a polling to get the framer status and
nit: perfom -> perform
checkpatch.pl --codespell is your friend here
Quoted 3 lines
+ * notify consumers on change. + * The framer should call @framer_notify_status_change() when it + * detects a status change. This is usally done using interrutps.
nit: usally -> usually
interrutps -> interrupts
...
Quoted 17 lines
include/linux/framer/framer.h new file +11
-0@@ -0,0 +1,199 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* +* Generic framer header file +* +* Copyright 2023 CS GROUP France +* +* Author: Herve Codina <[email protected]> +*/ + +#ifndef __DRIVERS_FRAMER_H +#define __DRIVERS_FRAMER_H
include/linux/framer/framer.h line 21
Quoted 10 lines
include/linux/framer/framer.h new file +10
-0+ +#include <linux/err.h> +#include <linux/mutex.h> +#include <linux/notifier.h> +#include <linux/of.h> +#include <linux/device.h> +#include <linux/workqueue.h> + +/** +* enum framer_iface - Framer interface
As this is a kernel-doc, please include documentation for the defined constants: FRAMER_IFACE_E1 and FRAMER_IFACE_T1.
As flagged by: ./scripts/kernel-doc -none
include/linux/framer/framer.h line 29
Quoted 8 lines
include/linux/framer/framer.h new file +8
-0+*/ +enum framer_iface { +FRAMER_IFACE_E1 ,/* E1 interface */ +FRAMER_IFACE_T1 ,/* T1 interface */ +}; + +/** +* enum framer_clock_mode - Framer clock mode
Likewise here too.
Also, nit: framer_clock_mode -> framer_clock_type
include/linux/framer/framer.h line 37
Quoted 8 lines
include/linux/framer/framer.h new file +8
-0+*/ +enum framer_clock_type { +FRAMER_CLOCK_EXT ,/* External clock */ +FRAMER_CLOCK_INT ,/* Internal clock */ +}; + +/** +* struct framer_configuration - Framer configuration
nit: framer_configuration -> framer_config
Quoted 10 lines
include/linux/framer/framer.h new file +10
-0+* @line_iface: Framer line interface +* @clock_mode: Framer clock type +* @clock_rate: Framer clock rate +*/ +struct framer_config { +enum framer_iface iface; +enum framer_clock_type clock_type; +unsigned long line_clock_rate; +}; +
include/linux/framer/framer.h line 57
Quoted 10 lines
include/linux/framer/framer.h new file +10
-0+/** +* struct framer_status - Framer status +* @link_is_on: Framer link state. true, the link is on, false, the link is off. +*/ +struct framer_status { +bool link_is_on; +}; + +/** +* framer_event - event available for notification
nit: framer_event -> enum framer_event
A~d please document FRAMER_EVENT_STATUS in the kernel doc too.
Quoted 4 lines
include/linux/framer/framer.h new file +4
-0+*/ +enum framer_event { +FRAMER_EVENT_STATUS ,/* Event notified on framer_status changes */ +};
...
Herve Codina
maintainerRe: [PATCH v4 21/28] net: wan: Add framer framework support
Hi Simon,
Quoted 41 lines · On Sun, 20 Aug 2023 19:15:11 +0200 Simon Horman <[email protected]> wrote:
Quoted 17 lines · Christophe Leroy
From: Herve Codina <[email protected]>
A framer is a component in charge of an E1/T1 line interface. Connected usually to a TDM bus, it converts TDM frames to/from E1/T1 frames. It also provides information related to the E1/T1 line.
The framer framework provides a set of APIs for the framer drivers (framer provider) to create/destroy a framer and APIs for the framer users (framer consumer) to obtain a reference to the framer, and use the framer.
This basic implementation provides a framer abstraction for:
- power on/off the framer
- get the framer status (line state)
- be notified on framer status changes
- get/set the framer configurationQuoted 3 lines
Signed-off-by Herve Codina <[email protected]>Reviewed-by Christophe Leroy <[email protected]>Signed-off-by Christophe Leroy <[email protected]>Hi Christophe and Herve,
some minor feedback from my side.
...
Quoted 1 line
drivers/net/wan/framer/framer-core.c +0
-0...
Quoted 9 lines
drivers/net/wan/framer/framer-core.c +9
-0+/** +* framer_create() - create a new framer +* @dev: device that is creating the new framer +* @node: device node of the framer. default to dev->of_node. +* @ops: function pointers for performing framer operations +* +* Called to create a framer using framer framework. +*/ +struct framer *framer_create(struct device *dev, struct device_node *node,
Quoted 8 lines
drivers/net/wan/framer/framer-core.c line 609
Quoted 5 lines
drivers/net/wan/framer/framer-core.c +5
-0+ const struct framer_ops *ops) +{ +int ret; +int id; +struct framer *framer;Please arrange local variable declarations for Networking code using reverse xmas tree order - longest line to shortest.
Yes, will be done in the next iteration.
Quoted 19 lines
https://github.com/ecree-solarflare/xmastree is helpful here.
...
Quoted 1 line
include/linux/framer/framer-provider.h +0
-0...
Quoted 9 lines
+/**
+ * structframer_ops- set of function pointers for performing framer operations
+ * @init: operation to be performed for initializing the framer
+ * @exit: operation to be performed while exiting
+ * @power_on: powering on the framer
+ * @power_off: powering off the framer
+ * @flags: OR-ed flags (FRAMER_FLAG_*) to ask for core functionality
+ * - @FRAMER_FLAG_POLL_STATUS:
+ * Ask the core to perfom a polling to get the framer status and
Quoted 1 line
nit: perfom -> perform
Will be fixed in the next iteration.
Quoted 9 lines
checkpatch.pl --codespell is your friend hereQuoted 3 lines
+ * notify consumers on change. + * The framer should call @framer_notify_status_change() when it + * detects a status change. This is usally done using interrutps.nit: usally -> usually
interrutps -> interrupts
Will be fixed in the next iteration.
Quoted 34 lines
...
Quoted 17 lines
include/linux/framer/framer.h new file +11
-0@@ -0,0 +1,199 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* +* Generic framer header file +* +* Copyright 2023 CS GROUP France +* +* Author: Herve Codina <[email protected]> +*/ + +#ifndef __DRIVERS_FRAMER_H +#define __DRIVERS_FRAMER_Hinclude/linux/framer/framer.h line 21
Quoted 10 lines
include/linux/framer/framer.h new file +10
-0+ +#include <linux/err.h> +#include <linux/mutex.h> +#include <linux/notifier.h> +#include <linux/of.h> +#include <linux/device.h> +#include <linux/workqueue.h> + +/** +* enum framer_iface - Framer interface As this is a kernel-doc, please include documentation for the defined constants:
FRAMER_IFACE_E1andFRAMER_IFACE_T1.
Quoted 1 line
As flagged by:
./scripts/kernel-doc-none
Will be done in the next iteration.
Quoted 12 lines
include/linux/framer/framer.h line 29
Quoted 9 lines
include/linux/framer/framer.h new file +8
-0+*/ +enum framer_iface { +FRAMER_IFACE_E1 ,/* E1 interface */ +FRAMER_IFACE_T1 ,/* T1 interface */ +}; + +/** +* enum framer_clock_mode - Framer clock mode Likewise here too.
Quoted 2 lines
Also, nit:
framer_clock_mode->framer_clock_type
Will be updated (doc and change to framer_clock_type) in the next iteration.
Quoted 10 lines
include/linux/framer/framer.h line 37
Quoted 8 lines
include/linux/framer/framer.h new file +8
-0+*/ +enum framer_clock_type { +FRAMER_CLOCK_EXT ,/* External clock */ +FRAMER_CLOCK_INT ,/* Internal clock */ +}; + +/** +* struct framer_configuration - Framer configuration nit:
framer_configuration->framer_config
Will be fixed in the next iteration.
Quoted 15 lines
Quoted 15 lines
include/linux/framer/framer.h new file +14
-0+* @line_iface: Framer line interface +* @clock_mode: Framer clock type +* @clock_rate: Framer clock rate +*/ +struct framer_config { +enum framer_iface iface; +enum framer_clock_type clock_type; +unsigned long line_clock_rate; +}; + +/** +* struct framer_status - Framer status +* @link_is_on: Framer link state. true, the link is on, false, the link is off. +*/
Quoted 8 lines
include/linux/framer/framer.h line 57
Quoted 6 lines
include/linux/framer/framer.h new file +6
-0+struct framer_status { +bool link_is_on; +}; + +/** +* framer_event - event available for notification nit:
framer_event-> enumframer_event
Will be fixed in the next iteration.
Quoted 2 lines
A~d please document
FRAMER_EVENT_STATUSin the kernel doc too.
Will be documented in the next iteration.
Quoted 7 lines
Quoted 5 lines
include/linux/framer/framer.h new file +4
-0+*/ +enum framer_event { +FRAMER_EVENT_STATUS ,/* Event notified on framer_status changes */ +};...
Thanks for the review,
Best regards,
Hervé
Re: [PATCH v4 21/28] net: wan: Add framer framework support
In reply to Christophe LeroyQuoted 17 lines · Christophe Leroy
From: Herve Codina <[email protected]>
A framer is a component in charge of an E1/T1 line interface. Connected usually to a TDM bus, it converts TDM frames to/from E1/T1 frames. It also provides information related to the E1/T1 line.
The framer framework provides a set of APIs for the framer drivers (framer provider) to create/destroy a framer and APIs for the framer users (framer consumer) to obtain a reference to the framer, and use the framer.
This basic implementation provides a framer abstraction for:
- power on/off the framer
- get the framer status (line state)
- be notified on framer status changes
- get/set the framer configuration
Quoted 3 lines
Signed-off-by Herve Codina <[email protected]>Reviewed-by Christophe Leroy <[email protected]>Signed-off-by Christophe Leroy <[email protected]>
I had these review comments, you must have missed them?
https://lore.kernel.org/netdev/CACRpkdZQ9_f6+9CseV1L_wGphHujFPAYXMjJfjUrzSZRakOBzg@mail.gmail.com/
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH v4 21/28] net: wan: Add framer framework support
Hi Linus,
Le 20/08/2023 à 23:06, Linus Walleij a écrit :
Quoted 20 lines
Quoted 17 lines · Christophe Leroy
From: Herve Codina <[email protected]>
A framer is a component in charge of an E1/T1 line interface. Connected usually to a TDM bus, it converts TDM frames to/from E1/T1 frames. It also provides information related to the E1/T1 line.
The framer framework provides a set of APIs for the framer drivers (framer provider) to create/destroy a framer and APIs for the framer users (framer consumer) to obtain a reference to the framer, and use the framer.
This basic implementation provides a framer abstraction for:
- power on/off the framer
- get the framer status (line state)
- be notified on framer status changes
- get/set the framer configuration
Quoted 7 lines
Quoted 3 lines
Signed-off-by Herve Codina <[email protected]>Reviewed-by Christophe Leroy <[email protected]>Signed-off-by Christophe Leroy <[email protected]>I had these review comments, you must have missed them?
https://lore.kernel.org/netdev/CACRpkdZQ9_f6+9CseV1L_wGphHujFPAYXMjJfjUrzSZRakOBzg@mail.gmail.com/
As I said in the cover letter, this series only fixes critical build failures that happened when CONFIG_MODULES is set. The purpose was to allow robots to perform their job up to the end. Other feedback and comments will be taken into account by Hervé when he is back from holidays.
Thanks
Christophe
Re: [PATCH v4 21/28] net: wan: Add framer framework support
Quoted 25 lines · Christophe Leroy
Quoted 24 lines · Linus Walleij
Quoted 20 lines · Christophe Leroy
From: Herve Codina <[email protected]>
A framer is a component in charge of an E1/T1 line interface. Connected usually to a TDM bus, it converts TDM frames to/from E1/T1 frames. It also provides information related to the E1/T1 line.
The framer framework provides a set of APIs for the framer drivers (framer provider) to create/destroy a framer and APIs for the framer users (framer consumer) to obtain a reference to the framer, and use the framer.
This basic implementation provides a framer abstraction for:
- power on/off the framer
- get the framer status (line state)
- be notified on framer status changes
- get/set the framer configurationSigned-off-by Herve Codina <[email protected]>Reviewed-by Christophe Leroy <[email protected]>Signed-off-by Christophe Leroy <[email protected]>
Quoted 8 lines
Quoted 3 lines
I had these review comments, you must have missed them?
https://lore.kernel.org/netdev/CACRpkdZQ9_f6+9CseV1L_wGphHujFPAYXMjJfjUrzSZRakOBzg@mail.gmail.com/As I said in the cover letter, this series only fixes critical build failures that happened when
CONFIG_MODULESis set. The purpose was to allow robots to perform their job up to the end. Other feedback and comments will be taken into account by Hervé when he is back from holidays.
Ah I see. I completely missed this.
Yours,
Linus Walleij
Jakub Kicinski
maintainerRe: [PATCH v4 21/28] net: wan: Add framer framework support
In reply to Christophe LeroyQuoted 4 lines · On Mon, 21 Aug 2023 05:19:22 +0000 Christophe Leroy wrote:
As I said in the cover letter, this series only fixes critical build failures that happened when
CONFIG_MODULESis set. The purpose was to allow robots to perform their job up to the end. Other feedback and comments will be taken into account by Hervé when he is back from holidays.
I missed this too, FTR this is unacceptable.
Quoting documentation:
**Do not** post your patches just to run them through the checks. You must ensure that your patches are ready by testing them locally before posting to the mailing list. The patchwork build bot instance gets overloaded very easily and netdev@vger really doesn't need more traffic if we can help it.
See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#patchwork-checks
Re: [PATCH v4 21/28] net: wan: Add framer framework support
In reply to Christophe LeroyLe 18/08/2023 à 18:39, Christophe Leroy a écrit :
Quoted 17 lines
From: Herve Codina <[email protected]>
A framer is a component in charge of an E1/T1 line interface. Connected usually to a TDM bus, it converts TDM frames to/from E1/T1 frames. It also provides information related to the E1/T1 line.
The framer framework provides a set of APIs for the framer drivers (framer provider) to create/destroy a framer and APIs for the framer users (framer consumer) to obtain a reference to the framer, and use the framer.
This basic implementation provides a framer abstraction for:
- power on/off the framer
- get the framer status (line state)
- be notified on framer status changes
- get/set the framer configuration
Quoted 4 lines
Signed-off-by Herve Codina <[email protected]>Reviewed-by Christophe Leroy <[email protected]>Signed-off-by Christophe Leroy <[email protected]>---
Hi,
should there be a V5, some nits below.
...
drivers/net/wan/framer/framer-core.c line 226
Quoted 7 lines
drivers/net/wan/framer/framer-core.c new file +7
-0+int framer_power_off (struct framer *framer) +{ +int ret; + +mutex_lock (&framer->mutex); +if (framer->power_count ==1 && framer->ops->power_off) { + ret = framer->ops->power_off (framer);
~~
Useless extra space
Quoted 15 lines
drivers/net/wan/framer/framer-core.c new file +15
-0+if (ret <0 ) { +dev_err (&framer->dev,"framer poweroff failed --> %d\n" , ret); +mutex_unlock (&framer->mutex); +return ret; + } + } + --framer->power_count; +mutex_unlock (&framer->mutex); +framer_pm_runtime_put (framer); + +if (framer->pwr) +regulator_disable (framer->pwr); + +return 0 ; +}
...
Quoted 9 lines
drivers/net/wan/framer/framer-core.c new file +9
-0+struct framer *framer_create (struct device *dev,struct device_node *node, +const struct framer_ops *ops) +{ +int ret; +int id; +struct framer *framer; + +if (WARN_ON (!dev)) +return ERR_PTR (-EINVAL );
drivers/net/wan/framer/framer-core.c line 622
Quoted 10 lines
drivers/net/wan/framer/framer-core.c new file +10
-0+ +/* get_status() is mandatory if the provider ask for polling status */ +if (WARN_ON ((ops->flags &FRAMER_FLAG_POLL_STATUS ) && !ops->get_status)) +return ERR_PTR (-EINVAL ); + + framer =kzalloc (sizeof (*framer),GFP_KERNEL ); +if (!framer) +return ERR_PTR (-ENOMEM ); + + id =ida_simple_get (&framer_ida,0 ,0 ,GFP_KERNEL );
ida_alloc()?
(ida_simple_get() is deprecated)
Quoted 51 lines
drivers/net/wan/framer/framer-core.c new file +51
-0+if (id <0 ) { +dev_err (dev,"unable to get id\n" ); + ret = id; + goto free_framer; + } + +device_initialize (&framer->dev); +mutex_init (&framer->mutex); +INIT_WORK (&framer->notify_status_work, framer_notify_status_work); +INIT_DELAYED_WORK (&framer->polling_work, framer_polling_work); +BLOCKING_INIT_NOTIFIER_HEAD (&framer->notifier_list); + + framer->dev.class = framer_class; + framer->dev.parent = dev; + framer->dev.of_node = node ? node : dev->of_node; + framer->id = id; + framer->ops = ops; + + ret =dev_set_name (&framer->dev,"framer-%s.%d" ,dev_name (dev), id); +if (ret) + goto put_dev; + +/* framer-supply */ + framer->pwr =regulator_get_optional (&framer->dev,"framer" ); +if (IS_ERR (framer->pwr)) { + ret =PTR_ERR (framer->pwr); +if (ret == -EPROBE_DEFER ) + goto put_dev; + + framer->pwr =NULL ; + } + + ret =device_add (&framer->dev); +if (ret) + goto put_dev; + +if (pm_runtime_enabled (dev)) { +pm_runtime_enable (&framer->dev); +pm_runtime_no_callbacks (&framer->dev); + } + +return framer; + +put_dev: +put_device (&framer->dev);/* calls framer_release() which frees resources */ +return ERR_PTR (ret); + +free_framer: +kfree (framer); +return ERR_PTR (ret); +}
...
drivers/net/wan/framer/framer-core.c line 810
Quoted 7 lines
drivers/net/wan/framer/framer-core.c new file +7
-0+void framer_provider_of_unregister (struct framer_provider *framer_provider) +{ +mutex_lock (&framer_provider_mutex); +list_del (&framer_provider->list); +of_node_put (framer_provider->dev->of_node); +kfree (framer_provider); +mutex_unlock (&framer_provider_mutex);
If it make sense, of_node_put() and kfree() could maybe be out of the mutex, in order to match how things are done in __framer_provider_of_register().
Quoted 1 line
+}
...
drivers/net/wan/framer/framer-core.c line 870
Quoted 7 lines
drivers/net/wan/framer/framer-core.c new file +7
-0+static void framer_release (struct device *dev) +{ +struct framer *framer; + + framer =dev_to_framer (dev); +regulator_put (framer->pwr); +ida_simple_remove (&framer_ida, framer->id);
ida_free()?
(ida_simple_remove() is deprecated)
Quoted 2 lines
(quoted diff) +2
-0+ kfree(framer); +}
...
Herve Codina
maintainerRe: [PATCH v4 21/28] net: wan: Add framer framework support
Hi Christophe,
Quoted 38 lines · On Mon, 21 Aug 2023 08:02:10 +0200 Christophe JAILLET…
Le 18/08/2023 à 18:39, Christophe Leroy a écrit :
Quoted 17 lines
From: Herve Codina <[email protected]>
A framer is a component in charge of an E1/T1 line interface. Connected usually to a TDM bus, it converts TDM frames to/from E1/T1 frames. It also provides information related to the E1/T1 line.
The framer framework provides a set of APIs for the framer drivers (framer provider) to create/destroy a framer and APIs for the framer users (framer consumer) to obtain a reference to the framer, and use the framer.
This basic implementation provides a framer abstraction for:
- power on/off the framer
- get the framer status (line state)
- be notified on framer status changes
- get/set the framer configurationQuoted 4 lines
Signed-off-by Herve Codina <[email protected]>Reviewed-by Christophe Leroy <[email protected]>Signed-off-by Christophe Leroy <[email protected]>---
Hi,
should there be a V5, some nits below.
...
drivers/net/wan/framer/framer-core.c line 226
Quoted 7 lines
drivers/net/wan/framer/framer-core.c new file +7
-0+int framer_power_off (struct framer *framer) +{ +int ret; + +mutex_lock (&framer->mutex); +if (framer->power_count ==1 && framer->ops->power_off) { + ret = framer->ops->power_off (framer);~~
Quoted 1 line
Useless extra space
Will be remove in the next iteration.
Quoted 33 lines
Quoted 16 lines
drivers/net/wan/framer/framer-core.c new file +15
-0+if (ret <0 ) { +dev_err (&framer->dev,"framer poweroff failed --> %d\n" , ret); +mutex_unlock (&framer->mutex); +return ret; + } + } + --framer->power_count; +mutex_unlock (&framer->mutex); +framer_pm_runtime_put (framer); + +if (framer->pwr) +regulator_disable (framer->pwr); + +return 0 ; +}...
Quoted 14 lines
drivers/net/wan/framer/framer-core.c new file +14
-0+struct framer *framer_create (struct device *dev,struct device_node *node, +const struct framer_ops *ops) +{ +int ret; +int id; +struct framer *framer; + +if (WARN_ON (!dev)) +return ERR_PTR (-EINVAL ); + +/* get_status() is mandatory if the provider ask for polling status */ +if (WARN_ON ((ops->flags &FRAMER_FLAG_POLL_STATUS ) && !ops->get_status)) +return ERR_PTR (-EINVAL ); +
Quoted 8 lines
drivers/net/wan/framer/framer-core.c line 622
Quoted 5 lines
drivers/net/wan/framer/framer-core.c new file +5
-0+ framer =kzalloc (sizeof (*framer),GFP_KERNEL ); +if (!framer) +return ERR_PTR (-ENOMEM ); + + id =ida_simple_get (&framer_ida,0 ,0 ,GFP_KERNEL );
ida_alloc()?
(ida_simple_get()is deprecated)
Indeed, ida_alloc() and ida_free() will be used in the next iteration.
Quoted 55 lines
Quoted 52 lines
drivers/net/wan/framer/framer-core.c new file +51
-0+if (id <0 ) { +dev_err (dev,"unable to get id\n" ); + ret = id; + goto free_framer; + } + +device_initialize (&framer->dev); +mutex_init (&framer->mutex); +INIT_WORK (&framer->notify_status_work, framer_notify_status_work); +INIT_DELAYED_WORK (&framer->polling_work, framer_polling_work); +BLOCKING_INIT_NOTIFIER_HEAD (&framer->notifier_list); + + framer->dev.class = framer_class; + framer->dev.parent = dev; + framer->dev.of_node = node ? node : dev->of_node; + framer->id = id; + framer->ops = ops; + + ret =dev_set_name (&framer->dev,"framer-%s.%d" ,dev_name (dev), id); +if (ret) + goto put_dev; + +/* framer-supply */ + framer->pwr =regulator_get_optional (&framer->dev,"framer" ); +if (IS_ERR (framer->pwr)) { + ret =PTR_ERR (framer->pwr); +if (ret == -EPROBE_DEFER ) + goto put_dev; + + framer->pwr =NULL ; + } + + ret =device_add (&framer->dev); +if (ret) + goto put_dev; + +if (pm_runtime_enabled (dev)) { +pm_runtime_enable (&framer->dev); +pm_runtime_no_callbacks (&framer->dev); + } + +return framer; + +put_dev: +put_device (&framer->dev);/* calls framer_release() which frees resources */ +return ERR_PTR (ret); + +free_framer: +kfree (framer); +return ERR_PTR (ret); +}...
Quoted 11 lines
drivers/net/wan/framer/framer-core.c line 810
Quoted 7 lines
drivers/net/wan/framer/framer-core.c new file +7
-0+void framer_provider_of_unregister (struct framer_provider *framer_provider) +{ +mutex_lock (&framer_provider_mutex); +list_del (&framer_provider->list); +of_node_put (framer_provider->dev->of_node); +kfree (framer_provider); +mutex_unlock (&framer_provider_mutex);If it make sense,
of_node_put()andkfree()could maybe be out of the mutex, in order to match how things are done in__framer_provider_of_register().
Yes, it makes sense.
Both of_node_put() and kfree() will be moved out of the mutex.
Quoted 5 lines
Quoted 2 lines
+}
...
Quoted 10 lines
drivers/net/wan/framer/framer-core.c line 870
Quoted 7 lines
drivers/net/wan/framer/framer-core.c new file +7
-0+static void framer_release (struct device *dev) +{ +struct framer *framer; + + framer =dev_to_framer (dev); +regulator_put (framer->pwr); +ida_simple_remove (&framer_ida, framer->id);
ida_free()?
(ida_simple_remove()is deprecated)
Yes
Quoted 6 lines
Quoted 3 lines
(quoted diff) +2
-0+ kfree(framer); +}...
Thanks for the review,
Hervé
Signature · 3 lines
Hervé Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH v4 22/28 dt-bindings: net: Add the Lantiq PEF2256 E1/T1/J1 framer
In reply to Christophe LeroyFrom: Herve Codina <[email protected]>
The Lantiq PEF2256 is a framer and line interface component designed to fulfill all required interfacing between an analog E1/T1/J1 line and the digital PCM system highway/H.100 bus.
--- .../bindings/net/lantiq,pef2256.yaml | 219 ++++++++++++++++++ 1 file changed, 219 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/lantiq,pef2256.yaml
Documentation/devicetree/bindings/net/lantiq,pef2256.yaml new file +219 -0
@@ -0,0 +1,219 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/lantiq,pef2256.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Lantiq PEF2256 + +maintainers: + - Herve Codina <[email protected]> + +description: + The Lantiq PEF2256, also known as Infineon PEF2256 or FALC56, is a framer and + line interface component designed to fulfill all required interfacing between + an analog E1/T1/J1 line and the digital PCM system highway/H.100 bus. + +properties: + compatible: + items: + - const: lantiq,pef2256 + + reg: + maxItems: 1 + + clocks: + items: + - description: Master clock + - description: System Clock Receive + - description: System Clock Transmit + + clock-names: + items: + - const: mclk + - const: sclkr + - const: sclkx + + interrupts: + maxItems: 1 + + reset-gpios: + description: + GPIO used to reset the device. + maxItems: 1 + + '#framer-cells': + const: 0 + + pinctrl: + $ref: /schemas/pinctrl/pinctrl.yaml# + additionalProperties: false + + patternProperties: + '-pins$': + type: object + $ref: /schemas/pinctrl/pincfg-node.yaml# + additionalProperties: false + + properties: + pins: + enum: [ RPA, RPB, RPC, RPD, XPA, XPB, XPC, XPD ] + + function: + enum: [ SYPR, RFM, RFMB, RSIGM, RSIG, DLR, FREEZE, RFSP, LOS, + SYPX, XFMS, XSIG, TCLK, XMFB, XSIGM, DLX, XCLK, XLT, + GPI, GPOH, GPOL ] + + required: + - pins + - function + + lantiq,data-rate-bps: + $ref: /schemas/types.yaml#/definitions/uint32 + enum: [2048000, 4096000, 8192000, 16384000] + default: 2048000 + description: + Data rate (bit per seconds) on the system highway. + + lantiq,clock-falling-edge: + $ref: /schemas/types.yaml#/definitions/flag + description: + Data is sent on falling edge of the clock (and received on the rising + edge). If 'clock-falling-edge' is not present, data is sent on the + rising edge (and received on the falling edge). + + lantiq,channel-phase: + $ref: /schemas/types.yaml#/definitions/uint32 + enum: [0, 1, 2, 3, 4, 5, 6, 7] + default: 0 + description: + The pef2256 delivers a full frame (32 8bit time-slots in E1 and 24 8bit + time-slots 8 8bit signaling in E1/J1) every 125us. This lead to a data + rate of 2048000 bit/s. When lantiq,data-rate-bps is more than 2048000 + bit/s, the data (all 32 8bit) present in the frame are interleave with + unused time-slots. The lantiq,channel-phase property allows to set the + correct alignment of the interleave mechanism. + For instance, suppose lantiq,data-rate-bps = 8192000 (ie 4*2048000), and + lantiq,channel-phase = 2, the interleave schema with unused time-slots + (nu) and used time-slots (XX) for TSi is + nu nu XX nu nu nu XX nu nu nu XX nu + <-- TSi --> <- TSi+1 -> <- TSi+2 -> + With lantiq,data-rate-bps = 8192000, and lantiq,channel-phase = 1, the + interleave schema is + nu XX nu nu nu XX nu nu nu XX nu nu + <-- TSi --> <- TSi+1 -> <- TSi+2 -> + With lantiq,data-rate-bps = 4096000 (ie 2*2048000), and + lantiq,channel-phase = 1, the interleave schema is + nu XX nu XX nu XX + <-- TSi --> <- TSi+1 -> <- TSi+2 -> + +patternProperties: + '^codec(-([0-9]|[1-2][0-9]|3[0-1]))?$': + type: object + $ref: /schemas/sound/dai-common.yaml + unevaluatedProperties: false + description: + Codec provided by the pef2256. This codec allows to use some of the PCM + system highway time-slots as audio channels to transport audio data over + the E1/T1/J1 lines. + The time-slots used by the codec must be set and so, the properties + 'dai-tdm-slot-num', 'dai-tdm-slot-width', 'dai-tdm-slot-tx-mask' and + 'dai-tdm-slot-rx-mask' must be present in the sound card node for + sub-nodes that involve the codec. The codec uses 8bit time-slots. + 'dai-tdm-tdm-slot-with' must be set to 8. + The tx and rx masks define the pef2256 time-slots assigned to the codec. + + properties: + compatible: + const: lantiq,pef2256-codec + + '#sound-dai-cells': + const: 0 + + required: + - compatible + - '#sound-dai-cells' + +required: + - compatible + - reg + - clocks + - clock-names + - interrupts + - '#framer-cells' + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + #include <dt-bindings/interrupt-controller/irq.h> + + pef2256: framer@2000000 { + compatible = "lantiq,pef2256"; + reg = <0x2000000 0x100>; + interrupts = <8 IRQ_TYPE_LEVEL_LOW>; + interrupt-parent = <&intc>; + clocks = <&clk_mclk>, <&clk_sclkr>, <&clk_sclkx>; + clock-names = "mclk", "sclkr", "sclkx"; + reset-gpios = <&gpio 11 GPIO_ACTIVE_LOW>; + lantiq,data-rate-bps = <4096000>; + #framer-cells = <0>; + + pinctrl { + pef2256_rpa_sypr: rpa-pins { + pins = "RPA"; + function = "SYPR"; + }; + pef2256_xpa_sypx: xpa-pins { + pins = "XPA"; + function = "SYPX"; + }; + }; + + pef2256_codec0: codec-0 { + compatible = "lantiq,pef2256-codec"; + #sound-dai-cells = <0>; + sound-name-prefix = "PEF2256_0"; + }; + + pef2256_codec1: codec-1 { + compatible = "lantiq,pef2256-codec"; + #sound-dai-cells = <0>; + sound-name-prefix = "PEF2256_1"; + }; + }; + + sound { + compatible = "simple-audio-card"; + #address-cells = <1>; + #size-cells = <0>; + simple-audio-card,dai-link@0 { /* CPU DAI1 - pef2256 codec 1 */ + reg = <0>; + cpu { + sound-dai = <&cpu_dai1>; + }; + codec { + sound-dai = <&pef2256_codec0>; + dai-tdm-slot-num = <4>; + dai-tdm-slot-width = <8>; + /* TS 1, 2, 3, 4 */ + dai-tdm-slot-tx-mask = <0 1 1 1 1>; + dai-tdm-slot-rx-mask = <0 1 1 1 1>; + }; + }; + simple-audio-card,dai-link@1 { /* CPU DAI2 - pef2256 codec 2 */ + reg = <1>; + cpu { + sound-dai = <&cpu_dai2>; + }; + codec { + sound-dai = <&pef2256_codec1>; + dai-tdm-slot-num = <4>; + dai-tdm-slot-width = <8>; + /* TS 5, 6, 7, 8 */ + dai-tdm-slot-tx-mask = <0 0 0 0 0 1 1 1 1>; + dai-tdm-slot-rx-mask = <0 0 0 0 0 1 1 1 1>; + }; + }; + };
Signature · 1 line
2.41.0
Rob Herring
maintainerRe: [PATCH v4 22/28] dt-bindings: net: Add the Lantiq PEF2256 E1/T1/J1 framer
Quoted 54 lines · Christophe Leroy
From: Herve Codina <[email protected]>
The Lantiq PEF2256 is a framer and line interface component designed to fulfill all required interfacing between an analog E1/T1/J1 line and the digital PCM system highway/H.100 bus.
Signed-off-by Herve Codina <[email protected]>Signed-off-by Christophe Leroy <[email protected]>--- .../bindings/net/lantiq,pef2256.yaml | 219 ++++++++++++++++++ 1 file changed, 219 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/lantiq,pef2256.yamlDocumentation/devicetree/bindings/net/lantiq,pef2256.yaml new file +35
-0@@ -0,0 +1,219 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/lantiq,pef2256.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Lantiq PEF2256 + +maintainers: + - Herve Codina <[email protected]> + +description: + The Lantiq PEF2256, also known as Infineon PEF2256 or FALC56, is a framer and + line interface component designed to fulfill all required interfacing between + an analog E1/T1/J1 line and the digital PCM system highway/H.100 bus. + +properties: + compatible: + items: + - const: lantiq,pef2256 + + reg: + maxItems: 1 + + clocks: + items: + - description: Master clock + - description: System Clock Receive + - description: System Clock Transmit + + clock-names: + items: + - const: mclk + - const: sclkr + - const: sclkx
Documentation/devicetree/bindings/net/lantiq,pef2256.yaml line 45
Quoted 10 lines
Documentation/devicetree/bindings/net/lantiq,pef2256.yaml new file +10
-0+ + interrupts: + maxItems: 1 + + reset-gpios: + description: + GPIO used to reset the device. + maxItems: 1 + + '#framer-cells':
Not a standard binding. Do you need provider specific variable number of cells?
Quoted 34 lines
Documentation/devicetree/bindings/net/lantiq,pef2256.yaml new file +34
-0+ const: 0 + + pinctrl: + $ref: /schemas/pinctrl/pinctrl.yaml# + additionalProperties: false + + patternProperties: + '-pins$': + type: object + $ref: /schemas/pinctrl/pincfg-node.yaml# + additionalProperties: false + + properties: + pins: + enum: [ RPA, RPB, RPC, RPD, XPA, XPB, XPC, XPD ] + + function: + enum: [ SYPR, RFM, RFMB, RSIGM, RSIG, DLR, FREEZE, RFSP, LOS, + SYPX, XFMS, XSIG, TCLK, XMFB, XSIGM, DLX, XCLK, XLT, + GPI, GPOH, GPOL ] + + required: + - pins + - function + + lantiq,data-rate-bps: + $ref: /schemas/types.yaml#/definitions/uint32 + enum: [2048000, 4096000, 8192000, 16384000] + default: 2048000 + description: + Data rate (bit per seconds) on the system highway. + + lantiq,clock-falling-edge: + $ref: /schemas/types.yaml#/definitions/flag
Documentation/devicetree/bindings/net/lantiq,pef2256.yaml line 89
Quoted 10 lines
Documentation/devicetree/bindings/net/lantiq,pef2256.yaml new file +10
-0+ description: + Data is sent on falling edge of the clock (and received on the rising + edge). If 'clock-falling-edge' is not present, data is sent on the + rising edge (and received on the falling edge). + + lantiq,channel-phase: + $ref: /schemas/types.yaml#/definitions/uint32 + enum: [0, 1, 2, 3, 4, 5, 6, 7] + default: 0 + description:
Need '|' to preserve formatting
Quoted 133 lines
Documentation/devicetree/bindings/net/lantiq,pef2256.yaml new file +130
-0+ The pef2256 delivers a full frame (32 8bit time-slots in E1 and 24 8bit + time-slots 8 8bit signaling in E1/J1) every 125us. This lead to a data + rate of 2048000 bit/s. When lantiq,data-rate-bps is more than 2048000 + bit/s, the data (all 32 8bit) present in the frame are interleave with + unused time-slots. The lantiq,channel-phase property allows to set the + correct alignment of the interleave mechanism. + For instance, suppose lantiq,data-rate-bps = 8192000 (ie 4*2048000), and + lantiq,channel-phase = 2, the interleave schema with unused time-slots + (nu) and used time-slots (XX) for TSi is + nu nu XX nu nu nu XX nu nu nu XX nu + <-- TSi --> <- TSi+1 -> <- TSi+2 -> + With lantiq,data-rate-bps = 8192000, and lantiq,channel-phase = 1, the + interleave schema is + nu XX nu nu nu XX nu nu nu XX nu nu + <-- TSi --> <- TSi+1 -> <- TSi+2 -> + With lantiq,data-rate-bps = 4096000 (ie 2*2048000), and + lantiq,channel-phase = 1, the interleave schema is + nu XX nu XX nu XX + <-- TSi --> <- TSi+1 -> <- TSi+2 -> + +patternProperties: + '^codec(-([0-9]|[1-2][0-9]|3[0-1]))?$': + type: object + $ref: /schemas/sound/dai-common.yaml + unevaluatedProperties: false + description: + Codec provided by the pef2256. This codec allows to use some of the PCM + system highway time-slots as audio channels to transport audio data over + the E1/T1/J1 lines. + The time-slots used by the codec must be set and so, the properties + 'dai-tdm-slot-num', 'dai-tdm-slot-width', 'dai-tdm-slot-tx-mask' and + 'dai-tdm-slot-rx-mask' must be present in the sound card node for + sub-nodes that involve the codec. The codec uses 8bit time-slots. + 'dai-tdm-tdm-slot-with' must be set to 8. + The tx and rx masks define the pef2256 time-slots assigned to the codec. + + properties: + compatible: + const: lantiq,pef2256-codec + + '#sound-dai-cells': + const: 0 + + required: + - compatible + - '#sound-dai-cells' + +required: + - compatible + - reg + - clocks + - clock-names + - interrupts + - '#framer-cells' + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + #include <dt-bindings/interrupt-controller/irq.h> + + pef2256: framer@2000000 { + compatible = "lantiq,pef2256"; + reg = <0x2000000 0x100>; + interrupts = <8 IRQ_TYPE_LEVEL_LOW>; + interrupt-parent = <&intc>; + clocks = <&clk_mclk>, <&clk_sclkr>, <&clk_sclkx>; + clock-names = "mclk", "sclkr", "sclkx"; + reset-gpios = <&gpio 11 GPIO_ACTIVE_LOW>; + lantiq,data-rate-bps = <4096000>; + #framer-cells = <0>; + + pinctrl { + pef2256_rpa_sypr: rpa-pins { + pins = "RPA"; + function = "SYPR"; + }; + pef2256_xpa_sypx: xpa-pins { + pins = "XPA"; + function = "SYPX"; + }; + }; + + pef2256_codec0: codec-0 { + compatible = "lantiq,pef2256-codec"; + #sound-dai-cells = <0>; + sound-name-prefix = "PEF2256_0"; + }; + + pef2256_codec1: codec-1 { + compatible = "lantiq,pef2256-codec"; + #sound-dai-cells = <0>; + sound-name-prefix = "PEF2256_1"; + }; + }; + + sound { + compatible = "simple-audio-card"; + #address-cells = <1>; + #size-cells = <0>; + simple-audio-card,dai-link@0 { /* CPU DAI1 - pef2256 codec 1 */ + reg = <0>; + cpu { + sound-dai = <&cpu_dai1>; + }; + codec { + sound-dai = <&pef2256_codec0>; + dai-tdm-slot-num = <4>; + dai-tdm-slot-width = <8>; + /* TS 1, 2, 3, 4 */ + dai-tdm-slot-tx-mask = <0 1 1 1 1>; + dai-tdm-slot-rx-mask = <0 1 1 1 1>; + }; + }; + simple-audio-card,dai-link@1 { /* CPU DAI2 - pef2256 codec 2 */ + reg = <1>; + cpu { + sound-dai = <&cpu_dai2>; + }; + codec { + sound-dai = <&pef2256_codec1>; + dai-tdm-slot-num = <4>; + dai-tdm-slot-width = <8>; + /* TS 5, 6, 7, 8 */ + dai-tdm-slot-tx-mask = <0 0 0 0 0 1 1 1 1>; + dai-tdm-slot-rx-mask = <0 0 0 0 0 1 1 1 1>; + }; + }; + };Signature · 1 line
2.41.0
Herve Codina
maintainerRe: [PATCH v4 22/28] dt-bindings: net: Add the Lantiq PEF2256 E1/T1/J1 framer
Hi Rob,
Quoted 13 lines · On Mon, 21 Aug 2023 15:49:29 -0500 Rob Herring <[email protected]> wrote:
Quoted 12 lines · Christophe Leroy
From: Herve Codina <[email protected]>
The Lantiq PEF2256 is a framer and line interface component designed to fulfill all required interfacing between an analog E1/T1/J1 line and the digital PCM system highway/H.100 bus.
Signed-off-by Herve Codina <[email protected]>Signed-off-by Christophe Leroy <[email protected]>--- .../bindings/net/lantiq,pef2256.yaml | 219 ++++++++++++++++++ 1 file changed, 219 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/lantiq,pef2256.yaml
...
Quoted 4 lines
Quoted 1 line
+ '#framer-cells':
Not a standard binding. Do you need provider specific variable number of cells?
For the PEF2256, I don't need it.
It will be removed in the next iteration.
Quoted 3 lines
Quoted 3 lines
(quoted diff) +2
-0+ const: 0 +
...
Quoted 7 lines
Documentation/devicetree/bindings/net/lantiq,pef2256.yaml line 89
Quoted 5 lines
Documentation/devicetree/bindings/net/lantiq,pef2256.yaml new file +5
-0+ lantiq,channel-phase: + $ref: /schemas/types.yaml#/definitions/uint32 + enum: [0, 1, 2, 3, 4, 5, 6, 7] + default: 0 + description:Need '|' to preserve formatting
Will be fixed in the next iteration.
Best regards,
Hervé
PATCH v4 23/28 mfd: core: Ensure disabled devices are skiped without aborting
In reply to Christophe LeroyFrom: Herve Codina <[email protected]>
The loop searching for a matching device based on its compatible string is aborted when a matching disabled device is found. This abort prevents to add devices as soon as one disabled device is found.
Continue searching for an other device instead of aborting on the first disabled one fixes the issue.
--- drivers/mfd/mfd-core.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-)
drivers/mfd/mfd-core.c +12 -5
@@ -146,6 +146,7 @@ static int mfd_add_device(struct device *parent, int id,struct platform_device *pdev;struct device_node *np =NULL ;struct mfd_of_node_entry *of_entry, *tmp; +bool disabled = false;int ret = -ENOMEM ;int platform_id;int r;
@@ -183,11 +184,10 @@ static int mfd_add_device(struct device *parent, int id,if (IS_ENABLED (CONFIG_OF ) && parent->of_node && cell->of_compatible) {for_each_child_of_node (parent->of_node, np) {if (of_device_is_compatible (np, cell->of_compatible)) { -/* Ignore 'disabled' devices error free */ +/* Skip 'disabled' devices */ if (!of_device_is_available (np)) { -of_node_put (np); - ret =0 ; - goto fail_alias; + disabled = true; +continue ; } ret =mfd_match_of_node_to_dev (pdev, np, cell);
@@ -197,10 +197,17 @@ static int mfd_add_device(struct device *parent, int id,if (ret) goto fail_alias; -break ; + goto match; } } +if (disabled) { +/* Ignore 'disabled' devices error free */ + ret =0 ; + goto fail_alias; + } + +match:if (!pdev->dev.of_node)pr_warn ("%s: Failed to locate of_node [id: %d]\n" , cell->name, platform_id);
Signature · 1 line
2.41.0
Lee Jones
maintainerRe: [PATCH v4 23/28] mfd: core: Ensure disabled devices are skiped without aborting
Quoted 10 lines · Christophe Leroy
From: Herve Codina <[email protected]>
The loop searching for a matching device based on its compatible string is aborted when a matching disabled device is found. This abort prevents to add devices as soon as one disabled device is found.
Continue searching for an other device instead of aborting on the first disabled one fixes the issue.
Quoted 7 lines
Fixes 22380b65dc70 ("mfd: mfd-core: Ensure disabled devices are ignored without error")Signed-off-by Herve Codina <[email protected]>Reviewed-by Christophe Leroy <[email protected]>Signed-off-by Christophe Leroy <[email protected]>--- drivers/mfd/mfd-core.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-)
This is too big of a change to be added this late in the cycle.
Pushing review until after v6.5 is out.
Signature · 1 line
Lee Jones [李琼斯]
Re: (subset) [PATCH v4 23/28] mfd: core: Ensure disabled devices are skiped without aborting
In reply to Christophe LeroyQuoted 9 lines · Christophe Leroy
The loop searching for a matching device based on its compatible string is aborted when a matching disabled device is found. This abort prevents to add devices as soon as one disabled device is found.
Continue searching for an other device instead of aborting on the first disabled one fixes the issue.
[...]
Applied, thanks!
[23/28] mfd: core: Ensure disabled devices are skiped without aborting
commit: 36d139dc63db18eb95165fcc2bd3c670c948d605
--
Lee Jones [李琼斯]
PATCH v4 24/28 net: wan: framer: Add support for the Lantiq PEF2256 framer
In reply to Christophe LeroyFrom: Herve Codina <[email protected]>
The Lantiq PEF2256 is a framer and line interface component designed to fulfill all required interfacing between an analog E1/T1/J1 line and the digital PCM system highway/H.100 bus.
--- drivers/net/wan/framer/Kconfig | 16 + drivers/net/wan/framer/Makefile | 1 + drivers/net/wan/framer/pef2256/Makefile | 8 + drivers/net/wan/framer/pef2256/pef2256-regs.h | 250 +++++ drivers/net/wan/framer/pef2256/pef2256.c | 880 ++++++++++++++++++ include/linux/framer/pef2256.h | 31 + 6 files changed, 1186 insertions(+) create mode 100644 drivers/net/wan/framer/pef2256/Makefile create mode 100644 drivers/net/wan/framer/pef2256/pef2256-regs.h create mode 100644 drivers/net/wan/framer/pef2256/pef2256.c create mode 100644 include/linux/framer/pef2256.h
drivers/net/wan/framer/Kconfig +16 -0
@@ -16,4 +16,20 @@ config GENERIC_FRAMER framework and framer users can obtain reference to the framer. All the users of this framework should select this config. +config FRAMER_PEF2256 + tristate "Lantiq PEF2256" + depends on OF + select GENERIC_FRAMER + select MFD_CORE + select REGMAP_MMIO + help + Enable support for the Lantiq PEF2256 (FALC56) framer. + The PEF2256 is a framer and line interface between analog E1/T1/J1 + line and a digital PCM bus. + + If unsure, say N. + + To compile this driver as a module, choose M here: the + module will be called framer-pef2256. + endmenu
drivers/net/wan/framer/Makefile +1 -0
@@ -4,3 +4,4 @@ # obj-$(CONFIG_GENERIC_FRAMER) += framer-core.o +obj-$(CONFIG_FRAMER_PEF2256) += pef2256/
drivers/net/wan/framer/pef2256/Makefile new file +8 -0
@@ -0,0 +1,8 @@ +# SPDX-License-Identifier: GPL-2.0 +# +# Makefile for the pef2256 driver. +# + +obj-$(CONFIG_FRAMER_PEF2256) += framer-pef2256.o + +framer-pef2256-objs := pef2256.o
drivers/net/wan/framer/pef2256/pef2256-regs.h new file +250 -0
250 lines not on this page · raw message
drivers/net/wan/framer/pef2256/pef2256.c new file +880 -0
880 lines not on this page · raw message
include/linux/framer/pef2256.h new file +31 -0
@@ -0,0 +1,31 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +/* +* PEF2256 consumer API +* +* Copyright 2023 CS GROUP France +* +* Author: Herve Codina <[email protected]> +*/ +#ifndef __PEF2256_H__ +#define __PEF2256_H__ + +#include <linux/types.h> + +struct pef2256 ; +struct regmap ; + +/* Retrieve the PEF2256 regmap */ +struct regmap *pef2256_get_regmap (struct pef2256 *pef2256); + +/* PEF2256 hardware versions */ +enum pef2256_version { +PEF2256_VERSION_UNKNOWN , +PEF2256_VERSION_1_2 , +PEF2256_VERSION_2_1 , +PEF2256_VERSION_2_2 , +}; + +/* Get the PEF2256 hardware version */ +enum pef2256_version pef2256_get_version (struct pef2256 *pef2256); + +#endif /* __PEF2256_H__ */
Signature · 9 lines
2.41.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH v4 25/28 pinctrl: Add support for the Lantic PEF2256 pinmux
In reply to Christophe LeroyFrom: Herve Codina <[email protected]>
The Lantiq PEF2256 is a framer and line interface component designed to fulfill all required interfacing between an analog E1/T1/J1 line and the digital PCM system highway/H.100 bus.
This kind of component can be found in old telecommunication system. It was used to digital transmission of many simultaneous telephone calls by time-division multiplexing. Also using HDLC protocol, WAN networks can be reached through the framer.
This pinmux support handles the pin muxing part (pins RP(A..D) and pins XP(A..D)) of the PEF2256.
--- drivers/pinctrl/Kconfig | 14 ++ drivers/pinctrl/Makefile | 1 + drivers/pinctrl/pinctrl-pef2256-regs.h | 65 ++++++ drivers/pinctrl/pinctrl-pef2256.c | 308 +++++++++++++++++++++++++ 4 files changed, 388 insertions(+) create mode 100644 drivers/pinctrl/pinctrl-pef2256-regs.h create mode 100644 drivers/pinctrl/pinctrl-pef2256.c
drivers/pinctrl/Kconfig +14 -0
@@ -377,6 +377,20 @@ config PINCTRL_PALMAS open drain configuration for the Palmas series devices like TPS65913, TPS80036 etc. +config PINCTRL_PEF2256 + tristate "Lantiq PEF2256 (FALC56) pin controller driver" + depends on OF && FRAMER_PEF2256 + select PINMUX + select GENERIC_PINCONF + help + This option enables the pin controller support for the Lantiq PEF2256 + framer, also known as FALC56. + + If unsure, say N. + + To compile this driver as a module, choose M here: the + module will be called pinctrl-pef2256. + config PINCTRL_PIC32 bool "Microchip PIC32 pin controller driver" depends on OF
drivers/pinctrl/Makefile +1 -0
@@ -40,6 +40,7 @@ obj-$(CONFIG_PINCTRL_MLXBF3) += pinctrl-mlxbf3.o obj-$(CONFIG_PINCTRL_OCELOT) += pinctrl-ocelot.o obj-$(CONFIG_PINCTRL_OXNAS) += pinctrl-oxnas.o obj-$(CONFIG_PINCTRL_PALMAS) += pinctrl-palmas.o +obj-$(CONFIG_PINCTRL_PEF2256) += pinctrl-pef2256.o obj-$(CONFIG_PINCTRL_PIC32) += pinctrl-pic32.o obj-$(CONFIG_PINCTRL_PISTACHIO) += pinctrl-pistachio.o obj-$(CONFIG_PINCTRL_RK805) += pinctrl-rk805.o
drivers/pinctrl/pinctrl-pef2256-regs.h new file +65 -0
65 lines not on this page · raw message
drivers/pinctrl/pinctrl-pef2256.c new file +308 -0
308 lines not on this page · raw message
Signature · 1 line
2.41.0
PATCH v4 26/28 MAINTAINERS: Add the Lantiq PEF2256 driver entry
In reply to Christophe LeroyFrom: Herve Codina <[email protected]>
After contributing the driver, add myself as the maintainer for the Lantiq PEF2256 driver.
--- MAINTAINERS | 9 +++++++++ 1 file changed, 9 insertions(+)
MAINTAINERS +9 -0
@@ -11777,6 +11777,15 @@ S: Maintained F: arch/mips/lantiq F: drivers/soc/lantiq +LANTIQ PEF2256 DRIVER +M: Herve Codina <[email protected]> +S: Maintained +F: Documentation/devicetree/bindings/net/lantiq,pef2256.yaml +F: drivers/net/wan/framer/pef2256/ +F: drivers/pinctrl/pinctrl-pef2256-regs.h +F: drivers/pinctrl/pinctrl-pef2256.c +F: include/linux/framer/pef2256.h + LASI 53c700 driver for PARISC M: "James E.J. Bottomley" <[email protected]> L: [email protected]
Signature · 1 line
2.41.0
PATCH v4 27/28 ASoC: codecs: Add support for the framer codec
In reply to Christophe LeroyFrom: Herve Codina <[email protected]>
The framer codec interracts with a framer.
It allows to use some of the framer timeslots as audio channels to transport audio data over the framer E1/T1/J1 lines.
It also reports line carrier detection events through the ALSA jack detection feature.
--- sound/soc/codecs/Kconfig | 15 ++ sound/soc/codecs/Makefile | 2 + sound/soc/codecs/framer-codec.c | 413 ++++++++++++++++++++++++++++++++ 3 files changed, 430 insertions(+) create mode 100644 sound/soc/codecs/framer-codec.c
sound/soc/codecs/Kconfig +15 -0
@@ -109,6 +109,7 @@ config SND_SOC_ALL_CODECS imply SND_SOC_ES8328_I2C imply SND_SOC_ES7134 imply SND_SOC_ES7241 + imply SND_SOC_FRAMER imply SND_SOC_GTM601 imply SND_SOC_HDAC_HDMI imply SND_SOC_HDAC_HDA
@@ -1032,6 +1033,20 @@ config SND_SOC_ES8328_SPI depends on SPI_MASTER select SND_SOC_ES8328 +config SND_SOC_FRAMER + tristate "Framer codec" + depends on GENERIC_FRAMER + help + Enable support for the framer codec. + The framer codec uses the generic framer infrastructure to transport + some audio data over an analog E1/T1/J1 line. + This codec allows to use some of the time slots available on the TDM + bus on which the framer is connected to transport the audio data. + + To compile this driver as a module, choose M here: the module + will be called snd-soc-framer. + + config SND_SOC_GTM601 tristate 'GTM601 UMTS modem audio codec'
sound/soc/codecs/Makefile +2 -0
@@ -115,6 +115,7 @@ snd-soc-es8326-objs := es8326.o snd-soc-es8328-objs := es8328.o snd-soc-es8328-i2c-objs := es8328-i2c.o snd-soc-es8328-spi-objs := es8328-spi.o +snd-soc-framer-objs := framer-codec.o snd-soc-gtm601-objs := gtm601.o snd-soc-hdac-hdmi-objs := hdac_hdmi.o snd-soc-hdac-hda-objs := hdac_hda.o
@@ -497,6 +498,7 @@ obj-$(CONFIG_SND_SOC_ES8326) += snd-soc-es8326.o obj-$(CONFIG_SND_SOC_ES8328) += snd-soc-es8328.o obj-$(CONFIG_SND_SOC_ES8328_I2C)+= snd-soc-es8328-i2c.o obj-$(CONFIG_SND_SOC_ES8328_SPI)+= snd-soc-es8328-spi.o +obj-$(CONFIG_SND_SOC_FRAMER) += snd-soc-framer.o obj-$(CONFIG_SND_SOC_GTM601) += snd-soc-gtm601.o obj-$(CONFIG_SND_SOC_HDAC_HDMI) += snd-soc-hdac-hdmi.o obj-$(CONFIG_SND_SOC_HDAC_HDA) += snd-soc-hdac-hda.o
sound/soc/codecs/framer-codec.c new file +413 -0
413 lines not on this page · raw message
Signature · 7 lines
2.41.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Re: [PATCH v4 27/28] ASoC: codecs: Add support for the framer codec
Hi,
sound/soc/codecs/Kconfig config SND_SOC_ES8328_SPI · line 1045
Quoted 10 lines · Christophe Leroy
sound/soc/codecs/Kconfig +10
-0+config SND_SOC_FRAMER + tristate "Framer codec" + depends on GENERIC_FRAMER + help + Enable support for the framer codec. + The framer codec uses the generic framer infrastructure to transport + some audio data over an analog E1/T1/J1 line. + This codec allows to use some of the time slots available on the TDM + bus on which the framer is connected to transport the audio data. +
Just curious: what controls the slot allocations/usages? Is that done in userspace?
sound/soc/codecs/Kconfig config SND_SOC_ES8328_SPI · line 1047
Quoted 2 lines
sound/soc/codecs/Kconfig +2
-0+ To compile this driver as a module, choose M here: the module + will be called snd-soc-framer.
thanks.
Signature · 1 line
~Randy
Re: [PATCH v4 27/28] ASoC: codecs: Add support for the framer codec
Le 19/08/2023 à 01:18, Randy Dunlap a écrit :
Quoted 16 lines
Hi,
sound/soc/codecs/Kconfig config SND_SOC_ES8328_SPI · line 1045
Quoted 10 lines · Christophe Leroy
sound/soc/codecs/Kconfig +10
-0+config SND_SOC_FRAMER + tristate "Framer codec" + depends on GENERIC_FRAMER + help + Enable support for the framer codec. + The framer codec uses the generic framer infrastructure to transport + some audio data over an analog E1/T1/J1 line. + This codec allows to use some of the time slots available on the TDM + bus on which the framer is connected to transport the audio data. +Just curious: what controls the slot allocations/usages? Is that done in userspace?
For audio, this is done in userspace through alsalib.
For IP over E1, a mask is provided with the userspace tool 'sethdlc'
For the time being there is no sharing, either the E1 line is used for audio either the E1 line is used for IP over E1 (HDLC)
Christophe
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH v4 28/28 net: wan: fsl_qmc_hdlc: Add framer support
In reply to Christophe LeroyFrom: Herve Codina <[email protected]>
Add framer support in the fsl_qmc_hdlc driver in order to be able to signal carrier changes to the network stack based on the framer status Also use this framer to provide information related to the E1/T1 line interface on IF_GET_IFACE and configure the line interface according to IF_IFACE_{E1,T1} information.
--- drivers/net/wan/fsl_qmc_hdlc.c | 239 ++++++++++++++++++++++++++++++++- 1 file changed, 235 insertions(+), 4 deletions(-)
drivers/net/wan/fsl_qmc_hdlc.c +235 -4
@@ -8,6 +8,7 @@*/ #include <linux/dma-mapping.h> +#include <linux/framer/framer.h> #include <linux/hdlc.h> #include <linux/module.h> #include <linux/of.h>
@@ -27,6 +28,9 @@ struct qmc_hdlc {struct device *dev;struct qmc_chan *qmc_chan;struct net_device *netdev; +struct framer *framer; +spinlock_t carrier_lock;/* Protect carrier detection */ +struct notifier_block nb;bool is_crc32;spinlock_t tx_lock;/* Protect tx descriptors */ struct qmc_hdlc_desc tx_descs[8 ];
@@ -40,6 +44,195 @@ static inline struct qmc_hdlc *netdev_to_qmc_hdlc(struct net_device *netdev)return dev_to_hdlc (netdev)->priv; } +static int qmc_hdlc_framer_set_carrier (struct qmc_hdlc *qmc_hdlc) +{ +struct framer_status framer_status; +unsigned long flags; +int ret; + +if (!qmc_hdlc->framer) +return 0 ; + +spin_lock_irqsave (&qmc_hdlc->carrier_lock, flags); + + ret =framer_get_status (qmc_hdlc->framer, &framer_status); +if (ret) { +dev_err (qmc_hdlc->dev,"get framer status failed (%d)\n" , ret); + goto end; + } +if (framer_status.link_is_on) +netif_carrier_on (qmc_hdlc->netdev); +else +netif_carrier_off (qmc_hdlc->netdev); + +end: +spin_unlock_irqrestore (&qmc_hdlc->carrier_lock, flags); +return ret; +} + +static int qmc_hdlc_framer_notifier (struct notifier_block *nb,unsigned long action, +void *data) +{ + struct qmc_hdlc *qmc_hdlc = container_of(nb, struct qmc_hdlc, nb); +int ret; + +if (action !=FRAMER_EVENT_STATUS ) +return NOTIFY_DONE ; + + ret =qmc_hdlc_framer_set_carrier (qmc_hdlc); +return ret ?NOTIFY_DONE :NOTIFY_OK ; +} + +static int qmc_hdlc_framer_start (struct qmc_hdlc *qmc_hdlc) +{ +struct framer_status framer_status; +int ret; + +if (!qmc_hdlc->framer) +return 0 ; + + ret =framer_power_on (qmc_hdlc->framer); +if (ret) { +dev_err (qmc_hdlc->dev,"framer power-on failed (%d)\n" , ret); +return ret; + } + +/* Be sure that get_status is supported */ + ret =framer_get_status (qmc_hdlc->framer, &framer_status); +if (ret) { +dev_err (qmc_hdlc->dev,"get framer status failed (%d)\n" , ret); + goto framer_power_off; + } + + qmc_hdlc->nb.notifier_call = qmc_hdlc_framer_notifier; + ret =framer_notifier_register (qmc_hdlc->framer, &qmc_hdlc->nb); +if (ret) { +dev_err (qmc_hdlc->dev,"framer notifier register failed (%d)\n" , ret); + goto framer_power_off; + } + +return 0 ; + +framer_power_off: +framer_power_off (qmc_hdlc->framer); +return ret; +} + +static void qmc_hdlc_framer_stop (struct qmc_hdlc *qmc_hdlc) +{ +if (!qmc_hdlc->framer) +return ; + +framer_notifier_unregister (qmc_hdlc->framer, &qmc_hdlc->nb); +framer_power_off (qmc_hdlc->framer); +} + +static int qmc_hdlc_framer_set_iface (struct qmc_hdlc *qmc_hdlc,int if_iface, +const te1_settings *te1) +{ +struct framer_config config; +int ret; + +if (!qmc_hdlc->framer) +return 0 ; + + ret =framer_get_config (qmc_hdlc->framer, &config); +if (ret) +return ret; + +switch (if_iface) { +case IF_IFACE_E1 : + config.iface =FRAMER_IFACE_E1 ; +break ; +case IF_IFACE_T1 : + config.iface =FRAMER_IFACE_T1 ; +break ; +default : +return -EINVAL ; + } + +switch (te1->clock_type) { +case CLOCK_DEFAULT : +/* Keep current value */ +break ; +case CLOCK_EXT : + config.clock_type =FRAMER_CLOCK_EXT ; +break ; +case CLOCK_INT : + config.clock_type =FRAMER_CLOCK_INT ; +break ; +default : +return -EINVAL ; + } + config.line_clock_rate = te1->clock_rate; + +return framer_set_config (qmc_hdlc->framer, &config); +} + +static int qmc_hdlc_framer_get_iface (struct qmc_hdlc *qmc_hdlc,int *if_iface,te1_settings *te1) +{ +struct framer_config config; +int ret; + +if (!qmc_hdlc->framer) { + *if_iface =IF_IFACE_E1 ; +return 0 ; + } + + ret =framer_get_config (qmc_hdlc->framer, &config); +if (ret) +return ret; + +switch (config.iface) { +case FRAMER_IFACE_E1 : + *if_iface =IF_IFACE_E1 ; +break ; +case FRAMER_IFACE_T1 : + *if_iface =IF_IFACE_T1 ; +break ; + } + +if (!te1) +return 0 ;/* Only iface type requested */ + +switch (config.clock_type) { +case FRAMER_CLOCK_EXT : + te1->clock_type =CLOCK_EXT ; +break ; +case FRAMER_CLOCK_INT : + te1->clock_type =CLOCK_INT ; +break ; +default : +return -EINVAL ; + } + te1->clock_rate = config.line_clock_rate; +return 0 ; +} + +static int qmc_hdlc_framer_init (struct qmc_hdlc *qmc_hdlc) +{ +int ret; + +if (!qmc_hdlc->framer) +return 0 ; + + ret =framer_init (qmc_hdlc->framer); +if (ret) { +dev_err (qmc_hdlc->dev,"framer init failed (%d)\n" , ret); +return ret; + } + +return 0 ; +} + +static void qmc_hdlc_framer_exit (struct qmc_hdlc *qmc_hdlc) +{ +if (!qmc_hdlc->framer) +return ; + +framer_exit (qmc_hdlc->framer); +} +static int qmc_hdlc_recv_queue (struct qmc_hdlc *qmc_hdlc,struct qmc_hdlc_desc *desc,size_t size);#define QMC_HDLC_RX_ERROR_FLAGS (QMC_RX_FLAG_HDLC_OVF | \
@@ -313,6 +506,12 @@ static int qmc_hdlc_set_iface(struct qmc_hdlc *qmc_hdlc, int if_iface, const te1 qmc_hdlc->slot_map = te1->slot_map; + ret =qmc_hdlc_framer_set_iface (qmc_hdlc, if_iface, te1); +if (ret) { +dev_err (qmc_hdlc->dev,"framer set iface failed %d\n" , ret); +return ret; + } +return 0 ; }
@@ -320,11 +519,16 @@ static int qmc_hdlc_ioctl(struct net_device *netdev, struct if_settings *ifs) {struct qmc_hdlc *qmc_hdlc =netdev_to_qmc_hdlc (netdev);te1_settings te1; +int ret;switch (ifs->type) {case IF_GET_IFACE : - ifs->type =IF_IFACE_E1 ;if (ifs->size <sizeof (te1)) { +/* Retrieve type only */ + ret =qmc_hdlc_framer_get_iface (qmc_hdlc, &ifs->type,NULL ); +if (ret) +return ret; +if (!ifs->size)return 0 ;/* only type requested */
@@ -334,6 +538,11 @@ static int qmc_hdlc_ioctl(struct net_device *netdev, struct if_settings *ifs)memset (&te1,0 ,sizeof (te1)); +/* Retrieve info from framer */ + ret =qmc_hdlc_framer_get_iface (qmc_hdlc, &ifs->type, &te1); +if (ret) +return ret; +/* Update slot_map */ te1.slot_map = qmc_hdlc->slot_map;
@@ -367,10 +576,17 @@ static int qmc_hdlc_open(struct net_device *netdev)int ret;int i; - ret =hdlc_open (netdev); + ret =qmc_hdlc_framer_start (qmc_hdlc);if (ret)return ret; + ret =hdlc_open (netdev); +if (ret) + goto framer_stop; + +/* Update carrier */ +qmc_hdlc_framer_set_carrier (qmc_hdlc); + chan_param.mode =QMC_HDLC ;/* HDLC_MAX_MRU + 4 for the CRC * HDLC_MAX_MRU + 4 + 8 for the CRC and some extraspace needed by the QMC
@@ -420,6 +636,8 @@ static int qmc_hdlc_open(struct net_device *netdev) } hdlc_close:hdlc_close (netdev); +framer_stop: +qmc_hdlc_framer_stop (qmc_hdlc);return ret; }
@@ -455,6 +673,7 @@ static int qmc_hdlc_close(struct net_device *netdev) }hdlc_close (netdev); +qmc_hdlc_framer_stop (qmc_hdlc);return 0 ; }
@@ -503,6 +722,7 @@ static int qmc_hdlc_probe(struct platform_device *pdev) qmc_hdlc->dev = &pdev->dev;spin_lock_init (&qmc_hdlc->tx_lock); +spin_lock_init (&qmc_hdlc->carrier_lock); qmc_hdlc->qmc_chan =devm_qmc_chan_get_byphandle (qmc_hdlc->dev, np,"fsl,qmc-chan" );if (IS_ERR (qmc_hdlc->qmc_chan)) {
@@ -531,10 +751,19 @@ static int qmc_hdlc_probe(struct platform_device *pdev)if (ret)return ret; + qmc_hdlc->framer =devm_framer_optional_get (qmc_hdlc->dev,"framer" ); +if (IS_ERR (qmc_hdlc->framer)) +return PTR_ERR (qmc_hdlc->framer); + + ret =qmc_hdlc_framer_init (qmc_hdlc); +if (ret) +return ret; + qmc_hdlc->netdev =alloc_hdlcdev (qmc_hdlc);if (!qmc_hdlc->netdev) {dev_err (qmc_hdlc->dev,"failed to alloc hdlc dev\n" ); -return -ENOMEM ; + ret = -ENOMEM ; + goto framer_exit; } hdlc =dev_to_hdlc (qmc_hdlc->netdev);
@@ -550,11 +779,12 @@ static int qmc_hdlc_probe(struct platform_device *pdev) }platform_set_drvdata (pdev, qmc_hdlc); -return 0 ; free_netdev:free_netdev (qmc_hdlc->netdev); +framer_exit: +qmc_hdlc_framer_exit (qmc_hdlc);return ret; }
@@ -564,6 +794,7 @@ static int qmc_hdlc_remove(struct platform_device *pdev)unregister_hdlc_device (qmc_hdlc->netdev);free_netdev (qmc_hdlc->netdev); +qmc_hdlc_framer_exit (qmc_hdlc);return 0 ; }
Signature · 1 line
2.41.0