Skip to content

Add support for QMC HDLC, framer infrastruture and PEF2256 framer (v4)

Christophe Leroy alsa-devel linux-arm-kernel linux-devicetree linux-gpio linuxppc-dev lkml netdev 1 version Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v4 Latest28 patches 19 repliesApplied

Changes in v4 from the cover letter

- Fixes build failure with CONFIG_MODULES in patch 21 (net: wan: Add framer framework support)

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/28soc: fsl: cpm1: tsa: Fix __iomem addresses declarationdrivers/soc/fsl/qe/tsa.c+11 -110 replies
2/28soc: fsl: cpm1: qmc: Fix __iomem addresses declarationdrivers/soc/fsl/qe/qmc.c+17 -170 replies
3/28soc: fsl: cpm1: qmc: Fix rx channel resetdrivers/soc/fsl/qe/qmc.c+0 -10 replies
4/28soc: fsl: cpm1: qmc: Extend the API to provide Rx statusdrivers/soc/fsl/qe/qmc.c include/soc/fsl/qe/qmc.h sound/soc/fsl/fsl_qmc_audio.c+40 -60 replies
5/28soc: fsl: cpm1: qmc: Remove inline function specifiersdrivers/soc/fsl/qe/qmc.c+7 -70 replies
6/28dt-bindings: net: Add support for QMC HDLCDocumentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml+46 -02 replies
7/28net: wan: Add support for QMC HDLCdrivers/net/wan/Kconfig drivers/net/wan/Makefile drivers/net/wan/fsl_qmc_hdlc.c+435 -00 replies
8/28MAINTAINERS: Add the Freescale QMC HDLC driver entryMAINTAINERS+8 -00 replies
9/28soc: fsl: cpm1: qmc: Introduce available timeslots masksdrivers/soc/fsl/qe/qmc.c+6 -20 replies
10/28soc: fsl: cpm1: qmc: Rename qmc_setup_tsa* to qmc_init_tsa*drivers/soc/fsl/qe/qmc.c+8 -80 replies
11/28soc: fsl: cpm1: qmc: Introduce qmc_chan_setup_tsa*drivers/soc/fsl/qe/qmc.c+125 -360 replies
12/28soc: fsl: cpm1: qmc: Remove no more needed checks from qmc_check_chans()drivers/soc/fsl/qe/qmc.c+0 -200 replies
13/28soc: fsl: cpm1: qmc: Check available timeslots in qmc_check_chans()drivers/soc/fsl/qe/qmc.c+4 -40 replies
14/28soc: fsl: cpm1: qmc: Add support for disabling channel TSA entriesdrivers/soc/fsl/qe/qmc.c+11 -90 replies
15/28soc: fsl: cpm1: qmc: Split Tx and Rx TSA entries setupdrivers/soc/fsl/qe/qmc.c+35 -140 replies
16/28soc: fsl: cpm1: qmc: Introduce is_tsa_64rxtx flagdrivers/soc/fsl/qe/qmc.c+4 -10 replies
17/28soc: fsl: cpm1: qmc: Handle timeslot entries at channel start() and stop()drivers/soc/fsl/qe/qmc.c+163 -120 replies
18/28soc: fsl: cpm1: qmc: Remove timeslots handling from setup_chan()drivers/soc/fsl/qe/qmc.c+0 -280 replies
19/28soc: fsl: cpm1: qmc: Introduce functions to change timeslots at runtimedrivers/soc/fsl/qe/qmc.c include/soc/fsl/qe/qmc.h+61 -00 replies
20/28wan: qmc_hdlc: Add runtime timeslots changes supportdrivers/net/wan/fsl_qmc_hdlc.c+168 -12 replies
21/28net: wan: Add framer framework supportdrivers/net/wan/Kconfig drivers/net/wan/Makefile drivers/net/wan/framer/Kconfig +4 more+1308 -09 replies
22/28dt-bindings: net: Add the Lantiq PEF2256 E1/T1/J1 framerDocumentation/devicetree/bindings/net/lantiq,pef2256.yaml+219 -02 replies
23/28mfd: core: Ensure disabled devices are skiped without abortingdrivers/mfd/mfd-core.c+12 -52 replies
24/28net: wan: framer: Add support for the Lantiq PEF2256 framerdrivers/net/wan/framer/Kconfig drivers/net/wan/framer/Makefile drivers/net/wan/framer/pef2256/Makefile +3 more+1186 -00 replies
25/28pinctrl: Add support for the Lantic PEF2256 pinmuxdrivers/pinctrl/Kconfig drivers/pinctrl/Makefile drivers/pinctrl/pinctrl-pef2256-regs.h +1 more+388 -00 replies
26/28MAINTAINERS: Add the Lantiq PEF2256 driver entryMAINTAINERS+9 -00 replies
27/28ASoC: codecs: Add support for the framer codecsound/soc/codecs/Kconfig sound/soc/codecs/Makefile sound/soc/codecs/framer-codec.c+430 -02 replies
28/28net: wan: fsl_qmc_hdlc: Add framer supportdrivers/net/wan/fsl_qmc_hdlc.c+235 -40 replies

Reviews trailers per patch

25 of 28 patches have a Reviewed-by or Acked-by.

PatchChristophe Leroy
1/28R-b
2/28R-b
3/28R-b
4/28R-b
5/28R-b
6/28
7/28R-b
8/28
9/28R-b
10/28R-b
11/28R-b
12/28R-b
13/28R-b
14/28R-b
15/28R-b
16/28R-b
17/28R-b
18/28R-b
19/28R-b
20/28R-b
21/28R-b
22/28
23/28R-b
24/28R-b
25/28R-b
26/28R-b
27/28R-b
28/28R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 00/28] Add support for QMC HDLC, framer infrastruture and PEF2256 framer (v4)

From: Herve Codina <[email protected]>

Hi,

TLDR: This is a resend of v3 with a build failure fix in patch 21. No other changes.

I have a system where I need to handle an HDLC interface and some audio data.

The HDLC data are transferred using a TDM bus on which a PEF2256 (E1/T1 framer) is present. The PEF2256 transfers data from/to the TDM bus to/from the E1 line. This PEF2256 is connected to a PowerQUICC SoC for the control path and the TDM is connected to the SoC (QMC component) for the data path.

From the QMC HDLC driver, I need to handle HDLC data using the QMC, carrier detection using the PEF2256 (E1 line carrier) and set/get some PEF2256 configuration.

The QMC HDLC driver considers the PEF2256 as a generic framer. It performs operations that involve the PEF2256 through the generic framer API.

The audio data are exchanged with the PEF2256 using a CPU DAI connected to the TDM bus through the QMC and the PEF2256 needs to be seen as a codec in order to be linked to the CPU DAI.
The codec handles the carrier detection using the PEF2256 and reports the carrier state to the ALSA subsystem using the ASoC jack detection.

The codec, even if instantiated by the PEF2256 driver, considers the PEF2256 as a generic framer.

The generic framer has:
- 2 consumers (QMC HDLC drv and codec)
- 1 provider (PEF2256)

So, the design is the following:

                        +------------------+           +---------+
                        | QMC              | <- TDM -> | PEF2256 | <-> E1
     +---------+        |  +-------------+ |           |         |
     | CPU DAI | <-data--> | QMC channel | |           |         |
     +---------+        |  +-------------+ |           |         |
+--------------+        |  +-------------+ |           |         |
| QMC HDLC drv | <-data--> | QMC channel | |           |         |
+--------------+        |  +-------------+ |           |         |
     ^                  +------------------+           |         |
     |   +--------+     +-------------+                |         |
     +-> | framer | <-> | PEF2256 drv | <- local bus ->|         |
         |        |     |             |                +---------+
     +-> |        |     |             |
     |   +--------+     |  +-------+  |
     +-------------------> | codec |  |
                        |  +-------+  |
                        +-------------+

Further more, the TDM timeslots used by the QMC HDLC driver need to be configured at runtime (QMC dynamic timeslots).

Several weeks ago, I sent two series related to this topic:
- Add the Lantiq PEF2256 audio support [1]
- RFC Add support for QMC HDLC and PHY [2]
This current series is a rework of these two series taking into account feedbacks previously received.

In order to implement all of this, I do the following:
1) Perform some fixes (patches 1, 2, 3, 4)
2) Introduce the QMC HDLC driver (patches 5, 6, 7)
3) Add QMC dynamic timeslot support (patches 8 - 18)
4) Add timeslots change support in QMC HDLC (patch 19)
5) Introduce framer infrastructure (patch 20)
6) Add PEF2256 framer provider (patches 11, 22, 23, 24, 25)
7) Add framer codec as a framer consumer (patch 26)
8) Add framer support as a framer consumer in QMC HDLC (patch 27, 28)

The series contains the full story and detailed modifications. If needed, the series can be split and/or commmits can be squashed. Let me know.

Compare to the previous iteration
https://lore.kernel.org/linux-kernel/[email protected]/
This v3 series mainly:
- Fixes some implementation details.
- Adds a new patch (patch 5) to remove existing inline keyword in the QMC driver.
- Squashes patches related to the QMC HDLC binding together.

Best regards,
Hervé

[1]: https://lore.kernel.org/all/[email protected]/
[2]: https://lore.kernel.org/all/[email protected]/

Changes v3 -> v4
- Fixes build failure with CONFIG_MODULES in patch 21 (net: wan: Add framer framework support)

Changes v2 -> v3

- Patches 1, 2, 3, 4
Add 'Reviewed-by: Christophe Leroy <[email protected]>'

- New patch
Remove inline keyword from the existing registers accessors helpers

- Patch 6 (patches 5, 27 in v2)
Update the binding title
Squash patch 27

- Patch 7 (patch 6 in v2)
Remove the cast in netdev_to_qmc_hdlc()
Add 'Reviewed-by: Christophe Leroy <[email protected]>'

- Patch 8 (patch 7 in v2): No change

- Patches 9, 10 (patches 8, 9 in v2)
Add 'Reviewed-by: Christophe Leroy <[email protected]>'

- Patch 11 (patch 10 in v2)
Remove inline keyword from the introduced qmc_clrsetbits16() helper Add 'Reviewed-by: Christophe Leroy <[email protected]>'

- Patches 12, 13, 14, 15, 16, 17, 18, 19, 20
Add 'Reviewed-by: Christophe Leroy <[email protected]>'

- Patch 21 (patch 20 in v2)
Remove unneeded framer NULL pointer check
Add 'Reviewed-by: Christophe Leroy <[email protected]>'

- Patch 22 (patch 21 in v2)
Change sclkr and sclkx clocks description
Remove the framer phandle property from the framer subnodes (ie. from framer-codec nodes)

- Patch 23 (patch 22 in v2)
Initialize 'disabled' variable at declaration
Fix commit log
Add 'Reviewed-by: Christophe Leroy <[email protected]>'

- Patch 24 (patch 23 in v2)
Remove inline keyword from the existing registers accessors helpers Use dev_warn_ratelimited() in default interrupt handler Add 'Reviewed-by: Christophe Leroy <[email protected]>'

- Patch 25 (patch 24 in v2)
Replace #include "linux/bitfield.h" by #include <linux/bitfield.h> Fold the pinctrl anonymous struct into the struct pef2256_pinctrl Update commit log
Add 'Reviewed-by: Christophe Leroy <[email protected]>'

- Patch 26 (patch 25 in v2)
Add 'Reviewed-by: Christophe Leroy <[email protected]>'

- Patch 27 (patch 26 in v2)
Fix error message
Changed the ch.max computation in framer_dai_hw_rule_channels_by_format() Add 'Reviewed-by: Christophe Leroy <[email protected]>'

- Patch 28
Add 'Reviewed-by: Christophe Leroy <[email protected]>'

Changes v1 -> v2
- Patches 1, 2 (New in v2)
Fix __iomem addresses declaration

- Patch 19 (17 in v1)
Fix a compilation warning

- Patch 26 (24 in v1)
Fix a typo in Kconfig file
Fix issues raised by sparse (make C=1)

Herve Codina (28):
soc: fsl: cpm1: tsa: Fix __iomem addresses declaration
soc: fsl: cpm1: qmc: Fix __iomem addresses declaration
soc: fsl: cpm1: qmc: Fix rx channel reset
soc: fsl: cpm1: qmc: Extend the API to provide Rx status
soc: fsl: cpm1: qmc: Remove inline function specifiers
dt-bindings: net: Add support for QMC HDLC
net: wan: Add support for QMC HDLC
MAINTAINERS: Add the Freescale QMC HDLC driver entry
soc: fsl: cpm1: qmc: Introduce available timeslots masks
soc: fsl: cpm1: qmc: Rename qmc_setup_tsa* to qmc_init_tsa*
soc: fsl: cpm1: qmc: Introduce qmc_chan_setup_tsa*
soc: fsl: cpm1: qmc: Remove no more needed checks from
qmc_check_chans()
soc: fsl: cpm1: qmc: Check available timeslots in qmc_check_chans()
soc: fsl: cpm1: qmc: Add support for disabling channel TSA entries
soc: fsl: cpm1: qmc: Split Tx and Rx TSA entries setup
soc: fsl: cpm1: qmc: Introduce is_tsa_64rxtx flag
soc: fsl: cpm1: qmc: Handle timeslot entries at channel start() and

    stop()

soc: fsl: cpm1: qmc: Remove timeslots handling from setup_chan()
soc: fsl: cpm1: qmc: Introduce functions to change timeslots at
runtime
wan: qmc_hdlc: Add runtime timeslots changes support
net: wan: Add framer framework support
dt-bindings: net: Add the Lantiq PEF2256 E1/T1/J1 framer
mfd: core: Ensure disabled devices are skiped without aborting
net: wan: framer: Add support for the Lantiq PEF2256 framer
pinctrl: Add support for the Lantic PEF2256 pinmux
MAINTAINERS: Add the Lantiq PEF2256 driver entry
ASoC: codecs: Add support for the framer codec
net: wan: fsl_qmc_hdlc: Add framer support

 .../devicetree/bindings/net/fsl,qmc-hdlc.yaml |  46 +
 .../bindings/net/lantiq,pef2256.yaml          | 219 +++++
 MAINTAINERS                                   |  17 +
 drivers/mfd/mfd-core.c                        |  17 +-
 drivers/net/wan/Kconfig                       |  14 +
 drivers/net/wan/Makefile                      |   3 +
 drivers/net/wan/framer/Kconfig                |  35 +
 drivers/net/wan/framer/Makefile               |   7 +
 drivers/net/wan/framer/framer-core.c          | 886 ++++++++++++++++++
 drivers/net/wan/framer/pef2256/Makefile       |   8 +
 drivers/net/wan/framer/pef2256/pef2256-regs.h | 250 +++++
 drivers/net/wan/framer/pef2256/pef2256.c      | 880 +++++++++++++++++
 drivers/net/wan/fsl_qmc_hdlc.c                | 820 ++++++++++++++++
 drivers/pinctrl/Kconfig                       |  14 +
 drivers/pinctrl/Makefile                      |   1 +
 drivers/pinctrl/pinctrl-pef2256-regs.h        |  65 ++
 drivers/pinctrl/pinctrl-pef2256.c             | 308 ++++++
 drivers/soc/fsl/qe/qmc.c                      | 501 ++++++++--
 drivers/soc/fsl/qe/tsa.c                      |  22 +-
 include/linux/framer/framer-provider.h        | 194 ++++
 include/linux/framer/framer.h                 | 199 ++++
 include/linux/framer/pef2256.h                |  31 +
 include/soc/fsl/qe/qmc.h                      |  25 +-
 sound/soc/codecs/Kconfig                      |  15 +
 sound/soc/codecs/Makefile                     |   2 +
 sound/soc/codecs/framer-codec.c               | 413 ++++++++
 sound/soc/fsl/fsl_qmc_audio.c                 |   2 +-
 27 files changed, 4872 insertions(+), 122 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/net/fsl,qmc-hdlc.yaml
 create mode 100644 Documentation/devicetree/bindings/net/lantiq,pef2256.yaml
 create mode 100644 drivers/net/wan/framer/Kconfig
 create mode 100644 drivers/net/wan/framer/Makefile
 create mode 100644 drivers/net/wan/framer/framer-core.c
 create mode 100644 drivers/net/wan/framer/pef2256/Makefile
 create mode 100644 drivers/net/wan/framer/pef2256/pef2256-regs.h
 create mode 100644 drivers/net/wan/framer/pef2256/pef2256.c
 create mode 100644 drivers/net/wan/fsl_qmc_hdlc.c
 create mode 100644 drivers/pinctrl/pinctrl-pef2256-regs.h
 create mode 100644 drivers/pinctrl/pinctrl-pef2256.c
 create mode 100644 include/linux/framer/framer-provider.h
 create mode 100644 include/linux/framer/framer.h
 create mode 100644 include/linux/framer/pef2256.h
 create mode 100644 sound/soc/codecs/framer-codec.c
Signature · 7 lines
2.41.0


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel