Enable FPGA Manager support for Agilex5
Subsystems (2)
v4 cover Enable FPGA Manager support for Agilex5
This patch series adds device tree bindings, driver and DTS updates to enable FPGA Manager functionality for Intel Agilex5 SoC.
These changes are intended to enable FPGA programming and FPGA management capabilities on Agilex5-based platforms.
---
Notes:
Patch #2 depends on "arm64: dts: intel: Add Agilex5 SVC node with memory region" from
https://lore.kernel.org/all/3381ef56c1ff34a0b54cf76010889b5523ead825.1762387665.git.khairul.anuar.romli@altera.com/
This patch series is applied on socfpga maintainer's tree
https://git.kernel.org/pub/scm/linux/kernel/git/dinguyen/linux.git/log/?h=socfpga_dts_for_v6.19
Changes in v4:
- Simplify the compatible property to use enum without items.
- Use contains instead of oneOf due to the use of enum without items.
Changes in v3:
- Add fallback in altera's soc fpga manager compatible properties.
- Validate with make CHECK_DBTS=y on:
- intel/socfpga_agilex5_socdk.dtb (fallback)
- intel/socfpga_agilex_socdk.dtb (non-fallback)
- altera/socfpga_stratix10_socdk.dtb (non-fallback)
Changes in v2:
- Drop "fpga: stratix10-soc: Add support for Agilex5"
- Add fallback compatible in DT
---
Khairul Anuar Romli (2):
dt-bindings: fpga: stratix10: add support for Agilex5
arm64: dts: agilex5: add fpga-region and fpga-mgr nodes
.../bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml | 8 +++++--- arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi | 12 ++++++++++++ 2 files changed, 17 insertions(+), 3 deletions(-)
Signature · 1 line
2.43.7
PATCH v4 1/2 dt-bindings: fpga: stratix10: add support for Agilex5
Agilex5 introduces changes in how reserved memory is mapped and accessed compared to previous SoC generations. Agilex5 compatible allows stratix10- FPGA manager driver to handle these changes.
Fallback is added for driver probe and init that rely on matching of table and DT node.
---
Changes in v4:
- Remove redundant "items - enum" as suggested in v3.
- Simplify compatible property to use contains instead of oneOf.
- Validate fallback and non-fallback DT. Also validate binding with dt_binding_check.
Changes in v3:
- Add description for Agilex5 Device
- Add and define fallback to "intel,agilex-soc-fpga-mgr"
- Validate against Agilex and Stratix10 (non-fallback) and Agilex5 (fallback)
Changes in v2:
- No changes in this patch
--- .../bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml +5 -3
@@ -20,9 +20,11 @@ description: properties: compatible: - enum: - - intel,stratix10-soc-fpga-mgr - - intel,agilex-soc-fpga-mgr + contains: + enum: + - intel,stratix10-soc-fpga-mgr + - intel,agilex-soc-fpga-mgr + - intel,agilex5-soc-fpga-mgr required: - compatible
Signature · 1 line
2.43.7
Re: [PATCH v4 1/2] dt-bindings: fpga: stratix10: add support for Agilex5
Quoted 7 lines · Khairul Anuar Romli
Agilex5 introduces changes in how reserved memory is mapped and accessed compared to previous SoC generations. Agilex5 compatible allows stratix10- FPGA manager driver to handle these changes.
Fallback is added for driver probe and init that rely on matching of table and DT node.
Quoted 8 lines
Reviewed-by Xu Yilun <[email protected]>Signed-off-by Khairul Anuar Romli <[email protected]>---
Changes in v4:
- Remove redundant "items - enum" as suggested in v3.
- Simplify compatible property to use contains instead of oneOf.
- Validate fallback and non-fallback DT. Also validate binding withdt_binding_check.
What are you doing?? You've been told several times exactly what to do and yet you keep conjuring up completely random different things. Using contains instead of the oneOf construct that was being done before is *not* a simplification, it is functionally different.
NAK. Go do what you were told to do.
pw-bot: changes-requested
Quoted 33 lines
Changes in v3:
- Add description for Agilex5 Device
- Add and define fallback to "intel,agilex-soc-fpga-mgr"
- Validate against Agilex and Stratix10 (non-fallback) and Agilex5 (fallback)
Changes in v2:
- No changes in this patch--- .../bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)Documentation/devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml +5
-3@@ -20,9 +20,11 @@ description: properties: compatible: - enum: - - intel,stratix10-soc-fpga-mgr - - intel,agilex-soc-fpga-mgr + contains: + enum: + - intel,stratix10-soc-fpga-mgr + - intel,agilex-soc-fpga-mgr + - intel,agilex5-soc-fpga-mgr required: - compatibleSignature · 1 line
2.43.7
Re: [PATCH v4 1/2] dt-bindings: fpga: stratix10: add support for Agilex5
Quoted 17 lines · Conor Dooley
Quoted 7 lines · Khairul Anuar Romli
Agilex5 introduces changes in how reserved memory is mapped and accessed compared to previous SoC generations. Agilex5 compatible allows stratix10- FPGA manager driver to handle these changes.
Fallback is added for driver probe and init that rely on matching of table and DT node.
Quoted 8 lines
Reviewed-by Xu Yilun <[email protected]>Signed-off-by Khairul Anuar Romli <[email protected]>---
Changes in v4:
- Remove redundant "items - enum" as suggested in v3.
- Simplify compatible property to use contains instead of oneOf.
- Validate fallback and non-fallback DT. Also validate binding withdt_binding_check.
Quoted 6 lines
What are you doing?? You've been told several times exactly what to do and yet you keep conjuring up completely random different things. Using contains instead of the oneOf construct that was being done before is *not* a simplification, it is functionally different.
NAK. Go do what you were told to do.
There is no single file with that syntax, so I really do not understand why completely different syntax is reasonable for the author :/
Best regards,
Krzysztof
Re: [PATCH v4 1/2] dt-bindings: fpga: stratix10: add support for Agilex5
Quoted 23 lines · Krzysztof Kozlowski
Quoted 22 lines · Conor Dooley
Quoted 7 lines · Khairul Anuar Romli
Agilex5 introduces changes in how reserved memory is mapped and accessed compared to previous SoC generations. Agilex5 compatible allows stratix10- FPGA manager driver to handle these changes.
Fallback is added for driver probe and init that rely on matching of table and DT node.
Quoted 8 lines
Reviewed-by Xu Yilun <[email protected]>Signed-off-by Khairul Anuar Romli <[email protected]>---
Changes in v4:
- Remove redundant "items - enum" as suggested in v3.
- Simplify compatible property to use contains instead of oneOf.
- Validate fallback and non-fallback DT. Also validate binding withdt_binding_check.What are you doing?? You've been told several times exactly what to do and yet you keep conjuring up completely random different things. Using contains instead of the oneOf construct that was being done before is *not* a simplification, it is functionally different.
Quoted 4 lines
Quoted 1 line
NAK. Go do what you were told to do.
There is no single file with that syntax, so I really do not understand why completely different syntax is reasonable for the author :/
There are actually a handful of bindings that do it (14). Some are probably wrong, others are the generic portions of snps etc IP schemas. Run this if you wanna quickly see what's what:
rg --multiline "^properties:\n.*compatible:\n.*contains" --context=5
I'd say that about half of them should be enums or const.
PATCH v4 2/2 arm64: dts: agilex5: add fpga-region and fpga-mgr nodes
In reply to Khairul Anuar RomliThe Intel Agilex 5 SoC contains a programmable FPGA region that requires proper device tree description to enable FPGA manager support in the Linux kernel.
The fpga-region node is introduced to support FPGA partial reconfiguration through the FPGA Manager framework. This node defines a region in the device tree that can be dynamically programmed at runtime.
---
Changes in v4:
- No changes.
- Validated with CHECK_DTBS=y as standalone and with intel,stratix10-soc-fpga-mgr.yaml
Changes in v3:
- tested with intel,stratix10-soc-fpga-mgr.yaml
- Rephrase commit message to make it more concise.
Changes in v2:
- All fallback compatible string to ensure driver is still able to initialize without new compatible string added in the driver.
--- arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi | 12 ++++++++++++ 1 file changed, 12 insertions(+)
arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi +12 -0
@@ -85,9 +85,21 @@ svc { method = "smc"; memory-region = <&service_reserved>; iommus = <&smmu 10>; + + fpga_mgr: fpga-mgr { + compatible = "intel,agilex5-soc-fpga-mgr", + "intel,agilex-soc-fpga-mgr"; + }; }; }; + fpga-region { + compatible = "fpga-region"; + #address-cells = <0x2>; + #size-cells = <0x2>; + fpga-mgr = <&fpga_mgr>; + }; + psci { compatible = "arm,psci-0.2"; method = "smc";
Signature · 1 line
2.43.7