Skip to contentSkip to conversation

Enable FPGA Manager support for Agilex5

PATCH Superseded Khairul Anuar Romli 4 participants 18 messages Nov 13, 2025 – Nov 14, 2025

Subsystems (2)

v2 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

v2 cover Enable FPGA Manager support for Agilex5

This patch series adds device tree bindings, driver support, and DTS updates to enable FPGA Manager functionality for Intel Agilex5 SoC.

These changes are intended to enable FPGA programming and management capabilities on Agilex5-based platforms.

---
Notes:
Patch #3 depends on "arm64: dts: intel: Add Agilex5 SVC node with memory region" from
https://lore.kernel.org/all/3381ef56c1ff34a0b54cf76010889b5523ead825.1762387665.git.khairul.anuar.romli@altera.com/

This patch series is applied on socfpga maintainer's tree
https://git.kernel.org/pub/scm/linux/kernel/git/dinguyen/linux.git/log/?h=socfpga_dts_for_v6.19

Changes in v2:
- Drop "fpga: stratix10-soc: Add support for Agilex5"
- Add fallback compatible in DT
---
Khairul Anuar Romli (2):
dt-bindings: fpga: stratix10: add support for Agilex5
arm64: dts: agilex5: add fpga-region and fpga-mgr nodes

 .../bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml  |  1 +
 arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi       | 12 ++++++++++++
 2 files changed, 13 insertions(+)
Signature · 1 line
2.43.7
#1 lore raw

PATCH v2 1/2 dt-bindings: fpga: stratix10: add support for Agilex5

The Agilex 5 SoC FPGA manager introduces updated hardware features and register maps that require explicit binding support to enable correct initialization and control through the FPGA manager subsystem.

It allows FPGA manager drivers detect and configure Agilex 5 FPGA managers properly. This changes also keep device tree bindings up to date with hardware platforms changes.

---
Changes in v2:
- No changes in this patch

---
 .../devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml   | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml +1 -0
index 6e536d6b28a9..b531522cca07 100644
@@ -23,6 +23,7 @@ properties:
     enum:
       - intel,stratix10-soc-fpga-mgr
       - intel,agilex-soc-fpga-mgr
+      - intel,agilex5-soc-fpga-mgr
 
 required:
   - compatible
Signature · 1 line
2.43.7
Reviewed-by on v2 1/2
#2 lore raw

Re: [PATCH v2 1/2] dt-bindings: fpga: stratix10: add support for Agilex5

Quoted 21 lines · Khairul Anuar Romli

The Agilex 5 SoC FPGA manager introduces updated hardware features and register maps that require explicit binding support to enable correct initialization and control through the FPGA manager subsystem.

It allows FPGA manager drivers detect and configure Agilex 5 FPGA managers properly. This changes also keep device tree bindings up to date with hardware platforms changes.

---
Changes in v2:
- No changes in this patch

---
 .../devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml   | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml +0 -0
index 6e536d6b28a9..b531522cca07 100644

Documentation/devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml properties: · line 26

Quoted 4 lines
Documentation/devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml +1 -0
@@ -23,6 +23,7 @@ properties:
     enum:
       - intel,stratix10-soc-fpga-mgr
       - intel,agilex-soc-fpga-mgr
+      - intel,agilex5-soc-fpga-mgr
Quoted 7 lines
Documentation/devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml +0 -0
 required:
   - compatible
Signature · 1 line
2.43.7
#3 lore raw

Re: [PATCH v2 1/2] dt-bindings: fpga: stratix10: add support for Agilex5

Quoted 5 lines · Xu Yilun
Quoted 4 lines · Khairul Anuar Romli

The Agilex 5 SoC FPGA manager introduces updated hardware features and register maps that require explicit binding support to enable correct initialization and control through the FPGA manager subsystem.

Quoted 8 lines
Quoted 8 lines

It allows FPGA manager drivers detect and configure Agilex 5 FPGA managers properly. This changes also keep device tree bindings up to date with hardware platforms changes.

---
Changes in v2:
- No changes in this patch

Should have been changed to permit the fallback compatible as discussed.
pw-bot: changes-requested

Quoted 23 lines

Documentation/devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml properties: · line 26

Quoted 13 lines
---
 .../devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml   | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml +1 -0
index 6e536d6b28a9..b531522cca07 100644
@@ -23,6 +23,7 @@ properties:
     enum:
       - intel,stratix10-soc-fpga-mgr
       - intel,agilex-soc-fpga-mgr
+      - intel,agilex5-soc-fpga-mgr
Quoted 7 lines
Documentation/devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml +0 -0
 required:
   - compatible
Signature · 1 line
2.43.7
#4 lore raw

Re: [PATCH v2 1/2] dt-bindings: fpga: stratix10: add support for Agilex5

Quoted 10 lines · Conor Dooley
Quoted 9 lines · Xu Yilun
Quoted 8 lines · Khairul Anuar Romli

The Agilex 5 SoC FPGA manager introduces updated hardware features and register maps that require explicit binding support to enable correct initialization and control through the FPGA manager subsystem.

It allows FPGA manager drivers detect and configure Agilex 5 FPGA managers properly. This changes also keep device tree bindings up to date with hardware platforms changes.

Quoted 8 lines
Quoted 4 lines
Quoted 4 lines

---
Changes in v2:
- No changes in this patch

Should have been changed to permit the fallback compatible as discussed.
pw-bot: changes-requested

Working on it right now. Will include the changes in the next version after test is done.

Thanks.

Best Regards,
Khairul

Quoted 24 lines
Quoted 24 lines
Quoted 10 lines
---
  .../devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml   | 1 +
  1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml +0 -0
index 6e536d6b28a9..b531522cca07 100644

Documentation/devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml properties: · line 26

Quoted 4 lines
Documentation/devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml +1 -0
@@ -23,6 +23,7 @@ properties:
      enum:
        - intel,stratix10-soc-fpga-mgr
        - intel,agilex-soc-fpga-mgr
+      - intel,agilex5-soc-fpga-mgr
Quoted 7 lines
Documentation/devicetree/bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml +0 -0
  required:
    - compatible
Signature · 1 line
2.43.7
#5 lore raw

PATCH v2 2/2 arm64: dts: agilex5: add fpga-region and fpga-mgr nodes

In reply to Khairul Anuar Romli

The Intel Agilex 5 SoC contains a programmable FPGA region that requires proper device tree description to enable FPGA manager support in the Linux kernel. Without the 'fpga-region' and 'fpga-mgr' nodes, the kernel cannot detect or manage the FPGA hardware correctly.

This patch adds a 'fpga-region' node with compatible = "fpga-region", along with appropriate #address-cells and #size-cells properties, to describe the FPGA region layout.

Also defines specific compatible string for Agilex5 and add Agilex string as fallback for stratix10-soc driver initialization.

---
Changes in v2:
- All fallback compatible string to ensure driver is still able to initialize without new compatible string added in the driver.

---
 arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)
arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi +12 -0
index bf7128adddde..06be0b8671c0 100644
@@ -85,9 +85,21 @@ svc {
 			method = "smc";
 			memory-region = <&service_reserved>;
 			iommus = <&smmu 10>;
+
+			fpga_mgr: fpga-mgr {
+				compatible = "intel,agilex5-soc-fpga-mgr",
+					     "intel,agilex-soc-fpga-mgr";
+			};
 		};
 	};
 
+	fpga-region {
+		compatible = "fpga-region";
+		#address-cells = <0x2>;
+		#size-cells = <0x2>;
+		fpga-mgr = <&fpga_mgr>;
+	};
+
 	psci {
 		compatible = "arm,psci-0.2";
 		method = "smc";
Signature · 1 line
2.43.7
Reviewed-by on v2 2/2
#6 lore raw

Re: [PATCH v2 2/2] arm64: dts: agilex5: add fpga-region and fpga-mgr nodes

Quoted 5 lines · Khairul Anuar Romli

The Intel Agilex 5 SoC contains a programmable FPGA region that requires proper device tree description to enable FPGA manager support in the Linux kernel. Without the 'fpga-region' and 'fpga-mgr' nodes, the kernel cannot detect or manage the FPGA hardware correctly.

Quoted 8 lines

This patch adds a 'fpga-region' node with compatible = "fpga-region", along with appropriate #address-cells and #size-cells properties, to describe the FPGA region layout.

Also defines specific compatible string for Agilex5 and add Agilex string as fallback for stratix10-soc driver initialization.

#7 lore raw

Re: [PATCH v2 2/2] arm64: dts: agilex5: add fpga-region and fpga-mgr nodes

Quoted 10 lines · Xu Yilun
Quoted 9 lines · Khairul Anuar Romli

The Intel Agilex 5 SoC contains a programmable FPGA region that requires proper device tree description to enable FPGA manager support in the Linux kernel. Without the 'fpga-region' and 'fpga-mgr' nodes, the kernel cannot detect or manage the FPGA hardware correctly.

This patch adds a 'fpga-region' node with compatible = "fpga-region", along with appropriate #address-cells and #size-cells properties, to describe the FPGA region layout.

Quoted 6 lines
Quoted 4 lines

Also defines specific compatible string for Agilex5 and add Agilex string as fallback for stratix10-soc driver initialization.

How this can be reviewed if it is completely wrong and obviously not matching the bindings from this patchset?

Best regards,
Krzysztof

#8 lore raw

Re: [PATCH v2 2/2] arm64: dts: agilex5: add fpga-region and fpga-mgr nodes

Quoted 16 lines · Krzysztof Kozlowski
Quoted 15 lines · Xu Yilun
Quoted 13 lines · Khairul Anuar Romli

The Intel Agilex 5 SoC contains a programmable FPGA region that requires proper device tree description to enable FPGA manager support in the Linux kernel. Without the 'fpga-region' and 'fpga-mgr' nodes, the kernel cannot detect or manage the FPGA hardware correctly.

This patch adds a 'fpga-region' node with compatible = "fpga-region", along with appropriate #address-cells and #size-cells properties, to describe the FPGA region layout.

Also defines specific compatible string for Agilex5 and add Agilex string as fallback for stratix10-soc driver initialization.

Quoted 7 lines
Quoted 1 line

How this can be reviewed if it is completely wrong and obviously not matching the bindings from this patchset?

Best regards,
Krzysztof

Could you point out which part that I need to fix?

Thanks.

Best Regards,
Khairul

#9 lore raw

Re: [PATCH v2 2/2] arm64: dts: agilex5: add fpga-region and fpga-mgr nodes

Quoted 19 lines · Khairul Anuar
Quoted 18 lines · Krzysztof Kozlowski
Quoted 16 lines · Xu Yilun
Quoted 5 lines · Khairul Anuar Romli

The Intel Agilex 5 SoC contains a programmable FPGA region that requires proper device tree description to enable FPGA manager support in the Linux kernel. Without the 'fpga-region' and 'fpga-mgr' nodes, the kernel cannot detect or manage the FPGA hardware correctly.

Quoted 8 lines

This patch adds a 'fpga-region' node with compatible = "fpga-region", along with appropriate #address-cells and #size-cells properties, to describe the FPGA region layout.

Also defines specific compatible string for Agilex5 and add Agilex string as fallback for stratix10-soc driver initialization.

Quoted 8 lines
Quoted 5 lines

How this can be reviewed if it is completely wrong and obviously not matching the bindings from this patchset?

Best regards,
Krzysztof

Could you point out which part that I need to fix?

Why? Tools tell you that. Why are you expecting the community to do the job of compiler/toolchain/toolset? We have better things to do.

Best regards,
Krzysztof

#10 lore raw

Re: [PATCH v2 2/2] arm64: dts: agilex5: add fpga-region and fpga-mgr nodes

In reply to Krzysztof Kozlowski
Quoted 14 lines · Krzysztof Kozlowski
Quoted 13 lines · Xu Yilun
Quoted 12 lines · Khairul Anuar Romli

The Intel Agilex 5 SoC contains a programmable FPGA region that requires proper device tree description to enable FPGA manager support in the Linux kernel. Without the 'fpga-region' and 'fpga-mgr' nodes, the kernel cannot detect or manage the FPGA hardware correctly.

This patch adds a 'fpga-region' node with compatible = "fpga-region", along with appropriate #address-cells and #size-cells properties, to describe the FPGA region layout.

Also defines specific compatible string for Agilex5 and add Agilex string as fallback for stratix10-soc driver initialization.

Quoted 6 lines
Quoted 3 lines
Quoted 1 line

How this can be reviewed if it is completely wrong and obviously not matching the bindings from this patchset?

I apologize. Obviously I didn't pay enough effort on DT. Thanks for pointing out and providing the Doc.

Quoted 3 lines

Best regards,
Krzysztof

#11 lore raw

Re: [PATCH v2 2/2] arm64: dts: agilex5: add fpga-region and fpga-mgr nodes

In reply to Khairul Anuar Romli
Quoted 26 lines · Khairul Anuar Romli

The Intel Agilex 5 SoC contains a programmable FPGA region that requires proper device tree description to enable FPGA manager support in the Linux kernel. Without the 'fpga-region' and 'fpga-mgr' nodes, the kernel cannot detect or manage the FPGA hardware correctly.

This patch adds a 'fpga-region' node with compatible = "fpga-region", along with appropriate #address-cells and #size-cells properties, to describe the FPGA region layout.

Also defines specific compatible string for Agilex5 and add Agilex string as fallback for stratix10-soc driver initialization.

---
Changes in v2:
- All fallback compatible string to ensure driver is still able to initialize without new compatible string added in the driver.

---
 arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)
arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi +0 -0
index bf7128adddde..06be0b8671c0 100644

arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi svc { · line 91

Quoted 7 lines
arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi +4 -0
@@ -85,9 +85,21 @@ svc {
 			method = "smc";
 			memory-region = <&service_reserved>;
 			iommus = <&smmu 10>;
+
+			fpga_mgr: fpga-mgr {
+				compatible = "intel,agilex5-soc-fpga-mgr",
+					     "intel,agilex-soc-fpga-mgr";

You did not bother to test this...

Best regards,
Krzysztof

#12 lore raw
In reply to Khairul Anuar Romli
Quoted 9 lines · Khairul Anuar Romli

This patch series adds device tree bindings, driver support, and DTS updates to enable FPGA Manager functionality for Intel Agilex5 SoC.

These changes are intended to enable FPGA programming and management capabilities on Agilex5-based platforms.

---
Notes:
Patch #3 depends on "arm64: dts: intel: Add Agilex5 SVC node with memory

There is no patch #3 now. Should be Patch #2 ?

Quoted 5 lines

region" from
https://lore.kernel.org/all/3381ef56c1ff34a0b54cf76010889b5523ead825.1762387665.git.khairul.anuar.romli@altera.com/

This patch series is applied on socfpga maintainer's tree
https://git.kernel.org/pub/scm/linux/kernel/git/dinguyen/linux.git/log/?h=socfpga_dts_for_v6.19

Given that, @Dinh Nguyen could you take the series if you are good?

Thanks,
Yilun

Quoted 17 lines

Changes in v2:
- Drop "fpga: stratix10-soc: Add support for Agilex5"
- Add fallback compatible in DT
---
Khairul Anuar Romli (2):
dt-bindings: fpga: stratix10: add support for Agilex5
arm64: dts: agilex5: add fpga-region and fpga-mgr nodes

 .../bindings/fpga/intel,stratix10-soc-fpga-mgr.yaml  |  1 +
 arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi       | 12 ++++++++++++
 2 files changed, 13 insertions(+)
Signature · 1 line
2.43.7
#13 lore raw
Quoted 13 lines · Xu Yilun
Quoted 9 lines · Khairul Anuar Romli

This patch series adds device tree bindings, driver support, and DTS updates to enable FPGA Manager functionality for Intel Agilex5 SoC.

These changes are intended to enable FPGA programming and management capabilities on Agilex5-based platforms.

---
Notes:
Patch #3 depends on "arm64: dts: intel: Add Agilex5 SVC node with memory

There is no patch #3 now. Should be Patch #2 ?

Quoted 7 lines
Quoted 5 lines

region" from
https://lore.kernel.org/all/3381ef56c1ff34a0b54cf76010889b5523ead825.1762387665.git.khairul.anuar.romli@altera.com/

This patch series is applied on socfpga maintainer's tree
https://git.kernel.org/pub/scm/linux/kernel/git/dinguyen/linux.git/log/?h=socfpga_dts_for_v6.19

Given that, @Dinh Nguyen could you take the series if you are good?

This was never tested, so series cannot be taken.

NAK, Altera should test the code BEFORE sending it to upstream, not after we say it was not tested.

Best regards,
Krzysztof

#14 lore raw
Quoted 22 lines · Krzysztof Kozlowski
Quoted 13 lines · Xu Yilun
Quoted 9 lines · Khairul Anuar Romli

This patch series adds device tree bindings, driver support, and DTS updates to enable FPGA Manager functionality for Intel Agilex5 SoC.

These changes are intended to enable FPGA programming and management capabilities on Agilex5-based platforms.

---
Notes:
Patch #3 depends on "arm64: dts: intel: Add Agilex5 SVC node with memory

There is no patch #3 now. Should be Patch #2 ?

Quoted 7 lines
Quoted 5 lines

region" from
https://lore.kernel.org/all/3381ef56c1ff34a0b54cf76010889b5523ead825.1762387665.git.khairul.anuar.romli@altera.com/

This patch series is applied on socfpga maintainer's tree
https://git.kernel.org/pub/scm/linux/kernel/git/dinguyen/linux.git/log/?h=socfpga_dts_for_v6.19

Given that, @Dinh Nguyen could you take the series if you are good?

Quoted 7 lines

This was never tested, so series cannot be taken.

NAK, Altera should test the code BEFORE sending it to upstream, not after we say it was not tested.

Best regards,
Krzysztof

If you are referring to the code being tested on the Agilex5, it was tested. I even take the measure to add the debug print the in init to see if the fallback is working, which it did.

Of course I took clock manager patch from Dinh's clock manager driver for Agilex5 have local defconfig instead of using default defconfig for testing the code.

https://lore.kernel.org/all/9326ee66cb8e33c0fe83a24e9a1effc8da252ff2.1760396607.git.khairul.anuar.romli@altera.com/

Are you referring to different kind of test?

Thanks.

Best Regards,
Khairul

#15 lore raw
Quoted 35 lines · Khairul Anuar
Quoted 22 lines · Krzysztof Kozlowski
Quoted 13 lines · Xu Yilun
Quoted 9 lines · Khairul Anuar Romli

This patch series adds device tree bindings, driver support, and DTS updates to enable FPGA Manager functionality for Intel Agilex5 SoC.

These changes are intended to enable FPGA programming and management capabilities on Agilex5-based platforms.

---
Notes:
Patch #3 depends on "arm64: dts: intel: Add Agilex5 SVC node with memory

There is no patch #3 now. Should be Patch #2 ?

Quoted 7 lines
Quoted 5 lines

region" from
https://lore.kernel.org/all/3381ef56c1ff34a0b54cf76010889b5523ead825.1762387665.git.khairul.anuar.romli@altera.com/

This patch series is applied on socfpga maintainer's tree
https://git.kernel.org/pub/scm/linux/kernel/git/dinguyen/linux.git/log/?h=socfpga_dts_for_v6.19

Given that, @Dinh Nguyen could you take the series if you are good?

Quoted 7 lines

This was never tested, so series cannot be taken.

NAK, Altera should test the code BEFORE sending it to upstream, not after we say it was not tested.

Best regards,
Krzysztof

If you are referring to the code being tested on the Agilex5, it was tested. I even take the measure to add the debug print the in init to see if the fallback is working, which it did.

Quoted 7 lines

Of course I took clock manager patch from Dinh's clock manager driver for Agilex5 have local defconfig instead of using default defconfig for testing the code.

https://lore.kernel.org/all/9326ee66cb8e33c0fe83a24e9a1effc8da252ff2.1760396607.git.khairul.anuar.romli@altera.com/

Are you referring to different kind of test?

Yes, test by tools, because you certainly do not want to engage reviewers if computers do the job fine.

see any DT talk (there where like four last years!) or Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/

Best regards,
Krzysztof

#16 lore raw
Quoted 47 lines · Krzysztof Kozlowski
Quoted 35 lines · Khairul Anuar
Quoted 22 lines · Krzysztof Kozlowski
Quoted 13 lines · Xu Yilun
Quoted 9 lines · Khairul Anuar Romli

This patch series adds device tree bindings, driver support, and DTS updates to enable FPGA Manager functionality for Intel Agilex5 SoC.

These changes are intended to enable FPGA programming and management capabilities on Agilex5-based platforms.

---
Notes:
Patch #3 depends on "arm64: dts: intel: Add Agilex5 SVC node with memory

There is no patch #3 now. Should be Patch #2 ?

Quoted 7 lines
Quoted 5 lines

region" from
https://lore.kernel.org/all/3381ef56c1ff34a0b54cf76010889b5523ead825.1762387665.git.khairul.anuar.romli@altera.com/

This patch series is applied on socfpga maintainer's tree
https://git.kernel.org/pub/scm/linux/kernel/git/dinguyen/linux.git/log/?h=socfpga_dts_for_v6.19

Given that, @Dinh Nguyen could you take the series if you are good?

Quoted 7 lines

This was never tested, so series cannot be taken.

NAK, Altera should test the code BEFORE sending it to upstream, not after we say it was not tested.

Best regards,
Krzysztof

If you are referring to the code being tested on the Agilex5, it was tested. I even take the measure to add the debug print the in init to see if the fallback is working, which it did.

Quoted 7 lines

Of course I took clock manager patch from Dinh's clock manager driver for Agilex5 have local defconfig instead of using default defconfig for testing the code.

https://lore.kernel.org/all/9326ee66cb8e33c0fe83a24e9a1effc8da252ff2.1760396607.git.khairul.anuar.romli@altera.com/

Are you referring to different kind of test?

Yes, test by tools, because you certainly do not want to engage reviewers if computers do the job fine.

Quoted 6 lines

see any DT talk (there where like four last years!) or Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/

Best regards,
Krzysztof

Thanks, I can see the error with make -j48 CHECK_DTBS=y DT_SCHEMA_FILES=intel,stratix10-soc-fpga-mgr.yaml intel/socfpga_agilex5_socdk.dtb;

If i revert back without adding "intel,agilex-soc-fpga-mgr"", the tool is able to pass without any issue. But we need the driver entry to make it able to load as it compare the entry from dts and the compatible entry in the driver.

Should we add back the entry in the driver like in the v1? Or, shall we defer the driver changes for now?

Thanks.

Best Regards,
Khairul

#17 lore raw
Quoted 59 lines · Khairul Anuar
Quoted 47 lines · Krzysztof Kozlowski
Quoted 35 lines · Khairul Anuar
Quoted 22 lines · Krzysztof Kozlowski
Quoted 13 lines · Xu Yilun
Quoted 9 lines · Khairul Anuar Romli

This patch series adds device tree bindings, driver support, and DTS updates to enable FPGA Manager functionality for Intel Agilex5 SoC.

These changes are intended to enable FPGA programming and management capabilities on Agilex5-based platforms.

---
Notes:
Patch #3 depends on "arm64: dts: intel: Add Agilex5 SVC node with memory

There is no patch #3 now. Should be Patch #2 ?

Quoted 7 lines
Quoted 5 lines

region" from
https://lore.kernel.org/all/3381ef56c1ff34a0b54cf76010889b5523ead825.1762387665.git.khairul.anuar.romli@altera.com/

This patch series is applied on socfpga maintainer's tree
https://git.kernel.org/pub/scm/linux/kernel/git/dinguyen/linux.git/log/?h=socfpga_dts_for_v6.19

Given that, @Dinh Nguyen could you take the series if you are good?

Quoted 7 lines

This was never tested, so series cannot be taken.

NAK, Altera should test the code BEFORE sending it to upstream, not after we say it was not tested.

Best regards,
Krzysztof

If you are referring to the code being tested on the Agilex5, it was tested. I even take the measure to add the debug print the in init to see if the fallback is working, which it did.

Quoted 7 lines

Of course I took clock manager patch from Dinh's clock manager driver for Agilex5 have local defconfig instead of using default defconfig for testing the code.

https://lore.kernel.org/all/9326ee66cb8e33c0fe83a24e9a1effc8da252ff2.1760396607.git.khairul.anuar.romli@altera.com/

Are you referring to different kind of test?

Yes, test by tools, because you certainly do not want to engage reviewers if computers do the job fine.

Quoted 6 lines

see any DT talk (there where like four last years!) or Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/

Best regards,
Krzysztof

Thanks, I can see the error with make -j48 CHECK_DTBS=y DT_SCHEMA_FILES=intel,stratix10-soc-fpga-mgr.yaml intel/socfpga_agilex5_socdk.dtb;

Quoted 7 lines

If i revert back without adding "intel,agilex-soc-fpga-mgr"", the tool is able to pass without any issue. But we need the driver entry to make it able to load as it compare the entry from dts and the compatible entry in the driver.

Should we add back the entry in the driver like in the v1? Or, shall we defer the driver changes for now?

You ask now about basics of DT, so sorry but doing homework is your task. Maybe the beginners DTS talk from this year's OSSEU will be helpful here. Or one of many other resources...

Best regards,
Krzysztof