Skip to contentSkip to conversation

arm64: dts: intel: set alias for i3c controllers for agilex5 variants and derivatives

PATCH In review Adrian Ng Ho Yin 2 participants 5 messages May 5 – May 6 Device tree bindings

lore
Share & tools
lore
#0 lore raw

v3 cover arm64: dts: intel: set alias for i3c controllers for agilex5 variants and derivatives

Agilex5 SoCFPGA variants and derivatives have 2 i3c controllers, a main master and a secondary master. Setting the alias for both i3c controllers to prevent bus id contention when both controllers are enabled which results in driver probe failures.

---
changelog
v1->v2
* Simplify commit titles

v2->v3
* Update commit titles for clarity
---

Adrian Ng Ho Yin (2):
arm64: dts: socfpga: agilex5: set alias for i3c controllers
arm64: dts: socfpga: agilex3: set alias for i3c controller

 arch/arm64/boot/dts/intel/socfpga_agilex3_socdk.dts         | 2 ++
 arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts         | 2 ++
 arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_013b.dts    | 2 ++
 arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_modular.dts | 2 ++
 arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_nand.dts    | 2 ++
 5 files changed, 10 insertions(+)
Signature · 1 line
2.49.GIT
#1 lore raw

PATCH v3 1/2 arm64: dts: socfpga: agilex5: set alias for i3c controllers

From: Adrian Ng Ho Yin <[email protected]>

Agilex5 SoCFPGA variants and derivities have 2 i3c controllers, a main master and a secondary master. Setting the alias for both i3c controllers to prevent bus id contention when both controllers are enabled which results in driver probe failures.

---
 arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts         | 2 ++
 arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_013b.dts    | 2 ++
 arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_modular.dts | 2 ++
 arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_nand.dts    | 2 ++
 4 files changed, 8 insertions(+)
arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts +2 -0
index 262bb3e8e5c7..dae0db9f8819 100644
@@ -13,6 +13,8 @@ aliases {
 		ethernet0 = &gmac0;
 		ethernet1 = &gmac1;
 		ethernet2 = &gmac2;
+		i3c0 = &i3c0;
+		i3c1 = &i3c1;
 	};
 
 	chosen {
arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_013b.dts +2 -0
index f71e1280c778..86137380df04 100644
@@ -11,6 +11,8 @@ / {
 	aliases {
 		serial0 = &uart0;
 		ethernet2 = &gmac2;
+		i3c0 = &i3c0;
+		i3c1 = &i3c1;
 	};
 
 	chosen {
arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_modular.dts +2 -0
index 1831402d8808..e728cedb4cbd 100644
@@ -11,6 +11,8 @@ / {
 	aliases {
 		serial0 = &uart0;
 		ethernet2 = &gmac2;
+		i3c0 = &i3c0;
+		i3c1 = &i3c1;
 	};
 
 	chosen {
arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_nand.dts +2 -0
index ec4541d44c9b..21faa47681fa 100644
@@ -11,6 +11,8 @@ / {
 	aliases {
 		serial0 = &uart0;
 		ethernet0 = &gmac0;
+		i3c0 = &i3c0;
+		i3c1 = &i3c1;
 	};
 
 	chosen {
Signature · 1 line
2.49.GIT
#2 lore raw

PATCH v3 2/2 arm64: dts: socfpga: agilex3: set alias for i3c controller

In reply to Adrian Ng Ho Yin

From: Adrian Ng Ho Yin <[email protected]>

Agilex3 SoCFPGA have 2 i3c controllers, a main master and a secondary master. Setting the alias for both i3c controllers to prevent bus id contention when both controllers are enabled which results in driver probe failures.

---
 arch/arm64/boot/dts/intel/socfpga_agilex3_socdk.dts | 2 ++
 1 file changed, 2 insertions(+)
arch/arm64/boot/dts/intel/socfpga_agilex3_socdk.dts +2 -0
index 14b299f19f3a..25e17df0cbdb 100644
@@ -12,6 +12,8 @@ / {
 	aliases {
 		serial0 = &uart0;
 		ethernet2 = &gmac2;
+		i3c0 = &i3c0;
+		i3c1 = &i3c1;
 	};
 
 	chosen {
Signature · 1 line
2.49.GIT
#3 lore raw
In reply to Adrian Ng Ho Yin

Hi Adrian,

Quoted 10 lines · Adrian Ng Ho Yin

Agilex5 SoCFPGA variants and derivatives have 2 i3c controllers, a main master and a secondary master. Setting the alias for both i3c controllers to prevent bus id contention when both controllers are enabled which results in driver probe failures.

---
changelog
v1->v2
* Simplify commit titles

Quoted 8 lines

v2->v3
* Update commit titles for clarity
---

Adrian Ng Ho Yin (2):
arm64: dts: socfpga: agilex5: set alias for i3c controllers
arm64: dts: socfpga: agilex3: set alias for i3c controller

I've applied both patches.

Nit: I'm getting this checkpatch warning:

WARNING: From:/Signed-off-by: email address mismatch: 'From: Adrian Ng Ho Yin <[email protected]>' != 'Signed-off-by: Adrian Ng Ho Yin <[email protected]>'

Please try to fix this up for future submissions.

Thanks,
Dinh

#4 lore raw
Quoted 24 lines · Dinh Nguyen

Hi Adrian,

Quoted 10 lines · Adrian Ng Ho Yin

Agilex5 SoCFPGA variants and derivatives have 2 i3c controllers, a main master and a secondary master. Setting the alias for both i3c controllers to prevent bus id contention when both controllers are enabled which results in driver probe failures.

---
changelog
v1->v2
* Simplify commit titles

Quoted 8 lines

v2->v3
* Update commit titles for clarity
---

Adrian Ng Ho Yin (2):
   arm64: dts: socfpga: agilex5: set alias for i3c controllers
   arm64: dts: socfpga: agilex3: set alias for i3c controller

I've applied both patches.

Quoted 8 lines

Nit: I'm getting this checkpatch warning:

WARNING: From:/Signed-off-by: email address mismatch: 'From: Adrian Ng Ho Yin <[email protected]>' != 'Signed-off-by: Adrian Ng Ho Yin <[email protected]>'

Please try to fix this up for future submissions.

Thanks,
Dinh

Hi Dinh,

Thanks for the feedback. Will fix in the future submissions.

Thank You
Adrian