Skip to contentSkip to conversation

Add OrangePi 6 Plus board

PATCH Superseded Gary Yang 2 participants 10 messages Jan 4 – Jan 6

Subsystems (2)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Gary Yang

author maintainer
#0 lore raw

v3 cover Add OrangePi 6 Plus board

Patch 1: add compatible strings for OrangePi 6 Plus board Patch 2: add dts file for OrangePi 6 Plus board

v3 changes:
-Pass dts build check with below commands:
make O=$OUTKNL dt_binding_check
make O=$OUTKNL dt_binding_check DT_SCHEMA_FILES=arm/cix.yaml scripts/checkpatch.pl 000*.patch
make O=$OUTKNL CHECK_DTBS=y W=1 cix/sky1-orion-o6.dtb
- Fix the description of board
- Fix the commit message length within 75 words

v2 changes:
-Pass dts build check with below commands:
make O=$OUTKNL dt_binding_check
make O=$OUTKNL dt_binding_check DT_SCHEMA_FILES=arm/cix.yaml scripts/checkpatch.pl 000*.patch
make O=$OUTKNL CHECK_DTBS=y W=1 cix/sky1-orion-o6.dtb
- Fix the description of board

Gary Yang (2):
dt-bindings: arm: cix: add OrangePi 6 Plus board
arm64: dts: cix: Add OrangePi 6 Plus board support

 .../devicetree/bindings/arm/cix.yaml          | 11 ++-
 arch/arm64/boot/dts/cix/Makefile              |  1 +
 arch/arm64/boot/dts/cix/sky1-xcp.dts          | 83 +++++++++++++++++++
 3 files changed, 93 insertions(+), 2 deletions(-)
 create mode 100644 arch/arm64/boot/dts/cix/sky1-xcp.dts
Signature · 1 line
2.49.0
author maintainer
#1 lore raw

PATCH v3 1/2 dt-bindings: arm: cix: add OrangePi 6 Plus board

OrangePi 6 Plus adopts CIX CD8180/CD8160 SoC, built-in 12-core 64-bit processor + NPU processor,integrated graphics processor, equipped with 16GB/32GB/64GB LPDDR5, and provides two M.2 KEY-M interfaces 2280 for NVMe SSD,as well as SPI FLASH and TF slots to meet the needs of fast read/write and high-capacity storage

---
 Documentation/devicetree/bindings/arm/cix.yaml | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/arm/cix.yaml +9 -2
index 114dab4bc4d2..9e132e609b7b 100644
@@ -16,9 +16,16 @@ properties:
   compatible:
     oneOf:
 
-      - description: Radxa Orion O6
+      - description: Radxa Orion O6 board
         items:
-          - const: radxa,orion-o6
+          - enum:
+              - radxa,orion-o6
+          - const: cix,sky1
+
+      - description: Xunlong orangepi 6 plus board
+        items:
+          - enum:
+              - xunlong,orangepi-6-plus
           - const: cix,sky1
 
 additionalProperties: true
Signature · 1 line
2.49.0
#2 lore raw

Re: [PATCH v3 1/2] dt-bindings: arm: cix: add OrangePi 6 Plus board

Quoted 21 lines · Gary Yang

OrangePi 6 Plus adopts CIX CD8180/CD8160 SoC, built-in 12-core 64-bit processor + NPU processor,integrated graphics processor, equipped with 16GB/32GB/64GB LPDDR5, and provides two M.2 KEY-M interfaces 2280 for NVMe SSD,as well as SPI FLASH and TF slots to meet the needs of fast read/write and high-capacity storage

---
 Documentation/devicetree/bindings/arm/cix.yaml | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/arm/cix.yaml +1 -1
index 114dab4bc4d2..9e132e609b7b 100644
@@ -16,9 +16,16 @@ properties:
   compatible:
     oneOf:
 
-      - description: Radxa Orion O6
+      - description: Radxa Orion O6 board

Documentation/devicetree/bindings/arm/cix.yaml properties: · line 28

Quoted 10 lines
Documentation/devicetree/bindings/arm/cix.yaml +8 -1
         items:
-          - const: radxa,orion-o6
+          - enum:
+              - radxa,orion-o6
+          - const: cix,sky1
+
+      - description: Xunlong orangepi 6 plus board
+        items:
+          - enum:
+              - xunlong,orangepi-6-plus

Previous patch was correct, not this one.

<form letter>
This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions of patchset, under or above your Signed-off-by tag, unless patch changed significantly (e.g. new properties added to the DT bindings). Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply.

Please read:
https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577

If a tag was not added on purpose, please state why and what changed. </form letter>

Read last sentence and linked documentation. Where did you explain ignoring/dropping my tag?

Best regards,
Krzysztof

author maintainer
#3 lore raw

回复: [PATCH v3 1/2] dt-bindings: arm: cix: add OrangePi 6 Plus board

Hi Krzysztof:

Thanks for your comments

Quoted 56 lines

EXTERNAL EMAIL

Quoted 22 lines · Gary Yang

OrangePi 6 Plus adopts CIX CD8180/CD8160 SoC, built-in 12-core 64-bit processor + NPU processor,integrated graphics processor, equipped with 16GB/32GB/64GB LPDDR5, and provides two M.2 KEY-M interfaces 2280 for NVMe SSD,as well as SPI FLASH and TF slots to meet the needs of fast read/write and high-capacity storage

---
 Documentation/devicetree/bindings/arm/cix.yaml | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/arm/cix.yaml +1 -1
index 114dab4bc4d2..9e132e609b7b 100644
@@ -16,9 +16,16 @@ properties:
   compatible:
     oneOf:
 
-      - description: Radxa Orion O6
+      - description: Radxa Orion O6 board

Documentation/devicetree/bindings/arm/cix.yaml properties: · line 28

Quoted 10 lines
Documentation/devicetree/bindings/arm/cix.yaml +8 -1
         items:
-          - const: radxa,orion-o6
+          - enum:
+              - radxa,orion-o6
+          - const: cix,sky1
+
+      - description: Xunlong orangepi 6 plus board
+        items:
+          - enum:
+              - xunlong,orangepi-6-plus

Previous patch was correct, not this one.

<form letter>
This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions of patchset, under or above your Signed-off-by tag, unless patch changed significantly (e.g. new properties added to the DT bindings). Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply.

Please read:
https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/sub
mitting-patches.rst#L577

Quoted 6 lines

If a tag was not added on purpose, please state why and what changed. </form letter>

Read last sentence and linked documentation. Where did you explain ignoring/dropping my tag?

Yes, the previous version was acked by you before.

When apply it, we found that orangepi 6 plus and Radxa Orion O6 belongs the different boards.

So we need to add a new item for it. Like these from qcom.yaml

- description: Qualcomm Technologies, Inc. Distributed Unit 1000 platform items:
- enum:
- qcom,qdu1000-idp
- qcom,qdu1000-x100
- const: qcom,qdu1000

- description: Qualcomm Technologies, Inc. Radio Unit 1000 platform items:
- enum:
- qcom,qru1000-idp
- const: qcom,qru1000

Best Regards
Gary

Quoted 2 lines

Best regards,
Krzysztof

#4 lore raw

Re: 回复: [PATCH v3 1/2] dt-bindings: arm: cix: add OrangePi 6 Plus board

Quoted 60 lines · Gary Yang

Hi Krzysztof:

Thanks for your comments

Quoted 56 lines

EXTERNAL EMAIL

Quoted 22 lines · Gary Yang

OrangePi 6 Plus adopts CIX CD8180/CD8160 SoC, built-in 12-core 64-bit processor + NPU processor,integrated graphics processor, equipped with 16GB/32GB/64GB LPDDR5, and provides two M.2 KEY-M interfaces 2280 for NVMe SSD,as well as SPI FLASH and TF slots to meet the needs of fast read/write and high-capacity storage

---
 Documentation/devicetree/bindings/arm/cix.yaml | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/arm/cix.yaml +1 -1
index 114dab4bc4d2..9e132e609b7b 100644
@@ -16,9 +16,16 @@ properties:
   compatible:
     oneOf:
 
-      - description: Radxa Orion O6
+      - description: Radxa Orion O6 board

Documentation/devicetree/bindings/arm/cix.yaml properties: · line 28

Quoted 10 lines
Documentation/devicetree/bindings/arm/cix.yaml +8 -1
         items:
-          - const: radxa,orion-o6
+          - enum:
+              - radxa,orion-o6
+          - const: cix,sky1
+
+      - description: Xunlong orangepi 6 plus board
+        items:
+          - enum:
+              - xunlong,orangepi-6-plus

Previous patch was correct, not this one.

<form letter>
This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions of patchset, under or above your Signed-off-by tag, unless patch changed significantly (e.g. new properties added to the DT bindings). Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply.

Please read:
https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/sub
mitting-patches.rst#L577

Quoted 8 lines
Quoted 6 lines

If a tag was not added on purpose, please state why and what changed. </form letter>

Read last sentence and linked documentation. Where did you explain ignoring/dropping my tag?

Yes, the previous version was acked by you before.

I stressed what I expect twice. In form letter and later explicitly. You still ignored it.

Quoted 12 lines

When apply it, we found that orangepi 6 plus and Radxa Orion O6 belongs the different boards.

So we need to add a new item for it. Like these from qcom.yaml

- description: Qualcomm Technologies, Inc. Distributed Unit 1000 platform items:
- enum:
- qcom,qdu1000-idp
- qcom,qdu1000-x100
- const: qcom,qdu1000

Quoted 5 lines

- description: Qualcomm Technologies, Inc. Radio Unit 1000 platform items:
- enum:
- qcom,qru1000-idp
- const: qcom,qru1000

No, look at SoCs. Different SocS.

Best regards,
Krzysztof

author maintainer
#5 lore raw

回复: 回复: [PATCH v3 1/2] dt-bindings: arm: cix: add OrangePi 6 Plus board

Hi Krzysztof:

Thanks for your comments

Quoted 91 lines

EXTERNAL EMAIL

Quoted 53 lines · Gary Yang

Hi Krzysztof:

Thanks for your comments

Quoted 49 lines

EXTERNAL EMAIL

Quoted 22 lines · Gary Yang

OrangePi 6 Plus adopts CIX CD8180/CD8160 SoC, built-in 12-core 64-bit processor + NPU processor,integrated graphics processor, equipped with 16GB/32GB/64GB LPDDR5, and provides two M.2 KEY-M interfaces 2280 for NVMe SSD,as well as SPI FLASH and TF slots to meet the needs of fast read/write and high-capacity storage

---
 Documentation/devicetree/bindings/arm/cix.yaml | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/arm/cix.yaml +1 -1
index 114dab4bc4d2..9e132e609b7b 100644
@@ -16,9 +16,16 @@ properties:
   compatible:
     oneOf:
 
-      - description: Radxa Orion O6
+      - description: Radxa Orion O6 board

Documentation/devicetree/bindings/arm/cix.yaml properties: · line 28

Quoted 10 lines
Documentation/devicetree/bindings/arm/cix.yaml +8 -1
         items:
-          - const: radxa,orion-o6
+          - enum:
+              - radxa,orion-o6
+          - const: cix,sky1
+
+      - description: Xunlong orangepi 6 plus board
+        items:
+          - enum:
+              - xunlong,orangepi-6-plus

Previous patch was correct, not this one.

<form letter>
This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions of patchset, under or above your Signed-off-by tag, unless patch changed significantly (e.g. new properties added to the DT bindings). Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no

need to repost patches *only* to add the tags.

Quoted 8 lines
Quoted 8 lines

The upstream maintainer will do that for tags received on the version they apply.

Please read:
https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/proce
ss/sub
mitting-patches.rst#L577

Quoted 8 lines
Quoted 6 lines

If a tag was not added on purpose, please state why and what changed. </form letter>

Read last sentence and linked documentation. Where did you explain ignoring/dropping my tag?

Yes, the previous version was acked by you before.

I stressed what I expect twice. In form letter and later explicitly. You still ignored it.

Quoted 2 lines

When apply it, we found that orangepi 6 plus and Radxa Orion O6 belongs

the different boards.

Quoted 4 lines

So we need to add a new item for it. Like these from qcom.yaml

- description: Qualcomm Technologies, Inc. Distributed Unit 1000

platform

Quoted 6 lines

items:
- enum:
- qcom,qdu1000-idp
- qcom,qdu1000-x100
- const: qcom,qdu1000

Quoted 8 lines
Quoted 5 lines

- description: Qualcomm Technologies, Inc. Radio Unit 1000 platform items:
- enum:
- qcom,qru1000-idp
- const: qcom,qru1000

No, look at SoCs. Different SocS.

Please Look at rockchip.yaml, the same Socs, and the different boards

- description: 96boards RK3399 Ficus (ROCK960 Enterprise Edition) items:
- const: vamrs,ficus
- const: rockchip,rk3399

- description: 96boards RK3399 Rock960 (ROCK960 Consumer Edition) items:
- const: vamrs,rock960
- const: rockchip,rk3399

For the different boards,please give your professional suggestions,Thanks a lot

Best Regards
Gary

Quoted 3 lines

Best regards,
Krzysztof

#6 lore raw

Re: 回复: 回复: [PATCH v3 1/2] dt-bindings: arm: cix: add OrangePi 6 Plus board

Quoted 111 lines · Gary Yang

Hi Krzysztof:

Thanks for your comments

Quoted 91 lines

EXTERNAL EMAIL

Quoted 53 lines · Gary Yang

Hi Krzysztof:

Thanks for your comments

Quoted 49 lines

EXTERNAL EMAIL

Quoted 22 lines · Gary Yang

OrangePi 6 Plus adopts CIX CD8180/CD8160 SoC, built-in 12-core 64-bit processor + NPU processor,integrated graphics processor, equipped with 16GB/32GB/64GB LPDDR5, and provides two M.2 KEY-M interfaces 2280 for NVMe SSD,as well as SPI FLASH and TF slots to meet the needs of fast read/write and high-capacity storage

---
 Documentation/devicetree/bindings/arm/cix.yaml | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/arm/cix.yaml +1 -1
index 114dab4bc4d2..9e132e609b7b 100644
@@ -16,9 +16,16 @@ properties:
   compatible:
     oneOf:
 
-      - description: Radxa Orion O6
+      - description: Radxa Orion O6 board

Documentation/devicetree/bindings/arm/cix.yaml properties: · line 28

Quoted 10 lines
Documentation/devicetree/bindings/arm/cix.yaml +8 -1
         items:
-          - const: radxa,orion-o6
+          - enum:
+              - radxa,orion-o6
+          - const: cix,sky1
+
+      - description: Xunlong orangepi 6 plus board
+        items:
+          - enum:
+              - xunlong,orangepi-6-plus

Previous patch was correct, not this one.

<form letter>
This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions of patchset, under or above your Signed-off-by tag, unless patch changed significantly (e.g. new properties added to the DT bindings). Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no

need to repost patches *only* to add the tags.

Quoted 8 lines
Quoted 8 lines

The upstream maintainer will do that for tags received on the version they apply.

Please read:
https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/proce
ss/sub
mitting-patches.rst#L577

Quoted 8 lines
Quoted 6 lines

If a tag was not added on purpose, please state why and what changed. </form letter>

Read last sentence and linked documentation. Where did you explain ignoring/dropping my tag?

Yes, the previous version was acked by you before.

I stressed what I expect twice. In form letter and later explicitly. You still ignored it.

Quoted 2 lines

When apply it, we found that orangepi 6 plus and Radxa Orion O6 belongs

the different boards.

Quoted 4 lines

So we need to add a new item for it. Like these from qcom.yaml

- description: Qualcomm Technologies, Inc. Distributed Unit 1000

platform

Quoted 6 lines

items:
- enum:
- qcom,qdu1000-idp
- qcom,qdu1000-x100
- const: qcom,qdu1000

Quoted 8 lines
Quoted 5 lines

- description: Qualcomm Technologies, Inc. Radio Unit 1000 platform items:
- enum:
- qcom,qru1000-idp
- const: qcom,qru1000

No, look at SoCs. Different SocS.

Please Look at rockchip.yaml, the same Socs, and the different boards

- description: 96boards RK3399 Ficus (ROCK960 Enterprise Edition) items:
- const: vamrs,ficus
- const: rockchip,rk3399

Quoted 6 lines

- description: 96boards RK3399 Rock960 (ROCK960 Consumer Edition) items:
- const: vamrs,rock960
- const: rockchip,rk3399

For the different boards,please give your professional suggestions,Thanks a lot

I gave you already.

Best regards,
Krzysztof

author maintainer
#7 lore raw

回复: 回复: 回复: [PATCH v3 1/2] dt-bindings: arm: cix: add OrangePi 6 Plus board

Hi Krzysztof:

Thanks for you commets

Quoted 121 lines

EXTERNAL EMAIL

Quoted 100 lines · Gary Yang

Hi Krzysztof:

Thanks for your comments

Quoted 96 lines

EXTERNAL EMAIL

Quoted 54 lines · Gary Yang

Hi Krzysztof:

Thanks for your comments

Quoted 50 lines

EXTERNAL EMAIL

Quoted 22 lines · Gary Yang

OrangePi 6 Plus adopts CIX CD8180/CD8160 SoC, built-in 12-core 64-bit processor + NPU processor,integrated graphics processor, equipped with 16GB/32GB/64GB LPDDR5, and provides two M.2 KEY-M interfaces 2280 for NVMe SSD,as well as SPI FLASH and TF slots to meet the needs of fast read/write and high-capacity storage

---
 Documentation/devicetree/bindings/arm/cix.yaml | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/arm/cix.yaml +1 -1
index 114dab4bc4d2..9e132e609b7b 100644
@@ -16,9 +16,16 @@ properties:
   compatible:
     oneOf:
 
-      - description: Radxa Orion O6
+      - description: Radxa Orion O6 board

Documentation/devicetree/bindings/arm/cix.yaml properties: · line 28

Quoted 10 lines
Documentation/devicetree/bindings/arm/cix.yaml +8 -1
         items:
-          - const: radxa,orion-o6
+          - enum:
+              - radxa,orion-o6
+          - const: cix,sky1
+
+      - description: Xunlong orangepi 6 plus board
+        items:
+          - enum:
+              - xunlong,orangepi-6-plus

Previous patch was correct, not this one.

<form letter>
This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions of patchset, under or above your Signed-off-by tag, unless patch changed significantly (e.g. new properties added to the DT bindings). Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no

need to repost patches *only* to add the tags.

Quoted 9 lines
Quoted 9 lines

The upstream maintainer will do that for tags received on the version they apply.

Please read:
https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/pro
ce
ss/sub
mitting-patches.rst#L577

Quoted 8 lines
Quoted 6 lines

If a tag was not added on purpose, please state why and what changed. </form letter>

Read last sentence and linked documentation. Where did you explain ignoring/dropping my tag?

Yes, the previous version was acked by you before.

I stressed what I expect twice. In form letter and later explicitly. You still ignored it.

Quoted 3 lines

When apply it, we found that orangepi 6 plus and Radxa Orion O6 belongs

the different boards.

Quoted 5 lines

So we need to add a new item for it. Like these from qcom.yaml

- description: Qualcomm Technologies, Inc. Distributed Unit
1000

platform

Quoted 7 lines

items:
- enum:
- qcom,qdu1000-idp
- qcom,qdu1000-x100
- const: qcom,qdu1000

- description: Qualcomm Technologies, Inc. Radio Unit 1000

platform

Quoted 8 lines
Quoted 7 lines
Quoted 4 lines

items:
- enum:
- qcom,qru1000-idp
- const: qcom,qru1000

No, look at SoCs. Different SocS.

Quoted 8 lines

Please Look at rockchip.yaml, the same Socs, and the different boards

- description: 96boards RK3399 Ficus (ROCK960 Enterprise Edition) items:
- const: vamrs,ficus
- const: rockchip,rk3399

- description: 96boards RK3399 Rock960 (ROCK960 Consumer

Edition)

Quoted 9 lines
Quoted 6 lines

items:
- const: vamrs,rock960
- const: rockchip,rk3399

For the different boards,please give your professional suggestions,Thanks a lot

I gave you already.

We find these codes below from qcom.yaml, Can we do the same things?

- description: Acer Chromebook Spin 513 with LTE (rev1 - 2) items:
- const: google,lazor-rev1-sku0
- const: google,lazor-rev2-sku0
- const: qcom,sc7180

- description: Acer Chromebook Spin 513 with LTE (rev3 - 8) items:
- const: google,lazor-rev3-sku0
- const: google,lazor-rev4-sku0
- const: google,lazor-rev5-sku0
- const: google,lazor-rev6-sku0
- const: google,lazor-rev7-sku0
- const: google,lazor-rev8-sku0
- const: qcom,sc7180

- description: Acer Chromebook Spin 513 with LTE (rev9) items:
- const: google,lazor-rev9-sku0
- const: google,lazor-rev9-sku10
- const: qcom,sc7180

- description: Acer Chromebook Spin 513 with LTE (newest rev) items:
- const: google,lazor-sku0
- const: google,lazor-sku10
- const: qcom,sc7180

Best Regards
Gary

Quoted 2 lines

Best regards,
Krzysztof

#8 lore raw

Re: 回复: 回复: 回复: [PATCH v3 1/2] dt-bindings: arm: cix: add OrangePi 6 Plus board

Quoted 129 lines · Gary Yang

Hi Krzysztof:

Thanks for you commets

Quoted 125 lines

EXTERNAL EMAIL

Quoted 100 lines · Gary Yang

Hi Krzysztof:

Thanks for your comments

Quoted 96 lines

EXTERNAL EMAIL

Quoted 54 lines · Gary Yang

Hi Krzysztof:

Thanks for your comments

Quoted 50 lines

EXTERNAL EMAIL

Quoted 22 lines · Gary Yang

OrangePi 6 Plus adopts CIX CD8180/CD8160 SoC, built-in 12-core 64-bit processor + NPU processor,integrated graphics processor, equipped with 16GB/32GB/64GB LPDDR5, and provides two M.2 KEY-M interfaces 2280 for NVMe SSD,as well as SPI FLASH and TF slots to meet the needs of fast read/write and high-capacity storage

---
 Documentation/devicetree/bindings/arm/cix.yaml | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/arm/cix.yaml +1 -1
index 114dab4bc4d2..9e132e609b7b 100644
@@ -16,9 +16,16 @@ properties:
   compatible:
     oneOf:
 
-      - description: Radxa Orion O6
+      - description: Radxa Orion O6 board

Documentation/devicetree/bindings/arm/cix.yaml properties: · line 28

Quoted 10 lines
Documentation/devicetree/bindings/arm/cix.yaml +8 -1
         items:
-          - const: radxa,orion-o6
+          - enum:
+              - radxa,orion-o6
+          - const: cix,sky1
+
+      - description: Xunlong orangepi 6 plus board
+        items:
+          - enum:
+              - xunlong,orangepi-6-plus

Previous patch was correct, not this one.

<form letter>
This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions of patchset, under or above your Signed-off-by tag, unless patch changed significantly (e.g. new properties added to the DT bindings). Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no

need to repost patches *only* to add the tags.

Quoted 9 lines
Quoted 9 lines

The upstream maintainer will do that for tags received on the version they apply.

Please read:
https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/pro
ce
ss/sub
mitting-patches.rst#L577

Quoted 8 lines
Quoted 6 lines

If a tag was not added on purpose, please state why and what changed. </form letter>

Read last sentence and linked documentation. Where did you explain ignoring/dropping my tag?

Yes, the previous version was acked by you before.

I stressed what I expect twice. In form letter and later explicitly. You still ignored it.

Quoted 3 lines

When apply it, we found that orangepi 6 plus and Radxa Orion O6 belongs

the different boards.

Quoted 5 lines

So we need to add a new item for it. Like these from qcom.yaml

- description: Qualcomm Technologies, Inc. Distributed Unit
1000

platform

Quoted 7 lines

items:
- enum:
- qcom,qdu1000-idp
- qcom,qdu1000-x100
- const: qcom,qdu1000

- description: Qualcomm Technologies, Inc. Radio Unit 1000

platform

Quoted 8 lines
Quoted 7 lines
Quoted 4 lines

items:
- enum:
- qcom,qru1000-idp
- const: qcom,qru1000

No, look at SoCs. Different SocS.

Quoted 8 lines

Please Look at rockchip.yaml, the same Socs, and the different boards

- description: 96boards RK3399 Ficus (ROCK960 Enterprise Edition) items:
- const: vamrs,ficus
- const: rockchip,rk3399

- description: 96boards RK3399 Rock960 (ROCK960 Consumer

Edition)

Quoted 4 lines

items:
- const: vamrs,rock960
- const: rockchip,rk3399

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

For the different boards,please give your professional suggestions,Thanks a lot

I gave you already.

We find these codes below from qcom.yaml, Can we do the same things?

Open your binding. How many SKUs you have? ZERO.

Why do you ask if you can add more SKUs? To make the bindings fake? I already told you what you have to do and you completely ignored it. Previous code was correct, but you need to fix description. And look how Qualcomm or IMX organizes this file.

I finished responding here, because you just don't bother to read my replies.

Best regards,
Krzysztof

author maintainer
#9 lore raw

PATCH v3 2/2 arm64: dts: cix: Add OrangePi 6 Plus board support

In reply to Gary Yang

OrangePi 6 Plus adopts CIX CD8180/CD8160 SoC, built-in 12-core 64-bit processor + NPU processor,integrated graphics processor, equipped with 16GB/32GB/64GB LPDDR5, and provides two M.2 KEY-M interfaces 2280 for NVMe SSD,as well as SPI FLASH and TF slots to meet the needs of fast read/write and high-capacity storage

---
 arch/arm64/boot/dts/cix/Makefile     |  1 +
 arch/arm64/boot/dts/cix/sky1-xcp.dts | 83 ++++++++++++++++++++++++++++
 2 files changed, 84 insertions(+)
 create mode 100644 arch/arm64/boot/dts/cix/sky1-xcp.dts
arch/arm64/boot/dts/cix/Makefile +1 -0
index ed3713982012..8a6c6fdc4ec0 100644
@@ -1,2 +1,3 @@
 # SPDX-License-Identifier: GPL-2.0
 dtb-$(CONFIG_ARCH_CIX) += sky1-orion-o6.dtb
+dtb-$(CONFIG_ARCH_CIX) += sky1-xcp.dtb
arch/arm64/boot/dts/cix/sky1-xcp.dts new file +83 -0

83 lines not on this page · raw message

Signature · 1 line
2.49.0