BPF packet scheduler updates part 4
Subsystems (5)
v3 cover BPF packet scheduler updates part 4
v3:
- store burst in msk->snd_burst instead of in sk_storage.
- make mptcp_sched_data_set_contexts static.
- rename mptcp_subflow_ctx_by_pos to bpf_mptcp_subflow_ctx_by_pos, and add "__bpf_kfunc" before it.
v2:
- keep sched API unchanged.
- use bpf_sk_storage_lookup to get snd_burst from BPF context.
- applied after "add bpf_stale scheduler v3" serise.
v1:
There's a bug in bpf_burst. snd_burst stored in mptcp_burst_storage in BPF context is not used. msk->snd_burst is still used in kernel space. To fix this, add two new interfaces in mptcp_sched_ops to get and set scheduler's paramters from BPF context to kernel space.
Geliang Tang (9):
Squash to "bpf: Export more bpf_burst related functions" Squash to "mptcp: add sched_data helpers" Squash to "bpf: Add bpf_mptcp_sched_ops"
Squash to "selftests/bpf: Add mptcp sched structs" Squash to "selftests/bpf: Add bpf_first scheduler" Squash to "selftests/bpf: Add bpf_bkup scheduler" Squash to "selftests/bpf: Add bpf_rr scheduler" Squash to "selftests/bpf: Add bpf_red scheduler" Squash to "selftests/bpf: Add bpf_burst scheduler"
net/mptcp/bpf.c | 41 +++++++++++---- net/mptcp/protocol.h | 6 +-- net/mptcp/sched.c | 50 ++++++++----------- tools/testing/selftests/bpf/bpf_tcp_helpers.h | 5 +- .../selftests/bpf/progs/mptcp_bpf_bkup.c | 6 +-- .../selftests/bpf/progs/mptcp_bpf_burst.c | 30 ++--------- .../selftests/bpf/progs/mptcp_bpf_first.c | 3 +- .../selftests/bpf/progs/mptcp_bpf_red.c | 6 +-- .../selftests/bpf/progs/mptcp_bpf_rr.c | 9 ++-- 9 files changed, 70 insertions(+), 86 deletions(-)
Signature · 1 line
2.35.3
PATCH v3 1/9 Squash to "bpf: Export more bpf_burst related functions"
Add __bpf_kfunc before bpf_mptcp_subflow_queues_empty(), drop __diag_*, it will be added in the next patch.
--- net/mptcp/bpf.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)
net/mptcp/bpf.c +1 -7
@@ -163,17 +163,11 @@ static const struct btf_kfunc_id_set bpf_mptcp_fmodret_set = { .set = &bpf_mptcp_fmodret_ids, }; -__diag_push (); -__diag_ignore_all ("-Wmissing-prototypes" , -"kfuncs which will be used in BPF programs" ); - -bool bpf_mptcp_subflow_queues_empty (struct sock *sk) +__bpf_kfunc bool bpf_mptcp_subflow_queues_empty(struct sock *sk) {return tcp_rtx_queue_empty (sk); } -__diag_pop (); - BTF_SET8_START(bpf_mptcp_sched_kfunc_ids) BTF_ID_FLAGS(func, mptcp_subflow_set_scheduled) BTF_ID_FLAGS(func, mptcp_sched_data_set_contexts)
Signature · 1 line
2.35.3
PATCH v3 2/9 Squash to "mptcp: add sched_data helpers"
In reply to Geliang TangChange mptcp_sched_data_set_contexts as static function. Rename mptcp_subflow_ctx_by_pos with bpf_ prefix, move it into bpf.c in __diag_* section.
--- net/mptcp/bpf.c | 17 +++++++++++++-- net/mptcp/protocol.h | 6 ++---- net/mptcp/sched.c | 50 +++++++++++++++++++------------------------- 3 files changed, 39 insertions(+), 34 deletions(-)
net/mptcp/bpf.c +15 -2
@@ -163,15 +163,28 @@ static const struct btf_kfunc_id_set bpf_mptcp_fmodret_set = { .set = &bpf_mptcp_fmodret_ids, }; +__diag_push (); +__diag_ignore_all ("-Wmissing-prototypes" , +"kfuncs which will be used in BPF programs" ); + +__bpf_kfunc struct mptcp_subflow_context * +bpf_mptcp_subflow_ctx_by_pos (const struct mptcp_sched_data *data,unsigned int pos) +{ +if (pos >=MPTCP_SUBFLOWS_MAX ) +return NULL ; +return data->contexts[pos]; +} + __bpf_kfunc bool bpf_mptcp_subflow_queues_empty(struct sock *sk) {return tcp_rtx_queue_empty (sk); } +__diag_pop (); + BTF_SET8_START(bpf_mptcp_sched_kfunc_ids) BTF_ID_FLAGS(func, mptcp_subflow_set_scheduled) -BTF_ID_FLAGS(func, mptcp_sched_data_set_contexts) -BTF_ID_FLAGS(func, mptcp_subflow_ctx_by_pos) +BTF_ID_FLAGS(func, bpf_mptcp_subflow_ctx_by_pos) BTF_ID_FLAGS(func, mptcp_subflow_active) BTF_ID_FLAGS(func, mptcp_set_timeout) BTF_ID_FLAGS(func, mptcp_wnd_end)
net/mptcp/protocol.h +2 -4
@@ -643,6 +643,8 @@ void mptcp_sock_graft(struct sock *sk, struct socket *parent);u64 mptcp_wnd_end (const struct mptcp_sock *msk);void mptcp_set_timeout (struct sock *sk);bool bpf_mptcp_subflow_queues_empty (struct sock *sk); +struct mptcp_subflow_context * +bpf_mptcp_subflow_ctx_by_pos (const struct mptcp_sched_data *data,unsigned int pos);struct sock *__mptcp_nmpc_sk (struct mptcp_sock *msk);bool __mptcp_close (struct sock *sk,long timeout);void mptcp_cancel_work (struct sock *sk);
@@ -674,10 +676,6 @@ struct sock *mptcp_subflow_get_send(struct mptcp_sock *msk);struct sock *mptcp_subflow_get_retrans (struct mptcp_sock *msk);int mptcp_sched_get_send (struct mptcp_sock *msk);int mptcp_sched_get_retrans (struct mptcp_sock *msk); -void mptcp_sched_data_set_contexts (const struct mptcp_sock *msk, -struct mptcp_sched_data *data); -struct mptcp_subflow_context * -mptcp_subflow_ctx_by_pos (const struct mptcp_sched_data *data,unsigned int pos);static inline bool __tcp_can_send (const struct sock *ssk) {
net/mptcp/sched.c +22 -28
67 lines not on this page · raw message
Signature · 1 line
2.35.3
PATCH v3 3/9 Squash to "bpf: Add bpf_mptcp_sched_ops"
In reply to Geliang TangAdd write acess to msk->snd_burst.
--- net/mptcp/bpf.c | 28 ++++++++++++++++++++-------- 1 file changed, 20 insertions(+), 8 deletions(-)
net/mptcp/bpf.c +20 -8
@@ -18,8 +18,8 @@#ifdef CONFIG_BPF_JIT extern struct bpf_struct_ops bpf_mptcp_sched_ops; -static const struct btf_type *mptcp_sched_type__read_mostly ; -static u32 mptcp_sched_id; +static const struct btf_type *mptcp_sock_type, *mptcp_subflow_type__read_mostly ; +static u32 mptcp_sock_id, mptcp_subflow_id;static const struct bpf_func_proto * bpf_mptcp_sched_get_func_proto(enum bpf_func_id func_id,
@@ -47,12 +47,15 @@ static int bpf_mptcp_sched_btf_struct_access(struct bpf_verifier_log *log,size_t end; t =btf_type_by_id (reg->btf, reg->btf_id); -if (t != mptcp_sched_type) { -bpf_log (log,"only access to mptcp_subflow_context is supported\n" ); +if (t != mptcp_sock_type && t != mptcp_subflow_type) { +bpf_log (log,"only access to mptcp sock or subflow is supported\n" );return -EACCES ; }switch (off) { +case offsetof(struct mptcp_sock , snd_burst): + end = offsetofend(struct mptcp_sock, snd_burst); +break ;case offsetof(struct mptcp_subflow_context , scheduled): end = offsetofend(struct mptcp_subflow_context, scheduled);break ;
@@ -60,12 +63,14 @@ static int bpf_mptcp_sched_btf_struct_access(struct bpf_verifier_log *log, end = offsetofend(struct mptcp_subflow_context, avg_pacing_rate);break ;default : -bpf_log (log,"no write support to mptcp_subflow_context at off %d\n" , off); +bpf_log (log,"no write support to %s at off %d\n" , + t == mptcp_sock_type ?"mptcp_sock" :"mptcp_subflow_context" , off);return -EACCES ; }if (off + size > end) { -bpf_log (log,"access beyond mptcp_subflow_context at off %u size %u ended at %zu" , +bpf_log (log,"access beyond %s at off %u size %u ended at %zu" , + t == mptcp_sock_type ?"mptcp_sock" :"mptcp_subflow_context" , off, size, end);return -EACCES ; }
@@ -125,12 +130,19 @@ static int bpf_mptcp_sched_init(struct btf *btf) {s32 type_id; + type_id =btf_find_by_name_kind (btf,"mptcp_sock" , +BTF_KIND_STRUCT ); +if (type_id <0 ) +return -EINVAL ; + mptcp_sock_id = type_id; + mptcp_sock_type =btf_type_by_id (btf, mptcp_sock_id); + type_id =btf_find_by_name_kind (btf,"mptcp_subflow_context" ,BTF_KIND_STRUCT );if (type_id <0 )return -EINVAL ; - mptcp_sched_id = type_id; - mptcp_sched_type =btf_type_by_id (btf, mptcp_sched_id); + mptcp_subflow_id = type_id; + mptcp_subflow_type =btf_type_by_id (btf, mptcp_subflow_id);return 0 ; }
Signature · 1 line
2.35.3
PATCH v3 4/9 Squash to "selftests/bpf: Add mptcp sched structs"
In reply to Geliang TangUpdate mptcp_sched_data_set_contexts and mptcp_subflow_ctx_by_pos.
--- tools/testing/selftests/bpf/bpf_tcp_helpers.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
tools/testing/selftests/bpf/bpf_tcp_helpers.h +1 -3
@@ -269,10 +269,8 @@ struct mptcp_sock { extern void mptcp_subflow_set_scheduled(struct mptcp_subflow_context *subflow, bool scheduled) __ksym; -extern void mptcp_sched_data_set_contexts(const struct mptcp_sock *msk, - struct mptcp_sched_data *data) __ksym;extern struct mptcp_subflow_context * -mptcp_subflow_ctx_by_pos (const struct mptcp_sched_data *data,unsigned int pos) __ksym; +bpf_mptcp_subflow_ctx_by_pos (const struct mptcp_sched_data *data,unsigned int pos) __ksym; static __always_inline struct sock *mptcp_subflow_tcp_sock (const struct mptcp_subflow_context *subflow) {
Signature · 1 line
2.35.3
PATCH v3 5/9 Squash to "selftests/bpf: Add bpf_first scheduler"
In reply to Geliang TangUpdate mptcp_sched_data_set_contexts and mptcp_subflow_ctx_by_pos.
--- tools/testing/selftests/bpf/progs/mptcp_bpf_first.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
tools/testing/selftests/bpf/progs/mptcp_bpf_first.c +1 -2
@@ -19,8 +19,7 @@ void BPF_PROG(mptcp_sched_first_release, struct mptcp_sock *msk)int BPF_STRUCT_OPS (bpf_first_get_subflow ,struct mptcp_sock *msk,struct mptcp_sched_data *data) { -mptcp_sched_data_set_contexts (msk, data); -mptcp_subflow_set_scheduled (mptcp_subflow_ctx_by_pos (data,0 ), true); +mptcp_subflow_set_scheduled (bpf_mptcp_subflow_ctx_by_pos (data,0 ), true);return 0 ; }
Signature · 1 line
2.35.3
PATCH v3 6/9 Squash to "selftests/bpf: Add bpf_bkup scheduler"
In reply to Geliang TangUpdate mptcp_sched_data_set_contexts and mptcp_subflow_ctx_by_pos.
--- tools/testing/selftests/bpf/progs/mptcp_bpf_bkup.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
tools/testing/selftests/bpf/progs/mptcp_bpf_bkup.c +2 -4
@@ -21,12 +21,10 @@ int BPF_STRUCT_OPS(bpf_bkup_get_subflow, struct mptcp_sock *msk, {int nr =-1 ; -mptcp_sched_data_set_contexts (msk, data); -for (int i =0 ; i < data->subflows && i <MPTCP_SUBFLOWS_MAX ; i++) {struct mptcp_subflow_context *subflow; - subflow =mptcp_subflow_ctx_by_pos (data, i); + subflow =bpf_mptcp_subflow_ctx_by_pos (data, i);if (!subflow)break ;
@@ -37,7 +35,7 @@ int BPF_STRUCT_OPS(bpf_bkup_get_subflow, struct mptcp_sock *msk, }if (nr !=-1 ) { -mptcp_subflow_set_scheduled (mptcp_subflow_ctx_by_pos (data, nr), true); +mptcp_subflow_set_scheduled (bpf_mptcp_subflow_ctx_by_pos (data, nr), true);return -1 ; }return 0 ;
Signature · 1 line
2.35.3
PATCH v3 7/9 Squash to "selftests/bpf: Add bpf_rr scheduler"
In reply to Geliang TangUpdate mptcp_sched_data_set_contexts and mptcp_subflow_ctx_by_pos.
--- tools/testing/selftests/bpf/progs/mptcp_bpf_rr.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)
tools/testing/selftests/bpf/progs/mptcp_bpf_rr.c +4 -5
@@ -45,15 +45,14 @@ int BPF_STRUCT_OPS(bpf_rr_get_subflow, struct mptcp_sock *msk, last_snd = ptr->last_snd; -mptcp_sched_data_set_contexts (msk, data); -for (int i =0 ; i < data->subflows && i <MPTCP_SUBFLOWS_MAX ; i++) { - subflow =mptcp_subflow_ctx_by_pos (data, i); + subflow =bpf_mptcp_subflow_ctx_by_pos (data, i);if (!last_snd || !subflow)break ;if (mptcp_subflow_tcp_sock (subflow) == last_snd) { -if (i +1 ==MPTCP_SUBFLOWS_MAX || !mptcp_subflow_ctx_by_pos (data, i +1 )) +if (i +1 ==MPTCP_SUBFLOWS_MAX || + !bpf_mptcp_subflow_ctx_by_pos (data, i +1 ))break ; nr = i +1 ;
@@ -61,7 +60,7 @@ int BPF_STRUCT_OPS(bpf_rr_get_subflow, struct mptcp_sock *msk, } } - subflow =mptcp_subflow_ctx_by_pos (data, nr); + subflow =bpf_mptcp_subflow_ctx_by_pos (data, nr);if (!subflow)return -1 ;mptcp_subflow_set_scheduled (subflow, true);
Signature · 1 line
2.35.3
PATCH v3 8/9 Squash to "selftests/bpf: Add bpf_red scheduler"
In reply to Geliang TangUpdate mptcp_sched_data_set_contexts and mptcp_subflow_ctx_by_pos.
--- tools/testing/selftests/bpf/progs/mptcp_bpf_red.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
tools/testing/selftests/bpf/progs/mptcp_bpf_red.c +2 -4
@@ -19,13 +19,11 @@ void BPF_PROG(mptcp_sched_red_release, struct mptcp_sock *msk)int BPF_STRUCT_OPS (bpf_red_get_subflow ,struct mptcp_sock *msk,struct mptcp_sched_data *data) { -mptcp_sched_data_set_contexts (msk, data); -for (int i =0 ; i < data->subflows && i <MPTCP_SUBFLOWS_MAX ; i++) { -if (!mptcp_subflow_ctx_by_pos (data, i)) +if (!bpf_mptcp_subflow_ctx_by_pos (data, i))break ; -mptcp_subflow_set_scheduled (mptcp_subflow_ctx_by_pos (data, i), true); +mptcp_subflow_set_scheduled (bpf_mptcp_subflow_ctx_by_pos (data, i), true); }return 0 ;
Signature · 1 line
2.35.3
PATCH v3 9/9 Squash to "selftests/bpf: Add bpf_burst scheduler"
In reply to Geliang TangUpdate mptcp_sched_data_set_contexts and mptcp_subflow_ctx_by_pos.
Store burst in msk->snd_burst instead of in sk_storage.
--- tools/testing/selftests/bpf/bpf_tcp_helpers.h | 1 + .../selftests/bpf/progs/mptcp_bpf_burst.c | 30 ++++--------------- 2 files changed, 6 insertions(+), 25 deletions(-)
tools/testing/selftests/bpf/bpf_tcp_helpers.h +1 -0
@@ -262,6 +262,7 @@ struct mptcp_sock {struct inet_connection_sock sk;__u64 snd_nxt; +int snd_burst;__u32 token;struct sock *first;char ca_name[TCP_CA_NAME_MAX ];
tools/testing/selftests/bpf/progs/mptcp_bpf_burst.c +5 -25
@@ -7,17 +7,6 @@ char _license[] SEC("license") = "GPL"; -struct mptcp_burst_storage { -int snd_burst; -}; - -struct { - __uint(type, BPF_MAP_TYPE_SK_STORAGE); - __uint(map_flags, BPF_F_NO_PREALLOC); - __type(key, int); - __type(value, struct mptcp_burst_storage); -} mptcp_burst_map SEC(".maps"); -#define MPTCP_SEND_BURST_SIZE 65428struct subflow_send_info {
@@ -69,14 +58,11 @@ static __always_inline bool sk_stream_memory_free(const struct sock *sk) SEC("struct_ops/mptcp_sched_burst_init")void BPF_PROG (mptcp_sched_burst_init ,struct mptcp_sock *msk) { -bpf_sk_storage_get (&mptcp_burst_map, msk,0 , -BPF_LOCAL_STORAGE_GET_F_CREATE ); } SEC("struct_ops/mptcp_sched_burst_release")void BPF_PROG (mptcp_sched_burst_release ,struct mptcp_sock *msk) { -bpf_sk_storage_delete (&mptcp_burst_map, msk); } static int bpf_burst_get_send(struct mptcp_sock *msk,
@@ -85,7 +71,6 @@ static int bpf_burst_get_send(struct mptcp_sock *msk,struct subflow_send_info send_info[SSK_MODE_MAX ];struct mptcp_subflow_context *subflow;struct sock *sk = (struct sock *)msk; -struct mptcp_burst_storage *ptr;__u32 pace, burst, wmem;__u64 linger_time;struct sock *ssk;
@@ -98,7 +83,7 @@ static int bpf_burst_get_send(struct mptcp_sock *msk, }for (i =0 ; i < data->subflows && i <MPTCP_SUBFLOWS_MAX ; i++) { - subflow =mptcp_subflow_ctx_by_pos (data, i); + subflow =bpf_mptcp_subflow_ctx_by_pos (data, i);if (!subflow)break ;
@@ -127,7 +112,7 @@ static int bpf_burst_get_send(struct mptcp_sock *msk,if (send_info[SSK_MODE_ACTIVE ].subflow_id ==MPTCP_SUBFLOWS_MAX ) send_info[SSK_MODE_ACTIVE ].subflow_id = send_info[SSK_MODE_BACKUP ].subflow_id; - subflow =mptcp_subflow_ctx_by_pos (data, send_info[SSK_MODE_ACTIVE ].subflow_id); + subflow =bpf_mptcp_subflow_ctx_by_pos (data, send_info[SSK_MODE_ACTIVE ].subflow_id);if (!subflow)return -1 ; ssk =mptcp_subflow_tcp_sock (subflow);
@@ -142,10 +127,7 @@ static int bpf_burst_get_send(struct mptcp_sock *msk, subflow->avg_pacing_rate =div_u64 ((__u64 )subflow->avg_pacing_rate * wmem + ssk->sk_pacing_rate * burst, burst + wmem); - ptr =bpf_sk_storage_get (&mptcp_burst_map, msk,0 , -BPF_LOCAL_STORAGE_GET_F_CREATE ); -if (ptr) - ptr->snd_burst = burst; + msk->snd_burst = burst; out:mptcp_subflow_set_scheduled (subflow, true);
@@ -161,7 +143,7 @@ static int bpf_burst_get_retrans(struct mptcp_sock *msk,struct sock *ssk;for (int i =0 ; i < data->subflows && i <MPTCP_SUBFLOWS_MAX ; i++) { - subflow =mptcp_subflow_ctx_by_pos (data, i); + subflow =bpf_mptcp_subflow_ctx_by_pos (data, i);if (!subflow)break ;
@@ -193,7 +175,7 @@ static int bpf_burst_get_retrans(struct mptcp_sock *msk, subflow_id = min_stale_count >1 ? backup :MPTCP_SUBFLOWS_MAX ; out: - subflow =mptcp_subflow_ctx_by_pos (data, subflow_id); + subflow =bpf_mptcp_subflow_ctx_by_pos (data, subflow_id);if (!subflow)return -1 ;mptcp_subflow_set_scheduled (subflow, true);
@@ -203,8 +185,6 @@ static int bpf_burst_get_retrans(struct mptcp_sock *msk,int BPF_STRUCT_OPS (bpf_burst_get_subflow ,struct mptcp_sock *msk,struct mptcp_sched_data *data) { -mptcp_sched_data_set_contexts (msk, data); -if (data->reinject)return bpf_burst_get_retrans (msk, data);return bpf_burst_get_send (msk, data);
Signature · 1 line
2.35.3
Mat Martineau
maintainerQuoted 6 lines · Geliang Tang
v3:
- store burst inmsk->snd_burstinstead of insk_storage.
- makemptcp_sched_data_set_contextsstatic.
- renamemptcp_subflow_ctx_by_postobpf_mptcp_subflow_ctx_by_pos, and add "__bpf_kfunc" before it.
Hi Geliang -
Apologies for the delay on reviewing these. The series looks good to squash, thanks!
- Mat
Quoted 39 lines
v2:
- keep sched API unchanged.
- usebpf_sk_storage_lookupto getsnd_burstfrom BPF context.
- applied after "addbpf_stalescheduler v3" serise.v1:
There's a bug in
bpf_burst.snd_burststored inmptcp_burst_storagein BPF context is not used.msk->snd_burstis still used in kernel space. To fix this, add two new interfaces inmptcp_sched_opsto get and set scheduler's paramters from BPF context to kernel space.Geliang Tang (9):
Squash to "bpf: Export morebpf_burstrelated functions" Squash to "mptcp: addsched_datahelpers" Squash to "bpf: Addbpf_mptcp_sched_ops"
Squash to "selftests/bpf: Add mptcp sched structs" Squash to "selftests/bpf: Addbpf_firstscheduler" Squash to "selftests/bpf: Addbpf_bkupscheduler" Squash to "selftests/bpf: Addbpf_rrscheduler" Squash to "selftests/bpf: Addbpf_redscheduler" Squash to "selftests/bpf: Addbpf_burstscheduler"net/mptcp/bpf.c | 41 +++++++++++---- net/mptcp/protocol.h | 6 +-- net/mptcp/sched.c | 50 ++++++++----------- tools/testing/selftests/bpf/bpf_tcp_helpers.h | 5 +- .../selftests/bpf/progs/mptcp_bpf_bkup.c | 6 +-- .../selftests/bpf/progs/mptcp_bpf_burst.c | 30 ++--------- .../selftests/bpf/progs/mptcp_bpf_first.c | 3 +- .../selftests/bpf/progs/mptcp_bpf_red.c | 6 +-- .../selftests/bpf/progs/mptcp_bpf_rr.c | 9 ++-- 9 files changed, 70 insertions(+), 86 deletions(-)Signature · 1 line
2.35.3
Hi Geliang, Mat,
Quoted 11 lines · Geliang Tang
v3:
- store burst inmsk->snd_burstinstead of insk_storage.
- makemptcp_sched_data_set_contextsstatic.
- renamemptcp_subflow_ctx_by_postobpf_mptcp_subflow_ctx_by_pos, and add "__bpf_kfunc" before it.v2:
- keep sched API unchanged.
- usebpf_sk_storage_lookupto getsnd_burstfrom BPF context.
- applied after "addbpf_stalescheduler v3" serise.
Quoted 6 lines
v1:
There's a bug in
bpf_burst.snd_burststored inmptcp_burst_storagein BPF context is not used.msk->snd_burstis still used in kernel space. To fix this, add two new interfaces inmptcp_sched_opsto get and set scheduler's paramters from BPF context to kernel space.
Thank you for the patches and the review!
I just applied these patches in our tree. Please make sure I correctly fix the different conflicts and I didn't miss any instructions.
New patches for t/upstream:
- 5eed4d815c41: "squashed" patch 1/9 in "bpf: Export more bpf_burst related functions"
- 764bf652d4bf: "squashed" patch 2/9 (with conflicts) in "mptcp: add sched_data helpers"
- 9906c014e61a: "squashed" patch 3/9 in "bpf: Add bpf_mptcp_sched_ops"
- 816a6f2cad25: conflict in t/bpf-Add-bpf_mptcp_sched_kfunc_set
- ff8a0c543074: "squashed" patch 4/9 (with conflicts) in "selftests/bpf:
Add mptcp sched structs"
- a0098f3f355d: "squashed" patch 5/9 in "selftests/bpf: Add bpf_first scheduler"
- d9c7f7c37051: "squashed" patch 6/9 in "selftests/bpf: Add bpf_bkup scheduler"
- 2e2e1a1bfb70: conflict in t/selftests-bpf-Add-bpf_rr-scheduler
- 6c22024f0008: "squashed" patch 7/9 in "selftests/bpf: Add bpf_rr scheduler"
- 684e5a0e4824: "squashed" patch 8/9 in "selftests/bpf: Add bpf_red scheduler"
- 6b458f5734d3: conflict in t/bpf-Export-more-bpf_burst-related-functions
- 24d78ea20a36: "squashed" patch 9/9 in "selftests/bpf: Add bpf_burst scheduler"
- Results: 6b6b68bc221b..fe720f4b5da8 (export)
Tests are now in progress:
https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20230916T114711
Cheers,
Matt
Signature · 2 lines
Tessares | Belgium | Hybrid Access Solutions www.tessares.net