Skip to contentSkip to conversation

Add IMX8 SCU GPIO support

PATCH Superseded Shenwei Wang 2 participants 9 messages Aug 11, 2022 – Aug 12, 2022

Subsystems (3)

v4 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

v4 cover Add IMX8 SCU GPIO support

The system controller (SCU) is the central unit to manage the resources on i.MX8 platforms. The SCU firmware provides a set of APIs to access the GPIO PINs on the SCU domain.

This patch series implements the standard GPIO driver over the SCU firmware APIs, so that the GPIOs on the SCU domain could be accessed like a local GPIO PINs.

Changes in V4:
- remove the generic compatible of "fsl,imx-sc-gpio"
- update the gpio $ref in "fsl,scu.yaml" as the file name is changed
- update the commit comment for 0003 because the driver is moved to the directory of "drivers/gpio"

Changes in V3:
- follow the other imx8 SCU binding rule and rename the compatible string from fsl,imx8-scu-gpio to fsl,imx8qxp-sc-gpio
- rename the doc file from fsl,imx8-scu-gpio.yaml to fsl,imx-sc-gpio.yaml

Changes in V2:
- move the driver into the gpio directory per Krzysztof's feedback
- change the subnode description in file fsl,scu.yaml
- fix the dt_binding_check error

Shenwei Wang (3):
dt-bindings: gpio: Add imx scu gpio driver bindings
dt-bindings: firmware: imx: Add imx-scu gpio node
gpio: imx-scu: add imx-scu GPIO driver

 .../devicetree/bindings/firmware/fsl,scu.yaml |   5 +
 .../bindings/gpio/fsl,imx-sc-gpio.yaml        |  39 +++++
 drivers/gpio/Kconfig                          |   4 +
 drivers/gpio/Makefile                         |   1 +
 drivers/gpio/gpio-imx-scu.c                   | 139 ++++++++++++++++++
 5 files changed, 188 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml
 create mode 100644 drivers/gpio/gpio-imx-scu.c

--
2.25.1

#1 lore raw

PATCH v4 1/3 dt-bindings: gpio: Add imx scu gpio driver bindings

Add binding document for the imx scu gpio driver.

---
 .../bindings/gpio/fsl,imx-sc-gpio.yaml        | 39 +++++++++++++++++++
 1 file changed, 39 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml
Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml new file +39 -0
new file mode 100644
index 000000000000..a1b024cddc97
@@ -0,0 +1,39 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/gpio/fsl,imx-sc-gpio.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: GPIO driver over IMX SCU firmware API
+
+maintainers:
+  - Shenwei Wang <[email protected]>
+
+description: |
+  This module provides the standard interface to control the
+  resource pins in SCU domain on i.MX8 platforms.
+
+properties:
+  compatible:
+    enum:
+      - fsl,imx8qxp-sc-gpio
+
+  "#gpio-cells":
+    const: 2
+
+  gpio-controller: true
+
+required:
+  - compatible
+  - "#gpio-cells"
+  - gpio-controller
+
+additionalProperties: false
+
+examples:
+  - |
+    gpio0: gpio {
+        compatible = "fsl,imx8qxp-sc-gpio";
+        gpio-controller;
+        #gpio-cells = <2>;
+    };
Signature · 1 line
2.25.1
#2 lore raw

Re: [PATCH v4 1/3] dt-bindings: gpio: Add imx scu gpio driver bindings

Quoted 23 lines · Shenwei Wang

Add binding document for the imx scu gpio driver.

---
 .../bindings/gpio/fsl,imx-sc-gpio.yaml        | 39 +++++++++++++++++++
 1 file changed, 39 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml
Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml new file +9 -0
new file mode 100644
index 000000000000..a1b024cddc97
@@ -0,0 +1,39 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/gpio/fsl,imx-sc-gpio.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: GPIO driver over IMX SCU firmware API
+
+maintainers:

Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml line 19

Quoted 10 lines
Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml new file +10 -0
+  - Shenwei Wang <[email protected]>
+
+description: |
+  This module provides the standard interface to control the
+  resource pins in SCU domain on i.MX8 platforms.
+
+properties:
+  compatible:
+    enum:
+      - fsl,imx8qxp-sc-gpio

Now the filename does not match compatible. Use the same compatible as filename.

Best regards,
Krzysztof

#3 lore raw

RE: [EXT] Re: [PATCH v4 1/3] dt-bindings: gpio: Add imx scu gpio driver bindings

Quoted 23 lines

-----Original Message-----
From: Krzysztof Kozlowski <[email protected]>
Sent: Thursday, August 11, 2022 9:36 AM
To: Shenwei Wang <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; dl-linux-imx <[email protected]>
Cc: [email protected]; [email protected]; linux- [email protected]; [email protected]; [email protected]
Subject: [EXT] Re: [PATCH v4 1/3] dt-bindings: gpio: Add imx scu gpio driver bindings

Quoted 10 lines

diff --git a/Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml b/Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml new file mode 100644
index 000000000000..a1b024cddc97

Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml new file +3 -0
+description: |
+  This module provides the standard interface to control the
+  resource pins in SCU domain on i.MX8 platforms.
Quoted 8 lines

Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml line 19

Quoted 5 lines
Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml new file +5 -0
+
+properties:
+  compatible:
+    enum:
+      - fsl,imx8qxp-sc-gpio

Now the filename does not match compatible. Use the same compatible as filename.

The subnodes under fsl,scu.yaml have their own naming rule. For example, the watchdog compatible is "fsl,imx-sc-wdt", but the file name is "fsl,scu-wdt.yaml". Is the filename required to match its compatible?

Regards,
Shenwei

Quoted 3 lines

Best regards,
Krzysztof

#4 lore raw

Re: [EXT] Re: [PATCH v4 1/3] dt-bindings: gpio: Add imx scu gpio driver bindings

Quoted 32 lines · Shenwei Wang
Quoted 23 lines

-----Original Message-----
From: Krzysztof Kozlowski <[email protected]>
Sent: Thursday, August 11, 2022 9:36 AM
To: Shenwei Wang <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; dl-linux-imx <[email protected]>
Cc: [email protected]; [email protected]; linux- [email protected]; [email protected]; [email protected]
Subject: [EXT] Re: [PATCH v4 1/3] dt-bindings: gpio: Add imx scu gpio driver bindings

Quoted 10 lines

diff --git a/Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml b/Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml new file mode 100644
index 000000000000..a1b024cddc97

Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml new file +3 -0
+description: |
+  This module provides the standard interface to control the
+  resource pins in SCU domain on i.MX8 platforms.
Quoted 8 lines

Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml line 19

Quoted 5 lines
Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml new file +5 -0
+
+properties:
+  compatible:
+    enum:
+      - fsl,imx8qxp-sc-gpio

Now the filename does not match compatible. Use the same compatible as filename.

Quoted 2 lines

The subnodes under fsl,scu.yaml have their own naming rule. For example, the watchdog compatible is "fsl,imx-sc-wdt", but the file name is "fsl,scu-wdt.yaml".

The other files have for example fsl,imx-sc-wdt, so they match compatible.

Quoted 2 lines

Is the filename required
to match its compatible?

Yes, that's the convention. Otherwise people tend to name the files in whatever way they like...

Best regards,
Krzysztof

#5 lore raw

RE: [EXT] Re: [PATCH v4 1/3] dt-bindings: gpio: Add imx scu gpio driver bindings

Quoted 51 lines

-----Original Message-----
From: Krzysztof Kozlowski <[email protected]>
Sent: Thursday, August 11, 2022 10:11 AM
To: Shenwei Wang <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; dl-linux-imx <[email protected]>
Cc: [email protected]; [email protected]; linux- [email protected]; [email protected]; [email protected]
Subject: Re: [EXT] Re: [PATCH v4 1/3] dt-bindings: gpio: Add imx scu gpio driver bindings

Caution: EXT Email

Quoted 34 lines · Shenwei Wang
Quoted 33 lines

-----Original Message-----
From: Krzysztof Kozlowski <[email protected]>
Sent: Thursday, August 11, 2022 9:36 AM
To: Shenwei Wang <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; dl-linux-imx <[email protected]>
Cc: [email protected]; [email protected]; linux- [email protected]; [email protected]; [email protected]
Subject: [EXT] Re: [PATCH v4 1/3] dt-bindings: gpio: Add imx scu gpio driver bindings

Quoted 7 lines

diff --git a/Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml b/Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml new file mode 100644
index 000000000000..a1b024cddc97

Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml line 19

Quoted 8 lines
Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml new file +8 -0
+description: |
+  This module provides the standard interface to control the
+  resource pins in SCU domain on i.MX8 platforms.
+
+properties:
+  compatible:
+    enum:
+      - fsl,imx8qxp-sc-gpio

Now the filename does not match compatible. Use the same compatible as filename.

Quoted 5 lines
Quoted 2 lines

The subnodes under fsl,scu.yaml have their own naming rule. For example, the watchdog compatible is "fsl,imx-sc-wdt", but the file name is

"fsl,scu-wdt.yaml".

The other files have for example fsl,imx-sc-wdt, so they match compatible.

I don't see the file fsl,imx-sc-wdt you mentioned under the watchdog directory.

$ ls fsl*
fsl-imx7ulp-wdt.yaml  fsl-imx-wdt.yaml  fsl,scu-wdt.yaml

Regards,
Shenwei

Quoted 9 lines
Quoted 3 lines

Is the filename required
to match its compatible?

Yes, that's the convention. Otherwise people tend to name the files in whatever way they like...

Best regards,
Krzysztof

#6 lore raw

Re: [EXT] Re: [PATCH v4 1/3] dt-bindings: gpio: Add imx scu gpio driver bindings

Quoted 53 lines · Shenwei Wang
Quoted 53 lines

-----Original Message-----
From: Krzysztof Kozlowski <[email protected]>
Sent: Thursday, August 11, 2022 10:11 AM
To: Shenwei Wang <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; dl-linux-imx <[email protected]>
Cc: [email protected]; [email protected]; linux- [email protected]; [email protected]; [email protected]
Subject: Re: [EXT] Re: [PATCH v4 1/3] dt-bindings: gpio: Add imx scu gpio driver bindings

Caution: EXT Email

Quoted 36 lines · Shenwei Wang
Quoted 25 lines

-----Original Message-----
From: Krzysztof Kozlowski <[email protected]>
Sent: Thursday, August 11, 2022 9:36 AM
To: Shenwei Wang <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; dl-linux-imx <[email protected]>
Cc: [email protected]; [email protected]; linux- [email protected]; [email protected]; [email protected]
Subject: [EXT] Re: [PATCH v4 1/3] dt-bindings: gpio: Add imx scu gpio driver bindings

Quoted 10 lines

diff --git a/Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml b/Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml new file mode 100644
index 000000000000..a1b024cddc97

Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml new file +3 -0
+description: |
+  This module provides the standard interface to control the
+  resource pins in SCU domain on i.MX8 platforms.
Quoted 8 lines

Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml line 19

Quoted 5 lines
Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml new file +5 -0
+
+properties:
+  compatible:
+    enum:
+      - fsl,imx8qxp-sc-gpio

Now the filename does not match compatible. Use the same compatible as filename.

The subnodes under fsl,scu.yaml have their own naming rule. For example, the watchdog compatible is "fsl,imx-sc-wdt", but the file name is

Quoted 8 lines
Quoted 3 lines

"fsl,scu-wdt.yaml".

The other files have for example fsl,imx-sc-wdt, so they match compatible.

I don't see the file fsl,imx-sc-wdt you mentioned under the watchdog directory.

$ ls fsl*
fsl-imx7ulp-wdt.yaml  fsl-imx-wdt.yaml  fsl,scu-wdt.yaml

Eh, they looked similar enough that I did not spot it during review. fsl,scu-wdt.yaml should be named fsl,imx-sc-wdt.yaml, of course.

Best regards,
Krzysztof

#7 lore raw

PATCH v4 2/3 dt-bindings: firmware: imx: Add imx-scu gpio node

In reply to Shenwei Wang

Add the description for imx-scu gpio subnode.

---
 Documentation/devicetree/bindings/firmware/fsl,scu.yaml | 5 +++++
 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/firmware/fsl,scu.yaml +5 -0
index b40b0ef56978..1fe61c2599e4 100644
@@ -30,6 +30,11 @@ properties:
       Clock controller node that provides the clocks controlled by the SCU
     $ref: /schemas/clock/fsl,scu-clk.yaml
 
+  gpio:
+    description:
+      Control the GPIO PINs on SCU domain over the firmware APIs
+    $ref: /schemas/gpio/fsl,imx-sc-gpio.yaml
+
   ocotp:
     description:
       OCOTP controller node provided by the SCU
Signature · 1 line
2.25.1
#8 lore raw

PATCH v4 3/3 gpio: imx-scu: add imx-scu GPIO driver

In reply to Shenwei Wang

The SCU firmware on i.MX8 platforms provides a set of APIs to control the GPIO PINs on the SCU domain. This patch implements the standard GPIO driver interface to access those PINs on the SCU domain over the SCU APIs.

---
 drivers/gpio/Kconfig        |   4 ++
 drivers/gpio/Makefile       |   1 +
 drivers/gpio/gpio-imx-scu.c | 139 ++++++++++++++++++++++++++++++++++++
 3 files changed, 144 insertions(+)
 create mode 100644 drivers/gpio/gpio-imx-scu.c
drivers/gpio/Kconfig +4 -0
index 0499c2facbb0..b01310f6ebcc 100644
@@ -341,6 +341,10 @@ config GPIO_ICH
 
 	  If unsure, say N.
 
+config GPIO_IMX_SCU
+       def_bool y
+       depends on IMX_SCU
+
 config GPIO_IOP
 	tristate "Intel IOP GPIO"
 	depends on ARCH_IOP32X || COMPILE_TEST
drivers/gpio/Makefile +1 -0
index 3fa4f3f93d85..b39ab87793ec 100644
@@ -70,6 +70,7 @@ obj-$(CONFIG_HTC_EGPIO)			+= gpio-htc-egpio.o
 obj-$(CONFIG_GPIO_I8255)		+= gpio-i8255.o
 obj-$(CONFIG_GPIO_ICH)			+= gpio-ich.o
 obj-$(CONFIG_GPIO_IDT3243X)		+= gpio-idt3243x.o
+obj-$(CONFIG_GPIO_IMX_SCU)		+= gpio-imx-scu.o
 obj-$(CONFIG_GPIO_IOP)			+= gpio-iop.o
 obj-$(CONFIG_GPIO_IT87)			+= gpio-it87.o
 obj-$(CONFIG_GPIO_IXP4XX)		+= gpio-ixp4xx.o
drivers/gpio/gpio-imx-scu.c new file +139 -0

139 lines not on this page · raw message

Signature · 1 line
2.25.1