kunit: Add missing newline in summary message
PATCH 1/1 kunit: Add missing newline in summary message
Add missing newline, as otherwise flushing of the final summary message to the console log can be delayed.
--- lib/kunit/test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/kunit/test.c +1 -1
@@ -93,7 +93,7 @@ static void kunit_print_ok_not_ok(void *test_or_suite,* representation. */ if (suite) -pr_info ("%s %zd - %s" , +pr_info ("%s %zd - %s\n" ,kunit_status_to_string (is_ok), test_number, description);else
Signature · 1 line
2.26.1.301.g55bc3eb7cb9-goog
Quoted 6 lines · Marco Elver' via KUnit Development
Add missing newline, as otherwise flushing of the final summary message to the console log can be delayed.
Fixes e2219db280e3 ("kunit: add debugfs /sys/kernel/debug/kunit/<suite>/results display")Signed-off-by Marco Elver <[email protected]>
Thanks a lot: this issue was starting to get annoying, and I can confirm this patch fixes it for me!
-- David
Quoted 5 lines · Marco Elver
Add missing newline, as otherwise flushing of the final summary message to the console log can be delayed.
Fixes e2219db280e3 ("kunit: add debugfs /sys/kernel/debug/kunit/<suite>/results display")Signed-off-by Marco Elver <[email protected]>
Thanks for finding/fixing this!
Alan
Quoted 21 lines
--- lib/kunit/test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)lib/kunit/test.c +1
-1@@ -93,7 +93,7 @@ static void kunit_print_ok_not_ok(void *test_or_suite,* representation. */ if (suite) -pr_info ("%s %zd - %s" , +pr_info ("%s %zd - %s\n" ,kunit_status_to_string (is_ok), test_number, description);else Signature · 1 line
2.26.1.301.g55bc3eb7cb9-goog
Quoted 6 lines · Alan Maguire
Quoted 3 lines · Marco Elver
Add missing newline, as otherwise flushing of the final summary message to the console log can be delayed.
Quoted 12 lines
Quoted 2 lines
Fixes e2219db280e3 ("kunit: add debugfs /sys/kernel/debug/kunit/<suite>/results display")Signed-off-by Marco Elver <[email protected]>Reviewed-by Alan Maguire <[email protected]>Thanks for finding/fixing this!
Alan
Quoted 3 lines
--- lib/kunit/test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Which tree will pick this up? I cannot yet see this in -next.
Thanks,
-- Marco
Quoted 17 lines
Quoted 17 lines
lib/kunit/test.c +1
-2@@ -93,7 +93,7 @@ static void kunit_print_ok_not_ok(void *test_or_suite,* representation. */ if (suite) -pr_info ("%s %zd - %s" , +pr_info ("%s %zd - %s\n" ,kunit_status_to_string (is_ok), test_number, description);else --2.26.1.301.g55bc3eb7cb9-goog
Quoted 15 lines · Marco Elver
Quoted 13 lines · Alan Maguire
Quoted 5 lines · Marco Elver
Add missing newline, as otherwise flushing of the final summary message to the console log can be delayed.
Fixes e2219db280e3 ("kunit: add debugfs /sys/kernel/debug/kunit/<suite>/results display")Signed-off-by Marco Elver <[email protected]>Reviewed-by Alan Maguire <[email protected]>Thanks for finding/fixing this!
Quoted 7 lines
Quoted 5 lines
Alan
Quoted 3 lines
--- lib/kunit/test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Which tree will pick this up? I cannot yet see this in -next.
This will be picked up by kselftest/kunit:
https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/log/?h=kunit
Quoted 6 lines · Marco Elver
Add missing newline, as otherwise flushing of the final summary message to the console log can be delayed.
Fixes e2219db280e3 ("kunit: add debugfs /sys/kernel/debug/kunit/<suite>/results display")Signed-off-by Marco Elver <[email protected]>
Thanks!
Quoted 5 lines · Brendan Higgins
Quoted 4 lines · Marco Elver
Add missing newline, as otherwise flushing of the final summary message to the console log can be delayed.
Quoted 7 lines
Quoted 2 lines
Fixes e2219db280e3 ("kunit: add debugfs /sys/kernel/debug/kunit/<suite>/results display")Signed-off-by Marco Elver <[email protected]>Acked-by Brendan Higgins <[email protected]>Thanks!
Applied. Now in
git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest kunit branch.
thanks,
-- Shuah