Skip to contentSkip to conversation

kunit: Add missing newline in summary message

PATCH Applied Marco Elver 5 participants 7 messages Apr 16, 2020 – Apr 23, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kunit: Add missing newline in summary message

Add missing newline, as otherwise flushing of the final summary message to the console log can be delayed.

Fixes e2219db280e3 ("kunit: add debugfs /sys/kernel/debug/kunit/<suite>/results display")
---
 lib/kunit/test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/kunit/test.c +1 -1
index 7a6430a7fca0..ccb2ffad8dcf 100644
@@ -93,7 +93,7 @@ static void kunit_print_ok_not_ok(void *test_or_suite,
 	 * representation.
 	 */
 	if (suite)
-		pr_info("%s %zd - %s",
+		pr_info("%s %zd - %s\n",
 			kunit_status_to_string(is_ok),
 			test_number, description);
 	else
Signature · 1 line
2.26.1.301.g55bc3eb7cb9-goog
Tested-by on v1 1/1
#1 lore raw
Quoted 6 lines · Marco Elver' via KUnit Development

Add missing newline, as otherwise flushing of the final summary message to the console log can be delayed.

Fixes e2219db280e3 ("kunit: add debugfs /sys/kernel/debug/kunit/<suite>/results display")

Thanks a lot: this issue was starting to get annoying, and I can confirm this patch fixes it for me!

-- David

Reviewed-by on v1 1/1
#2 lore raw
In reply to Marco Elver
Quoted 5 lines · Marco Elver

Add missing newline, as otherwise flushing of the final summary message to the console log can be delayed.

Fixes e2219db280e3 ("kunit: add debugfs /sys/kernel/debug/kunit/<suite>/results display")

Thanks for finding/fixing this!

Alan

Quoted 21 lines
---
 lib/kunit/test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/kunit/test.c +1 -1
index 7a6430a7fca0..ccb2ffad8dcf 100644
@@ -93,7 +93,7 @@ static void kunit_print_ok_not_ok(void *test_or_suite,
 	 * representation.
 	 */
 	if (suite)
-		pr_info("%s %zd - %s",
+		pr_info("%s %zd - %s\n",
 			kunit_status_to_string(is_ok),
 			test_number, description);
 	else
Signature · 1 line
2.26.1.301.g55bc3eb7cb9-goog
#3 lore raw
Quoted 6 lines · Alan Maguire
Quoted 3 lines · Marco Elver

Add missing newline, as otherwise flushing of the final summary message to the console log can be delayed.

Quoted 12 lines
Quoted 2 lines
Fixes e2219db280e3 ("kunit: add debugfs /sys/kernel/debug/kunit/<suite>/results display")

Thanks for finding/fixing this!

Alan

Quoted 3 lines
---
 lib/kunit/test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Which tree will pick this up? I cannot yet see this in -next.

Thanks,
-- Marco

Quoted 17 lines
Quoted 17 lines
lib/kunit/test.c +1 -2
index 7a6430a7fca0..ccb2ffad8dcf 100644
@@ -93,7 +93,7 @@ static void kunit_print_ok_not_ok(void *test_or_suite,
       * representation.
       */
      if (suite)
-             pr_info("%s %zd - %s",
+             pr_info("%s %zd - %s\n",
                      kunit_status_to_string(is_ok),
                      test_number, description);
      else
--

2.26.1.301.g55bc3eb7cb9-goog

#4 lore raw
Quoted 15 lines · Marco Elver
Quoted 13 lines · Alan Maguire
Quoted 5 lines · Marco Elver

Add missing newline, as otherwise flushing of the final summary message to the console log can be delayed.

Fixes e2219db280e3 ("kunit: add debugfs /sys/kernel/debug/kunit/<suite>/results display")

Thanks for finding/fixing this!

Quoted 7 lines
Quoted 5 lines

Alan

Quoted 3 lines
---
 lib/kunit/test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Which tree will pick this up? I cannot yet see this in -next.

This will be picked up by kselftest/kunit:

https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/log/?h=kunit

maintainer Applied
#6 lore raw
Quoted 5 lines · Brendan Higgins
Quoted 4 lines · Marco Elver

Add missing newline, as otherwise flushing of the final summary message to the console log can be delayed.

Quoted 7 lines
Quoted 2 lines
Fixes e2219db280e3 ("kunit: add debugfs /sys/kernel/debug/kunit/<suite>/results display")

Thanks!

Applied. Now in

git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest kunit branch.

thanks,
-- Shuah