parisc: Replace setup_irq() by request_irq()
PATCH v3 1/1 parisc: Replace setup_irq() by request_irq()
request_irq() is preferred over setup_irq(). Invocations of setup_irq() occur after memory allocators are ready.
Per tglx[1], setup_irq() existed in olden days when allocators were not ready by the time early interrupts were initialized.
Hence replace setup_irq() by request_irq().
[1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos
---
Hi parisc maintainers,
if okay w/ this change, please consider taking it thr' your tree, else please let me know.
Regards
afzal
Link to v2 & v1,
[v2] https://lkml.kernel.org/r/[email protected]
[v1] https://lkml.kernel.org/r/[email protected]
v3:
* Split out from tree wide series, as Thomas suggested to get it thr' respective maintainers
* Modify pr_err displayed in case of error
* Re-arrange code & choose pr_err args as required to improve readability
* Remove irrelevant parts from commit message & improve
v2:
* Replace pr_err("request_irq() on %s failed" by
pr_err("%s: request_irq() failed"* Commit message massage
arch/parisc/kernel/irq.c | 22 ++++++---------------- drivers/parisc/eisa.c | 8 ++------ 2 files changed, 8 insertions(+), 22 deletions(-)
arch/parisc/kernel/irq.c +6 -16
@@ -560,33 +560,23 @@ void do_cpu_irq_mask(struct pt_regs *regs) goto out; } -static struct irqaction timer_action = { - .handler = timer_interrupt, - .name ="timer" , - .flags =IRQF_TIMER |IRQF_PERCPU |IRQF_IRQPOLL , -}; - -#ifdef CONFIG_SMP -static struct irqaction ipi_action = { - .handler = ipi_interrupt, - .name ="IPI" , - .flags =IRQF_PERCPU , -}; -#endif -static void claim_cpu_irqs (void ) { +unsigned long flags =IRQF_TIMER |IRQF_PERCPU |IRQF_IRQPOLL ;int i; +for (i =CPU_IRQ_BASE ; i <=CPU_IRQ_MAX ; i++) {irq_set_chip_and_handler (i, &cpu_interrupt_type, handle_percpu_irq); }irq_set_handler (TIMER_IRQ , handle_percpu_irq); -setup_irq (TIMER_IRQ , &timer_action); +if (request_irq (TIMER_IRQ , timer_interrupt, flags,"timer" ,NULL )) +pr_err ("Failed to register timer interrupt\n" );#ifdef CONFIG_SMP irq_set_handler (IPI_IRQ , handle_percpu_irq); -setup_irq (IPI_IRQ , &ipi_action); +if (request_irq (IPI_IRQ , ipi_interrupt,IRQF_PERCPU ,"IPI" ,NULL )) +pr_err ("Failed to register IPI interrupt\n" );#endif }
drivers/parisc/eisa.c +2 -6
@@ -243,11 +243,6 @@ static irqreturn_t dummy_irq2_handler(int _, void *dev)return IRQ_HANDLED ; } -static struct irqaction irq2_action = { - .handler = dummy_irq2_handler, - .name ="cascade" , -}; -static void init_eisa_pic (void ) {unsigned long flags;
@@ -335,7 +330,8 @@ static int __init eisa_probe(struct parisc_device *dev) }/* Reserve IRQ2 */ -setup_irq (2 , &irq2_action); +if (request_irq (2 , dummy_irq2_handler,0 ,"cascade" ,NULL )) +pr_err ("Failed to request irq 2 (cascade)\n" );for (i =0 ; i <16 ; i++) {irq_set_chip_and_handler (i, &eisa_interrupt_type, handle_simple_irq);
Signature · 1 line
2.25.1
Hi Helge Deller,
Quoted 8 lines · afzal mohammed
request_irq()is preferred oversetup_irq(). Invocations ofsetup_irq()occur after memory allocators are ready.Per tglx[1],
setup_irq()existed in olden days when allocators were not ready by the time early interrupts were initialized.Hence replace
setup_irq()byrequest_irq().
Quoted 8 lines
[1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos
Signed-off-by afzal mohammed <[email protected]>---
Hi parisc maintainers,if okay w/ this change, please consider taking it thr' your tree, else please let me know.
Seems you handle the pull requests for parisc, if this patch is okay, can you please consider for inclusion in your tree.
Regards
afzal
Quoted 17 lines · afzal mohammed
Hi Helge Deller,
Quoted 14 lines · afzal mohammed
request_irq()is preferred oversetup_irq(). Invocations ofsetup_irq()occur after memory allocators are ready.Per tglx[1],
setup_irq()existed in olden days when allocators were not ready by the time early interrupts were initialized.Hence replace
setup_irq()byrequest_irq().[1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos
Signed-off-by afzal mohammed <[email protected]>---
Hi parisc maintainers,
Quoted 5 lines
Quoted 2 lines
if okay w/ this change, please consider taking it thr' your tree, else please let me know.
Seems you handle the pull requests for parisc, if this patch is okay, can you please consider for inclusion in your tree.
Applied into my for-next tree.
Thanks!
Helge