Add many missing _requires
cover Add many missing _requires
Many tests take actions (chmod, chown, hardlink, mknod) which may not be supported by simpler filesystems. Often this is fine because other _require tests already cause the _notrun to occur, but this makes it all explicit.
Patch 1 simply removes some spurious "chmod" calls that do not act on the filesystem under test and AFAICT are not necessary.
PATCH 1/5 generic: remove chmod of $seqres.full file
This appears to be an historical artifact.
--- tests/generic/379 | 3 --- tests/generic/384 | 3 --- 2 files changed, 6 deletions(-)
tests/generic/379 +0 -3
@@ -22,9 +22,6 @@ _cleanup() } -cp /dev/null $seqres.full -chmod ugo+rwx $seqres.full - _require_scratch _require_quota _require_xfs_quota_foreign
tests/generic/384 +0 -3
@@ -42,9 +42,6 @@ cat >$tmp.projid <<EOF test:1 EOF -cp /dev/null $seqres.full -chmod a+rwx $seqres.full # arbitrary users will write here - _require_scratch _scratch_mkfs >/dev/null 2>&1 _scratch_enable_pquota
Signature · 1 line
2.55.0
Re: [PATCH 1/5] generic: remove chmod of $seqres.full file
Quoted 4 lines · Eric Sandeen
This appears to be an historical artifact.
Signed-off-by Eric Sandeen <[email protected]>---
Makes sense,
Quoted 36 lines
tests/generic/379 | 3 --- tests/generic/384 | 3 --- 2 files changed, 6 deletions(-)tests/generic/379 +0
-3@@ -22,9 +22,6 @@ _cleanup() } -cp /dev/null $seqres.full -chmod ugo+rwx $seqres.full - _require_scratch _require_quota _require_xfs_quota_foreigntests/generic/384 +0
-3@@ -42,9 +42,6 @@ cat >$tmp.projid <<EOF test:1 EOF -cp /dev/null $seqres.full -chmod a+rwx $seqres.full # arbitrary users will write here - _require_scratch _scratch_mkfs >/dev/null 2>&1 _scratch_enable_pquotaSignature · 1 line
2.55.0
PATCH 2/5 Add _require_chmod as needed
In reply to Eric Sandeen--- tests/generic/093 | 1 + tests/generic/099 | 1 + tests/generic/184 | 1 + tests/generic/193 | 1 + tests/generic/230 | 1 + tests/generic/256 | 1 + tests/generic/314 | 1 + tests/generic/317 | 1 + tests/generic/355 | 1 + tests/generic/370 | 1 + tests/generic/375 | 1 + tests/generic/378 | 1 + tests/generic/444 | 1 + tests/generic/449 | 1 + tests/generic/462 | 1 + tests/generic/495 | 1 + tests/generic/514 | 1 + tests/generic/535 | 1 + tests/generic/572 | 1 + tests/generic/573 | 1 + tests/generic/581 | 1 + tests/generic/597 | 1 + tests/generic/603 | 1 + tests/generic/622 | 1 + tests/generic/636 | 1 + tests/generic/641 | 1 + tests/generic/673 | 1 + tests/generic/674 | 1 + tests/generic/675 | 1 + tests/generic/682 | 1 + tests/generic/683 | 1 + tests/generic/684 | 1 + tests/generic/685 | 1 + tests/generic/686 | 1 + tests/generic/687 | 1 + tests/generic/688 | 1 + tests/generic/698 | 1 + tests/generic/699 | 1 + tests/generic/726 | 1 + tests/generic/727 | 1 + tests/generic/792 | 1 + 41 files changed, 41 insertions(+)
tests/generic/093 +1 -0
@@ -29,6 +29,7 @@ filefilter() _require_test _require_attrs security _require_user +_require_chmod _require_test_program "writemod" _require_command "$SETCAP_PROG" "setcap" _require_command "$GETCAP_PROG" "getcap"
tests/generic/099 +1 -0
@@ -47,6 +47,7 @@ _cleanup() # _require_test +_require_chmod _require_runas _acl_setup_ids
tests/generic/184 +1 -0
@@ -13,6 +13,7 @@ _begin_fstest metadata auto quick . ./common/filter _require_test +_require_chmod _require_mknod rm -f $TEST_DIR/null
tests/generic/193 +1 -0
@@ -49,6 +49,7 @@ _filter_files() _require_test _require_user +_require_chmod _require_chown test_root=$TEST_DIR/$seq.$$.root
tests/generic/230 +1 -0
@@ -17,6 +17,7 @@ _begin_fstest auto quota quick _require_scratch _require_quota _require_user +_require_chmod test_files() {
tests/generic/256 +1 -0
@@ -19,6 +19,7 @@ _require_xfs_io_command "fpunch" _require_scratch _require_user _require_test +_require_chmod testfile=$TEST_DIR/256.$$
tests/generic/314 +1 -0
@@ -15,6 +15,7 @@ _begin_fstest auto quick perms _require_test _require_user _require_chown +_require_chmod _require_sgid_inheritance rm -rf $TEST_DIR/$seq-dir
tests/generic/317 +1 -0
@@ -33,6 +33,7 @@ file=$SCRATCH_MNT/file1 _require_scratch _require_user +_require_chmod _require_ugid_map _require_userns _require_chown
tests/generic/355 +1 -0
@@ -14,6 +14,7 @@ _begin_fstest auto quick perms _require_test _require_user +_require_chmod _require_odirect _require_chown
tests/generic/370 +1 -0
@@ -23,6 +23,7 @@ _fixed_by_fs_commit btrfs 03018e5d8508 \ "btrfs: fix swap file activation failure due to extents that used to be shared" _fixed_by_fs_commit xfs 2d873efd174b "xfs: flush inodegc before swapon" +_require_chmod _require_scratch_swapfile _require_scratch_reflink _require_cp_reflink
tests/generic/375 +1 -0
@@ -15,6 +15,7 @@ _begin_fstest auto quick acl perms . ./common/attr _require_test +_require_chmod _require_runas _require_acls
tests/generic/378 +1 -0
@@ -20,6 +20,7 @@ _begin_fstest auto quick metadata _require_test _require_user +_require_chmod _require_hardlinks # Setup testfile and its hardlink
tests/generic/444 +1 -0
@@ -15,6 +15,7 @@ _begin_fstest auto quick acl perms . ./common/attr _require_test +_require_chmod _require_runas _require_acls
tests/generic/449 +1 -0
@@ -19,6 +19,7 @@ _begin_fstest auto quick acl attr enospc # Modify as appropriate. _require_scratch _require_test +_require_chmod _require_acls _require_attrs trusted
tests/generic/462 +1 -0
@@ -19,6 +19,7 @@ _begin_fstest auto quick dax mmap # Modify as appropriate. _require_test +_require_chmod _require_scratch_dax_mountopt "dax" _require_test_program "t_mmap_write_ro" # running by unpriviliged user is not necessary to reproduce
tests/generic/495 +1 -0
@@ -12,6 +12,7 @@ _begin_fstest auto quick swap # Import common functions. . ./common/filter +_require_chmod _require_scratch_swapfile _require_test_program mkswap _require_test_program swapon
tests/generic/514 +1 -0
@@ -15,6 +15,7 @@ _begin_fstest auto quick clone _require_scratch_reflink _require_user +_require_chmod _scratch_mkfs >>$seqres.full 2>&1 _scratch_mount
tests/generic/535 +1 -0
@@ -34,6 +34,7 @@ _cleanup() _require_scratch +_require_chmod _require_dm_target flakey _scratch_mkfs >/dev/null 2>&1
tests/generic/572 +1 -0
@@ -27,6 +27,7 @@ _cleanup() . ./common/verity _require_scratch_verity +_require_chmod _disable_fsverity_signatures _scratch_mkfs_verity &>> $seqres.full
tests/generic/573 +1 -0
@@ -24,6 +24,7 @@ _cleanup() _require_scratch_verity _require_user +_require_chmod _require_chattr ia _disable_fsverity_signatures
tests/generic/581 +1 -0
@@ -29,6 +29,7 @@ _cleanup() . ./common/encrypt _require_user +_require_chmod _require_scratch_encryption -v 2 _scratch_mkfs_encrypted &>> $seqres.full
tests/generic/597 +1 -0
@@ -27,6 +27,7 @@ _cleanup() # Modify as appropriate. _require_test +_require_chmod _require_sysctl_variable fs.protected_symlinks _require_sysctl_variable fs.protected_hardlinks _require_user fsgqa2
tests/generic/603 +1 -0
@@ -115,6 +115,7 @@ _require_setquota_project _require_quota _require_user _require_group +_require_chmod _scratch_mkfs >$seqres.full 2>&1 _scratch_enable_pquota
tests/generic/622 +1 -0
@@ -77,6 +77,7 @@ _cleanup() # This test uses the shutdown command, so it has to use the scratch filesystem # rather than the test filesystem. _require_scratch +_require_chmod _require_scratch_shutdown _require_metadata_journaling _require_xfs_io_command "pwrite"
tests/generic/636 +1 -0
@@ -13,6 +13,7 @@ _begin_fstest auto quick swap # Import common functions. . ./common/filter +_require_chmod _require_scratch_swapfile _require_test_program mkswap _require_test_program swapon
tests/generic/641 +1 -0
@@ -15,6 +15,7 @@ _begin_fstest auto quick swap collapse . ./common/filter _require_scratch +_require_chmod _require_scratch_swapfile _require_test_program mkswap _require_test_program swapon
tests/generic/673 +1 -0
@@ -16,6 +16,7 @@ _begin_fstest auto clone quick perms # Modify as appropriate. _require_user +_require_chmod _require_scratch_reflink _scratch_mkfs >> $seqres.full
tests/generic/674 +1 -0
@@ -16,6 +16,7 @@ _begin_fstest auto clone quick perms dedupe # Modify as appropriate. _require_user +_require_chmod _require_scratch_dedupe _require_xfs_io_command dedupe
tests/generic/675 +1 -0
@@ -17,6 +17,7 @@ _begin_fstest auto clone quick # Modify as appropriate. _require_user +_require_chmod _require_command "$GETCAP_PROG" getcap _require_command "$SETCAP_PROG" setcap _require_scratch_reflink
tests/generic/682 +1 -0
@@ -23,6 +23,7 @@ _begin_fstest auto quick quota _require_quota _require_user _require_scratch +_require_chmod _scratch_mkfs > "$seqres.full" 2>&1 _qmount_option usrquota
tests/generic/683 +1 -0
@@ -24,6 +24,7 @@ _cleanup() # Modify as appropriate. _require_user _require_test +_require_chmod verb=falloc _require_xfs_io_command $verb _require_congruent_file_oplen $TEST_DIR 65536
tests/generic/684 +1 -0
@@ -24,6 +24,7 @@ _cleanup() # Modify as appropriate. _require_user _require_test +_require_chmod verb=fpunch _require_xfs_io_command $verb _require_congruent_file_oplen $TEST_DIR 65536
tests/generic/685 +1 -0
@@ -24,6 +24,7 @@ _cleanup() # Modify as appropriate. _require_user _require_test +_require_chmod verb=fzero _require_xfs_io_command $verb _require_congruent_file_oplen $TEST_DIR 65536
tests/generic/686 +1 -0
@@ -24,6 +24,7 @@ _cleanup() # Modify as appropriate. _require_user _require_test +_require_chmod verb=finsert _require_xfs_io_command $verb _require_congruent_file_oplen $TEST_DIR 65536
tests/generic/687 +1 -0
@@ -24,6 +24,7 @@ _cleanup() # Modify as appropriate. _require_user _require_test +_require_chmod verb=fcollapse _require_xfs_io_command $verb _require_congruent_file_oplen $TEST_DIR 65536
tests/generic/688 +1 -0
@@ -23,6 +23,7 @@ _cleanup() # Modify as appropriate. _require_user +_require_chmod _require_command "$GETCAP_PROG" getcap _require_command "$SETCAP_PROG" setcap _require_xfs_io_command falloc
tests/generic/698 +1 -0
@@ -26,6 +26,7 @@ _fixed_by_kernel_commit 168f91289340 \ "fs: account for group membership" _require_scratch _require_chown +_require_chmod _require_idmapped_mounts _require_test_program "vfs/mount-idmapped" _require_user fsgqa2
tests/generic/699 +1 -0
@@ -25,6 +25,7 @@ _require_extra_fs overlay _require_scratch _require_chown +_require_chmod _require_idmapped_mounts _require_test_program "vfs/mount-idmapped" _require_user fsgqa2
tests/generic/726 +1 -0
@@ -23,6 +23,7 @@ _begin_fstest auto fiexchange quick # Modify as appropriate. _require_user +_require_chmod _require_xfs_io_command exchangerange _require_xfs_io_command startupdate _require_scratch
tests/generic/727 +1 -0
@@ -24,6 +24,7 @@ _begin_fstest auto fiexchange quick # Modify as appropriate. _require_user +_require_chmod _require_command "$GETCAP_PROG" getcap _require_command "$SETCAP_PROG" setcap _require_xfs_io_command exchangerange
tests/generic/792 +1 -0
@@ -22,6 +22,7 @@ _cleanup() . ./common/dmflakey _require_scratch +_require_chmod _require_test_program unlink-fsync _require_dm_target flakey
Signature · 1 line
2.55.0
Re: [PATCH 2/5] Add _require_chmod as needed
Quoted 2 lines · Eric Sandeen
Signed-off-by Eric Sandeen <[email protected]>---
Maybe we need a helper likes _require_posix_fs to filter out non-POSIX filesystems such as exFAT, NTFS, and CIFS etc :)
Quoted 539 lines
tests/generic/093 | 1 + tests/generic/099 | 1 + tests/generic/184 | 1 + tests/generic/193 | 1 + tests/generic/230 | 1 + tests/generic/256 | 1 + tests/generic/314 | 1 + tests/generic/317 | 1 + tests/generic/355 | 1 + tests/generic/370 | 1 + tests/generic/375 | 1 + tests/generic/378 | 1 + tests/generic/444 | 1 + tests/generic/449 | 1 + tests/generic/462 | 1 + tests/generic/495 | 1 + tests/generic/514 | 1 + tests/generic/535 | 1 + tests/generic/572 | 1 + tests/generic/573 | 1 + tests/generic/581 | 1 + tests/generic/597 | 1 + tests/generic/603 | 1 + tests/generic/622 | 1 + tests/generic/636 | 1 + tests/generic/641 | 1 + tests/generic/673 | 1 + tests/generic/674 | 1 + tests/generic/675 | 1 + tests/generic/682 | 1 + tests/generic/683 | 1 + tests/generic/684 | 1 + tests/generic/685 | 1 + tests/generic/686 | 1 + tests/generic/687 | 1 + tests/generic/688 | 1 + tests/generic/698 | 1 + tests/generic/699 | 1 + tests/generic/726 | 1 + tests/generic/727 | 1 + tests/generic/792 | 1 + 41 files changed, 41 insertions(+)tests/generic/093 +1
-0@@ -29,6 +29,7 @@ filefilter() _require_test _require_attrs security _require_user +_require_chmod _require_test_program "writemod" _require_command "$SETCAP_PROG" "setcap" _require_command "$GETCAP_PROG" "getcap"tests/generic/099 +1
-0@@ -47,6 +47,7 @@ _cleanup() # _require_test +_require_chmod _require_runas _acl_setup_idstests/generic/184 +1
-0@@ -13,6 +13,7 @@ _begin_fstest metadata auto quick . ./common/filter _require_test +_require_chmod _require_mknod rm -f $TEST_DIR/nulltests/generic/193 +1
-0@@ -49,6 +49,7 @@ _filter_files() _require_test _require_user +_require_chmod _require_chown test_root=$TEST_DIR/$seq.$$.roottests/generic/230 +1
-0@@ -17,6 +17,7 @@ _begin_fstest auto quota quick _require_scratch _require_quota _require_user +_require_chmod test_files() {tests/generic/256 +1
-0@@ -19,6 +19,7 @@ _require_xfs_io_command "fpunch" _require_scratch _require_user _require_test +_require_chmod testfile=$TEST_DIR/256.$$tests/generic/314 +1
-0@@ -15,6 +15,7 @@ _begin_fstest auto quick perms _require_test _require_user _require_chown +_require_chmod _require_sgid_inheritance rm -rf $TEST_DIR/$seq-dirtests/generic/317 +1
-0@@ -33,6 +33,7 @@ file=$SCRATCH_MNT/file1 _require_scratch _require_user +_require_chmod _require_ugid_map _require_userns _require_chowntests/generic/355 +1
-0@@ -14,6 +14,7 @@ _begin_fstest auto quick perms _require_test _require_user +_require_chmod _require_odirect _require_chowntests/generic/370 +1
-0@@ -23,6 +23,7 @@ _fixed_by_fs_commit btrfs 03018e5d8508 \ "btrfs: fix swap file activation failure due to extents that used to be shared" _fixed_by_fs_commit xfs 2d873efd174b "xfs: flush inodegc before swapon" +_require_chmod _require_scratch_swapfile _require_scratch_reflink _require_cp_reflinktests/generic/375 +1
-0@@ -15,6 +15,7 @@ _begin_fstest auto quick acl perms . ./common/attr _require_test +_require_chmod _require_runas _require_aclstests/generic/378 +1
-0@@ -20,6 +20,7 @@ _begin_fstest auto quick metadata _require_test _require_user +_require_chmod _require_hardlinks # Setup testfile and its hardlinktests/generic/444 +1
-0@@ -15,6 +15,7 @@ _begin_fstest auto quick acl perms . ./common/attr _require_test +_require_chmod _require_runas _require_aclstests/generic/449 +1
-0@@ -19,6 +19,7 @@ _begin_fstest auto quick acl attr enospc # Modify as appropriate. _require_scratch _require_test +_require_chmod _require_acls _require_attrs trustedtests/generic/462 +1
-0@@ -19,6 +19,7 @@ _begin_fstest auto quick dax mmap # Modify as appropriate. _require_test +_require_chmod _require_scratch_dax_mountopt "dax" _require_test_program "t_mmap_write_ro" # running by unpriviliged user is not necessary to reproducetests/generic/495 +1
-0@@ -12,6 +12,7 @@ _begin_fstest auto quick swap # Import common functions. . ./common/filter +_require_chmod _require_scratch_swapfile _require_test_program mkswap _require_test_program swapontests/generic/514 +1
-0@@ -15,6 +15,7 @@ _begin_fstest auto quick clone _require_scratch_reflink _require_user +_require_chmod _scratch_mkfs >>$seqres.full 2>&1 _scratch_mounttests/generic/535 +1
-0@@ -34,6 +34,7 @@ _cleanup() _require_scratch +_require_chmod _require_dm_target flakey _scratch_mkfs >/dev/null 2>&1tests/generic/572 +1
-0@@ -27,6 +27,7 @@ _cleanup() . ./common/verity _require_scratch_verity +_require_chmod _disable_fsverity_signatures _scratch_mkfs_verity &>> $seqres.fulltests/generic/573 +1
-0@@ -24,6 +24,7 @@ _cleanup() _require_scratch_verity _require_user +_require_chmod _require_chattr ia _disable_fsverity_signaturestests/generic/581 +1
-0@@ -29,6 +29,7 @@ _cleanup() . ./common/encrypt _require_user +_require_chmod _require_scratch_encryption -v 2 _scratch_mkfs_encrypted &>> $seqres.fulltests/generic/597 +1
-0@@ -27,6 +27,7 @@ _cleanup() # Modify as appropriate. _require_test +_require_chmod _require_sysctl_variable fs.protected_symlinks _require_sysctl_variable fs.protected_hardlinks _require_user fsgqa2tests/generic/603 +1
-0@@ -115,6 +115,7 @@ _require_setquota_project _require_quota _require_user _require_group +_require_chmod _scratch_mkfs >$seqres.full 2>&1 _scratch_enable_pquotatests/generic/622 +1
-0@@ -77,6 +77,7 @@ _cleanup() # This test uses the shutdown command, so it has to use the scratch filesystem # rather than the test filesystem. _require_scratch +_require_chmod _require_scratch_shutdown _require_metadata_journaling _require_xfs_io_command "pwrite"tests/generic/636 +1
-0@@ -13,6 +13,7 @@ _begin_fstest auto quick swap # Import common functions. . ./common/filter +_require_chmod _require_scratch_swapfile _require_test_program mkswap _require_test_program swapontests/generic/641 +1
-0@@ -15,6 +15,7 @@ _begin_fstest auto quick swap collapse . ./common/filter _require_scratch +_require_chmod _require_scratch_swapfile _require_test_program mkswap _require_test_program swapontests/generic/673 +1
-0@@ -16,6 +16,7 @@ _begin_fstest auto clone quick perms # Modify as appropriate. _require_user +_require_chmod _require_scratch_reflink _scratch_mkfs >> $seqres.fulltests/generic/674 +1
-0@@ -16,6 +16,7 @@ _begin_fstest auto clone quick perms dedupe # Modify as appropriate. _require_user +_require_chmod _require_scratch_dedupe _require_xfs_io_command dedupetests/generic/675 +1
-0@@ -17,6 +17,7 @@ _begin_fstest auto clone quick # Modify as appropriate. _require_user +_require_chmod _require_command "$GETCAP_PROG" getcap _require_command "$SETCAP_PROG" setcap _require_scratch_reflinktests/generic/682 +1
-0@@ -23,6 +23,7 @@ _begin_fstest auto quick quota _require_quota _require_user _require_scratch +_require_chmod _scratch_mkfs > "$seqres.full" 2>&1 _qmount_option usrquotatests/generic/683 +1
-0@@ -24,6 +24,7 @@ _cleanup() # Modify as appropriate. _require_user _require_test +_require_chmod verb=falloc _require_xfs_io_command $verb _require_congruent_file_oplen $TEST_DIR 65536tests/generic/684 +1
-0@@ -24,6 +24,7 @@ _cleanup() # Modify as appropriate. _require_user _require_test +_require_chmod verb=fpunch _require_xfs_io_command $verb _require_congruent_file_oplen $TEST_DIR 65536tests/generic/685 +1
-0@@ -24,6 +24,7 @@ _cleanup() # Modify as appropriate. _require_user _require_test +_require_chmod verb=fzero _require_xfs_io_command $verb _require_congruent_file_oplen $TEST_DIR 65536tests/generic/686 +1
-0@@ -24,6 +24,7 @@ _cleanup() # Modify as appropriate. _require_user _require_test +_require_chmod verb=finsert _require_xfs_io_command $verb _require_congruent_file_oplen $TEST_DIR 65536tests/generic/687 +1
-0@@ -24,6 +24,7 @@ _cleanup() # Modify as appropriate. _require_user _require_test +_require_chmod verb=fcollapse _require_xfs_io_command $verb _require_congruent_file_oplen $TEST_DIR 65536tests/generic/688 +1
-0@@ -23,6 +23,7 @@ _cleanup() # Modify as appropriate. _require_user +_require_chmod _require_command "$GETCAP_PROG" getcap _require_command "$SETCAP_PROG" setcap _require_xfs_io_command falloctests/generic/698 +1
-0@@ -26,6 +26,7 @@ _fixed_by_kernel_commit 168f91289340 \ "fs: account for group membership" _require_scratch _require_chown +_require_chmod _require_idmapped_mounts _require_test_program "vfs/mount-idmapped" _require_user fsgqa2tests/generic/699 +1
-0@@ -25,6 +25,7 @@ _require_extra_fs overlay _require_scratch _require_chown +_require_chmod _require_idmapped_mounts _require_test_program "vfs/mount-idmapped" _require_user fsgqa2tests/generic/726 +1
-0@@ -23,6 +23,7 @@ _begin_fstest auto fiexchange quick # Modify as appropriate. _require_user +_require_chmod _require_xfs_io_command exchangerange _require_xfs_io_command startupdate _require_scratchtests/generic/727 +1
-0@@ -24,6 +24,7 @@ _begin_fstest auto fiexchange quick # Modify as appropriate. _require_user +_require_chmod _require_command "$GETCAP_PROG" getcap _require_command "$SETCAP_PROG" setcap _require_xfs_io_command exchangerangetests/generic/792 +1
-0@@ -22,6 +22,7 @@ _cleanup() . ./common/dmflakey _require_scratch +_require_chmod _require_test_program unlink-fsync _require_dm_target flakeySignature · 1 line
2.55.0
PATCH 3/5 Add _require_chown as needed
In reply to Eric Sandeen--- tests/generic/093 | 1 + tests/generic/099 | 1 + tests/generic/105 | 1 + tests/generic/219 | 1 + tests/generic/230 | 1 + tests/generic/235 | 1 + tests/generic/237 | 1 + tests/generic/244 | 1 + tests/generic/305 | 1 + tests/generic/318 | 1 + tests/generic/326 | 1 + tests/generic/327 | 1 + tests/generic/328 | 1 + tests/generic/375 | 1 + tests/generic/379 | 1 + tests/generic/380 | 1 + tests/generic/400 | 1 + tests/generic/444 | 1 + tests/generic/462 | 1 + tests/generic/505 | 1 + tests/generic/566 | 1 + tests/generic/572 | 1 + tests/generic/587 | 1 + tests/generic/597 | 1 + tests/generic/598 | 1 + tests/generic/603 | 1 + tests/generic/681 | 1 + tests/generic/682 | 1 + tests/generic/709 | 1 + tests/generic/710 | 1 + tests/generic/721 | 1 + 31 files changed, 31 insertions(+)
tests/generic/093 +1 -0
@@ -29,6 +29,7 @@ filefilter() _require_test _require_attrs security _require_user +_require_chown _require_chmod _require_test_program "writemod" _require_command "$SETCAP_PROG" "setcap"
tests/generic/099 +1 -0
@@ -48,6 +48,7 @@ _cleanup() _require_test _require_chmod +_require_chown _require_runas _acl_setup_ids
tests/generic/105 +1 -0
@@ -26,6 +26,7 @@ _cleanup() _require_scratch +_require_chown _require_acls _acl_setup_ids
tests/generic/219 +1 -0
@@ -17,6 +17,7 @@ _begin_fstest auto quota quick mmap _require_scratch _require_quota _require_user +_require_chown _require_group _require_odirect
tests/generic/230 +1 -0
@@ -17,6 +17,7 @@ _begin_fstest auto quota quick _require_scratch _require_quota _require_user +_require_chown _require_chmod test_files()
tests/generic/235 +1 -0
@@ -17,6 +17,7 @@ _begin_fstest auto quota quick _require_scratch _require_quota _require_user +_require_chown do_repquota() {
tests/generic/237 +1 -0
@@ -25,6 +25,7 @@ _cleanup() # only Linux supports fallocate _require_test _require_runas +_require_chown _acl_setup_ids _require_acls
tests/generic/244 +1 -0
@@ -26,6 +26,7 @@ _cleanup() _require_quota _require_scratch +_require_chown _scratch_mkfs >> $seqres.full 2>&1
tests/generic/305 +1 -0
@@ -21,6 +21,7 @@ _require_xfs_io_command "fiemap" _require_quota _require_nobody _require_user +_require_chown echo "Format and mount" _scratch_mkfs > $seqres.full 2>&1
tests/generic/318 +1 -0
@@ -34,6 +34,7 @@ file=$SCRATCH_MNT/file1 _require_scratch _acl_setup_ids _require_acls +_require_chown _require_ugid_map _require_userns ns_acl1=0
tests/generic/326 +1 -0
@@ -22,6 +22,7 @@ _require_quota _require_nobody _require_odirect _require_user +_require_chown echo "Format and mount" _scratch_mkfs > $seqres.full 2>&1
tests/generic/327 +1 -0
@@ -20,6 +20,7 @@ _require_xfs_io_command "fiemap" _require_quota _require_nobody _require_user +_require_chown echo "Format and mount" _scratch_mkfs > $seqres.full 2>&1
tests/generic/328 +1 -0
@@ -21,6 +21,7 @@ _require_quota _require_nobody _require_odirect _require_user +_require_chown echo "Format and mount" _scratch_mkfs > $seqres.full 2>&1
tests/generic/375 +1 -0
@@ -16,6 +16,7 @@ _begin_fstest auto quick acl perms _require_test _require_chmod +_require_chown _require_runas _require_acls
tests/generic/379 +1 -0
@@ -23,6 +23,7 @@ _cleanup() _require_scratch +_require_chown _require_quota _require_xfs_quota_foreign
tests/generic/380 +1 -0
@@ -19,6 +19,7 @@ _begin_fstest quota auto quick # Modify as appropriate. _require_scratch +_require_chown _require_quota _require_xfs_quota_foreign
tests/generic/400 +1 -0
@@ -19,6 +19,7 @@ _begin_fstest auto quick quota _require_quota _require_scratch +_require_chown _scratch_mkfs >> $seqres.full 2>&1
tests/generic/444 +1 -0
@@ -16,6 +16,7 @@ _begin_fstest auto quick acl perms _require_test _require_chmod +_require_chown _require_runas _require_acls
tests/generic/462 +1 -0
@@ -20,6 +20,7 @@ _begin_fstest auto quick dax mmap # Modify as appropriate. _require_test _require_chmod +_require_chown _require_scratch_dax_mountopt "dax" _require_test_program "t_mmap_write_ro" # running by unpriviliged user is not necessary to reproduce
tests/generic/505 +1 -0
@@ -25,6 +25,7 @@ _begin_fstest shutdown auto quick metadata _require_scratch +_require_chown _require_scratch_shutdown _scratch_mkfs >/dev/null 2>&1
tests/generic/566 +1 -0
@@ -27,6 +27,7 @@ _require_scratch _require_quota _require_xfs_quota_foreign _require_user +_require_chown _qmount_option "grpquota" _scratch_mkfs > $seqres.full
tests/generic/572 +1 -0
@@ -28,6 +28,7 @@ _cleanup() _require_scratch_verity _require_chmod +_require_chown _disable_fsverity_signatures _scratch_mkfs_verity &>> $seqres.full
tests/generic/587 +1 -0
@@ -20,6 +20,7 @@ _begin_fstest auto quick rw prealloc quota . ./common/quota _require_user +_require_chown _require_quota _require_xfs_io_command "falloc" _require_scratch
tests/generic/597 +1 -0
@@ -28,6 +28,7 @@ _cleanup() # Modify as appropriate. _require_test _require_chmod +_require_chown _require_sysctl_variable fs.protected_symlinks _require_sysctl_variable fs.protected_hardlinks _require_user fsgqa2
tests/generic/598 +1 -0
@@ -35,6 +35,7 @@ _require_group fsgqa2 _require_user fsgqa _require_group fsgqa _require_chmod +_require_chown USER1=fsgqa2 USER2=fsgqa
tests/generic/603 +1 -0
@@ -116,6 +116,7 @@ _require_quota _require_user _require_group _require_chmod +_require_chown _scratch_mkfs >$seqres.full 2>&1 _scratch_enable_pquota
tests/generic/681 +1 -0
@@ -23,6 +23,7 @@ _begin_fstest auto quick quota _require_quota _require_user _require_scratch +_require_chown _scratch_mkfs > "$seqres.full" 2>&1 _qmount_option usrquota
tests/generic/682 +1 -0
@@ -24,6 +24,7 @@ _require_quota _require_user _require_scratch _require_chmod +_require_chown _scratch_mkfs > "$seqres.full" 2>&1 _qmount_option usrquota
tests/generic/709 +1 -0
@@ -15,6 +15,7 @@ _begin_fstest auto quick fiexchange quota _require_xfs_io_command exchangerange _require_user +_require_chown _require_nobody _require_quota _require_xfs_quota
tests/generic/710 +1 -0
@@ -15,6 +15,7 @@ _begin_fstest auto quick fiexchange quota _require_xfs_io_command exchangerange _require_user +_require_chown _require_nobody _require_quota _require_xfs_quota
tests/generic/721 +1 -0
@@ -25,6 +25,7 @@ _require_xfs_io_command startupdate _require_test_reflink _require_test _require_user +_require_chown filesnap() { echo "$1"
Signature · 1 line
2.55.0
Re: [PATCH 3/5] Add _require_chown as needed
Quoted 2 lines · Eric Sandeen
Signed-off-by Eric Sandeen <[email protected]>---
I doubt there's any filesystem that supports chmod but not chown.
Quoted 409 lines
tests/generic/093 | 1 + tests/generic/099 | 1 + tests/generic/105 | 1 + tests/generic/219 | 1 + tests/generic/230 | 1 + tests/generic/235 | 1 + tests/generic/237 | 1 + tests/generic/244 | 1 + tests/generic/305 | 1 + tests/generic/318 | 1 + tests/generic/326 | 1 + tests/generic/327 | 1 + tests/generic/328 | 1 + tests/generic/375 | 1 + tests/generic/379 | 1 + tests/generic/380 | 1 + tests/generic/400 | 1 + tests/generic/444 | 1 + tests/generic/462 | 1 + tests/generic/505 | 1 + tests/generic/566 | 1 + tests/generic/572 | 1 + tests/generic/587 | 1 + tests/generic/597 | 1 + tests/generic/598 | 1 + tests/generic/603 | 1 + tests/generic/681 | 1 + tests/generic/682 | 1 + tests/generic/709 | 1 + tests/generic/710 | 1 + tests/generic/721 | 1 + 31 files changed, 31 insertions(+)tests/generic/093 +1
-0@@ -29,6 +29,7 @@ filefilter() _require_test _require_attrs security _require_user +_require_chown _require_chmod _require_test_program "writemod" _require_command "$SETCAP_PROG" "setcap"tests/generic/099 +1
-0@@ -48,6 +48,7 @@ _cleanup() _require_test _require_chmod +_require_chown _require_runas _acl_setup_idstests/generic/105 +1
-0@@ -26,6 +26,7 @@ _cleanup() _require_scratch +_require_chown _require_acls _acl_setup_idstests/generic/219 +1
-0@@ -17,6 +17,7 @@ _begin_fstest auto quota quick mmap _require_scratch _require_quota _require_user +_require_chown _require_group _require_odirecttests/generic/230 +1
-0@@ -17,6 +17,7 @@ _begin_fstest auto quota quick _require_scratch _require_quota _require_user +_require_chown _require_chmod test_files()tests/generic/235 +1
-0@@ -17,6 +17,7 @@ _begin_fstest auto quota quick _require_scratch _require_quota _require_user +_require_chown do_repquota() {tests/generic/237 +1
-0@@ -25,6 +25,7 @@ _cleanup() # only Linux supports fallocate _require_test _require_runas +_require_chown _acl_setup_ids _require_aclstests/generic/244 +1
-0@@ -26,6 +26,7 @@ _cleanup() _require_quota _require_scratch +_require_chown _scratch_mkfs >> $seqres.full 2>&1tests/generic/305 +1
-0@@ -21,6 +21,7 @@ _require_xfs_io_command "fiemap" _require_quota _require_nobody _require_user +_require_chown echo "Format and mount" _scratch_mkfs > $seqres.full 2>&1tests/generic/318 +1
-0@@ -34,6 +34,7 @@ file=$SCRATCH_MNT/file1 _require_scratch _acl_setup_ids _require_acls +_require_chown _require_ugid_map _require_userns ns_acl1=0tests/generic/326 +1
-0@@ -22,6 +22,7 @@ _require_quota _require_nobody _require_odirect _require_user +_require_chown echo "Format and mount" _scratch_mkfs > $seqres.full 2>&1tests/generic/327 +1
-0@@ -20,6 +20,7 @@ _require_xfs_io_command "fiemap" _require_quota _require_nobody _require_user +_require_chown echo "Format and mount" _scratch_mkfs > $seqres.full 2>&1tests/generic/328 +1
-0@@ -21,6 +21,7 @@ _require_quota _require_nobody _require_odirect _require_user +_require_chown echo "Format and mount" _scratch_mkfs > $seqres.full 2>&1tests/generic/375 +1
-0@@ -16,6 +16,7 @@ _begin_fstest auto quick acl perms _require_test _require_chmod +_require_chown _require_runas _require_aclstests/generic/379 +1
-0@@ -23,6 +23,7 @@ _cleanup() _require_scratch +_require_chown _require_quota _require_xfs_quota_foreigntests/generic/380 +1
-0@@ -19,6 +19,7 @@ _begin_fstest quota auto quick # Modify as appropriate. _require_scratch +_require_chown _require_quota _require_xfs_quota_foreigntests/generic/400 +1
-0@@ -19,6 +19,7 @@ _begin_fstest auto quick quota _require_quota _require_scratch +_require_chown _scratch_mkfs >> $seqres.full 2>&1tests/generic/444 +1
-0@@ -16,6 +16,7 @@ _begin_fstest auto quick acl perms _require_test _require_chmod +_require_chown _require_runas _require_aclstests/generic/462 +1
-0@@ -20,6 +20,7 @@ _begin_fstest auto quick dax mmap # Modify as appropriate. _require_test _require_chmod +_require_chown _require_scratch_dax_mountopt "dax" _require_test_program "t_mmap_write_ro" # running by unpriviliged user is not necessary to reproducetests/generic/505 +1
-0@@ -25,6 +25,7 @@ _begin_fstest shutdown auto quick metadata _require_scratch +_require_chown _require_scratch_shutdown _scratch_mkfs >/dev/null 2>&1tests/generic/566 +1
-0@@ -27,6 +27,7 @@ _require_scratch _require_quota _require_xfs_quota_foreign _require_user +_require_chown _qmount_option "grpquota" _scratch_mkfs > $seqres.fulltests/generic/572 +1
-0@@ -28,6 +28,7 @@ _cleanup() _require_scratch_verity _require_chmod +_require_chown _disable_fsverity_signatures _scratch_mkfs_verity &>> $seqres.fulltests/generic/587 +1
-0@@ -20,6 +20,7 @@ _begin_fstest auto quick rw prealloc quota . ./common/quota _require_user +_require_chown _require_quota _require_xfs_io_command "falloc" _require_scratchtests/generic/597 +1
-0@@ -28,6 +28,7 @@ _cleanup() # Modify as appropriate. _require_test _require_chmod +_require_chown _require_sysctl_variable fs.protected_symlinks _require_sysctl_variable fs.protected_hardlinks _require_user fsgqa2tests/generic/598 +1
-0@@ -35,6 +35,7 @@ _require_group fsgqa2 _require_user fsgqa _require_group fsgqa _require_chmod +_require_chown USER1=fsgqa2 USER2=fsgqatests/generic/603 +1
-0@@ -116,6 +116,7 @@ _require_quota _require_user _require_group _require_chmod +_require_chown _scratch_mkfs >$seqres.full 2>&1 _scratch_enable_pquotatests/generic/681 +1
-0@@ -23,6 +23,7 @@ _begin_fstest auto quick quota _require_quota _require_user _require_scratch +_require_chown _scratch_mkfs > "$seqres.full" 2>&1 _qmount_option usrquotatests/generic/682 +1
-0@@ -24,6 +24,7 @@ _require_quota _require_user _require_scratch _require_chmod +_require_chown _scratch_mkfs > "$seqres.full" 2>&1 _qmount_option usrquotatests/generic/709 +1
-0@@ -15,6 +15,7 @@ _begin_fstest auto quick fiexchange quota _require_xfs_io_command exchangerange _require_user +_require_chown _require_nobody _require_quota _require_xfs_quotatests/generic/710 +1
-0@@ -15,6 +15,7 @@ _begin_fstest auto quick fiexchange quota _require_xfs_io_command exchangerange _require_user +_require_chown _require_nobody _require_quota _require_xfs_quotatests/generic/721 +1
-0@@ -25,6 +25,7 @@ _require_xfs_io_command startupdate _require_test_reflink _require_test _require_user +_require_chown filesnap() { echo "$1"Signature · 1 line
2.55.0
Re: [PATCH 3/5] Add _require_chown as needed
Quoted 6 lines · Zorro Lang
Quoted 2 lines · Eric Sandeen
Signed-off-by Eric Sandeen <[email protected]>---
I doubt there's any filesystem that supports
chmodbut notchown.Reviewed-by Zorro Lang <[email protected]>
Yep, I'm not sure why we have both helpers, tbh ...
hey, you asked for ful _requirel annotation so .... ;)
Thanks,
-Eric
Re: [PATCH 3/5] Add _require_chown as needed
Quoted 11 lines · Eric Sandeen
Quoted 6 lines · Zorro Lang
Quoted 2 lines · Eric Sandeen
Signed-off-by Eric Sandeen <[email protected]>---
I doubt there's any filesystem that supports
chmodbut notchown.Reviewed-by Zorro Lang <[email protected]>Yep, I'm not sure why we have both helpers, tbh ...
hey, you asked for ful
_requirelannotation so .... ;)
Haha, I just wanted to add the same _require_ to patches that were copy-pasted from the same template. I wasn't planning on updating all cases across the fstests. Generally, for test cases that are already merged, we usually don't add extra _require checks unless there's an obvious failure. Anyway, since you've already gone through and updated everything, the current changes look good to me:)
Quoted 5 lines
Thanks,
-Eric
Re: [PATCH 3/5] Add _require_chown as needed
Quoted 11 lines · Zorro Lang
Quoted 10 lines · Eric Sandeen
Quoted 6 lines · Zorro Lang
Quoted 2 lines · Eric Sandeen
Signed-off-by Eric Sandeen <[email protected]>---
I doubt there's any filesystem that supports
chmodbut notchown.Reviewed-by Zorro Lang <[email protected]>Yep, I'm not sure why we have both helpers, tbh ...
Quoted 8 lines
Quoted 1 line
hey, you asked for ful
_requirelannotation so .... ;)Haha, I just wanted to add the same _require_ to patches that were copy-pasted from the same template. I wasn't planning on updating all cases across the fstests. Generally, for test cases that are already merged, we usually don't add extra
_requirechecks unless there's an obvious failure. Anyway, since you've already gone through and updated everything, the current changes look good to me:)
Ok, I will leave it up to you whether you want this series, or the trivial targeted patch I sent first, which is the only one addressing an observed problem. :)
-Eric
PATCH 4/5 Add _require_hardlinks as needed
In reply to Eric Sandeen--- tests/generic/066 | 1 + tests/generic/084 | 1 + tests/generic/398 | 1 + tests/generic/423 | 1 + tests/generic/440 | 1 + tests/generic/479 | 1 + tests/generic/520 | 1 + tests/generic/556 | 1 + tests/generic/572 | 1 + tests/generic/597 | 1 + tests/generic/681 | 1 + tests/generic/682 | 1 + tests/generic/782 | 1 + tests/generic/789 | 1 + tests/generic/790 | 1 + 15 files changed, 15 insertions(+)
tests/generic/066 +1 -0
@@ -34,6 +34,7 @@ _cleanup() . ./common/attr _require_scratch +_require_hardlinks _require_dm_target flakey _require_attrs
tests/generic/084 +1 -0
@@ -25,6 +25,7 @@ _cleanup() . ./common/filter _require_scratch +_require_hardlinks link_unlink_storm() {
tests/generic/398 +1 -0
@@ -20,6 +20,7 @@ _begin_fstest auto quick encrypt . ./common/renameat2 _require_scratch_encryption +_require_hardlinks _require_renameat2 exchange _init_session_keyring
tests/generic/423 +1 -0
@@ -27,6 +27,7 @@ _require_test_program "stat_test" _require_test_program "af_unix" _require_statx _require_symlinks +_require_hardlinks _require_mknod function check_stat () {
tests/generic/440 +1 -0
@@ -20,6 +20,7 @@ _begin_fstest auto quick encrypt _require_scratch_encryption _require_symlinks +_require_hardlinks _require_command "$KEYCTL_PROG" keyctl # Set up an encryption-capable filesystem and an encryption key.
tests/generic/479 +1 -0
@@ -26,6 +26,7 @@ _cleanup() _require_scratch _require_symlinks +_require_hardlinks _require_mknod _require_dm_target flakey
tests/generic/520 +1 -0
@@ -28,6 +28,7 @@ _cleanup() fssize=$((2**20 * 256)) _require_scratch_nocheck +_require_hardlinks _require_dm_target flakey # initialize scratch device
tests/generic/556 +1 -0
@@ -15,6 +15,7 @@ _begin_fstest auto quick casefold _require_scratch_nocheck _require_scratch_casefold _require_symlinks +_require_hardlinks _require_check_dmesg _require_attrs
tests/generic/572 +1 -0
@@ -29,6 +29,7 @@ _cleanup() _require_scratch_verity _require_chmod _require_chown +_require_hardlinks _disable_fsverity_signatures _scratch_mkfs_verity &>> $seqres.full
tests/generic/597 +1 -0
@@ -37,6 +37,7 @@ _require_group fsgqa2 _require_user fsgqa _require_group fsgqa _require_symlinks +_require_hardlinks OWNER=fsgqa2 OTHER=fsgqa
tests/generic/681 +1 -0
@@ -24,6 +24,7 @@ _require_quota _require_user _require_scratch _require_chown +_require_hardlinks _scratch_mkfs > "$seqres.full" 2>&1 _qmount_option usrquota
tests/generic/682 +1 -0
@@ -25,6 +25,7 @@ _require_user _require_scratch _require_chmod _require_chown +_require_hardlinks _scratch_mkfs > "$seqres.full" 2>&1 _qmount_option usrquota
tests/generic/782 +1 -0
@@ -23,6 +23,7 @@ _cleanup() . ./common/dmflakey _require_scratch +_require_hardlinks _require_dm_target flakey _fixed_by_fs_commit btrfs bfe3d755ef7c \
tests/generic/789 +1 -0
@@ -22,6 +22,7 @@ _cleanup() . ./common/dmflakey _require_scratch +_require_hardlinks _require_dm_target flakey _fixed_by_fs_commit btrfs 5254d4181add \
tests/generic/790 +1 -0
@@ -25,6 +25,7 @@ _cleanup() . ./common/dmflakey _require_scratch +_require_hardlinks _require_dm_target flakey _fixed_by_fs_commit btrfs 9573a365ff9f \
Signature · 1 line
2.55.0
Re: [PATCH 4/5] Add _require_hardlinks as needed
Quoted 2 lines · Eric Sandeen
Signed-off-by Eric Sandeen <[email protected]>---
Quoted 201 lines
tests/generic/066 | 1 + tests/generic/084 | 1 + tests/generic/398 | 1 + tests/generic/423 | 1 + tests/generic/440 | 1 + tests/generic/479 | 1 + tests/generic/520 | 1 + tests/generic/556 | 1 + tests/generic/572 | 1 + tests/generic/597 | 1 + tests/generic/681 | 1 + tests/generic/682 | 1 + tests/generic/782 | 1 + tests/generic/789 | 1 + tests/generic/790 | 1 + 15 files changed, 15 insertions(+)tests/generic/066 +1
-0@@ -34,6 +34,7 @@ _cleanup() . ./common/attr _require_scratch +_require_hardlinks _require_dm_target flakey _require_attrstests/generic/084 +1
-0@@ -25,6 +25,7 @@ _cleanup() . ./common/filter _require_scratch +_require_hardlinks link_unlink_storm() {tests/generic/398 +1
-0@@ -20,6 +20,7 @@ _begin_fstest auto quick encrypt . ./common/renameat2 _require_scratch_encryption +_require_hardlinks _require_renameat2 exchange _init_session_keyringtests/generic/423 +1
-0@@ -27,6 +27,7 @@ _require_test_program "stat_test" _require_test_program "af_unix" _require_statx _require_symlinks +_require_hardlinks _require_mknod function check_stat () {tests/generic/440 +1
-0@@ -20,6 +20,7 @@ _begin_fstest auto quick encrypt _require_scratch_encryption _require_symlinks +_require_hardlinks _require_command "$KEYCTL_PROG" keyctl # Set up an encryption-capable filesystem and an encryption key.tests/generic/479 +1
-0@@ -26,6 +26,7 @@ _cleanup() _require_scratch _require_symlinks +_require_hardlinks _require_mknod _require_dm_target flakeytests/generic/520 +1
-0@@ -28,6 +28,7 @@ _cleanup() fssize=$((2**20 * 256)) _require_scratch_nocheck +_require_hardlinks _require_dm_target flakey # initialize scratch devicetests/generic/556 +1
-0@@ -15,6 +15,7 @@ _begin_fstest auto quick casefold _require_scratch_nocheck _require_scratch_casefold _require_symlinks +_require_hardlinks _require_check_dmesg _require_attrstests/generic/572 +1
-0@@ -29,6 +29,7 @@ _cleanup() _require_scratch_verity _require_chmod _require_chown +_require_hardlinks _disable_fsverity_signatures _scratch_mkfs_verity &>> $seqres.fulltests/generic/597 +1
-0@@ -37,6 +37,7 @@ _require_group fsgqa2 _require_user fsgqa _require_group fsgqa _require_symlinks +_require_hardlinks OWNER=fsgqa2 OTHER=fsgqatests/generic/681 +1
-0@@ -24,6 +24,7 @@ _require_quota _require_user _require_scratch _require_chown +_require_hardlinks _scratch_mkfs > "$seqres.full" 2>&1 _qmount_option usrquotatests/generic/682 +1
-0@@ -25,6 +25,7 @@ _require_user _require_scratch _require_chmod _require_chown +_require_hardlinks _scratch_mkfs > "$seqres.full" 2>&1 _qmount_option usrquotatests/generic/782 +1
-0@@ -23,6 +23,7 @@ _cleanup() . ./common/dmflakey _require_scratch +_require_hardlinks _require_dm_target flakey _fixed_by_fs_commit btrfs bfe3d755ef7c \tests/generic/789 +1
-0@@ -22,6 +22,7 @@ _cleanup() . ./common/dmflakey _require_scratch +_require_hardlinks _require_dm_target flakey _fixed_by_fs_commit btrfs 5254d4181add \tests/generic/790 +1
-0@@ -25,6 +25,7 @@ _cleanup() . ./common/dmflakey _require_scratch +_require_hardlinks _require_dm_target flakey _fixed_by_fs_commit btrfs 9573a365ff9f \Signature · 1 line
2.55.0
PATCH 5/5 Add _require_mknod as needed
In reply to Eric Sandeen--- tests/generic/398 | 1 + tests/generic/598 | 1 + 2 files changed, 2 insertions(+)
tests/generic/398 +1 -0
@@ -21,6 +21,7 @@ _begin_fstest auto quick encrypt _require_scratch_encryption _require_hardlinks +_require_mknod _require_renameat2 exchange _init_session_keyring
tests/generic/598 +1 -0
@@ -36,6 +36,7 @@ _require_user fsgqa _require_group fsgqa _require_chmod _require_chown +_require_mknod USER1=fsgqa2 USER2=fsgqa
Signature · 1 line
2.55.0
Re: [PATCH 5/5] Add _require_mknod as needed
Quoted 2 lines · Eric Sandeen
Signed-off-by Eric Sandeen <[email protected]>---
Quoted 32 lines
tests/generic/398 | 1 + tests/generic/598 | 1 + 2 files changed, 2 insertions(+)tests/generic/398 +1
-0@@ -21,6 +21,7 @@ _begin_fstest auto quick encrypt _require_scratch_encryption _require_hardlinks +_require_mknod _require_renameat2 exchange _init_session_keyringtests/generic/598 +1
-0@@ -36,6 +36,7 @@ _require_user fsgqa _require_group fsgqa _require_chmod _require_chown +_require_mknod USER1=fsgqa2 USER2=fsgqaSignature · 1 line
2.55.0