Skip to contentSkip to conversation

ALSA: hda: cs35l41: Support HP OmniBook 7 Laptop 16-bh0xxx

PATCH Superseded Sven Jans 2 participants 3 messages May 6 – May 7

Subsystems (2)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Sven Jans

author
#0 lore raw

PATCH 1/1 ALSA: hda: cs35l41: Support HP OmniBook 7 Laptop 16-bh0xxx

The laptop has _DSD but the cirrus,dev-index property fails to parse, so it needs to be supported using the configuration table.

---
 sound/hda/codecs/side-codecs/cs35l41_hda_property.c | 2 ++
 1 file changed, 2 insertions(+)
sound/hda/codecs/side-codecs/cs35l41_hda_property.c +2 -0
index 732ae534db36..a972da0ae4e1 100644
@@ -85,6 +85,7 @@ static const struct cs35l41_config cs35l41_config_table[] = {
 	{ "103C8C51", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 },
 	{ "103C8CDD", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 },
 	{ "103C8CDE", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 3900, 24 },
+	{ "103C8E60", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
 	{ "104312AF", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
 	{ "10431433", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
 	{ "10431463", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
@@ -510,6 +511,7 @@ static const struct cs35l41_prop_model cs35l41_prop_model_table[] = {
 	{ "CSC3551", "103C8C6A", hp_i2c_int_2amp_dual_spkid },
 	{ "CSC3551", "103C8CDD", generic_dsd_config },
 	{ "CSC3551", "103C8CDE", generic_dsd_config },
+	{ "CSC3551", "103C8E60", generic_dsd_config },
 	{ "CSC3551", "104312AF", generic_dsd_config },
 	{ "CSC3551", "10431433", generic_dsd_config },
 	{ "CSC3551", "10431463", generic_dsd_config },
Signature · 1 line
2.54.0
#1 lore raw

Hi,

Quoted 2 lines · Sven Jans

The laptop has _DSD but the cirrus,dev-index property fails to parse, so it needs to be supported using the configuration table.

This is quite odd. As far as I am aware, this laptop should have valid _DSD.

I don't think some of the values in the table are correct either.

Please create a bugzilla ticket at the below address and CC Cirrus Patches ([email protected] <mailto:[email protected]>) to it, we will investigate the issue as soon as we can.

https://bugzilla.kernel.org/ <https://bugzilla.kernel.org/>

Please attach an acpi dump and dmesg to the ticket.

Thanks,

Stefan

Quoted 25 lines
---
 sound/hda/codecs/side-codecs/cs35l41_hda_property.c | 2 ++
 1 file changed, 2 insertions(+)
sound/hda/codecs/side-codecs/cs35l41_hda_property.c +2 -0
index 732ae534db36..a972da0ae4e1 100644
@@ -85,6 +85,7 @@ static const struct cs35l41_config cs35l41_config_table[] = {
 	{ "103C8C51", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 },
 	{ "103C8CDD", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 },
 	{ "103C8CDE", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 3900, 24 },
+	{ "103C8E60", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
 	{ "104312AF", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
 	{ "10431433", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
 	{ "10431463", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
@@ -510,6 +511,7 @@ static const struct cs35l41_prop_model cs35l41_prop_model_table[] = {
 	{ "CSC3551", "103C8C6A", hp_i2c_int_2amp_dual_spkid },
 	{ "CSC3551", "103C8CDD", generic_dsd_config },
 	{ "CSC3551", "103C8CDE", generic_dsd_config },
+	{ "CSC3551", "103C8E60", generic_dsd_config },
 	{ "CSC3551", "104312AF", generic_dsd_config },
 	{ "CSC3551", "10431433", generic_dsd_config },
 	{ "CSC3551", "10431463", generic_dsd_config },
author
#2 lore raw

Hello,
I have created a bugzilla ticket.

I do think most values are correct with the ACPI dump I looked at, the only one that could be incorrect is the boost type, but I haven't had any issues while playing audio using INTERNAL, even at max volume.

Regards,
Sven

Quoted 45 lines · Stefan Binding

Hi,

Quoted 2 lines · Sven Jans

The laptop has _DSD but the cirrus,dev-index property fails to parse, so it needs to be supported using the configuration table.

This is quite odd. As far as I am aware, this laptop should have valid _DSD.

I don't think some of the values in the table are correct either.

Please create a bugzilla ticket at the below address and CC Cirrus Patches ([email protected] <mailto:[email protected]>) to it, we will investigate the issue as soon as we can.

https://bugzilla.kernel.org/ <https://bugzilla.kernel.org/>

Please attach an acpi dump and dmesg to the ticket.

Thanks,

Stefan

Quoted 25 lines
---
  sound/hda/codecs/side-codecs/cs35l41_hda_property.c | 2 ++
  1 file changed, 2 insertions(+)
sound/hda/codecs/side-codecs/cs35l41_hda_property.c +2 -0
index 732ae534db36..a972da0ae4e1 100644
@@ -85,6 +85,7 @@ static const struct cs35l41_config cs35l41_config_table[] = {
  	{ "103C8C51", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 },
  	{ "103C8CDD", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4100, 24 },
  	{ "103C8CDE", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 3900, 24 },
+	{ "103C8E60", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
  	{ "104312AF", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 1, 2, 0, 1000, 4500, 24 },
  	{ "10431433", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
  	{ "10431463", 2, INTERNAL, { CS35L41_LEFT, CS35L41_RIGHT, 0, 0 }, 0, 1, -1, 1000, 4500, 24 },
@@ -510,6 +511,7 @@ static const struct cs35l41_prop_model cs35l41_prop_model_table[] = {
  	{ "CSC3551", "103C8C6A", hp_i2c_int_2amp_dual_spkid },
  	{ "CSC3551", "103C8CDD", generic_dsd_config },
  	{ "CSC3551", "103C8CDE", generic_dsd_config },
+	{ "CSC3551", "103C8E60", generic_dsd_config },
  	{ "CSC3551", "104312AF", generic_dsd_config },
  	{ "CSC3551", "10431433", generic_dsd_config },
  	{ "CSC3551", "10431463", generic_dsd_config },