Skip to contentSkip to conversation

Hyper-V netvsc PMD and VMBus support

PATCH Superseded Stephen Hemminger 4 participants 10 messages May 9, 2018 – May 13, 2018

Subsystems (2)

v6 of 12 Superseded Latest is v12 →

lore
Share & tools
lore
#0 lore raw

v6 cover Hyper-V netvsc PMD and VMBus support

This is a revised version of the Hyper-V native bus (VMBus) and network device (netvsc) drivers. This virtual device is used in Microsoft Hyper-V in Windows 10, Windows Server 2016 and Azure. Most of this code was extracted from FreeBSD and some of this is from earlier code donated by Brocade.

Only Linux is supported at present, but the code is split to allow future FreeBSD and Windows support.

This version works with upstream kernel (4.16) but in that mode only a single queue is supported. With additional patches that are pending for 5.0 kernel, multi-queue support works as well.

Device binding is best done via driverctl; this required some additional fixes to kernel and driverctl to work correctly. Linux kernel vmbus support needed to support sysfs driver_override and driverctl needed to handle non-PCI bus from udev.
https://gitlab.com/driverctl/driverctl/merge_requests/3
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-April/118889.html

v6
- rebase to current 18.05
- fix RSS initialization
- minor documentation fixes

v5
- rebase to current 18.05
- fix message from vmbus due to race on sysfs for sub channel

v4
- don't enable by default because of uuid library dependency
- api's are internal no need to mark experimental
- add netvsc ini file
- fix MAINTAINERS entry

v3
- fix documentation to format correctly and include more info about binding
- fix build on 32 bit
- minor white space and indentation fixes

Stephen Hemminger (4):
bus/vmbus: add hyper-v virtual bus support net/netvsc: add hyper-v netvsc network device net/netvsc: add documentation
bus/vmbus and net/netvsc: add meson build support

 MAINTAINERS                                   |   11 +
 config/common_base                            |   13 +
 config/meson.build                            |    7 +
 doc/guides/nics/features/netvsc.ini           |   23 +
 doc/guides/nics/index.rst                     |    1 +
 doc/guides/nics/netvsc.rst                    |   98 ++
 doc/guides/rel_notes/release_18_05.rst        |    5 +
 drivers/bus/Makefile                          |    1 +
 drivers/bus/meson.build                       |    2 +-
 drivers/bus/vmbus/Makefile                    |   36 +
 drivers/bus/vmbus/linux/Makefile              |    3 +
 drivers/bus/vmbus/linux/vmbus_bus.c           |  355 +++++
 drivers/bus/vmbus/linux/vmbus_uio.c           |  390 ++++++
 drivers/bus/vmbus/meson.build                 |   16 +
 drivers/bus/vmbus/private.h                   |  132 ++
 drivers/bus/vmbus/rte_bus_vmbus.h             |  397 ++++++
 drivers/bus/vmbus/rte_bus_vmbus_version.map   |   28 +
 drivers/bus/vmbus/rte_vmbus_reg.h             |  344 +++++
 drivers/bus/vmbus/vmbus_bufring.c             |  241 ++++
 drivers/bus/vmbus/vmbus_channel.c             |  406 ++++++
 drivers/bus/vmbus/vmbus_common.c              |  286 ++++
 drivers/bus/vmbus/vmbus_common_uio.c          |  232 ++++
 drivers/net/Makefile                          |    1 +
 drivers/net/meson.build                       |    2 +-
 drivers/net/netvsc/Makefile                   |   23 +
 drivers/net/netvsc/hn_ethdev.c                |  728 ++++++++++
 drivers/net/netvsc/hn_logs.h                  |   35 +
 drivers/net/netvsc/hn_nvs.c                   |  533 +++++++
 drivers/net/netvsc/hn_nvs.h                   |  243 ++++
 drivers/net/netvsc/hn_rndis.c                 | 1099 +++++++++++++++
 drivers/net/netvsc/hn_rndis.h                 |   26 +
 drivers/net/netvsc/hn_rxtx.c                  | 1221 +++++++++++++++++
 drivers/net/netvsc/hn_var.h                   |  139 ++
 drivers/net/netvsc/meson.build                |   13 +
 drivers/net/netvsc/ndis.h                     |  378 +++++
 drivers/net/netvsc/rndis.h                    |  414 ++++++
 drivers/net/netvsc/rte_pmd_netvsc_version.map |    5 +
 mk/rte.app.mk                                 |    2 +
 38 files changed, 7887 insertions(+), 2 deletions(-)
 create mode 100644 doc/guides/nics/features/netvsc.ini
 create mode 100644 doc/guides/nics/netvsc.rst
 create mode 100644 drivers/bus/vmbus/Makefile
 create mode 100644 drivers/bus/vmbus/linux/Makefile
 create mode 100644 drivers/bus/vmbus/linux/vmbus_bus.c
 create mode 100644 drivers/bus/vmbus/linux/vmbus_uio.c
 create mode 100644 drivers/bus/vmbus/meson.build
 create mode 100644 drivers/bus/vmbus/private.h
 create mode 100644 drivers/bus/vmbus/rte_bus_vmbus.h
 create mode 100644 drivers/bus/vmbus/rte_bus_vmbus_version.map
 create mode 100644 drivers/bus/vmbus/rte_vmbus_reg.h
 create mode 100644 drivers/bus/vmbus/vmbus_bufring.c
 create mode 100644 drivers/bus/vmbus/vmbus_channel.c
 create mode 100644 drivers/bus/vmbus/vmbus_common.c
 create mode 100644 drivers/bus/vmbus/vmbus_common_uio.c
 create mode 100644 drivers/net/netvsc/Makefile
 create mode 100644 drivers/net/netvsc/hn_ethdev.c
 create mode 100644 drivers/net/netvsc/hn_logs.h
 create mode 100644 drivers/net/netvsc/hn_nvs.c
 create mode 100644 drivers/net/netvsc/hn_nvs.h
 create mode 100644 drivers/net/netvsc/hn_rndis.c
 create mode 100644 drivers/net/netvsc/hn_rndis.h
 create mode 100644 drivers/net/netvsc/hn_rxtx.c
 create mode 100644 drivers/net/netvsc/hn_var.h
 create mode 100644 drivers/net/netvsc/meson.build
 create mode 100644 drivers/net/netvsc/ndis.h
 create mode 100644 drivers/net/netvsc/rndis.h
 create mode 100644 drivers/net/netvsc/rte_pmd_netvsc_version.map
Signature · 1 line
2.17.0
#1 lore raw

PATCH v6 1/4 bus/vmbus: add hyper-v virtual bus support

This patch adds support for an additional bus type Virtual Machine BUS (VMBUS) on Microsoft Hyper-V in Windows 10, Windows Server 2016 and Azure. Most of this code was extracted from FreeBSD and some of this is from earlier code donated by Brocade.

Only Linux is supported at present, but the code is split to allow future FreeBSD and Windows support.

The bus support relies on the uio_hv_generic driver from Linux kernel 4.16. Multiple queue support requires additional sysfs interfaces which is in kernel 5.0 (a.k.a 4.17).

---
 MAINTAINERS                                 |   3 +
 config/common_base                          |   5 +
 drivers/bus/Makefile                        |   1 +
 drivers/bus/vmbus/Makefile                  |  36 ++
 drivers/bus/vmbus/linux/Makefile            |   3 +
 drivers/bus/vmbus/linux/vmbus_bus.c         | 355 +++++++++++++++++
 drivers/bus/vmbus/linux/vmbus_uio.c         | 390 +++++++++++++++++++
 drivers/bus/vmbus/private.h                 | 132 +++++++
 drivers/bus/vmbus/rte_bus_vmbus.h           | 397 +++++++++++++++++++
 drivers/bus/vmbus/rte_bus_vmbus_version.map |  28 ++
 drivers/bus/vmbus/rte_vmbus_reg.h           | 344 +++++++++++++++++
 drivers/bus/vmbus/vmbus_bufring.c           | 241 ++++++++++++
 drivers/bus/vmbus/vmbus_channel.c           | 406 ++++++++++++++++++++
 drivers/bus/vmbus/vmbus_common.c            | 286 ++++++++++++++
 drivers/bus/vmbus/vmbus_common_uio.c        | 232 +++++++++++
 mk/rte.app.mk                               |   1 +
 16 files changed, 2860 insertions(+)
 create mode 100644 drivers/bus/vmbus/Makefile
 create mode 100644 drivers/bus/vmbus/linux/Makefile
 create mode 100644 drivers/bus/vmbus/linux/vmbus_bus.c
 create mode 100644 drivers/bus/vmbus/linux/vmbus_uio.c
 create mode 100644 drivers/bus/vmbus/private.h
 create mode 100644 drivers/bus/vmbus/rte_bus_vmbus.h
 create mode 100644 drivers/bus/vmbus/rte_bus_vmbus_version.map
 create mode 100644 drivers/bus/vmbus/rte_vmbus_reg.h
 create mode 100644 drivers/bus/vmbus/vmbus_bufring.c
 create mode 100644 drivers/bus/vmbus/vmbus_channel.c
 create mode 100644 drivers/bus/vmbus/vmbus_common.c
 create mode 100644 drivers/bus/vmbus/vmbus_common_uio.c
MAINTAINERS +3 -0
index 7105920f35f7..46cb08986189 100644
@@ -395,6 +395,9 @@ F: drivers/bus/pci/
 VDEV bus driver
 F: drivers/bus/vdev/
 
+VMBUS bus driver
+M: Stephen Hemminger <[email protected]>
+F: drivers/bus/vmbus/
 
 Networking Drivers
 ------------------
config/common_base +5 -0
index 0d181ace8f97..8a25e2cd53e1 100644
@@ -398,6 +398,11 @@ CONFIG_RTE_LIBRTE_PMD_FAILSAFE=y
 CONFIG_RTE_LIBRTE_MVPP2_PMD=n
 
 #
+# Compile support for VMBus library
+#
+CONFIG_RTE_LIBRTE_VMBUS=n
+
+
 # Compile virtual device driver for NetVSC on Hyper-V/Azure
 #
 CONFIG_RTE_LIBRTE_VDEV_NETVSC_PMD=n
drivers/bus/Makefile +1 -0
index c251b65ad368..6fe35139fa0b 100644
@@ -9,5 +9,6 @@ DIRS-$(CONFIG_RTE_LIBRTE_FSLMC_BUS) += fslmc
 endif
 DIRS-$(CONFIG_RTE_LIBRTE_PCI_BUS) += pci
 DIRS-$(CONFIG_RTE_LIBRTE_VDEV_BUS) += vdev
+DIRS-$(CONFIG_RTE_LIBRTE_VMBUS) += vmbus
 
 include $(RTE_SDK)/mk/rte.subdir.mk
drivers/bus/vmbus/Makefile new file +36 -0
new file mode 100644
index 000000000000..bd18a71154af
@@ -0,0 +1,36 @@
+# SPDX-License-Identifier: BSD-3-Clause
+
+include $(RTE_SDK)/mk/rte.vars.mk
+
+LIB = librte_bus_vmbus.a
+LIBABIVER := 1
+EXPORT_MAP := rte_bus_vmbus_version.map
+
+CFLAGS += -I$(SRCDIR)
+CFLAGS += -O3 $(WERROR_FLAGS)
+CFLAGS += -DALLOW_EXPERIMENTAL_API
+
+ifneq ($(CONFIG_RTE_EXEC_ENV_LINUXAPP),)
+SYSTEM := linux
+endif
+ifneq ($(CONFIG_RTE_EXEC_ENV_BSDAPP),)
+$(error "VMBUS not implemented for BSD yet")
+endif
+
+CFLAGS += -I$(RTE_SDK)/drivers/bus/vmbus/$(SYSTEM)
+CFLAGS += -I$(RTE_SDK)/lib/librte_eal/common
+CFLAGS += -I$(RTE_SDK)/lib/librte_eal/$(SYSTEM)app/eal
+
+LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
+LDLIBS += -lrte_ethdev -luuid
+
+include $(RTE_SDK)/drivers/bus/vmbus/$(SYSTEM)/Makefile
+SRCS-$(CONFIG_RTE_LIBRTE_VMBUS) := $(addprefix $(SYSTEM)/,$(SRCS))
+SRCS-$(CONFIG_RTE_LIBRTE_VMBUS) += vmbus_common.c
+SRCS-$(CONFIG_RTE_LIBRTE_VMBUS) += vmbus_channel.c vmbus_bufring.c
+SRCS-$(CONFIG_RTE_LIBRTE_VMBUS) += vmbus_common_uio.c
+
+SYMLINK-$(CONFIG_RTE_LIBRTE_VMBUS)-include += rte_bus_vmbus.h
+SYMLINK-$(CONFIG_RTE_LIBRTE_VMBUS)-include += rte_vmbus_reg.h
+
+include $(RTE_SDK)/mk/rte.lib.mk
drivers/bus/vmbus/linux/Makefile new file +3 -0
new file mode 100644
index 000000000000..ef0d30b2d3aa
@@ -0,0 +1,3 @@
+# SPDX-License-Identifier: BSD-3-Clause
+
+SRCS += vmbus_bus.c vmbus_uio.c
drivers/bus/vmbus/linux/vmbus_bus.c new file +355 -0

355 lines not on this page · raw message

drivers/bus/vmbus/linux/vmbus_uio.c new file +390 -0

390 lines not on this page · raw message

drivers/bus/vmbus/private.h new file +132 -0

132 lines not on this page · raw message

drivers/bus/vmbus/rte_bus_vmbus.h new file +397 -0

397 lines not on this page · raw message

drivers/bus/vmbus/rte_bus_vmbus_version.map new file +28 -0
new file mode 100644
index 000000000000..445081ae2f8c
@@ -0,0 +1,28 @@
+/* SPDX-License-Identifier: BSD-3-Clause */
+DPDK_18.05 {
+	global:
+
+	rte_vmbus_chan_close;
+	rte_vmbus_chan_open;
+	rte_vmbus_chan_recv;
+	rte_vmbus_chan_recv_raw;
+	rte_vmbus_chan_rx_empty;
+	rte_vmbus_chan_send;
+	rte_vmbus_chan_send_sglist;
+	rte_vmbus_chan_signal_tx;
+	rte_vmbus_irq_mask;
+	rte_vmbus_irq_read;
+	rte_vmbus_irq_unmask;
+	rte_vmbus_map_device;
+	rte_vmbus_max_channels;
+	rte_vmbus_probe;
+	rte_vmbus_probe_one;
+	rte_vmbus_register;
+	rte_vmbus_scan;
+	rte_vmbus_sub_channel_index;
+	rte_vmbus_subchan_open;
+	rte_vmbus_unmap_device;
+	rte_vmbus_unregister;
+
+	local: *;
+};
drivers/bus/vmbus/rte_vmbus_reg.h new file +344 -0

344 lines not on this page · raw message

drivers/bus/vmbus/vmbus_bufring.c new file +241 -0

241 lines not on this page · raw message

drivers/bus/vmbus/vmbus_channel.c new file +406 -0

406 lines not on this page · raw message

drivers/bus/vmbus/vmbus_common.c new file +286 -0

286 lines not on this page · raw message

drivers/bus/vmbus/vmbus_common_uio.c new file +232 -0

232 lines not on this page · raw message

mk/rte.app.mk +1 -0
index 26f35630a9c3..7b46f6174788 100644
@@ -192,6 +192,7 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_IFCVF_VDPA_PMD) += -lrte_ifcvf_vdpa
 endif # $(CONFIG_RTE_EAL_VFIO)
 endif # $(CONFIG_RTE_LIBRTE_VHOST)
 _LDLIBS-$(CONFIG_RTE_LIBRTE_VMXNET3_PMD)    += -lrte_pmd_vmxnet3_uio
+_LDLIBS-$(CONFIG_RTE_LIBRTE_VMBUS)	    += -lrte_bus_vmbus -luuid
 
 ifeq ($(CONFIG_RTE_LIBRTE_BBDEV),y)
 _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_BBDEV_NULL)     += -lrte_pmd_bbdev_null
Signature · 1 line
2.17.0
#2 lore raw

PATCH v6 2/4 net/netvsc: add hyper-v netvsc network device

In reply to Stephen Hemminger

The driver supports Hyper-V networking directly like virtio for KVM or vmxnet3 for VMware.

This code is based off of the FreeBSD driver. The file and variable names are kept the same to help with understanding (with most of the BSD style warts removed).

---
 MAINTAINERS                                   |    8 +
 config/common_base                            |    8 +
 drivers/net/Makefile                          |    1 +
 drivers/net/netvsc/Makefile                   |   23 +
 drivers/net/netvsc/hn_ethdev.c                |  728 ++++++++++
 drivers/net/netvsc/hn_logs.h                  |   35 +
 drivers/net/netvsc/hn_nvs.c                   |  533 +++++++
 drivers/net/netvsc/hn_nvs.h                   |  243 ++++
 drivers/net/netvsc/hn_rndis.c                 | 1099 +++++++++++++++
 drivers/net/netvsc/hn_rndis.h                 |   26 +
 drivers/net/netvsc/hn_rxtx.c                  | 1221 +++++++++++++++++
 drivers/net/netvsc/hn_var.h                   |  139 ++
 drivers/net/netvsc/ndis.h                     |  378 +++++
 drivers/net/netvsc/rndis.h                    |  414 ++++++
 drivers/net/netvsc/rte_pmd_netvsc_version.map |    5 +
 mk/rte.app.mk                                 |    1 +
 16 files changed, 4862 insertions(+)
 create mode 100644 drivers/net/netvsc/Makefile
 create mode 100644 drivers/net/netvsc/hn_ethdev.c
 create mode 100644 drivers/net/netvsc/hn_logs.h
 create mode 100644 drivers/net/netvsc/hn_nvs.c
 create mode 100644 drivers/net/netvsc/hn_nvs.h
 create mode 100644 drivers/net/netvsc/hn_rndis.c
 create mode 100644 drivers/net/netvsc/hn_rndis.h
 create mode 100644 drivers/net/netvsc/hn_rxtx.c
 create mode 100644 drivers/net/netvsc/hn_var.h
 create mode 100644 drivers/net/netvsc/ndis.h
 create mode 100644 drivers/net/netvsc/rndis.h
 create mode 100644 drivers/net/netvsc/rte_pmd_netvsc_version.map
MAINTAINERS +8 -0
index 46cb08986189..b111c1678c9f 100644
@@ -572,6 +572,14 @@ F: drivers/net/vdev_netvsc/
 F: doc/guides/nics/vdev_netvsc.rst
 F: doc/guides/nics/features/vdev_netvsc.ini
 
+Microsoft Hyper-V netvsc - EXPERIMENTAL
+M: Stephen Hemminger <[email protected]>
+M: "K. Y. Srinivasan" <[email protected]>
+M: Haiyang Zhang <[email protected]>
+F: drivers/net/hyperv/
+F: doc/guides/nics/netvsc.rst
+F: doc/guides/nics/features/netvsc.ini
+
 Netcope szedata2
 M: Matej Vido <[email protected]>
 F: drivers/net/szedata2/
config/common_base +8 -0
index 8a25e2cd53e1..c97718126d9c 100644
@@ -402,7 +402,15 @@ CONFIG_RTE_LIBRTE_MVPP2_PMD=n
 #
 CONFIG_RTE_LIBRTE_VMBUS=n
 
+#
+# Compile native PMD for Hyper-V/Azure
+#
+CONFIG_RTE_LIBRTE_NETVSC_PMD=n
+CONFIG_RTE_LIBRTE_NETVSC_DEBUG_RX=n
+CONFIG_RTE_LIBRTE_NETVSC_DEBUG_TX=n
+CONFIG_RTE_LIBRTE_NETVSC_DEBUG_DUMP=n
 
+#
 # Compile virtual device driver for NetVSC on Hyper-V/Azure
 #
 CONFIG_RTE_LIBRTE_VDEV_NETVSC_PMD=n
drivers/net/Makefile +1 -0
index 9f9da665173a..7cfc08d6f340 100644
@@ -33,6 +33,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_LIO_PMD) += liquidio
 DIRS-$(CONFIG_RTE_LIBRTE_MLX4_PMD) += mlx4
 DIRS-$(CONFIG_RTE_LIBRTE_MLX5_PMD) += mlx5
 DIRS-$(CONFIG_RTE_LIBRTE_MVPP2_PMD) += mvpp2
+DIRS-$(CONFIG_RTE_LIBRTE_NETVSC_PMD) += netvsc
 DIRS-$(CONFIG_RTE_LIBRTE_NFP_PMD) += nfp
 DIRS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += bnxt
 DIRS-$(CONFIG_RTE_LIBRTE_PMD_NULL) += null
drivers/net/netvsc/Makefile new file +23 -0
new file mode 100644
index 000000000000..3c713af3c8fc
@@ -0,0 +1,23 @@
+# SPDX-License-Identifier: BSD-3-Clause
+
+include $(RTE_SDK)/mk/rte.vars.mk
+
+LIB = librte_pmd_netvsc.a
+
+CFLAGS += -O3 $(WERROR_FLAGS)
+CFLAGS += -DALLOW_EXPERIMENTAL_API
+
+EXPORT_MAP := rte_pmd_netvsc_version.map
+
+LIBABIVER := 1
+
+SRCS-$(CONFIG_RTE_LIBRTE_NETVSC_PMD) += hn_ethdev.c
+SRCS-$(CONFIG_RTE_LIBRTE_NETVSC_PMD) += hn_rxtx.c
+SRCS-$(CONFIG_RTE_LIBRTE_NETVSC_PMD) += hn_rndis.c
+SRCS-$(CONFIG_RTE_LIBRTE_NETVSC_PMD) += hn_nvs.c
+
+LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
+LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs
+LDLIBS += -lrte_bus_vmbus
+
+include $(RTE_SDK)/mk/rte.lib.mk
drivers/net/netvsc/hn_ethdev.c new file +728 -0

728 lines not on this page · raw message

drivers/net/netvsc/hn_logs.h new file +35 -0
new file mode 100644
index 000000000000..f821655b83a6
@@ -0,0 +1,35 @@
+/* SPDX-License-Identifier: BSD-3-Clause */
+
+#ifndef _HN_LOGS_H_
+#define _HN_LOGS_H_
+
+#include <rte_log.h>
+
+extern int hn_logtype_init;
+
+#define PMD_INIT_LOG(level, fmt, args...) \
+	rte_log(RTE_LOG_ ## level, hn_logtype_init, "%s(): " fmt "\n",\
+		__func__, ## args)
+#define PMD_INIT_FUNC_TRACE() PMD_INIT_LOG(DEBUG, " >>")
+
+#ifdef RTE_LIBRTE_NETVSC_DEBUG_RX
+#define PMD_RX_LOG(level, fmt, args...) \
+	RTE_LOG(level, PMD, "%s() rx: " fmt "\n", __func__, ## args)
+#else
+#define PMD_RX_LOG(level, fmt, args...) do { } while (0)
+#endif
+
+#ifdef RTE_LIBRTE_NETVSC_DEBUG_TX
+#define PMD_TX_LOG(level, fmt, args...) \
+	RTE_LOG(level, PMD, "%s() tx: " fmt "\n", __func__, ## args)
+#else
+#define PMD_TX_LOG(level, fmt, args...) do { } while (0)
+#endif
+
+
+extern int hn_logtype_driver;
+#define PMD_DRV_LOG(level, fmt, args...) \
+	rte_log(RTE_LOG_ ## level, hn_logtype_driver, "%s(): " fmt "\n", \
+		__func__, ## args)
+
+#endif /* _HN_LOGS_H_ */
drivers/net/netvsc/hn_nvs.c new file +533 -0

533 lines not on this page · raw message

drivers/net/netvsc/hn_nvs.h new file +243 -0

243 lines not on this page · raw message

drivers/net/netvsc/hn_rndis.c new file +1099 -0

1,099 lines not on this page · raw message

drivers/net/netvsc/hn_rndis.h new file +26 -0
new file mode 100644
index 000000000000..f82f6d69d490
@@ -0,0 +1,26 @@
+/* SPDX-License-Identifier: BSD-3-Clause */
+
+#include "rndis.h"
+
+struct hn_data;
+
+void hn_rndis_receive_response(struct hn_data *hv,
+			      const void *data, uint32_t len);
+void	hn_rndis_link_status(struct hn_data *hv, const void *data);
+int	hn_rndis_attach(struct hn_data *hv);
+void	hn_rndis_detach(struct hn_data *hv);
+int	hn_rndis_get_eaddr(struct hn_data *hv, uint8_t *eaddr);
+int	hn_rndis_get_linkstatus(struct hn_data *hv);
+int	hn_rndis_get_linkspeed(struct hn_data *hv);
+int	hn_rndis_set_rxfilter(struct hn_data *hv, uint32_t filter);
+void	hn_rndis_rx_ctrl(struct hn_data *hv, const void *data,
+			 int dlen);
+int	hn_rndis_get_offload(struct hn_data *hv,
+			     struct rte_eth_dev_info *dev_info);
+int	hn_rndis_conf_offload(struct hn_data *hv,
+			      uint64_t tx_offloads,
+			      uint64_t rx_offloads);
+int	hn_rndis_query_rsscaps(struct hn_data *hv,
+			       unsigned int *rxr_cnt0);
+int	hn_rndis_conf_rss(struct hn_data *hv,
+			  const struct rte_eth_rss_conf *rss_conf);
drivers/net/netvsc/hn_rxtx.c new file +1221 -0

277 lines not on this page · raw message

drivers/net/netvsc/hn_var.h new file +139 -0

139 lines not on this page · raw message

drivers/net/netvsc/ndis.h new file +378 -0

378 lines not on this page · raw message

drivers/net/netvsc/rndis.h new file +414 -0

414 lines not on this page · raw message

drivers/net/netvsc/rte_pmd_netvsc_version.map new file +5 -0
new file mode 100644
index 000000000000..916e924c2093

Lines of this file are not shown. View the raw message.

mk/rte.app.mk +1 -0
index 7b46f6174788..b6476bcb1027 100644

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.17.0

Part of the diff is not shown here. View the raw message.

#3 lore raw

PATCH v4 4/4 bus/vmbus and net/netvsc: add meson build support

In reply to Stephen Hemminger

From: Stephen Hemminger <[email protected]>

Update meson build files for new netvsc and vmbus drivers.

---
 config/meson.build             |  7 +++++++
 drivers/bus/meson.build        |  2 +-
 drivers/bus/vmbus/meson.build  | 16 ++++++++++++++++
 drivers/net/meson.build        |  2 +-
 drivers/net/netvsc/meson.build | 13 +++++++++++++
 5 files changed, 38 insertions(+), 2 deletions(-)
 create mode 100644 drivers/bus/vmbus/meson.build
 create mode 100644 drivers/net/netvsc/meson.build
config/meson.build +7 -0
index 5815b56021b1..9900157143e1 100644
@@ -49,6 +49,13 @@ if host_machine.system() == 'linux' and cc.find_library('bsd', required: false).
 	dpdk_extra_ldflags += '-lbsd'
 endif
 
+# vmbus depends on lib uuid
+uuid_dep = cc.find_library('uuid', required: false)
+if uuid_dep.found() and cc.has_header('uuid/uuid.h')
+	add_project_link_arguments('-luuid', language: 'c')
+	dpdk_extra_ldflags += '-luuid'
+endif
+
 # add -include rte_config to cflags
 add_project_arguments('-include', 'rte_config.h', language: 'c')
 
drivers/bus/meson.build +1 -1
index 58dfbe2b24dd..720eecef0577 100644
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: BSD-3-Clause
 # Copyright(c) 2017 Intel Corporation
 
-drivers = ['dpaa', 'fslmc', 'pci', 'vdev']
+drivers = ['dpaa', 'fslmc', 'pci', 'vdev', 'vmbus']
 std_deps = ['eal']
 config_flag_fmt = 'RTE_LIBRTE_@0@_BUS'
 driver_name_fmt = 'rte_bus_@0@'
drivers/bus/vmbus/meson.build new file +16 -0
new file mode 100644
index 000000000000..8a17be828a32
@@ -0,0 +1,16 @@
+# SPDX-License-Identifier: BSD-3-Clause
+
+install_headers('rte_bus_vmbus.h','rte_vmbus_reg.h')
+
+sources = files('vmbus_common.c',
+		'vmbus_channel.c',
+		'vmbus_bufring.c',
+		'vmbus_common_uio.c')
+
+if host_machine.system() == 'linux'
+	sources += files('linux/vmbus_bus.c',
+			'linux/vmbus_uio.c')
+	includes += include_directories('linux')
+else
+	build = false
+endif
drivers/net/meson.build +1 -1
index b7d00a04c8ef..74d6c0f7cabf 100644
@@ -3,7 +3,7 @@
 
 drivers = ['af_packet', 'axgbe', 'bonding', 'dpaa', 'dpaa2',
 	'e1000', 'enic', 'fm10k', 'i40e', 'ixgbe',
-	'mvpp2', 'null', 'octeontx', 'pcap', 'ring',
+	'mvpp2', 'netvsc', 'null', 'octeontx', 'pcap', 'ring',
 	'sfc', 'thunderx', 'virtio']
 std_deps = ['ethdev', 'kvargs'] # 'ethdev' also pulls in mbuf, net, eal etc
 std_deps += ['bus_pci']         # very many PMDs depend on PCI, so make std
drivers/net/netvsc/meson.build new file +13 -0
new file mode 100644
index 000000000000..44926b20e973
@@ -0,0 +1,13 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2018 Microsoft Corporation
+
+version = 2
+
+allow_experimental_apis = true
+
+sources = files('hn_ethdev.c',
+		'hn_rxtx.c',
+		'hn_rndis.c',
+		'hn_nvs.c')
+
+deps += ['bus_vmbus' ]
Signature · 1 line
2.17.0
#4 lore raw

PATCH v6 3/4 net/netvsc: add documentation

In reply to Stephen Hemminger

From: Stephen Hemminger <[email protected]>

Matching documentation for new netvsc device.

---
 doc/guides/nics/features/netvsc.ini    | 23 ++++++
 doc/guides/nics/index.rst              |  1 +
 doc/guides/nics/netvsc.rst             | 98 ++++++++++++++++++++++++++
 doc/guides/rel_notes/release_18_05.rst |  5 ++
 4 files changed, 127 insertions(+)
 create mode 100644 doc/guides/nics/features/netvsc.ini
 create mode 100644 doc/guides/nics/netvsc.rst
doc/guides/nics/features/netvsc.ini new file +23 -0
new file mode 100644
index 000000000000..2ff6042bf47b
@@ -0,0 +1,23 @@
+;
+; Supported features of the 'netvsc' network poll mode driver.
+;
+; Refer to default.ini for the full list of available PMD features.
+;
+[Features]
+Speed capabilities   = P
+Link status          = Y
+Queue start/stop     = Y
+Scattered Rx         = Y
+Promiscuous mode     = Y
+Allmulticast mode    = Y
+Basic stats          = Y
+Stats per queue      = Y
+Extended stats       = Y
+Multiprocess aware   = Y
+Other kdrv           = Y
+ARMv7                = Y
+ARMv8                = Y
+x86-32               = Y
+x86-64               = Y
+Usage doc            = Y
+MTU update           = Y
doc/guides/nics/index.rst +1 -0
index ddb9eb7a922e..d4eae2b8f046 100644
@@ -33,6 +33,7 @@ Network Interface Controller Drivers
     mlx4
     mlx5
     mvpp2
+    netvsc
     nfp
     octeontx
     qede
doc/guides/nics/netvsc.rst new file +98 -0

98 lines not on this page · raw message

doc/guides/rel_notes/release_18_05.rst +5 -0
index 7187348520cf..ab6126dc3b66 100644
@@ -183,6 +183,11 @@ New Features
   stats/xstats on shared memory from secondary process, and also pdump packets on
   those virtual devices.
 
+* **Added experimental support for Hyper-V netvsc PMD.**
+
+  The new experimntal ``netvsc`` poll mode driver provides native support for
+  networking on Hyper-V. See the :doc:`../nics/netvsc` nic driver guide
+  for more details on this   new driver.
 
 API Changes
 -----------
Signature · 1 line
2.17.0
#5 lore raw

Re: [PATCH v6 3/4] net/netvsc: add documentation

Quoted 21 lines

From: Stephen Hemminger <[email protected]>

Matching documentation for new netvsc device.

---
 doc/guides/nics/features/netvsc.ini    | 23 ++++++
 doc/guides/nics/index.rst              |  1 +
 doc/guides/nics/netvsc.rst             | 98 ++++++++++++++++++++++++++
 doc/guides/rel_notes/release_18_05.rst |  5 ++
 4 files changed, 127 insertions(+)
 create mode 100644 doc/guides/nics/features/netvsc.ini
 create mode 100644 doc/guides/nics/netvsc.rst
doc/guides/nics/features/netvsc.ini new file +0 -0
new file mode 100644
index 000000000000..2ff6042bf47b

<...>

Quoted 16 lines

+++ b/doc/guides/nics/netvsc.rst

doc/guides/nics/features/netvsc.ini new file +14 -0
@@ -0,0 +1,98 @@
+..  SPDX-License-Identifier: BSD-3-Clause
+    Copyright(c) Microsoft Corporation.
+
+Netvsc (Hyper-V) poll mode driver
+=================================
+
+Hyper-V is a hypervisor integrated into Window Server 2008, Windows 10
+and later versions.  It supports a para-virtualized network interface
+called netvsc that is visible on the virtual machine bus (VMBUS).  In
+the Data Plane Development Kit (DPDK), we provide a Network Virtual
+Service Client (NetVSC) Poll Mode Driver (PMD). The NetVSC PMD supports
+Windows Server 2016 and Microsoft Azure cloud.
+
+NetVSC Implementation in DPDK

doc/guides/nics/features/netvsc.ini line 24

Quoted 10 lines
doc/guides/nics/features/netvsc.ini new file +10 -0
+-----------------------------
+
+The Netvsc PMD is a standalone driver. VMBus network devices that are
+being used by DPDK must be unbound from the Linux kernel driver
+(hv_netvsc) and bound to the Userspace IO driver for Hyper-V
+(uio_hv_generic).
+
+This is most conveniently done with the .. _`driverctl`:
+https://gitlab.com/driverctl/driverctl
+script.

The way you set up the link here is wrong

.. _driverctl: https://gitlab.com/driverctl/driverctl ---> driverctl <https://gitlab.com/driverctl/driverctl>_

<...>

Quoted 11 lines
doc/guides/nics/features/netvsc.ini new file +1 -0
+++ b/doc/guides/rel_notes/release_18_05.rst
@@ -183,6 +183,11 @@ New Features
   stats/xstats on shared memory from secondary process, and also pdump

packets on
those virtual devices.

doc/guides/nics/features/netvsc.ini new file +4 -0
+* **Added experimental support for Hyper-V netvsc PMD.**
+
+  The new experimntal ``netvsc`` poll mode driver provides native
+ support for  networking on Hyper-V. See the :doc:`../nics/netvsc` nic driver

guide

Spelling above
experimntal / experimental

Quoted 4 lines

+ for more details on this new driver.

API Changes
-----------

#6 lore raw
In reply to Stephen Hemminger
Quoted 42 lines · Stephen Hemminger

This is a revised version of the Hyper-V native bus (VMBus) and network device (netvsc) drivers. This virtual device is used in Microsoft Hyper-V in Windows 10, Windows Server 2016 and Azure. Most of this code was extracted from FreeBSD and some of this is from earlier code donated by Brocade.

Only Linux is supported at present, but the code is split to allow future FreeBSD and Windows support.

This version works with upstream kernel (4.16) but in that mode only a single queue is supported. With additional patches that are pending for 5.0 kernel, multi-queue support works as well.

Device binding is best done via driverctl; this required some additional fixes to kernel and driverctl to work correctly. Linux kernel vmbus support needed to support sysfs driver_override and driverctl needed to handle non-PCI bus from udev.
https://gitlab.com/driverctl/driverctl/merge_requests/3
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-April/118889.html

v6
- rebase to current 18.05
- fix RSS initialization
- minor documentation fixes

v5
- rebase to current 18.05
- fix message from vmbus due to race on sysfs for sub channel

v4
- don't enable by default because of uuid library dependency
- api's are internal no need to mark experimental
- add netvsc ini file
- fix MAINTAINERS entry

v3
- fix documentation to format correctly and include more info about binding
- fix build on 32 bit
- minor white space and indentation fixes

Quoted 5 lines

Stephen Hemminger (4):
bus/vmbus: add hyper-v virtual bus support net/netvsc: add hyper-v netvsc network device net/netvsc: add documentation
bus/vmbus and net/netvsc: add meson build support

I confirm my test scripts passes for x86, not able to cross build for other architectures because of uuid dependency and I am missing cross version of it.
note: need to enable both LIBRTE_VMBUS & NETVSC_PMD

Overall series looks good to me.

#7 lore raw
Quoted 49 lines · On Fri, 11 May 2018 17:50:37 +0100 Ferruh Yigit <[email protected]> wrote:
Quoted 42 lines · Stephen Hemminger

This is a revised version of the Hyper-V native bus (VMBus) and network device (netvsc) drivers. This virtual device is used in Microsoft Hyper-V in Windows 10, Windows Server 2016 and Azure. Most of this code was extracted from FreeBSD and some of this is from earlier code donated by Brocade.

Only Linux is supported at present, but the code is split to allow future FreeBSD and Windows support.

This version works with upstream kernel (4.16) but in that mode only a single queue is supported. With additional patches that are pending for 5.0 kernel, multi-queue support works as well.

Device binding is best done via driverctl; this required some additional fixes to kernel and driverctl to work correctly. Linux kernel vmbus support needed to support sysfs driver_override and driverctl needed to handle non-PCI bus from udev.
https://gitlab.com/driverctl/driverctl/merge_requests/3
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-April/118889.html

v6
- rebase to current 18.05
- fix RSS initialization
- minor documentation fixes

v5
- rebase to current 18.05
- fix message from vmbus due to race on sysfs for sub channel

v4
- don't enable by default because of uuid library dependency
- api's are internal no need to mark experimental
- add netvsc ini file
- fix MAINTAINERS entry

v3
- fix documentation to format correctly and include more info about binding
- fix build on 32 bit
- minor white space and indentation fixes

Quoted 5 lines

Stephen Hemminger (4):
bus/vmbus: add hyper-v virtual bus support net/netvsc: add hyper-v netvsc network device net/netvsc: add documentation
bus/vmbus and net/netvsc: add meson build support

Quoted 5 lines

I confirm my test scripts passes for x86, not able to cross build for other architectures because of uuid dependency and I am missing cross version of it.
note: need to enable both LIBRTE_VMBUS & NETVSC_PMD

Overall series looks good to me.

Released versions of Hyper-V/Azure are x86 only.
Libuuid should be available for all architectures, for example Debian support x85, arm, mips, ppc, s390

#8 lore raw
In reply to Ferruh Yigit

11/05/2018 18:50, Ferruh Yigit:

Quoted 10 lines · Stephen Hemminger
Quoted 5 lines

Stephen Hemminger (4):
bus/vmbus: add hyper-v virtual bus support net/netvsc: add hyper-v netvsc network device net/netvsc: add documentation
bus/vmbus and net/netvsc: add meson build support

I confirm my test scripts passes for x86, not able to cross build for other architectures because of uuid dependency and I am missing cross version of it.
note: need to enable both LIBRTE_VMBUS & NETVSC_PMD

Unfortunately, I have a compilation error with meson because of uuid dependency:

Library uuid found: NO
[...]
./drivers/bus/vmbus/rte_bus_vmbus.h:23:10: fatal error: uuid/uuid.h:
No such file or directory

I think it is missing a "build = false" when dep is not found.

In the next revision, please merge meson files in first patches, thanks.

#9 lore raw
Quoted 19 lines · On Sun, 13 May 2018 00:02:59 +0200 Thomas Monjalon <[email protected]> wrote:

11/05/2018 18:50, Ferruh Yigit:

Quoted 10 lines · Stephen Hemminger
Quoted 5 lines

Stephen Hemminger (4):
bus/vmbus: add hyper-v virtual bus support net/netvsc: add hyper-v netvsc network device net/netvsc: add documentation
bus/vmbus and net/netvsc: add meson build support

I confirm my test scripts passes for x86, not able to cross build for other architectures because of uuid dependency and I am missing cross version of it.
note: need to enable both LIBRTE_VMBUS & NETVSC_PMD

Unfortunately, I have a compilation error with meson because of uuid dependency:

Library uuid found: NO
[...]
./drivers/bus/vmbus/rte_bus_vmbus.h:23:10: fatal error: uuid/uuid.h:
No such file or directory

Quoted 6 lines

I think it is missing a "build = false" when dep is not found.

In the next revision, please merge meson files in first patches, thanks.

Ok, didn't check negative meson build case.