mtd: added missing GigaDevice chips
v2 cover mtd: added missing GigaDevice chips
in kernel tree are additional 2 chips from GigaDevice, which i need for Vocore2 (MT7688)
Jiri Kastner (1):
mtd: added missing GigaDevice chips
drivers/mtd/spi/spi-nor-ids.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
Signature · 1 line
2.20.1
PATCH v2 1/1 mtd: added missing GigaDevice chips
Vocore2 (mt7688 based device) has g25q128 chip from GigaDevice, which i've found in kernel tree. added chips are gd25q128 and gd25q256.
--- drivers/mtd/spi/spi-nor-ids.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
drivers/mtd/spi/spi-nor-ids.c +10 -0
@@ -106,6 +106,16 @@ const struct flash_info spi_nor_ids[] = {SECT_4K |SPI_NOR_DUAL_READ |SPI_NOR_QUAD_READ | SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) }, + { +INFO ("gd25q128" ,0xc84018 ,0 ,64 *1024 ,256 , +SECT_4K |SPI_NOR_DUAL_READ |SPI_NOR_QUAD_READ | +SPI_NOR_HAS_LOCK |SPI_NOR_HAS_TB ) + }, + { +INFO ("gd25q256" ,0xc84019 ,0 ,64 *1024 ,512 , +SECT_4K |SPI_NOR_DUAL_READ |SPI_NOR_QUAD_READ | +SPI_NOR_HAS_LOCK |SPI_NOR_HAS_TB ) + }, #endif #ifdef CONFIG_SPI_FLASH_ISSI /* ISSI *//* ISSI */
Signature · 1 line
2.20.1
Vignesh R
maintainerPATCH v2 1/1 mtd: added missing GigaDevice chips
Hi,
Quoted 18 lines · Jiri Kastner
Vocore2 (mt7688 based device) has g25q128 chip from GigaDevice, which i've found in kernel tree. added chips are gd25q128 and gd25q256.
Cc Jagan Teki <[email protected]>Cc Vignesh R <[email protected]>--- drivers/mtd/spi/spi-nor-ids.c | 10 ++++++++++ 1 file changed, 10 insertions(+)drivers/mtd/spi/spi-nor-ids.c +0
-0@@ -106,6 +106,16 @@ const struct flash_info spi_nor_ids[] = {SECT_4K |SPI_NOR_DUAL_READ |SPI_NOR_QUAD_READ | SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 118
Quoted 10 lines
drivers/mtd/spi/spi-nor-ids.c +10
-0+ { +INFO ("gd25q128" ,0xc84018 ,0 ,64 *1024 ,256 , +SECT_4K |SPI_NOR_DUAL_READ |SPI_NOR_QUAD_READ | +SPI_NOR_HAS_LOCK |SPI_NOR_HAS_TB ) + }, + { +INFO ("gd25q256" ,0xc84019 ,0 ,64 *1024 ,512 , +SECT_4K |SPI_NOR_DUAL_READ |SPI_NOR_QUAD_READ | +SPI_NOR_HAS_LOCK |SPI_NOR_HAS_TB ) + },
Have you tested Quad mode on this device? I see gd25q256 uses macronix_quad_enable() and kernel handles this by .quad_enable() callback which isnt supported in U-Boot yet. Could you explain how Quad mode would work in U-Boot with this flash?
Signature · 2 lines
Regards Vignesh
PATCH v2 1/1 mtd: added missing GigaDevice chips
Quoted 6 lines · Vignesh R
Hi,
Have you tested Quad mode on this device? I see gd25q256 uses
macronix_quad_enable()and kernel handles this by .quad_enable() callback which isnt supported in U-Boot yet. Could you explain how Quad mode would work in U-Boot with this flash?
hi,
if i read correctly between lines, in that case gd25q64 is not tested with quad mode too, as i copied flags from q64 (already being in master).
no chance to test q256 at all.
best regards
jiri kastner
PATCH v2 1/1 mtd: added missing GigaDevice chips
Quoted 10 lines · Jiri Kastner
Quoted 6 lines · Vignesh R
Hi,
Have you tested Quad mode on this device? I see gd25q256 uses
macronix_quad_enable()and kernel handles this by .quad_enable() callback which isnt supported in U-Boot yet. Could you explain how Quad mode would work in U-Boot with this flash?
Quoted 5 lines
hi,
if i read correctly between lines, in that case gd25q64 is not tested with quad mode too, as i copied flags from q64 (already being in master).no chance to test q256 at all.
Would you test this and update the quad flag?