Mark clocks as critical for MT6797
Subsystems (2)
v4 cover Mark clocks as critical for MT6797
From: Matthias Brugger <[email protected]>
Jasper send this series some month ago. As there was no reaction from his side, I'll do a friendly take-over.
I tested the patches on my Helios X20 boards and they fix the issue. I didn't add a Tested-by tag as I added my Signed-off-by.
Changes since v3:
- add comments explaining why the clock muxer and gates are marked as critical
Changes since v2 (https://patchwork.kernel.org/patch/10686759/):
- axi_sel is not needed, drop CLK_IS_CRITICAL for it.
- update commit message
- add Acked-by from Mars
Changes since v1:
- add a fixes tag.
---
Currently, DRAM-related clocks and the axi_sel MUX are not marked with CLK_IS_CRITICAL for MT6797. This causes memory corruption when the system is booted without clk_ignore_unused.
This patchset
1. Makes it possible to mark outputs of MUXes as critical by introducing a new macro, MUX_FLAGS,
2. Makes it possible to mark gates as critical by adding flags to mtk_gate, and
3. Marks axi_sel, ddrphycfg_sel, infra_dramc_f26m and infra_dramc_b_f26m as critical.
The addition of flags to mtk_gate also exists in the patch series "Add basic and clock support for Mediatek MT8183 SoC" [1]. The type of flags is unsigned int in that series, but the real type is unsigned long, so my patch differs from that patch.
[1] https://patchwork.kernel.org/patch/10549953/
Jasper Mattsson (3):
clk: mediatek: Add MUX_FLAGS macro
clk: mediatek: Add flags to mtk_gate
clk: mediatek: Mark bus and DRAM related clocks as critical
drivers/clk/mediatek/clk-gate.c | 4 +- drivers/clk/mediatek/clk-gate.h | 3 +- drivers/clk/mediatek/clk-mt6797.c | 68 +++++++++++++++++++------------ drivers/clk/mediatek/clk-mtk.c | 2 +- drivers/clk/mediatek/clk-mtk.h | 9 +++- 5 files changed, 56 insertions(+), 30 deletions(-)
Signature · 1 line
2.20.1
Matthias Brugger
maintainerQuoted 11 lines · On 14/02/2019 17:30, [email protected] wrote:
From: Matthias Brugger <[email protected]>
Jasper send this series some month ago. As there was no reaction from his side, I'll do a friendly take-over.
I tested the patches on my Helios X20 boards and they fix the issue. I didn't add a Tested-by tag as I added my Signed-off-by.Changes since v3:
- add comments explaining why the clock muxer and gates are marked as critical
Quoted 8 lines
Changes since v2 (https://patchwork.kernel.org/patch/10686759/):
-axi_selis not needed, dropCLK_IS_CRITICALfor it.
- update commit message
- add Acked-by from MarsChanges since v1:
- add a fixes tag.
Steven, Mike any comments on this?
Regards,
Matthias
Quoted 34 lines
---
Currently, DRAM-related clocks and the
axi_selMUX are not marked withCLK_IS_CRITICALfor MT6797. This causes memory corruption when the system is booted withoutclk_ignore_unused.This patchset
1. Makes it possible to mark outputs of MUXes as critical by introducing a new macro,
MUX_FLAGS,
2. Makes it possible to mark gates as critical by adding flags tomtk_gate, and
3. Marksaxi_sel,ddrphycfg_sel,infra_dramc_f26mandinfra_dramc_b_f26mas critical.The addition of flags to
mtk_gatealso exists in the patch series "Add basic and clock support for Mediatek MT8183 SoC" [1]. The type of flags is unsigned int in that series, but the real type is unsigned long, so my patch differs from that patch.[1] https://patchwork.kernel.org/patch/10549953/
Jasper Mattsson (3):
clk: mediatek: AddMUX_FLAGSmacro
clk: mediatek: Add flags tomtk_gate
clk: mediatek: Mark bus and DRAM related clocks as criticaldrivers/clk/mediatek/clk-gate.c | 4 +- drivers/clk/mediatek/clk-gate.h | 3 +- drivers/clk/mediatek/clk-mt6797.c | 68 +++++++++++++++++++------------ drivers/clk/mediatek/clk-mtk.c | 2 +- drivers/clk/mediatek/clk-mtk.h | 9 +++- 5 files changed, 56 insertions(+), 30 deletions(-)
Stephen Boyd
maintainerQuoting Matthias Brugger (2019-02-26 04:59:44)
Quoted 19 lines · On 14/02/2019 17:30, [email protected] wrote:
Quoted 16 lines
From: Matthias Brugger <[email protected]>
Jasper send this series some month ago. As there was no reaction from his side, I'll do a friendly take-over.
I tested the patches on my Helios X20 boards and they fix the issue. I didn't add a Tested-by tag as I added my Signed-off-by.Changes since v3:
- add comments explaining why the clock muxer and gates are marked as criticalChanges since v2 (https://patchwork.kernel.org/patch/10686759/):
-axi_selis not needed, dropCLK_IS_CRITICALfor it.
- update commit message
- add Acked-by from Mars
Quoted 6 lines
Quoted 3 lines
Changes since v1:
- add a fixes tag.Steven, Mike any comments on this?
I got patch #1 and #2 in my queue and they're not threaded properly as replies to each other. I'll have to go dig out the last patch somehow, but probably I can apply them now.