Skip to contentSkip to conversation

GPIO: Adding new Xilinx driver

PATCH Superseded John Linn 2 participants 2 messages Oct 27, 2008

Subsystems (2)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

John Linn

author
#0 lore raw

PATCH v2 1/1 GPIO: Adding new Xilinx driver

This driver supports the Xilinx XPS GPIO IP core which has the typical GPIO features.

---
V2 - Updated based on Anton's comments

 drivers/gpio/Kconfig       |   15 ++--
 drivers/gpio/Makefile      |    1 +
 drivers/gpio/xilinx_gpio.c |  235 ++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 244 insertions(+), 7 deletions(-)
 create mode 100644 drivers/gpio/xilinx_gpio.c
drivers/gpio/Kconfig +8 -7
index 7f2ee27..12a8006 100644
@@ -65,6 +65,14 @@ config GPIO_SYSFS
 
 # put expanders in the right section, in alphabetical order
 
+comment "Memory mapped GPIO expanders:"
+
+config GPIO_XILINX
+	bool "Xilinx GPIO support"
+	depends on PPC_OF
+	help
+	  Say yes here to support the Xilinx FPGA GPIO device
+
 comment "I2C GPIO expanders:"
 
 config GPIO_MAX732X
@@ -127,13 +135,6 @@ config GPIO_PCF857X
 	  This driver provides an in-kernel interface to those GPIOs using
 	  platform-neutral GPIO calls.
 
-config GPIO_TWL4030
-	tristate "TWL4030, TWL5030, and TPS659x0 GPIOs"
-	depends on TWL4030_CORE
-	help
-	  Say yes here to access the GPIO signals of various multi-function
-	  power management chips from Texas Instruments.
-
 comment "PCI GPIO expanders:"
 
 config GPIO_BT8XX
drivers/gpio/Makefile +1 -0
index 6aafdeb..49ac64e 100644
@@ -10,4 +10,5 @@ obj-$(CONFIG_GPIO_MCP23S08)	+= mcp23s08.o
 obj-$(CONFIG_GPIO_PCA953X)	+= pca953x.o
 obj-$(CONFIG_GPIO_PCF857X)	+= pcf857x.o
 obj-$(CONFIG_GPIO_TWL4030)	+= twl4030-gpio.o
+obj-$(CONFIG_GPIO_XILINX)	+= xilinx_gpio.o
 obj-$(CONFIG_GPIO_BT8XX)	+= bt8xxgpio.o
drivers/gpio/xilinx_gpio.c new file +235 -0

235 lines not on this page · raw message

Signature · 5 lines
1.5.2.1



This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.
#1 lore raw
Quoted 19 lines · John Linn

This driver supports the Xilinx XPS GPIO IP core which has the typical GPIO features.

---
V2 - Updated based on Anton's comments

 drivers/gpio/Kconfig       |   15 ++--
 drivers/gpio/Makefile      |    1 +
 drivers/gpio/xilinx_gpio.c |  235 ++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 244 insertions(+), 7 deletions(-)
 create mode 100644 drivers/gpio/xilinx_gpio.c
drivers/gpio/Kconfig +0 -0
index 7f2ee27..12a8006 100644

drivers/gpio/Kconfig config GPIO_PCF857X · line 136

Quoted 10 lines
drivers/gpio/Kconfig +0 -7
@@ -127,13 +135,6 @@ config GPIO_PCF857X
         This driver provides an in-kernel interface to those GPIOs using
         platform-neutral GPIO calls.
 
-config GPIO_TWL4030
-       tristate "TWL4030, TWL5030, and TPS659x0 GPIOs"
-       depends on TWL4030_CORE
-       help
-         Say yes here to access the GPIO signals of various multi-function
-         power management chips from Texas Instruments.
-

Looks like you've got some colateral damage in here. Otherwise looks right to me.

When you repost, please add my Signed-off-by line between yours and Kiran's since I did a bunch of hacking on this driver too. Also, make use you post it to the LKML.

g.

Signature · 2 lines
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.