Skip to contentSkip to conversation

dt-bindings: input: touchscreen: ti,tsc2005: Add wakeup-source

PATCH Superseded [email protected] 3 participants 5 messages Mar 16 – Mar 18

Subsystems (3)

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 dt-bindings: input: touchscreen: ti,tsc2005: Add wakeup-source

From: bui duc phuc <[email protected]>

Document the "wakeup-source" property for the ti,tsc2005 touchscreen controllers to allow the device to wake the system from suspend.

---
 .../devicetree/bindings/input/touchscreen/ti,tsc2005.yaml  | 7 +++++++
 1 file changed, 7 insertions(+)
Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml +7 -0
index 7187c390b2f5..c0aae044d7d4 100644
@@ -55,6 +55,9 @@ properties:
   touchscreen-size-x: true
   touchscreen-size-y: true
 
+  wakeup-source:
+    type: boolean
+
 allOf:
   - $ref: touchscreen.yaml#
   - if:
@@ -97,6 +100,8 @@ examples:
 
             ti,x-plate-ohms = <280>;
             ti,esd-recovery-timeout-ms = <8000>;
+
+            wakeup-source;
         };
     };
   - |
@@ -124,5 +129,7 @@ examples:
 
             ti,x-plate-ohms = <280>;
             ti,esd-recovery-timeout-ms = <8000>;
+
+            wakeup-source;
         };
     };
Signature · 1 line
2.43.0
#1 lore raw
Quoted 15 lines · On Mon, Mar 16, 2026 at 10:46:06AM +0700, [email protected] wrote:

From: bui duc phuc <[email protected]>

Document the "wakeup-source" property for the ti,tsc2005 touchscreen controllers to allow the device to wake the system from suspend.

---
 .../devicetree/bindings/input/touchscreen/ti,tsc2005.yaml  | 7 +++++++
 1 file changed, 7 insertions(+)
Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml +0 -0
index 7187c390b2f5..c0aae044d7d4 100644

Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml properties: · line 59

Quoted 5 lines
Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml +2 -0
@@ -55,6 +55,9 @@ properties:
   touchscreen-size-x: true
   touchscreen-size-y: true
 
+  wakeup-source:
+    type: boolean

wakeup-source: true

Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml examples: · line 103

Quoted 9 lines
Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml +2 -0
+
 allOf:
   - $ref: touchscreen.yaml#
   - if:
@@ -97,6 +100,8 @@ examples:
 
             ti,x-plate-ohms = <280>;
             ti,esd-recovery-timeout-ms = <8000>;
+

Remove the blank line please.

pw-bot: changes-requested

Thanks,
Conor.

Quoted 15 lines
Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml +3 -0
+            wakeup-source;
         };
     };
   - |
@@ -124,5 +129,7 @@ examples:
 
             ti,x-plate-ohms = <280>;
             ti,esd-recovery-timeout-ms = <8000>;
+
+            wakeup-source;
         };
     };
Signature · 1 line
2.43.0
#2 lore raw
Quoted 19 lines · Conor Dooley
Quoted 18 lines · On Mon, Mar 16, 2026 at 10:46:06AM +0700, [email protected] wrote:

From: bui duc phuc <[email protected]>

Document the "wakeup-source" property for the ti,tsc2005 touchscreen controllers to allow the device to wake the system from suspend.

---
 .../devicetree/bindings/input/touchscreen/ti,tsc2005.yaml  | 7 +++++++
 1 file changed, 7 insertions(+)
Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml +0 -0
index 7187c390b2f5..c0aae044d7d4 100644
@@ -55,6 +55,9 @@ properties:
   touchscreen-size-x: true
   touchscreen-size-y: true
 
Quoted 4 lines

Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml properties: · line 59

Quoted 2 lines
Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml +2 -0
+  wakeup-source:
+    type: boolean

wakeup-source: true

I am not so sure.

The property is multi-type, so we want to choose one - bool, IMO, because device cannot wakeup the specific system idle states. Or am I misinterpreting the phandles behind wakeup-source and every device can be differently routed in such system?

Best regards,
Krzysztof

#3 lore raw
Quoted 25 lines · Krzysztof Kozlowski
Quoted 19 lines · Conor Dooley
Quoted 18 lines · On Mon, Mar 16, 2026 at 10:46:06AM +0700, [email protected] wrote:

From: bui duc phuc <[email protected]>

Document the "wakeup-source" property for the ti,tsc2005 touchscreen controllers to allow the device to wake the system from suspend.

---
 .../devicetree/bindings/input/touchscreen/ti,tsc2005.yaml  | 7 +++++++
 1 file changed, 7 insertions(+)
Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml +0 -0
index 7187c390b2f5..c0aae044d7d4 100644
@@ -55,6 +55,9 @@ properties:
   touchscreen-size-x: true
   touchscreen-size-y: true
 
Quoted 4 lines

Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml properties: · line 59

Quoted 2 lines
Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml +2 -0
+  wakeup-source:
+    type: boolean

wakeup-source: true

Quoted 6 lines

I am not so sure.

The property is multi-type, so we want to choose one - bool, IMO, because device cannot wakeup the specific system idle states. Or am I misinterpreting the phandles behind wakeup-source and every device can be differently routed in such system?

I checked before my original comment, and there there's a bout a 2:1 ratio of defined v true. I suppose my comment can be ignored, I am just used to this always being true.

#4 lore raw

Hi Conor, Krzysztof,

Thanks for the review.
I will remove the extra blank line in the next version.
As for the wakeup-source property, I'll keep it as a boolean as per the current patch.

Best Regards,
Phuc

Quoted 37 lines · Conor Dooley
Quoted 25 lines · Krzysztof Kozlowski
Quoted 19 lines · Conor Dooley
Quoted 18 lines · On Mon, Mar 16, 2026 at 10:46:06AM +0700, [email protected] wrote:

From: bui duc phuc <[email protected]>

Document the "wakeup-source" property for the ti,tsc2005 touchscreen controllers to allow the device to wake the system from suspend.

---
 .../devicetree/bindings/input/touchscreen/ti,tsc2005.yaml  | 7 +++++++
 1 file changed, 7 insertions(+)
Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml +0 -0
index 7187c390b2f5..c0aae044d7d4 100644
@@ -55,6 +55,9 @@ properties:
   touchscreen-size-x: true
   touchscreen-size-y: true
 
Quoted 4 lines

Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml properties: · line 59

Quoted 2 lines
Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml +2 -0
+  wakeup-source:
+    type: boolean

wakeup-source: true

Quoted 6 lines

I am not so sure.

The property is multi-type, so we want to choose one - bool, IMO, because device cannot wakeup the specific system idle states. Or am I misinterpreting the phandles behind wakeup-source and every device can be differently routed in such system?

I checked before my original comment, and there there's a bout a 2:1 ratio of defined v true. I suppose my comment can be ignored, I am just used to this always being true.