Skip to contentSkip to conversation

hw/core/cpu: Add missing 'exec/cpu-common.h' include

PATCH In review Philippe Mathieu-Daudé 2 participants 3 messages Sep 8, 2020 – Oct 1, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hw/core/cpu: Add missing 'exec/cpu-common.h' include

cpu_common_reset() uses tcg_flush_softmmu_tlb() which is declared in "exec/cpu-common.h". Add the missing header to avoid when refactoring other headers:

hw/core/cpu.c: In function ‘cpu_common_reset’:
hw/core/cpu.c:273:9: error: implicit declaration of function ‘tcg_flush_softmmu_tlb’ [-Werror=implicit-function-declaration]

    273 |         tcg_flush_softmmu_tlb(cpu);
        |         ^~~~~~~~~~~~~~~~~~~~~
---
 hw/core/cpu.c | 1 +
 1 file changed, 1 insertion(+)
hw/core/cpu.c +1 -0
index 22bc3f974a2..63ece3662d6 100644
@@ -26,6 +26,7 @@
 #include "qemu/log.h"
 #include "qemu/main-loop.h"
 #include "exec/log.h"
+#include "exec/cpu-common.h"
 #include "qemu/error-report.h"
 #include "qemu/qemu-print.h"
 #include "sysemu/tcg.h"
Signature · 1 line
2.26.2
#1 lore raw

ping?

Quoted 27 lines · Philippe Mathieu-Daudé

cpu_common_reset() uses tcg_flush_softmmu_tlb() which is declared in "exec/cpu-common.h". Add the missing header to avoid when refactoring other headers:

hw/core/cpu.c: In function ‘cpu_common_reset’:
hw/core/cpu.c:273:9: error: implicit declaration of function ‘tcg_flush_softmmu_tlb’ [-Werror=implicit-function-declaration]

    273 |         tcg_flush_softmmu_tlb(cpu);
        |         ^~~~~~~~~~~~~~~~~~~~~
---
 hw/core/cpu.c | 1 +
 1 file changed, 1 insertion(+)
hw/core/cpu.c +1 -0
index 22bc3f974a2..63ece3662d6 100644
@@ -26,6 +26,7 @@
 #include "qemu/log.h"
 #include "qemu/main-loop.h"
 #include "exec/log.h"
+#include "exec/cpu-common.h"
 #include "qemu/error-report.h"
 #include "qemu/qemu-print.h"
 #include "sysemu/tcg.h"
#2 lore raw
Quoted 13 lines · Philippe Mathieu-Daudé

ping?

Quoted 10 lines · Philippe Mathieu-Daudé

cpu_common_reset() uses tcg_flush_softmmu_tlb() which is declared in "exec/cpu-common.h". Add the missing header to avoid when refactoring other headers:

hw/core/cpu.c: In function ‘cpu_common_reset’:
hw/core/cpu.c:273:9: error: implicit declaration of function ‘tcg_flush_softmmu_tlb’ [-Werror=implicit-function-declaration]

    273 |         tcg_flush_softmmu_tlb(cpu);
        |         ^~~~~~~~~~~~~~~~~~~~~

Qeueued, thanks!

Signature · 1 line
Eduardo