Skip to contentSkip to conversation

tools/xenstat/xentop/xentop.c -- fix xentop so it returns the correct exit code on invalid argument

PATCH New ShaunR 1 participant 1 message Oct 22, 2010

lore
Share & tools
lore

ShaunR

author
#0 lore raw

PATCH 1/1 tools/xenstat/xentop/xentop.c -- fix xentop so it returns the correct exit code on invalid argument

This patch fixes the problem with xentop where it returns an exit code of 0 when passing it invalid options when it should return 1. The issue comes from getopt() returning '?' and the case from switch matching it.
The solution was to remove the case '?' so that the default match
could be triggered.

Quote from man 3 getopt
"If getopt() does not recognize an option character, it prints an error message to stderr, stores the character in optopt, and returns '?'."

xenstat/xentop/xentop.c 2010-10-22 15:20:21.000000000 -0700 renamed from xenstat/xentop/xentop.c-orig 2010-10-22 15:20:13.000000000 -0700 +0 -1
@@ -1135,7 +1135,6 @@
                default:
                        usage(argv[0]);
                        exit(1);
-               case '?':
                case 'h':
                        usage(argv[0]);
                        exit(0);