Skip to contentSkip to conversation

clear irq pending when bypassing it

PATCH Eric W. Biederman 2 participants 3 messages Apr 30, 2009 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 5 lines · Joe Korty

IRQ_MOVE_PENDING must be cleared whenever it is bypassed.

Otherwise, we risk an old, pending affinity change overtaking and erasing a more recent affinity change that had been directly applied (eg, IRQ_MOVE_PCNTXT mode).

When can this happen?

Eric

#2 lore raw
Quoted 9 lines · Eric W. Biederman
Quoted 5 lines · Joe Korty

IRQ_MOVE_PENDING must be cleared whenever it is bypassed.

Otherwise, we risk an old, pending affinity change overtaking and erasing a more recent affinity change that had been directly applied (eg, IRQ_MOVE_PCNTXT mode).

When can this happen?

Probably doesn't happen. AFAIK, each IRQ is either fully MSI or non-MSI. The MSI IRQs will always use IRQ_MOVE_PCNTXT and the non-MSI's will never use IRQ_MOVE_PCNTXT. Thus no collision.

It could only happen if it was possible for a MSI and non-MSI device to share an IRQ.

Joe

#3 lore raw
Quoted 9 lines · Joe Korty
Quoted 8 lines · Eric W. Biederman
Quoted 5 lines · Joe Korty

IRQ_MOVE_PENDING must be cleared whenever it is bypassed.

Otherwise, we risk an old, pending affinity change overtaking and erasing a more recent affinity change that had been directly applied (eg, IRQ_MOVE_PCNTXT mode).

Quoted 8 lines
Quoted 1 line

When can this happen?

Probably doesn't happen. AFAIK, each IRQ is either fully MSI or non-MSI. The MSI IRQs will always use IRQ_MOVE_PCNTXT and the non-MSI's will never use IRQ_MOVE_PCNTXT. Thus no collision.

It could only happen if it was possible for a MSI and non-MSI device to share an IRQ.

Ok. I thought you might have seen something.

It doesn't happen and it can't happen, making your patch wrong.

Eric