clear irq pending when bypassing it
Quoted 5 lines · Joe Korty
IRQ_MOVE_PENDINGmust be cleared whenever it is bypassed.Otherwise, we risk an old, pending affinity change overtaking and erasing a more recent affinity change that had been directly applied (eg,
IRQ_MOVE_PCNTXTmode).
When can this happen?
Eric
Quoted 9 lines · Eric W. Biederman
Quoted 5 lines · Joe Korty
IRQ_MOVE_PENDINGmust be cleared whenever it is bypassed.Otherwise, we risk an old, pending affinity change overtaking and erasing a more recent affinity change that had been directly applied (eg,
IRQ_MOVE_PCNTXTmode).When can this happen?
Probably doesn't happen. AFAIK, each IRQ is either fully MSI or non-MSI. The MSI IRQs will always use IRQ_MOVE_PCNTXT and the non-MSI's will never use IRQ_MOVE_PCNTXT. Thus no collision.
It could only happen if it was possible for a MSI and non-MSI device to share an IRQ.
Joe
Quoted 9 lines · Joe Korty
Quoted 8 lines · Eric W. Biederman
Quoted 5 lines · Joe Korty
IRQ_MOVE_PENDINGmust be cleared whenever it is bypassed.Otherwise, we risk an old, pending affinity change overtaking and erasing a more recent affinity change that had been directly applied (eg,
IRQ_MOVE_PCNTXTmode).
Quoted 8 lines
Quoted 1 line
When can this happen?
Probably doesn't happen. AFAIK, each IRQ is either fully MSI or non-MSI. The MSI IRQs will always use
IRQ_MOVE_PCNTXTand the non-MSI's will never useIRQ_MOVE_PCNTXT. Thus no collision.It could only happen if it was possible for a MSI and non-MSI device to share an IRQ.
Ok. I thought you might have seen something.
It doesn't happen and it can't happen, making your patch wrong.
Eric