Skip to contentSkip to conversation

A320: Add support for Faraday A320 evaluation board

PATCH Superseded Po-Yu Chuang 3 participants 7 messages Jun 23, 2009 – Jun 26, 2009

Subsystems (2)

v1 of 7 Superseded Latest is v7 →

lore
Share & tools
lore
#0 lore raw

PATCH 3/3 A320: Add support for Faraday A320 evaluation board

This patch adds support for A320 development board from Faraday. This board uses FA526 processor by default and has 512kB and 32MB NOR flash, 64M RAM. FA526 is an ARMv4 processor and uses the ARM920T source in this patch.

---
Index: Makefile
===================================================================
RCS file: /usr/local/cvsroot/ctd/u-boot-2009.06/Makefile,v retrieving revision 1.1.1.1

Makefile +7 -0
diff -u -r1.1.1.1 Makefile
@@ -2940,6 +2940,13 @@
 	@$(MKCONFIG) $(@:_config=) arm s3c44b0 B2 dave
 
 #########################################################################
+## Faraday A320 Systems
+#########################################################################
+
+a320_config	:	unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm920t a320 faraday
+
+#########################################################################
 ## ARM720T Systems
 #########################################################################
 

Index: board/faraday/a320/Makefile
===================================================================
RCS file: board/faraday/a320/Makefile

faraday/a320/Makefile new file +51 -0

51 lines not on this page · raw message

Index: board/faraday/a320/board.c
===================================================================
RCS file: board/faraday/a320/board.c

faraday/a320/board.c new file +120 -0

120 lines not on this page · raw message

Index: board/faraday/a320/config.mk
===================================================================
RCS file: board/faraday/a320/config.mk

faraday/a320/config.mk new file +35 -0
diff -N board/faraday/a320/config.mk
@@ -0,0 +1,35 @@
+#
+# (C) Copyright 2009 Faraday Technology
+# Po-Yu Chuang <[email protected]>
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+
+# Faraday A320 board with FA526/FA626TE/ARM926EJ-S cpus
+#
+# see http://www.faraday-tech.com/ for more information
+
+# A320 has 1 bank of 64 MB DRAM (after remapped)
+#
+# 0000'0000 to 0400'0000
+#
+# Linux-Kernel is expected to be at 0000'8000, entry 0000'8000
+#
+# we load ourself to 03f8'0000
+#
+# download area is 0200'0000
+
+TEXT_BASE = 0x03f80000

Index: board/faraday/a320/ftahbc.h
===================================================================
RCS file: board/faraday/a320/ftahbc.h

faraday/a320/ftahbc.h new file +71 -0

71 lines not on this page · raw message

Index: board/faraday/a320/ftpmu.h
===================================================================
RCS file: board/faraday/a320/ftpmu.h

faraday/a320/ftpmu.h new file +190 -0

190 lines not on this page · raw message

Index: board/faraday/a320/ftsdmc.h
===================================================================
RCS file: board/faraday/a320/ftsdmc.h

faraday/a320/ftsdmc.h new file +103 -0

103 lines not on this page · raw message

Index: board/faraday/a320/ftsmc.h
===================================================================
RCS file: board/faraday/a320/ftsmc.h

faraday/a320/ftsmc.h new file +73 -0

73 lines not on this page · raw message

Index: board/faraday/a320/fttmr.h
===================================================================
RCS file: board/faraday/a320/fttmr.h

faraday/a320/fttmr.h new file +73 -0

73 lines not on this page · raw message

Index: board/faraday/a320/lowlevel_init.S
===================================================================
RCS file: board/faraday/a320/lowlevel_init.S

faraday/a320/lowlevel_init.S new file +205 -0

205 lines not on this page · raw message

Index: board/faraday/a320/timer.c
===================================================================
RCS file: board/faraday/a320/timer.c

faraday/a320/timer.c new file +209 -0

209 lines not on this page · raw message

Index: board/faraday/a320/u-boot.lds
===================================================================
RCS file: board/faraday/a320/u-boot.lds

faraday/a320/u-boot.lds new file +57 -0

57 lines not on this page · raw message

Index: include/configs/a320.h
===================================================================
RCS file: include/configs/a320.h

configs/a320.h new file +181 -0

181 lines not on this page · raw message

#1 lore raw

PATCH 3/3 A320: Add support for Faraday A320 evaluation board

Quoted 6 lines · Po-Yu Chuang

This patch adds support for A320 development board from Faraday. This board uses FA526 processor by default and has 512kB and 32MB NOR flash, 64M RAM. FA526 is an ARMv4 processor and uses the ARM920T source in this patch.

---

please use git
please add a MAKEALL and MAINTAINER entry

Quoted 8 lines

Index: Makefile
===================================================================
RCS file: /usr/local/cvsroot/ctd/u-boot-2009.06/Makefile,v retrieving revision 1.1.1.1
diff -u -r1.1.1.1 Makefile

Makefile line 2947

Quoted 8 lines
Makefile +5 -0
@@ -2940,6 +2940,13 @@
 	@$(MKCONFIG) $(@:_config=) arm s3c44b0 B2 dave
 
 #########################################################################
+## Faraday A320 Systems
+#########################################################################
+
+a320_config	:	unconfig
+	@$(MKCONFIG) $(@:_config=) arm arm920t a320 faraday

920T but you write 926ejs in the config.mk?

Quoted 5 lines
Makefile +2 -0
+
+#########################################################################
 ## ARM720T Systems
 #########################################################################
 

<snip>

Quoted 50 lines

Index: board/faraday/a320/board.c
===================================================================
RCS file: board/faraday/a320/board.c
diff -N board/faraday/a320/board.c

faraday/a320/board.c new file +43 -0
@@ -0,0 +1,120 @@
+/*
+ * (C) Copyright 2009 Faraday Technology
+ * Po-Yu Chuang <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+ */
+
+#include <common.h>
+#include <netdev.h>
+#include <rtc.h>
+
+#include "ftsmc.h"
+
+DECLARE_GLOBAL_DATA_PTR;
+
+#define FLASH_BANK0_CONFIG	(FTSMC_BANK_ENABLE |			\
+				 FTSMC_BANK_BASE(PHYS_FLASH_1) |	\
+				 FTSMC_BANK_SIZE_1M |			\
+				 FTSMC_BANK_MBW_8)
+
+#define FLASH_BANK0_TIMING	(FTSMC_TPR_RBE |	\
+				 FTSMC_TPR_AST(3) |	\
+				 FTSMC_TPR_CTW(3) |	\
+				 FTSMC_TPR_ATI(0xf) |	\
+				 FTSMC_TPR_AT2(3) |	\
+				 FTSMC_TPR_WTC(3) |	\
+				 FTSMC_TPR_AHT(3) |	\
+				 FTSMC_TPR_TRNA(0xf))
+
+#define FLASH_BANK1_CONFIG	(FTSMC_BANK_ENABLE |			\
+				 FTSMC_BANK_BASE(PHYS_FLASH_2) |	\

faraday/a320/board.c line 53

Quoted 10 lines
faraday/a320/board.c new file +10 -0
+				 FTSMC_BANK_SIZE_32M |			\
+				 FTSMC_BANK_MBW_32 )
+
+#define FLASH_BANK1_TIMING	(FTSMC_TPR_AST(3) |	\
+				 FTSMC_TPR_CTW(3) |	\
+				 FTSMC_TPR_ATI(0xf) |	\
+				 FTSMC_TPR_AT2(3) |	\
+				 FTSMC_TPR_WTC(3) |	\
+				 FTSMC_TPR_AHT(3) |	\
+				 FTSMC_TPR_TRNA(0xf))

please move this to config header

faraday/a320/board.c line 55

Quoted 2 lines
faraday/a320/board.c new file +2 -0
+
+extern int timer_init (void);

no-need please remove

faraday/a320/board.c line 62

Quoted 7 lines
faraday/a320/board.c new file +7 -0
+
+/*
+ * Miscellaneous platform dependent initialisations
+ */
+
+static void
+ftsmc_setup_bank (int bank, unsigned int config, unsigned int timing)

is this board or soc specific?

faraday/a320/board.c line 72

Quoted 10 lines
faraday/a320/board.c new file +10 -0
+{
+	volatile struct ftsmc *smc = (struct ftsmc *)CONFIG_SYS_SMC_BASE;
+
+	if (bank < 0 || bank > 3) {
+		printf ("bank # %d invalid\n", bank);
+		return;
+	}
+
+	smc->bank[bank].cr  = cpu_to_le32 (config);
+	smc->bank[bank].tpr = cpu_to_le32 (timing);

please use proper accessor everywhere

Quoted 5 lines
faraday/a320/board.c new file +5 -0
+}
+
+/* initialize Flash */
+static void ftsmc_init (void)
+{

faraday/a320/board.c line 87

Quoted 10 lines
faraday/a320/board.c new file +10 -0
+	ftsmc_setup_bank (0, FLASH_BANK0_CONFIG, FLASH_BANK0_TIMING);
+	ftsmc_setup_bank (1, FLASH_BANK1_CONFIG, FLASH_BANK1_TIMING);
+}
+
+int board_init (void)
+{
+	gd->bd->bi_arch_number = MACH_TYPE_FARADAY;
+
+	ftsmc_init ();
+	rtc_reset ();

do you really need this so early the rtc and enable everytime?

faraday/a320/board.c line 88

Quoted 1 line
faraday/a320/board.c new file +1 -0
+	timer_init ();

no-need pelase remove

Quoted 22 lines
faraday/a320/board.c new file +22 -0
+	return 0;
+}
+
+int dram_init (void)
+{
+	gd->bd->bi_dram[0].start = PHYS_SDRAM_1;
+	gd->bd->bi_dram[0].size  = PHYS_SDRAM_1_SIZE;
+
+	return 0;
+}
+
+int board_eth_init (bd_t * bd)
+{
+	return ftmac100_initialize (bd);
+}
+
+ulong board_flash_get_legacy (ulong base, int banknum, flash_info_t * info)
+{
+	if (banknum == 0) {	/* non-CFI boot flash */
+		info->portwidth = FLASH_CFI_8BIT;
+		info->chipwidth = FLASH_CFI_BY8;
+		info->interface = FLASH_CFI_X8;

faraday/a320/board.c line 120

Quoted 10 lines
faraday/a320/board.c new file +10 -0
+		return 1;
+	} else
+		return 0;
+}
+
+int interrupt_init (void)
+{
+	/* nothing happens here - we don't setup any IRQs */
+	return (0);
+}

no-need please remove

Quoted 18 lines

Index: board/faraday/a320/config.mk
===================================================================
RCS file: board/faraday/a320/config.mk
diff -N board/faraday/a320/config.mk

faraday/a320/config.mk new file +11 -0
@@ -0,0 +1,35 @@
+#
+# (C) Copyright 2009 Faraday Technology
+# Po-Yu Chuang <[email protected]>
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of

faraday/a320/config.mk line 21

Quoted 10 lines
faraday/a320/config.mk new file +10 -0
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+# MA 02111-1307 USA
+#
+
+# Faraday A320 board with FA526/FA626TE/ARM926EJ-S cpus

??

Quoted 14 lines
faraday/a320/config.mk new file +14 -0
+#
+# see http://www.faraday-tech.com/ for more information
+
+# A320 has 1 bank of 64 MB DRAM (after remapped)
+#
+# 0000'0000 to 0400'0000
+#
+# Linux-Kernel is expected to be at 0000'8000, entry 0000'8000
+#
+# we load ourself to 03f8'0000
+#
+# download area is 0200'0000
+
+TEXT_BASE = 0x03f80000

<snip>

Quoted 5 lines

Index: board/faraday/a320/ftahbc.h
Index: board/faraday/a320/ftpmu.h
Index: board/faraday/a320/ftsdmc.h
Index: board/faraday/a320/ftsmc.h
Index: board/faraday/a320/fttmr.h

If I undersand correctly all those header are soc specific not board specific as the timer code
so please move the header to
include/asm-arm/arch-faraday or your soc familiy name
and the code to
cpu/armxxx/faraday/

Quoted 27 lines

Index: board/faraday/a320/lowlevel_init.S
===================================================================
RCS file: board/faraday/a320/lowlevel_init.S
diff -N board/faraday/a320/lowlevel_init.S

faraday/a320/lowlevel_init.S new file +20 -0
@@ -0,0 +1,205 @@
+/*
+ * (C) Copyright 2009 Faraday Technology
+ * Po-Yu Chuang <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+ */
+
+#include <config.h>

faraday/a320/lowlevel_init.S line 30

Quoted 10 lines
faraday/a320/lowlevel_init.S new file +10 -0
+#include <version.h>
+#include "ftahbc.h"
+#include "ftsdmc.h"
+
+/*
+ * Memory Mapping
+ */
+#define CONFIG_SYS_ROM_DEFAULT		0x00000000
+#define CONFIG_SYS_SDRAM_DEFAULT	0x10000000
+#define CONFIG_SYS_SDRAM_REMAPPED	PHYS_SDRAM_1	/* remap location */

I guess this board specific too

faraday/a320/lowlevel_init.S line 39

Quoted 9 lines
faraday/a320/lowlevel_init.S new file +9 -0
+
+/*
+ * numeric 7 segment display
+ */
+.macro	led, num, rtmp1, rtmp2
+	mov	\rtmp1, #\num
+	ldr	\rtmp2, =CONFIG_SYS_DEBUG_LED
+	str	\rtmp1, [\rtmp2]
+.endm

please use write32

Quoted 29 lines
faraday/a320/lowlevel_init.S new file +29 -0
+
+.global reset_cpu
+reset_cpu:
+	b	reset_cpu
+
+.globl lowlevel_init
+lowlevel_init:
+	mov	r11, lr
+
+	led	0x0, r0, r1
+
+	/* if REMAP bit is set -> memory had been initialzed */
+
+	ldr	r0, =CONFIG_SYS_AHBC_BASE
+	ldr	r1, [r0, #FTAHBC_OFFSET_ICR]
+	tst	r1, #FTAHBC_ICR_REMAP		@ test REMAP bit
+	bne	1f
+
+	bl	init_sdmc
+
+	led	0x1, r0, r1
+
+	/*
+	 * copy U-Boot to RAM
+	 */
+copy_code:
+	ldr	r0, =CONFIG_SYS_ROM_DEFAULT	/* r0 <- source address     */
+	ldr	r1, =CONFIG_SYS_SDRAM_DEFAULT	/* r1 <- target address     */
+

faraday/a320/lowlevel_init.S line 78

Quoted 10 lines
faraday/a320/lowlevel_init.S new file +10 -0
+	ldr	r2, .LC5
+	ldr	r3, .LC6
+	sub	r2, r3, r2		/* r2 <- size of armboot            */
+	add	r2, r0, r2		/* r2 <- source end address         */
+
+copy_loop:
+	ldmia	r0!, {r3-r10}		/* copy from source address [r0]    */
+	stmia	r1!, {r3-r10}		/* copy to   target address [r1]    */
+	cmp	r0, r2			/* until source end addreee [r2]    */
+	ble	copy_loop

why???
it's already done in the start.S

Quoted 12 lines
faraday/a320/lowlevel_init.S new file +12 -0
+
+	led	0x2, r0, r1
+
+	bl	remap
+1:
+	led	0x3, r0, r1
+
+	/* everything is fine now */
+	mov	lr, r11
+	mov	pc, lr
+
+.LC5:

faraday/a320/lowlevel_init.S line 100

Quoted 10 lines
faraday/a320/lowlevel_init.S new file +10 -0
+	.word	_start
+.LC6:
+	.word	__bss_start
+
+/*
+ * memory initialization
+ */
+init_sdmc:
+	mov	r9, lr
+

please use write32 and co when it's possible
include/asm-arm/macro.h

Quoted 90 lines
faraday/a320/lowlevel_init.S new file +90 -0
+	/* set SDRAM register */
+	ldr	r0, =CONFIG_SYS_SDMC_BASE
+	ldr	r1, tp0
+	str	r1, [r0, #FTSDMC_OFFSET_TP0]
+	ldr	r1, tp1
+	str	r1, [r0, #FTSDMC_OFFSET_TP1]
+
+	/* set to precharge */
+	mov	r1, #FTSDMC_CR_IPREC
+	str	r1, [r0, #FTSDMC_OFFSET_CR]
+
+	/* Waiting for SDRAM to set up */
+4:
+	ldr	r1, [r0, #FTSDMC_OFFSET_CR]
+	cmp	r1, #0
+	bne	4b
+
+	/* set mode register */
+	ldr	r1, =FTSDMC_CR_ISMR
+	str	r1, [r0, #FTSDMC_OFFSET_CR]
+
+	/* Waiting for SDRAM to set up */
+5:
+	ldr	r1, [r0, #FTSDMC_OFFSET_CR]
+	cmp	r1,   #0
+	bne	5b
+
+	/* set to refresh */
+	mov	r1, #FTSDMC_CR_IREF
+	str	r1, [r0, #FTSDMC_OFFSET_CR]
+
+	/* Waiting for SDRAM to set up */
+6:
+	ldr	r1, [r0, #FTSDMC_OFFSET_CR]
+	cmp	r1, #0
+	bne	6b
+
+	ldr	r1, b0_bsr
+	ldr	r2, =FTSDMC_BANK_BASE(CONFIG_SYS_SDRAM_DEFAULT)
+	orr	r1, r1, r2
+	str	r1, [r0, #FTSDMC_OFFSET_BANK0_BSR]	@ bank 0
+
+	ldr	r1, =0x0
+	str	r1, [r0, #FTSDMC_OFFSET_BANK1_BSR]	@ bank 1 (clear/disable)
+	str	r1, [r0, #FTSDMC_OFFSET_BANK2_BSR]	@ bank 2 (clear/disable)
+	str	r1, [r0, #FTSDMC_OFFSET_BANK3_BSR]	@ bank 3 (clear/disable)
+	str	r1, [r0, #FTSDMC_OFFSET_BANK4_BSR]	@ bank 4 (clear/disable)
+	str	r1, [r0, #FTSDMC_OFFSET_BANK5_BSR]	@ bank 5 (clear/disable)
+	str	r1, [r0, #FTSDMC_OFFSET_BANK6_BSR]	@ bank 6 (clear/disable)
+	str	r1, [r0, #FTSDMC_OFFSET_BANK7_BSR]	@ bank 7 (clear/disable)
+
+	ldr	r1, =FTSDMC_ACR_TOC(0x18)
+	str	r1, [r0, #FTSDMC_OFFSET_ACR]	@ arbiter
+
+	mov	lr, r9
+	mov	pc, lr
+
+/*
+ * This code will remap the memory ROM and SDRAM
+ * ROM will be placed on 0x80000000 SDRAM will jump to 0x0
+ */
+remap:
+	mov	r9, lr
+
+	ldr	r0, =CONFIG_SYS_SDMC_BASE
+
+	/* first adjust sdram */
+	ldr	r1, b0_bsr
+	ldr	r2, =FTSDMC_BANK_BASE(CONFIG_SYS_SDRAM_REMAPPED)
+	orr	r1, r1, r2
+	str	r1, [r0, #FTSDMC_OFFSET_BANK0_BSR]	@ bank 0
+
+	/* then remap */
+	ldr	r3, =CONFIG_SYS_AHBC_BASE
+	ldr	r4, [r3, #FTAHBC_OFFSET_ICR]
+	orr	r4, r4, #FTAHBC_ICR_REMAP		@ Set REMAP bit
+	str	r4, [r3, #FTAHBC_OFFSET_ICR]
+
+	mov	lr, r9
+	mov	pc, lr
+
+/*
+ * some parameters for the board
+ */
+tp0:	.word	FTSDMC_TP0_TRAS(2) |	\
+		FTSDMC_TP0_TRP(1) |	\
+		FTSDMC_TP0_TRCD(1) |	\
+		FTSDMC_TP0_TRF(3) |	\
+		FTSDMC_TP0_TWR(1) |	\
+		FTSDMC_TP0_TCL(2)

faraday/a320/lowlevel_init.S line 200

Quoted 10 lines
faraday/a320/lowlevel_init.S new file +10 -0
+
+tp1:	.word	FTSDMC_TP1_INI_PREC(4) |	\
+		FTSDMC_TP1_INI_REFT(8) |	\
+		FTSDMC_TP1_REF_INTV(0x180)
+
+b0_bsr:	.word	FTSDMC_BANK_ENABLE |	\
+		FTSDMC_BANK_DDW_X16 |	\
+		FTSDMC_BANK_DSZ_256M |	\
+		FTSDMC_BANK_MBW_32 |	\
+		FTSDMC_BANK_SIZE_64M

those config will need to the config head

Quoted 1 line

Index: board/faraday/a320/u-boot.lds

no need please remove

Quoted 34 lines

Index: include/configs/a320.h
===================================================================
RCS file: include/configs/a320.h
diff -N include/configs/a320.h

configs/a320.h new file +27 -0
@@ -0,0 +1,181 @@
+/*
+ * (C) Copyright 2009 Faraday Technology
+ * Po-Yu Chuang <[email protected]>
+ *
+ * Configuation settings for the Faraday A320 board.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+ */
+
+#ifndef __CONFIG_H
+#define __CONFIG_H
+
+/*-----------------------------------------------------------------------
+ * CPU and Board Configuration Options
+ */

configs/a320.h line 37

Quoted 10 lines
configs/a320.h new file +10 -0
+#define CONFIG_A320		/* in a Faraday A320 SoC/Board   */
+
+#undef CONFIG_USE_IRQ		/* we don't need IRQ/FIQ stuff */
+
+#undef CONFIG_SKIP_LOWLEVEL_INIT
+
+/*-----------------------------------------------------------------------
+ * Timer
+ */
+#define CONFIG_SYS_HZ		32768	/* timer ticks per second */

1000 mandatory

configs/a320.h line 38

Quoted 1 line
configs/a320.h new file +1 -0
+#define CONFIG_SYS_TIMERBASE	0x98400000

is it board specific??

configs/a320.h line 44

Quoted 6 lines
configs/a320.h new file +6 -0
+
+/*-----------------------------------------------------------------------
+ * RTC
+ */
+#define CONFIG_RTC_FTRTC
+#define CONFIG_SYS_RTC_BASE	0x98600000

ditto

Quoted 13 lines
configs/a320.h new file +13 -0
+
+/*-----------------------------------------------------------------------
+ * Serial console configuration
+ */
+
+/* FTUART is a high speed NS 16C550A compatible UART */
+#define CONFIG_BAUDRATE			38400
+#define CONFIG_CONS_INDEX		1
+#define CONFIG_SYS_NS16550
+#define CONFIG_SYS_NS16550_SERIAL
+#define CONFIG_SYS_NS16550_COM1		0x98200000
+#define CONFIG_SYS_NS16550_REG_SIZE	-4
+#define CONFIG_SYS_NS16550_CLK		18432000

configs/a320.h line 67

Quoted 10 lines
configs/a320.h new file +10 -0
+
+/* valid baudrates */
+#define CONFIG_SYS_BAUDRATE_TABLE	{ 9600, 19200, 38400, 57600, 115200 }
+
+/*-----------------------------------------------------------------------
+ * Ethernet
+ */
+#define CONFIG_NET_MULTI
+#define CONFIG_DRIVER_FTMAC100
+#define CONFIG_SYS_MAC100_BASE	0x90900000

ditto

configs/a320.h line 73

Quoted 6 lines
configs/a320.h new file +6 -0
+
+#define CONFIG_BOOTDELAY	3
+#define CONFIG_ETHADDR		c3:10:da:ce:3f:3e
+#define CONFIG_NETMASK		255.255.255.0
+#define CONFIG_IPADDR		192.168.68.55
+#define CONFIG_SERVERIP		192.168.68.63

please remove the mac and ip config

configs/a320.h line 81

Quoted 8 lines
configs/a320.h new file +8 -0
+
+/*-----------------------------------------------------------------------
+ * Hardware register bases
+ */
+#define CONFIG_SYS_AHBC_BASE	0x90100000	/* AHB Controller */
+#define CONFIG_SYS_SMC_BASE	0x90200000	/* Static Memory Controller */
+#define CONFIG_SYS_DEBUG_LED	0x902ffffc	/* Debug LED */
+#define CONFIG_SYS_SDMC_BASE	0x90300000	/* SDRAM Controller */

is it board specific??

configs/a320.h line 83

Quoted 2 lines
configs/a320.h new file +2 -0
+
+#define CONFIG_SYS_FTPMU_BASE	0x98100000	/* Power Management Unit */

is it board specific??

Quoted 61 lines
configs/a320.h new file +61 -0
+
+/*-----------------------------------------------------------------------
+ * Command line configuration.
+ */
+#include <config_cmd_default.h>
+
+#define CONFIG_CMD_CACHE
+#define CONFIG_CMD_DATE
+#define CONFIG_CMD_PING
+
+/*-----------------------------------------------------------------------
+ * Miscellaneous configurable options
+ */
+#define CONFIG_SYS_LONGHELP			/* undef to save memory */
+#define CONFIG_SYS_PROMPT	"A320 # "	/* Monitor Command Prompt */
+#define CONFIG_SYS_CBSIZE	256		/* Console I/O Buffer Size */
+
+/* Print Buffer Size */
+#define CONFIG_SYS_PBSIZE	\
+	(CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16)
+
+/* max number of command args */
+#define CONFIG_SYS_MAXARGS	16
+
+/* Boot Argument Buffer Size */
+#define CONFIG_SYS_BARGSIZE	CONFIG_SYS_CBSIZE
+
+/*-----------------------------------------------------------------------
+ * Stack sizes
+ *
+ * The stack sizes are set up in start.S using the settings below
+ */
+#define CONFIG_STACKSIZE	(128 * 1024)	/* regular stack */
+#ifdef CONFIG_USE_IRQ
+#define CONFIG_STACKSIZE_IRQ	(4 * 1024)	/* IRQ stack */
+#define CONFIG_STACKSIZE_FIQ	(4 * 1024)	/* FIQ stack */
+#endif
+
+/*-----------------------------------------------------------------------
+ * Size of malloc() pool
+ */
+#define CONFIG_SYS_MALLOC_LEN		(CONFIG_ENV_SIZE + 128 * 1024)
+
+/*-----------------------------------------------------------------------
+ * size in bytes reserved for initial data
+*/
+#define CONFIG_SYS_GBL_DATA_SIZE	128
+
+/*-----------------------------------------------------------------------
+ * Physical Memory Map
+ */
+#define CONFIG_NR_DRAM_BANKS	1		/* we have 1 bank of DRAM */
+#define PHYS_SDRAM_1		0x00000000	/* SDRAM Bank #1 */
+#define PHYS_SDRAM_1_SIZE	0x04000000	/* 64 MB */
+
+/*
+ * Load address and memory test area should agree with
+ * board/faraday/a320/config.mk. Be careful not to overwrite U-boot itself.
+ */
+#define CONFIG_SYS_LOAD_ADDR		0x02000000
+

configs/a320.h line 154

Quoted 10 lines
configs/a320.h new file +10 -0
+/* memtest works on 63 MB in DRAM */
+#define CONFIG_SYS_MEMTEST_START	0x00000000
+#define CONFIG_SYS_MEMTEST_END		0x03F00000
+
+/*-----------------------------------------------------------------------
+ * FLASH and environment organization
+ */
+
+/* no environments */
+#define CONFIG_ENV_IS_NOWHERE

you do not plan to store the env in nor?

configs/a320.h line 158

Quoted 4 lines
configs/a320.h new file +4 -0
+
+/* Total Size of Environment Sector */
+#define CONFIG_ENV_SIZE			0x20000
+

Best Regards,
J.

#2 lore raw

PATCH 3/3 A320: Add support for Faraday A320 evaluation board

Dear Jean-Christophe PLAGNIOL-VILLARD,

Thank you for your detailed review

2009/6/24 Jean-Christophe PLAGNIOL-VILLARD <[email protected]>:

Quoted 1 line

please use git

I cannot access git in the company, but I will try that at home.

Quoted 1 line

please add a MAKEALL and MAINTAINER entry

ok, I will fix them

Quoted 4 lines
Quoted 3 lines

RCS file: /usr/local/cvsroot/ctd/u-boot-2009.06/Makefile,v +a320_config ?: ? ? ? unconfig
+ ? ? @$(MKCONFIG) $(@:_config=) arm arm920t a320 faraday

920T but you write 926ejs in the config.mk?

please see the explanation below

Quoted 20 lines
Quoted 20 lines

diff -N board/faraday/a320/board.c

(quoted diff) +19 -0
+#define FLASH_BANK0_CONFIG ? (FTSMC_BANK_ENABLE | ? ? ? ? ? ? ? ? ? ?\
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?FTSMC_BANK_BASE(PHYS_FLASH_1) | ? ? ? ?\
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?FTSMC_BANK_SIZE_1M | ? ? ? ? ? ? ? ? ? \
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?FTSMC_BANK_MBW_8)
+
+#define FLASH_BANK0_TIMING ? (FTSMC_TPR_RBE | ? ? ? ?\
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?FTSMC_TPR_AST(3) | ? ? \
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?FTSMC_TPR_CTW(3) | ? ? \
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?FTSMC_TPR_ATI(0xf) | ? \
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?FTSMC_TPR_AT2(3) | ? ? \
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?FTSMC_TPR_WTC(3) | ? ? \
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?FTSMC_TPR_AHT(3) | ? ? \
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?FTSMC_TPR_TRNA(0xf))
+
+#define FLASH_BANK1_CONFIG ? (FTSMC_BANK_ENABLE | ? ? ? ? ? ? ? ? ? ?\
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?FTSMC_BANK_BASE(PHYS_FLASH_2) | ? ? ? ?\
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?FTSMC_BANK_SIZE_32M | ? ? ? ? ? ? ? ? ?\
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?FTSMC_BANK_MBW_32 )
+
Quoted 8 lines
Quoted 7 lines

+#define FLASH_BANK1_TIMING ? (FTSMC_TPR_AST(3) | ? ? \
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?FTSMC_TPR_CTW(3) | ? ? \
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?FTSMC_TPR_ATI(0xf) | ? \

+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?FTSMC_TPR_AT2(3) | ? ? \
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?FTSMC_TPR_WTC(3) | ? ? \
+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?FTSMC_TPR_AHT(3) | ? ? \

+ ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?FTSMC_TPR_TRNA(0xf))

please move this to config header

ok, I will fix them

Quoted 3 lines

Review

Quoted 2 lines
(quoted diff) +2 -0
+
+extern int timer_init (void);

no-need please remove

ok

Quoted 3 lines
Quoted 2 lines

+ ? ? smc->bank[bank].cr ?= cpu_to_le32 (config);
+ ? ? smc->bank[bank].tpr = cpu_to_le32 (timing);

please use proper accessor everywhere

Should I use
writel(config, &smc->bank[bank].cr);
or
smc->bank[bank].cr = config;

Quoted 7 lines

faraday/a320/board.c

Quoted 6 lines
faraday/a320/board.c new file +6 -0
+int board_init (void)
+{
+ ? ? gd->bd->bi_arch_number = MACH_TYPE_FARADAY;
+
+ ? ? ftsmc_init ();
+ ? ? rtc_reset ();

do you really need this so early the rtc and enable everytime?

sorry, I don't understand what do you mean.

Quoted 2 lines
Quoted 1 line

+ ? ? timer_init ();

no-need pelase remove

ok

Quoted 6 lines

faraday/a320/board.c line 120

Quoted 5 lines
faraday/a320/board.c new file +5 -0
+int interrupt_init (void)
+{
+ ? ? /* nothing happens here - we don't setup any IRQs */
+ ? ? return (0);
+}

no-need please remove

It looks like interrupt_init is an soc function, I will put it to the soc code.

Quoted 8 lines
Quoted 2 lines

diff -N board/faraday/a320/config.mk
+# Faraday A320 board with FA526/FA626TE/ARM926EJ-S cpus

??

Quoted 5 lines

Index: board/faraday/a320/ftahbc.h
Index: board/faraday/a320/ftpmu.h
Index: board/faraday/a320/ftsdmc.h
Index: board/faraday/a320/ftsmc.h
Index: board/faraday/a320/fttmr.h

Quoted 6 lines

If I undersand correctly all those header are soc specific not board specific as the timer code
so please move the header to
include/asm-arm/arch-faraday or your soc familiy name
and the code to
cpu/armxxx/faraday/

We have an SOC called a320 (so does the evaluation board) which has an armv4 cpu called fa526.
We can overdrive (with daughter board) it with a different cpu such as arm926ej-s.

At first, I created cpu/fa526 and copy the cpu stuff from arm920t. Then I found that it is not a good
idea to duplicate code, so I reused cpu/arm920t.

If I should create an SOC directory, where should I place it? cpu/fa526/a320 ? but this duplicates cpu code cpu/arm920t/a320 ? but it is not arm920t in fact cpu/arm926ejs/a320? but it is not arm926ejs by default

Quoted 8 lines

faraday/a320/lowlevel_init.S

Quoted 7 lines

diff -N board/faraday/a320/lowlevel_init.S

faraday/a320/lowlevel_init.S new file +6 -0
+/*
+ * Memory Mapping
+ */
+#define CONFIG_SYS_ROM_DEFAULT ? ? ? ? ? ? ? 0x00000000
+#define CONFIG_SYS_SDRAM_DEFAULT ? ? 0x10000000
+#define CONFIG_SYS_SDRAM_REMAPPED ? ?PHYS_SDRAM_1 ? ?/* remap location */

I guess this board specific too

yes

Quoted 9 lines
Quoted 8 lines

+/*
+ * numeric 7 segment display
+ */
+.macro ? ? ? led, num, rtmp1, rtmp2
+ ? ? mov ? ? \rtmp1, #\num
+ ? ? ldr ? ? \rtmp2, =CONFIG_SYS_DEBUG_LED
+ ? ? str ? ? \rtmp1, [\rtmp2]
+.endm

please use write32

ok, I will fix this

Quoted 11 lines
Quoted 11 lines

+ ? ? /*
+ ? ? ?* copy U-Boot to RAM
+ ? ? ?*/

(quoted diff) +8 -0
+copy_code:
+ ? ? ldr ? ? r0, =CONFIG_SYS_ROM_DEFAULT ? ? /* r0 <- source address ? ? */
+ ? ? ldr ? ? r1, =CONFIG_SYS_SDRAM_DEFAULT ? /* r1 <- target address ? ? */
+
+ ? ? ldr ? ? r2, .LC5
+ ? ? ldr ? ? r3, .LC6
+ ? ? sub ? ? r2, r3, r2 ? ? ? ? ? ? ?/* r2 <- size of armboot ? ? ? ? ? ?*/
+ ? ? add ? ? r2, r0, r2 ? ? ? ? ? ? ?/* r2 <- source end address ? ? ? ? */
Quoted 8 lines

Review

Quoted 6 lines
(quoted diff) +6 -0
+
+copy_loop:
+ ? ? ldmia ? r0!, {r3-r10} ? ? ? ? ? /* copy from source address [r0] ? ?*/
+ ? ? stmia ? r1!, {r3-r10} ? ? ? ? ? /* copy to ? target address [r1] ? ?*/
+ ? ? cmp ? ? r0, r2 ? ? ? ? ? ? ? ? ?/* until source end addreee [r2] ? ?*/
+ ? ? ble ? ? copy_loop

why???
it's already done in the start.S

After power on, cpu starts from ROM (at 0x0) and this code copies u-boot to SDRAM (at 0x10000000). Then the later "remap" routine modifies the setting of the AHB controller. SDRAM base will become 0x0. Therefore I have to do this copy to make "remap" work.

Other boot loader of our company behaves like this and our kernel and non-OS programs depends on it (SDRAM base 0x0). Therefore, TEXT_BASE is 0x03f80000 rather than 0x13f80000.

Quoted 16 lines
Quoted 16 lines
faraday/a320/lowlevel_init.S new file +16 -0
+
+ ? ? led ? ? 0x2, r0, r1
+
+ ? ? bl ? ? ?remap
+1:
+ ? ? led ? ? 0x3, r0, r1
+
+ ? ? /* everything is fine now */
+ ? ? mov ? ? lr, r11
+ ? ? mov ? ? pc, lr
+
+.LC5:
+ ? ? .word ? _start
+.LC6:
+ ? ? .word ? __bss_start
+
Quoted 8 lines

faraday/a320/lowlevel_init.S line 100

Quoted 6 lines
faraday/a320/lowlevel_init.S new file +6 -0
+/*
+ * memory initialization
+ */
+init_sdmc:
+ ? ? mov ? ? r9, lr
+

please use write32 and co when it's possible
include/asm-arm/macro.h

ok, I will fix them

Quoted 43 lines
Quoted 43 lines

+ ? ? /* set SDRAM register */
+ ? ? ldr ? ? r0, =CONFIG_SYS_SDMC_BASE
+ ? ? ldr ? ? r1, tp0
+ ? ? str ? ? r1, [r0, #FTSDMC_OFFSET_TP0]
+ ? ? ldr ? ? r1, tp1
+ ? ? str ? ? r1, [r0, #FTSDMC_OFFSET_TP1]

(quoted diff) +36 -0
+/*
+ * This code will remap the memory ROM and SDRAM
+ * ROM will be placed on 0x80000000 SDRAM will jump to 0x0
+ */
+remap:
+ ? ? mov ? ? r9, lr
+
+ ? ? ldr ? ? r0, =CONFIG_SYS_SDMC_BASE
+
+ ? ? /* first adjust sdram */
+ ? ? ldr ? ? r1, b0_bsr
+ ? ? ldr ? ? r2, =FTSDMC_BANK_BASE(CONFIG_SYS_SDRAM_REMAPPED)
+ ? ? orr ? ? r1, r1, r2
+ ? ? str ? ? r1, [r0, #FTSDMC_OFFSET_BANK0_BSR] ? ? ?@ bank 0
+
+ ? ? /* then remap */
+ ? ? ldr ? ? r3, =CONFIG_SYS_AHBC_BASE
+ ? ? ldr ? ? r4, [r3, #FTAHBC_OFFSET_ICR]
+ ? ? orr ? ? r4, r4, #FTAHBC_ICR_REMAP ? ? ? ? ? ? ? @ Set REMAP bit
+ ? ? str ? ? r4, [r3, #FTAHBC_OFFSET_ICR]
+
+ ? ? mov ? ? lr, r9
+ ? ? mov ? ? pc, lr
+
+/*
+ * some parameters for the board
+ */
+tp0: .word ? FTSDMC_TP0_TRAS(2) | ? ?\
+ ? ? ? ? ? ? FTSDMC_TP0_TRP(1) | ? ? \
+ ? ? ? ? ? ? FTSDMC_TP0_TRCD(1) | ? ?\
+ ? ? ? ? ? ? FTSDMC_TP0_TRF(3) | ? ? \
+ ? ? ? ? ? ? FTSDMC_TP0_TWR(1) | ? ? \
+ ? ? ? ? ? ? FTSDMC_TP0_TCL(2)
+
+tp1: .word ? FTSDMC_TP1_INI_PREC(4) | ? ? ? ?\
+ ? ? ? ? ? ? FTSDMC_TP1_INI_REFT(8) | ? ? ? ?\
Quoted 8 lines

Review

Quoted 7 lines

+ ? ? ? ? ? ? FTSDMC_TP1_REF_INTV(0x180)

(quoted diff) +6 -0
+
+b0_bsr: ? ? ?.word ? FTSDMC_BANK_ENABLE | ? ?\
+ ? ? ? ? ? ? FTSDMC_BANK_DDW_X16 | ? \
+ ? ? ? ? ? ? FTSDMC_BANK_DSZ_256M | ?\
+ ? ? ? ? ? ? FTSDMC_BANK_MBW_32 | ? ?\
+ ? ? ? ? ? ? FTSDMC_BANK_SIZE_64M

those config will need to the config head

ok, I will fix this

Quoted 40 lines
Quoted 1 line

Index: board/faraday/a320/u-boot.lds

no need please remove

Quoted 37 lines

Index: include/configs/a320.h
===================================================================
RCS file: include/configs/a320.h
diff -N include/configs/a320.h

configs/a320.h ? ?23 Jun 2009 06:25:54 -0000 ? ? ?1.3 renamed from dev/null 1 Jan 1970 00:00:00 -0000 +30 -0
@@ -0,0 +1,181 @@
+/*
+ * (C) Copyright 2009 Faraday Technology
+ * Po-Yu Chuang <[email protected]>
+ *
+ * Configuation settings for the Faraday A320 board.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. ?See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+ */
+
+#ifndef __CONFIG_H
+#define __CONFIG_H
+
+/*-----------------------------------------------------------------------
+ * CPU and Board Configuration Options
+ */
+#define CONFIG_A320 ? ? ? ? ?/* in a Faraday A320 SoC/Board ? */
+
+#undef CONFIG_USE_IRQ ? ? ? ? ? ? ? ?/* we don't need IRQ/FIQ stuff */
Quoted 8 lines

configs/a320.h ? ?23 Jun 2009 06:25:54 -0000 ? ? ?1.3 line 37

Quoted 7 lines
configs/a320.h ? ?23 Jun 2009 06:25:54 -0000 ? ? ?1.3 renamed from dev/null 1 Jan 1970 00:00:00 -0000 +7 -0
+
+#undef CONFIG_SKIP_LOWLEVEL_INIT
+
+/*-----------------------------------------------------------------------
+ * Timer
+ */
+#define CONFIG_SYS_HZ ? ? ? ? ? ? ? ?32768 ? /* timer ticks per second */

1000 mandatory

ok, I will fix it

Quoted 2 lines

configs/a320.h ? ?23 Jun 2009 06:25:54 -0000 ? ? ?1.3 line 38

Quoted 1 line
configs/a320.h ? ?23 Jun 2009 06:25:54 -0000 ? ? ?1.3 renamed from dev/null 1 Jan 1970 00:00:00 -0000 +1 -0
+#define CONFIG_SYS_TIMERBASE 0x98400000

is it board specific??

soc specific indeed

Quoted 7 lines

configs/a320.h ? ?23 Jun 2009 06:25:54 -0000 ? ? ?1.3 line 44

Quoted 6 lines
configs/a320.h ? ?23 Jun 2009 06:25:54 -0000 ? ? ?1.3 renamed from dev/null 1 Jan 1970 00:00:00 -0000 +6 -0
+
+/*-----------------------------------------------------------------------
+ * RTC
+ */
+#define CONFIG_RTC_FTRTC
+#define CONFIG_SYS_RTC_BASE ?0x98600000

ditto

ok

Quoted 2 lines

configs/a320.h ? ?23 Jun 2009 06:25:54 -0000 ? ? ?1.3 line 45

Quoted 1 line
configs/a320.h ? ?23 Jun 2009 06:25:54 -0000 ? ? ?1.3 renamed from dev/null 1 Jan 1970 00:00:00 -0000 +1 -0
+#define CONFIG_SYS_MAC100_BASE ? ? ? 0x90900000

ditto

ok

Quoted 7 lines

configs/a320.h ? ?23 Jun 2009 06:25:54 -0000 ? ? ?1.3 line 51

Quoted 6 lines
configs/a320.h ? ?23 Jun 2009 06:25:54 -0000 ? ? ?1.3 renamed from dev/null 1 Jan 1970 00:00:00 -0000 +6 -0
+
+#define CONFIG_BOOTDELAY ? ? 3
+#define CONFIG_ETHADDR ? ? ? ? ? ? ? c3:10:da:ce:3f:3e
+#define CONFIG_NETMASK ? ? ? ? ? ? ? 255.255.255.0
+#define CONFIG_IPADDR ? ? ? ? ? ? ? ?192.168.68.55
+#define CONFIG_SERVERIP ? ? ? ? ? ? ?192.168.68.63

please remove the mac and ip config

ok, I will fix it

Quoted 9 lines

configs/a320.h ? ?23 Jun 2009 06:25:54 -0000 ? ? ?1.3 line 59

Quoted 8 lines
configs/a320.h ? ?23 Jun 2009 06:25:54 -0000 ? ? ?1.3 renamed from dev/null 1 Jan 1970 00:00:00 -0000 +8 -0
+
+/*-----------------------------------------------------------------------
+ * Hardware register bases
+ */
+#define CONFIG_SYS_AHBC_BASE 0x90100000 ? ? ?/* AHB Controller */
+#define CONFIG_SYS_SMC_BASE ?0x90200000 ? ? ?/* Static Memory Controller */
+#define CONFIG_SYS_DEBUG_LED 0x902ffffc ? ? ?/* Debug LED */
+#define CONFIG_SYS_SDMC_BASE 0x90300000 ? ? ?/* SDRAM Controller */

is it board specific??

You are right. soc specific

Quoted 4 lines

configs/a320.h ? ?23 Jun 2009 06:25:54 -0000 ? ? ?1.3 line 61

Quoted 3 lines
configs/a320.h ? ?23 Jun 2009 06:25:54 -0000 ? ? ?1.3 renamed from dev/null 1 Jan 1970 00:00:00 -0000 +2 -0
+
+#define CONFIG_SYS_FTPMU_BASE ? ? ? ?0x98100000 ? ? ?/* Power Management Unit */

is it board specific??

ok

Quoted 3 lines

configs/a320.h ? ?23 Jun 2009 06:25:54 -0000 ? ? ?1.3 line 63

Quoted 2 lines
configs/a320.h ? ?23 Jun 2009 06:25:54 -0000 ? ? ?1.3 renamed from dev/null 1 Jan 1970 00:00:00 -0000 +2 -0
+/* no environments */
+#define CONFIG_ENV_IS_NOWHERE

you do not plan to store the env in nor?

Yes, I do, but I will do this later after the current patches are accepted.

Best regards,
Po-Yu Chuang

#3 lore raw

PATCH 3/3 A320: Add support for Faraday A320 evaluation board

Hello Po-Yu,

Quoted 3 lines

2009/6/24 Jean-Christophe PLAGNIOL-VILLARD <[email protected]>:

Quoted 1 line

please use git

I cannot access git in the company, but I will try that at home.

Why is that? If it is because of the git port not getting through a company firewall, we do actually offer http:// access to our git repos - just check the "URL" section in gitweb[1].

Cheers
Detlev

[1] http://git.denx.de/?p=u-boot.git;a=summary

Signature · 7 lines
One of the main causes of the fall of the Roman Empire was that, lacking zero,
they had no way to indicate successful termination of their C programs.
                                        -- Robert Firth
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
#4 lore raw

PATCH 3/3 A320: Add support for Faraday A320 evaluation board

Dear Detlev Zundel,

2009/6/24 Detlev Zundel <[email protected]>:

Quoted 4 lines
Quoted 1 line

I cannot access git in the company, but I will try that at home.

Why is that? ?If it is because of the git port not getting through a company firewall, we do actually offer http:// access to our git repos - just check the "URL" section in gitweb[1].

I have tried on two machines.

desktop with vmware

# git clone http://git.denx.de/u-boot.git
Initialized empty Git repository in /home/ratbert/linux/u-boot/.git/
fatal: http://git.denx.de/u-boot.git/info/refs download error - Empty
reply from server

linux server

$ git clone http://git.denx.de/u-boot.git
Initialized empty Git repository in /opt/ratbert/linux/u-boot/.git/
fatal: http://git.denx.de/u-boot.git/info/refs download error -
couldn't connect to host

p.s. ping git.denx.de OK

best regards,
Po-Yu Chuang

#5 lore raw

PATCH 3/3 A320: Add support for Faraday A320 evaluation board

Hi Po-Yu Chuang,

Quoted 15 lines

Dear Detlev Zundel,

2009/6/24 Detlev Zundel <[email protected]>:

Quoted 4 lines
Quoted 1 line

I cannot access git in the company, but I will try that at home.

Why is that? ?If it is because of the git port not getting through a company firewall, we do actually offer http:// access to our git repos - just check the "URL" section in gitweb[1].

I have tried on two machines.

desktop with vmware

# git clone http://git.denx.de/u-boot.git
Initialized empty Git repository in /home/ratbert/linux/u-boot/.git/
fatal: http://git.denx.de/u-boot.git/info/refs download error - Empty
reply from server
Quoted 7 lines

linux server

$ git clone http://git.denx.de/u-boot.git
Initialized empty Git repository in /opt/ratbert/linux/u-boot/.git/
fatal: http://git.denx.de/u-boot.git/info/refs download error -
couldn't connect to host

p.s. ping git.denx.de OK

Hm. Do you have any kind of proxy in between? This works flawlessly for me:

[dzu at pollux tmp]$ git clone http://git.denx.de/u-boot.git
Initialized empty Git repository in /tmp/u-boot/.git/ got 3e88337b225bf796f6df21d0a7f591530e9d4ce0
walk 3e88337b225bf796f6df21d0a7f591530e9d4ce0
Getting alternates list for http://git.denx.de/u-boot.git
Getting pack list for http://git.denx.de/u-boot.git
Getting index for pack 9d6ff0d1b6334089f18fe2a25e4017a9a874cd77 Getting index for pack 3d2c42c65b4d7647eb78fc59504a61ffb3e36987 Getting index for pack dc08df4b9096a9aea978018a87cefd5719f92b96 Getting index for pack 005a71750c21a5b02b8b539e5305d956d39a3551 Getting index for pack c0db934da1ae1ce325e7c27380db2e790c9931b7 Getting index for pack ec2d949e0a06f5472a1e23446f9b46bb1852aa3f Getting index for pack 5a81f6c5331dfb5a851d8e1205c1baa269033eba Getting index for pack a7505bd52e3782f3dfbb10ac4f5b6c8b577c7739 Getting pack 9d6ff0d1b6334089f18fe2a25e4017a9a874cd77
which contains a6e0e74f933745c45d2b5ee83a0898d973acaf71
got d70da93b038dbee50cb3e84cc0db25aab424a772
got 6b1f78ae6ad037382ad430b07064105c88f7ac02
got 95bd78f93cfc903186e88fc58deac036c401cfbc
got 580611cb0932143fc2d7a735cfa9ce1ef34d6002
got 4f90a896f2c64cc05c3a1bc451a0aee6ebbadd61
got afac8b07172d7e4a65f86ce1ec4c783a6165ba1f
....

If you have a proxy, try this beforehand:

export http_proxy=http://<username>:<password>@<proxy_ip>:<proxy_port>

Cheers
Detlev

Signature · 6 lines
To you I'm an atheist; to God, I'm the Loyal Opposition.
                                        -- Woody Allen
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de
#6 lore raw

PATCH 3/3 A320: Add support for Faraday A320 evaluation board

Dear Detlev Zundel,

2009/6/25 Detlev Zundel <[email protected]>:

Quoted 3 lines

If you have a proxy, try this beforehand:

export http_proxy=http://<username>:<password>@<proxy_ip>:<proxy_port>

It works! That's terrific!
Thank you. :-D

regards,
Po-Yu Chuang