-pcidevice broken - fix or remove it?

Hi,

looks like the documented way to configure device assignment at qemu-kvm level is broken in 0.13 and git head:

  # qemu-system-x86_64 -pcidevice host=0:1a.0
  qemu-system-x86_64: Parameter 'id' expects an identifier
  Identifiers consist of letters, digits, '-', '.', '_', starting with a letter.
  pcidevice argument parse error; please check the help text for usage

"-device pci-assign" works, but only if specify "iommu=0" (otherwise: No IOMMU found. Unable to assign device "(null)").

Fix that legacy qemu-kvm switch or remove it at this chance? No one seems to have complained yet.

Jan

Quoted 16 lines · Jan Kiszka

Hi,

looks like the documented way to configure device assignment at qemu-kvm level is broken in 0.13 and git head:

  # qemu-system-x86_64 -pcidevice host=0:1a.0
  qemu-system-x86_64: Parameter 'id' expects an identifier
  Identifiers consist of letters, digits, '-', '.', '_', starting with a letter.
  pcidevice argument parse error; please check the help text for usage

"-device pci-assign" works, but only if specify "iommu=0" (otherwise: No IOMMU found. Unable to assign device "(null)").

Fix that legacy qemu-kvm switch or remove it at this chance? No one seems to have complained yet.

Quoted 1 line

Jan

Broken since June. Xudong Hao (cc'ed) reported it then[1], and Hidetoshi Seto (also cc'ed) attempted to get it patched [2,3].

Removing -pcidevice would be fine with me. For what it's worth, it's not in upstream qemu.

Quoted 18 lines · Markus Armbruster

Quoted 16 lines · Jan Kiszka

Hi,

looks like the documented way to configure device assignment at qemu-kvm level is broken in 0.13 and git head:

  # qemu-system-x86_64 -pcidevice host=0:1a.0
  qemu-system-x86_64: Parameter 'id' expects an identifier
  Identifiers consist of letters, digits, '-', '.', '_', starting with a letter.
  pcidevice argument parse error; please check the help text for usage

"-device pci-assign" works, but only if specify "iommu=0" (otherwise: No IOMMU found. Unable to assign device "(null)").

Fix that legacy qemu-kvm switch or remove it at this chance? No one seems to have complained yet.

Quoted 8 lines

Quoted 1 line

Jan

Broken since June. Xudong Hao (cc'ed) reported it then[1], and Hidetoshi Seto (also cc'ed) attempted to get it patched [2,3].

Removing -pcidevice would be fine with me. For what it's worth, it's not in upstream qemu.

Patch queued.

While at it, I wondered if we should kill "pci_add ... host" as well. But it looks like libvirt uses it - and should stumble over this breakage (it does not specify a device name). I can fix it by removing the silly auto-naming, or can libvirt live without it?