Skip to contentSkip to conversation

fix 'i' format handling in memory dump

PATCH In review Gleb Natapov 2 participants 2 messages Feb 21, 2010 – Feb 22, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix 'i' format handling in memory dump

It was broken by 09b9418c6d0. (!env && !is_physical) != (!is_physical) when env is true.

monitor.c +0 -2
index b1a6edc..19470d1 100644
@@ -1297,8 +1297,6 @@ static void memory_dump(Monitor *mon, int count, int format, int wsize,
         int flags;
         flags = 0;
         env = mon_get_cpu();
-        if (!is_physical)
-            return;
 #ifdef TARGET_I386
         if (wsize == 2) {
             flags = 1;

--
Gleb.

#1 lore raw
Quoted 9 lines · Gleb Natapov

It was broken by 09b9418c6d0. (!env && !is_physical) != (!is_physical) when env is true.

monitor.c +0 -0
index b1a6edc..19470d1 100644

monitor.c static void memory_dump(Monitor *mon, int count, int format, int wsize, · line 1302

Quoted 8 lines
monitor.c +0 -2
@@ -1297,8 +1297,6 @@ static void memory_dump(Monitor *mon, int count, int format, int wsize,
         int flags;
         flags = 0;
         env = mon_get_cpu();
-        if (!is_physical)
-            return;
 #ifdef TARGET_I386
         if (wsize == 2) {
             flags = 1;

*Ouch*

I checked the offending commit for more such errors, but couldn't find any.