gpio: twl4030: Remove error print for devm_add_action_or_reset()
PATCH v2 1/1 gpio: twl4030: Remove error print for devm_add_action_or_reset()
When devm_add_action_or_reset() fails, it is due to a failed memory allocation and will thus return -ENOMEM. dev_err_probe() doesn't do anything when error is -ENOMEM. Therefore, remove the useless call to dev_err_probe() when devm_add_action_or_reset() fails, and just return the value instead.
---
Changes in v2:
* Split the patch to one seperate patch for each sub-system.
Link to v1: https://lore.kernel.org/all/[email protected]/
drivers/gpio/gpio-twl4030.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpio/gpio-twl4030.c +1 -3
@@ -597,9 +597,7 @@ static int gpio_twl4030_probe(struct platform_device *pdev) ret =devm_add_action_or_reset (&pdev->dev, gpio_twl4030_power_off_action, d);if (ret) -return dev_err_probe (&pdev->dev, ret, -"failed to install power off handler\n" ); - +return ret; }return 0 ;
base-commit: 260f6f4fda93c8485c8037865c941b42b9cba5d2
Signature · 1 line
2.39.5
Bartosz Golaszewski
AppliedFrom: Bartosz Golaszewski <[email protected]>
Quoted 8 lines · Waqar Hameed
When
devm_add_action_or_reset()fails, it is due to a failed memory allocation and will thus return-ENOMEM.dev_err_probe()doesn't do anything when error is-ENOMEM. Therefore, remove the useless call todev_err_probe()whendevm_add_action_or_reset()fails, and just return the value instead.[...]
Applied, thanks!
[1/1] gpio: twl4030: Remove error print for devm_add_action_or_reset()
https://git.kernel.org/brgl/linux/c/0d1e68fb1efd2fe951d68cf05460e3672d4a846d
Best regards,
Signature · 1 line
Bartosz Golaszewski <[email protected]>