Skip to contentSkip to conversation

ASoC: Build files

PATCH In review Liam Girdwood 2 participants 6 messages Sep 15, 2006 – Sep 29, 2006 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/5 ASoC: Build files

This patch adds support for building the ASoC core and the dynamic audio power management support.

Kconfig +2 -0
Index: alsa-kernel/Kconfig
===================================================================
@@ -76,6 +76,8 @@ source "sound/sparc/Kconfig"
 
 source "sound/parisc/Kconfig"
 
+source "sound/soc/Kconfig"
+
 endmenu
 
 menu "Open Sound System"
Makefile +1 -1
Index: alsa-kernel/Makefile
===================================================================
@@ -4,7 +4,7 @@
 obj-$(CONFIG_SOUND) += soundcore.o
 obj-$(CONFIG_SOUND_PRIME) += oss/
 obj-$(CONFIG_DMASOUND) += oss/
-obj-$(CONFIG_SND) += core/ i2c/ drivers/ isa/ pci/ ppc/ arm/ synth/ usb/ sparc/ parisc/ pcmcia/ mips/
+obj-$(CONFIG_SND) += core/ i2c/ drivers/ isa/ pci/ ppc/ arm/ synth/ usb/ sparc/ parisc/ pcmcia/ mips/ soc/
 obj-$(CONFIG_SND_AOA) += aoa/
 
 ifeq ($(CONFIG_SND),y)
soc/Kconfig new file +18 -0
Index: alsa-kernel/soc/Kconfig
===================================================================
@@ -0,0 +1,18 @@
+#
+# SoC audio configuration
+#
+
+menu "SoC audio support"
+
+config SND_SOC
+	tristate "SoC audio support"
+	---help---
+
+	  If you want SoC support, you should say Y here and also to the
+	  specific driver for your SoC below. You will also need to select the
+	  specific codec(s) attached to the SoC
+
+	  This SoC audio support can also be built as a module.  If so, the module
+	  will be called snd-soc-core.
+
+endmenu
soc/Makefile new file +4 -0
Index: alsa-kernel/soc/Makefile
===================================================================
@@ -0,0 +1,4 @@
+snd-soc-core-objs := soc-core.o soc-dapm.o
+
+obj-$(CONFIG_SND_SOC)	+= snd-soc-core.o
+

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

_______________________________________________
Alsa-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/alsa-devel

#1 lore raw

At Fri, 15 Sep 2006 14:17:32 +0100,

Quoted 6 lines · Liam Girdwood

Index: alsa-kernel/soc/Kconfig
===================================================================

soc/Kconfig line 8

Quoted 8 lines
soc/Kconfig new file +8 -0
@@ -0,0 +1,18 @@
+#
+# SoC audio configuration
+#
+
+menu "SoC audio support"
+
+config SND_SOC
+	tristate "SoC audio support"

Don't you need dependencies?

Also, changes for Kconfig and Makefile are usually the last patch so that you don't break build. A minor issue, though...

Takashi

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

#2 lore raw
Quoted 19 lines · Takashi Iwai

At Fri, 15 Sep 2006 14:17:32 +0100,

Quoted 6 lines · Liam Girdwood

Index: alsa-kernel/soc/Kconfig
===================================================================

soc/Kconfig line 8

Quoted 8 lines
soc/Kconfig new file +8 -0
@@ -0,0 +1,18 @@
+#
+# SoC audio configuration
+#
+
+menu "SoC audio support"
+
+config SND_SOC
+	tristate "SoC audio support"

Don't you need dependencies?

I've set the deps (for each platform) in the child (asoc) Kconfig.

Liam

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

#3 lore raw

At Fri, 22 Sep 2006 17:56:11 +0100,

Quoted 22 lines · Liam Girdwood
Quoted 19 lines · Takashi Iwai

At Fri, 15 Sep 2006 14:17:32 +0100,

Quoted 6 lines · Liam Girdwood

Index: alsa-kernel/soc/Kconfig
===================================================================

soc/Kconfig line 8

Quoted 8 lines
soc/Kconfig new file +8 -0
@@ -0,0 +1,18 @@
+#
+# SoC audio configuration
+#
+
+menu "SoC audio support"
+
+config SND_SOC
+	tristate "SoC audio support"

Don't you need dependencies?

Quoted 1 line

I've set the deps (for each platform) in the child (asoc) Kconfig.

But soc/Kconfig is always evaluated even if CONFIG_SND=n. If SoC depends on ALSA core layer, it should have "depends on SND" or "select SND" at least. Otherwise you can get a build error.

BTW, any drivers using SoC are planned to be merged soon, too? It's always better to have a working driver together with the core stuff for pushing to upstream.

Takashi

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

#4 lore raw
Quoted 24 lines · Takashi Iwai

At Fri, 22 Sep 2006 17:56:11 +0100,

Quoted 22 lines · Liam Girdwood
Quoted 19 lines · Takashi Iwai

At Fri, 15 Sep 2006 14:17:32 +0100,

Quoted 6 lines · Liam Girdwood

Index: alsa-kernel/soc/Kconfig
===================================================================

soc/Kconfig line 8

Quoted 8 lines
soc/Kconfig new file +8 -0
@@ -0,0 +1,18 @@
+#
+# SoC audio configuration
+#
+
+menu "SoC audio support"
+
+config SND_SOC
+	tristate "SoC audio support"

Don't you need dependencies?

Quoted 7 lines
Quoted 1 line

I've set the deps (for each platform) in the child (asoc) Kconfig.

But soc/Kconfig is always evaluated even if CONFIG_SND=n. If SoC depends on ALSA core layer, it should have "depends on SND" or "select SND" at least. Otherwise you can get a build error.

Fixed.

Quoted 5 lines

BTW, any drivers using SoC are planned to be merged soon, too? It's always better to have a working driver together with the core stuff for pushing to upstream.

Np, I was waiting until after 1.0.13 final was released. It's late today, so I'll submit on Monday.

Liam

Kconfig +2 -0
Index: alsa-kernel/Kconfig
===================================================================
@@ -76,6 +76,8 @@ source "sound/sparc/Kconfig"
 
 source "sound/parisc/Kconfig"
 
+source "sound/soc/Kconfig"
+
 endmenu
 
 menu "Open Sound System"
Makefile +1 -1
Index: alsa-kernel/Makefile
===================================================================
@@ -4,7 +4,7 @@
 obj-$(CONFIG_SOUND) += soundcore.o
 obj-$(CONFIG_SOUND_PRIME) += oss/
 obj-$(CONFIG_DMASOUND) += oss/
-obj-$(CONFIG_SND) += core/ i2c/ drivers/ isa/ pci/ ppc/ arm/ synth/ usb/ sparc/ parisc/ pcmcia/ mips/
+obj-$(CONFIG_SND) += core/ i2c/ drivers/ isa/ pci/ ppc/ arm/ synth/ usb/ sparc/ parisc/ pcmcia/ mips/ soc/
 obj-$(CONFIG_SND_AOA) += aoa/
 
 ifeq ($(CONFIG_SND),y)
soc/Kconfig new file +19 -0
Index: alsa-kernel/soc/Kconfig
===================================================================
@@ -0,0 +1,19 @@
+#
+# SoC audio configuration
+#
+
+menu "SoC audio support"
+	depends on SND!=n
+
+config SND_SOC
+	tristate "SoC audio support"
+	---help---
+
+	  If you want SoC support, you should say Y here and also to the
+	  specific driver for your SoC below. You will also need to select the
+	  specific codec(s) attached to the SoC
+
+	  This SoC audio support can also be built as a module.  If so, the module
+	  will be called snd-soc-core.
+
+endmenu
soc/Makefile new file +4 -0
Index: alsa-kernel/soc/Makefile
===================================================================
@@ -0,0 +1,4 @@
+snd-soc-core-objs := soc-core.o soc-dapm.o
+
+obj-$(CONFIG_SND_SOC)	+= snd-soc-core.o
+

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

_______________________________________________
Alsa-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/alsa-devel

#5 lore raw

At Fri, 29 Sep 2006 14:56:07 +0100,

Quoted 36 lines · Liam Girdwood
Quoted 24 lines · Takashi Iwai

At Fri, 22 Sep 2006 17:56:11 +0100,

Quoted 22 lines · Liam Girdwood
Quoted 19 lines · Takashi Iwai

At Fri, 15 Sep 2006 14:17:32 +0100,

Quoted 6 lines · Liam Girdwood

Index: alsa-kernel/soc/Kconfig
===================================================================

soc/Kconfig line 8

Quoted 8 lines
soc/Kconfig new file +8 -0
@@ -0,0 +1,18 @@
+#
+# SoC audio configuration
+#
+
+menu "SoC audio support"
+
+config SND_SOC
+	tristate "SoC audio support"

Don't you need dependencies?

Quoted 7 lines
Quoted 1 line

I've set the deps (for each platform) in the child (asoc) Kconfig.

But soc/Kconfig is always evaluated even if CONFIG_SND=n. If SoC depends on ALSA core layer, it should have "depends on SND" or "select SND" at least. Otherwise you can get a build error.

Fixed.

Quoted 8 lines
Quoted 5 lines

BTW, any drivers using SoC are planned to be merged soon, too? It's always better to have a working driver together with the core stuff for pushing to upstream.

Np, I was waiting until after 1.0.13 final was released. It's late today, so I'll submit on Monday.

1.0.13 final will be released really soon, so it's fine to submit on Monday.

Thanks,

Takashi

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV