Skip to contentSkip to conversation

Huawei laptops

PATCH Superseded Ayman Bagabas 3 participants 10 messages Nov 27, 2018 – Nov 28, 2018

Subsystems (2)

v7 of 11 Superseded Latest is v11 →

lore
Share & tools
lore
#0 lore raw

v7 cover Huawei laptops

This patch set is based on new audio LED triggers in branch topic/leds-trigger from
git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git

Changes from v6:
* Use audio LED triggers patch set
* Use KEY_CONFIG (XF86Tools) instead of KEY_PROG1.
In Windows, the key is used to launch Huawei PC manager. XF86Tools is used by default on most desktop environments i.e. Gnome.

Ayman Bagabas (3):
ALSA: hda: fix front speakers on Huawei MBXP.
x86: add support for Huawei WMI hotkeys.
ALSA: hda: add support for Huawei WMI micmute LED

 drivers/platform/x86/Kconfig      |  15 ++
 drivers/platform/x86/Makefile     |   1 +
 drivers/platform/x86/huawei-wmi.c | 247 ++++++++++++++++++++++++++++++
 sound/pci/hda/patch_realtek.c     |  22 +++
 4 files changed, 285 insertions(+)
 create mode 100644 drivers/platform/x86/huawei-wmi.c
Signature · 1 line
2.19.1
#1 lore raw

PATCH v7 1/3 ALSA: hda: fix front speakers on Huawei MBXP.

This patch solves bug 200501 'Only 2 of 4 speakers playing sound.'
https://bugzilla.kernel.org/show_bug.cgi?id=200501
It enables the front speakers on Huawei Matebook X Pro laptops. These laptops come with Dolby Atmos sound system and these pins configuration enables the front speakers.

---
 sound/pci/hda/patch_realtek.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
sound/pci/hda/patch_realtek.c +18 -0
index 993d34c141c2..1326f32f4574 100644
@@ -5490,6 +5490,7 @@ enum {
 	ALC298_FIXUP_TPT470_DOCK,
 	ALC255_FIXUP_DUMMY_LINEOUT_VERB,
 	ALC255_FIXUP_DELL_HEADSET_MIC,
+	ALC256_FIXUP_HUAWEI_MBXP_PINS,
 	ALC295_FIXUP_HP_X360,
 	ALC221_FIXUP_HP_HEADSET_MIC,
 };
@@ -5761,6 +5762,22 @@ static const struct hda_fixup alc269_fixups[] = {
 		.chained = true,
 		.chain_id = ALC269_FIXUP_HEADSET_MIC
 	},
+	[ALC256_FIXUP_HUAWEI_MBXP_PINS] = {
+		.type = HDA_FIXUP_PINS,
+		.v.pins = (const struct hda_pintbl[]) {
+			{0x12, 0x90a60130},
+			{0x13, 0x40000000},
+			{0x14, 0x90170110},
+			{0x18, 0x411111f0},
+			{0x19, 0x04a11040},
+			{0x1a, 0x411111f0},
+			{0x1b, 0x90170112},
+			{0x1d, 0x40759a05},
+			{0x1e, 0x411111f0},
+			{0x21, 0x04211020},
+			{ }
+		}
+	},
 	[ALC269_FIXUP_ASUS_X101_FUNC] = {
 		.type = HDA_FIXUP_FUNC,
 		.v.func = alc269_fixup_x101_headset_mic,
@@ -6591,6 +6608,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x17aa, 0x511f, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
 	SND_PCI_QUIRK(0x17aa, 0x3bf8, "Quanta FL1", ALC269_FIXUP_PCM_44K),
 	SND_PCI_QUIRK(0x17aa, 0x9e54, "LENOVO NB", ALC269_FIXUP_LENOVO_EAPD),
+	SND_PCI_QUIRK(0x19e5, 0x3204, "Huawei MBXP", ALC256_FIXUP_HUAWEI_MBXP_PINS),
 	SND_PCI_QUIRK(0x1b7d, 0xa831, "Ordissimo EVE2 ", ALC269VB_FIXUP_ORDISSIMO_EVE2), /* Also known as Malata PC-B1303 */
 
 #if 0
Signature · 1 line
2.19.1
#2 lore raw

PATCH v7 2/3 x86: add support for Huawei WMI hotkeys.

In reply to Ayman Bagabas

This driver adds support for missing hotkeys on some Huawei laptops. Currently, only Huawei Matebook X and Matebook X Pro is supported.

---
 drivers/platform/x86/Kconfig      |  15 ++
 drivers/platform/x86/Makefile     |   1 +
 drivers/platform/x86/huawei-wmi.c | 247 ++++++++++++++++++++++++++++++
 3 files changed, 263 insertions(+)
 create mode 100644 drivers/platform/x86/huawei-wmi.c
drivers/platform/x86/Kconfig +15 -0
index 87f70e8f4dd0..0f9db4275fb4 100644
@@ -1292,6 +1292,21 @@ config INTEL_ATOMISP2_PM
 	  To compile this driver as a module, choose M here: the module
 	  will be called intel_atomisp2_pm.
 
+config HUAWEI_WMI
+	tristate "Huawei WMI hotkeys driver"
+	depends on ACPI_WMI
+	depends on INPUT
+	select INPUT_SPARSEKMAP
+	select LEDS_TRIGGERS
+	select LEDS_TRIGGER_AUDIO
+	help
+	  This driver provides support for Huawei WMI hotkeys.
+	  It enables the missing keys and adds support to the micmute
+	  LED found on some of these laptops.
+
+	  To compile this driver as a module, choose M here: the module
+	  will be called huawei-wmi.
+
 endif # X86_PLATFORM_DEVICES
 
 config PMC_ATOM
drivers/platform/x86/Makefile +1 -0
index 39ae94135406..d841c550e3cc 100644
@@ -32,6 +32,7 @@ obj-$(CONFIG_ACERHDF)		+= acerhdf.o
 obj-$(CONFIG_HP_ACCEL)		+= hp_accel.o
 obj-$(CONFIG_HP_WIRELESS)	+= hp-wireless.o
 obj-$(CONFIG_HP_WMI)		+= hp-wmi.o
+obj-$(CONFIG_HUAWEI_WMI)		+= huawei-wmi.o
 obj-$(CONFIG_AMILO_RFKILL)	+= amilo-rfkill.o
 obj-$(CONFIG_GPD_POCKET_FAN)	+= gpd-pocket-fan.o
 obj-$(CONFIG_TC1100_WMI)	+= tc1100-wmi.o
drivers/platform/x86/huawei-wmi.c new file +247 -0

247 lines not on this page · raw message

Signature · 1 line
2.19.1
#3 lore raw

Re: [PATCH v7 2/3] x86: add support for Huawei WMI hotkeys.

Quoted 6 lines · Ayman Bagabas
drivers/platform/x86/huawei-wmi.c new file +5 -0
+static const struct key_entry huawei_wmi_keymap[] __initconst = {
+		{ KE_KEY,    0x281, { KEY_BRIGHTNESSDOWN } },
+		{ KE_KEY,    0x282, { KEY_BRIGHTNESSUP } },
+		{ KE_KEY,    0x284, { KEY_MUTE } },
+		{ KE_KEY,    0x285, { KEY_VOLUMEDOWN } },

drivers/platform/x86/huawei-wmi.c line 41

Quoted 10 lines
drivers/platform/x86/huawei-wmi.c new file +10 -0
+		{ KE_KEY,    0x286, { KEY_VOLUMEUP } },
+		{ KE_KEY,    0x287, { KEY_MICMUTE } },
+		{ KE_KEY,    0x289, { KEY_WLAN } },
+		// Huawei |M| button
+		{ KE_KEY,    0x28a, { KEY_CONFIG } },
+		// Keyboard light
+		{ KE_IGNORE, 0x293, { KEY_KBDILLUMTOGGLE } },
+		{ KE_IGNORE, 0x294, { KEY_KBDILLUMUP } },
+		{ KE_IGNORE, 0x295, { KEY_KBDILLUMUP } },
+		{ KE_END,    0 }

The indentation looks too deep here.

drivers/platform/x86/huawei-wmi.c line 57

Quoted 11 lines
drivers/platform/x86/huawei-wmi.c new file +11 -0
+static int huawei_wmi_micmute_led_set(bool on)
+{
+	acpi_handle handle;
+	char *method;
+	union acpi_object args[3];
+	struct acpi_object_list arg_list = {
+		.pointer = args,
+		.count = ARRAY_SIZE(args),
+	};
+
+	handle = ACPI_HANDLE(&inputdev->dev);

Just wondering whether the ACPI handle is assigned properly for this device...

Quoted 17 lines
drivers/platform/x86/huawei-wmi.c new file +17 -0
+	args[0].type = args[1].type = args[2].type = ACPI_TYPE_INTEGER;
+	args[1].integer.value = 0x04;
+
+	if (acpi_has_method(handle, method = "\\_SB.PCI0.LPCB.EC0.SPIN")) {
+		args[0].integer.value = 0;
+		args[2].integer.value = on ? 1 : 0;
+	} else if (acpi_has_method(handle, method = "\\_SB.PCI0.LPCB.EC0.WPIN")) {
+		args[0].integer.value = 1;
+		args[2].integer.value = on ? 0 : 1;
+	} else {
+		dev_err(&inputdev->dev, "Unable to find ACPI method\n");
+		return -ENOSYS;
+	}
+
+	acpi_evaluate_object(handle, method, &arg_list, NULL);
+
+	return 0;

drivers/platform/x86/huawei-wmi.c line 84

Quoted 10 lines
drivers/platform/x86/huawei-wmi.c new file +10 -0
+}
+
+static int micmute_led_set(struct led_classdev *led_cdev,
+		enum led_brightness brightness)
+{
+	int state = brightness != LED_OFF;
+	int err;
+
+	err = huawei_wmi_micmute_led_set(state);
+	return err < 0 ? err : 0;

No need for checking err here, you can return
huawei_wmi_mute_led_set() directly.

Or even you can fold two functions into one.

Quoted 13 lines
drivers/platform/x86/huawei-wmi.c new file +13 -0
+static int __init huawei_wmi_init(void)
+{
+	int err;
+
+	if (wmi_has_guid(MBX_EVENT_GUID)) {
+		event_guid = MBX_EVENT_GUID;
+	} else if (wmi_has_guid(MBXP_EVENT_GUID)) {
+		event_guid = MBXP_EVENT_GUID;
+	} else {
+		pr_warn("Compatible WMI GUID not found\n");
+		return -ENODEV;
+	}
+

drivers/platform/x86/huawei-wmi.c line 232

Quoted 10 lines
drivers/platform/x86/huawei-wmi.c new file +10 -0
+	err = huawei_wmi_input_init();
+	if (err)
+		goto err_input;
+
+	micmute_led_cdev.brightness = ledtrig_audio_get(LED_AUDIO_MICMUTE);
+	err = led_classdev_register(&inputdev->dev, &micmute_led_cdev);
+	if (err)
+		goto err_leds;
+
+	return 0;

Might it be cleaner to implement on top of wmi_driver? Then you can create both input and led devices on wmi device.

thanks,

Takashi

#4 lore raw

Re: [PATCH v7 2/3] x86: add support for Huawei WMI hotkeys.

Quoted 20 lines · Takashi Iwai
Quoted 5 lines · Ayman Bagabas
drivers/platform/x86/huawei-wmi.c new file +5 -0
+static const struct key_entry huawei_wmi_keymap[] __initconst = {
+		{ KE_KEY,    0x281, { KEY_BRIGHTNESSDOWN } },
+		{ KE_KEY,    0x282, { KEY_BRIGHTNESSUP } },
+		{ KE_KEY,    0x284, { KEY_MUTE } },
+		{ KE_KEY,    0x285, { KEY_VOLUMEDOWN } },

drivers/platform/x86/huawei-wmi.c line 41

Quoted 10 lines
drivers/platform/x86/huawei-wmi.c new file +10 -0
+		{ KE_KEY,    0x286, { KEY_VOLUMEUP } },
+		{ KE_KEY,    0x287, { KEY_MICMUTE } },
+		{ KE_KEY,    0x289, { KEY_WLAN } },
+		// Huawei |M| button
+		{ KE_KEY,    0x28a, { KEY_CONFIG } },
+		// Keyboard light
+		{ KE_IGNORE, 0x293, { KEY_KBDILLUMTOGGLE } },
+		{ KE_IGNORE, 0x294, { KEY_KBDILLUMUP } },
+		{ KE_IGNORE, 0x295, { KEY_KBDILLUMUP } },
+		{ KE_END,    0 }

The indentation looks too deep here.

Quoted 14 lines

drivers/platform/x86/huawei-wmi.c line 57

Quoted 11 lines
drivers/platform/x86/huawei-wmi.c new file +11 -0
+static int huawei_wmi_micmute_led_set(bool on)
+{
+	acpi_handle handle;
+	char *method;
+	union acpi_object args[3];
+	struct acpi_object_list arg_list = {
+		.pointer = args,
+		.count = ARRAY_SIZE(args),
+	};
+
+	handle = ACPI_HANDLE(&inputdev->dev);

Just wondering whether the ACPI handle is assigned properly for this device...

It is, but it returns a handle at "\".

Quoted 35 lines
Quoted 21 lines
drivers/platform/x86/huawei-wmi.c new file +4 -0
+	args[0].type = args[1].type = args[2].type = ACPI_TYPE_INTEGER;
+	args[1].integer.value = 0x04;
+
+	if (acpi_has_method(handle, method =

"\\_SB.PCI0.LPCB.EC0.SPIN")) {

drivers/platform/x86/huawei-wmi.c new file +3 -0
+		args[0].integer.value = 0;
+		args[2].integer.value = on ? 1 : 0;
+	} else if (acpi_has_method(handle, method =

"\\_SB.PCI0.LPCB.EC0.WPIN")) {

drivers/platform/x86/huawei-wmi.c new file +4 -0
+		args[0].integer.value = 1;
+		args[2].integer.value = on ? 0 : 1;
+	} else {
+		dev_err(&inputdev->dev, "Unable to find ACPI

method\n");

drivers/platform/x86/huawei-wmi.c new file +6 -0
+		return -ENOSYS;
+	}
+
+	acpi_evaluate_object(handle, method, &arg_list, NULL);
+
+	return 0;

drivers/platform/x86/huawei-wmi.c line 84

Quoted 10 lines
drivers/platform/x86/huawei-wmi.c new file +10 -0
+}
+
+static int micmute_led_set(struct led_classdev *led_cdev,
+		enum led_brightness brightness)
+{
+	int state = brightness != LED_OFF;
+	int err;
+
+	err = huawei_wmi_micmute_led_set(state);
+	return err < 0 ? err : 0;

No need for checking err here, you can return
huawei_wmi_mute_led_set() directly.

Quoted 1 line

Or even you can fold two functions into one.

I think folding them make more sense.

Quoted 20 lines
Quoted 20 lines
drivers/platform/x86/huawei-wmi.c new file +18 -0
+static int __init huawei_wmi_init(void)
+{
+	int err;
+
+	if (wmi_has_guid(MBX_EVENT_GUID)) {
+		event_guid = MBX_EVENT_GUID;
+	} else if (wmi_has_guid(MBXP_EVENT_GUID)) {
+		event_guid = MBXP_EVENT_GUID;
+	} else {
+		pr_warn("Compatible WMI GUID not found\n");
+		return -ENODEV;
+	}
+
+	err = huawei_wmi_input_init();
+	if (err)
+		goto err_input;
+
+	micmute_led_cdev.brightness =

ledtrig_audio_get(LED_AUDIO_MICMUTE);

Quoted 9 lines

drivers/platform/x86/huawei-wmi.c line 232

Quoted 5 lines
drivers/platform/x86/huawei-wmi.c new file +5 -0
+	err = led_classdev_register(&inputdev->dev, &micmute_led_cdev);
+	if (err)
+		goto err_leds;
+
+	return 0;

Might it be cleaner to implement on top of wmi_driver? Then you can create both input and led devices on wmi device.

Done! Now led devices get registered when wmi probes a new device. Thanks.

Quoted 4 lines

thanks,

Takashi

#5 lore raw

Re: [PATCH v7 2/3] x86: add support for Huawei WMI hotkeys.

In reply to Ayman Bagabas

Some more forgotten bits...

Quoted 2 lines · Ayman Bagabas
drivers/platform/x86/Kconfig +0 -0

....

drivers/platform/x86/Kconfig config INTEL_ATOMISP2_PM · line 1301

Quoted 7 lines
drivers/platform/x86/Kconfig +7 -0
+config HUAWEI_WMI
+	tristate "Huawei WMI hotkeys driver"
+	depends on ACPI_WMI
+	depends on INPUT
+	select INPUT_SPARSEKMAP
+	select LEDS_TRIGGERS
+	select LEDS_TRIGGER_AUDIO

I guess "select LEDS_CLASS" is needed as well.
Other drivers had already it.

Quoted 2 lines
drivers/platform/x86/huawei-wmi.c new file +0 -0

....

Quoted 5 lines
drivers/platform/x86/huawei-wmi.c new file +5 -0
+static int huawei_wmi_micmute_led_set(bool on)
+{
+	acpi_handle handle;
+	char *method;
+	union acpi_object args[3];

drivers/platform/x86/huawei-wmi.c line 61

Quoted 10 lines
drivers/platform/x86/huawei-wmi.c new file +10 -0
+	struct acpi_object_list arg_list = {
+		.pointer = args,
+		.count = ARRAY_SIZE(args),
+	};
+
+	handle = ACPI_HANDLE(&inputdev->dev);
+	args[0].type = args[1].type = args[2].type = ACPI_TYPE_INTEGER;
+	args[1].integer.value = 0x04;
+
+	if (acpi_has_method(handle, method = "\\_SB.PCI0.LPCB.EC0.SPIN")) {

This looks ugly... And checkpatch also complains.

drivers/platform/x86/huawei-wmi.c line 70

Quoted 9 lines
drivers/platform/x86/huawei-wmi.c new file +9 -0
+		args[0].integer.value = 0;
+		args[2].integer.value = on ? 1 : 0;
+	} else if (acpi_has_method(handle, method = "\\_SB.PCI0.LPCB.EC0.WPIN")) {
+		args[0].integer.value = 1;
+		args[2].integer.value = on ? 0 : 1;
+	} else {
+		dev_err(&inputdev->dev, "Unable to find ACPI method\n");
+		return -ENOSYS;
+	}

Can these checks be done at initialization phase? It doesn't seem needed to be executed at each call.

thanks,

Takashi

#6 lore raw

Re: [PATCH v7 2/3] x86: add support for Huawei WMI hotkeys.

Quoted 10 lines · Takashi Iwai

drivers/platform/x86/huawei-wmi.c line 61

Quoted 5 lines · Ayman Bagabas
drivers/platform/x86/huawei-wmi.c new file +5 -0
+     handle = ACPI_HANDLE(&inputdev->dev);
+     args[0].type = args[1].type = args[2].type = ACPI_TYPE_INTEGER;
+     args[1].integer.value = 0x04;
+
+     if (acpi_has_method(handle, method = "\\_SB.PCI0.LPCB.EC0.SPIN")) {

This looks ugly... And checkpatch also complains.

Good point.
Actually another question is what handle do we get here? Can we check method name by relative path, i.e. "SPIN" / "WPIN" instead?

Quoted 10 lines

drivers/platform/x86/huawei-wmi.c line 70

Quoted 9 lines
drivers/platform/x86/huawei-wmi.c new file +9 -0
+             args[0].integer.value = 0;
+             args[2].integer.value = on ? 1 : 0;
+     } else if (acpi_has_method(handle, method = "\\_SB.PCI0.LPCB.EC0.WPIN")) {
+             args[0].integer.value = 1;
+             args[2].integer.value = on ? 0 : 1;
+     } else {
+             dev_err(&inputdev->dev, "Unable to find ACPI method\n");
+             return -ENOSYS;
+     }
Quoted 2 lines

Can these checks be done at initialization phase? It doesn't seem needed to be executed at each call.

Agree.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#7 lore raw

Re: [PATCH v7 2/3] x86: add support for Huawei WMI hotkeys.

Quoted 11 lines · Andy Shevchenko
Quoted 10 lines · Takashi Iwai
Quoted 7 lines · Ayman Bagabas
(quoted diff) +2 -0
+     handle = ACPI_HANDLE(&inputdev->dev);
+     args[0].type = args[1].type = args[2].type =

ACPI_TYPE_INTEGER;

drivers/platform/x86/huawei-wmi.c new file +3 -0
+     args[1].integer.value = 0x04;
+
+     if (acpi_has_method(handle, method =

"\\_SB.PCI0.LPCB.EC0.SPIN")) {

Quoted 5 lines
Quoted 1 line

This looks ugly... And checkpatch also complains.

Good point.
Actually another question is what handle do we get here? Can we check method name by relative path, i.e. "SPIN" / "WPIN" instead?

The handle is a NULL handle at "\". Should I use acpi_get_handle(NULL, "\\_SB.PCI0.LPCB.EC0", &handle)? EC0 is a acpi device HID:PNP0C09.

Quoted 13 lines
Quoted 13 lines
Quoted 12 lines
drivers/platform/x86/huawei-wmi.c new file +3 -0
+             args[0].integer.value = 0;
+             args[2].integer.value = on ? 1 : 0;
+     } else if (acpi_has_method(handle, method =

"\\_SB.PCI0.LPCB.EC0.WPIN")) {

drivers/platform/x86/huawei-wmi.c new file +4 -0
+             args[0].integer.value = 1;
+             args[2].integer.value = on ? 0 : 1;
+     } else {
+             dev_err(&inputdev->dev, "Unable to find ACPI

method\n");

(quoted diff) +2 -0
+             return -ENOSYS;
+     }
Quoted 5 lines
Quoted 2 lines

Can these checks be done at initialization phase? It doesn't seem needed to be executed at each call.

Agree.

Even if it was done in init phase, we still need to check what acpi method should be used and based on that and micmute status we set the arguments args[0] and args[2], args[1] is the pin value. We could check these using event_guid, but that would assume the methods exist for each guid.
For example, if event_guid == MBX_EVENT_GUID, then method SPIN should be used.

#8 lore raw

Re: [PATCH v7 2/3] x86: add support for Huawei WMI hotkeys.

Quoted 13 lines · On Wed, 28 Nov 2018 01:49:48 +0100, [email protected] wrote:
Quoted 11 lines · Andy Shevchenko
Quoted 10 lines · Takashi Iwai
Quoted 7 lines · Ayman Bagabas
(quoted diff) +2 -0
+     handle = ACPI_HANDLE(&inputdev->dev);
+     args[0].type = args[1].type = args[2].type =

ACPI_TYPE_INTEGER;

drivers/platform/x86/huawei-wmi.c new file +3 -0
+     args[1].integer.value = 0x04;
+
+     if (acpi_has_method(handle, method =

"\\_SB.PCI0.LPCB.EC0.SPIN")) {

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

This looks ugly... And checkpatch also complains.

Good point.
Actually another question is what handle do we get here? Can we check method name by relative path, i.e. "SPIN" / "WPIN" instead?

The handle is a NULL handle at "\". Should I use acpi_get_handle(NULL, "\\_SB.PCI0.LPCB.EC0", &handle)? EC0 is a acpi device HID:PNP0C09.

Then passing NULL explicitly avoid confusion, IMO.

Quoted 18 lines
Quoted 12 lines
Quoted 12 lines
Quoted 11 lines
drivers/platform/x86/huawei-wmi.c new file +3 -0
+             args[0].integer.value = 0;
+             args[2].integer.value = on ? 1 : 0;
+     } else if (acpi_has_method(handle, method =

"\\_SB.PCI0.LPCB.EC0.WPIN")) {

drivers/platform/x86/huawei-wmi.c new file +4 -0
+             args[0].integer.value = 1;
+             args[2].integer.value = on ? 0 : 1;
+     } else {
+             dev_err(&inputdev->dev, "Unable to find ACPI

method\n");

(quoted diff) +2 -0
+             return -ENOSYS;
+     }
Quoted 5 lines
Quoted 2 lines

Can these checks be done at initialization phase? It doesn't seem needed to be executed at each call.

Agree.

Quoted 7 lines

Even if it was done in init phase, we still need to check what acpi method should be used and based on that and micmute status we set the arguments args[0] and args[2], args[1] is the pin value. We could check these using event_guid, but that would assume the methods exist for each guid.
For example, if event_guid == MBX_EVENT_GUID, then method SPIN should be used.

Hmm, I can't read it from your patch... Where is event_guid checked in huawei_wmi_mucmute_led_set()? I thought it checks only acpi_has_method().

thanks,

Takashi

#9 lore raw

PATCH v7 3/3 ALSA: hda: add support for Huawei WMI micmute LED

In reply to Ayman Bagabas

Some of Huawei laptops come with a LED in the micmute key. This patch enables the use of micmute LED for these devices:
1. Matebook X (19e5:3200), (19e5:3201)
2. Matebook X Pro (19e5:3204)

---
 sound/pci/hda/patch_realtek.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
sound/pci/hda/patch_realtek.c +5 -1
index 1326f32f4574..9766fd249bdf 100644
@@ -5776,7 +5776,9 @@ static const struct hda_fixup alc269_fixups[] = {
 			{0x1e, 0x411111f0},
 			{0x21, 0x04211020},
 			{ }
-		}
+		},
+		.chained = true,
+		.chain_id = ALC255_FIXUP_MIC_MUTE_LED
 	},
 	[ALC269_FIXUP_ASUS_X101_FUNC] = {
 		.type = HDA_FIXUP_FUNC,
@@ -6608,6 +6610,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x17aa, 0x511f, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
 	SND_PCI_QUIRK(0x17aa, 0x3bf8, "Quanta FL1", ALC269_FIXUP_PCM_44K),
 	SND_PCI_QUIRK(0x17aa, 0x9e54, "LENOVO NB", ALC269_FIXUP_LENOVO_EAPD),
+	SND_PCI_QUIRK(0x19e5, 0x3200, "Huawei MBX", ALC255_FIXUP_MIC_MUTE_LED),
+	SND_PCI_QUIRK(0x19e5, 0x3201, "Huawei MBX", ALC255_FIXUP_MIC_MUTE_LED),
 	SND_PCI_QUIRK(0x19e5, 0x3204, "Huawei MBXP", ALC256_FIXUP_HUAWEI_MBXP_PINS),
 	SND_PCI_QUIRK(0x1b7d, 0xa831, "Ordissimo EVE2 ", ALC269VB_FIXUP_ORDISSIMO_EVE2), /* Also known as Malata PC-B1303 */
 
Signature · 1 line
2.19.1