Skip to contentSkip to conversation

Possible problem with cmipci driver

DISCUSSION Takashi Iwai 1 participant 1 message Nov 11, 2012 1 message not in the archive Sound

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

At Sat, 10 Nov 2012 11:20:06 -0700,

Quoted 8 lines · Jake Edge

Hi Takashi, Jaroslav, and other sound developers,

Maybe I am way off base, but I think there may be a bug relatively recently introduced into the cmipci driver. I note that Takashi has made some changes in July (commit:
68cb2b559278858ef9f3a7722f95df88797c7840 ) that might (?) be relevant.

If the above commit is the culprit, does the patch below help?

Takashi

---

sound/pci/cmipci.c +1 -1
index 22122ff..ae41982 100644
@@ -3368,7 +3368,7 @@ static int snd_cmipci_suspend(struct device *dev)
 
 	pci_disable_device(pci);
 	pci_save_state(pci);
-	pci_set_power_state(pci, PCI_D3hot);
+	pci_set_power_state(pci, pci_choose_state(pci, PMSG_SUSPEND));
 	return 0;
 }