ALSA: hda - fix whitespaces
PATCH 1/1 ALSA: hda - fix whitespaces
Some trailing whitespaces seems to have crept in the hda_intel.c, so fix them up
--- sound/pci/hda/hda_intel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
sound/pci/hda/hda_intel.c +2 -2
@@ -383,8 +383,8 @@ static char *driver_short_names[] = { [AZX_DRIVER_SIS] = "HDA SIS966", [AZX_DRIVER_ULI] = "HDA ULI M5461", [AZX_DRIVER_NVIDIA] = "HDA NVidia", - [AZX_DRIVER_TERA] = "HDA Teradici", - [AZX_DRIVER_CTX] = "HDA Creative", + [AZX_DRIVER_TERA] = "HDA Teradici", + [AZX_DRIVER_CTX] = "HDA Creative", [AZX_DRIVER_CTHDA] = "HDA Creative", [AZX_DRIVER_CMEDIA] = "HDA C-Media", [AZX_DRIVER_GENERIC] = "HD-Audio Generic",
Signature · 1 line
1.9.1
Quoted 5 lines · Vinod Koul
Some trailing whitespaces seems to have crept in the
hda_intel.c, so fix them upSigned-off-by Vinod Koul <[email protected]>
Well, this kind of "fix" doesn't improve readability but often makes stable backporting harder. So I'd like to skip it.
This, of course, depends on the state of the code: for the code that is being actively rewritten, it's good to have such fixes. OTOH, for the longly maintained code, it's not clear whether to apply or not.
thanks,
Takashi
Quoted 22 lines
--- sound/pci/hda/hda_intel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)sound/pci/hda/hda_intel.c +2
-2@@ -383,8 +383,8 @@ static char *driver_short_names[] = { [AZX_DRIVER_SIS] = "HDA SIS966", [AZX_DRIVER_ULI] = "HDA ULI M5461", [AZX_DRIVER_NVIDIA] = "HDA NVidia", - [AZX_DRIVER_TERA] = "HDA Teradici", - [AZX_DRIVER_CTX] = "HDA Creative", + [AZX_DRIVER_TERA] = "HDA Teradici", + [AZX_DRIVER_CTX] = "HDA Creative", [AZX_DRIVER_CTHDA] = "HDA Creative", [AZX_DRIVER_CMEDIA] = "HDA C-Media", [AZX_DRIVER_GENERIC] = "HD-Audio Generic",Signature · 1 line
1.9.1
Quoted 6 lines · Takashi Iwai
Quoted 4 lines · Vinod Koul
Some trailing whitespaces seems to have crept in the
hda_intel.c, so fix them up
Quoted 8 lines
Quoted 1 line
Signed-off-by Vinod Koul <[email protected]>Well, this kind of "fix" doesn't improve readability but often makes stable backporting harder. So I'd like to skip it.
This, of course, depends on the state of the code: for the code that is being actively rewritten, it's good to have such fixes. OTOH, for the longly maintained code, it's not clear whether to apply or not.
Okay I dont mind. I noticed these spaces while doing the Kabylake patch, so thought to send :)
Signature · 1 line
~Vinod