Dereference after free in snd_hwdep_release()
PATCH 1/1 Dereference after free in snd_hwdep_release()
snd_card_file_remove() may free hw->card so we can't dereference hw->card->module after that.
Coverity ID 1420.
Signed-off-by Florin Malita <[email protected]>
---
sound/core/hwdep.c +2 -1
@@ -158,6 +158,7 @@ static int snd_hwdep_release(struct inod {int err = -ENXIO ;struct snd_hwdep *hw = file->private_data; +struct module *mod = hw->card->module;mutex_lock (&hw->open_mutex);if (hw->ops.release) { err = hw->ops.release (hw, file);
@@ -167,7 +168,7 @@ static int snd_hwdep_release(struct inod hw->used--;snd_card_file_remove (hw->card, file);mutex_unlock (&hw->open_mutex); -module_put (hw->card->module); +module_put (mod);return err; }
At Thu, 28 Sep 2006 19:45:50 -0400,
Quoted 7 lines · Florin Malita
snd_card_file_remove()may freehw->cardso we can't dereferencehw->card->moduleafter that.Coverity ID 1420.
Signed-off-by Florin Malita <[email protected]>
Thanks! Applied to ALSA tree now.
Takashi
Quoted 25 lines
---
sound/core/hwdep.c +2
-1@@ -158,6 +158,7 @@ static int snd_hwdep_release(struct inod {int err = -ENXIO ;struct snd_hwdep *hw = file->private_data; +struct module *mod = hw->card->module;mutex_lock (&hw->open_mutex);if (hw->ops.release) { err = hw->ops.release (hw, file);@@ -167,7 +168,7 @@ static int snd_hwdep_release(struct inod hw->used--;snd_card_file_remove (hw->card, file);mutex_unlock (&hw->open_mutex); -module_put (hw->card->module); +module_put (mod);return err; }