Skip to contentSkip to conversation

Dereference after free in snd_hwdep_release()

PATCH In review Florin Malita 2 participants 2 messages Sep 28, 2006 – Sep 29, 2006 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Dereference after free in snd_hwdep_release()

snd_card_file_remove() may free hw->card so we can't dereference hw->card->module after that.

Coverity ID 1420.

---

sound/core/hwdep.c +2 -1
index 9aa9d94..46b4768 100644
@@ -158,6 +158,7 @@ static int snd_hwdep_release(struct inod
 {
 	int err = -ENXIO;
 	struct snd_hwdep *hw = file->private_data;
+	struct module *mod = hw->card->module;
 	mutex_lock(&hw->open_mutex);
 	if (hw->ops.release) {
 		err = hw->ops.release(hw, file);
@@ -167,7 +168,7 @@ static int snd_hwdep_release(struct inod
 		hw->used--;
 	snd_card_file_remove(hw->card, file);
 	mutex_unlock(&hw->open_mutex);
-	module_put(hw->card->module);
+	module_put(mod);
 	return err;
 }
 
#1 lore raw

At Thu, 28 Sep 2006 19:45:50 -0400,

Quoted 7 lines · Florin Malita

snd_card_file_remove() may free hw->card so we can't dereference hw->card->module after that.

Coverity ID 1420.

Thanks! Applied to ALSA tree now.

Takashi

Quoted 25 lines

---

sound/core/hwdep.c +2 -1
index 9aa9d94..46b4768 100644
@@ -158,6 +158,7 @@ static int snd_hwdep_release(struct inod
 {
 	int err = -ENXIO;
 	struct snd_hwdep *hw = file->private_data;
+	struct module *mod = hw->card->module;
 	mutex_lock(&hw->open_mutex);
 	if (hw->ops.release) {
 		err = hw->ops.release(hw, file);
@@ -167,7 +168,7 @@ static int snd_hwdep_release(struct inod
 		hw->used--;
 	snd_card_file_remove(hw->card, file);
 	mutex_unlock(&hw->open_mutex);
-	module_put(hw->card->module);
+	module_put(mod);
 	return err;
 }