ALSA: hda - Change HP dv7 (103c:30f4) quirk from hp-m4 to hp-dv5 model
PATCH 1/1 ALSA: hda - Change HP dv7 (103c:30f4) quirk from hp-m4 to hp-dv5 model
Change HP dv7 quirk: although reported to work with hp-m4 model
(https://bugzilla.novell.com/show_bug.cgi?id=445321), the original report doesn't contain info about testing of internal microphone.
Recently I received a report about internal mic not working
(https://qa.mandriva.com/show_bug.cgi?id=44855#c193), this must be related with the forced line in on pin 0x0e done with hp-m4 model. Thus change the current quirk from STAC_HP_M4 to STAC_HP_DV5, later reported to be fixed on a provided kernel with this change
(https://qa.mandriva.com/show_bug.cgi?id=44855#c196).
--- sound/pci/hda/patch_sigmatel.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
sound/pci/hda/patch_sigmatel.c +1 -1
@@ -1811,7 +1811,7 @@ static struct snd_pci_quirk stac92hd71bxx_cfg_tbl[] = {SND_PCI_QUIRK (PCI_VENDOR_ID_HP ,0x30f2 ,"HP dv5" ,STAC_HP_M4 ),SND_PCI_QUIRK (PCI_VENDOR_ID_HP ,0x30f4 , -"HP dv7" ,STAC_HP_M4 ), +"HP dv7" ,STAC_HP_DV5 ),SND_PCI_QUIRK (PCI_VENDOR_ID_HP ,0x30f7 ,"HP dv4" ,STAC_HP_DV5 ), SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x30fc,
Signature · 1 line
1.6.1.3
At Thu, 12 Feb 2009 17:27:27 -0200,
Quoted 5 lines · Herton Ronaldo Krzesinski
Change HP dv7 quirk: although reported to work with hp-m4 model
(https://bugzilla.novell.com/show_bug.cgi?id=445321), the original report doesn't contain info about testing of internal microphone.
Quoted 8 lines
Recently I received a report about internal mic not working
(https://qa.mandriva.com/show_bug.cgi?id=44855#c193), this must be related with the forced line in on pin0x0edone with hp-m4 model. Thus change the current quirk fromSTAC_HP_M4toSTAC_HP_DV5, later reported to be fixed on a provided kernel with this change
(https://qa.mandriva.com/show_bug.cgi?id=44855#c196).Signed-off-by Herton Ronaldo Krzesinski <[email protected]>
Applied now. Thanks.
I guess we can change all 0x30f* entries. Though, I'm a bit conservative to change 2.6.29 code at this stage. Maybe we should first change the code for the next kernel using SND_PCI_QUIRK_MASK().
Takashi
Quoted 25 lines
--- sound/pci/hda/patch_sigmatel.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)sound/pci/hda/patch_sigmatel.c +1
-1@@ -1811,7 +1811,7 @@ static struct snd_pci_quirk stac92hd71bxx_cfg_tbl[] = {SND_PCI_QUIRK (PCI_VENDOR_ID_HP ,0x30f2 ,"HP dv5" ,STAC_HP_M4 ),SND_PCI_QUIRK (PCI_VENDOR_ID_HP ,0x30f4 , -"HP dv7" ,STAC_HP_M4 ), +"HP dv7" ,STAC_HP_DV5 ),SND_PCI_QUIRK (PCI_VENDOR_ID_HP ,0x30f7 ,"HP dv4" ,STAC_HP_DV5 ), SND_PCI_QUIRK(PCI_VENDOR_ID_HP, 0x30fc,Signature · 6 lines
1.6.1.3 _______________________________________________ Alsa-devel mailing list [email protected] http://mailman.alsa-project.org/mailman/listinfo/alsa-devel