Skip to contentSkip to conversation

dt-bindings: crypto: qcom,inline-crypto-engine: Add IPQ5210, IPQ5424 and IPQ9650

PATCH Superseded Varadarajan Narayanan 3 participants 3 messages Oct 16

Subsystems (4)
Device tree bindings Arm Qualcomm mailing list Crypto API Qualcomm inline crypto engine driver

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Varadarajan Narayanan

author
#0 lore raw

PATCH 1/1 dt-bindings: crypto: qcom,inline-crypto-engine: Add IPQ5210, IPQ5424 and IPQ9650

Document the Inline Crypto Engine compatibles for the Qualcomm IPQ5210, IPQ5424 and IPQ9650 SoCs.

Separate the power-domains requirement from the two-clock requirement. IPQ5210/IPQ5424/IPQ9650 require two clocks but intentionally do not require power-domains because they have no RPM.

Preserve the existing requirements for other platforms.

Signed-off-by Varadarajan Narayanan <[email protected]>
---
 .../bindings/crypto/qcom,inline-crypto-engine.yaml | 27 +++++++++++++++++++++-
 1 file changed, 26 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml +26 -1
index 23bf98c2b9fa..e838694bb70a 100644
@@ -15,6 +15,9 @@ properties:
       - enum:
           - qcom,eliza-inline-crypto-engine
           - qcom,hawi-inline-crypto-engine
+          - qcom,ipq5210-inline-crypto-engine
+          - qcom,ipq5424-inline-crypto-engine
+          - qcom,ipq9650-inline-crypto-engine
           - qcom,kaanapali-inline-crypto-engine
           - qcom,maili-inline-crypto-engine
           - qcom,milos-inline-crypto-engine

@@ -81,7 +84,6 @@ allOf:
 
     then:
       required:
-        - power-domains
         - clock-names
       properties:
         clocks:

@@ -89,6 +91,29 @@ allOf:
         clock-names:
           minItems: 2
 
+  - if:
+      not:
+        properties:
+          compatible:
+            contains:
+              enum:
+                - qcom,ipq5424-inline-crypto-engine
+                - qcom,ipq5210-inline-crypto-engine
+                - qcom,ipq9650-inline-crypto-engine
+                - qcom,kaanapali-inline-crypto-engine
+                - qcom,qcs8300-inline-crypto-engine
+                - qcom,sa8775p-inline-crypto-engine
+                - qcom,sc7180-inline-crypto-engine
+                - qcom,sc7280-inline-crypto-engine
+                - qcom,sm8450-inline-crypto-engine
+                - qcom,sm8550-inline-crypto-engine
+                - qcom,sm8650-inline-crypto-engine
+                - qcom,sm8750-inline-crypto-engine
+
+    then:
+      required:
+        - power-domains
+
 examples:
   - |
     #include <dt-bindings/clock/qcom,sm8550-gcc.h>

---
base-commit: 525d50941ea7764239624e4c22ef4d2658ab20b0
change-id: 20261016-ice-e1d8ba304436

Best regards,

Signature · 1 line
Varadarajan Narayanan <[email protected]>
AI review
#1 lore raw
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] dt-bindings: compatible strings in enum list are not sorted alphabetically --

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: compatible strings in enum list are not sorted alphabetically --

commit e22b78d683f92d3a3cc416d808b2c4da1c5e0341
Author: Varadarajan Narayanan <[email protected]>

dt-bindings: crypto: qcom,inline-crypto-engine: Add IPQ5210, IPQ5424 and IPQ9650

Document the Inline Crypto Engine compatibles for the Qualcomm IPQ5210, IPQ5424 and IPQ9650 SoCs. Separate the power-domains requirement from the two-clock requirement because these SoCs do not require power-domains. Preserve the existing requirements for other platforms.

Quoted 4 lines
Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml +0 -0
index 23bf98c2b9fa0..e838694bb70a8 100644

[ ... ]

Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml allOf: · line 101

Quoted 12 lines
Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml +8 -0
@@ -89,6 +91,29 @@ allOf:
         clock-names:
           minItems: 2
 
+  - if:
+      not:
+        properties:
+          compatible:
+            contains:
+              enum:
+                - qcom,ipq5424-inline-crypto-engine
+                - qcom,ipq5210-inline-crypto-engine

[Severity: Low]
This isn't a bug, but should these compatible strings be kept in alphabetical order? It looks like qcom,ipq5424-inline-crypto-engine was placed before qcom,ipq5210-inline-crypto-engine.

Quoted 3 lines
Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml +3 -0
+                - qcom,ipq9650-inline-crypto-engine
+                - qcom,kaanapali-inline-crypto-engine
+                - qcom,qcs8300-inline-crypto-engine

[ ... ]

Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
Reviewed-by on v1 1/1
#2 lore raw
In reply to Varadarajan Narayanan

Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml allOf: · line 101

Quoted 10 lines · Varadarajan Narayanan

minItems: 2

Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml +8 -0
+  - if:
+      not:
+        properties:
+          compatible:
+            contains:
+              enum:
+                - qcom,ipq5424-inline-crypto-engine
+                - qcom,ipq5210-inline-crypto-engine

Keep the list sorted.

With this fixed:

Reviewed-by Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof