cpu/hotplug: Fix cpuhp_step name for timers
PATCH v2 1/1 cpu/hotplug: Fix cpuhp_step name for timers
After commit 249d4a9b3246 ("timers: Reinitialize per cpu bases on hotplug") i.e introduction of state CPUHP_TIMERS_PREPARE instead of CPUHP_TIMERS_DEAD the cpuhp_step name "timers:dead" for timer looks to be invalid. So, better to name it as "timers:prepare".
---
Changes in v2:
- Updated commit text.
kernel/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/cpu.c +1 -1
@@ -1274,7 +1274,7 @@ static int __init cpu_hotplug_pm_sync_init(void)* otherwise a RCU stall occurs. */ [CPUHP_TIMERS_PREPARE] = { - .name = "timers:dead", + .name = "timers:prepare", .startup.single = timers_prepare_cpu, .teardown.single = timers_dead_cpu, },
Signature · 2 lines
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Hi All,
Can i get input on this ?
Thanks,
Mukesh
Quoted 33 lines · Mukesh Ojha
After commit
249d4a9b3246("timers: Reinitialize per cpu bases on hotplug") i.e introduction of stateCPUHP_TIMERS_PREPAREinstead ofCPUHP_TIMERS_DEADthecpuhp_stepname "timers:dead" for timer looks to be invalid. So, better to name it as "timers:prepare".Signed-off-by Mukesh Ojha <[email protected]>Cc Thomas Gleixner <[email protected]>Cc Peter Zijlstra <[email protected]>Cc Lai Jiangshan <[email protected]>Cc Ingo Molnar <[email protected]>Cc Brendan Jackman <[email protected]>Cc Mathieu Malaterre <[email protected]>---
Changes in v2:
- Updated commit text.kernel/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)kernel/cpu.c +1
-1@@ -1274,7 +1274,7 @@ static int __init cpu_hotplug_pm_sync_init(void)* otherwise a RCU stall occurs. */ [CPUHP_TIMERS_PREPARE] = { - .name = "timers:dead", + .name = "timers:prepare", .startup.single = timers_prepare_cpu, .teardown.single = timers_dead_cpu, },
Mukesh,
Quoted 3 lines · Mukesh Ojha
Hi All,
Can i get input on this ?
Sure.
Quoted 3 lines
Thanks,
Mukesh
On 7/24/2018 8:17 PM, Mukesh Ojha wrote:
The input you get is that it's unprofessional to poke people after TWO days about a patch which is purely cosmetic.
It's perfectly fine to send a reminder after a week for important changes and after two for trivial cleanups like this. You really cannot expect that maintainers and other developers permanentely sit there twiddling thumbs and wait for new mail to arrive in order to reply immediately.
Thanks,
tglx
Quoted 12 lines · Thomas Gleixner
Mukesh,
Quoted 3 lines · Mukesh Ojha
Hi All,
Can i get input on this ?
Sure.
Quoted 3 lines
Thanks,
Mukesh
On 7/24/2018 8:17 PM, Mukesh Ojha wrote:
Quoted 7 lines
The input you get is that it's unprofessional to poke people after TWO days about a patch which is purely cosmetic.
It's perfectly fine to send a reminder after a week for important changes and after two for trivial cleanups like this. You really cannot expect that maintainers and other developers permanentely sit there twiddling thumbs and wait for new mail to arrive in order to reply immediately.
Thanks for your patience and time in replying.
Will keep the patience :-)
Regards,
Mukesh
Quoted 5 lines
Thanks,
tglx
tip-bot for Mukesh Ojha
merge bot[tip:smp/hotplug] cpu/hotplug: Clarify CPU hotplug step name for timers
In reply to Mukesh Ojhacpu/hotplug: Clarify CPU hotplug step name for timers
Commit-ID: d018031f562b9c2eff038969ab1955a370c52d8f Gitweb: https://git.kernel.org/tip/d018031f562b9c2eff038969ab1955a370c52d8f Author: Mukesh Ojha <[email protected]> AuthorDate: Tue, 24 Jul 2018 20:17:48 +0530 Committer: Thomas Gleixner <[email protected]> CommitDate: Mon, 30 Jul 2018 21:30:52 +0200
cpu/hotplug: Clarify CPU hotplug step name for timers
After commit 249d4a9b3246 ("timers: Reinitialize per cpu bases on hotplug") i.e. the introduction of state CPUHP_TIMERS_PREPARE instead of CPUHP_TIMERS_DEAD the step name "timers:dead" is not longer accurate.
Rename it to "timers:prepare".
[ tglx: Massaged changelog ]
--- kernel/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/cpu.c +1 -1
@@ -1274,7 +1274,7 @@ static struct cpuhp_step cpuhp_hp_states[] = {* otherwise a RCU stall occurs. */ [CPUHP_TIMERS_PREPARE] = { - .name = "timers:dead", + .name = "timers:prepare", .startup.single = timers_prepare_cpu, .teardown.single = timers_dead_cpu, },