scsi: Mark expected switch fall-throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Addresses-Coverity-ID: 1056537 ("Missing break in switch")

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
 drivers/scsi/BusLogic.c | 1 +
 1 file changed, 1 insertion(+)

drivers/scsi/BusLogic.c +0 -0

index 9cee941f97d6..717eef3ee893 100644

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Notice that in this particular case, I replaced "Fall through to reject message" with a "fall through" annotation at the bottom of the case, which is what GCC is expecting to find.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
 drivers/scsi/NCR5380.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

drivers/scsi/NCR5380.c +0 -0

index 01c23d27f290..12073e52a0eb 100644
@@ -1933,12 +1933,11 @@ static void NCR5380_information_transfer(struct Scsi_Host *instance)
 					if (!hostdata->connected)
 						return;
 

I believe the 'if we get something weird' comment block relates to the default branch of the switch, _not_ the fall through from the case above (extended message received that we end up rejecting). Ordering the comments like you did just for GCC's sake is misleading.

The comment block should perhaps be moved after the default label. And it would be nice if the reason for the fall through could be retained in the comment.

-----Original Message-----
From: Gustavo A. R. Silva [mailto:[email protected]]
Sent: Tuesday, November 27, 2018 9:26 PM
To: Adaptec OEM Raid Solutions <[email protected]>
Cc: James E.J. Bottomley <[email protected]>; Martin K. Petersen <[email protected]>; [email protected]; linux- [email protected]; Gustavo A. R. Silva <[email protected]>
Subject: [PATCH 03/41] scsi: aacraid: aachba: Mark expected switch fall- throughs

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Also, a break statement is properly aligned.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

-----Original Message-----
From: Gustavo A. R. Silva [mailto:[email protected]]
Sent: Tuesday, November 27, 2018 9:26 PM
To: Adaptec OEM Raid Solutions <[email protected]>
Cc: James E.J. Bottomley <[email protected]>; Martin K. Petersen <[email protected]>; [email protected]; linux- [email protected]; Gustavo A. R. Silva <[email protected]>
Subject: [PATCH 04/41] scsi: aacraid: linit: Mark expected switch fall-through

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
 drivers/scsi/aacraid/linit.c | 1 +

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Notice that, in some cases, I replaced "FALLTHROUGH" with a "fall through" annotation and then placed it at the bottom of the corresponding switch case, which is what GCC is expecting to find.

Addresses-Coverity-ID: 114961 ("Missing break in switch")
Addresses-Coverity-ID: 114962 ("Missing break in switch")
Addresses-Coverity-ID: 114963 ("Missing break in switch")
Addresses-Coverity-ID: 114964 ("Missing break in switch")

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/scsi/aic7xxx/aic79xx_core.c | 14 +++++++++-----
  1 file changed, 9 insertions(+), 5 deletions(-)

drivers/scsi/aic7xxx/aic79xx_core.c +9 -5

index 9ee75c9a9aa1..7e5044bf05c0 100644
@@ -2285,6 +2285,7 @@ ahd_handle_seqint(struct ahd_softc *ahd, u_int intstat)
  			switch (scb->hscb->task_management) {
  			case SIU_TASKMGMT_ABORT_TASK:
  				tag = SCB_GET_TAG(scb);
+				/* fall through */
  			case SIU_TASKMGMT_ABORT_TASK_SET:
  			case SIU_TASKMGMT_CLEAR_TASK_SET:
  				lun = scb->hscb->lun;

@@ -2295,6 +2296,7 @@ ahd_handle_seqint(struct ahd_softc *ahd, u_int intstat)
  				break;
  			case SIU_TASKMGMT_LUN_RESET:
  				lun = scb->hscb->lun;
+				/* fall through */
  			case SIU_TASKMGMT_TARGET_RESET:
  			{
  				struct ahd_devinfo devinfo;

@@ -6550,8 +6552,8 @@ ahd_fini_scbdata(struct ahd_softc *ahd)
  			kfree(sns_map);
  		}
  		ahd_dma_tag_destroy(ahd, scb_data->sense_dmat);
-		/* FALLTHROUGH */
  	}
+		/* fall through */
  	case 6:
  	{
  		struct map_node *sg_map;

@@ -6565,8 +6567,8 @@ ahd_fini_scbdata(struct ahd_softc *ahd)
  			kfree(sg_map);
  		}
  		ahd_dma_tag_destroy(ahd, scb_data->sg_dmat);
-		/* FALLTHROUGH */
  	}
+		/* fall through */
  	case 5:
  	{
  		struct map_node *hscb_map;

@@ -7209,6 +7211,7 @@ ahd_init(struct ahd_softc *ahd)
  		case FLX_CSTAT_OVER:
  		case FLX_CSTAT_UNDER:
  			warn_user++;
+			/* fall through */
  		case FLX_CSTAT_INVALID:
  		case FLX_CSTAT_OKAY:
  			if (warn_user == 0 && bootverbose == 0)

@@ -8413,7 +8416,7 @@ ahd_search_scb_list(struct ahd_softc *ahd, int target, char channel,
  			if ((scb->flags & SCB_ACTIVE) == 0)
  				printk("Inactive SCB in Waiting List\n");
  			ahd_done_with_status(ahd, scb, status);
-			/* FALLTHROUGH */
+			/* fall through */
  		case SEARCH_REMOVE:
  			ahd_rem_wscb(ahd, scbid, prev, next, tid);
  			*list_tail = prev;

@@ -8422,6 +8425,7 @@ ahd_search_scb_list(struct ahd_softc *ahd, int target, char channel,
  			break;
  		case SEARCH_PRINT:
  			printk("0x%x ", scbid);
+			/* fall through */
  		case SEARCH_COUNT:
  			prev = scbid;
  			break;

@@ -9547,8 +9551,8 @@ ahd_download_instr(struct ahd_softc *ahd, u_int instrptr, uint8_t *dconsts)
  	{
  		fmt3_ins = &instr.format3;
  		fmt3_ins->address = ahd_resolve_seqaddr(ahd, fmt3_ins->address);
-		/* FALLTHROUGH */
  	}
+		/* fall through */
  	case AIC_OP_OR:
  	case AIC_OP_AND:
  	case AIC_OP_XOR:

@@ -9559,7 +9563,7 @@ ahd_download_instr(struct ahd_softc *ahd, u_int instrptr, uint8_t *dconsts)
  			fmt1_ins->immediate = dconsts[fmt1_ins->immediate];
  		}
  		fmt1_ins->parity = 0;
-		/* FALLTHROUGH */
+		/* fall through */
  	case AIC_OP_ROL:
  	{
  		int i, count;

Hi,

Friendly ping:

Who can ack or review this patch, please?

Thanks

Signature · 1 line

Gustavo

Quoted 101 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Notice that, in some cases, I replaced "FALLTHROUGH" with a "fall through" annotation and then placed it at the bottom of the corresponding switch case, which is what GCC is expecting to find.

Addresses-Coverity-ID: 114961 ("Missing break in switch")
Addresses-Coverity-ID: 114962 ("Missing break in switch")
Addresses-Coverity-ID: 114963 ("Missing break in switch")
Addresses-Coverity-ID: 114964 ("Missing break in switch")

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/scsi/aic7xxx/aic79xx_core.c | 14 +++++++++-----

  1 file changed, 9 insertions(+), 5 deletions(-)

drivers/scsi/aic7xxx/aic79xx_core.c +0 -0

index 9ee75c9a9aa1..7e5044bf05c0 100644
@@ -2285,6 +2285,7 @@ ahd_handle_seqint(struct ahd_softc *ahd, u_int intstat)
               switch (scb->hscb->task_management) {

              case SIU_TASKMGMT_ABORT_TASK:
                  tag = SCB_GET_TAG(scb);
+                /* fall through */
              case SIU_TASKMGMT_ABORT_TASK_SET:
              case SIU_TASKMGMT_CLEAR_TASK_SET:
                  lun = scb->hscb->lun;

drivers/scsi/aic7xxx/aic79xx_core.c +0 -0

@@ -2295,6 +2296,7 @@ ahd_handle_seqint(struct ahd_softc *ahd, u_int intstat)
                   break;

              case SIU_TASKMGMT_LUN_RESET:
                  lun = scb->hscb->lun;
+                /* fall through */
              case SIU_TASKMGMT_TARGET_RESET:
              {
                  struct ahd_devinfo devinfo;

drivers/scsi/aic7xxx/aic79xx_core.c +1 -1

@@ -6550,8 +6552,8 @@ ahd_fini_scbdata(struct ahd_softc *ahd)
               kfree(sns_map);
           }
           ahd_dma_tag_destroy(ahd, scb_data->sense_dmat);
-        /* FALLTHROUGH */
       }
+        /* fall through */

      case 6:
      {
          struct map_node *sg_map;

drivers/scsi/aic7xxx/aic79xx_core.c +1 -1

@@ -6565,8 +6567,8 @@ ahd_fini_scbdata(struct ahd_softc *ahd)
               kfree(sg_map);
           }
           ahd_dma_tag_destroy(ahd, scb_data->sg_dmat);
-        /* FALLTHROUGH */
       }
+        /* fall through */

      case 5:
      {
          struct map_node *hscb_map;

drivers/scsi/aic7xxx/aic79xx_core.c +0 -0

@@ -7209,6 +7211,7 @@ ahd_init(struct ahd_softc *ahd)

          case FLX_CSTAT_OVER:
          case FLX_CSTAT_UNDER:
              warn_user++;
+            /* fall through */
          case FLX_CSTAT_INVALID:
          case FLX_CSTAT_OKAY:
              if (warn_user == 0 && bootverbose == 0)

drivers/scsi/aic7xxx/aic79xx_core.c +1 -1

@@ -8413,7 +8416,7 @@ ahd_search_scb_list(struct ahd_softc *ahd, int target, char channel,
               if ((scb->flags & SCB_ACTIVE) == 0)
                   printk("Inactive SCB in Waiting List\n");
               ahd_done_with_status(ahd, scb, status);
-            /* FALLTHROUGH */
+            /* fall through */

          case SEARCH_REMOVE:
              ahd_rem_wscb(ahd, scbid, prev, next, tid); *list_tail = prev;

drivers/scsi/aic7xxx/aic79xx_core.c +0 -0

@@ -8422,6 +8425,7 @@ ahd_search_scb_list(struct ahd_softc *ahd, int target, char channel,
               break;

          case SEARCH_PRINT:
              printk("0x%x ", scbid);
+            /* fall through */
          case SEARCH_COUNT:
              prev = scbid;
              break;

drivers/scsi/aic7xxx/aic79xx_core.c +1 -1

@@ -9547,8 +9551,8 @@ ahd_download_instr(struct ahd_softc *ahd, u_int instrptr, uint8_t *dconsts)
       {
           fmt3_ins = &instr.format3;
           fmt3_ins->address = ahd_resolve_seqaddr(ahd, fmt3_ins->address);
-        /* FALLTHROUGH */
       }
+        /* fall through */

      case AIC_OP_OR:
      case AIC_OP_AND:
      case AIC_OP_XOR:

drivers/scsi/aic7xxx/aic79xx_core.c +1 -1

@@ -9559,7 +9563,7 @@ ahd_download_instr(struct ahd_softc *ahd, u_int instrptr, uint8_t *dconsts)
               fmt1_ins->immediate = dconsts[fmt1_ins->immediate];
           }
           fmt1_ins->parity = 0;
-        /* FALLTHROUGH */
+        /* fall through */

      case AIC_OP_ROL:
      {
          int i, count;

Hi,

Friendly ping (second one):

Who can ack/review/take this patch, please?

Thanks

Signature · 1 line

Gustavo

Quoted 27 lines · Gustavo A. R. Silva

Hi,

Friendly ping:

Who can ack or review this patch, please?

Thanks

Signature · 1 line

Gustavo

Quoted 16 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Notice that, in some cases, I replaced "FALLTHROUGH" with a "fall through" annotation and then placed it at the bottom of the corresponding switch case, which is what GCC is expecting to find.

Addresses-Coverity-ID: 114961 ("Missing break in switch")
Addresses-Coverity-ID: 114962 ("Missing break in switch")
Addresses-Coverity-ID: 114963 ("Missing break in switch")
Addresses-Coverity-ID: 114964 ("Missing break in switch")

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/scsi/aic7xxx/aic79xx_core.c | 14 +++++++++-----

  1 file changed, 9 insertions(+), 5 deletions(-)

Quoted 3 lines

Friendly ping (second one):

Who can ack/review/take this patch, please?

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Notice that, in some cases, I replaced "FALLTHROUGH" with a "fall through" annotation and then placed it at the bottom of the corresponding switch case, which is what GCC is expecting to find.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/scsi/aic7xxx/aic7xxx_core.c | 12 +++++++++---
  1 file changed, 9 insertions(+), 3 deletions(-)

drivers/scsi/aic7xxx/aic7xxx_core.c +9 -3

index f3362f4ab16e..d4a7263e4b8f 100644
@@ -4920,24 +4920,30 @@ ahc_fini_scbdata(struct ahc_softc *ahc)
  		}
  		ahc_dma_tag_destroy(ahc, scb_data->sg_dmat);
  	}
+		/* fall through */
  	case 6:
  		ahc_dmamap_unload(ahc, scb_data->sense_dmat,
  				  scb_data->sense_dmamap);
+		/* fall through */
  	case 5:
  		ahc_dmamem_free(ahc, scb_data->sense_dmat, scb_data->sense,
  				scb_data->sense_dmamap);
  		ahc_dmamap_destroy(ahc, scb_data->sense_dmat,
  				   scb_data->sense_dmamap);
+		/* fall through */
  	case 4:
  		ahc_dma_tag_destroy(ahc, scb_data->sense_dmat);
+		/* fall through */
  	case 3:
  		ahc_dmamap_unload(ahc, scb_data->hscb_dmat,
  				  scb_data->hscb_dmamap);
+		/* fall through */
  	case 2:
  		ahc_dmamem_free(ahc, scb_data->hscb_dmat, scb_data->hscbs,
  				scb_data->hscb_dmamap);
  		ahc_dmamap_destroy(ahc, scb_data->hscb_dmat,
  				   scb_data->hscb_dmamap);
+		/* fall through */
  	case 1:
  		ahc_dma_tag_destroy(ahc, scb_data->hscb_dmat);
  		break;

@@ -6002,8 +6008,8 @@ ahc_search_qinfifo(struct ahc_softc *ahc, int target, char channel,
  				if ((scb->flags & SCB_ACTIVE) == 0)
  					printk("Inactive SCB in Waiting List\n");
  				ahc_done(ahc, scb);
-				/* FALLTHROUGH */
  			}
+				/* fall through */
  			case SEARCH_REMOVE:
  				next = ahc_rem_wscb(ahc, next, prev);
  				break;

@@ -7008,8 +7014,8 @@ ahc_download_instr(struct ahc_softc *ahc, u_int instrptr, uint8_t *dconsts)
  		}
  		address -= address_offset;
  		fmt3_ins->address = address;
-		/* FALLTHROUGH */
  	}
+		/* fall through */
  	case AIC_OP_OR:
  	case AIC_OP_AND:
  	case AIC_OP_XOR:

@@ -7035,7 +7041,7 @@ ahc_download_instr(struct ahc_softc *ahc, u_int instrptr, uint8_t *dconsts)
  			fmt1_ins->opcode = AIC_OP_AND;
  			fmt1_ins->immediate = 0xff;
  		}
-		/* FALLTHROUGH */
+		/* fall through */
  	case AIC_OP_ROL:
  		if ((ahc->features & AHC_ULTRA2) != 0) {
  			int i, count;

Hi,

Friendly ping:

Who can ack or review this patch, please?

Thanks

Signature · 1 line

Gustavo

Quoted 77 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Notice that, in some cases, I replaced "FALLTHROUGH" with a "fall through" annotation and then placed it at the bottom of the corresponding switch case, which is what GCC is expecting to find.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/scsi/aic7xxx/aic7xxx_core.c | 12 +++++++++---

  1 file changed, 9 insertions(+), 3 deletions(-)

drivers/scsi/aic7xxx/aic7xxx_core.c +1 -0

index f3362f4ab16e..d4a7263e4b8f 100644
@@ -4920,24 +4920,30 @@ ahc_fini_scbdata(struct ahc_softc *ahc)
           }
           ahc_dma_tag_destroy(ahc, scb_data->sg_dmat);
       }
+        /* fall through */

      case 6:
          ahc_dmamap_unload(ahc, scb_data->sense_dmat, scb_data->sense_dmamap);
+        /* fall through */
      case 5:
          ahc_dmamem_free(ahc, scb_data->sense_dmat, scb_data->sense, scb_data->sense_dmamap); ahc_dmamap_destroy(ahc, scb_data->sense_dmat, scb_data->sense_dmamap);
+        /* fall through */
      case 4:
          ahc_dma_tag_destroy(ahc, scb_data->sense_dmat); +        /* fall through */
      case 3:
          ahc_dmamap_unload(ahc, scb_data->hscb_dmat, scb_data->hscb_dmamap);
+        /* fall through */
      case 2:
          ahc_dmamem_free(ahc, scb_data->hscb_dmat, scb_data->hscbs, scb_data->hscb_dmamap); ahc_dmamap_destroy(ahc, scb_data->hscb_dmat, scb_data->hscb_dmamap);
+        /* fall through */
      case 1:
          ahc_dma_tag_destroy(ahc, scb_data->hscb_dmat); break;

drivers/scsi/aic7xxx/aic7xxx_core.c +1 -1

@@ -6002,8 +6008,8 @@ ahc_search_qinfifo(struct ahc_softc *ahc, int target, char channel,
                   if ((scb->flags & SCB_ACTIVE) == 0)
                       printk("Inactive SCB in Waiting List\n");
                   ahc_done(ahc, scb);
-                /* FALLTHROUGH */
               }
+                /* fall through */

              case SEARCH_REMOVE:
                  next = ahc_rem_wscb(ahc, next, prev); break;

drivers/scsi/aic7xxx/aic7xxx_core.c +1 -1

@@ -7008,8 +7014,8 @@ ahc_download_instr(struct ahc_softc *ahc, u_int instrptr, uint8_t *dconsts)
           }
           address -= address_offset;
           fmt3_ins->address = address;
-        /* FALLTHROUGH */
       }
+        /* fall through */

      case AIC_OP_OR:
      case AIC_OP_AND:
      case AIC_OP_XOR:

drivers/scsi/aic7xxx/aic7xxx_core.c +1 -1

@@ -7035,7 +7041,7 @@ ahc_download_instr(struct ahc_softc *ahc, u_int instrptr, uint8_t *dconsts)
               fmt1_ins->opcode = AIC_OP_AND;
               fmt1_ins->immediate = 0xff;
           }
-        /* FALLTHROUGH */
+        /* fall through */

      case AIC_OP_ROL:
          if ((ahc->features & AHC_ULTRA2) != 0) { int i, count;

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/scsi/be2iscsi/be_iscsi.c | 1 +
  1 file changed, 1 insertion(+)

drivers/scsi/be2iscsi/be_iscsi.c +1 -0

index 96b96e2ab91a..ed1bd369baa0 100644
@@ -679,6 +679,7 @@ int beiscsi_set_param(struct iscsi_cls_conn *cls_conn,
  	case ISCSI_PARAM_MAX_XMIT_DLENGTH:
  		if (conn->max_xmit_dlength > 65536)
  			conn->max_xmit_dlength = 65536;
+		/* fall through */
  	default:
  		return 0;
  	}

Hi,

Friendly ping:

Who can ack or review this patch, please?

Thanks

Signature · 1 line

Gustavo

Quoted 21 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/scsi/be2iscsi/be_iscsi.c | 1 +

  1 file changed, 1 insertion(+)

drivers/scsi/be2iscsi/be_iscsi.c +0 -0

index 96b96e2ab91a..ed1bd369baa0 100644
@@ -679,6 +679,7 @@ int beiscsi_set_param(struct iscsi_cls_conn *cls_conn,

      case ISCSI_PARAM_MAX_XMIT_DLENGTH:
          if (conn->max_xmit_dlength > 65536)
              conn->max_xmit_dlength = 65536;
+        /* fall through */
      default:
          return 0;
      }

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Addresses-Coverity-ID: 1357387 ("Missing break in switch")

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/scsi/be2iscsi/be_main.c | 1 +
  1 file changed, 1 insertion(+)

drivers/scsi/be2iscsi/be_main.c +1 -0

index effb6fc95af4..b6449da1320c 100644
@@ -1539,6 +1539,7 @@ beiscsi_hdl_get_handle(struct beiscsi_conn *beiscsi_conn,
  		break;
  	case UNSOL_DATA_DIGEST_ERROR_NOTIFY:
  		error = 1;
+		/* fall through */
  	case UNSOL_DATA_NOTIFY:
  		pasync_handle = pasync_ctx->async_entry[ci].data;
  		break;

Hi,

Friendly ping:

Who can ack or review this patch, please?

Thanks

Signature · 1 line

Gustavo

Quoted 22 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Addresses-Coverity-ID: 1357387 ("Missing break in switch")

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/scsi/be2iscsi/be_main.c | 1 +

  1 file changed, 1 insertion(+)

drivers/scsi/be2iscsi/be_main.c +0 -0

index effb6fc95af4..b6449da1320c 100644
@@ -1539,6 +1539,7 @@ beiscsi_hdl_get_handle(struct beiscsi_conn *beiscsi_conn,
           break;

      case UNSOL_DATA_DIGEST_ERROR_NOTIFY:
          error = 1;
+        /* fall through */
      case UNSOL_DATA_NOTIFY:
          pasync_handle = pasync_ctx->async_entry[ci].data; break;

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Notice that I replaced "Fall through !!!" with a "fall through" annotation, which is what GCC is expecting to find.

Addresses-Coverity-ID: 114971 ("Missing break in switch")

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/scsi/bfa/bfa_fcpim.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

drivers/scsi/bfa/bfa_fcpim.c +3 -3

index 2c85f5b1f9c1..7e996bcf026c 100644
@@ -2586,6 +2586,7 @@ bfa_ioim_send_ioreq(struct bfa_ioim_s *ioim)
  	case FCP_IODIR_RW:
  		bfa_stats(itnim, input_reqs);
  		bfa_stats(itnim, output_reqs);
+		/* fall through */
  	default:
  		bfi_h2i_set(m->mh, BFI_MC_IOIM_IO, 0, bfa_fn_lpu(ioim->bfa));
  	}

@@ -2820,6 +2821,7 @@ bfa_ioim_isr(struct bfa_s *bfa, struct bfi_msg_s *m)
 
  	case BFI_IOIM_STS_TIMEDOUT:
  		bfa_stats(ioim->itnim, iocomp_timedout);
+		/* fall through */
  	case BFI_IOIM_STS_ABORTED:
  		rsp->io_status = BFI_IOIM_STS_ABORTED;
  		bfa_stats(ioim->itnim, iocomp_aborted);

@@ -3215,9 +3217,7 @@ bfa_tskim_sm_cleanup_qfull(struct bfa_tskim_s *tskim,
  	switch (event) {
  	case BFA_TSKIM_SM_DONE:
  		bfa_reqq_wcancel(&tskim->reqq_wait);
-		/*
-		 * Fall through !!!
-		 */
+		/* fall through */
  	case BFA_TSKIM_SM_QRESUME:
  		bfa_sm_set_state(tskim, bfa_tskim_sm_cleanup);
  		bfa_tskim_send_abort(tskim);

Hi,

Friendly ping:

Who can ack or review this patch, please?

Thanks

Signature · 1 line

Gustavo

Quoted 43 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Notice that I replaced "Fall through !!!" with a "fall through" annotation, which is what GCC is expecting to find.

Addresses-Coverity-ID: 114971 ("Missing break in switch")

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/scsi/bfa/bfa_fcpim.c | 6 +++---

  1 file changed, 3 insertions(+), 3 deletions(-)

drivers/scsi/bfa/bfa_fcpim.c +0 -0

index 2c85f5b1f9c1..7e996bcf026c 100644
@@ -2586,6 +2586,7 @@ bfa_ioim_send_ioreq(struct bfa_ioim_s *ioim)

      case FCP_IODIR_RW:
          bfa_stats(itnim, input_reqs);
          bfa_stats(itnim, output_reqs);
+        /* fall through */
      default:
          bfi_h2i_set(m->mh, BFI_MC_IOIM_IO, 0, bfa_fn_lpu(ioim->bfa)); }

drivers/scsi/bfa/bfa_fcpim.c +0 -0

@@ -2820,6 +2821,7 @@ bfa_ioim_isr(struct bfa_s *bfa, struct bfi_msg_s *m)

      case BFI_IOIM_STS_TIMEDOUT:
          bfa_stats(ioim->itnim, iocomp_timedout); +        /* fall through */
      case BFI_IOIM_STS_ABORTED:
          rsp->io_status = BFI_IOIM_STS_ABORTED; bfa_stats(ioim->itnim, iocomp_aborted);

drivers/scsi/bfa/bfa_fcpim.c +0 -0

@@ -3215,9 +3217,7 @@ bfa_tskim_sm_cleanup_qfull(struct bfa_tskim_s *tskim,
       switch (event) {

      case BFA_TSKIM_SM_DONE:
          bfa_reqq_wcancel(&tskim->reqq_wait); -        /*
-         * Fall through !!!
-         */
+        /* fall through */
      case BFA_TSKIM_SM_QRESUME:
          bfa_sm_set_state(tskim, bfa_tskim_sm_cleanup); bfa_tskim_send_abort(tskim);

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Notice that, in this particular case, I replaced "!!! fall through !!!" with a "fall through" annotation, which is what GCC is expecting to find.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/scsi/bfa/bfa_fcs_lport.c | 8 ++------
  1 file changed, 2 insertions(+), 6 deletions(-)

drivers/scsi/bfa/bfa_fcs_lport.c +2 -6

index b4f2c1d8742e..646f09f66443 100644
@@ -6430,9 +6430,7 @@ bfa_fcs_vport_sm_logo_for_stop(struct bfa_fcs_vport_s *vport,
  	switch (event) {
  	case BFA_FCS_VPORT_SM_OFFLINE:
  		bfa_sm_send_event(vport->lps, BFA_LPS_SM_OFFLINE);
-		/*
-		 * !!! fall through !!!
-		 */
+		/* fall through */
 
  	case BFA_FCS_VPORT_SM_RSP_OK:
  	case BFA_FCS_VPORT_SM_RSP_ERROR:

@@ -6458,9 +6456,7 @@ bfa_fcs_vport_sm_logo(struct bfa_fcs_vport_s *vport,
  	switch (event) {
  	case BFA_FCS_VPORT_SM_OFFLINE:
  		bfa_sm_send_event(vport->lps, BFA_LPS_SM_OFFLINE);
-		/*
-		 * !!! fall through !!!
-		 */
+		/* fall through */
 
  	case BFA_FCS_VPORT_SM_RSP_OK:
  	case BFA_FCS_VPORT_SM_RSP_ERROR:

Hi,

Friendly ping:

Who can ack or review this patch, please?

Thanks

Signature · 1 line

Gustavo

Quoted 37 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Notice that, in this particular case, I replaced "!!! fall through !!!" with a "fall through" annotation, which is what GCC is expecting to find.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/scsi/bfa/bfa_fcs_lport.c | 8 ++------

  1 file changed, 2 insertions(+), 6 deletions(-)

drivers/scsi/bfa/bfa_fcs_lport.c +0 -0

index b4f2c1d8742e..646f09f66443 100644
@@ -6430,9 +6430,7 @@ bfa_fcs_vport_sm_logo_for_stop(struct bfa_fcs_vport_s *vport,
       switch (event) {

      case BFA_FCS_VPORT_SM_OFFLINE:
          bfa_sm_send_event(vport->lps, BFA_LPS_SM_OFFLINE); -        /*
-         * !!! fall through !!!
-         */
+        /* fall through */
      case BFA_FCS_VPORT_SM_RSP_OK:
      case BFA_FCS_VPORT_SM_RSP_ERROR:

drivers/scsi/bfa/bfa_fcs_lport.c +0 -0

@@ -6458,9 +6456,7 @@ bfa_fcs_vport_sm_logo(struct bfa_fcs_vport_s *vport,
       switch (event) {

      case BFA_FCS_VPORT_SM_OFFLINE:
          bfa_sm_send_event(vport->lps, BFA_LPS_SM_OFFLINE); -        /*
-         * !!! fall through !!!
-         */
+        /* fall through */
      case BFA_FCS_VPORT_SM_RSP_OK:
      case BFA_FCS_VPORT_SM_RSP_ERROR:

Hi,

Friendly ping:

Who can ack or review this patch, please?

Thanks
--
Gustavo

Quoted 30 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Notice that, in this particular case, I replaced "!!! fall through !!!" with a "fall through" annotation, which is what GCC is expecting to find.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/scsi/bfa/bfa_fcs_lport.c | 8 ++------
  1 file changed, 2 insertions(+), 6 deletions(-)

drivers/scsi/bfa/bfa_fcs_lport.c +1 -3

index b4f2c1d8742e..646f09f66443 100644
@@ -6430,9 +6430,7 @@ bfa_fcs_vport_sm_logo_for_stop(struct bfa_fcs_vport_s *vport,
      switch (event) {
      case BFA_FCS_VPORT_SM_OFFLINE:
          bfa_sm_send_event(vport->lps, BFA_LPS_SM_OFFLINE);
-        /*
-         * !!! fall through !!!
-         */
+        /* fall through */
      case BFA_FCS_VPORT_SM_RSP_OK:
      case BFA_FCS_VPORT_SM_RSP_ERROR:

@@ -6458,9 +6456,7 @@ bfa_fcs_vport_sm_logo(struct bfa_fcs_vport_s *vport,
      switch (event) {
      case BFA_FCS_VPORT_SM_OFFLINE:

drivers/scsi/bfa/bfa_fcs_lport.c bfa_fcs_vport_sm_logo_for_stop(struct bfa_fcs_vport_s *vport,

Quoted 8 lines

drivers/scsi/bfa/bfa_fcs_lport.c +1 -3

          bfa_sm_send_event(vport->lps, BFA_LPS_SM_OFFLINE);
-        /*
-         * !!! fall through !!!
-         */
+        /* fall through */
      case BFA_FCS_VPORT_SM_RSP_OK:
      case BFA_FCS_VPORT_SM_RSP_ERROR:
 

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Notice that I replaced "!! fall through !!" and "!!! fall through !!!" comments with "fall through" annotations, which is what GCC is expecting to find.

Addresses-Coverity-ID: 744899 ("Missing break in switch")
Addresses-Coverity-ID: 744900 ("Missing break in switch")
Addresses-Coverity-ID: 744901 ("Missing break in switch")

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/scsi/bfa/bfa_fcs_rport.c | 19 +++++++------------
  1 file changed, 7 insertions(+), 12 deletions(-)

drivers/scsi/bfa/bfa_fcs_rport.c +7 -12

index de50349a39ce..1e400f2aaece 100644
@@ -427,17 +427,13 @@ bfa_fcs_rport_sm_plogi(struct bfa_fcs_rport_s *rport, enum rport_event event)
 
  	case RPSM_EVENT_LOGO_RCVD:
  		bfa_fcs_rport_send_logo_acc(rport);
-		/*
-		 * !! fall through !!
-		 */
+		/* fall through */
  	case RPSM_EVENT_PRLO_RCVD:
  		if (rport->prlo == BFA_TRUE)
  			bfa_fcs_rport_send_prlo_acc(rport);
 
  		bfa_fcxp_discard(rport->fcxp);
-		/*
-		 * !! fall through !!
-		 */
+		/* fall through */
  	case RPSM_EVENT_FAILED:
  		if (rport->plogi_retries < BFA_FCS_RPORT_MAX_RETRIES) {
  			rport->plogi_retries++;

@@ -868,9 +864,7 @@ bfa_fcs_rport_sm_adisc_online(struct bfa_fcs_rport_s *rport,
  		 * At least go offline when a PLOGI is received.
  		 */
  		bfa_fcxp_discard(rport->fcxp);
-		/*
-		 * !!! fall through !!!
-		 */
+		/* fall through */
 
  	case RPSM_EVENT_FAILED:
  	case RPSM_EVENT_ADDRESS_CHANGE:

@@ -1056,6 +1050,7 @@ bfa_fcs_rport_sm_fc4_logosend(struct bfa_fcs_rport_s *rport,
 
  	case RPSM_EVENT_LOGO_RCVD:
  		bfa_fcs_rport_send_logo_acc(rport);
+		/* fall through */
  	case RPSM_EVENT_PRLO_RCVD:
  		if (rport->prlo == BFA_TRUE)
  			bfa_fcs_rport_send_prlo_acc(rport);

@@ -1144,9 +1139,7 @@ bfa_fcs_rport_sm_hcb_offline(struct bfa_fcs_rport_s *rport,
  			bfa_fcs_rport_send_plogiacc(rport, NULL);
  			break;
  		}
-		/*
-		 * !! fall through !!
-		 */
+		/* fall through */
 
  	case RPSM_EVENT_ADDRESS_CHANGE:
  		if (!bfa_fcs_lport_is_online(rport->port)) {

@@ -1303,6 +1296,7 @@ bfa_fcs_rport_sm_hcb_logosend(struct bfa_fcs_rport_s *rport,
 
  	case RPSM_EVENT_LOGO_RCVD:
  		bfa_fcs_rport_send_logo_acc(rport);
+		/* fall through */
  	case RPSM_EVENT_PRLO_RCVD:
  		if (rport->prlo == BFA_TRUE)
  			bfa_fcs_rport_send_prlo_acc(rport);

@@ -1346,6 +1340,7 @@ bfa_fcs_rport_sm_logo_sending(struct bfa_fcs_rport_s *rport,
 
  	case RPSM_EVENT_LOGO_RCVD:
  		bfa_fcs_rport_send_logo_acc(rport);
+		/* fall through */
  	case RPSM_EVENT_PRLO_RCVD:
  		if (rport->prlo == BFA_TRUE)
  			bfa_fcs_rport_send_prlo_acc(rport);

Hi,

Friendly ping:

Who can ack or review this patch, please?

Thanks

Signature · 1 line

Gustavo

Quoted 79 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Notice that I replaced "!! fall through !!" and "!!! fall through !!!" comments with "fall through" annotations, which is what GCC is expecting to find.

Addresses-Coverity-ID: 744899 ("Missing break in switch")
Addresses-Coverity-ID: 744900 ("Missing break in switch")
Addresses-Coverity-ID: 744901 ("Missing break in switch")

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/scsi/bfa/bfa_fcs_rport.c | 19 +++++++------------

  1 file changed, 7 insertions(+), 12 deletions(-)

drivers/scsi/bfa/bfa_fcs_rport.c +0 -0

index de50349a39ce..1e400f2aaece 100644
@@ -427,17 +427,13 @@ bfa_fcs_rport_sm_plogi(struct bfa_fcs_rport_s *rport, enum rport_event event)

      case RPSM_EVENT_LOGO_RCVD:
          bfa_fcs_rport_send_logo_acc(rport);
-        /*
-         * !! fall through !!
-         */
+        /* fall through */
      case RPSM_EVENT_PRLO_RCVD:
          if (rport->prlo == BFA_TRUE) bfa_fcs_rport_send_prlo_acc(rport); bfa_fcxp_discard(rport->fcxp);
-        /*
-         * !! fall through !!
-         */
+        /* fall through */
      case RPSM_EVENT_FAILED:
          if (rport->plogi_retries < BFA_FCS_RPORT_MAX_RETRIES) { rport->plogi_retries++;

drivers/scsi/bfa/bfa_fcs_rport.c +1 -3

@@ -868,9 +864,7 @@ bfa_fcs_rport_sm_adisc_online(struct bfa_fcs_rport_s *rport,
            * At least go offline when a PLOGI is received.
            */
           bfa_fcxp_discard(rport->fcxp);
-        /*
-         * !!! fall through !!!
-         */
+        /* fall through */

      case RPSM_EVENT_FAILED:
      case RPSM_EVENT_ADDRESS_CHANGE:

drivers/scsi/bfa/bfa_fcs_rport.c +0 -0

@@ -1056,6 +1050,7 @@ bfa_fcs_rport_sm_fc4_logosend(struct bfa_fcs_rport_s *rport,

      case RPSM_EVENT_LOGO_RCVD:
          bfa_fcs_rport_send_logo_acc(rport);
+        /* fall through */
      case RPSM_EVENT_PRLO_RCVD:
          if (rport->prlo == BFA_TRUE)
              bfa_fcs_rport_send_prlo_acc(rport);

drivers/scsi/bfa/bfa_fcs_rport.c +1 -3

@@ -1144,9 +1139,7 @@ bfa_fcs_rport_sm_hcb_offline(struct bfa_fcs_rport_s *rport,
               bfa_fcs_rport_send_plogiacc(rport, NULL);
               break;
           }
-        /*
-         * !! fall through !!
-         */
+        /* fall through */

      case RPSM_EVENT_ADDRESS_CHANGE:
          if (!bfa_fcs_lport_is_online(rport->port)) {

drivers/scsi/bfa/bfa_fcs_rport.c +0 -0

@@ -1303,6 +1296,7 @@ bfa_fcs_rport_sm_hcb_logosend(struct bfa_fcs_rport_s *rport,

      case RPSM_EVENT_LOGO_RCVD:
          bfa_fcs_rport_send_logo_acc(rport);
+        /* fall through */
      case RPSM_EVENT_PRLO_RCVD:
          if (rport->prlo == BFA_TRUE)
              bfa_fcs_rport_send_prlo_acc(rport);

drivers/scsi/bfa/bfa_fcs_rport.c +0 -0

@@ -1346,6 +1340,7 @@ bfa_fcs_rport_sm_logo_sending(struct bfa_fcs_rport_s *rport,

      case RPSM_EVENT_LOGO_RCVD:
          bfa_fcs_rport_send_logo_acc(rport);
+        /* fall through */
      case RPSM_EVENT_PRLO_RCVD:
          if (rport->prlo == BFA_TRUE)
              bfa_fcs_rport_send_prlo_acc(rport);

Hi,

Friendly ping:

Who can ack or review this patch, please?

Thanks
--
Gustavo

Quoted 72 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Notice that I replaced "!! fall through !!" and "!!! fall through !!!" comments with "fall through" annotations, which is what GCC is expecting to find.

Addresses-Coverity-ID: 744899 ("Missing break in switch")
Addresses-Coverity-ID: 744900 ("Missing break in switch")
Addresses-Coverity-ID: 744901 ("Missing break in switch")

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/scsi/bfa/bfa_fcs_rport.c | 19 +++++++------------
  1 file changed, 7 insertions(+), 12 deletions(-)

drivers/scsi/bfa/bfa_fcs_rport.c +2 -6

index de50349a39ce..1e400f2aaece 100644
@@ -427,17 +427,13 @@ bfa_fcs_rport_sm_plogi(struct bfa_fcs_rport_s *rport, enum rport_event event)
      case RPSM_EVENT_LOGO_RCVD:
          bfa_fcs_rport_send_logo_acc(rport);
-        /*
-         * !! fall through !!
-         */
+        /* fall through */
      case RPSM_EVENT_PRLO_RCVD:
          if (rport->prlo == BFA_TRUE)
              bfa_fcs_rport_send_prlo_acc(rport);
          bfa_fcxp_discard(rport->fcxp);
-        /*
-         * !! fall through !!
-         */
+        /* fall through */
      case RPSM_EVENT_FAILED:
          if (rport->plogi_retries < BFA_FCS_RPORT_MAX_RETRIES) {
              rport->plogi_retries++; @@ -868,9 +864,7 @@ 
 bfa_fcs_rport_sm_adisc_online(struct bfa_fcs_rport_s *rport,
           * At least go offline when a PLOGI is received.

           */
          bfa_fcxp_discard(rport->fcxp);

drivers/scsi/bfa/bfa_fcs_rport.c +5 -6

-        /*
-         * !!! fall through !!!
-         */
+        /* fall through */
      case RPSM_EVENT_FAILED:
      case RPSM_EVENT_ADDRESS_CHANGE:

@@ -1056,6 +1050,7 @@ bfa_fcs_rport_sm_fc4_logosend(struct bfa_fcs_rport_s *rport,
      case RPSM_EVENT_LOGO_RCVD:
          bfa_fcs_rport_send_logo_acc(rport);
+        /* fall through */
      case RPSM_EVENT_PRLO_RCVD:
          if (rport->prlo == BFA_TRUE)
              bfa_fcs_rport_send_prlo_acc(rport);

@@ -1144,9 +1139,7 @@ bfa_fcs_rport_sm_hcb_offline(struct bfa_fcs_rport_s *rport,
              bfa_fcs_rport_send_plogiacc(rport, NULL);
              break;
          }
-        /*
-         * !! fall through !!
-         */
+        /* fall through */
      case RPSM_EVENT_ADDRESS_CHANGE:
          if (!bfa_fcs_lport_is_online(rport->port)) { @@ -1303,6 
+1296,7 @@ bfa_fcs_rport_sm_hcb_logosend(struct bfa_fcs_rport_s *rport,
      case RPSM_EVENT_LOGO_RCVD:
          bfa_fcs_rport_send_logo_acc(rport);
+        /* fall through */
      case RPSM_EVENT_PRLO_RCVD:
          if (rport->prlo == BFA_TRUE)
              bfa_fcs_rport_send_prlo_acc(rport);

drivers/scsi/bfa/bfa_fcs_rport.c bfa_fcs_rport_sm_logo_sending(struct bfa_fcs_rport_s *rport, · line 1346

Quoted 8 lines

drivers/scsi/bfa/bfa_fcs_rport.c +1 -0

@@ -1346,6 +1340,7 @@ bfa_fcs_rport_sm_logo_sending(struct bfa_fcs_rport_s *rport,
      case RPSM_EVENT_LOGO_RCVD:
          bfa_fcs_rport_send_logo_acc(rport);
+        /* fall through */
      case RPSM_EVENT_PRLO_RCVD:
          if (rport->prlo == BFA_TRUE)
              bfa_fcs_rport_send_prlo_acc(rport);
 

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Notice that, in this particular case, I replaced "!!! fall through !!!" comment with "fall through" annotations, which is what GCC is expecting to find.

Addresses-Coverity-ID: 146155 ("Missing break in switch")

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/scsi/bfa/bfa_ioc.c | 9 +++------
  1 file changed, 3 insertions(+), 6 deletions(-)

drivers/scsi/bfa/bfa_ioc.c +3 -6

index 16d3aeb0e572..32b24e51cce6 100644
@@ -978,9 +978,7 @@ bfa_iocpf_sm_enabling(struct bfa_iocpf_s *iocpf, enum iocpf_event event)
 
  	case IOCPF_E_INITFAIL:
  		bfa_iocpf_timer_stop(ioc);
-		/*
-		 * !!! fall through !!!
-		 */
+		/* fall through */
 
  	case IOCPF_E_TIMEOUT:
  		writel(1, ioc->ioc_regs.ioc_sem_reg);

@@ -1056,9 +1054,7 @@ bfa_iocpf_sm_disabling(struct bfa_iocpf_s *iocpf, enum iocpf_event event)
 
  	case IOCPF_E_FAIL:
  		bfa_iocpf_timer_stop(ioc);
-		/*
-		 * !!! fall through !!!
-		 */
+		/* fall through */
 
  	case IOCPF_E_TIMEOUT:
  		bfa_ioc_set_cur_ioc_fwstate(ioc, BFI_IOC_FAIL);

@@ -6007,6 +6003,7 @@ bfa_dconf_sm_final_sync(struct bfa_dconf_mod_s *dconf,
  	case BFA_DCONF_SM_IOCDISABLE:
  	case BFA_DCONF_SM_FLASH_COMP:
  		bfa_timer_stop(&dconf->timer);
+		/* fall through */
  	case BFA_DCONF_SM_TIMEOUT:
  		bfa_sm_set_state(dconf, bfa_dconf_sm_uninit);
  		bfa_fsm_send_event(&dconf->bfa->iocfc, IOCFC_E_DCONF_DONE);

Hi,

Friendly ping:

Who can ack or review this patch, please?

Thanks

Signature · 1 line

Gustavo

Quoted 44 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Notice that, in this particular case, I replaced "!!! fall through !!!" comment with "fall through" annotations, which is what GCC is expecting to find.

Addresses-Coverity-ID: 146155 ("Missing break in switch")

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/scsi/bfa/bfa_ioc.c | 9 +++------

  1 file changed, 3 insertions(+), 6 deletions(-)

drivers/scsi/bfa/bfa_ioc.c +0 -0

index 16d3aeb0e572..32b24e51cce6 100644
@@ -978,9 +978,7 @@ bfa_iocpf_sm_enabling(struct bfa_iocpf_s *iocpf, enum iocpf_event event)

      case IOCPF_E_INITFAIL:
          bfa_iocpf_timer_stop(ioc);
-        /*
-         * !!! fall through !!!
-         */
+        /* fall through */
      case IOCPF_E_TIMEOUT:
          writel(1, ioc->ioc_regs.ioc_sem_reg);

drivers/scsi/bfa/bfa_ioc.c +0 -0

@@ -1056,9 +1054,7 @@ bfa_iocpf_sm_disabling(struct bfa_iocpf_s *iocpf, enum iocpf_event event)

      case IOCPF_E_FAIL:
          bfa_iocpf_timer_stop(ioc);
-        /*
-         * !!! fall through !!!
-         */
+        /* fall through */
      case IOCPF_E_TIMEOUT:
          bfa_ioc_set_cur_ioc_fwstate(ioc, BFI_IOC_FAIL);

drivers/scsi/bfa/bfa_ioc.c +0 -0

@@ -6007,6 +6003,7 @@ bfa_dconf_sm_final_sync(struct bfa_dconf_mod_s *dconf,

      case BFA_DCONF_SM_IOCDISABLE:
      case BFA_DCONF_SM_FLASH_COMP:
          bfa_timer_stop(&dconf->timer);
+        /* fall through */
      case BFA_DCONF_SM_TIMEOUT:
          bfa_sm_set_state(dconf, bfa_dconf_sm_uninit); bfa_fsm_send_event(&dconf->bfa->iocfc, IOCFC_E_DCONF_DONE);

Hi,

Friendly ping:

Who can ack or review this patch, please?

Thanks
--
Gustavo

Quoted 36 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Notice that, in this particular case, I replaced "!!! fall through !!!" comment with "fall through" annotations, which is what GCC is expecting to find.

Addresses-Coverity-ID: 146155 ("Missing break in switch")

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/scsi/bfa/bfa_ioc.c | 9 +++------
  1 file changed, 3 insertions(+), 6 deletions(-)

drivers/scsi/bfa/bfa_ioc.c +1 -3

index 16d3aeb0e572..32b24e51cce6 100644
@@ -978,9 +978,7 @@ bfa_iocpf_sm_enabling(struct bfa_iocpf_s *iocpf, enum iocpf_event event)
      case IOCPF_E_INITFAIL:
          bfa_iocpf_timer_stop(ioc);
-        /*
-         * !!! fall through !!!
-         */
+        /* fall through */
      case IOCPF_E_TIMEOUT:
          writel(1, ioc->ioc_regs.ioc_sem_reg); @@ -1056,9 +1054,7 @@ 
 bfa_iocpf_sm_disabling(struct bfa_iocpf_s *iocpf, enum iocpf_event event)
      case IOCPF_E_FAIL:

          bfa_iocpf_timer_stop(ioc);

drivers/scsi/bfa/bfa_ioc.c +2 -3

-        /*
-         * !!! fall through !!!
-         */
+        /* fall through */
      case IOCPF_E_TIMEOUT:
          bfa_ioc_set_cur_ioc_fwstate(ioc, BFI_IOC_FAIL); @@ -6007,6 
+6003,7 @@ bfa_dconf_sm_final_sync(struct bfa_dconf_mod_s *dconf,

Quoted 8 lines

      case BFA_DCONF_SM_IOCDISABLE:
      case BFA_DCONF_SM_FLASH_COMP:
          bfa_timer_stop(&dconf->timer);
+        /* fall through */
      case BFA_DCONF_SM_TIMEOUT:
          bfa_sm_set_state(dconf, bfa_dconf_sm_uninit);
          bfa_fsm_send_event(&dconf->bfa->iocfc, IOCFC_E_DCONF_DONE);

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Addresses-Coverity-ID: 1056538 ("Missing break in switch")

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/scsi/csiostor/csio_wr.c | 1 +
  1 file changed, 1 insertion(+)

drivers/scsi/csiostor/csio_wr.c +1 -0

index dc12933533d5..b6861ea66c9f 100644
@@ -808,6 +808,7 @@ csio_wr_destroy_queues(struct csio_hw *hw, bool cmd)
 
  				csio_q_eqid(hw, i) = CSIO_MAX_QID;
  			}
+			/* fall through */
  		case CSIO_INGRESS:
  			if (csio_q_iqid(hw, i) != CSIO_MAX_QID) {
  				csio_wr_cleanup_iq_ftr(hw, i);

Hi,

Friendly ping:

Who can ack or review this patch, please?

Thanks

Signature · 1 line

Gustavo

Quoted 21 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Addresses-Coverity-ID: 1056538 ("Missing break in switch")

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/scsi/csiostor/csio_wr.c | 1 +

  1 file changed, 1 insertion(+)

drivers/scsi/csiostor/csio_wr.c +1 -0

index dc12933533d5..b6861ea66c9f 100644
@@ -808,6 +808,7 @@ csio_wr_destroy_queues(struct csio_hw *hw, bool cmd)
                   csio_q_eqid(hw, i) = CSIO_MAX_QID;
               }
+            /* fall through */

          case CSIO_INGRESS:
              if (csio_q_iqid(hw, i) != CSIO_MAX_QID) { csio_wr_cleanup_iq_ftr(hw, i);

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/scsi/esas2r/esas2r_init.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

drivers/scsi/esas2r/esas2r_init.c +2 -1

index 46b2c83ba21f..950cd92df2ff 100644
@@ -1241,6 +1241,7 @@ static bool esas2r_format_init_msg(struct esas2r_adapter *a,
  			a->init_msg = ESAS2R_INIT_MSG_GET_INIT;
  			break;
  		}
+		/* fall through */
 
  	case ESAS2R_INIT_MSG_GET_INIT:
  		if (msg == ESAS2R_INIT_MSG_GET_INIT) {

@@ -1254,7 +1255,7 @@ static bool esas2r_format_init_msg(struct esas2r_adapter *a,
  				esas2r_hdebug("FAILED");
  			}
  		}
-	/* fall through */
+		/* fall through */
 
  	default:
  		rq->req_stat = RS_SUCCESS;

Hi,

Friendly ping:

Who can ack or review this patch, please?

Thanks

Signature · 1 line

Gustavo

Quoted 28 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/scsi/esas2r/esas2r_init.c | 3 ++-

  1 file changed, 2 insertions(+), 1 deletion(-)

drivers/scsi/esas2r/esas2r_init.c +1 -0

index 46b2c83ba21f..950cd92df2ff 100644
@@ -1241,6 +1241,7 @@ static bool esas2r_format_init_msg(struct esas2r_adapter *a,
               a->init_msg = ESAS2R_INIT_MSG_GET_INIT;
               break;
           }
+        /* fall through */

      case ESAS2R_INIT_MSG_GET_INIT:
          if (msg == ESAS2R_INIT_MSG_GET_INIT) {

drivers/scsi/esas2r/esas2r_init.c +1 -1

@@ -1254,7 +1255,7 @@ static bool esas2r_format_init_msg(struct esas2r_adapter *a,
                   esas2r_hdebug("FAILED");
               }
           }
-    /* fall through */
+        /* fall through */

      default:
          rq->req_stat = RS_SUCCESS;

Hi,

Friendly ping (second one):

Who can ack/review/take this patch, please?

Thanks

Signature · 1 line

Gustavo

Quoted 41 lines · Gustavo A. R. Silva

Hi,

Friendly ping:

Who can ack or review this patch, please?

Thanks

Signature · 1 line

Gustavo

Quoted 27 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/scsi/esas2r/esas2r_init.c | 3 ++-

  1 file changed, 2 insertions(+), 1 deletion(-)

drivers/scsi/esas2r/esas2r_init.c +1 -0

index 46b2c83ba21f..950cd92df2ff 100644
@@ -1241,6 +1241,7 @@ static bool esas2r_format_init_msg(struct 
 esas2r_adapter *a,
               a->init_msg = ESAS2R_INIT_MSG_GET_INIT;
               break;
           }
+        /* fall through */

      case ESAS2R_INIT_MSG_GET_INIT:
          if (msg == ESAS2R_INIT_MSG_GET_INIT) {

drivers/scsi/esas2r/esas2r_init.c +1 -1

@@ -1254,7 +1255,7 @@ static bool esas2r_format_init_msg(struct 
 esas2r_adapter *a,
                   esas2r_hdebug("FAILED");
               }
           }
-    /* fall through */
+        /* fall through */

Quoted 3 lines

      default:
          rq->req_stat = RS_SUCCESS;

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Notice that, in this particular case, I placed all the "Phase N - ..." comments on the same line as its corresponding switch case. The same way in which similar comments appear in drivers/scsi/ppa.c. This makes it possible to place the "fall through" annotations at the bottom of each switch case, which is what GCC is expecting to find.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/scsi/imm.c | 33 +++++++++++++++++----------------
  1 file changed, 17 insertions(+), 16 deletions(-)

drivers/scsi/imm.c +17 -16

index 8c6627bc8a39..629e0bc70d3e 100644
@@ -796,21 +796,21 @@ static int imm_engine(imm_struct *dev, struct scsi_cmnd *cmd)
  			return 0;
  		}
  		return 1;	/* wait until imm_wakeup claims parport */
-		/* Phase 1 - Connected */
-	case 1:
+
+	case 1:		/* Phase 1 - Connected */
  		imm_connect(dev, CONNECT_EPP_MAYBE);
  		cmd->SCp.phase++;
+		/* fall through */
 
-		/* Phase 2 - We are now talking to the scsi bus */
-	case 2:
+	case 2:		/* Phase 2 - We are now talking to the scsi bus */
  		if (!imm_select(dev, scmd_id(cmd))) {
  			imm_fail(dev, DID_NO_CONNECT);
  			return 0;
  		}
  		cmd->SCp.phase++;
+		/* fall through */
 
-		/* Phase 3 - Ready to accept a command */
-	case 3:
+	case 3:		/* Phase 3 - Ready to accept a command */
  		w_ctr(ppb, 0x0c);
  		if (!(r_str(ppb) & 0x80))
  			return 1;

@@ -818,9 +818,9 @@ static int imm_engine(imm_struct *dev, struct scsi_cmnd *cmd)
  		if (!imm_send_command(cmd))
  			return 0;
  		cmd->SCp.phase++;
+		/* fall through */
 
-		/* Phase 4 - Setup scatter/gather buffers */
-	case 4:
+	case 4:		/* Phase 4 - Setup scatter/gather buffers */
  		if (scsi_bufflen(cmd)) {
  			cmd->SCp.buffer = scsi_sglist(cmd);
  			cmd->SCp.this_residual = cmd->SCp.buffer->length;

@@ -834,8 +834,9 @@ static int imm_engine(imm_struct *dev, struct scsi_cmnd *cmd)
  		cmd->SCp.phase++;
  		if (cmd->SCp.this_residual & 0x01)
  			cmd->SCp.this_residual++;
-		/* Phase 5 - Pre-Data transfer stage */
-	case 5:
+		/* fall through */
+
+	case 5:		/* Phase 5 - Pre-Data transfer stage */
  		/* Spin lock for BUSY */
  		w_ctr(ppb, 0x0c);
  		if (!(r_str(ppb) & 0x80))

@@ -850,9 +851,9 @@ static int imm_engine(imm_struct *dev, struct scsi_cmnd *cmd)
  			if (imm_negotiate(dev))
  				return 0;
  		cmd->SCp.phase++;
+		/* fall through */
 
-		/* Phase 6 - Data transfer stage */
-	case 6:
+	case 6:		/* Phase 6 - Data transfer stage */
  		/* Spin lock for BUSY */
  		w_ctr(ppb, 0x0c);
  		if (!(r_str(ppb) & 0x80))

@@ -866,9 +867,9 @@ static int imm_engine(imm_struct *dev, struct scsi_cmnd *cmd)
  				return 1;
  		}
  		cmd->SCp.phase++;
+		/* fall through */
 
-		/* Phase 7 - Post data transfer stage */
-	case 7:
+	case 7:		/* Phase 7 - Post data transfer stage */
  		if ((dev->dp) && (dev->rd)) {
  			if ((dev->mode == IMM_NIBBLE) || (dev->mode == IMM_PS2)) {
  				w_ctr(ppb, 0x4);

@@ -878,9 +879,9 @@ static int imm_engine(imm_struct *dev, struct scsi_cmnd *cmd)
  			}
  		}
  		cmd->SCp.phase++;
+		/* fall through */
 
-		/* Phase 8 - Read status/message */
-	case 8:
+	case 8:		/* Phase 8 - Read status/message */
  		/* Check for data overrun */
  		if (imm_wait(dev) != (unsigned char) 0xb8) {
  			imm_fail(dev, DID_ERROR);

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Notice that, in this particular case, I placed all the "Phase N - ..." comments on the same line as its corresponding switch case. The same way in which similar comments appear in drivers/scsi/ppa.c. This makes it possible to place the "fall through" annotations at the bottom of each switch case, which is what GCC is expecting to find.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/scsi/imm.c | 33 +++++++++++++++++----------------
  1 file changed, 17 insertions(+), 16 deletions(-)

drivers/scsi/imm.c +17 -16

index 8c6627bc8a39..629e0bc70d3e 100644
@@ -796,21 +796,21 @@ static int imm_engine(imm_struct *dev, struct scsi_cmnd *cmd)
  			return 0;
  		}
  		return 1;	/* wait until imm_wakeup claims parport */
-		/* Phase 1 - Connected */
-	case 1:
+
+	case 1:		/* Phase 1 - Connected */
  		imm_connect(dev, CONNECT_EPP_MAYBE);
  		cmd->SCp.phase++;
+		/* fall through */
 
-		/* Phase 2 - We are now talking to the scsi bus */
-	case 2:
+	case 2:		/* Phase 2 - We are now talking to the scsi bus */
  		if (!imm_select(dev, scmd_id(cmd))) {
  			imm_fail(dev, DID_NO_CONNECT);
  			return 0;
  		}
  		cmd->SCp.phase++;
+		/* fall through */
 
-		/* Phase 3 - Ready to accept a command */
-	case 3:
+	case 3:		/* Phase 3 - Ready to accept a command */
  		w_ctr(ppb, 0x0c);
  		if (!(r_str(ppb) & 0x80))
  			return 1;

@@ -818,9 +818,9 @@ static int imm_engine(imm_struct *dev, struct scsi_cmnd *cmd)
  		if (!imm_send_command(cmd))
  			return 0;
  		cmd->SCp.phase++;
+		/* fall through */
 
-		/* Phase 4 - Setup scatter/gather buffers */
-	case 4:
+	case 4:		/* Phase 4 - Setup scatter/gather buffers */
  		if (scsi_bufflen(cmd)) {
  			cmd->SCp.buffer = scsi_sglist(cmd);
  			cmd->SCp.this_residual = cmd->SCp.buffer->length;

@@ -834,8 +834,9 @@ static int imm_engine(imm_struct *dev, struct scsi_cmnd *cmd)
  		cmd->SCp.phase++;
  		if (cmd->SCp.this_residual & 0x01)
  			cmd->SCp.this_residual++;
-		/* Phase 5 - Pre-Data transfer stage */
-	case 5:
+		/* fall through */
+
+	case 5:		/* Phase 5 - Pre-Data transfer stage */
  		/* Spin lock for BUSY */
  		w_ctr(ppb, 0x0c);
  		if (!(r_str(ppb) & 0x80))

@@ -850,9 +851,9 @@ static int imm_engine(imm_struct *dev, struct scsi_cmnd *cmd)
  			if (imm_negotiate(dev))
  				return 0;
  		cmd->SCp.phase++;
+		/* fall through */
 
-		/* Phase 6 - Data transfer stage */
-	case 6:
+	case 6:		/* Phase 6 - Data transfer stage */
  		/* Spin lock for BUSY */
  		w_ctr(ppb, 0x0c);
  		if (!(r_str(ppb) & 0x80))

@@ -866,9 +867,9 @@ static int imm_engine(imm_struct *dev, struct scsi_cmnd *cmd)
  				return 1;
  		}
  		cmd->SCp.phase++;
+		/* fall through */
 
-		/* Phase 7 - Post data transfer stage */
-	case 7:
+	case 7:		/* Phase 7 - Post data transfer stage */
  		if ((dev->dp) && (dev->rd)) {
  			if ((dev->mode == IMM_NIBBLE) || (dev->mode == IMM_PS2)) {
  				w_ctr(ppb, 0x4);

@@ -878,9 +879,9 @@ static int imm_engine(imm_struct *dev, struct scsi_cmnd *cmd)
  			}
  		}
  		cmd->SCp.phase++;
+		/* fall through */
 
-		/* Phase 8 - Read status/message */
-	case 8:
+	case 8:		/* Phase 8 - Read status/message */
  		/* Check for data overrun */
  		if (imm_wait(dev) != (unsigned char) 0xb8) {
  			imm_fail(dev, DID_ERROR);

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Addresses-Coverity-ID: 703127 ("Missing break in switch")

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/scsi/isci/phy.c | 1 +
  1 file changed, 1 insertion(+)

drivers/scsi/isci/phy.c +1 -0

index 1deca8c5a94f..7f9b3f20e5e4 100644
@@ -778,6 +778,7 @@ enum sci_status sci_phy_event_handler(struct isci_phy *iphy, u32 event_code)
  			break;
  		case SCU_EVENT_LINK_FAILURE:
  			scu_link_layer_set_txcomsas_timeout(iphy, SCU_SAS_LINK_LAYER_TXCOMSAS_NEGTIME_DEFAULT);
+			/* fall through */
  		case SCU_EVENT_HARD_RESET_RECEIVED:
  			/* Start the oob/sn state machine over again */
  			sci_change_state(&iphy->sm, SCI_PHY_STARTING);

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Notice that, in this particular case, a dash is added as a token in order to separate the "fall through" annotations from the rest of the comment on the same line, which is what GCC is expecting to find.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/scsi/isci/remote_device.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

drivers/scsi/isci/remote_device.c +2 -2

index cc51f38b116d..9d29edb9f590 100644
@@ -310,7 +310,7 @@ static void isci_remote_device_not_ready(struct isci_host *ihost,
  		/* Kill all outstanding requests for the device. */
  		sci_remote_device_terminate_requests(idev);
 
-		/* Fall through into the default case... */
+		/* Fall through - into the default case... */
  	default:
  		clear_bit(IDEV_IO_READY, &idev->flags);
  		break;

@@ -593,7 +593,7 @@ enum sci_status sci_remote_device_event_handler(struct isci_remote_device *idev,
 
  			break;
  		}
-	/* Else, fall through and treat as unhandled... */
+		/* fall through - and treat as unhandled... */
  	default:
  		dev_dbg(scirdev_to_dev(idev),
  			"%s: device: %p event code: %x: %s\n",

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Notice that, in this particular case, a dash is added as a token in order to separate the "Fall through" annotations from the rest of the comment on the same line, which is what GCC is expecting to find.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/scsi/isci/remote_node_context.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

drivers/scsi/isci/remote_node_context.c +2 -2

index e3f2a5359d71..474a43460963 100644
@@ -601,9 +601,9 @@ enum sci_status sci_remote_node_context_suspend(
  				 __func__, sci_rnc);
  			return SCI_FAILURE_INVALID_STATE;
  		}
-		/* Fall through and handle like SCI_RNC_POSTING */
+		/* Fall through - and handle like SCI_RNC_POSTING */
  	case SCI_RNC_RESUMING:
-		/* Fall through and handle like SCI_RNC_POSTING */
+		/* Fall through - and handle like SCI_RNC_POSTING */
  	case SCI_RNC_POSTING:
  		/* Set the destination state to AWAIT - this signals the
  		 * entry into the SCI_RNC_READY state that a suspension

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Notice that, in this particular case, a dash is added as a token in order to separate the "Fall through" annotation from the rest of the comment on the same line, which is what GCC is expecting to find.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/scsi/isci/request.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

drivers/scsi/isci/request.c +1 -1

index 2f151708b59a..1b18cf55167e 100644
@@ -894,7 +894,7 @@ sci_io_request_terminate(struct isci_request *ireq)
  		 * and don't wait for the task response.
  		 */
  		sci_change_state(&ireq->sm, SCI_REQ_ABORTING);
-		/* Fall through and handle like ABORTING... */
+		/* Fall through - and handle like ABORTING... */
  	case SCI_REQ_ABORTING:
  		if (!isci_remote_device_is_safe_to_abort(ireq->target_device))
  			set_bit(IREQ_PENDING_ABORT, &ireq->flags);

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/scsi/lpfc/lpfc_ct.c | 2 ++
  1 file changed, 2 insertions(+)

drivers/scsi/lpfc/lpfc_ct.c +2 -0

index 6305ffeba7ea..b2b7fcc23654 100644
@@ -3050,6 +3050,7 @@ lpfc_fdmi_cmd(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp,
  	case SLI_MGMT_GHAT:
  	case SLI_MGMT_GRPL:
  		rsp_size = FC_MAX_NS_RSP;
+		/* fall through */
  	case SLI_MGMT_DHBA:
  	case SLI_MGMT_DHAT:
  		pe = (struct lpfc_fdmi_port_entry *)&CtReq->un.PortID;

@@ -3062,6 +3063,7 @@ lpfc_fdmi_cmd(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp,
  	case SLI_MGMT_GPAT:
  	case SLI_MGMT_GPAS:
  		rsp_size = FC_MAX_NS_RSP;
+		/* fall through */
  	case SLI_MGMT_DPRT:
  	case SLI_MGMT_DPA:
  		pe = (struct lpfc_fdmi_port_entry *)&CtReq->un.PortID;

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/scsi/lpfc/lpfc_ct.c | 2 ++
  1 file changed, 2 insertions(+)

drivers/scsi/lpfc/lpfc_ct.c +2 -0

index 6305ffeba7ea..b2b7fcc23654 100644
@@ -3050,6 +3050,7 @@ lpfc_fdmi_cmd(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp,
  	case SLI_MGMT_GHAT:
  	case SLI_MGMT_GRPL:
  		rsp_size = FC_MAX_NS_RSP;
+		/* fall through */
  	case SLI_MGMT_DHBA:
  	case SLI_MGMT_DHAT:
  		pe = (struct lpfc_fdmi_port_entry *)&CtReq->un.PortID;

@@ -3062,6 +3063,7 @@ lpfc_fdmi_cmd(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp,
  	case SLI_MGMT_GPAT:
  	case SLI_MGMT_GPAS:
  		rsp_size = FC_MAX_NS_RSP;
+		/* fall through */
  	case SLI_MGMT_DPRT:
  	case SLI_MGMT_DPA:
  		pe = (struct lpfc_fdmi_port_entry *)&CtReq->un.PortID;

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Addresses-Coverity-ID: 114978 ("Missing break in switch")

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/scsi/lpfc/lpfc_els.c | 1 +
  1 file changed, 1 insertion(+)

drivers/scsi/lpfc/lpfc_els.c +1 -0

index 5c34bfa624ef..1f20c35e0f84 100644
@@ -8649,6 +8649,7 @@ lpfc_cmpl_reg_new_vport(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmb)
  				lpfc_nlp_put(ndlp);
  				return;
  			}
+			/* fall through */
 
  		default:
  			/* Try to recover from this error */

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Addresses-Coverity-ID: 114978 ("Missing break in switch")

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/scsi/lpfc/lpfc_els.c | 1 +
  1 file changed, 1 insertion(+)

drivers/scsi/lpfc/lpfc_els.c +1 -0

index 5c34bfa624ef..1f20c35e0f84 100644
@@ -8649,6 +8649,7 @@ lpfc_cmpl_reg_new_vport(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmb)
  				lpfc_nlp_put(ndlp);
  				return;
  			}
+			/* fall through */
 
  		default:
  			/* Try to recover from this error */

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Notice that, in this particular case, I replaced "Drop thru" with a "fall through" annotation, which is what GCC is expecting to find.

Addresses-Coverity-ID: 114976 ("Missing break in switch")
Addresses-Coverity-ID: 114977 ("Missing break in switch")

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/scsi/lpfc/lpfc_hbadisc.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

drivers/scsi/lpfc/lpfc_hbadisc.c +3 -1

index 6c2fb55d739b..1a61806739ff 100644
@@ -4645,9 +4645,11 @@ lpfc_check_sli_ndlp(struct lpfc_hba *phba,
  		case CMD_GEN_REQUEST64_CR:
  			if (iocb->context_un.ndlp == ndlp)
  				return 1;
+			/* fall through */
  		case CMD_ELS_REQUEST64_CR:
  			if (icmd->un.elsreq64.remoteID == ndlp->nlp_DID)
  				return 1;
+			/* fall through */
  		case CMD_XMIT_ELS_RSP64_CX:
  			if (iocb->context1 == (uint8_t *) ndlp)
  				return 1;

@@ -5791,7 +5793,7 @@ lpfc_disc_timeout_handler(struct lpfc_vport *vport)
 
  	case LPFC_LINK_UP:
  		lpfc_issue_clear_la(phba, vport);
-		/* Drop thru */
+		/* fall through */
  	case LPFC_LINK_UNKNOWN:
  	case LPFC_WARM_START:
  	case LPFC_INIT_START:

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Notice that, in this particular case, I replaced "Drop thru" with a "fall through" annotation, which is what GCC is expecting to find.

Addresses-Coverity-ID: 114976 ("Missing break in switch")
Addresses-Coverity-ID: 114977 ("Missing break in switch")

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/scsi/lpfc/lpfc_hbadisc.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

drivers/scsi/lpfc/lpfc_hbadisc.c +3 -1

index 6c2fb55d739b..1a61806739ff 100644
@@ -4645,9 +4645,11 @@ lpfc_check_sli_ndlp(struct lpfc_hba *phba,
  		case CMD_GEN_REQUEST64_CR:
  			if (iocb->context_un.ndlp == ndlp)
  				return 1;
+			/* fall through */
  		case CMD_ELS_REQUEST64_CR:
  			if (icmd->un.elsreq64.remoteID == ndlp->nlp_DID)
  				return 1;
+			/* fall through */
  		case CMD_XMIT_ELS_RSP64_CX:
  			if (iocb->context1 == (uint8_t *) ndlp)
  				return 1;

@@ -5791,7 +5793,7 @@ lpfc_disc_timeout_handler(struct lpfc_vport *vport)
 
  	case LPFC_LINK_UP:
  		lpfc_issue_clear_la(phba, vport);
-		/* Drop thru */
+		/* fall through */
  	case LPFC_LINK_UNKNOWN:
  	case LPFC_WARM_START:
  	case LPFC_INIT_START:

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/scsi/lpfc/lpfc_nportdisc.c | 1 +
  1 file changed, 1 insertion(+)

drivers/scsi/lpfc/lpfc_nportdisc.c +1 -0

index 7d5693cfaa87..e8583496feaf 100644
@@ -360,6 +360,7 @@ lpfc_rcv_plogi(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp,
  	case  NLP_STE_NPR_NODE:
  		if (!(ndlp->nlp_flag & NLP_NPR_ADISC))
  			break;
+		/* fall through */
  	case  NLP_STE_REG_LOGIN_ISSUE:
  	case  NLP_STE_PRLI_ISSUE:
  	case  NLP_STE_UNMAPPED_NODE:

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/scsi/lpfc/lpfc_nvme.c | 1 +
  1 file changed, 1 insertion(+)

drivers/scsi/lpfc/lpfc_nvme.c +1 -0

index ba831def9301..942fe58c433d 100644
@@ -1115,6 +1115,7 @@ lpfc_nvme_io_cmd_wqe_cmpl(struct lpfc_hba *phba, struct lpfc_iocbq *pwqeIn,
  					 lpfc_ncmd, nCmd,
  					 lpfc_ncmd->cur_iocbq.sli4_xritag,
  					 bf_get(lpfc_wcqe_c_xb, wcqe));
+			/* fall through */
  		default:
  out_err:
  			lpfc_printf_vlog(vport, KERN_INFO, LOG_NVME_IOERR,

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/scsi/lpfc/lpfc_nvme.c | 1 +
  1 file changed, 1 insertion(+)

drivers/scsi/lpfc/lpfc_nvme.c +1 -0

index ba831def9301..942fe58c433d 100644
@@ -1115,6 +1115,7 @@ lpfc_nvme_io_cmd_wqe_cmpl(struct lpfc_hba *phba, struct lpfc_iocbq *pwqeIn,
  					 lpfc_ncmd, nCmd,
  					 lpfc_ncmd->cur_iocbq.sli4_xritag,
  					 bf_get(lpfc_wcqe_c_xb, wcqe));
+			/* fall through */
  		default:
  out_err:
  			lpfc_printf_vlog(vport, KERN_INFO, LOG_NVME_IOERR,

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Notice that, in this particular case, I replaced "Drop thru" with "fall through" annotations, which is what GCC is expecting to find.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/scsi/lpfc/lpfc_scsi.c | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)

drivers/scsi/lpfc/lpfc_scsi.c +4 -4

index baed2b891efb..0eeed6c4c2ee 100644
@@ -1427,7 +1427,7 @@ lpfc_bg_err_inject(struct lpfc_hba *phba, struct scsi_cmnd *sc,
 
  					break;
  				}
-				/* Drop thru */
+				/* fall through */
  			case SCSI_PROT_WRITE_INSERT:
  				/*
  				 * For WRITE_INSERT, force the error

@@ -1546,7 +1546,7 @@ lpfc_bg_err_inject(struct lpfc_hba *phba, struct scsi_cmnd *sc,
  					rc = BG_ERR_TGT | BG_ERR_CHECK;
  					break;
  				}
-				/* Drop thru */
+				/* fall through */
  			case SCSI_PROT_WRITE_INSERT:
  				/*
  				 * For WRITE_INSERT, force the

@@ -1628,7 +1628,7 @@ lpfc_bg_err_inject(struct lpfc_hba *phba, struct scsi_cmnd *sc,
  			switch (op) {
  			case SCSI_PROT_WRITE_PASS:
  				rc = BG_ERR_CHECK;
-				/* Drop thru */
+				/* fall through */
 
  			case SCSI_PROT_WRITE_INSERT:
  				/*

@@ -4115,7 +4115,7 @@ lpfc_scsi_cmd_iocb_cmpl(struct lpfc_hba *phba, struct lpfc_iocbq *pIocbIn,
  					lpfc_cmd->cur_iocbq.sli4_lxritag,
  					0, 0);
  			}
-		/* else: fall through */
+			/* fall through */
  		default:
  			cmd->result = DID_ERROR << 16;
  			break;

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Notice that, in this particular case, I replaced "Drop thru" with "fall through" annotations, which is what GCC is expecting to find.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
  drivers/scsi/lpfc/lpfc_scsi.c | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)

drivers/scsi/lpfc/lpfc_scsi.c +4 -4

index baed2b891efb..0eeed6c4c2ee 100644
@@ -1427,7 +1427,7 @@ lpfc_bg_err_inject(struct lpfc_hba *phba, struct scsi_cmnd *sc,
 
  					break;
  				}
-				/* Drop thru */
+				/* fall through */
  			case SCSI_PROT_WRITE_INSERT:
  				/*
  				 * For WRITE_INSERT, force the error

@@ -1546,7 +1546,7 @@ lpfc_bg_err_inject(struct lpfc_hba *phba, struct scsi_cmnd *sc,
  					rc = BG_ERR_TGT | BG_ERR_CHECK;
  					break;
  				}
-				/* Drop thru */
+				/* fall through */
  			case SCSI_PROT_WRITE_INSERT:
  				/*
  				 * For WRITE_INSERT, force the

@@ -1628,7 +1628,7 @@ lpfc_bg_err_inject(struct lpfc_hba *phba, struct scsi_cmnd *sc,
  			switch (op) {
  			case SCSI_PROT_WRITE_PASS:
  				rc = BG_ERR_CHECK;
-				/* Drop thru */
+				/* fall through */
 
  			case SCSI_PROT_WRITE_INSERT:
  				/*

@@ -4115,7 +4115,7 @@ lpfc_scsi_cmd_iocb_cmpl(struct lpfc_hba *phba, struct lpfc_iocbq *pIocbIn,
  					lpfc_cmd->cur_iocbq.sli4_lxritag,
  					0, 0);
  			}
-		/* else: fall through */
+			/* fall through */
  		default:
  			cmd->result = DID_ERROR << 16;
  			break;