Skip to content

SATA framework and Freescale SATA controller support

Dave Liu u-boot 5 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest posting 2/20 of 9 patches 0 repliesNew
  2. v4 posting 1/29 patches 0 repliesSuperseded
  3. v3 posting 2/20 of 10 patches 0 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v3 posting 1/210 patches0 repliesSuperseded
v29 patches0 repliesSuperseded

Patches in v4 posting 2/2 No applies recorded yet

None of the 9 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [U-Boot-Users] [PATCH v4 0/9] SATA framework and Freescale SATA controller support
Quoted 6 lines

Applied, but please provide new (incremental) patches to fix the following remaining issues:

doc/README.sata:

Please apply Jerry Van Baren's "proposed English polishing."

done.

Quoted 4 lines

drivers/block/ata_piix.h:

Please add a file header which contains appropriate copyright and license information.

The original include/sata.h have *not* any copyright and license information, I think it is better to keep the original state. so, I don't add the copyright/license info to ata_piix.h

Quoted 6 lines

Also, please make the file idempotent.

Also, please change format strings like "49==0x%04x" into "49=0x%04x" or "49 = 0x%04x" or (IMHO best) "49 = %04X". Please do this globally (some other files, too).

done.

Quoted 6 lines

drivers/block/fsl_sata.c:

Generic S-ATA code like ata_low_level_rw_lba48(), ata_low_level_rw_lba28(), sata_read(), sata_write(), or scan_sata() is in no way FSL-specific and thus has no place in fsl_sata.c; please move this into a separate file.

I will do it in next day.

Thanks,
Dave