Skip to contentSkip to conversation

SATA framework and Freescale SATA controller support patch set

PATCH Superseded Dave Liu 2 participants 5 messages Mar 26, 2008

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Dave Liu

author
#0 lore raw

v3 cover SATA framework and Freescale SATA controller support patch set

Dear Wolfgang,

According to your suggestion, I respined the patcheset. please apply it.

Thanks,
Dave

The following changes since commit 18e69a35efbb078403db0c0063986470dad7d082:
Anton Vorontsov (1):
83xx/fdt_support: let user specifiy FSL USB Dual-Role controller
role

are available in the git repository at:

git://git.ap.freescale.net/scm/u-boot.git develop

Dave Liu (10):
ata: merge the ata_piix driver
ata: add the support for SATA framework
ata: make the ata_piix driver using new SATA framework
ata: add the libata support
ata: add the fis struct for SATA
ata: enable the sata init on bootup
ata: add the readme for SATA command line
mpc83xx: initialize serdes for MPC837xEMDS boards
drivers: Add the support for Freescale SATA controller
mpc83xx: enable the SATA interface on mpc837xemds board

 board/freescale/mpc837xemds/mpc837xemds.c |   33 +
 common/Makefile                           |    2 +-
 common/cmd_sata.c                         |  768 +++
+--------------------
 disk/part.c                               |   14 +
 disk/part_dos.c                           |    2 +
 disk/part_iso.c                           |    2 +
 disk/part_mac.c                           |    1 +
 doc/README.sata                           |   69 +++
 drivers/block/Makefile                    |    2 +
 drivers/block/ata_piix.c                  |  585 ++++++++++++++++++-
 drivers/block/fsl_sata.c                  |  921 ++++++++++++++++++++++
+++++++
 drivers/block/fsl_sata.h                  |  374 ++++++++++++
 drivers/block/libata.c                    |  158 +++++
 include/configs/MPC837XEMDS.h             |   28 +
 include/configs/sc520_cdp.h               |   27 +-
 include/fis.h                             |  156 +++++
 include/libata.h                          |  207 +++++++
 include/part.h                            |    3 +
 include/sata.h                            |   20 +-
 lib_ppc/board.c                           |    8 +
 20 files changed, 2686 insertions(+), 694 deletions(-)
 create mode 100644 doc/README.sata
 create mode 100644 drivers/block/fsl_sata.c
 create mode 100644 drivers/block/fsl_sata.h
 create mode 100644 drivers/block/libata.c
 create mode 100644 include/fis.h
 create mode 100644 include/libata.h
#1 lore raw

v3 cover SATA framework and Freescale SATA controller support patch set

Dear Dave,

Quoted 2 lines · in message <[email protected]> you wrote:

mpc83xx: initialize serdes for MPC837xEMDS boards

...

Quoted 1 line

mpc83xx: enable the SATA interface on mpc837xemds board

Please run the 83xx specific stuff through the MPC83xx custodian. At least we need his ACK.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Our business is run on trust.  We trust you will pay in advance.
author
#2 lore raw

v3 cover SATA framework and Freescale SATA controller support patch set

Quoted 10 lines · Wolfgang Denk

Dear Dave,

Quoted 2 lines · in message <[email protected]> you wrote:

mpc83xx: initialize serdes for MPC837xEMDS boards

...

Quoted 1 line

mpc83xx: enable the SATA interface on mpc837xemds board

Please run the 83xx specific stuff through the MPC83xx custodian. At least we need his ACK.

The two patches is to Kim's tree. I'm 'to' Kim in email. Do you mean I should send another patch series to Kim?

Thanks,
Dave

#3 lore raw

v3 cover SATA framework and Freescale SATA controller support patch set

In reply to Dave Liu
Quoted 12 lines · In message <[email protected]> you wrote:

Dave Liu (10):
ata: merge the ata_piix driver
ata: add the support for SATA framework
ata: make the ata_piix driver using new SATA framework
ata: add the libata support
ata: add the fis struct for SATA
ata: enable the sata init on bootup
ata: add the readme for SATA command line
mpc83xx: initialize serdes for MPC837xEMDS boards
drivers: Add the support for Freescale SATA controller
mpc83xx: enable the SATA interface on mpc837xemds board

You don't mention anythiong about the sc520 board here, yet...

Quoted 9 lines
 board/freescale/mpc837xemds/mpc837xemds.c |   33 +
 common/Makefile                           |    2 +-
 common/cmd_sata.c                         |  768 +++
+--------------------
 disk/part.c                               |   14 +
 disk/part_dos.c                           |    2 +
 disk/part_iso.c                           |    2 +
 disk/part_mac.c                           |    1 +
 doc/README.sata                           |   69 +++
Quoted 8 lines
 drivers/block/Makefile                    |    2 +
 drivers/block/ata_piix.c                  |  585 ++++++++++++++++++-
 drivers/block/fsl_sata.c                  |  921 ++++++++++++++++++++++
+++++++
 drivers/block/fsl_sata.h                  |  374 ++++++++++++
 drivers/block/libata.c                    |  158 +++++
 include/configs/MPC837XEMDS.h             |   28 +
 include/configs/sc520_cdp.h               |   27 +-

...you're trying to sneak in configuration changes here.

Have these been tested?

If yes, then please split these off into a separate patch.

If not, then just dump it.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The first thing we do is kill all the lawyers.
(Shakespeare. II Henry VI, Act IV, scene ii)
author
#4 lore raw

v3 cover SATA framework and Freescale SATA controller support patch set

Quoted 11 lines
Quoted 10 lines

ata: merge the ata_piix driver
ata: add the support for SATA framework
ata: make the ata_piix driver using new SATA framework
ata: add the libata support
ata: add the fis struct for SATA
ata: enable the sata init on bootup
ata: add the readme for SATA command line
mpc83xx: initialize serdes for MPC837xEMDS boards
drivers: Add the support for Freescale SATA controller
mpc83xx: enable the SATA interface on mpc837xemds board

Quoted 1 line

You don't mention anythiong about the sc520 board here, yet...

Currently, the ata_piix driver only is used by sc520 board.

Quoted 18 lines
Quoted 9 lines
 board/freescale/mpc837xemds/mpc837xemds.c |   33 +
 common/Makefile                           |    2 +-
 common/cmd_sata.c                         |  768 +++
+--------------------
 disk/part.c                               |   14 +
 disk/part_dos.c                           |    2 +
 disk/part_iso.c                           |    2 +
 disk/part_mac.c                           |    1 +
 doc/README.sata                           |   69 +++
Quoted 8 lines
 drivers/block/Makefile                    |    2 +
 drivers/block/ata_piix.c                  |  585 ++++++++++++++++++-
 drivers/block/fsl_sata.c                  |  921 ++++++++++++++++++++++
+++++++
 drivers/block/fsl_sata.h                  |  374 ++++++++++++
 drivers/block/libata.c                    |  158 +++++
 include/configs/MPC837XEMDS.h             |   28 +
 include/configs/sc520_cdp.h               |   27 +-
Quoted 3 lines

...you're trying to sneak in configuration changes here.

Have these been tested?

I have not the sc520_cdp x86 board,
so I can not test it.

but building/compiling it is passed.

Quoted 3 lines

If yes, then please split these off into a separate patch.

If not, then just dump it.

dump it, sorry, what do you mean?

Thanks,
Dave